Report for github.com/AchoArnold/cracking-the-coding-interview
A+ Excellent! Found 48 issues across 245 files
gofmt99%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
cracking-the-coding-interview/chapter17/26_sparse_similarity_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo99%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
cracking-the-coding-interview/chapter16/19_pond_sizes.go
- Line 40: warning: cyclomatic complexity 18 of function PondSizesBruteForce() is high (> 15) (gocyclo)
golint83%
Golint is a linter for Go source code.
-
-
cracking-the-coding-interview/chapter5/3_flip_bit_to_win.go
- Line 5: warning: exported function LongestSequenceBruteForce should have comment or be unexported (golint)
- Line 14: warning: exported function FlipBit should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/12_paths_with_sum.go
- Line 3: warning: exported method BinaryTreeNode.CountPathsWithSum should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/3_level_linked_list.go
- Line 5: warning: exported function CreateLevelLinkedList should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/5_tree_is_valid_binary_search_tree.go
- Line 5: warning: exported method BinaryTreeNode.IsBinarySearchTree should have comment or be unexported (golint)
- Line 9: warning: exported method BinaryTreeNode.IsBinarySearchTreeWithMinMax should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/graph.go
- Line 3: warning: exported type Graph should have comment or be unexported (golint)
- Line 7: warning: exported type GraphNode should have comment or be unexported (golint)
- Line 12: warning: exported function StringToInterfaceSlice should have comment or be unexported (golint)
- Line 21: warning: exported function IntToInterfaceSlice should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter8/3_magic_first.go
- Line 5: warning: exported function MagicFirstBruteForce should have comment or be unexported (golint)
- Line 15: warning: exported function MagicBinarySearch should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/1_multi_stack_array.go
- Line 8: warning: comment on exported type MultiArrayStack should be of the form "MultiArrayStack ..." (with optional leading article) (golint)
- Line 18: warning: exported function NewMultiArrayStack should have comment or be unexported (golint)
- Line 27: warning: exported method MultiArrayStack.Pop should have comment or be unexported (golint)
- Line 31: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 39: warning: exported method MultiArrayStack.Push should have comment or be unexported (golint)
- Line 43: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 52: warning: exported method MultiArrayStack.Peek should have comment or be unexported (golint)
- Line 56: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 62: warning: exported method MultiArrayStack.IsEmpty should have comment or be unexported (golint)
- Line 67: warning: exported method MultiArrayStack.AssertStackIndexIsWithinRange should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/4_queue_with_stacks.go
- Line 7: warning: exported type QueueUsingStacks should have comment or be unexported (golint)
- Line 12: warning: exported method QueueUsingStacks.Add should have comment or be unexported (golint)
- Line 19: warning: exported method QueueUsingStacks.IsEmpty should have comment or be unexported (golint)
- Line 23: warning: exported method QueueUsingStacks.Remove should have comment or be unexported (golint)
- Line 52: warning: exported method QueueUsingStacks.Peek should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/stack.go
- Line 7: warning: exported type StackNode should have comment or be unexported (golint)
- Line 12: warning: exported type Stack should have comment or be unexported (golint)
- Line 16: warning: exported method Stack.Pop should have comment or be unexported (golint)
- Line 27: warning: exported method Stack.IsEmpty should have comment or be unexported (golint)
- Line 31: warning: exported method Stack.Push should have comment or be unexported (golint)
- Line 36: warning: exported method Stack.Peek should have comment or be unexported (golint)
- Line 44: warning: exported method Stack.Empty should have comment or be unexported (golint)
- Line 53: warning: exported method Stack.ToArray should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/7_build_order.go
- Line 7: warning: exported type DependencyGraph should have comment or be unexported (golint)
- Line 12: warning: exported method DependencyGraph.GetOrCreateNode should have comment or be unexported (golint)
- Line 22: warning: exported method DependencyGraph.AddEdge should have comment or be unexported (golint)
- Line 29: warning: exported method DependencyGraph.GetNodes should have comment or be unexported (golint)
- Line 33: warning: exported type Project should have comment or be unexported (golint)
- Line 40: warning: exported function CreateProject should have comment or be unexported (golint)
- Line 49: warning: exported method Project.AddNeighbour should have comment or be unexported (golint)
- Line 57: warning: exported method Project.GetName should have comment or be unexported (golint)
- Line 61: warning: exported method Project.GetChildren should have comment or be unexported (golint)
- Line 65: warning: exported method Project.GetNumberDependencies should have comment or be unexported (golint)
- Line 69: warning: exported method Project.IncrementDependencies should have comment or be unexported (golint)
- Line 73: warning: exported method Project.DecrementDependencies should have comment or be unexported (golint)
- Line 77: warning: exported function BuildGraph should have comment or be unexported (golint)
- Line 96: warning: exported function FindBuildOrder should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter2/6_is_palindrome.go
- Line 3: warning: exported method SinglyLinkedList.IsPalindrome should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter8/4_power_set.go
- Line 3: warning: exported function GetPowerSet should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter5/7_pair_wise_swap.go
- Line 3: warning: exported function SwapOddEvenBits should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter8/1_tripple_step.go
- Line 3: warning: exported function TripleStep should have comment or be unexported (golint)
- Line 34: warning: exported function TripleStepRecursive should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter8/2_robot_grid.go
- Line 3: warning: exported type Point should have comment or be unexported (golint)
- Line 8: warning: exported function GetPath should have comment or be unexported (golint)
- Line 75: warning: exported function NotIn should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter5/6_bit_swap_required.go
- Line 3: warning: exported function BitSwapRequired should have comment or be unexported (golint)
- Line 11: warning: exported function BitSwapRequiredLastSignificantBit should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/3_stack_of_plates.go
- Line 10: warning: exported type MultiDimensionalStack should have comment or be unexported (golint)
- Line 14: warning: exported type NodeStack should have comment or be unexported (golint)
- Line 18: warning: exported type LengthAwareStack should have comment or be unexported (golint)
- Line 23: warning: exported method MultiDimensionalStack.Push should have comment or be unexported (golint)
- Line 43: warning: exported method MultiDimensionalStack.IsEmpty should have comment or be unexported (golint)
- Line 47: warning: exported method MultiDimensionalStack.PopAt should have comment or be unexported (golint)
- Line 60: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 63: warning: exported method MultiDimensionalStack.Pop should have comment or be unexported (golint)
- Line 80: warning: exported method MultiDimensionalStack.Print should have comment or be unexported (golint)
- Line 101: warning: exported method MultiDimensionalStack.Peek should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/6_animal_shelter.go
- Line 8: warning: exported type Shelter should have comment or be unexported (golint)
- Line 12: warning: exported type AnimalNode should have comment or be unexported (golint)
- Line 17: warning: exported const TypeDog should have comment or be unexported (golint)
- Line 18: warning: exported const TypeCat should have comment or be unexported (golint)
- Line 20: warning: exported function GetNewShelter should have comment or be unexported (golint)
- Line 24: warning: exported method Shelter.Enqueue should have comment or be unexported (golint)
- Line 28: warning: exported method Shelter.IsEmpty should have comment or be unexported (golint)
- Line 32: warning: exported method Shelter.DequeueAny should have comment or be unexported (golint)
- Line 43: warning: exported method Shelter.DequeueDog should have comment or be unexported (golint)
- Line 61: warning: exported method Shelter.DequeueCat should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/10_contains_tree.go
- Line 3: warning: exported method BinaryTreeNode.ContainsTree should have comment or be unexported (golint)
- Line 10: warning: exported method BinaryTreeNode.HasSubTree should have comment or be unexported (golint)
- Line 22: warning: exported method BinaryTreeNode.MatchTree should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/1_route_exists.go
- Line 7: warning: exported method Graph.RouteExists should have comment or be unexported (golint)
- Line 35: warning: exported method Graph.GetNodeFromName should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter2/8_loop_detection.go
- Line 3: warning: exported method SinglyLinkedList.GetLoopingNode should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter2/singly_linked_list.go
- Line 7: warning: exported type SinglyLinkedList should have comment or be unexported (golint)
- Line 11: warning: exported type Node should have comment or be unexported (golint)
- Line 85: warning: exported method SinglyLinkedList.Count should have comment or be unexported (golint)
- Line 101: warning: exported method SinglyLinkedList.IsEmpty should have comment or be unexported (golint)
- Line 105: warning: exported method SinglyLinkedList.Clone should have comment or be unexported (golint)
- Line 121: warning: exported method SinglyLinkedList.Reverse should have comment or be unexported (golint)
- Line 135: warning: exported method SinglyLinkedList.Slice should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter5/2_print_binary.go
- Line 3: warning: exported function PrintBinaryRepresentationOfFloat should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/2_min_aware_stack.go
- Line 7: warning: exported type MinAwareStack should have comment or be unexported (golint)
- Line 12: warning: exported method MinAwareStack.Pop should have comment or be unexported (golint)
- Line 25: warning: exported method MinAwareStack.IsEmpty should have comment or be unexported (golint)
- Line 29: warning: exported method MinAwareStack.Push should have comment or be unexported (golint)
- Line 42: warning: exported method MinAwareStack.Min should have comment or be unexported (golint)
- Line 50: warning: exported method MinAwareStack.Peek should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/2_binary_tree_from_array.go
- Line 7: warning: exported function GetBinaryTreeFromSortedArray should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/8_comon_ancestor.go
- Line 5: warning: exported method ParentAwareBinaryTreeNode.CommonAncestor should have comment or be unexported (golint)
- Line 35: warning: exported function GoUpBy should have comment or be unexported (golint)
- Line 44: warning: exported function Depth should have comment or be unexported (golint)
- Line 67: warning: exported method ParentAwareBinaryTreeNode.GetNodesAsSlice should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/9_all_sequences.go
- Line 5: warning: exported method BinaryTreeNode.AllSequences should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter8/6_towers_of_hanoi.go
- Line 10: warning: exported type Tower should have comment or be unexported (golint)
- Line 15: warning: exported function NewTower should have comment or be unexported (golint)
- Line 22: warning: exported method Tower.Add should have comment or be unexported (golint)
- Line 24: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 31: warning: exported method Tower.MoveTopTo should have comment or be unexported (golint)
- Line 37: warning: exported method Tower.MoveDisks should have comment or be unexported (golint)
- Line 52: warning: exported function SolveForN3 should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/utils/testing_util.go
- Line 17: warning: exported function PrintMatrixToStdOut should have comment or be unexported (golint)
- Line 27: warning: exported function HandleError should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter5/1_update_bits.go
- Line 3: warning: exported function SetBitsInRange should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter5/4_next_number.go
- Line 3: warning: exported function GetNextNumberWithSame1Bits should have comment or be unexported (golint)
- Line 32: warning: exported function GetPreviousNumberWithSame1Bits should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter5/8_draw_line.go
- Line 3: warning: exported function DrawLine should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/5_sort_stack.go
- Line 3: warning: exported method Stack.Sort should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter3/queue.go
- Line 7: warning: exported type QueueNode should have comment or be unexported (golint)
- Line 12: warning: exported type Queue should have comment or be unexported (golint)
- Line 16: warning: exported method Queue.Add should have comment or be unexported (golint)
- Line 30: warning: exported method Queue.IsEmpty should have comment or be unexported (golint)
- Line 34: warning: exported method Queue.Remove should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/4_binary_tree_is_balanced.go
- Line 7: warning: exported method BinaryTreeNode.GetBinaryHeight should have comment or be unexported (golint)
- Line 15: warning: exported method BinaryTreeNode.IsBalanced should have comment or be unexported (golint)
- Line 29: warning: exported method BinaryTreeNode.CheckBalancedHeight should have comment or be unexported (golint)
- Line 52: warning: exported method BinaryTreeNode.IsBalancedUsingHeightCheck should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/6_in_order_successor.go
- Line 5: warning: exported type ParentAwareBinaryTreeNode should have comment or be unexported (golint)
- Line 30: warning: exported function CreatParentAwareBinarySearchTree should have comment or be unexported (golint)
- Line 34: warning: exported method ParentAwareBinaryTreeNode.InOrderSuccessor should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter4/11_random_selecting_tree.go
- Line 7: warning: exported type RandomTreeNode should have comment or be unexported (golint)
- Line 13: warning: exported function NewRandomTreeNode should have comment or be unexported (golint)
- Line 22: warning: exported method RandomTreeNode.GetRandomNode should have comment or be unexported (golint)
- Line 44: warning: exported method RandomTreeNode.InsertInOrder should have comment or be unexported (golint)
- Line 62: warning: exported method RandomTreeNode.Find should have comment or be unexported (golint)
- Line 70: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
cracking-the-coding-interview/chapter4/tree.go
- Line 3: warning: exported type BinaryTreeNode should have comment or be unexported (golint)
- Line 9: warning: exported function DepthFirstSearchBinaryTree should have comment or be unexported (golint)
-
-
cracking-the-coding-interview/chapter2/7_intersection.go
- Line 13: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 19: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
cracking-the-coding-interview/chapter8/5_recursive_multiply.go
- Line 3: warning: exported function RecursiveMultiply should have comment or be unexported (golint)
ineffassign99%
IneffAssign detects ineffectual assignments in Go code.
-
-
cracking-the-coding-interview/chapter4/12_paths_with_sum.go
- Line 27: warning: ineffectual assignment to pathCount (ineffassign)
misspell97%
Misspell Finds commonly misspelled English words
-
-
cracking-the-coding-interview/chapter17/26_sparse_similarity.go
- Line 3: warning: "arithmethic" is a misspelling of "arithmetic" (misspell)
-
-
cracking-the-coding-interview/chapter8/12_eight_queens.go
- Line 29: warning: "emtpy" is a misspelling of "empty" (misspell)
-
-
cracking-the-coding-interview/chapter8/9_valid_parens_test.go
- Line 10: warning: "paranthesis" is a misspelling of "parenthesis" (misspell)
- Line 14: warning: "paranthesis" is a misspelling of "parenthesis" (misspell)
- Line 18: warning: "paranthesis" is a misspelling of "parenthesis" (misspell)
-
-
cracking-the-coding-interview/chapter10/9_matrix_sort.go
- Line 7: warning: "teh" is a misspelling of "the" (misspell)
-
-
cracking-the-coding-interview/chapter16/10_max_year_alive.go
- Line 9: warning: "withing" is a misspelling of "within" (misspell)
-
-
cracking-the-coding-interview/chapter17/10_marjority_element_test.go
- Line 31: warning: "homogenious" is a misspelling of "homogeneous" (misspell)