Preparing report...

Report for github.com/AnalogJ/capsulecd

B    Not bad!    Found 66 issues across 77 files

Tweet

gofmt36%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint49%

Golint is a linter for Go source code.

    • capsulecd/pkg/errors/errors.go
    • Line 7: warning: comment on exported type ScmFilesystemError should be of the form "ScmFilesystemError ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported type ScmUnspecifiedError should be of the form "ScmUnspecifiedError ..." (with optional leading article) (golint)
    • Line 21: warning: comment on exported type ScmAuthenticationFailed should be of the form "ScmAuthenticationFailed ..." (with optional leading article) (golint)
    • Line 28: warning: comment on exported type ScmPayloadFormatError should be of the form "ScmPayloadFormatError ..." (with optional leading article) (golint)
    • Line 35: warning: comment on exported type ScmPayloadUnsupported should be of the form "ScmPayloadUnsupported ..." (with optional leading article) (golint)
    • Line 42: warning: comment on exported type ScmUnauthorizedUser should be of the form "ScmUnauthorizedUser ..." (with optional leading article) (golint)
    • Line 49: warning: comment on exported type ScmCleanupFailed should be of the form "ScmCleanupFailed ..." (with optional leading article) (golint)
    • Line 56: warning: comment on exported type ScmMergeNothingToMergeError should be of the form "ScmMergeNothingToMergeError ..." (with optional leading article) (golint)
    • Line 63: warning: comment on exported type ScmMergeConflictError should be of the form "ScmMergeConflictError ..." (with optional leading article) (golint)
    • Line 69: warning: comment on exported type ScmMergeAnalysisUnknownError should be of the form "ScmMergeAnalysisUnknownError ..." (with optional leading article) (golint)
    • Line 75: warning: comment on exported type EngineTransformUnavailableStep should be of the form "EngineTransformUnavailableStep ..." (with optional leading article) (golint)
    • Line 82: warning: comment on exported type EngineValidateToolError should be of the form "EngineValidateToolError ..." (with optional leading article) (golint)
    • Line 89: warning: comment on exported type EngineUnspecifiedError should be of the form "EngineUnspecifiedError ..." (with optional leading article) (golint)
    • Line 96: warning: comment on exported type EngineBuildPackageInvalid should be of the form "EngineBuildPackageInvalid ..." (with optional leading article) (golint)
    • Line 103: warning: comment on exported type EngineBuildPackageFailed should be of the form "EngineBuildPackageFailed ..." (with optional leading article) (golint)
    • Line 110: warning: comment on exported type EngineTestDependenciesError should be of the form "EngineTestDependenciesError ..." (with optional leading article) (golint)
    • Line 117: warning: comment on exported type EngineTestRunnerError should be of the form "EngineTestRunnerError ..." (with optional leading article) (golint)
    • Line 124: warning: comment on exported type MgrAssembleError should be of the form "MgrAssembleError ..." (with optional leading article) (golint)
    • Line 131: warning: comment on exported type MgrUnspecifiedError should be of the form "MgrUnspecifiedError ..." (with optional leading article) (golint)
    • Line 138: warning: comment on exported type MgrDistCredentialsMissing should be of the form "MgrDistCredentialsMissing ..." (with optional leading article) (golint)
    • Line 145: warning: comment on exported type MgrDistPackageError should be of the form "MgrDistPackageError ..." (with optional leading article) (golint)
    • capsulecd/pkg/utils/git.go
    • Line 19: warning: comment on exported function GitClone should be of the form "GitClone ..." (golint)
    • Line 35: warning: comment on exported function GitFetchPullRequest should be of the form "GitFetchPullRequest ..." (golint)
    • Line 135: warning: comment on exported function GitMergeRemoteBranch should be of the form "GitMergeRemoteBranch ..." (golint)
    • Line 347: warning: exported function GitCheckout should have comment or be unexported (golint)
    • Line 420: warning: comment on exported function GitCommit should be of the form "GitCommit ..." (golint)
    • Line 466: warning: exported function GitTag should have comment or be unexported (golint)
    • Line 494: warning: exported function GitPush should have comment or be unexported (golint)
    • Line 516: warning: comment on exported function GitFindNearestTagName should be of the form "GitFindNearestTagName ..." (golint)
    • Line 550: warning: exported function GitGenerateChangelog should have comment or be unexported (golint)
    • Line 591: warning: exported function GitGenerateGitIgnore should have comment or be unexported (golint)
    • Line 603: warning: exported function GitGetTagDetails should have comment or be unexported (golint)
    • Line 649: warning: exported function GitSignature should have comment or be unexported (golint)
    • capsulecd/pkg/utils/string.go
    • Line 9: warning: exported function PopulateTemplate should have comment or be unexported (golint)
    • Line 25: warning: exported function SnakeCaseToCamelCase should have comment or be unexported (golint)
    • Line 56: warning: exported function LeftPad should have comment or be unexported (golint)
    • Line 59: warning: exported function RightPad should have comment or be unexported (golint)
    • Line 79: warning: exported function RightPad2Len should have comment or be unexported (golint)
    • Line 84: warning: exported function LeftPad2Len should have comment or be unexported (golint)
    • Line 90: warning: exported function StripIndent should have comment or be unexported (golint)
    • capsulecd/pkg/pipeline/pipeline_scm_commit.go
    • Line 5: warning: exported type ScmRepoInfo should have comment or be unexported (golint)
    • Line 11: warning: exported type ScmCommitInfo should have comment or be unexported (golint)
    • Line 17: warning: comment on exported method ScmCommitInfo.Validate should be of the form "Validate ..." (golint)
    • capsulecd/pkg/utils/cmd.go
    • Line 17: warning: exported function BashCmdExec should have comment or be unexported (golint)
    • Line 21: warning: exported function CmdExec should have comment or be unexported (golint)
    • capsulecd/pkg/engine/engine_base.go
    • Line 81: warning: receiver name e should be consistent with previous receiver name g for engineBase (golint)
    • Line 100: warning: receiver name e should be consistent with previous receiver name g for engineBase (golint)
    • capsulecd/pkg/pipeline.go
    • Line 17: warning: exported type Pipeline should have comment or be unexported (golint)
    • Line 25: warning: exported method Pipeline.Start should have comment or be unexported (golint)
    • Line 109: warning: exported method Pipeline.PipelineInitStep should have comment or be unexported (golint)
    • Line 143: warning: exported method Pipeline.ScmRetrievePayloadStep should have comment or be unexported (golint)
    • Line 167: warning: exported method Pipeline.ScmCheckoutPullRequestStep should have comment or be unexported (golint)
    • Line 192: warning: exported method Pipeline.ScmCheckoutPushPayloadStep should have comment or be unexported (golint)
    • Line 217: warning: exported method Pipeline.ParseRepoConfig should have comment or be unexported (golint)
    • Line 242: warning: exported method Pipeline.MgrInitStep should have comment or be unexported (golint)
    • Line 260: warning: comment on exported method Pipeline.ValidateTools should be of the form "ValidateTools ..." (golint)
    • Line 266: warning: exported method Pipeline.MgrValidateTools should have comment or be unexported (golint)
    • Line 272: warning: comment on exported method Pipeline.AssembleStep should be of the form "AssembleStep ..." (golint)
    • Line 299: warning: comment on exported method Pipeline.MgrDependenciesStep should be of the form "MgrDependenciesStep ..." (golint)
    • Line 324: warning: comment on exported method Pipeline.CompileStep should be of the form "CompileStep ..." (golint)
    • Line 354: warning: comment on exported method Pipeline.TestStep should be of the form "TestStep ..." (golint)
    • Line 384: warning: comment on exported method Pipeline.PackageStep should be of the form "PackageStep ..." (golint)
    • Line 410: warning: comment on exported method Pipeline.MgrDistStep should be of the form "MgrDistStep ..." (golint)
    • Line 440: warning: exported method Pipeline.ScmPublishStep should have comment or be unexported (golint)
    • Line 469: warning: exported method Pipeline.ScmCleanupStep should have comment or be unexported (golint)
    • Line 500: warning: exported method Pipeline.StepExecNotify should have comment or be unexported (golint)
    • Line 509: warning: exported method Pipeline.Cleanup should have comment or be unexported (golint)
    • Line 520: warning: exported method Pipeline.RunHook should have comment or be unexported (golint)
    • capsulecd/pkg/config/config.go
    • Line 73: warning: don't use underscores in Go names; var config_data should be configData (golint)
    • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign89%

IneffAssign detects ineffectual assignments in Go code.


misspell94%

Misspell Finds commonly misspelled English words