Preparing report...

Report for github.com/AtlantPlatform/ethereum-playbook

A    Great!    Found 17 issues across 21 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo61%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • ethereum-playbook/model/params.go
    • Line 215: warning: cyclomatic complexity 42 of function parseParam() is high (> 15) (gocyclo)
    • Line 386: warning: cyclomatic complexity 37 of function createStaticBytes() is high (> 15) (gocyclo)
    • Line 40: warning: cyclomatic complexity 21 of function (*ParamSpec).validateParam() is high (> 15) (gocyclo)

golint23%

Golint is a linter for Go source code.

    • ethereum-playbook/model/params.go
    • Line 15: warning: exported type ParamSpec should have comment or be unexported (golint)
    • Line 21: warning: exported method ParamSpec.Validate should have comment or be unexported (golint)
    • Line 34: warning: exported method ParamSpec.ParamValues should have comment or be unexported (golint)
    • Line 38: warning: exported var PlaceholderAddr should have comment or be unexported (golint)
    • Line 138: warning: exported method ParamSpec.CountArgsUsing should have comment or be unexported (golint)
    • Line 191: warning: exported type ParamType should have comment or be unexported (golint)
    • Line 194: warning: exported const ParamTypeString should have comment (or a comment on this block) or be unexported (golint)
    • Line 382: warning: exported type ArgReference should have comment or be unexported (golint)
    • ethereum-playbook/model/inventory.go
    • Line 8: warning: exported type Inventory should have comment or be unexported (golint)
    • Line 10: warning: exported method Inventory.Validate should have comment or be unexported (golint)
    • Line 22: warning: exported method Inventory.GetClient should have comment or be unexported (golint)
    • Line 34: warning: exported type InventorySpec should have comment or be unexported (golint)
    • Line 36: warning: exported method InventorySpec.Validate should have comment or be unexported (golint)
    • ethereum-playbook/model/cmds_read.go
    • Line 10: warning: exported type ViewCmds should have comment or be unexported (golint)
    • Line 12: warning: exported method ViewCmds.Validate should have comment or be unexported (golint)
    • Line 33: warning: exported method ViewCmds.ViewCmdSpec should have comment or be unexported (golint)
    • Line 38: warning: exported type ViewCmdSpec should have comment or be unexported (golint)
    • Line 51: warning: exported method ViewCmdSpec.Validate should have comment or be unexported (golint)
    • Line 120: warning: exported method ViewCmdSpec.MatchingWallets should have comment or be unexported (golint)
    • Line 124: warning: exported method ViewCmdSpec.CountArgsUsing should have comment or be unexported (golint)
    • Line 128: warning: exported method ViewCmdSpec.ArgCount should have comment or be unexported (golint)
    • ethereum-playbook/model/context.go
    • Line 10: warning: exported type AppContext should have comment or be unexported (golint)
    • Line 14: warning: exported function NewAppContext should have comment or be unexported (golint)
    • Line 16: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 17: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 18: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 19: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 20: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 21: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 22: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 26: warning: exported method AppContext.AppCommand should have comment or be unexported (golint)
    • Line 30: warning: exported method AppContext.AppCommandArgs should have comment or be unexported (golint)
    • Line 34: warning: exported method AppContext.NodeGroup should have comment or be unexported (golint)
    • Line 38: warning: exported method AppContext.SpecDir should have comment or be unexported (golint)
    • Line 42: warning: exported method AppContext.SolcCompiler should have comment or be unexported (golint)
    • Line 46: warning: exported method AppContext.KeyCache should have comment or be unexported (golint)
    • ethereum-playbook/model/contracts.go
    • Line 14: warning: exported type Contracts should have comment or be unexported (golint)
    • Line 16: warning: exported method Contracts.UseSolc should have comment or be unexported (golint)
    • Line 25: warning: exported method Contracts.Validate should have comment or be unexported (golint)
    • Line 39: warning: exported method Contracts.ContractSpec should have comment or be unexported (golint)
    • Line 44: warning: exported method Contracts.FindByTokenSymbol should have comment or be unexported (golint)
    • Line 56: warning: exported type ContractSpec should have comment or be unexported (golint)
    • Line 66: warning: exported method ContractSpec.Validate should have comment or be unexported (golint)
    • Line 109: warning: exported type ContractInstanceSpec should have comment or be unexported (golint)
    • Line 117: warning: exported method ContractInstanceSpec.Validate should have comment or be unexported (golint)
    • Line 140: warning: exported method ContractInstanceSpec.TokenSymbol should have comment or be unexported (golint)
    • Line 144: warning: exported method ContractInstanceSpec.FetchTokenSymbol should have comment or be unexported (golint)
    • Line 157: warning: exported method ContractInstanceSpec.BoundContract should have comment or be unexported (golint)
    • Line 161: warning: exported method ContractInstanceSpec.IsDeployed should have comment or be unexported (golint)
    • ethereum-playbook/model/evaler.go
    • Line 12: warning: exported type Evaler should have comment or be unexported (golint)
    • Line 17: warning: exported function NewEvaler should have comment or be unexported (golint)
    • Line 24: warning: exported method Evaler.Run should have comment or be unexported (golint)
    • Line 98: warning: exported type ExprType should have comment or be unexported (golint)
    • Line 101: warning: exported const ExprTypeBool should have comment (or a comment on this block) or be unexported (golint)
    • ethereum-playbook/model/valuer.go
    • Line 12: warning: exported type Valuer should have comment or be unexported (golint)
    • Line 14: warning: exported method Valuer.Parse should have comment or be unexported (golint)
    • Line 81: warning: exported method Valuer.CountArgsUsing should have comment or be unexported (golint)
    • Line 93: warning: exported type ExtendedValue should have comment or be unexported (golint)
    • Line 117: warning: exported function IsCommonDenominator should have comment or be unexported (golint)
    • ethereum-playbook/model/wallets.go
    • Line 24: warning: exported const ZeroAddress should have comment or be unexported (golint)
    • Line 26: warning: exported type Wallets should have comment or be unexported (golint)
    • Line 28: warning: exported method Wallets.Validate should have comment or be unexported (golint)
    • Line 37: warning: exported method Wallets.NameOf should have comment or be unexported (golint)
    • Line 46: warning: exported method Wallets.GetOne should have comment or be unexported (golint)
    • Line 59: warning: exported method Wallets.GetAll should have comment or be unexported (golint)
    • Line 74: warning: exported method Wallets.WalletSpec should have comment or be unexported (golint)
    • Line 79: warning: exported type WalletSpec should have comment or be unexported (golint)
    • Line 90: warning: exported method WalletSpec.Validate should have comment or be unexported (golint)
    • Line 258: warning: exported method WalletSpec.PrivKeyECDSA should have comment or be unexported (golint)
    • Line 273: warning: exported const WalletSpecAddressField should have comment (or a comment on this block) or be unexported (golint)
    • Line 280: warning: exported method WalletSpec.HasField should have comment or be unexported (golint)
    • Line 293: warning: exported method WalletSpec.FieldValue should have comment or be unexported (golint)
    • Line 341: warning: exported type WalletFieldReference should have comment or be unexported (golint)
    • ethereum-playbook/model/cmds_call.go
    • Line 9: warning: exported type CallCmds should have comment or be unexported (golint)
    • Line 11: warning: exported method CallCmds.Validate should have comment or be unexported (golint)
    • Line 32: warning: exported method CallCmds.CallCmdSpec should have comment or be unexported (golint)
    • Line 37: warning: exported type CallCmdSpec should have comment or be unexported (golint)
    • Line 48: warning: exported method CallCmdSpec.Validate should have comment or be unexported (golint)
    • Line 85: warning: exported method CallCmdSpec.MatchingWallets should have comment or be unexported (golint)
    • Line 89: warning: exported method CallCmdSpec.CountArgsUsing should have comment or be unexported (golint)
    • Line 93: warning: exported method CallCmdSpec.ArgCount should have comment or be unexported (golint)
    • ethereum-playbook/model/spec.go
    • Line 5: warning: exported type Spec should have comment or be unexported (golint)
    • Line 19: warning: exported method Spec.Validate should have comment or be unexported (golint)
    • Line 86: warning: exported method Spec.CountArgsUsing should have comment or be unexported (golint)
    • Line 96: warning: exported method Spec.ArgCount should have comment or be unexported (golint)
    • Line 107: warning: exported type FieldName should have comment or be unexported (golint)
    • ethereum-playbook/model/cmds_write.go
    • Line 10: warning: exported type WriteCmds should have comment or be unexported (golint)
    • Line 12: warning: exported method WriteCmds.Validate should have comment or be unexported (golint)
    • Line 33: warning: exported method WriteCmds.WriteCmdSpec should have comment or be unexported (golint)
    • Line 38: warning: exported type WriteCmdSpec should have comment or be unexported (golint)
    • Line 54: warning: exported method WriteCmdSpec.Validate should have comment or be unexported (golint)
    • Line 150: warning: exported method WriteCmdSpec.MatchingWallet should have comment or be unexported (golint)
    • Line 154: warning: exported method WriteCmdSpec.CountArgsUsing should have comment or be unexported (golint)
    • Line 159: warning: exported method WriteCmdSpec.ArgCount should have comment or be unexported (golint)
    • ethereum-playbook/model/config.go
    • Line 12: warning: exported type ConfigSpec should have comment or be unexported (golint)
    • Line 21: warning: exported var DefaultConfigSpec should have comment or be unexported (golint)
    • Line 31: warning: exported method ConfigSpec.Validate should have comment or be unexported (golint)
    • Line 66: warning: exported method ConfigSpec.GasLimitInt should have comment or be unexported (golint)
    • Line 74: warning: exported method ConfigSpec.GasPriceInt should have comment or be unexported (golint)
    • Line 78: warning: exported method ConfigSpec.ChainIDInt should have comment or be unexported (golint)
    • Line 82: warning: exported method ConfigSpec.AwaitTimeoutDuration should have comment or be unexported (golint)
    • ethereum-playbook/executor/executor.go
    • Line 17: warning: exported type Executor should have comment or be unexported (golint)
    • Line 26: warning: exported function New should have comment or be unexported (golint)
    • Line 43: warning: exported method Executor.RunTarget should have comment or be unexported (golint)
    • Line 51: warning: exported method Executor.RunCommand should have comment or be unexported (golint)
    • Line 64: warning: exported type CommandResult should have comment or be unexported (golint)
    • ethereum-playbook/model/targets.go
    • Line 9: warning: exported type Targets should have comment or be unexported (golint)
    • Line 11: warning: exported method Targets.Validate should have comment or be unexported (golint)
    • Line 30: warning: exported method Targets.TargetSpec should have comment or be unexported (golint)
    • Line 35: warning: exported type TargetSpec should have comment or be unexported (golint)
    • Line 37: warning: exported method TargetSpec.Validate should have comment or be unexported (golint)
    • Line 82: warning: exported method TargetSpec.CmdNames should have comment or be unexported (golint)
    • Line 90: warning: exported method TargetSpec.ArgCount should have comment or be unexported (golint)
    • Line 98: warning: exported type TargetCommandSpec should have comment or be unexported (golint)
    • Line 102: warning: exported method TargetCommandSpec.Name should have comment or be unexported (golint)
    • Line 106: warning: exported method TargetCommandSpec.IsDeferred should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!