Preparing report...

Report for github.com/Circutor/edgex

A+    Excellent!    Found 183 issues across 299 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • edgex/internal/pkg/db/test/db_metadata.go
    • Line 645: warning: cyclomatic complexity 35 of function testDBDeviceProfile() is high (> 15) (gocyclo)
    • Line 305: warning: cyclomatic complexity 35 of function testDBAddressables() is high (> 15) (gocyclo)
    • Line 802: warning: cyclomatic complexity 27 of function testDBDevice() is high (> 15) (gocyclo)
    • Line 926: warning: cyclomatic complexity 27 of function testDBProvisionWatcher() is high (> 15) (gocyclo)
    • Line 541: warning: cyclomatic complexity 22 of function testDBDeviceService() is high (> 15) (gocyclo)
    • Line 464: warning: cyclomatic complexity 18 of function testDBCommand() is high (> 15) (gocyclo)

golint39%

Golint is a linter for Go source code.

    • edgex/pkg/models/reading.go
    • Line 21: warning: comment on exported type Reading should be of the form "Reading ..." (with optional leading article) (golint)
    • Line 43: warning: comment on exported method Reading.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/internal/core/metadata/errors/types.go
    • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
    • Line 20: warning: exported type ErrLimitExceeded should have comment or be unexported (golint)
    • Line 28: warning: exported function NewErrLimitExceeded should have comment or be unexported (golint)
    • Line 32: warning: exported type ErrDuplicateAddressableName should have comment or be unexported (golint)
    • Line 40: warning: exported function NewErrDuplicateAddressableName should have comment or be unexported (golint)
    • Line 44: warning: exported type ErrEmptyAddressableName should have comment or be unexported (golint)
    • Line 51: warning: exported function NewErrEmptyAddressableName should have comment or be unexported (golint)
    • Line 55: warning: exported type ErrAddressableNotFound should have comment or be unexported (golint)
    • Line 69: warning: exported function NewErrAddressableNotFound should have comment or be unexported (golint)
    • Line 73: warning: exported type ErrAddressableInUse should have comment or be unexported (golint)
    • Line 81: warning: exported function NewErrAddressableInUse should have comment or be unexported (golint)
    • edgex/internal/support/scheduler/errors/types.go
    • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
    • Line 22: warning: comment on exported type ErrIntervalNotFound should be of the form "ErrIntervalNotFound ..." (with optional leading article) (golint)
    • Line 31: warning: exported function NewErrIntervalNotFound should have comment or be unexported (golint)
    • Line 35: warning: exported type ErrIntervalNameInUse should have comment or be unexported (golint)
    • Line 43: warning: exported function NewErrIntervalNameInUse should have comment or be unexported (golint)
    • Line 47: warning: exported type ErrIntervalStillUsedByIntervalActions should have comment or be unexported (golint)
    • Line 55: warning: exported function NewErrIntervalStillInUse should have comment or be unexported (golint)
    • Line 59: warning: comment on exported type ErrIntervalActionNotFound should be of the form "ErrIntervalActionNotFound ..." (with optional leading article) (golint)
    • Line 68: warning: exported function NewErrIntervalActionNotFound should have comment or be unexported (golint)
    • Line 72: warning: exported type ErrIntervalActionTargetNameRequired should have comment or be unexported (golint)
    • Line 80: warning: exported function NewErrIntervalActionTargetNameRequired should have comment or be unexported (golint)
    • Line 84: warning: exported type ErrIntervalActionNameInUse should have comment or be unexported (golint)
    • Line 92: warning: exported function NewErrIntervalActionNameInUse should have comment or be unexported (golint)
    • Line 96: warning: exported type ErrInvalidTimeFormat should have comment or be unexported (golint)
    • Line 104: warning: exported function NewErrInvalidTimeFormat should have comment or be unexported (golint)
    • Line 108: warning: exported type ErrInvalidFrequencyFormat should have comment or be unexported (golint)
    • Line 116: warning: exported function NewErrInvalidFrequencyFormat should have comment or be unexported (golint)
    • Line 120: warning: exported type ErrInvalidCronFormat should have comment or be unexported (golint)
    • Line 128: warning: exported function NewErrInvalidCronFormat should have comment or be unexported (golint)
    • Line 132: warning: exported type ErrDbNotFound should have comment or be unexported (golint)
    • Line 139: warning: exported function NewErrDbNotFound should have comment or be unexported (golint)
    • edgex/internal/core/metadata/rest_deviceprofile.go
    • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)
    • Line 37: warning: exported var ErrFailedReadProf should have comment or be unexported (golint)
    • Line 310: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 712: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • edgex/pkg/models/interval_action.go
    • Line 23: warning: exported type IntervalAction should have comment or be unexported (golint)
    • Line 43: warning: exported method IntervalAction.MarshalJSON should have comment or be unexported (golint)
    • Line 121: warning: exported method IntervalAction.GetBaseURL should have comment or be unexported (golint)
    • edgex/internal/support/scheduler/config.go
    • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)
    • Line 18: warning: comment on exported type ConfigurationStruct should be of the form "ConfigurationStruct ..." (with optional leading article) (golint)
    • Line 29: warning: exported type WritableInfo should have comment or be unexported (golint)
    • edgex/pkg/models/actiontype.go
    • Line 17: warning: exported type ActionType should have comment or be unexported (golint)
    • Line 20: warning: exported const PROFILE should have comment (or a comment on this block) or be unexported (golint)
    • edgex/pkg/models/registration.go
    • Line 54: warning: exported const NotifyUpdateAdd should have comment (or a comment on this block) or be unexported (golint)
    • Line 76: warning: comment on exported method Registration.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 126: warning: exported method Registration.Validate should have comment or be unexported (golint)
    • edgex/pkg/models/channel_type.go
    • Line 23: warning: exported type ChannelType should have comment or be unexported (golint)
    • Line 26: warning: exported const Rest should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: exported method ChannelType.UnmarshalJSON should have comment or be unexported (golint)
    • Line 45: warning: exported function IsChannelType should have comment or be unexported (golint)
    • edgex/pkg/models/deviceservice.go
    • Line 21: warning: exported type DeviceService should have comment or be unexported (golint)
    • Line 26: warning: comment on exported method DeviceService.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 60: warning: comment on exported method DeviceService.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)
    • edgex/internal/pkg/db/mongo/export.go
    • Line 1: warning: package comment should be of the form "Package mongo ..." (golint)
    • Line 25: warning: comment on exported method MongoClient.Registrations should be of the form "Registrations ..." (golint)
    • Line 31: warning: comment on exported method MongoClient.AddRegistration should be of the form "AddRegistration ..." (golint)
    • Line 51: warning: comment on exported method MongoClient.UpdateRegistration should be of the form "UpdateRegistration ..." (golint)
    • Line 66: warning: comment on exported method MongoClient.RegistrationById should be of the form "RegistrationById ..." (golint)
    • Line 91: warning: comment on exported method MongoClient.RegistrationByName should be of the form "RegistrationByName ..." (golint)
    • Line 110: warning: comment on exported method MongoClient.DeleteRegistrationById should be of the form "DeleteRegistrationById ..." (golint)
    • Line 117: warning: comment on exported method MongoClient.DeleteRegistrationByName should be of the form "DeleteRegistrationByName ..." (golint)
    • Line 124: warning: comment on exported method MongoClient.ScrubAllRegistrations should be of the form "ScrubAllRegistrations ..." (golint)
    • edgex/pkg/clients/notifications/client.go
    • Line 23: warning: exported type CategoryEnum should have comment or be unexported (golint)
    • Line 26: warning: exported const SECURITY should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported type SeverityEnum should have comment or be unexported (golint)
    • Line 34: warning: exported const CRITICAL should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported type StatusEnum should have comment or be unexported (golint)
    • Line 41: warning: exported const NEW should have comment (or a comment on this block) or be unexported (golint)
    • Line 46: warning: comment on exported type NotificationsClient should be of the form "NotificationsClient ..." (with optional leading article) (golint)
    • Line 56: warning: comment on exported type Notification should be of the form "Notification ..." (with optional leading article) (golint)
    • Line 71: warning: exported function NewNotificationsClient should have comment or be unexported (golint)
    • Line 77: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/core/command/device.go
    • Line 1: warning: package comment should be of the form "Package command ..." (golint)
    • Line 37: warning: context.Context should be the first parameter of a function (golint)
    • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 87: warning: context.Context should be the first parameter of a function (golint)
    • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 102: warning: context.Context should be the first parameter of a function (golint)
    • Line 110: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 117: warning: context.Context should be the first parameter of a function (golint)
    • Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 132: warning: context.Context should be the first parameter of a function (golint)
    • Line 140: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 153: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 165: warning: context.Context should be the first parameter of a function (golint)
    • Line 171: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 178: warning: context.Context should be the first parameter of a function (golint)
    • Line 184: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • edgex/pkg/clients/metadata/addressable.go
    • Line 26: warning: comment on exported type AddressableClient should be of the form "AddressableClient ..." (with optional leading article) (golint)
    • Line 37: warning: exported type AddressableRestClient should have comment or be unexported (golint)
    • Line 41: warning: comment on exported function NewAddressableClient should be of the form "NewAddressableClient ..." (golint)
    • Line 50: warning: context.Context should be the first parameter of a function (golint)
    • Line 63: warning: context.Context should be the first parameter of a function (golint)
    • Line 67: warning: comment on exported method AddressableRestClient.Addressable should be of the form "Addressable ..." (golint)
    • Line 68: warning: context.Context should be the first parameter of a function (golint)
    • Line 72: warning: comment on exported method AddressableRestClient.AddressableForName should be of the form "AddressableForName ..." (golint)
    • Line 73: warning: context.Context should be the first parameter of a function (golint)
    • Line 78: warning: context.Context should be the first parameter of a function (golint)
    • Line 83: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/support/logging/init.go
    • Line 22: warning: exported var Configuration should have comment or be unexported (golint)
    • Line 24: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 26: warning: exported function Retry should have comment or be unexported (golint)
    • Line 61: warning: exported function Init should have comment or be unexported (golint)
    • Line 71: warning: exported function Destruct should have comment or be unexported (golint)
    • Line 97: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 101: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • edgex/internal/pkg/config/types.go
    • Line 1: warning: package comment should be of the form "Package config ..." (golint)
    • Line 78: warning: exported method MessageQueueInfo.Uri should have comment or be unexported (golint)
    • Line 94: warning: exported type IntervalInfo should have comment or be unexported (golint)
    • Line 109: warning: exported type IntervalActionInfo should have comment or be unexported (golint)
    • Line 130: warning: comment on exported method IntervalActionInfo.Url should be of the form "Url ..." (golint)
    • Line 146: warning: exported method ClientInfo.Url should have comment or be unexported (golint)
    • Line 151: warning: comment on exported type NotificationInfo should be of the form "NotificationInfo ..." (with optional leading article) (golint)
    • edgex/internal/core/data/config.go
    • Line 1: warning: package comment should be of the form "Package data ..." (golint)
    • Line 18: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
    • Line 27: warning: exported type WritableInfo should have comment or be unexported (golint)
    • edgex/pkg/clients/request.go
    • Line 47: warning: comment on exported function GetRequest should be of the form "GetRequest ..." (golint)
    • Line 48: warning: context.Context should be the first parameter of a function (golint)
    • Line 76: warning: comment on exported function CountRequest should be of the form "CountRequest ..." (golint)
    • Line 77: warning: context.Context should be the first parameter of a function (golint)
    • Line 90: warning: comment on exported function PostJsonRequest should be of the form "PostJsonRequest ..." (golint)
    • Line 91: warning: context.Context should be the first parameter of a function (golint)
    • Line 97: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 102: warning: comment on exported function PostRequest should be of the form "PostRequest ..." (golint)
    • Line 103: warning: context.Context should be the first parameter of a function (golint)
    • Line 138: warning: comment on exported function UploadFileRequest should be of the form "UploadFileRequest ..." (golint)
    • Line 139: warning: context.Context should be the first parameter of a function (golint)
    • Line 187: warning: comment on exported function UpdateRequest should be of the form "UpdateRequest ..." (golint)
    • Line 188: warning: context.Context should be the first parameter of a function (golint)
    • Line 198: warning: comment on exported function PutRequest should be of the form "PutRequest ..." (golint)
    • Line 199: warning: context.Context should be the first parameter of a function (golint)
    • Line 241: warning: comment on exported function DeleteRequest should be of the form "DeleteRequest ..." (golint)
    • Line 242: warning: context.Context should be the first parameter of a function (golint)
    • Line 270: warning: exported type CorrelatedRequest should have comment or be unexported (golint)
    • Line 274: warning: context.Context should be the first parameter of a function (golint)
    • Line 274: warning: exported function NewCorrelatedRequest should have comment or be unexported (golint)
    • edgex/pkg/clients/scheduler/interval_action.go
    • Line 26: warning: exported type IntervalActionClient should have comment or be unexported (golint)
    • Line 37: warning: comment on exported type IntervalActionRestClient should be of the form "IntervalActionRestClient ..." (with optional leading article) (golint)
    • Line 42: warning: exported function NewIntervalActionClient should have comment or be unexported (golint)
    • Line 48: warning: context.Context should be the first parameter of a function (golint)
    • Line 60: warning: context.Context should be the first parameter of a function (golint)
    • Line 72: warning: context.Context should be the first parameter of a function (golint)
    • Line 77: warning: context.Context should be the first parameter of a function (golint)
    • Line 81: warning: comment on exported method IntervalActionRestClient.DeleteByName should be of the form "DeleteByName ..." (golint)
    • Line 82: warning: context.Context should be the first parameter of a function (golint)
    • Line 87: warning: context.Context should be the first parameter of a function (golint)
    • Line 92: warning: context.Context should be the first parameter of a function (golint)
    • Line 96: warning: comment on exported method IntervalActionRestClient.IntervalActions should be of the form "IntervalActions ..." (golint)
    • Line 101: warning: comment on exported method IntervalActionRestClient.IntervalActionsForTargetByName should be of the form "IntervalActionsForTargetByName ..." (golint)
    • Line 102: warning: context.Context should be the first parameter of a function (golint)
    • Line 107: warning: context.Context should be the first parameter of a function (golint)
    • edgex/pkg/models/callbackalert.go
    • Line 21: warning: exported type CallbackAlert should have comment or be unexported (golint)
    • Line 26: warning: comment on exported method CallbackAlert.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/models/sma_operation.go
    • Line 22: warning: comment on exported type Operation should be of the form "Operation ..." (with optional leading article) (golint)
    • Line 33: warning: comment on exported method Operation.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)
    • edgex/pkg/models/interval.go
    • Line 35: warning: comment on exported method Interval.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 82: warning: receiver name dp should be consistent with previous receiver name i for Interval (golint)
    • edgex/pkg/models/profileproperty.go
    • Line 19: warning: exported type ProfileProperty should have comment or be unexported (golint)
    • Line 25: warning: comment on exported method ProfileProperty.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 48: warning: receiver name pp should be consistent with previous receiver name p for ProfileProperty (golint)
    • edgex/internal/pkg/telemetry/telemetry.go
    • Line 23: warning: exported type SystemUsage should have comment or be unexported (golint)
    • Line 37: warning: exported type CpuUsage should have comment or be unexported (golint)
    • Line 47: warning: exported function NewSystemUsage should have comment or be unexported (golint)
    • Line 70: warning: exported function StartCpuUsageAverage should have comment or be unexported (golint)
    • edgex/pkg/clients/metadata/device_service.go
    • Line 26: warning: comment on exported type DeviceServiceClient should be of the form "DeviceServiceClient ..." (with optional leading article) (golint)
    • Line 36: warning: exported type DeviceServiceRestClient should have comment or be unexported (golint)
    • Line 40: warning: comment on exported function NewDeviceServiceClient should be of the form "NewDeviceServiceClient ..." (golint)
    • Line 49: warning: context.Context should be the first parameter of a function (golint)
    • Line 60: warning: comment on exported method DeviceServiceRestClient.UpdateLastConnected should be of the form "UpdateLastConnected ..." (golint)
    • Line 61: warning: context.Context should be the first parameter of a function (golint)
    • Line 66: warning: comment on exported method DeviceServiceRestClient.UpdateLastReported should be of the form "UpdateLastReported ..." (golint)
    • Line 67: warning: context.Context should be the first parameter of a function (golint)
    • Line 73: warning: context.Context should be the first parameter of a function (golint)
    • Line 77: warning: comment on exported method DeviceServiceRestClient.DeviceServiceForName should be of the form "DeviceServiceForName ..." (golint)
    • Line 78: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/pkg/db/bolt/export.go
    • Line 26: warning: exported const ExportCollection should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: comment on exported method BoltClient.Registrations should be of the form "Registrations ..." (golint)
    • Line 56: warning: comment on exported method BoltClient.AddRegistration should be of the form "AddRegistration ..." (golint)
    • Line 67: warning: comment on exported method BoltClient.UpdateRegistration should be of the form "UpdateRegistration ..." (golint)
    • Line 76: warning: comment on exported method BoltClient.RegistrationById should be of the form "RegistrationById ..." (golint)
    • Line 85: warning: comment on exported method BoltClient.RegistrationByName should be of the form "RegistrationByName ..." (golint)
    • Line 94: warning: comment on exported method BoltClient.DeleteRegistrationById should be of the form "DeleteRegistrationById ..." (golint)
    • Line 101: warning: comment on exported method BoltClient.DeleteRegistrationByName should be of the form "DeleteRegistrationByName ..." (golint)
    • Line 108: warning: comment on exported method BoltClient.ScrubAllRegistrations should be of the form "ScrubAllRegistrations ..." (golint)
    • edgex/pkg/models/service.go
    • Line 21: warning: exported type Service should have comment or be unexported (golint)
    • Line 32: warning: comment on exported method Service.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 66: warning: receiver name dp should be consistent with previous receiver name s for Service (golint)
    • edgex/pkg/models/subscription.go
    • Line 22: warning: comment on exported type Subscription should be of the form "Subscription ..." (with optional leading article) (golint)
    • Line 39: warning: comment on exported method Subscription.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/clients/metadata/device.go
    • Line 27: warning: comment on exported type DeviceClient should be of the form "DeviceClient ..." (with optional leading article) (golint)
    • Line 54: warning: exported type DeviceRestClient should have comment or be unexported (golint)
    • Line 58: warning: comment on exported function NewDeviceClient should be of the form "NewDeviceClient ..." (golint)
    • Line 67: warning: context.Context should be the first parameter of a function (golint)
    • Line 79: warning: context.Context should be the first parameter of a function (golint)
    • Line 90: warning: comment on exported method DeviceRestClient.CheckForDevice should be of the form "CheckForDevice ..." (golint)
    • Line 93: warning: context.Context should be the first parameter of a function (golint)
    • Line 97: warning: comment on exported method DeviceRestClient.Device should be of the form "Device ..." (golint)
    • Line 98: warning: context.Context should be the first parameter of a function (golint)
    • Line 102: warning: comment on exported method DeviceRestClient.Devices should be of the form "Devices ..." (golint)
    • Line 107: warning: comment on exported method DeviceRestClient.DeviceForName should be of the form "DeviceForName ..." (golint)
    • Line 108: warning: context.Context should be the first parameter of a function (golint)
    • Line 112: warning: comment on exported method DeviceRestClient.DevicesByLabel should be of the form "DevicesByLabel ..." (golint)
    • Line 113: warning: context.Context should be the first parameter of a function (golint)
    • Line 117: warning: comment on exported method DeviceRestClient.DevicesForService should be of the form "DevicesForService ..." (golint)
    • Line 118: warning: context.Context should be the first parameter of a function (golint)
    • Line 122: warning: comment on exported method DeviceRestClient.DevicesForServiceByName should be of the form "DevicesForServiceByName ..." (golint)
    • Line 123: warning: context.Context should be the first parameter of a function (golint)
    • Line 127: warning: comment on exported method DeviceRestClient.DevicesForProfile should be of the form "DevicesForProfile ..." (golint)
    • Line 128: warning: context.Context should be the first parameter of a function (golint)
    • Line 132: warning: comment on exported method DeviceRestClient.DevicesForProfileByName should be of the form "DevicesForProfileByName ..." (golint)
    • Line 133: warning: context.Context should be the first parameter of a function (golint)
    • Line 138: warning: context.Context should be the first parameter of a function (golint)
    • Line 143: warning: context.Context should be the first parameter of a function (golint)
    • Line 147: warning: comment on exported method DeviceRestClient.UpdateLastConnected should be of the form "UpdateLastConnected ..." (golint)
    • Line 148: warning: context.Context should be the first parameter of a function (golint)
    • Line 153: warning: comment on exported method DeviceRestClient.UpdateLastConnectedByName should be of the form "UpdateLastConnectedByName ..." (golint)
    • Line 154: warning: context.Context should be the first parameter of a function (golint)
    • Line 159: warning: comment on exported method DeviceRestClient.UpdateLastReported should be of the form "UpdateLastReported ..." (golint)
    • Line 160: warning: context.Context should be the first parameter of a function (golint)
    • Line 165: warning: comment on exported method DeviceRestClient.UpdateLastReportedByName should be of the form "UpdateLastReportedByName ..." (golint)
    • Line 166: warning: context.Context should be the first parameter of a function (golint)
    • Line 171: warning: comment on exported method DeviceRestClient.UpdateOpState should be of the form "UpdateOpState ..." (golint)
    • Line 172: warning: context.Context should be the first parameter of a function (golint)
    • Line 177: warning: comment on exported method DeviceRestClient.UpdateOpStateByName should be of the form "UpdateOpStateByName ..." (golint)
    • Line 178: warning: context.Context should be the first parameter of a function (golint)
    • Line 183: warning: comment on exported method DeviceRestClient.UpdateAdminState should be of the form "UpdateAdminState ..." (golint)
    • Line 184: warning: context.Context should be the first parameter of a function (golint)
    • Line 189: warning: comment on exported method DeviceRestClient.UpdateAdminStateByName should be of the form "UpdateAdminStateByName ..." (golint)
    • Line 190: warning: context.Context should be the first parameter of a function (golint)
    • Line 196: warning: context.Context should be the first parameter of a function (golint)
    • Line 200: warning: comment on exported method DeviceRestClient.DeleteByName should be of the form "DeleteByName ..." (golint)
    • Line 201: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/export/distro/init.go
    • Line 23: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 25: warning: exported var Configuration should have comment or be unexported (golint)
    • Line 27: warning: exported function Retry should have comment or be unexported (golint)
    • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 62: warning: exported function Init should have comment or be unexported (golint)
    • Line 72: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/pkg/models/category.go
    • Line 23: warning: exported type NotificationsCategory should have comment or be unexported (golint)
    • Line 26: warning: exported const Security should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported method NotificationsCategory.UnmarshalJSON should have comment or be unexported (golint)
    • Line 46: warning: exported function IsNotificationsCategory should have comment or be unexported (golint)
    • edgex/internal/export/client/memory_db.go
    • Line 1: warning: package comment should be of the form "Package client ..." (golint)
    • Line 33: warning: exported type MemDB should have comment or be unexported (golint)
    • Line 37: warning: exported method MemDB.CloseSession should have comment or be unexported (golint)
    • Line 40: warning: exported method MemDB.Connect should have comment or be unexported (golint)
    • Line 44: warning: exported method MemDB.Registrations should have comment or be unexported (golint)
    • Line 44: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • Line 48: warning: exported method MemDB.AddRegistration should have comment or be unexported (golint)
    • Line 48: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • Line 59: warning: exported method MemDB.UpdateRegistration should have comment or be unexported (golint)
    • Line 59: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • Line 69: warning: exported method MemDB.RegistrationById should have comment or be unexported (golint)
    • Line 69: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • Line 79: warning: exported method MemDB.RegistrationByName should have comment or be unexported (golint)
    • Line 79: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • Line 89: warning: exported method MemDB.DeleteRegistrationById should have comment or be unexported (golint)
    • Line 89: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • Line 99: warning: exported method MemDB.DeleteRegistrationByName should have comment or be unexported (golint)
    • Line 99: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • Line 109: warning: exported method MemDB.ScrubAllRegistrations should have comment or be unexported (golint)
    • Line 109: warning: receiver name mc should be consistent with previous receiver name m for MemDB (golint)
    • edgex/internal/pkg/db/bolt/client.go
    • Line 27: warning: exported type BoltClient should have comment or be unexported (golint)
    • Line 31: warning: exported var ErrLimReached should have comment or be unexported (golint)
    • Line 32: warning: exported var ErrObjFound should have comment or be unexported (golint)
    • Line 34: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 47: warning: exported method BoltClient.Connect should have comment or be unexported (golint)
    • Line 51: warning: exported method BoltClient.CloseSession should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/notifications.go
    • Line 26: warning: exported const NOTIFICATION_COLLECTION should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported method MongoClient.GetNotifications should have comment or be unexported (golint)
    • Line 40: warning: exported method MongoClient.GetNotificationById should have comment or be unexported (golint)
    • Line 48: warning: exported method MongoClient.GetNotificationBySlug should have comment or be unexported (golint)
    • Line 52: warning: exported method MongoClient.GetNotificationBySender should have comment or be unexported (golint)
    • Line 56: warning: exported method MongoClient.GetNotificationsByLabels should have comment or be unexported (golint)
    • Line 60: warning: exported method MongoClient.GetNotificationsByStartEnd should have comment or be unexported (golint)
    • Line 64: warning: exported method MongoClient.GetNotificationsByStart should have comment or be unexported (golint)
    • Line 68: warning: exported method MongoClient.GetNotificationsByEnd should have comment or be unexported (golint)
    • Line 72: warning: exported method MongoClient.GetNewNotifications should have comment or be unexported (golint)
    • Line 76: warning: exported method MongoClient.GetNewNormalNotifications should have comment or be unexported (golint)
    • Line 80: warning: exported method MongoClient.AddNotification should have comment or be unexported (golint)
    • Line 103: warning: exported method MongoClient.UpdateNotification should have comment or be unexported (golint)
    • Line 107: warning: exported method MongoClient.MarkNotificationProcessed should have comment or be unexported (golint)
    • Line 112: warning: exported method MongoClient.DeleteNotificationById should have comment or be unexported (golint)
    • Line 120: warning: exported method MongoClient.DeleteNotificationBySlug should have comment or be unexported (golint)
    • Line 128: warning: exported method MongoClient.DeleteNotificationsOld should have comment or be unexported (golint)
    • Line 215: warning: exported method MongoClient.GetSubscriptionBySlug should have comment or be unexported (golint)
    • Line 219: warning: exported method MongoClient.GetSubscriptionByCategories should have comment or be unexported (golint)
    • Line 223: warning: exported method MongoClient.GetSubscriptionByLabels should have comment or be unexported (golint)
    • Line 227: warning: exported method MongoClient.GetSubscriptionByCategoriesLabels should have comment or be unexported (golint)
    • Line 231: warning: exported method MongoClient.GetSubscriptionByReceiver should have comment or be unexported (golint)
    • Line 235: warning: exported method MongoClient.GetSubscriptionById should have comment or be unexported (golint)
    • Line 243: warning: exported method MongoClient.AddSubscription should have comment or be unexported (golint)
    • Line 266: warning: exported method MongoClient.UpdateSubscription should have comment or be unexported (golint)
    • Line 278: warning: exported method MongoClient.DeleteSubscriptionBySlug should have comment or be unexported (golint)
    • Line 286: warning: comment on exported method MongoClient.GetSubscriptions should be of the form "GetSubscriptions ..." (golint)
    • Line 335: warning: exported method MongoClient.AddTransmission should have comment or be unexported (golint)
    • Line 354: warning: exported method MongoClient.UpdateTransmission should have comment or be unexported (golint)
    • Line 366: warning: exported method MongoClient.DeleteTransmission should have comment or be unexported (golint)
    • Line 372: warning: exported method MongoClient.GetTransmissionsByNotificationSlug should have comment or be unexported (golint)
    • Line 376: warning: exported method MongoClient.GetTransmissionsByStartEnd should have comment or be unexported (golint)
    • Line 380: warning: exported method MongoClient.GetTransmissionsByStart should have comment or be unexported (golint)
    • Line 384: warning: exported method MongoClient.GetTransmissionsByEnd should have comment or be unexported (golint)
    • Line 388: warning: exported method MongoClient.GetTransmissionsByStatus should have comment or be unexported (golint)
    • Line 431: warning: exported method MongoClient.Cleanup should have comment or be unexported (golint)
    • Line 435: warning: exported method MongoClient.CleanupOld should have comment or be unexported (golint)
    • edgex/internal/system/agent/execution_engine.go
    • Line 8: warning: exported type ExecuteApp should have comment or be unexported (golint)
    • Line 28: warning: exported method ExecuteApp.Start should have comment or be unexported (golint)
    • Line 39: warning: exported method ExecuteApp.Stop should have comment or be unexported (golint)
    • Line 50: warning: exported method ExecuteApp.Restart should have comment or be unexported (golint)
    • edgex/pkg/models/commandresponse.go
    • Line 24: warning: comment on exported type CommandResponse should be of the form "CommandResponse ..." (with optional leading article) (golint)
    • Line 42: warning: comment on exported method CommandResponse.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 79: warning: receiver name d should be consistent with previous receiver name cr for CommandResponse (golint)
    • Line 91: warning: comment on exported function CommandResponseFromDevice should be of the form "CommandResponseFromDevice ..." (golint)
    • edgex/pkg/models/propertyvalue.go
    • Line 21: warning: exported type PropertyValue should have comment or be unexported (golint)
    • Line 38: warning: comment on exported method PropertyValue.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/models/log_entry.go
    • Line 19: warning: exported type LogEntry should have comment or be unexported (golint)
    • Line 27: warning: exported method LogEntry.MarshalJSON should have comment or be unexported (golint)
    • edgex/pkg/models/transmission.go
    • Line 22: warning: exported type Transmission should have comment or be unexported (golint)
    • Line 33: warning: comment on exported method Transmission.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/clients/logger/mock-logger.go
    • Line 17: warning: exported type MockLogger should have comment or be unexported (golint)
    • Line 20: warning: exported function NewMockClient should have comment or be unexported (golint)
    • Line 24: warning: exported method MockLogger.SetLogLevel should have comment or be unexported (golint)
    • Line 28: warning: exported method MockLogger.Info should have comment or be unexported (golint)
    • Line 31: warning: exported method MockLogger.Debug should have comment or be unexported (golint)
    • Line 37: warning: exported method MockLogger.Trace should have comment or be unexported (golint)
    • Line 40: warning: exported method MockLogger.Warn should have comment or be unexported (golint)
    • edgex/internal/core/metadata/config.go
    • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)
    • Line 20: warning: comment on exported type ConfigurationStruct should be of the form "ConfigurationStruct ..." (with optional leading article) (golint)
    • Line 30: warning: exported type WritableInfo should have comment or be unexported (golint)
    • edgex/internal/support/scheduler/init.go
    • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)
    • Line 34: warning: exported var Configuration should have comment or be unexported (golint)
    • Line 35: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 41: warning: exported function Retry should have comment or be unexported (golint)
    • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 85: warning: exported function Init should have comment or be unexported (golint)
    • Line 95: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/internal/export/client/init.go
    • Line 30: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 31: warning: exported var Configuration should have comment or be unexported (golint)
    • Line 34: warning: exported function Retry should have comment or be unexported (golint)
    • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 75: warning: exported function Init should have comment or be unexported (golint)
    • Line 85: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/internal/pkg/db/bolt/data.go
    • Line 38: warning: comment on exported method BoltClient.Events should be of the form "Events ..." (golint)
    • Line 47: warning: comment on exported method BoltClient.EventsWithLimit should be of the form "EventsWithLimit ..." (golint)
    • Line 56: warning: comment on exported method BoltClient.AddEvent should be of the form "AddEvent ..." (golint)
    • Line 91: warning: comment on exported method BoltClient.UpdateEvent should be of the form "UpdateEvent ..." (golint)
    • Line 100: warning: comment on exported method BoltClient.EventById should be of the form "EventById ..." (golint)
    • Line 107: warning: comment on exported method BoltClient.EventCount should be of the form "EventCount ..." (golint)
    • Line 112: warning: comment on exported method BoltClient.EventCountByDeviceId should be of the form "EventCountByDeviceId ..." (golint)
    • Line 132: warning: comment on exported method BoltClient.DeleteEventById should be of the form "DeleteEventById ..." (golint)
    • Line 139: warning: comment on exported method BoltClient.EventsForDeviceLimit should be of the form "EventsForDeviceLimit ..." (golint)
    • Line 150: warning: comment on exported method BoltClient.EventsForDevice should be of the form "EventsForDevice ..." (golint)
    • Line 161: warning: comment on exported method BoltClient.EventsByCreationTime should be of the form "EventsByCreationTime ..." (golint)
    • Line 173: warning: comment on exported method BoltClient.EventsOlderThanAge should be of the form "EventsOlderThanAge ..." (golint)
    • Line 185: warning: comment on exported method BoltClient.EventsPushed should be of the form "EventsPushed ..." (golint)
    • Line 196: warning: comment on exported method BoltClient.EventsUnpushedLimit should be of the form "EventsUnpushedLimit ..." (golint)
    • Line 207: warning: comment on exported method BoltClient.ScrubAllEvents should be of the form "ScrubAllEvents ..." (golint)
    • edgex/internal/system/agent/services.go
    • Line 27: warning: exported const START should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported function InvokeOperation should have comment or be unexported (golint)
    • Line 78: warning: context.Context should be the first parameter of a function (golint)
    • Line 107: warning: context.Context should be the first parameter of a function (golint)
    • edgex/pkg/clients/metadata/command.go
    • Line 25: warning: comment on exported type CommandClient should be of the form "CommandClient ..." (with optional leading article) (golint)
    • Line 37: warning: exported type CommandRestClient should have comment or be unexported (golint)
    • Line 41: warning: comment on exported function NewCommandClient should be of the form "NewCommandClient ..." (golint)
    • Line 50: warning: context.Context should be the first parameter of a function (golint)
    • Line 62: warning: context.Context should be the first parameter of a function (golint)
    • Line 73: warning: comment on exported method CommandRestClient.Command should be of the form "Command ..." (golint)
    • Line 74: warning: context.Context should be the first parameter of a function (golint)
    • Line 78: warning: comment on exported method CommandRestClient.Commands should be of the form "Commands ..." (golint)
    • Line 83: warning: comment on exported method CommandRestClient.CommandsForName should be of the form "CommandsForName ..." (golint)
    • Line 84: warning: context.Context should be the first parameter of a function (golint)
    • Line 89: warning: context.Context should be the first parameter of a function (golint)
    • Line 94: warning: context.Context should be the first parameter of a function (golint)
    • Line 99: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/pkg/db/mongo/models/service.go
    • Line 24: warning: exported type Service should have comment or be unexported (golint)
    • Line 39: warning: exported method Service.ToContract should have comment or be unexported (golint)
    • Line 65: warning: exported method Service.FromContract should have comment or be unexported (golint)
    • Line 93: warning: exported method Service.TimestampForUpdate should have comment or be unexported (golint)
    • Line 97: warning: exported method Service.TimestampForAdd should have comment or be unexported (golint)
    • edgex/pkg/models/deviceresource.go
    • Line 21: warning: exported type DeviceResource should have comment or be unexported (golint)
    • Line 29: warning: comment on exported method DeviceResource.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/models/deviceprofile.go
    • Line 21: warning: comment on exported type DeviceProfile should be of the form "DeviceProfile ..." (with optional leading article) (golint)
    • Line 39: warning: comment on exported method DeviceProfile.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/internal/core/command/config.go
    • Line 1: warning: package comment should be of the form "Package command ..." (golint)
    • Line 18: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
    • Line 26: warning: exported type WritableInfo should have comment or be unexported (golint)
    • edgex/internal/pkg/correlation/middleware.go
    • Line 14: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 16: warning: exported function ManageHeader should have comment or be unexported (golint)
    • Line 28: warning: exported function OnResponseComplete should have comment or be unexported (golint)
    • Line 39: warning: exported function OnRequestBegin should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/deviceprofile.go
    • Line 29: warning: exported type PropertyValue should have comment or be unexported (golint)
    • Line 45: warning: exported type Units should have comment or be unexported (golint)
    • Line 51: warning: exported type ProfileProperty should have comment or be unexported (golint)
    • Line 56: warning: exported type DeviceResource should have comment or be unexported (golint)
    • Line 64: warning: exported type ResourceOperation should have comment or be unexported (golint)
    • Line 74: warning: exported type ProfileResource should have comment or be unexported (golint)
    • Line 80: warning: exported type DeviceProfile should have comment or be unexported (golint)
    • Line 96: warning: exported method DeviceProfile.ToContract should have comment or be unexported (golint)
    • Line 183: warning: exported method DeviceProfile.FromContract should have comment or be unexported (golint)
    • Line 278: warning: exported method DeviceProfile.TimestampForUpdate should have comment or be unexported (golint)
    • Line 282: warning: exported method DeviceProfile.TimestampForAdd should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/scheduler.go
    • Line 1: warning: package comment should be of the form "Package mongo ..." (golint)
    • Line 29: warning: exported method MongoClient.Intervals should have comment or be unexported (golint)
    • Line 33: warning: comment on exported method MongoClient.IntervalsWithLimit should be of the form "IntervalsWithLimit ..." (golint)
    • Line 40: warning: comment on exported method MongoClient.IntervalByName should be of the form "IntervalByName ..." (golint)
    • Line 55: warning: comment on exported method MongoClient.IntervalById should be of the form "IntervalById ..." (golint)
    • Line 73: warning: comment on exported method MongoClient.AddInterval should be of the form "AddInterval ..." (golint)
    • Line 105: warning: comment on exported method MongoClient.UpdateInterval should be of the form "UpdateInterval ..." (golint)
    • Line 119: warning: comment on exported method MongoClient.DeleteIntervalById should be of the form "DeleteIntervalById ..." (golint)
    • Line 127: warning: comment on exported method MongoClient.IntervalActions should be of the form "IntervalActions ..." (golint)
    • Line 134: warning: comment on exported method MongoClient.IntervalActionsWithLimit should be of the form "IntervalActionsWithLimit ..." (golint)
    • Line 141: warning: comment on exported method MongoClient.IntervalActionsByIntervalName should be of the form "IntervalActionsByIntervalName ..." (golint)
    • Line 148: warning: comment on exported method MongoClient.IntervalActionsByTarget should be of the form "IntervalActionsByTarget ..." (golint)
    • Line 155: warning: comment on exported method MongoClient.IntervalActionById should be of the form "IntervalActionById ..." (golint)
    • Line 174: warning: comment on exported method MongoClient.IntervalActionByName should be of the form "IntervalActionByName ..." (golint)
    • Line 190: warning: comment on exported method MongoClient.AddIntervalAction should be of the form "AddIntervalAction ..." (golint)
    • Line 221: warning: comment on exported method MongoClient.UpdateIntervalAction should be of the form "UpdateIntervalAction ..." (golint)
    • Line 235: warning: comment on exported method MongoClient.DeleteIntervalActionById should be of the form "DeleteIntervalActionById ..." (golint)
    • Line 327: warning: comment on exported method MongoClient.ScrubAllIntervalActions should be of the form "ScrubAllIntervalActions ..." (golint)
    • Line 346: warning: comment on exported method MongoClient.ScrubAllIntervals should be of the form "ScrubAllIntervals ..." (golint)
    • edgex/pkg/models/provisionwatcher.go
    • Line 21: warning: exported type ProvisionWatcher should have comment or be unexported (golint)
    • Line 31: warning: comment on exported method ProvisionWatcher.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/clients/context.go
    • Line 21: warning: context.Context should be the first parameter of a function (golint)
    • Line 21: warning: exported function FromContext should have comment or be unexported (golint)
    • edgex/pkg/models/device.go
    • Line 21: warning: comment on exported type Device should be of the form "Device ..." (with optional leading article) (golint)
    • Line 46: warning: comment on exported method Device.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/internal/core/data/messaging/eventpublisher.go
    • Line 1: warning: package comment should be of the form "Package messaging ..." (golint)
    • Line 20: warning: comment on exported type PubSubConfiguration should be of the form "PubSubConfiguration ..." (with optional leading article) (golint)
    • Line 25: warning: exported type EventPublisher should have comment or be unexported (golint)
    • Line 29: warning: exported function NewEventPublisher should have comment or be unexported (golint)
    • edgex/internal/core/command/init.go
    • Line 1: warning: package comment should be of the form "Package command ..." (golint)
    • Line 30: warning: exported var Configuration should have comment or be unexported (golint)
    • Line 31: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 34: warning: exported function Retry should have comment or be unexported (golint)
    • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 69: warning: exported function Init should have comment or be unexported (golint)
    • Line 79: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/command.go
    • Line 29: warning: exported type Response should have comment or be unexported (golint)
    • Line 35: warning: exported type Get should have comment or be unexported (golint)
    • Line 41: warning: exported type Put should have comment or be unexported (golint)
    • Line 48: warning: exported type Command should have comment or be unexported (golint)
    • Line 59: warning: exported method Command.ToContract should have comment or be unexported (golint)
    • Line 110: warning: exported method Command.FromContract should have comment or be unexported (golint)
    • Line 153: warning: exported method Command.TimestampForUpdate should have comment or be unexported (golint)
    • Line 157: warning: exported method Command.TimestampForAdd should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/notification.go
    • Line 24: warning: exported type Notification should have comment or be unexported (golint)
    • Line 41: warning: exported method Notification.ToContract should have comment or be unexported (golint)
    • Line 64: warning: exported method Notification.FromContract should have comment or be unexported (golint)
    • Line 87: warning: exported method Notification.TimestampForUpdate should have comment or be unexported (golint)
    • Line 91: warning: exported method Notification.TimestampForAdd should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/registration.go
    • Line 23: warning: exported type Filter should have comment or be unexported (golint)
    • Line 28: warning: exported type EncryptionDetails should have comment or be unexported (golint)
    • Line 34: warning: exported type Registration should have comment or be unexported (golint)
    • Line 50: warning: exported method Registration.ToContract should have comment or be unexported (golint)
    • Line 78: warning: exported method Registration.FromContract should have comment or be unexported (golint)
    • Line 112: warning: exported method Registration.TimestampForUpdate should have comment or be unexported (golint)
    • Line 116: warning: exported method Registration.TimestampForAdd should have comment or be unexported (golint)
    • edgex/pkg/models/severity.go
    • Line 23: warning: exported type NotificationsSeverity should have comment or be unexported (golint)
    • Line 26: warning: exported const Critical should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: exported method NotificationsSeverity.UnmarshalJSON should have comment or be unexported (golint)
    • Line 45: warning: exported function IsNotificationsSeverity should have comment or be unexported (golint)
    • edgex/pkg/models/put.go
    • Line 19: warning: comment on exported type Put should be of the form "Put ..." (with optional leading article) (golint)
    • Line 29: warning: comment on exported method Put.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/internal/pkg/db/mongo/models/subscription.go
    • Line 25: warning: comment on exported type Subscription should be of the form "Subscription ..." (with optional leading article) (golint)
    • Line 45: warning: exported method Subscription.ToContract should have comment or be unexported (golint)
    • Line 68: warning: exported method Subscription.FromContract should have comment or be unexported (golint)
    • Line 93: warning: exported method Subscription.TimestampForUpdate should have comment or be unexported (golint)
    • Line 97: warning: exported method Subscription.TimestampForAdd should have comment or be unexported (golint)
    • edgex/internal/support/notifications/config.go
    • Line 1: warning: package comment should be of the form "Package notifications ..." (golint)
    • Line 19: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
    • Line 28: warning: exported type WritableInfo should have comment or be unexported (golint)
    • Line 33: warning: exported type SmtpInfo should have comment or be unexported (golint)
    • edgex/internal/core/metadata/rest_device.go
    • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)
    • Line 434: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 695: warning: context.Context should be the first parameter of a function (golint)
    • Line 866: warning: context.Context should be the first parameter of a function (golint)
    • Line 1036: warning: context.Context should be the first parameter of a function (golint)
    • Line 1074: warning: context.Context should be the first parameter of a function (golint)
    • Line 1092: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/support/scheduler/schedulecontext.go
    • Line 19: warning: exported type IntervalContext should have comment or be unexported (golint)
    • Line 31: warning: exported method IntervalContext.Reset should have comment or be unexported (golint)
    • Line 97: warning: exported method IntervalContext.IsComplete should have comment or be unexported (golint)
    • Line 101: warning: exported method IntervalContext.UpdateIterations should have comment or be unexported (golint)
    • Line 107: warning: exported method IntervalContext.UpdateNextTime should have comment or be unexported (golint)
    • Line 124: warning: exported method IntervalContext.GetInfo should have comment or be unexported (golint)
    • edgex/pkg/models/addressable.go
    • Line 23: warning: comment on exported type Addressable should be of the form "Addressable ..." (with optional leading article) (golint)
    • Line 45: warning: comment on exported method Addressable.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 117: warning: exported method Addressable.GetBaseURL should have comment or be unexported (golint)
    • Line 125: warning: comment on exported method Addressable.GetCallbackURL should be of the form "GetCallbackURL ..." (golint)
    • edgex/internal/pkg/db/db.go
    • Line 23: warning: comment on exported const MongoDB should be of the form "MongoDB ..." (golint)
    • Line 25: warning: exported const BoltDB should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: comment on exported const EventsCollection should be of the form "EventsCollection ..." (golint)
    • Line 30: warning: comment on exported const ExportCollection should be of the form "ExportCollection ..." (golint)
    • Line 33: warning: comment on exported const LogsCollection should be of the form "LogsCollection ..." (golint)
    • Line 36: warning: comment on exported const Device should be of the form "Device ..." (golint)
    • Line 48: warning: exported var ErrNotFound should have comment or be unexported (golint)
    • Line 57: warning: exported type Configuration should have comment or be unexported (golint)
    • Line 67: warning: exported function MakeTimestamp should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/addressable.go
    • Line 1: warning: package comment should be of the form "Package models ..." (golint)
    • Line 28: warning: exported type Addressable should have comment or be unexported (golint)
    • Line 46: warning: exported method Addressable.ToContract should have comment or be unexported (golint)
    • Line 71: warning: exported method Addressable.FromContract should have comment or be unexported (golint)
    • Line 94: warning: exported method Addressable.TimestampForUpdate should have comment or be unexported (golint)
    • Line 98: warning: exported method Addressable.TimestampForAdd should have comment or be unexported (golint)
    • edgex/internal/system/agent/config.go
    • Line 1: warning: package comment should be of the form "Package agent ..." (golint)
    • Line 18: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
    • Line 27: warning: exported type WritableInfo should have comment or be unexported (golint)
    • edgex/pkg/models/get.go
    • Line 19: warning: exported type Get should have comment or be unexported (golint)
    • Line 23: warning: comment on exported method Get.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/models/response.go
    • Line 23: warning: comment on exported type Response should be of the form "Response ..." (with optional leading article) (golint)
    • Line 35: warning: comment on exported method Response.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 59: warning: receiver name a should be consistent with previous receiver name r for Response (golint)
    • Line 67: warning: exported method Response.Equals should have comment or be unexported (golint)
    • edgex/internal/core/data/init.go
    • Line 1: warning: package comment should be of the form "Package data ..." (golint)
    • Line 34: warning: comment on exported var Configuration should be of the form "Configuration ..." (golint)
    • Line 37: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 45: warning: exported function Retry should have comment or be unexported (golint)
    • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 86: warning: exported function Init should have comment or be unexported (golint)
    • Line 98: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/internal/export/client/config.go
    • Line 1: warning: package comment should be of the form "Package client ..." (golint)
    • Line 18: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
    • Line 26: warning: exported type WritableInfo should have comment or be unexported (golint)
    • edgex/pkg/models/adminstate.go
    • Line 30: warning: exported const Unlocked should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: comment on exported method AdminState.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)
    • Line 52: warning: exported function IsAdminStateType should have comment or be unexported (golint)
    • Line 57: warning: exported function GetAdminState should have comment or be unexported (golint)
    • edgex/internal/core/data/domain_events.go
    • Line 1: warning: package comment should be of the form "Package data ..." (golint)
    • Line 16: warning: comment on exported type DeviceLastReported should be of the form "DeviceLastReported ..." (with optional leading article) (golint)
    • Line 21: warning: comment on exported type DeviceServiceLastReported should be of the form "DeviceServiceLastReported ..." (with optional leading article) (golint)
    • edgex/internal/core/data/event.go
    • Line 1: warning: package comment should be of the form "Package data ..." (golint)
    • Line 35: warning: context.Context should be the first parameter of a function (golint)
    • Line 80: warning: context.Context should be the first parameter of a function (golint)
    • Line 102: warning: context.Context should be the first parameter of a function (golint)
    • Line 161: warning: context.Context should be the first parameter of a function (golint)
    • Line 176: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/support/notifications/const.go
    • Line 20: warning: comment on exported var ESCALATIONSUBSCRIPTIONSLUG should be of the form "ESCALATIONSUBSCRIPTIONSLUG ..." (golint)
    • Line 22: warning: exported var ESCALATIONPREFIX should have comment or be unexported (golint)
    • Line 25: warning: comment on exported var START should be of the form "START ..." (golint)
    • edgex/pkg/models/status.go
    • Line 23: warning: exported type NotificationsStatus should have comment or be unexported (golint)
    • Line 26: warning: exported const New should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported method NotificationsStatus.UnmarshalJSON should have comment or be unexported (golint)
    • Line 46: warning: exported function IsNotificationsStatus should have comment or be unexported (golint)
    • edgex/internal/support/scheduler/utils.go
    • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)
    • Line 51: warning: comment on exported type QueueClient should be of the form "QueueClient ..." (with optional leading article) (golint)
    • Line 55: warning: comment on exported function NewSchedulerQueueClient should be of the form "NewSchedulerQueueClient ..." (golint)
    • edgex/pkg/models/transmission_status.go
    • Line 23: warning: exported type TransmissionStatus should have comment or be unexported (golint)
    • Line 26: warning: exported const Failed should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: comment on exported method TransmissionStatus.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)
    • Line 49: warning: exported function IsTransmissionStatus should have comment or be unexported (golint)
    • edgex/internal/constants.go
    • Line 1: warning: package comment should be of the form "Package internal ..." (golint)
    • Line 17: warning: exported const BootTimeoutDefault should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: exported const ServiceKeyPrefix should have comment (or a comment on this block) or be unexported (golint)
    • edgex/pkg/clients/scheduler/interval.go
    • Line 26: warning: exported type IntervalClient should have comment or be unexported (golint)
    • Line 36: warning: exported type IntervalRestClient should have comment or be unexported (golint)
    • Line 40: warning: exported function NewIntervalClient should have comment or be unexported (golint)
    • Line 45: warning: comment on exported method IntervalRestClient.Add should be of the form "Add ..." (golint)
    • Line 46: warning: context.Context should be the first parameter of a function (golint)
    • Line 51: warning: context.Context should be the first parameter of a function (golint)
    • Line 55: warning: comment on exported method IntervalRestClient.DeleteByName should be of the form "DeleteByName ..." (golint)
    • Line 56: warning: context.Context should be the first parameter of a function (golint)
    • Line 60: warning: comment on exported method IntervalRestClient.Interval should be of the form "Interval ..." (golint)
    • Line 61: warning: context.Context should be the first parameter of a function (golint)
    • Line 65: warning: comment on exported method IntervalRestClient.IntervalForName should be of the form "IntervalForName ..." (golint)
    • Line 66: warning: context.Context should be the first parameter of a function (golint)
    • Line 70: warning: comment on exported method IntervalRestClient.Intervals should be of the form "Intervals ..." (golint)
    • Line 76: warning: context.Context should be the first parameter of a function (golint)
    • Line 85: warning: context.Context should be the first parameter of a function (golint)
    • Line 97: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/system/agent/init.go
    • Line 1: warning: package comment should be of the form "Package agent ..." (golint)
    • Line 27: warning: comment on exported var Configuration should be of the form "Configuration ..." (golint)
    • Line 30: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 47: warning: exported function Retry should have comment or be unexported (golint)
    • Line 64: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 86: warning: exported function Init should have comment or be unexported (golint)
    • Line 94: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/internal/support/logging/config.go
    • Line 1: warning: package comment should be of the form "Package logging ..." (golint)
    • Line 18: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
    • Line 25: warning: exported type WritableInfo should have comment or be unexported (golint)
    • edgex/internal/pkg/startup/bootstrap.go
    • Line 1: warning: package comment should be of the form "Package startup ..." (golint)
    • Line 18: warning: exported type RetryFunc should have comment or be unexported (golint)
    • Line 20: warning: exported type LogFunc should have comment or be unexported (golint)
    • Line 22: warning: exported type BootParams should have comment or be unexported (golint)
    • Line 27: warning: exported function Bootstrap should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/channel.go
    • Line 1: warning: package comment should be of the form "Package models ..." (golint)
    • Line 19: warning: exported type Channel should have comment or be unexported (golint)
    • Line 25: warning: exported method Channel.ToContract should have comment or be unexported (golint)
    • Line 32: warning: exported method Channel.FromContract should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/transmission.go
    • Line 24: warning: exported type TransmissionRecord should have comment or be unexported (golint)
    • Line 30: warning: exported type Transmission should have comment or be unexported (golint)
    • Line 44: warning: exported method Transmission.ToContract should have comment or be unexported (golint)
    • Line 71: warning: exported method Transmission.FromContract should have comment or be unexported (golint)
    • Line 100: warning: exported method Transmission.TimestampForUpdate should have comment or be unexported (golint)
    • Line 104: warning: exported method Transmission.TimestampForAdd should have comment or be unexported (golint)
    • edgex/internal/core/metadata/const.go
    • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)
    • Line 17: warning: comment on exported const ID should be of the form "ID ..." (golint)
    • Line 19: warning: exported const NAME should have comment (or a comment on this block) or be unexported (golint)
    • edgex/internal/pkg/db/mongo/client.go
    • Line 1: warning: package comment should be of the form "Package mongo ..." (golint)
    • Line 24: warning: exported type MongoClient should have comment or be unexported (golint)
    • Line 29: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 53: warning: exported method MongoClient.CloseSession should have comment or be unexported (golint)
    • edgex/internal/support/scheduler/const.go
    • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)
    • Line 18: warning: comment on exported const ID should be of the form "ID ..." (golint)
    • Line 20: warning: exported const NAME should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: comment on exported const ContentTypeKey should be of the form "ContentTypeKey ..." (golint)
    • edgex/pkg/models/event.go
    • Line 23: warning: comment on exported type Event should be of the form "Event ..." (with optional leading article) (golint)
    • Line 52: warning: comment on exported method Event.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 94: warning: exported method Event.CBOR should have comment or be unexported (golint)
    • edgex/internal/pkg/correlation/models/event.go
    • Line 23: warning: exported type Event should have comment or be unexported (golint)
    • Line 28: warning: comment on exported method Event.ToContract should be of the form "ToContract ..." (golint)
    • Line 47: warning: exported method Event.MarshalJSON should have comment or be unexported (golint)
    • edgex/pkg/clients/command/command.go
    • Line 29: warning: exported type CommandRestClient should have comment or be unexported (golint)
    • Line 40: warning: context.Context should be the first parameter of a function (golint)
    • Line 46: warning: context.Context should be the first parameter of a function (golint)
    • edgex/pkg/clients/constants.go
    • Line 18: warning: exported const CorrelationHeader should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported const ApiBase should have comment (or a comment on this block) or be unexported (golint)
    • Line 46: warning: exported const ServiceKeyPrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 59: warning: exported const ContentType should have comment (or a comment on this block) or be unexported (golint)
    • edgex/internal/export/distro/config.go
    • Line 1: warning: package comment should be of the form "Package distro ..." (golint)
    • Line 18: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
    • Line 27: warning: exported type WritableInfo should have comment or be unexported (golint)
    • Line 32: warning: exported type CertificateInfo should have comment or be unexported (golint)
    • edgex/internal/export/db.go
    • Line 1: warning: package comment should be of the form "Package export ..." (golint)
    • Line 20: warning: exported type DBClient should have comment or be unexported (golint)
    • edgex/internal/pkg/config/loader.go
    • Line 37: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 39: warning: exported function LoadFromFile should have comment or be unexported (golint)
    • Line 81: warning: exported function VerifyTomlFiles should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/metadata.go
    • Line 28: warning: comment on exported method MongoClient.AddDevice should be of the form "AddDevice ..." (golint)
    • Line 55: warning: exported method MongoClient.UpdateDevice should have comment or be unexported (golint)
    • Line 67: warning: exported method MongoClient.DeleteDeviceById should have comment or be unexported (golint)
    • Line 71: warning: exported method MongoClient.GetAllDevices should have comment or be unexported (golint)
    • Line 75: warning: exported method MongoClient.GetDevicesByProfileId should have comment or be unexported (golint)
    • Line 83: warning: exported method MongoClient.GetDeviceById should have comment or be unexported (golint)
    • Line 91: warning: exported method MongoClient.GetDeviceByName should have comment or be unexported (golint)
    • Line 95: warning: exported method MongoClient.GetDevicesByServiceId should have comment or be unexported (golint)
    • Line 103: warning: exported method MongoClient.GetDevicesWithLabel should have comment or be unexported (golint)
    • Line 142: warning: exported method MongoClient.DBRefToDeviceProfile should have comment or be unexported (golint)
    • Line 152: warning: exported method MongoClient.DeviceProfileToDBRef should have comment or be unexported (golint)
    • Line 167: warning: exported method MongoClient.GetDeviceProfileById should have comment or be unexported (golint)
    • Line 183: warning: exported method MongoClient.GetAllDeviceProfiles should have comment or be unexported (golint)
    • Line 187: warning: exported method MongoClient.GetDeviceProfilesByModel should have comment or be unexported (golint)
    • Line 191: warning: exported method MongoClient.GetDeviceProfilesWithLabel should have comment or be unexported (golint)
    • Line 195: warning: exported method MongoClient.GetDeviceProfilesByManufacturerModel should have comment or be unexported (golint)
    • Line 199: warning: exported method MongoClient.GetDeviceProfilesByManufacturer should have comment or be unexported (golint)
    • Line 203: warning: exported method MongoClient.GetDeviceProfileByName should have comment or be unexported (golint)
    • Line 245: warning: exported method MongoClient.AddDeviceProfile should have comment or be unexported (golint)
    • Line 262: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 282: warning: exported method MongoClient.UpdateDeviceProfile should have comment or be unexported (golint)
    • Line 294: warning: comment on exported method MongoClient.GetDeviceProfilesByCommandId should be of the form "GetDeviceProfilesByCommandId ..." (golint)
    • Line 308: warning: exported method MongoClient.DeleteDeviceProfileById should have comment or be unexported (golint)
    • Line 314: warning: exported method MongoClient.DBRefToAddressable should have comment or be unexported (golint)
    • Line 324: warning: exported method MongoClient.AddressableToDBRef should have comment or be unexported (golint)
    • Line 340: warning: exported method MongoClient.UpdateAddressable should have comment or be unexported (golint)
    • Line 352: warning: exported method MongoClient.GetAddressables should have comment or be unexported (golint)
    • Line 368: warning: exported method MongoClient.GetAddressableById should have comment or be unexported (golint)
    • Line 384: warning: exported method MongoClient.AddAddressable should have comment or be unexported (golint)
    • Line 413: warning: exported method MongoClient.GetAddressableByName should have comment or be unexported (golint)
    • Line 429: warning: exported method MongoClient.GetAddressablesByTopic should have comment or be unexported (golint)
    • Line 433: warning: exported method MongoClient.GetAddressablesByPort should have comment or be unexported (golint)
    • Line 437: warning: exported method MongoClient.GetAddressablesByPublisher should have comment or be unexported (golint)
    • Line 441: warning: exported method MongoClient.GetAddressablesByAddress should have comment or be unexported (golint)
    • Line 457: warning: exported method MongoClient.DeleteAddressableById should have comment or be unexported (golint)
    • Line 474: warning: exported method MongoClient.DBRefToDeviceService should have comment or be unexported (golint)
    • Line 484: warning: exported method MongoClient.DeviceServiceToDBRef should have comment or be unexported (golint)
    • Line 499: warning: exported method MongoClient.GetDeviceServiceByName should have comment or be unexported (golint)
    • Line 507: warning: exported method MongoClient.GetDeviceServiceById should have comment or be unexported (golint)
    • Line 523: warning: exported method MongoClient.GetAllDeviceServices should have comment or be unexported (golint)
    • Line 527: warning: exported method MongoClient.GetDeviceServicesByAddressableId should have comment or be unexported (golint)
    • Line 535: warning: exported method MongoClient.GetDeviceServicesWithLabel should have comment or be unexported (golint)
    • Line 579: warning: exported method MongoClient.AddDeviceService should have comment or be unexported (golint)
    • Line 597: warning: exported method MongoClient.UpdateDeviceService should have comment or be unexported (golint)
    • Line 609: warning: exported method MongoClient.DeleteDeviceServiceById should have comment or be unexported (golint)
    • Line 613: warning: comment on exported method MongoClient.GetAllProvisionWatchers should be of the form "GetAllProvisionWatchers ..." (golint)
    • Line 618: warning: exported method MongoClient.GetProvisionWatcherByName should have comment or be unexported (golint)
    • Line 622: warning: exported method MongoClient.GetProvisionWatchersByIdentifier should have comment or be unexported (golint)
    • Line 626: warning: exported method MongoClient.GetProvisionWatchersByServiceId should have comment or be unexported (golint)
    • Line 634: warning: exported method MongoClient.GetProvisionWatchersByProfileId should have comment or be unexported (golint)
    • Line 642: warning: exported method MongoClient.GetProvisionWatcherById should have comment or be unexported (golint)
    • Line 656: warning: exported method MongoClient.GetProvisionWatcher should have comment or be unexported (golint)
    • Line 708: warning: exported method MongoClient.AddProvisionWatcher should have comment or be unexported (golint)
    • Line 765: warning: exported method MongoClient.UpdateProvisionWatcher should have comment or be unexported (golint)
    • Line 777: warning: exported method MongoClient.DeleteProvisionWatcherById should have comment or be unexported (golint)
    • Line 783: warning: exported method MongoClient.DBRefToCommand should have comment or be unexported (golint)
    • Line 793: warning: exported method MongoClient.CommandToDBRef should have comment or be unexported (golint)
    • Line 809: warning: exported method MongoClient.GetAllCommands should have comment or be unexported (golint)
    • Line 818: warning: exported method MongoClient.GetCommandById should have comment or be unexported (golint)
    • Line 842: warning: exported method MongoClient.GetCommandByName should have comment or be unexported (golint)
    • Line 865: warning: exported method MongoClient.AddCommand should have comment or be unexported (golint)
    • Line 880: warning: comment on exported method MongoClient.UpdateCommand should be of the form "UpdateCommand ..." (golint)
    • Line 893: warning: comment on exported method MongoClient.DeleteCommandById should be of the form "DeleteCommandById ..." (golint)
    • Line 922: warning: exported method MongoClient.GetAndMapCommands should have comment or be unexported (golint)
    • Line 937: warning: comment on exported method MongoClient.ScrubMetadata should be of the form "ScrubMetadata ..." (golint)
    • edgex/pkg/clients/metadata/device_profile.go
    • Line 26: warning: comment on exported type DeviceProfileClient should be of the form "DeviceProfileClient ..." (with optional leading article) (golint)
    • Line 39: warning: exported type DeviceProfileRestClient should have comment or be unexported (golint)
    • Line 43: warning: comment on exported function NewDeviceProfileClient should be of the form "NewDeviceProfileClient ..." (golint)
    • Line 50: warning: context.Context should be the first parameter of a function (golint)
    • Line 62: warning: context.Context should be the first parameter of a function (golint)
    • Line 74: warning: context.Context should be the first parameter of a function (golint)
    • Line 79: warning: context.Context should be the first parameter of a function (golint)
    • Line 83: warning: comment on exported method DeviceProfileRestClient.DeleteByName should be of the form "DeleteByName ..." (golint)
    • Line 84: warning: context.Context should be the first parameter of a function (golint)
    • Line 88: warning: comment on exported method DeviceProfileRestClient.DeviceProfile should be of the form "DeviceProfile ..." (golint)
    • Line 89: warning: context.Context should be the first parameter of a function (golint)
    • Line 93: warning: comment on exported method DeviceProfileRestClient.DeviceProfiles should be of the form "DeviceProfiles ..." (golint)
    • Line 98: warning: comment on exported method DeviceProfileRestClient.DeviceProfileForName should be of the form "DeviceProfileForName ..." (golint)
    • Line 99: warning: context.Context should be the first parameter of a function (golint)
    • Line 104: warning: context.Context should be the first parameter of a function (golint)
    • Line 108: warning: context.Context should be the first parameter of a function (golint)
    • Line 108: warning: exported method DeviceProfileRestClient.Upload should have comment or be unexported (golint)
    • Line 114: warning: context.Context should be the first parameter of a function (golint)
    • Line 114: warning: exported method DeviceProfileRestClient.UploadFile should have comment or be unexported (golint)
    • edgex/pkg/models/command.go
    • Line 21: warning: comment on exported type Command should be of the form "Command ..." (with optional leading article) (golint)
    • Line 35: warning: comment on exported method Command.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 72: warning: exported method Command.UnmarshalJSON should have comment or be unexported (golint)
    • edgex/internal/support/notifications/interfaces/db.go
    • Line 24: warning: exported type DatabaseType should have comment or be unexported (golint)
    • Line 26: warning: exported const MONGO should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported type DBClient should have comment or be unexported (golint)
    • Line 77: warning: exported type DBConfiguration should have comment or be unexported (golint)
    • Line 90: warning: exported var ErrNotFound should have comment or be unexported (golint)
    • Line 91: warning: exported var ErrUnsupportedDatabase should have comment or be unexported (golint)
    • Line 92: warning: exported var ErrInvalidObjectId should have comment or be unexported (golint)
    • Line 93: warning: exported var ErrNotUnique should have comment or be unexported (golint)
    • Line 94: warning: exported var ErrSlugEmpty should have comment or be unexported (golint)
    • edgex/pkg/clients/export/distro/client.go
    • Line 24: warning: exported type DistroClient should have comment or be unexported (golint)
    • Line 32: warning: exported function NewDistroClient should have comment or be unexported (golint)
    • Line 37: warning: context.Context should be the first parameter of a function (golint)
    • edgex/internal/support/notifications/init.go
    • Line 36: warning: comment on exported var Configuration should be of the form "Configuration ..." (golint)
    • Line 39: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 41: warning: exported function Retry should have comment or be unexported (golint)
    • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 79: warning: exported function Init should have comment or be unexported (golint)
    • Line 89: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/internal/core/metadata/init.go
    • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)
    • Line 34: warning: comment on exported var Configuration should be of the form "Configuration ..." (golint)
    • Line 37: warning: exported var LoggingClient should have comment or be unexported (golint)
    • Line 40: warning: exported function Retry should have comment or be unexported (golint)
    • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 81: warning: exported function Init should have comment or be unexported (golint)
    • Line 91: warning: exported function Destruct should have comment or be unexported (golint)
    • edgex/internal/core/data/errors/types.go
    • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
    • Line 22: warning: exported type ErrEventNotFound should have comment or be unexported (golint)
    • Line 30: warning: exported function NewErrEventNotFound should have comment or be unexported (golint)
    • Line 34: warning: exported type ErrValueDescriptorInvalid should have comment or be unexported (golint)
    • Line 43: warning: exported function NewErrValueDescriptorInvalid should have comment or be unexported (golint)
    • Line 47: warning: exported type ErrUnsupportedDatabase should have comment or be unexported (golint)
    • Line 55: warning: exported function NewErrUnsupportedDatabase should have comment or be unexported (golint)
    • Line 59: warning: exported type ErrUnsupportedPublisher should have comment or be unexported (golint)
    • Line 67: warning: exported function NewErrUnsupportedPublisher should have comment or be unexported (golint)
    • Line 71: warning: exported type ErrLimitExceeded should have comment or be unexported (golint)
    • Line 79: warning: exported function NewErrLimitExceeded should have comment or be unexported (golint)
    • Line 83: warning: exported type ErrJsonDecoding should have comment or be unexported (golint)
    • Line 91: warning: exported function NewErrJsonDecoding should have comment or be unexported (golint)
    • Line 95: warning: exported type ErrDbNotFound should have comment or be unexported (golint)
    • Line 102: warning: exported function NewErrDbNotFound should have comment or be unexported (golint)
    • Line 106: warning: exported type ErrInvalidId should have comment or be unexported (golint)
    • Line 114: warning: exported function NewErrInvalidId should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/provisionwatcher.go
    • Line 24: warning: exported type ProvisionWatcher should have comment or be unexported (golint)
    • Line 37: warning: exported method ProvisionWatcher.ToContract should have comment or be unexported (golint)
    • Line 73: warning: exported method ProvisionWatcher.FromContract should have comment or be unexported (golint)
    • Line 107: warning: exported method ProvisionWatcher.TimestampForUpdate should have comment or be unexported (golint)
    • Line 111: warning: exported method ProvisionWatcher.TimestampForAdd should have comment or be unexported (golint)
    • edgex/pkg/clients/types/errors.go
    • Line 19: warning: exported type ErrNotFound should have comment or be unexported (golint)
    • Line 25: warning: exported type ErrResponseNil should have comment or be unexported (golint)
    • Line 31: warning: exported type ErrServiceClient should have comment or be unexported (golint)
    • Line 36: warning: exported function NewErrServiceClient should have comment or be unexported (golint)
    • edgex/internal/pkg/db/bolt/scheduler.go
    • Line 27: warning: comment on exported method BoltClient.Intervals should be of the form "Intervals ..." (golint)
    • Line 34: warning: comment on exported method BoltClient.IntervalsWithLimit should be of the form "IntervalsWithLimit ..." (golint)
    • Line 41: warning: comment on exported method BoltClient.IntervalByName should be of the form "IntervalByName ..." (golint)
    • Line 49: warning: comment on exported method BoltClient.IntervalById should be of the form "IntervalById ..." (golint)
    • Line 57: warning: comment on exported method BoltClient.AddInterval should be of the form "AddInterval ..." (golint)
    • Line 76: warning: comment on exported method BoltClient.UpdateInterval should be of the form "UpdateInterval ..." (golint)
    • Line 83: warning: comment on exported method BoltClient.DeleteIntervalById should be of the form "DeleteIntervalById ..." (golint)
    • Line 91: warning: comment on exported method BoltClient.IntervalActions should be of the form "IntervalActions ..." (golint)
    • Line 100: warning: comment on exported method BoltClient.IntervalActionsWithLimit should be of the form "IntervalActionsWithLimit ..." (golint)
    • Line 109: warning: comment on exported method BoltClient.IntervalActionsByIntervalName should be of the form "IntervalActionsByIntervalName ..." (golint)
    • Line 122: warning: comment on exported method BoltClient.IntervalActionsByTarget should be of the form "IntervalActionsByTarget ..." (golint)
    • Line 135: warning: comment on exported method BoltClient.IntervalActionById should be of the form "IntervalActionById ..." (golint)
    • Line 144: warning: comment on exported method BoltClient.IntervalActionByName should be of the form "IntervalActionByName ..." (golint)
    • Line 153: warning: comment on exported method BoltClient.AddIntervalAction should be of the form "AddIntervalAction ..." (golint)
    • Line 172: warning: comment on exported method BoltClient.UpdateIntervalAction should be of the form "UpdateIntervalAction ..." (golint)
    • Line 179: warning: comment on exported method BoltClient.DeleteIntervalActionById should be of the form "DeleteIntervalActionById ..." (golint)
    • Line 269: warning: comment on exported method BoltClient.ScrubAllIntervalActions should be of the form "ScrubAllIntervalActions ..." (golint)
    • Line 280: warning: comment on exported method BoltClient.ScrubAllIntervals should be of the form "ScrubAllIntervals ..." (golint)
    • edgex/pkg/models/units.go
    • Line 19: warning: exported type Units should have comment or be unexported (golint)
    • Line 25: warning: comment on exported method Units.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/internal/pkg/db/mongo/models/interval.go
    • Line 23: warning: exported type Interval should have comment or be unexported (golint)
    • Line 37: warning: exported method Interval.ToContract should have comment or be unexported (golint)
    • Line 57: warning: exported method Interval.FromContract should have comment or be unexported (golint)
    • Line 77: warning: exported method Interval.TimestampForUpdate should have comment or be unexported (golint)
    • Line 81: warning: exported method Interval.TimestampForAdd should have comment or be unexported (golint)
    • edgex/internal/pkg/db/bolt/metadata.go
    • Line 1: warning: package comment should be of the form "Package bolt ..." (golint)
    • Line 26: warning: comment on exported method BoltClient.AddDevice should be of the form "AddDevice ..." (golint)
    • Line 42: warning: exported method BoltClient.UpdateDevice should have comment or be unexported (golint)
    • Line 48: warning: exported method BoltClient.DeleteDeviceById should have comment or be unexported (golint)
    • Line 52: warning: exported method BoltClient.GetAllDevices should have comment or be unexported (golint)
    • Line 58: warning: exported method BoltClient.GetDeviceById should have comment or be unexported (golint)
    • Line 65: warning: exported method BoltClient.GetDeviceByName should have comment or be unexported (golint)
    • Line 72: warning: exported method BoltClient.GetDevicesByServiceId should have comment or be unexported (golint)
    • Line 88: warning: exported method BoltClient.GetDevicesByAddressableId should have comment or be unexported (golint)
    • Line 104: warning: exported method BoltClient.GetDevicesByProfileId should have comment or be unexported (golint)
    • Line 120: warning: exported method BoltClient.GetDevicesWithLabel should have comment or be unexported (golint)
    • Line 157: warning: comment on exported method BoltClient.GetDeviceProfileById should be of the form "GetDeviceProfileById ..." (golint)
    • Line 165: warning: exported method BoltClient.GetAllDeviceProfiles should have comment or be unexported (golint)
    • Line 171: warning: exported method BoltClient.GetDeviceProfilesByModel should have comment or be unexported (golint)
    • Line 181: warning: exported method BoltClient.GetDeviceProfilesWithLabel should have comment or be unexported (golint)
    • Line 193: warning: exported method BoltClient.GetDeviceProfilesByManufacturerModel should have comment or be unexported (golint)
    • Line 204: warning: exported method BoltClient.GetDeviceProfilesByManufacturer should have comment or be unexported (golint)
    • Line 239: warning: exported method BoltClient.GetDeviceProfileByName should have comment or be unexported (golint)
    • Line 246: warning: exported method BoltClient.AddDeviceProfile should have comment or be unexported (golint)
    • Line 256: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 269: warning: exported method BoltClient.UpdateDeviceProfile should have comment or be unexported (golint)
    • Line 275: warning: comment on exported method BoltClient.GetDeviceProfilesByCommandId should be of the form "GetDeviceProfilesByCommandId ..." (golint)
    • Line 294: warning: exported method BoltClient.DeleteDeviceProfileById should have comment or be unexported (golint)
    • Line 298: warning: comment on exported method BoltClient.UpdateAddressable should be of the form "UpdateAddressable ..." (golint)
    • Line 305: warning: exported method BoltClient.GetAddressables should have comment or be unexported (golint)
    • Line 336: warning: exported method BoltClient.GetAddressableById should have comment or be unexported (golint)
    • Line 342: warning: exported method BoltClient.AddAddressable should have comment or be unexported (golint)
    • Line 358: warning: exported method BoltClient.GetAddressableByName should have comment or be unexported (golint)
    • Line 364: warning: exported method BoltClient.GetAddressablesByTopic should have comment or be unexported (golint)
    • Line 374: warning: exported method BoltClient.GetAddressablesByPort should have comment or be unexported (golint)
    • Line 384: warning: exported method BoltClient.GetAddressablesByPublisher should have comment or be unexported (golint)
    • Line 394: warning: exported method BoltClient.GetAddressablesByAddress should have comment or be unexported (golint)
    • Line 404: warning: exported method BoltClient.DeleteAddressableById should have comment or be unexported (golint)
    • Line 408: warning: comment on exported method BoltClient.GetDeviceServiceByName should be of the form "GetDeviceServiceByName ..." (golint)
    • Line 416: warning: exported method BoltClient.GetDeviceServiceById should have comment or be unexported (golint)
    • Line 423: warning: exported method BoltClient.GetAllDeviceServices should have comment or be unexported (golint)
    • Line 429: warning: exported method BoltClient.GetDeviceServicesByAddressableId should have comment or be unexported (golint)
    • Line 445: warning: exported method BoltClient.GetDeviceServicesWithLabel should have comment or be unexported (golint)
    • Line 482: warning: exported method BoltClient.AddDeviceService should have comment or be unexported (golint)
    • Line 497: warning: exported method BoltClient.UpdateDeviceService should have comment or be unexported (golint)
    • Line 503: warning: exported method BoltClient.DeleteDeviceServiceById should have comment or be unexported (golint)
    • Line 507: warning: comment on exported method BoltClient.GetAllProvisionWatchers should be of the form "GetAllProvisionWatchers ..." (golint)
    • Line 514: warning: exported method BoltClient.GetProvisionWatcherByName should have comment or be unexported (golint)
    • Line 521: warning: exported method BoltClient.GetProvisionWatchersByIdentifier should have comment or be unexported (golint)
    • Line 532: warning: exported method BoltClient.GetProvisionWatchersByServiceId should have comment or be unexported (golint)
    • Line 548: warning: exported method BoltClient.GetProvisionWatchersByProfileId should have comment or be unexported (golint)
    • Line 564: warning: exported method BoltClient.GetProvisionWatcherById should have comment or be unexported (golint)
    • Line 596: warning: exported method BoltClient.AddProvisionWatcher should have comment or be unexported (golint)
    • Line 611: warning: exported method BoltClient.UpdateProvisionWatcher should have comment or be unexported (golint)
    • Line 617: warning: exported method BoltClient.DeleteProvisionWatcherById should have comment or be unexported (golint)
    • Line 621: warning: comment on exported method BoltClient.GetAllCommands should be of the form "GetAllCommands ..." (golint)
    • Line 653: warning: exported method BoltClient.GetCommandById should have comment or be unexported (golint)
    • Line 659: warning: exported method BoltClient.GetCommandByName should have comment or be unexported (golint)
    • Line 669: warning: exported method BoltClient.AddCommand should have comment or be unexported (golint)
    • Line 677: warning: exported method BoltClient.UpdateCommand should have comment or be unexported (golint)
    • Line 682: warning: exported method BoltClient.DeleteCommandById should have comment or be unexported (golint)
    • Line 686: warning: comment on exported method BoltClient.ScrubMetadata should be of the form "ScrubMetadata ..." (golint)
    • edgex/pkg/clients/metadata/provision_watcher.go
    • Line 26: warning: comment on exported type ProvisionWatcherClient should be of the form "ProvisionWatcherClient ..." (with optional leading article) (golint)
    • Line 42: warning: exported type ProvisionWatcherRestClient should have comment or be unexported (golint)
    • Line 46: warning: comment on exported function NewProvisionWatcherClient should be of the form "NewProvisionWatcherClient ..." (golint)
    • Line 55: warning: context.Context should be the first parameter of a function (golint)
    • Line 67: warning: context.Context should be the first parameter of a function (golint)
    • Line 78: warning: comment on exported method ProvisionWatcherRestClient.ProvisionWatcher should be of the form "ProvisionWatcher ..." (golint)
    • Line 79: warning: context.Context should be the first parameter of a function (golint)
    • Line 83: warning: comment on exported method ProvisionWatcherRestClient.ProvisionWatchers should be of the form "ProvisionWatchers ..." (golint)
    • Line 88: warning: comment on exported method ProvisionWatcherRestClient.ProvisionWatcherForName should be of the form "ProvisionWatcherForName ..." (golint)
    • Line 89: warning: context.Context should be the first parameter of a function (golint)
    • Line 93: warning: comment on exported method ProvisionWatcherRestClient.ProvisionWatchersForService should be of the form "ProvisionWatchersForService ..." (golint)
    • Line 94: warning: context.Context should be the first parameter of a function (golint)
    • Line 98: warning: comment on exported method ProvisionWatcherRestClient.ProvisionWatchersForServiceByName should be of the form "ProvisionWatchersForServiceByName ..." (golint)
    • Line 99: warning: context.Context should be the first parameter of a function (golint)
    • Line 103: warning: comment on exported method ProvisionWatcherRestClient.ProvisionWatchersForProfile should be of the form "ProvisionWatchersForProfile ..." (golint)
    • Line 104: warning: context.Context should be the first parameter of a function (golint)
    • Line 108: warning: comment on exported method ProvisionWatcherRestClient.ProvisionWatchersForProfileByName should be of the form "ProvisionWatchersForProfileByName ..." (golint)
    • Line 109: warning: context.Context should be the first parameter of a function (golint)
    • Line 114: warning: context.Context should be the first parameter of a function (golint)
    • Line 119: warning: context.Context should be the first parameter of a function (golint)
    • Line 124: warning: context.Context should be the first parameter of a function (golint)
    • edgex/pkg/models/baseobject.go
    • Line 21: warning: exported type BaseObject should have comment or be unexported (golint)
    • Line 41: warning: receiver name ba should be consistent with previous receiver name o for BaseObject (golint)
    • edgex/internal/pkg/db/mongo/models/device.go
    • Line 26: warning: comment on exported type Device should be of the form "Device ..." (with optional leading article) (golint)
    • Line 53: warning: exported method Device.ToContract should have comment or be unexported (golint)
    • Line 111: warning: exported method Device.FromContract should have comment or be unexported (golint)
    • Line 159: warning: exported method Device.TimestampForUpdate should have comment or be unexported (golint)
    • Line 163: warning: exported method Device.TimestampForAdd should have comment or be unexported (golint)
    • edgex/pkg/clients/logger/logger.go
    • Line 43: warning: exported var LogLevels should have comment or be unexported (golint)
    • Line 50: warning: exported type LoggingClient should have comment or be unexported (golint)
    • Line 59: warning: exported type EdgeXLogger should have comment or be unexported (golint)
    • Line 72: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 202: warning: comment on exported method EdgeXLogger.Info should be of the form "Info ..." (golint)
    • Line 207: warning: comment on exported method EdgeXLogger.Trace should be of the form "Trace ..." (golint)
    • Line 212: warning: comment on exported method EdgeXLogger.Debug should be of the form "Debug ..." (golint)
    • Line 217: warning: comment on exported method EdgeXLogger.Warn should be of the form "Warn ..." (golint)
    • edgex/internal/support/scheduler/schedule.go
    • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)
    • Line 34: warning: exported function StartTicker should have comment or be unexported (golint)
    • Line 42: warning: exported function StopTicker should have comment or be unexported (golint)
    • Line 89: warning: exported method QueueClient.Connect should have comment or be unexported (golint)
    • Line 92: warning: exported method QueueClient.QueryIntervalByID should have comment or be unexported (golint)
    • Line 108: warning: exported method QueueClient.QueryIntervalByName should have comment or be unexported (golint)
    • Line 124: warning: exported method QueueClient.AddIntervalToQueue should have comment or be unexported (golint)
    • Line 151: warning: exported method QueueClient.UpdateIntervalInQueue should have comment or be unexported (golint)
    • Line 179: warning: exported method QueueClient.RemoveIntervalInQueue should have comment or be unexported (golint)
    • Line 203: warning: exported method QueueClient.QueryIntervalActionByID should have comment or be unexported (golint)
    • Line 228: warning: exported method QueueClient.QueryIntervalActionByName should have comment or be unexported (golint)
    • Line 263: warning: exported method QueueClient.AddIntervalActionToQueue should have comment or be unexported (golint)
    • Line 304: warning: exported method QueueClient.UpdateIntervalActionQueue should have comment or be unexported (golint)
    • Line 368: warning: exported method QueueClient.RemoveIntervalActionQueue should have comment or be unexported (golint)
    • edgex/internal/pkg/db/mongo/models/interval_action.go
    • Line 9: warning: exported type IntervalAction should have comment or be unexported (golint)
    • Line 30: warning: exported method IntervalAction.ToContract should have comment or be unexported (golint)
    • Line 58: warning: exported method IntervalAction.FromContract should have comment or be unexported (golint)
    • Line 85: warning: exported method IntervalAction.TimestampForUpdate should have comment or be unexported (golint)
    • Line 89: warning: exported method IntervalAction.TimestampForAdd should have comment or be unexported (golint)
    • edgex/pkg/clients/coredata/event.go
    • Line 29: warning: exported type EventClient should have comment or be unexported (golint)
    • Line 45: warning: exported type EventRestClient should have comment or be unexported (golint)
    • Line 49: warning: exported function NewEventClient should have comment or be unexported (golint)
    • Line 55: warning: context.Context should be the first parameter of a function (golint)
    • Line 67: warning: context.Context should be the first parameter of a function (golint)
    • Line 78: warning: comment on exported method EventRestClient.Events should be of the form "Events ..." (golint)
    • Line 83: warning: comment on exported method EventRestClient.EventsUnpushed should be of the form "EventsUnpushed ..." (golint)
    • Line 88: warning: comment on exported method EventRestClient.Event should be of the form "Event ..." (golint)
    • Line 89: warning: context.Context should be the first parameter of a function (golint)
    • Line 93: warning: comment on exported method EventRestClient.EventCount should be of the form "EventCount ..." (golint)
    • Line 98: warning: comment on exported method EventRestClient.EventCountForDevice should be of the form "EventCountForDevice ..." (golint)
    • Line 99: warning: context.Context should be the first parameter of a function (golint)
    • Line 103: warning: comment on exported method EventRestClient.EventsForDevice should be of the form "EventsForDevice ..." (golint)
    • Line 104: warning: context.Context should be the first parameter of a function (golint)
    • Line 108: warning: comment on exported method EventRestClient.EventsForInterval should be of the form "EventsForInterval ..." (golint)
    • Line 109: warning: context.Context should be the first parameter of a function (golint)
    • Line 113: warning: comment on exported method EventRestClient.EventsForDeviceAndValueDescriptor should be of the form "EventsForDeviceAndValueDescriptor ..." (golint)
    • Line 114: warning: context.Context should be the first parameter of a function (golint)
    • Line 119: warning: context.Context should be the first parameter of a function (golint)
    • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 129: warning: context.Context should be the first parameter of a function (golint)
    • Line 133: warning: comment on exported method EventRestClient.DeleteForDevice should be of the form "DeleteForDevice ..." (golint)
    • Line 134: warning: context.Context should be the first parameter of a function (golint)
    • Line 138: warning: comment on exported method EventRestClient.DeleteOld should be of the form "DeleteOld ..." (golint)
    • Line 139: warning: context.Context should be the first parameter of a function (golint)
    • Line 143: warning: comment on exported method EventRestClient.MarkPushed should be of the form "MarkPushed ..." (golint)
    • Line 144: warning: context.Context should be the first parameter of a function (golint)
    • edgex/pkg/models/profileresource.go
    • Line 19: warning: exported type ProfileResource should have comment or be unexported (golint)
    • Line 25: warning: comment on exported method ProfileResource.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • edgex/pkg/models/resourceoperation.go
    • Line 19: warning: exported type ResourceOperation should have comment or be unexported (golint)
    • Line 29: warning: comment on exported method ResourceOperation.MarshalJSON should be of the form "MarshalJSON ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell99%

Misspell Finds commonly misspelled English words