Preparing report...

Report for github.com/Comcast/codex-svalinn

A+    Excellent!    Found 12 issues across 18 files

Tweet

gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint38%

Golint is a linter for Go source code.

    • codex-svalinn/main.go
    • Line 72: warning: exported var GitCommit should have comment or be unexported (golint)
    • Line 77: warning: exported type SvalinnConfig should have comment or be unexported (golint)
    • Line 89: warning: exported type WebhookConfig should have comment or be unexported (golint)
    • Line 99: warning: exported type SecretConfig should have comment or be unexported (golint)
    • Line 104: warning: exported type Svalinn should have comment or be unexported (golint)
    • Line 121: warning: exported type HealthConfig should have comment or be unexported (golint)
    • Line 126: warning: exported function SetLogger should have comment or be unexported (golint)
    • Line 137: warning: exported function GetLogger should have comment or be unexported (golint)
    • Line 256: warning: error should be the last type when returning multiple items (golint)
    • codex-svalinn/rules/rules.go
    • Line 32: warning: exported type RuleConfig should have comment or be unexported (golint)
    • Line 39: warning: exported type Rule should have comment or be unexported (golint)
    • Line 46: warning: exported type Rules should have comment or be unexported (golint)
    • Line 48: warning: exported function NewRules should have comment or be unexported (golint)
    • Line 63: warning: exported method Rules.FindRule should have comment or be unexported (golint)
    • Line 72: warning: exported method Rule.EventType should have comment or be unexported (golint)
    • Line 76: warning: exported method Rule.StorePayload should have comment or be unexported (golint)
    • Line 80: warning: exported method Rule.TTL should have comment or be unexported (golint)
    • codex-svalinn/requestParser/metrics.go
    • Line 18: warning: don't use MixedCaps in package name; requestParser should be requestparser (golint)
    • Line 29: warning: exported const ParsingQueueDepth should have comment (or a comment on this block) or be unexported (golint)
    • Line 53: warning: exported function Metrics should have comment or be unexported (golint)
    • Line 75: warning: exported type Measures should have comment or be unexported (golint)
    • Line 81: warning: exported type EventTypeMetrics should have comment or be unexported (golint)
    • codex-svalinn/requestParser/requestParser.go
    • Line 1: warning: don't use MixedCaps in package name; requestParser should be requestparser (golint)
    • Line 42: warning: exported type TimeTracker should have comment or be unexported (golint)
    • Line 50: warning: exported type Config should have comment or be unexported (golint)
    • Line 59: warning: exported type RequestParser should have comment or be unexported (golint)
    • Line 75: warning: exported type WrpWithTime should have comment or be unexported (golint)
    • Line 80: warning: exported function NewRequestParser should have comment or be unexported (golint)
    • Line 141: warning: exported method RequestParser.Start should have comment or be unexported (golint)
    • Line 146: warning: exported method RequestParser.Parse should have comment or be unexported (golint)
    • Line 161: warning: exported method RequestParser.Stop should have comment or be unexported (golint)
    • codex-svalinn/metrics.go
    • Line 29: warning: exported const TimeInMemory should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported function Metrics should have comment or be unexported (golint)
    • Line 42: warning: exported type Measures should have comment or be unexported (golint)
    • Line 53: warning: exported method Measures.TrackTime should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!