Preparing report...

Report for github.com/ConorNevin/xmlrpc

A    Great!    Found 8 issues across 10 files

Tweet

gofmt70%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo80%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • xmlrpc/decoder.go
    • Line 70: warning: cyclomatic complexity 87 of function (*decoder).decodeValue() is high (> 15) (gocyclo)

golint50%

Golint is a linter for Go source code.

    • xmlrpc/request.go
    • Line 9: warning: exported function NewRequest should have comment or be unexported (golint)
    • Line 34: warning: exported function EncodeMethodCall should have comment or be unexported (golint)
    • xmlrpc/response.go
    • Line 23: warning: exported type Response should have comment or be unexported (golint)
    • Line 27: warning: exported function NewResponse should have comment or be unexported (golint)
    • Line 33: warning: exported method Response.Failed should have comment or be unexported (golint)
    • Line 37: warning: exported method Response.Err should have comment or be unexported (golint)
    • Line 46: warning: exported method Response.Unmarshal should have comment or be unexported (golint)
    • xmlrpc/decoder.go
    • Line 22: warning: error var invalidXmlError should have name of the form errFoo (golint)
    • Line 25: warning: exported type TypeMismatchError should have comment or be unexported (golint)
    • Line 90: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 420: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign80%

IneffAssign detects ineffectual assignments in Go code.

    • xmlrpc/client_test.go
    • Line 10: warning: cannot find package "." in: (ineffassign)
    • Line 11: warning: cannot find package "." in: (ineffassign)
    • Line 10: warning: could not import github.com/divan/gorilla-xmlrpc/xml (invalid package name: "") (ineffassign)
    • Line 11: warning: could not import github.com/gorilla/rpc (invalid package name: "") (ineffassign)
    • xmlrpc/decoder_test.go
    • Line 11: warning: cannot find package "." in: (ineffassign)
    • Line 12: warning: cannot find package "." in: (ineffassign)
    • Line 11: warning: could not import golang.org/x/text/encoding/charmap (invalid package name: "") (ineffassign)
    • Line 12: warning: could not import golang.org/x/text/transform (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!