Report for github.com/ConsenSys/fc-latency-map
A+ Excellent! Found 52 issues across 103 files
gofmt96%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
fc-latency-map/manager/measurements/measurements_impl_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
fc-latency-map/extern/ripe-atlas/cmd/atlas/config_unix.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
fc-latency-map/extern/ripe-atlas/cmd/atlas/config_windows.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
fc-latency-map/manager/miners/miners_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo99%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
fc-latency-map/extern/ripe-atlas/cmd/atlas/atlas.go
- Line 118: warning: cyclomatic complexity 19 of function finalcheck() is high (> 15) (gocyclo)
golint54%
Golint is a linter for Go source code.
-
-
fc-latency-map/manager/locations/locations_impl.go
- Line 20: warning: exported type Airport should have comment or be unexported (golint)
- Line 29: warning: exported type LocationServiceImpl should have comment or be unexported (golint)
- Line 34: warning: exported function NewLocationServiceImpl should have comment or be unexported (golint)
- Line 41: warning: exported method LocationServiceImpl.GetAllLocations should have comment or be unexported (golint)
- Line 55: warning: exported method LocationServiceImpl.GetTotalLocations should have comment or be unexported (golint)
- Line 61: warning: exported method LocationServiceImpl.GetLocation should have comment or be unexported (golint)
- Line 68: warning: exported method LocationServiceImpl.AddLocation should have comment or be unexported (golint)
- Line 80: warning: exported method LocationServiceImpl.DeleteLocation should have comment or be unexported (golint)
- Line 91: warning: exported method LocationServiceImpl.UpdateLocations should have comment or be unexported (golint)
- Line 189: warning: exported method LocationServiceImpl.ExtractAirports should have comment or be unexported (golint)
- Line 210: warning: exported method LocationServiceImpl.FindAirport should have comment or be unexported (golint)
-
-
fc-latency-map/manager/geomgr/geomgr_impl.go
- Line 15: warning: exported type GeoMgrImpl should have comment or be unexported (golint)
- Line 21: warning: exported function NewGeoMgrImpl should have comment or be unexported (golint)
- Line 27: warning: exported method GeoMgrImpl.IPGeolocation should have comment or be unexported (golint)
- Line 82: warning: exported method GeoMgrImpl.FindCountry should have comment or be unexported (golint)
-
-
fc-latency-map/manager/models/location.go
- Line 7: warning: exported type Location should have comment or be unexported (golint)
-
-
fc-latency-map/manager/jobs/measure.go
- Line 16: warning: exported function RunTaskCreateMeasures should have comment or be unexported (golint)
- Line 36: warning: exported function RunTaskImportMeasures should have comment or be unexported (golint)
-
-
fc-latency-map/manager/export/export.go
- Line 5: warning: exported type Service should have comment or be unexported (golint)
-
-
fc-latency-map/manager/probes/probes.go
- Line 9: warning: exported type Miner should have comment or be unexported (golint)
- Line 14: warning: exported type ProbeService should have comment or be unexported (golint)
-
-
fc-latency-map/manager/cli/cli.go
- Line 7: warning: exported type Commander should have comment or be unexported (golint)
-
-
fc-latency-map/manager/db/mocks.go
- Line 11: warning: exported type DatabaseMgrMock should have comment or be unexported (golint)
- Line 15: warning: exported function NewMockDatabaseMgr should have comment or be unexported (golint)
- Line 36: warning: exported method DatabaseMgrMock.GetDB should have comment or be unexported (golint)
-
-
fc-latency-map/manager/addresses/addresses.go
- Line 11: warning: exported function MultiAddrs should have comment or be unexported (golint)
- Line 22: warning: exported function IPAddress should have comment or be unexported (golint)
- Line 38: warning: exported function GetIPVersion should have comment or be unexported (golint)
-
-
fc-latency-map/manager/probes/probes_impl.go
- Line 19: warning: exported type ProbeServiceImpl should have comment or be unexported (golint)
- Line 29: warning: exported function NewProbeServiceImpl should have comment or be unexported (golint)
- Line 37: warning: exported method ProbeServiceImpl.RequestProbes should have comment or be unexported (golint)
- Line 119: warning: exported method ProbeServiceImpl.ListProbes should have comment or be unexported (golint)
- Line 129: warning: exported method ProbeServiceImpl.GetTotalProbes should have comment or be unexported (golint)
- Line 135: warning: exported method ProbeServiceImpl.Update should have comment or be unexported (golint)
- Line 148: warning: exported method ProbeServiceImpl.ImportProbes should have comment or be unexported (golint)
-
-
fc-latency-map/manager/db/dbmgr.go
- Line 7: warning: exported type DatabaseMgr should have comment or be unexported (golint)
-
-
fc-latency-map/manager/config/config.go
- Line 12: warning: exported function NewConfig should have comment or be unexported (golint)
-
-
fc-latency-map/manager/locations/locations_handlers.go
- Line 14: warning: exported type LocationHandler should have comment or be unexported (golint)
- Line 19: warning: exported function NewLocationHandler should have comment or be unexported (golint)
-
-
fc-latency-map/manager/measurements/measurements.go
- Line 11: warning: exported type MeasurementService should have comment or be unexported (golint)
-
-
fc-latency-map/manager/models/measurement.go
- Line 7: warning: exported type Measurement should have comment or be unexported (golint)
- Line 17: warning: exported type MeasurementResult should have comment or be unexported (golint)
-
-
fc-latency-map/manager/probes/probes_cli.go
- Line 18: warning: exported type ProbeCommander should have comment or be unexported (golint)
- Line 22: warning: exported function NewProbeCommander should have comment or be unexported (golint)
-
-
fc-latency-map/manager/probes/probes_handlers.go
- Line 14: warning: exported type ProbeHandler should have comment or be unexported (golint)
- Line 18: warning: exported function NewProbeHandler should have comment or be unexported (golint)
-
-
fc-latency-map/manager/ripemgr/ripemgr_impl.go
- Line 17: warning: exported type RipeMgrImpl should have comment or be unexported (golint)
- Line 29: warning: exported function NewRipeImpl should have comment or be unexported (golint)
- Line 49: warning: exported method RipeMgrImpl.GetProbes should have comment or be unexported (golint)
- Line 61: warning: exported method RipeMgrImpl.GetMeasurement should have comment or be unexported (golint)
- Line 74: warning: exported method RipeMgrImpl.GetMeasurementResults should have comment or be unexported (golint)
- Line 90: warning: exported method RipeMgrImpl.CreateMeasurements should have comment or be unexported (golint)
-
-
fc-latency-map/manager/measurements/measurements_cli.go
- Line 20: warning: exported type MesuresCommander should have comment or be unexported (golint)
- Line 25: warning: exported function NewMesuresCommander should have comment or be unexported (golint)
-
-
fc-latency-map/extern/ripe-atlas/types.go
- Line 324: warning: exported type Answers should have comment or be unexported (golint)
- Line 333: warning: exported type Resultset should have comment or be unexported (golint)
-
-
fc-latency-map/manager/models/miner.go
- Line 7: warning: exported type Miner should have comment or be unexported (golint)
-
-
fc-latency-map/manager/constants/airport.go
- Line 4: warning: exported const AirportTypeSmall should have comment (or a comment on this block) or be unexported (golint)
-
-
fc-latency-map/manager/filecoinmgr/filecoinmgr.go
- Line 12: warning: exported type FilecoinMgr should have comment or be unexported (golint)
-
-
fc-latency-map/manager/locations/locations_cli.go
- Line 20: warning: exported type LocationCommander should have comment or be unexported (golint)
- Line 24: warning: exported function NewLocationCommander should have comment or be unexported (golint)
-
-
fc-latency-map/manager/seeds/seeder_cli.go
- Line 16: warning: exported type SeederCommander should have comment or be unexported (golint)
- Line 19: warning: exported function NewSeederCommander should have comment or be unexported (golint)
-
-
fc-latency-map/manager/miners/miners.go
- Line 9: warning: exported type MinerService should have comment or be unexported (golint)
-
-
fc-latency-map/manager/geomgr/geomgr.go
- Line 5: warning: exported type GeoMgr should have comment or be unexported (golint)
-
-
fc-latency-map/manager/models/probes.go
- Line 7: warning: exported type CoordinatesStatus should have comment or be unexported (golint)
- Line 8: warning: exported type Status should have comment or be unexported (golint)
- Line 11: warning: exported const CoordinatesStatusUnknown should have comment (or a comment on this block) or be unexported (golint)
- Line 18: warning: exported type Probe should have comment or be unexported (golint)
-
-
fc-latency-map/manager/config/mocks.go
- Line 7: warning: comment on exported function NewMockConfig should be of the form "NewMockConfig ..." (golint)
-
-
fc-latency-map/manager/cmd/cli/main.go
- Line 21: warning: exported type LatencyMapCLI should have comment or be unexported (golint)
-
-
fc-latency-map/manager/seeds/seeder.go
- Line 14: warning: exported function Seed should have comment or be unexported (golint)
- Line 27: warning: comment on exported function Execute should be of the form "Execute ..." (golint)
-
-
fc-latency-map/manager/miners/miners_cli.go
- Line 20: warning: exported type MinerCommander should have comment or be unexported (golint)
- Line 24: warning: exported function NewMinerCommander should have comment or be unexported (golint)
-
-
fc-latency-map/manager/miners/miners_handlers.go
- Line 18: warning: exported type MinerHandler should have comment or be unexported (golint)
- Line 23: warning: exported function NewMinerHandler should have comment or be unexported (golint)
- Line 44: warning: exported method MinerHandler.GetAllMiners should have comment or be unexported (golint)
- Line 48: warning: exported method MinerHandler.MinersParseOffset should have comment or be unexported (golint)
- Line 64: warning: exported method MinerHandler.MinersParseBlock should have comment or be unexported (golint)
- Line 68: warning: exported method MinerHandler.MinersParseStateMarket should have comment or be unexported (golint)
-
-
fc-latency-map/manager/filecoinmgr/filecoinmgr_impl.go
- Line 19: warning: exported type VerifiedDeal should have comment or be unexported (golint)
- Line 24: warning: exported type FilecoinMgrImpl should have comment or be unexported (golint)
- Line 29: warning: exported function NewFilecoinImpl should have comment or be unexported (golint)
- Line 51: warning: exported method FilecoinMgrImpl.GetChainHead should have comment or be unexported (golint)
- Line 60: warning: exported method FilecoinMgrImpl.GetBlockHeight should have comment or be unexported (golint)
- Line 69: warning: exported method FilecoinMgrImpl.GetMinerInfo should have comment or be unexported (golint)
- Line 78: warning: exported method FilecoinMgrImpl.GetVerifiedDealsByBlockRange should have comment or be unexported (golint)
- Line 95: warning: exported function CheckIsVerifiedDeal should have comment or be unexported (golint)
- Line 105: warning: exported method FilecoinMgrImpl.GetVerifiedDealsByBlockHeight should have comment or be unexported (golint)
- Line 157: warning: exported method FilecoinMgrImpl.GetVerifiedDealsByStateMarket should have comment or be unexported (golint)
-
-
fc-latency-map/manager/webhook/notify.go
- Line 14: warning: exported type Notifier should have comment or be unexported (golint)
- Line 18: warning: exported type Payload should have comment or be unexported (golint)
- Line 23: warning: exported function NewNotifier should have comment or be unexported (golint)
- Line 29: warning: exported method Notifier.Notify should have comment or be unexported (golint)
-
-
fc-latency-map/manager/parser/parser.go
- Line 7: warning: exported function Parse should have comment or be unexported (golint)
-
-
fc-latency-map/manager/constants/countries.go
- Line 3: warning: exported type Country should have comment or be unexported (golint)
- Line 8: warning: exported var Countries should have comment or be unexported (golint)
-
-
fc-latency-map/manager/export/export_impl.go
- Line 18: warning: exported type ExportServiceImpl should have comment or be unexported (golint)
-
-
fc-latency-map/manager/export/export_model.go
- Line 7: warning: exported type Result should have comment or be unexported (golint)
- Line 14: warning: exported type Miner should have comment or be unexported (golint)
- Line 19: warning: exported type MeasureIP should have comment or be unexported (golint)
-
-
fc-latency-map/manager/locations/locations.go
- Line 9: warning: exported type LocationService should have comment or be unexported (golint)
-
-
fc-latency-map/manager/measurements/measurements_handler.go
- Line 19: warning: exported type Handler should have comment or be unexported (golint)
- Line 24: warning: exported function NewHandler should have comment or be unexported (golint)
- Line 48: warning: exported method Handler.ImportMeasures should have comment or be unexported (golint)
- Line 80: warning: exported method Handler.CreateMeasurements should have comment or be unexported (golint)
-
-
fc-latency-map/manager/geomgr/geomgr_model.go
- Line 3: warning: exported type GeoIP should have comment or be unexported (golint)
-
-
fc-latency-map/extern/ripe-atlas/errors.go
- Line 16: warning: comment on exported var ErrInvalidError should be of the form "ErrInvalidError ..." (golint)
-
-
fc-latency-map/manager/db/dbmgr_impl.go
- Line 12: warning: exported type DatabaseMgrImpl should have comment or be unexported (golint)
- Line 16: warning: exported function NewDatabaseMgrImpl should have comment or be unexported (golint)
- Line 51: warning: exported method DatabaseMgrImpl.GetDB should have comment or be unexported (golint)
-
-
fc-latency-map/manager/export/export_handler.go
- Line 8: warning: exported type ExportHandler should have comment or be unexported (golint)
- Line 12: warning: exported function NewExportHandler should have comment or be unexported (golint)
- Line 26: warning: exported method ExportHandler.Export should have comment or be unexported (golint)
-
-
fc-latency-map/manager/miners/miners_impl.go
- Line 20: warning: exported type MinerServiceImpl should have comment or be unexported (golint)
- Line 27: warning: exported function NewMinerServiceImpl should have comment or be unexported (golint)
- Line 36: warning: exported method MinerServiceImpl.GetAllMiners should have comment or be unexported (golint)
- Line 46: warning: exported method MinerServiceImpl.GetTotalMiners should have comment or be unexported (golint)
- Line 52: warning: exported method MinerServiceImpl.ParseMinersByBlockOffset should have comment or be unexported (golint)
- Line 134: warning: exported method MinerServiceImpl.ParseMinersByBlockHeight should have comment or be unexported (golint)
- Line 143: warning: exported method MinerServiceImpl.ParseMinersByStateMarket should have comment or be unexported (golint)
-
-
fc-latency-map/manager/ripemgr/ripemgr.go
- Line 11: warning: exported type RipeMgr should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!