gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• crane/src/plugins/search/router.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• crane/src/dockerclient/service.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• crane/src/dockerclient/service_helper_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• crane/src/dockerclient/service_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• crane/src/dockerclient/stack.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• crane/src/dockerclient/stack_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• crane/src/api/stack.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• crane/src/plugins/registry/client.go
  • Line 39: warning: cyclomatic complexity 22 of function (*Registry).RegistryAPI() is high (> 15) (gocyclo)

• crane/src/dockerclient/service.go
  • Line 105: warning: cyclomatic complexity 17 of function (*CraneDockerClient).GetServicesStatus() is high (> 15) (gocyclo)

golint32%

Golint is a linter for Go source code.

• crane/src/plugins/auth/group.go
  • Line 7: warning: exported type Group should have comment or be unexported (golint)
  • Line 13: warning: exported type GroupFilter should have comment or be unexported (golint)

• crane/src/api/middlewares/authorize_network_access.go
  • Line 9: warning: exported function AuthorizeNetworkAccess should have comment or be unexported (golint)

• crane/src/api/middlewares/authorize_service_access.go
  • Line 9: warning: exported function AuthorizeServiceAccess should have comment or be unexported (golint)

• crane/src/plugins/catalog/model.go
  • Line 10: warning: exported type Catalog should have comment or be unexported (golint)
  • Line 20: warning: exported function ImageHandle should have comment or be unexported (golint)
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• crane/src/dockerclient/volume_test.go
  • Line 39: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 53: warning: should not use basic type untyped string as key in context.WithValue (golint)

• crane/src/api/service.go
  • Line 23: warning: exported const CodeUpdateServiceParamError should have comment (or a comment on this block) or be unexported (golint)
  • Line 51: warning: exported method Api.ServiceCDAddr should have comment or be unexported (golint)
  • Line 55: warning: exported method Api.UpdateServiceImage should have comment or be unexported (golint)
  • Line 80: warning: comment on exported method Api.UpdateService should be of the form "UpdateService ..." (golint)
  • Line 168: warning: exported method Api.InspectService should have comment or be unexported (golint)
  • Line 187: warning: comment on exported method Api.CreateService should be of the form "CreateService ..." (golint)
  • Line 208: warning: exported method Api.RemoveService should have comment or be unexported (golint)
  • Line 220: warning: exported method Api.ScaleService should have comment or be unexported (golint)
  • Line 240: warning: exported method Api.LogsService should have comment or be unexported (golint)
  • Line 256: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 273: warning: exported method Api.StatsService should have comment or be unexported (golint)
  • Line 297: warning: should not use basic type untyped string as key in context.WithValue (golint)

• crane/src/api/task.go
  • Line 11: warning: exported method Api.InspectTask should have comment or be unexported (golint)
  • Line 21: warning: exported method Api.ListTasks should have comment or be unexported (golint)

• crane/src/api/tty.go
  • Line 12: warning: exported method Api.ConnectContainer should have comment or be unexported (golint)

• crane/src/dockerclient/stack.go
  • Line 21: warning: exported type Stacks should have comment or be unexported (golint)
  • Line 35: warning: exported type Stack should have comment or be unexported (golint)
  • Line 44: warning: comment on exported method CraneDockerClient.DeployStack should be of the form "DeployStack ..." (golint)
  • Line 58: warning: comment on exported method CraneDockerClient.PretreatmentStack should be of the form "PretreatmentStack ..." (golint)
  • Line 119: warning: comment on exported method CraneDockerClient.ListStack should be of the form "ListStack ..." (golint)
  • Line 161: warning: comment on exported method CraneDockerClient.ListStackService should be of the form "ListStackService ..." (golint)
  • Line 171: warning: comment on exported method CraneDockerClient.InspectStack should be of the form "InspectStack ..." (golint)
  • Line 192: warning: comment on exported method CraneDockerClient.RemoveStack should be of the form "RemoveStack ..." (golint)
  • Line 225: warning: comment on exported method CraneDockerClient.FilterServiceByStack should be of the form "FilterServiceByStack ..." (golint)
  • Line 255: warning: exported method CraneDockerClient.GetStackGroup should have comment or be unexported (golint)
  • Line 257: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)

• crane/src/utils/slice.go
  • Line 3: warning: exported function StringInSlice should have comment or be unexported (golint)

• crane/src/utils/encrypt/encrypt.go
  • Line 23: warning: exported function Encrypt should have comment or be unexported (golint)
  • Line 35: warning: exported function Decrypt should have comment or be unexported (golint)

• crane/src/utils/model/model.go
  • Line 3: warning: exported type ListOptions should have comment or be unexported (golint)

• crane/src/utils/config/env.go
  • Line 1: warning: package comment should be of the form "Package config ..." (golint)

• crane/src/plugins/catalog/store.go
  • Line 7: warning: exported method CatalogApi.Save should have comment or be unexported (golint)
  • Line 15: warning: exported method CatalogApi.List should have comment or be unexported (golint)
  • Line 24: warning: exported method CatalogApi.Get should have comment or be unexported (golint)
  • Line 33: warning: exported method CatalogApi.Delete should have comment or be unexported (golint)
  • Line 41: warning: exported method CatalogApi.Update should have comment or be unexported (golint)

• crane/src/utils/httpresponse/httpresponse.go
  • Line 15: warning: exported const CodeOk should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: comment on exported function Ok should be of the form "Ok ..." (golint)
  • Line 25: warning: comment on exported function Create should be of the form "Create ..." (golint)
  • Line 31: warning: comment on exported function Delete should be of the form "Delete ..." (golint)
  • Line 37: warning: comment on exported function Update should be of the form "Update ..." (golint)
  • Line 43: warning: exported function Error should have comment or be unexported (golint)
  • Line 75: warning: exported function SSEventOk should have comment or be unexported (golint)
  • Line 81: warning: exported function SSEventError should have comment or be unexported (golint)

• crane/src/plugins/catalog/router.go
  • Line 11: warning: exported function Init should have comment or be unexported (golint)
  • Line 26: warning: exported method CatalogApi.ApiRegister should have comment or be unexported (golint)

• crane/src/plugins/tty/htermpreferences.go
  • Line 3: warning: exported type HtermPrefernces should have comment or be unexported (golint)

• crane/src/dockerclient/swarm.go
  • Line 12: warning: comment on exported method CraneDockerClient.InspectSwarm should be of the form "InspectSwarm ..." (golint)
  • Line 28: warning: comment on exported method CraneDockerClient.Ping should be of the form "Ping ..." (golint)
  • Line 33: warning: comment on exported method CraneDockerClient.ManagerInfo should be of the form "ManagerInfo ..." (golint)

• crane/src/plugins/auth/token_store.go
  • Line 9: warning: exported type TokenStore should have comment or be unexported (golint)
  • Line 10: warning: don't use underscores in Go names; interface method parameter account_id should be accountID (golint)
  • Line 10: warning: don't use underscores in Go names; interface method parameter expired_at should be expiredAt (golint)

• crane/src/api/middlewares/cors.go
  • Line 7: warning: exported function OptionHandler should have comment or be unexported (golint)

• crane/src/plugins/license/api.go
  • Line 15: warning: comment on exported const CodeLicenseGetLicenseError should be of the form "CodeLicenseGetLicenseError ..." (golint)
  • Line 17: warning: exported const CodeLicenseCreateLicenseError should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported method LicenseApi.MigriateSetting should have comment or be unexported (golint)
  • Line 27: warning: exported method LicenseApi.Create should have comment or be unexported (golint)
  • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 87: warning: exported method LicenseApi.Get should have comment or be unexported (golint)
  • Line 111: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 118: warning: exported method LicenseApi.GetLicenseValidity should have comment or be unexported (golint)

• crane/src/api/network.go
  • Line 16: warning: exported const CodeConnectNetworkParamError should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported type ConnectNetworkRequest should have comment or be unexported (golint)
  • Line 29: warning: exported const NETWORK_CONNECT should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported method Api.ConnectNetwork should have comment or be unexported (golint)
  • Line 64: warning: exported method Api.CreateNetwork should have comment or be unexported (golint)
  • Line 85: warning: exported method Api.InspectNetwork should have comment or be unexported (golint)
  • Line 98: warning: exported method Api.ListNetworks should have comment or be unexported (golint)
  • Line 120: warning: exported method Api.RemoveNetwork should have comment or be unexported (golint)
  • Line 130: warning: exported method Api.ConnectNodeNetwork should have comment or be unexported (golint)
  • Line 163: warning: exported method Api.InspectNodeNetwork should have comment or be unexported (golint)
  • Line 178: warning: exported method Api.ListNodeNetworks should have comment or be unexported (golint)
  • Line 202: warning: exported method Api.CreateNodeNetwork should have comment or be unexported (golint)

• crane/src/api/node.go
  • Line 17: warning: exported const CodeUpdateNodeParamError should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported method Api.InspectNode should have comment or be unexported (golint)
  • Line 40: warning: exported method Api.ManagerInfo should have comment or be unexported (golint)
  • Line 60: warning: exported method Api.ListNodes should have comment or be unexported (golint)
  • Line 72: warning: exported method Api.CreateNode should have comment or be unexported (golint)
  • Line 98: warning: exported method Api.UpdateNode should have comment or be unexported (golint)
  • Line 132: warning: exported method Api.RemoveNode should have comment or be unexported (golint)
  • Line 144: warning: exported method Api.Info should have comment or be unexported (golint)

• crane/src/dockerclient/image_test.go
  • Line 37: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 51: warning: should not use basic type untyped string as key in context.WithValue (golint)

• crane/src/dockerclient/nodes.go
  • Line 30: warning: comment on exported method CraneDockerClient.ListNode should be of the form "ListNode ..." (golint)
  • Line 46: warning: comment on exported method CraneDockerClient.CreateNode should be of the form "CreateNode ..." (golint)
  • Line 130: warning: comment on exported method CraneDockerClient.InspectNode should be of the form "InspectNode ..." (golint)
  • Line 146: warning: comment on exported method CraneDockerClient.RemoveNode should be of the form "RemoveNode ..." (golint)
  • Line 156: warning: comment on exported method CraneDockerClient.UpdateNode should be of the form "UpdateNode ..." (golint)
  • Line 301: warning: comment on exported method CraneDockerClient.Info should be of the form "Info ..." (golint)
  • Line 310: warning: exported method CraneDockerClient.GetDaemonUrlById should have comment or be unexported (golint)

• crane/src/dockerclient/service_helper.go
  • Line 171: warning: exported function ValidateCraneServiceSpec should have comment or be unexported (golint)
  • Line 260: warning: exported function PortConflictToString should have comment or be unexported (golint)
  • Line 265: warning: exported method CraneDockerClient.CheckServicePortConflicts should have comment or be unexported (golint)

• crane/src/plugins/auth/authenticators/db.go
  • Line 15: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 21: warning: exported type DbAuthenicator should have comment or be unexported (golint)
  • Line 26: warning: exported function NewDBAuthenticator should have comment or be unexported (golint)
  • Line 40: warning: exported method DbAuthenicator.ModificationAllowed should have comment or be unexported (golint)
  • Line 40: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 44: warning: exported method DbAuthenicator.Login should have comment or be unexported (golint)
  • Line 44: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 59: warning: exported method DbAuthenicator.Accounts should have comment or be unexported (golint)
  • Line 59: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 72: warning: exported method DbAuthenicator.Account should have comment or be unexported (golint)
  • Line 72: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 96: warning: exported method DbAuthenicator.DeleteAccount should have comment or be unexported (golint)
  • Line 96: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 100: warning: exported method DbAuthenicator.UpdaetAccount should have comment or be unexported (golint)
  • Line 100: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 104: warning: exported method DbAuthenicator.CreateAccount should have comment or be unexported (golint)
  • Line 104: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 141: warning: exported method DbAuthenicator.Groups should have comment or be unexported (golint)
  • Line 141: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 153: warning: exported method DbAuthenicator.Group should have comment or be unexported (golint)
  • Line 153: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 161: warning: exported method DbAuthenicator.CreateGroup should have comment or be unexported (golint)
  • Line 161: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 165: warning: exported method DbAuthenicator.DeleteGroup should have comment or be unexported (golint)
  • Line 165: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 178: warning: exported method DbAuthenicator.UpdateGroup should have comment or be unexported (golint)
  • Line 178: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 182: warning: exported method DbAuthenicator.JoinGroup should have comment or be unexported (golint)
  • Line 182: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 202: warning: exported method DbAuthenicator.LeaveGroup should have comment or be unexported (golint)
  • Line 202: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 225: warning: exported method DbAuthenicator.GroupAccounts should have comment or be unexported (golint)
  • Line 225: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 250: warning: exported method DbAuthenicator.AccountGroups should have comment or be unexported (golint)
  • Line 250: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)
  • Line 271: warning: exported method DbAuthenicator.EncryptPassword should have comment or be unexported (golint)
  • Line 271: warning: receiver name db should be consistent with previous receiver name authenticator for DbAuthenicator (golint)

• crane/src/plugins/auth/constants.go
  • Line 9: warning: exported var ErrLoginFailed should have comment or be unexported (golint)
  • Line 15: warning: exported const SESSION_DURATION should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: comment on exported const CodeInvalidGroupId should be of the form "CodeInvalidGroupId ..." (golint)
  • Line 22: warning: exported const CodeAccountCreateParamError should have comment (or a comment on this block) or be unexported (golint)

• crane/src/plugins/auth/permission.go
  • Line 10: warning: exported const PERMISSION_LABEL_PREFIX should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: exported type Permission should have comment or be unexported (golint)
  • Line 18: warning: exported type GroupPermission should have comment or be unexported (golint)
  • Line 24: warning: exported var PermReadOnly should have comment or be unexported (golint)
  • Line 31: warning: exported method Permission.Normalize should have comment or be unexported (golint)
  • Line 35: warning: exported function NewPermission should have comment or be unexported (golint)
  • Line 44: warning: exported function PermGreaterOrEqualThan should have comment or be unexported (golint)
  • Line 56: warning: exported function PermLessOrEqualThan should have comment or be unexported (golint)
  • Line 68: warning: exported function PermissionRevokeLabelKeysFromPermissionId should have comment or be unexported (golint)
  • Line 85: warning: exported function PermissionGrantLabelsPairFromGroupIdAndPerm should have comment or be unexported (golint)

• crane/src/plugins/auth/token.go
  • Line 11: warning: exported const DEFAULT_SALT should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported function GenToken should have comment or be unexported (golint)

• crane/src/api/middlewares/authorization.go
  • Line 7: warning: exported function Authorization should have comment or be unexported (golint)

• crane/src/utils/log/log.go
  • Line 42: warning: exported function Ginrus should have comment or be unexported (golint)

• crane/src/plugins/catalog/api.go
  • Line 13: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 18: warning: comment on exported const CodeCatalogGetCatalogError should be of the form "CodeCatalogGetCatalogError ..." (golint)
  • Line 20: warning: exported const CodeCatalogListCatalogError should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported const CATALOG_SYSTEM_DEFAULT should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported type CatalogApi should have comment or be unexported (golint)
  • Line 41: warning: exported method CatalogApi.GetCatalog should have comment or be unexported (golint)
  • Line 59: warning: exported method CatalogApi.ListCatalog should have comment or be unexported (golint)
  • Line 70: warning: exported method CatalogApi.CreateCatalog should have comment or be unexported (golint)
  • Line 90: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 109: warning: exported method CatalogApi.DeleteCatalog should have comment or be unexported (golint)
  • Line 138: warning: exported method CatalogApi.UpdateCatalog should have comment or be unexported (golint)

• crane/src/api/image.go
  • Line 17: warning: comment on exported const CodeListImageParamError should be of the form "CodeListImageParamError ..." (golint)
  • Line 21: warning: exported method Api.ListImages should have comment or be unexported (golint)
  • Line 66: warning: exported method Api.InspectImage should have comment or be unexported (golint)
  • Line 79: warning: exported method Api.ImageHistory should have comment or be unexported (golint)

• crane/src/api/misc.go
  • Line 19: warning: comment on exported const CodeGetConfigError should be of the form "CodeGetConfigError ..." (golint)
  • Line 23: warning: exported type CraneConfigResponse should have comment or be unexported (golint)
  • Line 31: warning: exported type RouteInfo should have comment or be unexported (golint)
  • Line 36: warning: exported method Api.CraneConfig should have comment or be unexported (golint)
  • Line 57: warning: exported method Api.HealthCheck should have comment or be unexported (golint)
  • Line 73: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 85: warning: exported method Api.Help should have comment or be unexported (golint)

• crane/src/api/router.go
  • Line 17: warning: exported method Api.ApiRouter should have comment or be unexported (golint)

• crane/src/api/volume.go
  • Line 14: warning: exported const CodeCreateVolumeParamError should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported method Api.InspectVolume should have comment or be unexported (golint)
  • Line 30: warning: exported method Api.ListVolume should have comment or be unexported (golint)
  • Line 45: warning: exported method Api.CreateVolume should have comment or be unexported (golint)
  • Line 67: warning: exported method Api.RemoveVolume should have comment or be unexported (golint)

• crane/src/dockerclient/network_test.go
  • Line 39: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 51: warning: should not use basic type untyped string as key in context.WithValue (golint)

• crane/src/plugins/apiplugin/apiplugin.go
  • Line 7: warning: exported type CraneApi should have comment or be unexported (golint)
  • Line 11: warning: exported type ApiPlugin should have comment or be unexported (golint)
  • Line 17: warning: exported var ApiPlugins should have comment or be unexported (golint)
  • Line 19: warning: exported function Add should have comment or be unexported (golint)
  • Line 32: warning: exported const License should have comment (or a comment on this block) or be unexported (golint)

• crane/src/plugins/auth/api/api.go
  • Line 18: warning: exported method AccountApi.CreateAccount should have comment or be unexported (golint)
  • Line 55: warning: exported method AccountApi.GetAccountInfo should have comment or be unexported (golint)
  • Line 66: warning: exported method AccountApi.GetAccount should have comment or be unexported (golint)
  • Line 76: warning: exported method AccountApi.ListAccounts should have comment or be unexported (golint)
  • Line 88: warning: exported method AccountApi.AccountLogin should have comment or be unexported (golint)
  • Line 106: warning: exported method AccountApi.AccountLogout should have comment or be unexported (golint)
  • Line 115: warning: exported method AccountApi.GroupAccounts should have comment or be unexported (golint)
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 139: warning: exported method AccountApi.AccountGroups should have comment or be unexported (golint)
  • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 162: warning: exported method AccountApi.GetGroup should have comment or be unexported (golint)
  • Line 178: warning: exported method AccountApi.ListGroups should have comment or be unexported (golint)
  • Line 189: warning: exported method AccountApi.CreateGroup should have comment or be unexported (golint)
  • Line 213: warning: exported method AccountApi.UpdateGroup should have comment or be unexported (golint)
  • Line 236: warning: exported method AccountApi.DeleteGroup should have comment or be unexported (golint)
  • Line 258: warning: exported method AccountApi.JoinGroup should have comment or be unexported (golint)
  • Line 288: warning: exported method AccountApi.LeaveGroup should have comment or be unexported (golint)
  • Line 319: warning: exported method AccountApi.GrantServicePermission should have comment or be unexported (golint)
  • Line 340: warning: exported method AccountApi.RevokeServicePermission should have comment or be unexported (golint)

• crane/src/plugins/registry/model.go
  • Line 42: warning: exported type Namespace should have comment or be unexported (golint)
  • Line 46: warning: exported type NamespaceEmail should have comment or be unexported (golint)
  • Line 55: warning: exported type Image should have comment or be unexported (golint)
  • Line 69: warning: exported type Tag should have comment or be unexported (golint)
  • Line 84: warning: exported type ImageAccess should have comment or be unexported (golint)
  • Line 96: warning: exported type V2RegistryResponse should have comment or be unexported (golint)
  • Line 103: warning: exported type V2RegistryResponseConfig should have comment or be unexported (golint)
  • Line 109: warning: exported type V2RegistryResponseLayers should have comment or be unexported (golint)
  • Line 111: warning: exported type V2RegistryResponseLayer should have comment or be unexported (golint)

• crane/src/utils/httpclient/client.go
  • Line 21: warning: exported const DefaultTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type Client should have comment or be unexported (golint)
  • Line 30: warning: comment on exported function DefaultTransport should be of the form "DefaultTransport ..." (golint)
  • Line 77: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 89: warning: exported function NewTLSClient should have comment or be unexported (golint)
  • Line 124: warning: exported method Client.POST should have comment or be unexported (golint)
  • Line 142: warning: exported method Client.PUT should have comment or be unexported (golint)
  • Line 160: warning: exported method Client.DELETE should have comment or be unexported (golint)
  • Line 178: warning: exported method Client.GET should have comment or be unexported (golint)
  • Line 196: warning: exported method Client.PATCH should have comment or be unexported (golint)

• crane/src/model/node.go
  • Line 8: warning: exported type UpdateOptions should have comment or be unexported (golint)
  • Line 13: warning: exported type JoiningNode should have comment or be unexported (golint)

• crane/src/plugins/auth/token_store/redis.go
  • Line 1: warning: don't use an underscore in package name (golint)

• crane/src/version/version.go
  • Line 4: warning: exported var Version should have comment or be unexported (golint)

• crane/src/plugins/search/search_indexer.go
  • Line 13: warning: exported const DOCUMENT_NODE should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type CraneIndexer should have comment or be unexported (golint)
  • Line 27: warning: exported function NewCraneIndex should have comment or be unexported (golint)
  • Line 31: warning: exported method CraneIndexer.Index should have comment or be unexported (golint)
  • Line 43: warning: should not use basic type untyped string as key in context.WithValue (golint)

• crane/src/dockerclient/common.go
  • Line 18: warning: comment on exported method CraneDockerClient.ToCraneServiceSpec should be of the form "ToCraneServiceSpec ..." (golint)
  • Line 48: warning: exported function EncodeRegistryAuth should have comment or be unexported (golint)
  • Line 90: warning: exported function GetServicesNamespace should have comment or be unexported (golint)

• crane/src/plugins/registryauth/registryauth.go
  • Line 5: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 9: warning: exported type RegistryAuth should have comment or be unexported (golint)
  • Line 17: warning: exported var DbClient should have comment or be unexported (golint)
  • Line 19: warning: exported function Init should have comment or be unexported (golint)
  • Line 24: warning: exported function Create should have comment or be unexported (golint)
  • Line 28: warning: exported function List should have comment or be unexported (golint)
  • Line 34: warning: exported function Delete should have comment or be unexported (golint)
  • Line 40: warning: exported function Get should have comment or be unexported (golint)

• crane/src/plugins/auth/account.go
  • Line 8: warning: exported type Account should have comment or be unexported (golint)
  • Line 18: warning: exported type AccountFilter should have comment or be unexported (golint)
  • Line 20: warning: exported type AccountGroup should have comment or be unexported (golint)
  • Line 26: warning: exported function ReferenceToValue should have comment or be unexported (golint)

• crane/src/utils/cranerror/cranerror.go
  • Line 6: warning: comment on exported const CodeOk should be of the form "CodeOk ..." (golint)
  • Line 9: warning: comment on exported const CodeUndefined should be of the form "CodeUndefined ..." (golint)
  • Line 14: warning: comment on exported const CodeErrorUpdateNodeMethod should be of the form "CodeErrorUpdateNodeMethod ..." (golint)
  • Line 16: warning: exported const CodeErrorNodeRole should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type CraneError should have comment or be unexported (golint)
  • Line 26: warning: exported function NewError should have comment or be unexported (golint)
  • Line 37: warning: exported type ContainerStatsStopError should have comment or be unexported (golint)
  • Line 50: warning: exported type NodeConnError should have comment or be unexported (golint)
  • Line 64: warning: exported type ServicePortConflictError should have comment or be unexported (golint)

• crane/src/plugins/auth/token_store/db.go
  • Line 1: warning: don't use an underscore in package name (golint)

• crane/src/plugins/search/api.go
  • Line 14: warning: exported const RESULT_LEN should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: comment on exported const CodeInvalidSearchKeywords should be of the form "CodeInvalidSearchKeywords ..." (golint)
  • Line 22: warning: exported method SearchApi.Search should have comment or be unexported (golint)

• crane/src/plugins/registry/api.go
  • Line 19: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 24: warning: comment on exported const CodeRegistryGetManifestError should be of the form "CodeRegistryGetManifestError ..." (golint)
  • Line 26: warning: exported const CodeRegistryManifestParseError should have comment (or a comment on this block) or be unexported (golint)
  • Line 45: warning: exported type Registry should have comment or be unexported (golint)
  • Line 54: warning: exported function NewRegistry should have comment or be unexported (golint)
  • Line 78: warning: exported method Registry.Token should have comment or be unexported (golint)
  • Line 114: warning: exported method Registry.Namespace should have comment or be unexported (golint)
  • Line 116: warning: don't use underscores in Go names; var account_ should be account (golint)
  • Line 154: warning: don't use underscores in Go names; var account_ should be account (golint)
  • Line 184: warning: exported method Registry.Notifications should have comment or be unexported (golint)
  • Line 206: warning: exported method Registry.TagList should have comment or be unexported (golint)
  • Line 223: warning: exported method Registry.GetManifests should have comment or be unexported (golint)
  • Line 224: warning: don't use underscores in Go names; var account_ should be account (golint)
  • Line 250: warning: exported method Registry.DeleteManifests should have comment or be unexported (golint)
  • Line 252: warning: don't use underscores in Go names; var account_ should be account (golint)
  • Line 304: warning: exported method Registry.MineRepositories should have comment or be unexported (golint)
  • Line 306: warning: don't use underscores in Go names; var account_ should be account (golint)
  • Line 337: warning: exported method Registry.PublicRepositories should have comment or be unexported (golint)
  • Line 360: warning: exported method Registry.ImagePublicity should have comment or be unexported (golint)
  • Line 390: warning: exported method Registry.HandleNotification should have comment or be unexported (golint)
  • Line 451: warning: exported method Registry.LogImageAccess should have comment or be unexported (golint)
  • Line 463: warning: exported method Registry.SizeAndReferenceForTag should have comment or be unexported (golint)
  • Line 484: warning: exported function LikeParam should have comment or be unexported (golint)

• crane/src/plugins/registry/util.go
  • Line 23: warning: comment on exported method Registry.ParseResourceActions should be of the form "ParseResourceActions ..." (golint)
  • Line 71: warning: exported method Registry.MakeToken should have comment or be unexported (golint)
  • Line 155: warning: exported method Registry.GetPermission should have comment or be unexported (golint)
  • Line 182: warning: exported method Registry.GenTokenForUI should have comment or be unexported (golint)
  • Line 190: warning: exported method Registry.RegistryNamespaceForAccount should have comment or be unexported (golint)

• crane/src/dockerclient/network.go
  • Line 12: warning: exported method CraneDockerClient.ConnectNetwork should have comment or be unexported (golint)
  • Line 16: warning: exported method CraneDockerClient.CreateNetwork should have comment or be unexported (golint)
  • Line 24: warning: exported method CraneDockerClient.DisconnectNetwork should have comment or be unexported (golint)
  • Line 28: warning: exported method CraneDockerClient.InspectNetwork should have comment or be unexported (golint)
  • Line 32: warning: exported method CraneDockerClient.ListNetworks should have comment or be unexported (golint)
  • Line 36: warning: exported method CraneDockerClient.RemoveNetwork should have comment or be unexported (golint)
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 49: warning: exported method CraneDockerClient.ConnectNodeNetwork should have comment or be unexported (golint)
  • Line 63: warning: exported method CraneDockerClient.DisconnectNodeNetwork should have comment or be unexported (golint)
  • Line 77: warning: exported method CraneDockerClient.InspectNodeNetwork should have comment or be unexported (golint)
  • Line 91: warning: exported method CraneDockerClient.ListNodeNetworks should have comment or be unexported (golint)
  • Line 99: warning: exported method CraneDockerClient.CreateNodeNetwork should have comment or be unexported (golint)

• crane/src/dockerclient/tasks.go
  • Line 13: warning: exported type Tasks should have comment or be unexported (golint)
  • Line 27: warning: comment on exported method CraneDockerClient.ListTasks should be of the form "ListTasks ..." (golint)
  • Line 55: warning: comment on exported method CraneDockerClient.InspectTask should be of the form "InspectTask ..." (golint)

• crane/src/plugins/auth/token_store/default.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported type Default should have comment or be unexported (golint)
  • Line 23: warning: exported function NewDefaultStore should have comment or be unexported (golint)
  • Line 29: warning: exported method Default.Set should have comment or be unexported (golint)
  • Line 35: warning: exported method Default.Get should have comment or be unexported (golint)
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 49: warning: exported method Default.Del should have comment or be unexported (golint)

• crane/src/testing/server.go
  • Line 21: warning: exported type Server should have comment or be unexported (golint)
  • Line 30: warning: exported type RouterMap should have comment or be unexported (golint)
  • Line 36: warning: exported type RGroup should have comment or be unexported (golint)
  • Line 41: warning: exported type Request should have comment or be unexported (golint)
  • Line 47: warning: exported type Response should have comment or be unexported (golint)
  • Line 53: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 67: warning: exported method Server.Close should have comment or be unexported (golint)
  • Line 71: warning: exported method Server.Register should have comment or be unexported (golint)
  • Line 77: warning: exported method Server.AddRouter should have comment or be unexported (golint)
  • Line 89: warning: exported method RouterMap.RGroup should have comment or be unexported (golint)
  • Line 98: warning: exported method RGroup.RBody should have comment or be unexported (golint)
  • Line 103: warning: exported method RGroup.RQuery should have comment or be unexported (golint)
  • Line 108: warning: exported method RGroup.RBodyString should have comment or be unexported (golint)
  • Line 113: warning: exported method RGroup.RFile should have comment or be unexported (golint)
  • Line 118: warning: exported method RGroup.RJSON should have comment or be unexported (golint)
  • Line 123: warning: exported method RGroup.Reply should have comment or be unexported (golint)
  • Line 128: warning: exported method RGroup.WBody should have comment or be unexported (golint)
  • Line 133: warning: exported method RGroup.WBodyString should have comment or be unexported (golint)
  • Line 138: warning: exported method RGroup.WFile should have comment or be unexported (golint)
  • Line 143: warning: exported method RGroup.WJSON should have comment or be unexported (golint)
  • Line 175: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 178: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 192: warning: exported method RouterMap.Handler should have comment or be unexported (golint)

• crane/src/plugins/auth/authenticators/ldap.go
  • Line 7: warning: exported type Ldap should have comment or be unexported (golint)
  • Line 11: warning: exported method Ldap.ModificationAllowed should have comment or be unexported (golint)

• crane/src/api/middlewares/context.go
  • Line 8: warning: exported function CraneApiContext should have comment or be unexported (golint)
  • Line 14: warning: should not use basic type untyped string as key in context.WithValue (golint)

• crane/src/plugins/auth/token_store/cookie.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported const CRANE_SESSION_KEY should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported var ErrCookieNotExist should have comment or be unexported (golint)
  • Line 26: warning: exported type Cookie should have comment or be unexported (golint)
  • Line 30: warning: exported function NewCookieStore should have comment or be unexported (golint)
  • Line 34: warning: exported method Cookie.Set should have comment or be unexported (golint)
  • Line 46: warning: exported method Cookie.Get should have comment or be unexported (golint)
  • Line 58: warning: exported method Cookie.Del should have comment or be unexported (golint)

• crane/src/plugins/auth/token_store/default_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• crane/src/plugins/license/router.go
  • Line 9: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 13: warning: exported function Init should have comment or be unexported (golint)
  • Line 28: warning: exported type LicenseApi should have comment or be unexported (golint)
  • Line 32: warning: exported method LicenseApi.ApiRegister should have comment or be unexported (golint)

• crane/src/plugins/license/setting.go
  • Line 3: warning: exported type Setting should have comment or be unexported (golint)

• crane/src/api/api.go
  • Line 8: warning: exported type Api should have comment or be unexported (golint)
  • Line 13: warning: exported method Api.GetDockerClient should have comment or be unexported (golint)
  • Line 17: warning: exported method Api.GetConfig should have comment or be unexported (golint)

• crane/src/api/container.go
  • Line 19: warning: exported type ContainerRequest should have comment or be unexported (golint)
  • Line 27: warning: exported const CONTAINER_KILL should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported const CONTAINER_STOP_TIMEOUT should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported const CodeListContainerParamError should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported method Api.InspectContainer should have comment or be unexported (golint)
  • Line 57: warning: exported method Api.ListContainers should have comment or be unexported (golint)
  • Line 113: warning: exported method Api.PatchContainer should have comment or be unexported (golint)
  • Line 158: warning: exported method Api.DeleteContainer should have comment or be unexported (golint)
  • Line 190: warning: exported method Api.DiffContainer should have comment or be unexported (golint)
  • Line 204: warning: exported method Api.LogsContainer should have comment or be unexported (golint)
  • Line 225: warning: exported method Api.StatsContainer should have comment or be unexported (golint)

• crane/src/plugins/registry/router.go
  • Line 9: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 13: warning: exported function Init should have comment or be unexported (golint)
  • Line 27: warning: exported method Registry.ApiRegister should have comment or be unexported (golint)

• crane/src/plugins/auth/authenticators/default.go
  • Line 12: warning: exported type Default should have comment or be unexported (golint)
  • Line 16: warning: exported function NewDefaultAuthenticator should have comment or be unexported (golint)
  • Line 21: warning: exported var Accounts should have comment or be unexported (golint)
  • Line 31: warning: exported method Default.GetDefaultAccounts should have comment or be unexported (golint)
  • Line 46: warning: exported method Default.ModificationAllowed should have comment or be unexported (golint)
  • Line 50: warning: exported method Default.Login should have comment or be unexported (golint)
  • Line 57: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 66: warning: exported method Default.Accounts should have comment or be unexported (golint)
  • Line 70: warning: exported method Default.Account should have comment or be unexported (golint)
  • Line 82: warning: exported method Default.DeleteAccount should have comment or be unexported (golint)
  • Line 86: warning: exported method Default.UpdateAccount should have comment or be unexported (golint)
  • Line 90: warning: exported method Default.CreateAccount should have comment or be unexported (golint)
  • Line 94: warning: exported method Default.AccountGroups should have comment or be unexported (golint)
  • Line 98: warning: exported method Default.Groups should have comment or be unexported (golint)
  • Line 102: warning: exported method Default.Group should have comment or be unexported (golint)
  • Line 112: warning: exported method Default.CreateGroup should have comment or be unexported (golint)
  • Line 116: warning: exported method Default.DeleteGroup should have comment or be unexported (golint)
  • Line 120: warning: exported method Default.UpdateGroup should have comment or be unexported (golint)
  • Line 124: warning: exported method Default.JoinGroup should have comment or be unexported (golint)
  • Line 128: warning: exported method Default.LeaveGroup should have comment or be unexported (golint)
  • Line 132: warning: exported method Default.EncryptPassword should have comment or be unexported (golint)

• crane/src/plugins/plugins.go
  • Line 15: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 19: warning: exported function Init should have comment or be unexported (golint)

• crane/src/utils/config/config.go
  • Line 8: warning: exported type Config should have comment or be unexported (golint)
  • Line 36: warning: exported method Config.FeatureEnabled should have comment or be unexported (golint)
  • Line 40: warning: exported function InitConfig should have comment or be unexported (golint)

• crane/src/plugins/auth/api/router.go
  • Line 16: warning: exported type AccountApi should have comment or be unexported (golint)
  • Line 24: warning: exported function Init should have comment or be unexported (golint)
  • Line 51: warning: exported method AccountApi.ApiRegister should have comment or be unexported (golint)

• crane/src/dockerclient/containers.go
  • Line 15: warning: exported method CraneDockerClient.ListContainers should have comment or be unexported (golint)
  • Line 23: warning: exported method CraneDockerClient.InspectContainer should have comment or be unexported (golint)
  • Line 37: warning: exported method CraneDockerClient.RemoveContainer should have comment or be unexported (golint)
  • Line 51: warning: exported method CraneDockerClient.KillContainer should have comment or be unexported (golint)
  • Line 65: warning: exported method CraneDockerClient.RenameContainer should have comment or be unexported (golint)
  • Line 79: warning: exported method CraneDockerClient.DiffContainer should have comment or be unexported (golint)
  • Line 93: warning: exported method CraneDockerClient.StopContainer should have comment or be unexported (golint)
  • Line 107: warning: exported method CraneDockerClient.StartContainer should have comment or be unexported (golint)
  • Line 121: warning: exported method CraneDockerClient.RestartContainer should have comment or be unexported (golint)
  • Line 135: warning: exported method CraneDockerClient.PauseContainer should have comment or be unexported (golint)
  • Line 149: warning: exported method CraneDockerClient.UnpauseContainer should have comment or be unexported (golint)
  • Line 163: warning: exported method CraneDockerClient.ResizeContainerTTY should have comment or be unexported (golint)
  • Line 171: warning: exported method CraneDockerClient.LogsContainer should have comment or be unexported (golint)
  • Line 212: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 218: warning: exported method CraneDockerClient.StatsContainer should have comment or be unexported (golint)
  • Line 267: warning: comment on exported function CalcNetworkRate should be of the form "CalcNetworkRate ..." (golint)

• crane/src/plugins/auth/middlewares/authorization.go
  • Line 14: warning: exported function Authorization should have comment or be unexported (golint)
  • Line 56: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• crane/src/plugins/registryauth/api/api.go
  • Line 14: warning: exported const CodeCreateRegistryAuthParamError should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported method RegistryAuthApi.Create should have comment or be unexported (golint)
  • Line 56: warning: exported method RegistryAuthApi.List should have comment or be unexported (golint)
  • Line 74: warning: exported method RegistryAuthApi.Delete should have comment or be unexported (golint)

• crane/src/plugins/registryauth/api/router.go
  • Line 12: warning: exported type RegistryAuthApi should have comment or be unexported (golint)
  • Line 14: warning: exported function Init should have comment or be unexported (golint)
  • Line 28: warning: exported method RegistryAuthApi.ApiRegister should have comment or be unexported (golint)

• crane/src/plugins/auth/mock_authenticator.go
  • Line 8: warning: exported var AuthError should have comment or be unexported (golint)
  • Line 14: warning: exported type MockAuthenticator should have comment or be unexported (golint)
  • Line 18: warning: exported function NewMockAuthenticator should have comment or be unexported (golint)
  • Line 22: warning: exported method MockAuthenticator.AccountPermissions should have comment or be unexported (golint)
  • Line 26: warning: exported method MockAuthenticator.Login should have comment or be unexported (golint)
  • Line 30: warning: exported method MockAuthenticator.EncryptPassword should have comment or be unexported (golint)
  • Line 34: warning: exported method MockAuthenticator.DeleteGroup should have comment or be unexported (golint)
  • Line 38: warning: exported method MockAuthenticator.Groups should have comment or be unexported (golint)
  • Line 42: warning: exported method MockAuthenticator.Group should have comment or be unexported (golint)
  • Line 46: warning: exported method MockAuthenticator.CreateGroup should have comment or be unexported (golint)
  • Line 50: warning: exported method MockAuthenticator.UpdateGroup should have comment or be unexported (golint)
  • Line 54: warning: exported method MockAuthenticator.GroupAccounts should have comment or be unexported (golint)
  • Line 58: warning: exported method MockAuthenticator.AccountGroups should have comment or be unexported (golint)
  • Line 62: warning: exported method MockAuthenticator.Accounts should have comment or be unexported (golint)
  • Line 66: warning: exported method MockAuthenticator.Account should have comment or be unexported (golint)
  • Line 70: warning: exported method MockAuthenticator.UpdateAccount should have comment or be unexported (golint)
  • Line 74: warning: exported method MockAuthenticator.CreateAccount should have comment or be unexported (golint)
  • Line 78: warning: exported method MockAuthenticator.JoinGroup should have comment or be unexported (golint)
  • Line 82: warning: exported method MockAuthenticator.LeaveGroup should have comment or be unexported (golint)
  • Line 86: warning: exported method MockAuthenticator.ModificationAllowed should have comment or be unexported (golint)
  • Line 90: warning: exported method MockAuthenticator.GetDefaultAccounts should have comment or be unexported (golint)

• crane/src/dockerclient/image.go
  • Line 8: warning: exported method CraneDockerClient.ListImages should have comment or be unexported (golint)
  • Line 16: warning: exported method CraneDockerClient.InspectImage should have comment or be unexported (golint)
  • Line 24: warning: exported method CraneDockerClient.ImageHistory should have comment or be unexported (golint)
  • Line 32: warning: comment on exported method CraneDockerClient.RemoveImage should be of the form "RemoveImage ..." (golint)

• crane/src/dockerclient/volume.go
  • Line 10: warning: exported method CraneDockerClient.InspectVolume should have comment or be unexported (golint)
  • Line 18: warning: exported method CraneDockerClient.ListVolumes should have comment or be unexported (golint)
  • Line 26: warning: exported method CraneDockerClient.CreateVolume should have comment or be unexported (golint)
  • Line 39: warning: exported method CraneDockerClient.RemoveVolume should have comment or be unexported (golint)

• crane/src/utils/db/db.go
  • Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 12: warning: exported function NewDB should have comment or be unexported (golint)

• crane/src/plugins/auth/token_store/errors.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 8: warning: error var TokenExpired should have name of the form ErrFoo (golint)
  • Line 8: warning: exported var TokenExpired should have comment or be unexported (golint)
  • Line 9: warning: error var TokenNotFound should have name of the form ErrFoo (golint)

• crane/src/plugins/tty/context.go
  • Line 24: warning: exported const SubProtocol should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type ClientContext should have comment or be unexported (golint)
  • Line 37: warning: exported type Options should have comment or be unexported (golint)
  • Line 52: warning: exported const Input should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported const Output should have comment (or a comment on this block) or be unexported (golint)
  • Line 65: warning: exported type ArgResizeTerminal should have comment or be unexported (golint)
  • Line 70: warning: exported type ContextVars should have comment or be unexported (golint)
  • Line 78: warning: exported var Upgrader should have comment or be unexported (golint)
  • Line 99: warning: exported function New should have comment or be unexported (golint)
  • Line 121: warning: exported method ClientContext.HandleClient should have comment or be unexported (golint)

• crane/src/dockerclient/crane_docker_client_test.go
  • Line 255: warning: should not use basic type untyped string as key in context.WithValue (golint)
  • Line 259: warning: should not use basic type untyped string as key in context.WithValue (golint)

• crane/src/plugins/auth/middlewares/authorize_service_access.go
  • Line 10: warning: exported function AuthorizeServiceAccess should have comment or be unexported (golint)
  • Line 15: warning: don't use underscores in Go names; var account_ should be account (golint)

• crane/src/dockerclient/model/stack.go
  • Line 7: warning: comment on exported type Bundle should be of the form "Bundle ..." (with optional leading article) (golint)
  • Line 20: warning: exported type CraneServiceSpec should have comment or be unexported (golint)
  • Line 31: warning: exported type CraneService should have comment or be unexported (golint)

• crane/src/api/middlewares/listintercept.go
  • Line 11: warning: exported function ListIntercept should have comment or be unexported (golint)

• crane/src/plugins/registry/client.go
  • Line 14: warning: exported method Registry.RegistryAPIGet should have comment or be unexported (golint)
  • Line 18: warning: exported method Registry.RegistryAPIGetSchemaV1 should have comment or be unexported (golint)
  • Line 22: warning: exported method Registry.RegistryAPIGetSchemaV2 should have comment or be unexported (golint)
  • Line 26: warning: exported method Registry.RegistryAPIHeadSchemaV2 should have comment or be unexported (golint)
  • Line 30: warning: exported method Registry.RegistryAPIDelete should have comment or be unexported (golint)
  • Line 34: warning: exported method Registry.RegistryAPIDeleteSchemaV2 should have comment or be unexported (golint)
  • Line 38: warning: comment on exported method Registry.RegistryAPI should be of the form "RegistryAPI ..." (golint)

• crane/src/dockerclient/constants.go
  • Line 6: warning: comment on exported const TaskRunningState should be of the form "TaskRunningState ..." (golint)
  • Line 8: warning: exported const DefaultNetworkDriver should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: exported const LabelNamespace should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: comment on exported const CodeInvalidServiceNanoCPUs should be of the form "CodeInvalidServiceNanoCPUs ..." (golint)
  • Line 29: warning: exported const CodeInvalidServiceDelay should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: comment on exported const CodeInvalidStackName should be of the form "CodeInvalidStackName ..." (golint)
  • Line 43: warning: comment on exported const CodeErrorUpdateNodeMethod should be of the form "CodeErrorUpdateNodeMethod ..." (golint)
  • Line 51: warning: comment on exported const CodeNetworkPredefined should be of the form "CodeNetworkPredefined ..." (golint)
  • Line 57: warning: comment on exported const CodePatchContainerParamError should be of the form "CodePatchContainerParamError ..." (golint)
  • Line 65: warning: comment on exported const CodeConnToNodeError should be of the form "CodeConnToNodeError ..." (golint)
  • Line 72: warning: comment on exported const CodeInvalidVolumeName should be of the form "CodeInvalidVolumeName ..." (golint)

• crane/src/dockerclient/crane_docker_client.go
  • Line 18: warning: exported type CraneDockerClient should have comment or be unexported (golint)
  • Line 33: warning: comment on exported function NewCraneDockerClient should be of the form "NewCraneDockerClient ..." (golint)
  • Line 74: warning: comment on exported method CraneDockerClient.SwarmManager should be of the form "SwarmManager ..." (golint)
  • Line 95: warning: comment on exported method CraneDockerClient.SwarmNode should be of the form "SwarmNode ..." (golint)
  • Line 129: warning: exported method CraneDockerClient.VerifyNodeEndpoint should have comment or be unexported (golint)
  • Line 154: warning: exported function NewGoDockerClientTls should have comment or be unexported (golint)
  • Line 159: warning: exported function NewHttpClient should have comment or be unexported (golint)
  • Line 164: warning: exported function NewHttpClientTls should have comment or be unexported (golint)
  • Line 170: warning: exported function SharedClientCertFiles should have comment or be unexported (golint)
  • Line 178: warning: exported function ToCraneError should have comment or be unexported (golint)

• crane/src/dockerclient/service.go
  • Line 21: warning: exported var ErrPermissionNotExists should have comment or be unexported (golint)
  • Line 24: warning: exported type ServiceStatus should have comment or be unexported (golint)
  • Line 41: warning: comment on exported type ServiceScale should be of the form "ServiceScale ..." (with optional leading article) (golint)
  • Line 46: warning: comment on exported method CraneDockerClient.CreateService should be of the form "CreateService ..." (golint)
  • Line 69: warning: comment on exported method CraneDockerClient.ListServiceSpec should be of the form "ListServiceSpec ..." (golint)
  • Line 190: warning: comment on exported method CraneDockerClient.RemoveService should be of the form "RemoveService ..." (golint)
  • Line 196: warning: comment on exported method CraneDockerClient.UpdateService should be of the form "UpdateService ..." (golint)
  • Line 214: warning: exported method CraneDockerClient.UpdateServiceAutoOption should have comment or be unexported (golint)
  • Line 266: warning: comment on exported method CraneDockerClient.ServiceAddLabel should be of the form "ServiceAddLabel ..." (golint)
  • Line 280: warning: comment on exported method CraneDockerClient.ServiceRemoveLabel should be of the form "ServiceRemoveLabel ..." (golint)
  • Line 294: warning: exported method CraneDockerClient.GetServiceNetworkNames should have comment or be unexported (golint)

• crane/src/dockerclient/model/container.go
  • Line 9: warning: exported type CraneContainerStat should have comment or be unexported (golint)
  • Line 21: warning: exported type ContainerStatOptions should have comment or be unexported (golint)

• crane/src/plugins/auth/authenticator.go
  • Line 7: warning: exported type Authenticator should have comment or be unexported (golint)

• crane/src/plugins/search/router.go
  • Line 12: warning: exported const SEARCH_LOAD_DATA_INTERVAL should have comment or be unexported (golint)
  • Line 14: warning: exported type Indexer should have comment or be unexported (golint)
  • Line 18: warning: exported type DocumentStorage should have comment or be unexported (golint)
  • Line 22: warning: exported function NewDocumentStorage should have comment or be unexported (golint)
  • Line 26: warning: exported method DocumentStorage.Empty should have comment or be unexported (golint)
  • Line 30: warning: exported method DocumentStorage.Copy should have comment or be unexported (golint)
  • Line 38: warning: exported method DocumentStorage.Indices should have comment or be unexported (golint)
  • Line 40: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 46: warning: exported method DocumentStorage.Set should have comment or be unexported (golint)
  • Line 50: warning: exported method DocumentStorage.Get should have comment or be unexported (golint)
  • Line 55: warning: exported type SearchApi should have comment or be unexported (golint)
  • Line 63: warning: exported type Document should have comment or be unexported (golint)
  • Line 71: warning: exported function Init should have comment or be unexported (golint)
  • Line 84: warning: exported method SearchApi.ApiRegister should have comment or be unexported (golint)
  • Line 93: warning: exported method SearchApi.IndexData should have comment or be unexported (golint)

• crane/src/api/stack.go
  • Line 19: warning: comment on exported const CodeCreateStackParamError should be of the form "CodeCreateStackParamError ..." (golint)
  • Line 21: warning: exported const CodeInvalidStackName should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported method Api.UpdateStack should have comment or be unexported (golint)
  • Line 29: warning: exported method Api.CreateStack should have comment or be unexported (golint)
  • Line 80: warning: exported method Api.ListStack should have comment or be unexported (golint)
  • Line 92: warning: exported method Api.InspectStack should have comment or be unexported (golint)
  • Line 106: warning: exported method Api.ListStackService should have comment or be unexported (golint)
  • Line 110: warning: don't use underscores in Go names; var labelFilters_ should be labelFilters (golint)
  • Line 113: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 130: warning: exported method Api.RemoveStack should have comment or be unexported (golint)

• crane/src/dockerclient/interface.go
  • Line 15: warning: exported type DockerClientInterface should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign93%

IneffAssign detects ineffectual assignments in Go code.

• crane/src/plugins/search/api_test.go
  • Line 44: warning: ineffectual assignment to err (ineffassign)
  • Line 65: warning: ineffectual assignment to err (ineffassign)

• crane/src/api/stack.go
  • Line 47: warning: ineffectual assignment to groupId (ineffassign)

• crane/src/dockerclient/common_test.go
  • Line 99: warning: ineffectual assignment to host (ineffassign)

• crane/src/dockerclient/crane_docker_client.go
  • Line 49: warning: ineffectual assignment to err (ineffassign)
  • Line 52: warning: ineffectual assignment to err (ineffassign)

• crane/src/dockerclient/nodes_test.go
  • Line 662: warning: ineffectual assignment to err (ineffassign)
  • Line 761: warning: ineffectual assignment to err (ineffassign)

• crane/src/dockerclient/swarm_test.go
  • Line 68: warning: ineffectual assignment to err (ineffassign)
  • Line 90: warning: ineffectual assignment to err (ineffassign)
  • Line 120: warning: ineffectual assignment to err (ineffassign)
  • Line 145: warning: ineffectual assignment to err (ineffassign)

• crane/src/plugins/auth/token_store/default_test.go
  • Line 20: warning: ineffectual assignment to id (ineffassign)

• crane/src/plugins/registry/api_test.go
  • Line 109: warning: ineffectual assignment to err (ineffassign)
  • Line 128: warning: ineffectual assignment to err (ineffassign)
  • Line 136: warning: ineffectual assignment to err (ineffassign)
  • Line 146: warning: ineffectual assignment to err (ineffassign)
  • Line 161: warning: ineffectual assignment to err (ineffassign)
  • Line 192: warning: ineffectual assignment to err (ineffassign)
  • Line 203: warning: ineffectual assignment to err (ineffassign)
  • Line 210: warning: ineffectual assignment to err (ineffassign)
  • Line 228: warning: ineffectual assignment to err (ineffassign)
  • Line 236: warning: ineffectual assignment to err (ineffassign)

• crane/src/dockerclient/crane_docker_client_test.go
  • Line 200: warning: ineffectual assignment to err (ineffassign)
  • Line 212: warning: ineffectual assignment to err (ineffassign)
  • Line 256: warning: ineffectual assignment to dockerClient (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!