Preparing report...

Report for github.com/DevFactory/go-tools

A+    Excellent!    Found 9 issues across 43 files

Tweet

gofmt90%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint86%

Golint is a linter for Go source code.

    • go-tools/pkg/nettools/mocks/interfaces_mock.go
    • Line 33: warning: exported var MockInterfaces should have comment or be unexported (golint)
    • Line 35: warning: exported var MockInterfacesEth should have comment or be unexported (golint)
    • Line 62: warning: exported var MockInterfacesOther should have comment or be unexported (golint)
    • Line 85: warning: exported type MockInterfaceLister should have comment or be unexported (golint)
    • Line 88: warning: exported method MockInterfaceLister.GetInterfaces should have comment or be unexported (golint)
    • go-tools/pkg/nettools/mocks/utils_mock.go
    • Line 18: warning: exported type MockSimpleFileOperator should have comment or be unexported (golint)
    • Line 22: warning: exported method MockSimpleFileOperator.ReadFile should have comment or be unexported (golint)
    • Line 27: warning: exported method MockSimpleFileOperator.AppendToFile should have comment or be unexported (golint)
    • go-tools/pkg/linux/command/mock/executor.go
    • Line 26: warning: exported type ExecInfo should have comment or be unexported (golint)
    • Line 31: warning: exported type ExecInfoList should have comment or be unexported (golint)
    • Line 33: warning: exported type ExecProviderFunction should have comment or be unexported (golint)
    • Line 35: warning: exported type MockExecutor should have comment or be unexported (golint)
    • Line 42: warning: exported function NewMockExecutorFromInfos should have comment or be unexported (golint)
    • Line 53: warning: exported function NewMockExecutorFromSlices should have comment or be unexported (golint)
    • Line 69: warning: exported method MockExecutor.RunCommand should have comment or be unexported (golint)
    • Line 82: warning: exported method MockExecutor.RunCommandWithRetries should have comment or be unexported (golint)
    • Line 87: warning: exported method MockExecutor.RunCommandWithRetriesAndDelay should have comment or be unexported (golint)
    • Line 106: warning: exported method MockExecutor.ValidateCallNum should have comment or be unexported (golint)
    • go-tools/pkg/nettools/testhelpers/common_commands.go
    • Line 20: warning: exported function ExecResultOKNoOutput should have comment or be unexported (golint)
    • Line 24: warning: exported function ExecResultExitCodeNoOutput should have comment or be unexported (golint)
    • Line 28: warning: exported function ExecResultExitCodeStdOutput should have comment or be unexported (golint)
    • Line 32: warning: exported function ExecResultExitCodeErrOutput should have comment or be unexported (golint)
    • Line 36: warning: exported function ExecResultExitCodeStdErrOutput should have comment or be unexported (golint)
    • Line 40: warning: exported function ExecResultGrepNotFound should have comment or be unexported (golint)
    • Line 44: warning: exported function ExecResultGrepFound should have comment or be unexported (golint)
    • go-tools/pkg/nettools/testhelpers/iproute.go
    • Line 56: warning: exported function GetExecMockResultsForEnsureOnly1IPRule should have comment or be unexported (golint)
    • Line 99: warning: exported function GetExecMockResultsForExistingIPRuleRemove should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!