Preparing report...

Report for github.com/EfficientIP-Labs/terraform-provider-solidserver

A+    Excellent!    Found 25 issues across 56 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo75%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • terraform-provider-solidserver/solidserver/resource_dns_view.go
    • Line 463: warning: cyclomatic complexity 28 of function resourcednsviewRead() is high (> 15) (gocyclo)
    • Line 612: warning: cyclomatic complexity 28 of function resourcednsviewImportState() is high (> 15) (gocyclo)
    • Line 175: warning: cyclomatic complexity 23 of function resourcednsviewCreate() is high (> 15) (gocyclo)
    • Line 296: warning: cyclomatic complexity 23 of function resourcednsviewUpdate() is high (> 15) (gocyclo)
    • terraform-provider-solidserver/solidserver/resource_dns_server.go
    • Line 201: warning: cyclomatic complexity 21 of function resourcednsserverCreate() is high (> 15) (gocyclo)
    • Line 607: warning: cyclomatic complexity 20 of function resourcednsserverImportState() is high (> 15) (gocyclo)
    • Line 493: warning: cyclomatic complexity 20 of function resourcednsserverRead() is high (> 15) (gocyclo)
    • Line 326: warning: cyclomatic complexity 18 of function resourcednsserverUpdate() is high (> 15) (gocyclo)
    • terraform-provider-solidserver/solidserver/resource_dns_smart.go
    • Line 512: warning: cyclomatic complexity 20 of function resourcednssmartImportState() is high (> 15) (gocyclo)
    • Line 398: warning: cyclomatic complexity 20 of function resourcednssmartRead() is high (> 15) (gocyclo)
    • Line 258: warning: cyclomatic complexity 18 of function resourcednssmartUpdate() is high (> 15) (gocyclo)
    • Line 159: warning: cyclomatic complexity 18 of function resourcednssmartCreate() is high (> 15) (gocyclo)

golint73%

Golint is a linter for Go source code.

    • terraform-provider-solidserver/solidserver/solidserver-helper.go
    • Line 64: warning: don't use underscores in Go names; var old_offsets should be oldOffsets (golint)
    • Line 997: warning: don't use underscores in Go names; var ip_name_id should be ipNameID (golint)
    • Line 997: warning: don't use underscores in Go names; var ip_name_id_exist should be ipNameIDExist (golint)
    • Line 1041: warning: don't use underscores in Go names; var hexaddr_exist should be hexaddrExist (golint)
    • Line 1088: warning: don't use underscores in Go names; var hexaddr_exist should be hexaddrExist (golint)
    • Line 1392: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • terraform-provider-solidserver/solidserver/soliderver.go
    • Line 24: warning: exported type SOLIDserver should have comment or be unexported (golint)
    • Line 35: warning: exported function NewSOLIDserver should have comment or be unexported (golint)
    • Line 54: warning: exported method SOLIDserver.GetVersion should have comment or be unexported (golint)
    • Line 139: warning: exported method SOLIDserver.Request should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign89%

IneffAssign detects ineffectual assignments in Go code.


misspell94%

Misspell Finds commonly misspelled English words