Preparing report...

Report for github.com/Financial-Times/concept-rw-elasticsearch

A+    Excellent!    Found 7 issues across 13 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint46%

Golint is a linter for Go source code.

    • concept-rw-elasticsearch/service/es_service.go
    • Line 22: warning: exported var ErrNoElasticClient should have comment or be unexported (golint)
    • Line 50: warning: exported type EsService should have comment or be unexported (golint)
    • Line 63: warning: exported function NewEsService should have comment or be unexported (golint)
    • Line 244: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 255: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 300: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • concept-rw-elasticsearch/service/model.go
    • Line 13: warning: exported type PayloadPatch should have comment or be unexported (golint)
    • Line 15: warning: exported type ConceptModel should have comment or be unexported (golint)
    • Line 26: warning: exported type AggregateMembershipRole should have comment or be unexported (golint)
    • Line 32: warning: exported type AggregateConceptModel should have comment or be unexported (golint)
    • Line 52: warning: exported type SourceConcept should have comment or be unexported (golint)
    • Line 57: warning: exported type EsModel should have comment or be unexported (golint)
    • Line 59: warning: exported type EsConceptModel should have comment or be unexported (golint)
    • Line 76: warning: exported type EsMembershipModel should have comment or be unexported (golint)
    • Line 83: warning: exported type EsIDTypePair should have comment or be unexported (golint)
    • Line 88: warning: exported type EsConceptModelPatch should have comment or be unexported (golint)
    • Line 92: warning: exported type ConceptMetrics should have comment or be unexported (golint)
    • Line 97: warning: exported type EsPersonConceptModel should have comment or be unexported (golint)
    • Line 102: warning: exported type EsPersonConceptPatch should have comment or be unexported (golint)
    • Line 107: warning: exported method AggregateConceptModel.PreferredUUID should have comment or be unexported (golint)
    • Line 111: warning: exported method ConceptModel.PreferredUUID should have comment or be unexported (golint)
    • Line 115: warning: exported method ConceptModel.GetAuthorities should have comment or be unexported (golint)
    • Line 131: warning: exported method AggregateConceptModel.GetAuthorities should have comment or be unexported (golint)
    • Line 139: warning: exported method ConceptModel.ConcordedUUIDs should have comment or be unexported (golint)
    • Line 143: warning: exported method AggregateConceptModel.ConcordedUUIDs should have comment or be unexported (golint)
    • concept-rw-elasticsearch/health/healthcheck.go
    • Line 15: warning: exported type HealthService should have comment or be unexported (golint)
    • Line 19: warning: exported function NewHealthService should have comment or be unexported (golint)
    • Line 25: warning: exported method HealthService.HealthCheckHandler should have comment or be unexported (golint)
    • Line 123: warning: exported method HealthService.GTG should have comment or be unexported (golint)
    • concept-rw-elasticsearch/service/es_client.go
    • Line 11: warning: exported type EsAccessConfig should have comment or be unexported (golint)
    • Line 18: warning: exported function NewAccessConfig should have comment or be unexported (golint)
    • Line 22: warning: exported type AWSSigningTransport should have comment or be unexported (golint)
    • Line 69: warning: exported function NewElasticClient should have comment or be unexported (golint)
    • Line 72: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!