gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• armada/internal/executor/metrics/pod_metrics/cluster_context.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• armada/internal/executor/util/pod_status_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• armada/internal/armada/repository/event.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• armada/internal/executor/service/cluster_allocation.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• armada/internal/executor/metrics/pod_metrics/cluster_context.go
  • Line 128: warning: cyclomatic complexity 16 of function (*ClusterContextMetrics).Collect() is high (> 15) (gocyclo)

• armada/internal/lookout/events/processor.go
  • Line 61: warning: cyclomatic complexity 18 of function (*EventProcessor).processEvent() is high (> 15) (gocyclo)

• armada/pkg/client/domain/watch.go
  • Line 166: warning: cyclomatic complexity 22 of function updateJobInfo() is high (> 15) (gocyclo)
  • Line 278: warning: cyclomatic complexity 17 of function isLifeCycleEvent() is high (> 15) (gocyclo)

• armada/pkg/api/event_util.go
  • Line 74: warning: cyclomatic complexity 18 of function Wrap() is high (> 15) (gocyclo)
  • Line 34: warning: cyclomatic complexity 18 of function UnwrapEvent() is high (> 15) (gocyclo)

• armada/internal/armada/metrics/metrics.go
  • Line 219: warning: cyclomatic complexity 26 of function (*QueueInfoCollector).Collect() is high (> 15) (gocyclo)

golint34%

Golint is a linter for Go source code.

• armada/internal/armada/authorization/common.go
  • Line 21: warning: exported const EveryoneGroup should have comment or be unexported (golint)
  • Line 25: warning: exported type Principal should have comment or be unexported (golint)
  • Line 32: warning: exported type StaticPrincipal should have comment or be unexported (golint)
  • Line 39: warning: exported function NewStaticPrincipal should have comment or be unexported (golint)
  • Line 48: warning: exported function NewStaticPrincipalWithScopesAndClaims should have comment or be unexported (golint)
  • Line 57: warning: exported method StaticPrincipal.IsInGroup should have comment or be unexported (golint)
  • Line 61: warning: exported method StaticPrincipal.HasScope should have comment or be unexported (golint)
  • Line 65: warning: exported method StaticPrincipal.HasClaim should have comment or be unexported (golint)
  • Line 69: warning: exported method StaticPrincipal.GetName should have comment or be unexported (golint)
  • Line 73: warning: exported function GetPrincipal should have comment or be unexported (golint)
  • Line 81: warning: exported function WithPrincipal should have comment or be unexported (golint)
  • Line 82: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 85: warning: exported type AuthService should have comment or be unexported (golint)
  • Line 89: warning: exported function CreateMiddlewareAuthFunction should have comment or be unexported (golint)

• armada/pkg/api/deserialize.go
  • Line 8: warning: exported method IngressType.UnmarshalJSON should have comment or be unexported (golint)

• armada/internal/armada/configuration/types.go
  • Line 12: warning: exported type UserInfo should have comment or be unexported (golint)
  • Line 17: warning: exported type ArmadaConfig should have comment or be unexported (golint)
  • Line 42: warning: exported type OpenIdAuthenticationConfig should have comment or be unexported (golint)
  • Line 53: warning: exported type BasicAuthenticationConfig should have comment or be unexported (golint)
  • Line 57: warning: exported type KerberosAuthenticationConfig should have comment or be unexported (golint)
  • Line 63: warning: exported type SchedulingConfig should have comment or be unexported (golint)
  • Line 77: warning: exported type EventRetentionPolicy should have comment or be unexported (golint)
  • Line 82: warning: exported type LeaseSettings should have comment or be unexported (golint)
  • Line 87: warning: exported type KafkaConfig should have comment or be unexported (golint)
  • Line 94: warning: exported type NatsConfig should have comment or be unexported (golint)
  • Line 102: warning: exported type QueueManagementConfig should have comment or be unexported (golint)
  • Line 107: warning: exported type MetricsConfig should have comment or be unexported (golint)

• armada/internal/common/grpc/gateway.go
  • Line 20: warning: exported function ServeGateway should have comment or be unexported (golint)
  • Line 36: warning: exported function CreateGatewayHandler should have comment or be unexported (golint)

• armada/internal/executor/metrics/metrics.go
  • Line 3: warning: exported const ArmadaExecutorMetricsPrefix should have comment or be unexported (golint)

• armada/internal/armada/server/event.go
  • Line 15: warning: exported type EventServer should have comment or be unexported (golint)
  • Line 21: warning: exported function NewEventServer should have comment or be unexported (golint)
  • Line 32: warning: exported method EventServer.Report should have comment or be unexported (golint)
  • Line 39: warning: exported method EventServer.ReportMultiple should have comment or be unexported (golint)
  • Line 46: warning: exported method EventServer.GetJobSetEvents should have comment or be unexported (golint)

• armada/internal/executor/util/pod_status.go
  • Line 24: warning: exported function ExtractPodStuckReason should have comment or be unexported (golint)
  • Line 44: warning: exported function ExtractPodFailedReason should have comment or be unexported (golint)
  • Line 63: warning: exported function ExtractPodFailedCause should have comment or be unexported (golint)
  • Line 82: warning: exported function ExtractPodExitCodes should have comment or be unexported (golint)
  • Line 97: warning: exported function ExtractFailedPodContainerStatuses should have comment or be unexported (golint)
  • Line 129: warning: exported function DiagnoseStuckPod should have comment or be unexported (golint)
  • Line 147: warning: exported function ContainersAreRetryable should have comment or be unexported (golint)

• armada/internal/armada/server.go
  • Line 31: warning: exported function Serve should have comment or be unexported (golint)

• armada/internal/armada/authorization/kerberos.go
  • Line 37: warning: exported type KerberosAuthService should have comment or be unexported (golint)
  • Line 43: warning: exported function NewKerberosAuthService should have comment or be unexported (golint)
  • Line 61: warning: exported method KerberosAuthService.Authenticate should have comment or be unexported (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• armada/internal/armada/metrics/resource_recorder.go
  • Line 7: warning: exported type ResourceMetricsRecorder should have comment or be unexported (golint)
  • Line 11: warning: exported function NewResourceMetricsRecorder should have comment or be unexported (golint)
  • Line 17: warning: exported method ResourceMetricsRecorder.Record should have comment or be unexported (golint)
  • Line 28: warning: exported method ResourceMetricsRecorder.GetMetrics should have comment or be unexported (golint)
  • Line 38: warning: exported type ResourceMetrics should have comment or be unexported (golint)

• armada/internal/common/util/uuid.go
  • Line 15: warning: exported function NewULID should have comment or be unexported (golint)

• armada/pkg/api/queue_util.go
  • Line 5: warning: exported method Job.GetAllPodSpecs should have comment or be unexported (golint)
  • Line 12: warning: exported method JobSubmitRequestItem.GetAllPodSpecs should have comment or be unexported (golint)

• armada/internal/armada/repository/scheduling.go
  • Line 12: warning: exported type SchedulingInfoRepository should have comment or be unexported (golint)
  • Line 17: warning: exported type RedisSchedulingInfoRepository should have comment or be unexported (golint)
  • Line 21: warning: exported function NewRedisSchedulingInfoRepository should have comment or be unexported (golint)
  • Line 25: warning: exported method RedisSchedulingInfoRepository.GetClusterSchedulingInfo should have comment or be unexported (golint)
  • Line 43: warning: exported method RedisSchedulingInfoRepository.UpdateClusterSchedulingInfo should have comment or be unexported (golint)

• armada/internal/executor/service/pod_utilisation.go
  • Line 18: warning: exported type PodUtilisationService should have comment or be unexported (golint)
  • Line 22: warning: exported type MetricsServerPodUtilisationService should have comment or be unexported (golint)
  • Line 28: warning: exported function NewMetricsServerQueueUtilisationService should have comment or be unexported (golint)
  • Line 36: warning: exported type UsageMetric should have comment or be unexported (golint)
  • Line 40: warning: exported method UsageMetric.DeepCopy should have comment or be unexported (golint)
  • Line 46: warning: exported method MetricsServerPodUtilisationService.GetPodUtilisation should have comment or be unexported (golint)
  • Line 75: warning: exported method MetricsServerPodUtilisationService.RefreshUtilisationData should have comment or be unexported (golint)

• armada/internal/executor/context/cluster_context.go
  • Line 29: warning: exported type ClusterContext should have comment or be unexported (golint)
  • Line 52: warning: exported type KubernetesClusterContext should have comment or be unexported (golint)
  • Line 66: warning: exported method KubernetesClusterContext.GetClusterId should have comment or be unexported (golint)
  • Line 70: warning: exported method KubernetesClusterContext.GetClusterPool should have comment or be unexported (golint)
  • Line 74: warning: exported function NewClusterContext should have comment or be unexported (golint)
  • Line 131: warning: exported method KubernetesClusterContext.AddPodEventHandler should have comment or be unexported (golint)
  • Line 135: warning: exported method KubernetesClusterContext.Stop should have comment or be unexported (golint)
  • Line 139: warning: exported method KubernetesClusterContext.GetActiveBatchPods should have comment or be unexported (golint)
  • Line 143: warning: exported method KubernetesClusterContext.GetBatchPods should have comment or be unexported (golint)
  • Line 154: warning: exported method KubernetesClusterContext.GetAllPods should have comment or be unexported (golint)
  • Line 165: warning: exported method KubernetesClusterContext.GetPodEvents should have comment or be unexported (golint)
  • Line 180: warning: exported method KubernetesClusterContext.GetNodes should have comment or be unexported (golint)
  • Line 184: warning: exported method KubernetesClusterContext.GetNodeStatsSummary should have comment or be unexported (golint)
  • Line 208: warning: exported method KubernetesClusterContext.SubmitPod should have comment or be unexported (golint)
  • Line 224: warning: exported method KubernetesClusterContext.SubmitService should have comment or be unexported (golint)
  • Line 228: warning: exported method KubernetesClusterContext.AddAnnotation should have comment or be unexported (golint)
  • Line 245: warning: exported method KubernetesClusterContext.DeletePods should have comment or be unexported (golint)
  • Line 251: warning: exported method KubernetesClusterContext.DeleteService should have comment or be unexported (golint)
  • Line 260: warning: exported method KubernetesClusterContext.ProcessPodsToDelete should have comment or be unexported (golint)
  • Line 279: warning: exported method KubernetesClusterContext.GetService should have comment or be unexported (golint)

• armada/internal/common/task/background_task.go
  • Line 25: warning: exported function NewBackgroundTaskManager should have comment or be unexported (golint)
  • Line 33: warning: exported method BackgroundTaskManager.Register should have comment or be unexported (golint)
  • Line 44: warning: exported method BackgroundTaskManager.StopAll should have comment or be unexported (golint)

• armada/internal/executor/application.go
  • Line 25: warning: exported function StartUp should have comment or be unexported (golint)
  • Line 48: warning: exported function StartUpWithContext should have comment or be unexported (golint)

• armada/internal/armada/authorization/permissions.go
  • Line 9: warning: exported type Owned should have comment or be unexported (golint)
  • Line 14: warning: exported type PermissionChecker should have comment or be unexported (golint)
  • Line 19: warning: exported type PrincipalPermissionChecker should have comment or be unexported (golint)
  • Line 25: warning: exported function NewPrincipalPermissionChecker should have comment or be unexported (golint)
  • Line 36: warning: exported method PrincipalPermissionChecker.UserHasPermission should have comment or be unexported (golint)
  • Line 43: warning: exported method PrincipalPermissionChecker.UserOwns should have comment or be unexported (golint)

• armada/internal/armada/authorization/oidc.go
  • Line 17: warning: exported type PermissionClaimQueries should have comment or be unexported (golint)
  • Line 19: warning: exported type OpenIdAuthService should have comment or be unexported (golint)
  • Line 24: warning: exported function NewOpenIdAuthServiceForProvider should have comment or be unexported (golint)
  • Line 37: warning: exported function NewOpenIdAuthService should have comment or be unexported (golint)
  • Line 41: warning: exported method OpenIdAuthService.Authenticate should have comment or be unexported (golint)

• armada/internal/armada/scheduling/clusters.go
  • Line 12: warning: exported function FilterActiveClusters should have comment or be unexported (golint)
  • Line 23: warning: exported function FilterPoolClusters should have comment or be unexported (golint)
  • Line 33: warning: exported function GroupByPool should have comment or be unexported (golint)
  • Line 46: warning: exported function FilterClusterLeasedReports should have comment or be unexported (golint)
  • Line 56: warning: exported function FilterActiveClusterSchedulingInfoReports should have comment or be unexported (golint)
  • Line 67: warning: exported function GroupSchedulingInfoByPool should have comment or be unexported (golint)
  • Line 80: warning: exported function GetClusterReportIds should have comment or be unexported (golint)

• armada/cmd/fakeexecutor/main.go
  • Line 17: warning: exported const CustomConfigLocation should have comment or be unexported (golint)

• armada/internal/common/logging/formatter.go
  • Line 9: warning: exported type CommandLineFormatter should have comment or be unexported (golint)
  • Line 12: warning: exported method CommandLineFormatter.Format should have comment or be unexported (golint)

• armada/pkg/client/util/deserialize.go
  • Line 10: warning: exported function BindJsonOrYaml should have comment or be unexported (golint)

• armada/pkg/client/auth/oidc/common.go
  • Line 9: warning: exported type TokenCredentials should have comment or be unexported (golint)
  • Line 13: warning: exported method TokenCredentials.GetRequestMetadata should have comment or be unexported (golint)
  • Line 23: warning: exported method TokenCredentials.RequireTransportSecurity should have comment or be unexported (golint)

• armada/internal/lookout/repository/job_sets.go
  • Line 39: warning: exported method SQLJobRepository.GetJobSetInfos should have comment or be unexported (golint)

• armada/internal/armada/configuration/util.go
  • Line 3: warning: exported method SchedulingConfig.GetResourceScarcity should have comment or be unexported (golint)

• armada/internal/executor/fake/context/context.go
  • Line 27: warning: exported type NodeSpec should have comment or be unexported (golint)
  • Line 35: warning: exported var DefaultNodeSpec should have comment or be unexported (golint)
  • Line 46: warning: exported type FakeClusterContext should have comment or be unexported (golint)
  • Line 56: warning: exported function NewFakeClusterContext should have comment or be unexported (golint)
  • Line 70: warning: exported method FakeClusterContext.Stop should have comment or be unexported (golint)
  • Line 73: warning: exported method FakeClusterContext.AddPodEventHandler should have comment or be unexported (golint)
  • Line 77: warning: exported method FakeClusterContext.GetBatchPods should have comment or be unexported (golint)
  • Line 88: warning: exported method FakeClusterContext.GetAllPods should have comment or be unexported (golint)
  • Line 92: warning: exported method FakeClusterContext.GetActiveBatchPods should have comment or be unexported (golint)
  • Line 96: warning: exported method FakeClusterContext.GetNodes should have comment or be unexported (golint)
  • Line 100: warning: exported method FakeClusterContext.GetPodEvents should have comment or be unexported (golint)
  • Line 104: warning: exported method FakeClusterContext.SubmitPod should have comment or be unexported (golint)
  • Line 159: warning: exported method FakeClusterContext.SubmitService should have comment or be unexported (golint)
  • Line 163: warning: exported method FakeClusterContext.GetService should have comment or be unexported (golint)
  • Line 167: warning: exported method FakeClusterContext.DeleteService should have comment or be unexported (golint)
  • Line 217: warning: exported method FakeClusterContext.AddAnnotation should have comment or be unexported (golint)
  • Line 231: warning: exported method FakeClusterContext.DeletePods should have comment or be unexported (golint)
  • Line 245: warning: exported method FakeClusterContext.GetClusterId should have comment or be unexported (golint)
  • Line 249: warning: exported method FakeClusterContext.GetClusterPool should have comment or be unexported (golint)
  • Line 253: warning: exported method FakeClusterContext.GetNodeStatsSummary should have comment or be unexported (golint)

• armada/pkg/client/auth/kerberos/common.go
  • Line 10: warning: exported type ClientConfig should have comment or be unexported (golint)

• armada/pkg/client/command_line.go
  • Line 13: warning: exported function AddArmadaApiConnectionCommandlineArgs should have comment or be unexported (golint)
  • Line 18: warning: exported function LoadCommandlineArgsFromConfigFile should have comment or be unexported (golint)
  • Line 72: warning: exported function ExtractCommandlineArmadaApiConnectionDetails should have comment or be unexported (golint)

• armada/internal/armada/repository/usage.go
  • Line 12: warning: exported type Usage should have comment or be unexported (golint)
  • Line 21: warning: exported type UsageRepository should have comment or be unexported (golint)
  • Line 31: warning: exported type RedisUsageRepository should have comment or be unexported (golint)
  • Line 35: warning: exported function NewRedisUsageRepository should have comment or be unexported (golint)
  • Line 39: warning: exported method RedisUsageRepository.GetClusterUsageReports should have comment or be unexported (golint)
  • Line 57: warning: exported method RedisUsageRepository.GetClusterLeasedReports should have comment or be unexported (golint)
  • Line 75: warning: exported method RedisUsageRepository.GetClusterPriority should have comment or be unexported (golint)
  • Line 83: warning: exported method RedisUsageRepository.GetClusterPriorities should have comment or be unexported (golint)
  • Line 105: warning: exported method RedisUsageRepository.UpdateCluster should have comment or be unexported (golint)
  • Line 127: warning: exported method RedisUsageRepository.UpdateClusterLeased should have comment or be unexported (golint)

• armada/internal/executor/service/job_utilisation_reporter.go
  • Line 18: warning: exported type UtilisationEventReporter should have comment or be unexported (golint)
  • Line 34: warning: exported function NewUtilisationEventReporter should have comment or be unexported (golint)
  • Line 78: warning: exported method UtilisationEventReporter.ReportUtilisationEvents should have comment or be unexported (golint)

• armada/internal/armada/repository/event_nats.go
  • Line 13: warning: exported type NatsEventStore should have comment or be unexported (golint)
  • Line 18: warning: exported function NewNatsEventStore should have comment or be unexported (golint)
  • Line 22: warning: exported method NatsEventStore.ReportEvents should have comment or be unexported (golint)
  • Line 60: warning: exported type NatsEventRedisProcessor should have comment or be unexported (golint)
  • Line 67: warning: exported function NewNatsEventRedisProcessor should have comment or be unexported (golint)
  • Line 71: warning: exported method NatsEventRedisProcessor.Start should have comment or be unexported (golint)

• armada/internal/executor/reporter/job_event_reporter.go
  • Line 20: warning: exported type EventReporter should have comment or be unexported (golint)
  • Line 30: warning: exported type JobEventReporter should have comment or be unexported (golint)
  • Line 40: warning: exported function NewJobEventReporter should have comment or be unexported (golint)
  • Line 79: warning: exported method JobEventReporter.Report should have comment or be unexported (golint)
  • Line 121: warning: exported method JobEventReporter.QueueEvent should have comment or be unexported (golint)
  • Line 218: warning: exported method JobEventReporter.ReportMissingJobEvents should have comment or be unexported (golint)
  • Line 301: warning: exported function HasCurrentStateBeenReported should have comment or be unexported (golint)
  • Line 307: warning: exported function HasPodBeenInStateForLongerThanGivenDuration should have comment or be unexported (golint)

• armada/internal/executor/service/cluster_allocation.go
  • Line 23: warning: exported type ClusterAllocationService should have comment or be unexported (golint)
  • Line 30: warning: exported function NewClusterAllocationService should have comment or be unexported (golint)
  • Line 43: warning: exported method ClusterAllocationService.AllocateSpareClusterCapacity should have comment or be unexported (golint)
  • Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 76: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 121: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• armada/internal/armada/server/usage.go
  • Line 17: warning: exported type UsageServer should have comment or be unexported (golint)
  • Line 25: warning: exported function NewUsageServer should have comment or be unexported (golint)
  • Line 40: warning: exported method UsageServer.ReportUsage should have comment or be unexported (golint)

• armada/internal/armada/repository/event_kafka.go
  • Line 14: warning: exported type KafkaEventStore should have comment or be unexported (golint)
  • Line 18: warning: exported function NewKafkaEventStore should have comment or be unexported (golint)
  • Line 22: warning: exported method KafkaEventStore.ReportEvents should have comment or be unexported (golint)
  • Line 47: warning: exported type KafkaEventRedisProcessor should have comment or be unexported (golint)
  • Line 52: warning: exported function NewKafkaEventRedisProcessor should have comment or be unexported (golint)
  • Line 56: warning: exported method KafkaEventRedisProcessor.ProcessEvents should have comment or be unexported (golint)

• armada/internal/armada/scheduling/node_matching.go
  • Line 14: warning: exported function CreateClusterSchedulingInfoReport should have comment or be unexported (golint)
  • Line 36: warning: exported function MatchSchedulingRequirements should have comment or be unexported (golint)
  • Line 49: warning: exported function MatchSchedulingRequirementsOnAnyCluster should have comment or be unexported (golint)
  • Line 154: warning: exported function AggregateNodeTypeAllocations should have comment or be unexported (golint)

• armada/pkg/client/domain/watch.go
  • Line 12: warning: exported type JobStatus should have comment or be unexported (golint)
  • Line 13: warning: exported type PodStatus should have comment or be unexported (golint)
  • Line 16: warning: exported const Submitted should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type JobInfo should have comment or be unexported (golint)
  • Line 66: warning: exported function NewWatchContext should have comment or be unexported (golint)
  • Line 73: warning: exported method WatchContext.ProcessEvent should have comment or be unexported (golint)
  • Line 104: warning: exported method WatchContext.GetJobInfo should have comment or be unexported (golint)
  • Line 108: warning: exported method WatchContext.GetCurrentState should have comment or be unexported (golint)
  • Line 112: warning: exported method WatchContext.GetCurrentStateSummary should have comment or be unexported (golint)
  • Line 127: warning: exported method WatchContext.GetNumberOfJobsInStates should have comment or be unexported (golint)
  • Line 137: warning: comment on exported method WatchContext.GetNumberOfFinishedJobs should be of the form "GetNumberOfFinishedJobs ..." (golint)
  • Line 142: warning: comment on exported method WatchContext.GetNumberOfJobs should be of the form "GetNumberOfJobs ..." (golint)
  • Line 153: warning: exported method WatchContext.AreJobsFinished should have comment or be unexported (golint)

• armada/internal/executor/domain/resources.go
  • Line 3: warning: exported const AcceleratorDutyCycle should have comment or be unexported (golint)
  • Line 4: warning: exported const AcceleratorMemory should have comment or be unexported (golint)

• armada/cmd/lookout/main.go
  • Line 23: warning: exported const CustomConfigLocation should have comment or be unexported (golint)
  • Line 24: warning: exported const MigrateDatabase should have comment or be unexported (golint)

• armada/internal/lookout/application.go
  • Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 27: warning: exported type LogRusLogger should have comment or be unexported (golint)
  • Line 29: warning: exported method LogRusLogger.Printf should have comment or be unexported (golint)
  • Line 33: warning: exported function StartUp should have comment or be unexported (golint)

• armada/internal/common/startup.go
  • Line 24: warning: exported function BindCommandlineArguments should have comment or be unexported (golint)
  • Line 32: warning: exported function LoadConfig should have comment or be unexported (golint)
  • Line 66: warning: exported function UnmarshalKey should have comment or be unexported (golint)
  • Line 89: warning: exported function ConfigureCommandLineLogging should have comment or be unexported (golint)
  • Line 95: warning: exported function ConfigureLogging should have comment or be unexported (golint)
  • Line 112: warning: exported function ServeMetrics should have comment or be unexported (golint)
  • Line 116: warning: exported function ServeMetricsFor should have comment or be unexported (golint)
  • Line 125: warning: exported function ServeHttp should have comment or be unexported (golint)

• armada/internal/common/stan-util/durable_connection.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 12: warning: exported type DurableConnection should have comment or be unexported (golint)
  • Line 25: warning: exported function DurableConnect should have comment or be unexported (golint)
  • Line 47: warning: exported method DurableConnection.PublishAsync should have comment or be unexported (golint)
  • Line 54: warning: exported method DurableConnection.QueueSubscribe should have comment or be unexported (golint)
  • Line 67: warning: exported method DurableConnection.Close should have comment or be unexported (golint)

• armada/internal/armada/scheduling/priority.go
  • Line 14: warning: exported type QueuePriorityInfo should have comment or be unexported (golint)
  • Line 19: warning: exported function CalculateQueuesPriorityInfo should have comment or be unexported (golint)
  • Line 37: warning: exported function CalculatePriorityUpdate should have comment or be unexported (golint)

• armada/internal/executor/util/pod_util.go
  • Line 23: warning: exported function HasIngress should have comment or be unexported (golint)
  • Line 28: warning: exported function IsInTerminalState should have comment or be unexported (golint)
  • Line 36: warning: exported function IsManagedPod should have comment or be unexported (golint)
  • Line 41: warning: exported function GetManagedPodSelector should have comment or be unexported (golint)
  • Line 55: warning: exported function ExtractNames should have comment or be unexported (golint)
  • Line 65: warning: exported function ExtractJobIds should have comment or be unexported (golint)
  • Line 77: warning: exported function ExtractJobId should have comment or be unexported (golint)
  • Line 81: warning: exported function ExtractPodNumber should have comment or be unexported (golint)
  • Line 86: warning: exported function ExtractPodKey should have comment or be unexported (golint)
  • Line 90: warning: exported function FilterCompletedPods should have comment or be unexported (golint)
  • Line 102: warning: exported function FilterNonCompletedPods should have comment or be unexported (golint)
  • Line 114: warning: exported function FilterPodsWithPhase should have comment or be unexported (golint)
  • Line 126: warning: exported function IsReportingPhaseRequired should have comment or be unexported (golint)
  • Line 130: warning: exported function MergePodList should have comment or be unexported (golint)
  • Line 145: warning: exported function FilterPods should have comment or be unexported (golint)
  • Line 155: warning: exported function LastStatusChange should have comment or be unexported (golint)
  • Line 176: warning: exported function FindLastContainerStartTime should have comment or be unexported (golint)

• armada/internal/executor/service/job_lease.go
  • Line 24: warning: exported type LeaseService should have comment or be unexported (golint)
  • Line 30: warning: exported type JobLeaseService should have comment or be unexported (golint)
  • Line 40: warning: exported function NewJobLeaseService should have comment or be unexported (golint)
  • Line 59: warning: exported method JobLeaseService.RequestJobLeases should have comment or be unexported (golint)
  • Line 93: warning: exported method JobLeaseService.ReturnLease should have comment or be unexported (golint)
  • Line 105: warning: exported method JobLeaseService.ManageJobLeases should have comment or be unexported (golint)
  • Line 143: warning: exported method JobLeaseService.ReportDone should have comment or be unexported (golint)

• armada/internal/armada/server/submit.go
  • Line 20: warning: exported type SubmitServer should have comment or be unexported (golint)
  • Line 29: warning: exported function NewSubmitServer should have comment or be unexported (golint)
  • Line 46: warning: exported method SubmitServer.GetQueueInfo should have comment or be unexported (golint)
  • Line 60: warning: exported method SubmitServer.CreateQueue should have comment or be unexported (golint)
  • Line 81: warning: exported method SubmitServer.DeleteQueue should have comment or be unexported (golint)
  • Line 102: warning: exported method SubmitServer.SubmitJobs should have comment or be unexported (golint)
  • Line 180: warning: exported method SubmitServer.CancelJobs should have comment or be unexported (golint)
  • Line 233: warning: error should be the last type when returning multiple items (golint)
  • Line 255: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• armada/pkg/client/validation/submit_file.go
  • Line 38: warning: exported function ValidateSubmitFile should have comment or be unexported (golint)

• armada/internal/lookout/metrics/metrics.go
  • Line 7: warning: exported const MetricPrefix should have comment or be unexported (golint)
  • Line 23: warning: exported type LookoutCollector should have comment or be unexported (golint)
  • Line 28: warning: exported type LookoutApiCollector should have comment or be unexported (golint)
  • Line 32: warning: exported function ExposeLookoutMetrics should have comment or be unexported (golint)
  • Line 40: warning: exported method LookoutApiCollector.Describe should have comment or be unexported (golint)
  • Line 45: warning: exported method LookoutApiCollector.Collect should have comment or be unexported (golint)

• armada/internal/lookout/postgres/postgres.go
  • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 12: warning: exported function Open should have comment or be unexported (golint)

• armada/pkg/client/auth/oidc/password.go
  • Line 10: warning: exported type ClientPasswordDetails should have comment or be unexported (golint)
  • Line 18: warning: exported function AuthenticateWithPassword should have comment or be unexported (golint)

• armada/internal/armada/server_test.go
  • Line 119: warning: context.Context should be the first parameter of a function (golint)
  • Line 128: warning: context.Context should be the first parameter of a function (golint)

• armada/internal/common/serve/static.go
  • Line 9: warning: exported function CreateDirWithIndexFallback should have comment or be unexported (golint)

• armada/internal/lookout/server/lookout.go
  • Line 14: warning: exported type LookoutServer should have comment or be unexported (golint)
  • Line 18: warning: exported function NewLookoutServer should have comment or be unexported (golint)
  • Line 22: warning: exported method LookoutServer.Overview should have comment or be unexported (golint)
  • Line 30: warning: exported method LookoutServer.GetJobSets should have comment or be unexported (golint)
  • Line 38: warning: exported method LookoutServer.GetJobs should have comment or be unexported (golint)

• armada/internal/executor/util/cache.go
  • Line 15: warning: exported type PodCache should have comment or be unexported (golint)
  • Line 36: warning: exported function NewTimeExpiringPodCache should have comment or be unexported (golint)

• armada/internal/lookout/repository/queues.go
  • Line 24: warning: exported method SQLJobRepository.GetQueueInfos should have comment or be unexported (golint)

• armada/internal/lookout/repository/sql_repository.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 14: warning: comment on exported type JobState should be of the form "JobState ..." (with optional leading article) (golint)
  • Line 19: warning: exported const JobQueued should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type JobRepository should have comment or be unexported (golint)
  • Line 34: warning: exported type SQLJobRepository should have comment or be unexported (golint)
  • Line 47: warning: don't use underscores in Go names; var job_jobId should be jobJobID (golint)
  • Line 48: warning: don't use underscores in Go names; var job_queue should be jobQueue (golint)
  • Line 49: warning: don't use underscores in Go names; var job_owner should be jobOwner (golint)
  • Line 50: warning: don't use underscores in Go names; var job_jobset should be jobJobset (golint)
  • Line 51: warning: don't use underscores in Go names; var job_priority should be jobPriority (golint)
  • Line 52: warning: don't use underscores in Go names; var job_submitted should be jobSubmitted (golint)
  • Line 53: warning: don't use underscores in Go names; var job_cancelled should be jobCancelled (golint)
  • Line 54: warning: don't use underscores in Go names; var job_job should be jobJob (golint)
  • Line 55: warning: don't use underscores in Go names; var job_state should be jobState (golint)
  • Line 56: warning: don't use underscores in Go names; var job_duplicate should be jobDuplicate (golint)
  • Line 59: warning: don't use underscores in Go names; var jobRun_runId should be jobRunRunID (golint)
  • Line 60: warning: don't use underscores in Go names; var jobRun_jobId should be jobRunJobID (golint)
  • Line 61: warning: don't use underscores in Go names; var jobRun_podNumber should be jobRunPodNumber (golint)
  • Line 62: warning: don't use underscores in Go names; var jobRun_cluster should be jobRunCluster (golint)
  • Line 63: warning: don't use underscores in Go names; var jobRun_node should be jobRunNode (golint)
  • Line 64: warning: don't use underscores in Go names; var jobRun_created should be jobRunCreated (golint)
  • Line 65: warning: don't use underscores in Go names; var jobRun_started should be jobRunStarted (golint)
  • Line 66: warning: don't use underscores in Go names; var jobRun_finished should be jobRunFinished (golint)
  • Line 67: warning: don't use underscores in Go names; var jobRun_succeeded should be jobRunSucceeded (golint)
  • Line 68: warning: don't use underscores in Go names; var jobRun_error should be jobRunError (golint)
  • Line 71: warning: don't use underscores in Go names; var annotation_jobId should be annotationJobID (golint)
  • Line 72: warning: don't use underscores in Go names; var annotation_key should be annotationKey (golint)
  • Line 73: warning: don't use underscores in Go names; var annotation_value should be annotationValue (golint)
  • Line 76: warning: exported type JobRow should have comment or be unexported (golint)
  • Line 97: warning: exported var AllJobStates should have comment or be unexported (golint)
  • Line 107: warning: exported var JobStateToIntMap should have comment or be unexported (golint)
  • Line 117: warning: exported var IntToJobStateMap should have comment or be unexported (golint)
  • Line 136: warning: exported function NewSQLJobRepository should have comment or be unexported (golint)

• armada/internal/executor/metrics/kubernetes.go
  • Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 9: warning: exported function GetMetricsGatherer should have comment or be unexported (golint)

• armada/internal/armada/scheduling/lease.go
  • Line 19: warning: exported type JobQueue should have comment or be unexported (golint)
  • Line 42: warning: exported function LeaseJobs should have comment or be unexported (golint)

• armada/internal/executor/fake/application.go
  • Line 13: warning: exported function StartUp should have comment or be unexported (golint)

• armada/pkg/client/domain/types.go
  • Line 11: warning: exported type LoadTestSpecification should have comment or be unexported (golint)
  • Line 15: warning: exported type SubmissionDescription should have comment or be unexported (golint)
  • Line 24: warning: exported type JobSubmissionDescription should have comment or be unexported (golint)
  • Line 36: warning: exported type JobSubmitFile should have comment or be unexported (golint)
  • Line 42: warning: exported type LoadTestSummary should have comment or be unexported (golint)
  • Line 47: warning: exported method LoadTestSpecification.NumberOfJobsInSpecification should have comment or be unexported (golint)

• armada/internal/executor/service/ingress_cleanup.go
  • Line 12: warning: exported type IngressCleanupService should have comment or be unexported (golint)
  • Line 16: warning: exported function RunIngressCleanup should have comment or be unexported (golint)

• armada/pkg/client/with_connection.go
  • Line 8: warning: exported function WithConnection should have comment or be unexported (golint)

• armada/internal/executor/cluster/kubernetes_client.go
  • Line 12: warning: exported type KubernetesClientProvider should have comment or be unexported (golint)
  • Line 18: warning: exported type ConfigKubernetesClientProvider should have comment or be unexported (golint)
  • Line 24: warning: exported function NewKubernetesClientProvider should have comment or be unexported (golint)
  • Line 45: warning: exported method ConfigKubernetesClientProvider.Client should have comment or be unexported (golint)
  • Line 49: warning: exported method ConfigKubernetesClientProvider.ClientConfig should have comment or be unexported (golint)
  • Line 53: warning: exported method ConfigKubernetesClientProvider.ClientForUser should have comment or be unexported (golint)

• armada/internal/common/util/list.go
  • Line 3: warning: exported function SubtractStringList should have comment or be unexported (golint)
  • Line 14: warning: exported function StringListToSet should have comment or be unexported (golint)
  • Line 22: warning: exported function ContainsString should have comment or be unexported (golint)

• armada/internal/common/validation/job.go
  • Line 9: warning: exported function ValidateJobSubmitRequestItem should have comment or be unexported (golint)
  • Line 21: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• armada/internal/executor/reporter/event.go
  • Line 17: warning: exported function CreateEventForCurrentState should have comment or be unexported (golint)
  • Line 68: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 81: warning: exported function CreateJobUnableToScheduleEvent should have comment or be unexported (golint)
  • Line 97: warning: exported function CreateJobLeaseReturnedEvent should have comment or be unexported (golint)
  • Line 108: warning: exported function CreateJobIngressInfoEvent should have comment or be unexported (golint)
  • Line 136: warning: exported function CreateSimpleJobFailedEvent should have comment or be unexported (golint)
  • Line 140: warning: exported function CreateJobFailedEvent should have comment or be unexported (golint)
  • Line 160: warning: exported function CreateJobUtilisationEvent should have comment or be unexported (golint)
  • Line 176: warning: exported function CreateJobTerminatedEvent should have comment or be unexported (golint)

• armada/internal/common/resource.go
  • Line 14: warning: exported type ComputeResources should have comment or be unexported (golint)
  • Line 16: warning: exported function FromResourceList should have comment or be unexported (golint)
  • Line 43: warning: exported method ComputeResources.Add should have comment or be unexported (golint)
  • Line 55: warning: exported method ComputeResources.Max should have comment or be unexported (golint)
  • Line 68: warning: exported method ComputeResources.Equal should have comment or be unexported (golint)
  • Line 87: warning: exported method ComputeResources.Dominates should have comment or be unexported (golint)
  • Line 104: warning: exported method ComputeResources.IsValid should have comment or be unexported (golint)
  • Line 112: warning: exported method ComputeResources.Sub should have comment or be unexported (golint)
  • Line 129: warning: exported method ComputeResources.DeepCopy should have comment or be unexported (golint)
  • Line 139: warning: exported method ComputeResources.Mul should have comment or be unexported (golint)
  • Line 147: warning: exported method ComputeResources.MulByResource should have comment or be unexported (golint)
  • Line 159: warning: exported method ComputeResources.AsFloat should have comment or be unexported (golint)
  • Line 167: warning: exported function QuantityAsFloat64 should have comment or be unexported (golint)
  • Line 175: warning: comment on exported type ComputeResourcesFloat should be of the form "ComputeResourcesFloat ..." (with optional leading article) (golint)
  • Line 178: warning: exported method ComputeResourcesFloat.IsValid should have comment or be unexported (golint)
  • Line 186: warning: exported method ComputeResourcesFloat.Sub should have comment or be unexported (golint)
  • Line 200: warning: exported method ComputeResourcesFloat.Add should have comment or be unexported (golint)
  • Line 214: warning: exported method ComputeResourcesFloat.Max should have comment or be unexported (golint)
  • Line 225: warning: exported method ComputeResourcesFloat.DeepCopy should have comment or be unexported (golint)
  • Line 233: warning: exported method ComputeResourcesFloat.IsLessThan should have comment or be unexported (golint)
  • Line 239: warning: exported method ComputeResourcesFloat.LimitWith should have comment or be unexported (golint)
  • Line 247: warning: comment on exported method ComputeResourcesFloat.MergeWith should be of the form "MergeWith ..." (golint)
  • Line 256: warning: exported method ComputeResourcesFloat.LimitToZero should have comment or be unexported (golint)
  • Line 262: warning: exported method ComputeResourcesFloat.Mul should have comment or be unexported (golint)
  • Line 270: warning: exported function TotalJobResourceRequest should have comment or be unexported (golint)
  • Line 279: warning: comment on exported function TotalPodResourceRequest should be of the form "TotalPodResourceRequest ..." (golint)
  • Line 300: warning: exported function CalculateTotalResource should have comment or be unexported (golint)
  • Line 309: warning: exported function CalculateTotalResourceRequest should have comment or be unexported (golint)

• armada/pkg/client/auth/oidc/pkce.go
  • Line 19: warning: exported type PKCEDetails should have comment or be unexported (golint)
  • Line 26: warning: exported function AuthenticatePkce should have comment or be unexported (golint)

• armada/internal/armada/authorization/basic.go
  • Line 13: warning: exported type BasicAuthService should have comment or be unexported (golint)
  • Line 17: warning: exported function NewBasicAuthService should have comment or be unexported (golint)
  • Line 21: warning: exported method BasicAuthService.Authenticate should have comment or be unexported (golint)

• armada/internal/common/grpc/grpc.go
  • Line 22: warning: exported function CreateGrpcServer should have comment or be unexported (golint)

• armada/pkg/client/connection.go
  • Line 16: warning: exported type ApiConnectionDetails should have comment or be unexported (golint)
  • Line 27: warning: exported function CreateApiConnection should have comment or be unexported (golint)

• armada/pkg/client/kubectl.go
  • Line 12: warning: exported function GetKubectlCommand should have comment or be unexported (golint)

• armada/pkg/client/load-test.go
  • Line 17: warning: exported type LoadTester should have comment or be unexported (golint)
  • Line 21: warning: exported type ArmadaLoadTester should have comment or be unexported (golint)
  • Line 25: warning: exported function NewArmadaLoadTester should have comment or be unexported (golint)
  • Line 31: warning: exported method ArmadaLoadTester.RunSubmissionTest should have comment or be unexported (golint)
  • Line 276: warning: exported function NewThreadSafeStringSlice should have comment or be unexported (golint)

• armada/internal/lookout/repository/store.go
  • Line 10: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 16: warning: exported type JobRecorder should have comment or be unexported (golint)
  • Line 30: warning: exported type SQLJobStore should have comment or be unexported (golint)
  • Line 35: warning: exported function NewSQLJobStore should have comment or be unexported (golint)
  • Line 39: warning: exported method SQLJobStore.RecordJob should have comment or be unexported (golint)
  • Line 74: warning: exported method SQLJobStore.MarkCancelled should have comment or be unexported (golint)
  • Line 94: warning: exported method SQLJobStore.RecordJobPriorityChange should have comment or be unexported (golint)
  • Line 98: warning: exported method SQLJobStore.RecordJobDuplicate should have comment or be unexported (golint)
  • Line 117: warning: exported method SQLJobStore.RecordJobPending should have comment or be unexported (golint)
  • Line 146: warning: exported method SQLJobStore.RecordJobRunning should have comment or be unexported (golint)
  • Line 177: warning: exported method SQLJobStore.RecordJobSucceeded should have comment or be unexported (golint)
  • Line 209: warning: exported method SQLJobStore.RecordJobFailed should have comment or be unexported (golint)
  • Line 251: warning: exported method SQLJobStore.RecordJobUnableToSchedule should have comment or be unexported (golint)
  • Line 266: warning: exported method SQLJobStore.RecordJobTerminated should have comment or be unexported (golint)

• armada/internal/armada/authorization/anonymous.go
  • Line 5: warning: exported type AnonymousAuthService should have comment or be unexported (golint)
  • Line 7: warning: exported method AnonymousAuthService.Authenticate should have comment or be unexported (golint)

• armada/pkg/client/auth/kerberos/spnego_unix.go
  • Line 31: warning: exported function NewSPNEGOCredentials should have comment or be unexported (golint)

• armada/internal/executor/job_context/job_context.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 12: warning: exported type RunningJob should have comment or be unexported (golint)
  • Line 17: warning: exported type JobContext should have comment or be unexported (golint)
  • Line 25: warning: exported type ClusterJobContext should have comment or be unexported (golint)
  • Line 32: warning: exported function NewClusterJobContext should have comment or be unexported (golint)
  • Line 40: warning: exported method ClusterJobContext.GetRunningJobs should have comment or be unexported (golint)
  • Line 48: warning: exported method ClusterJobContext.DeleteJobs should have comment or be unexported (golint)
  • Line 70: warning: exported method ClusterJobContext.IsActiveJob should have comment or be unexported (golint)
  • Line 77: warning: exported method ClusterJobContext.RegisterActiveJobs should have comment or be unexported (golint)
  • Line 86: warning: exported method ClusterJobContext.RegisterDoneJobs should have comment or be unexported (golint)

• armada/internal/lookout/events/processor.go
  • Line 14: warning: exported type EventProcessor should have comment or be unexported (golint)
  • Line 21: warning: exported function NewEventProcessor should have comment or be unexported (golint)
  • Line 25: warning: exported method EventProcessor.Start should have comment or be unexported (golint)

• armada/internal/lookout/repository/schema/migrations.go
  • Line 22: warning: exported function UpdateDatabase should have comment or be unexported (golint)

• armada/cmd/executor/main.go
  • Line 18: warning: exported const CustomConfigLocation should have comment or be unexported (golint)

• armada/cmd/armada/main.go
  • Line 19: warning: exported const CustomConfigLocation should have comment or be unexported (golint)

• armada/internal/armada/scheduling/resources.go
  • Line 12: warning: exported type QueueSchedulingInfo should have comment or be unexported (golint)
  • Line 18: warning: exported function NewQueueSchedulingInfo should have comment or be unexported (golint)
  • Line 29: warning: exported method QueueSchedulingInfo.UpdateLimits should have comment or be unexported (golint)
  • Line 52: warning: exported function SliceResourceWithLimits should have comment or be unexported (golint)
  • Line 116: warning: exported function ResourcesAsUsage should have comment or be unexported (golint)
  • Line 125: warning: exported function ResourcesFloatAsUsage should have comment or be unexported (golint)
  • Line 134: warning: exported function QueueSlicesToShares should have comment or be unexported (golint)
  • Line 142: warning: exported function SumRemainingResource should have comment or be unexported (golint)
  • Line 150: warning: exported function ResourceScarcityFromReports should have comment or be unexported (golint)
  • Line 190: warning: exported function CombineLeasedReportResourceByQueue should have comment or be unexported (golint)
  • Line 204: warning: exported function CreateClusterLeasedReport should have comment or be unexported (golint)

• armada/internal/armada/repository/event.go
  • Line 16: warning: exported type EventStore should have comment or be unexported (golint)
  • Line 20: warning: exported type EventRepository should have comment or be unexported (golint)
  • Line 25: warning: exported type RedisEventRepository should have comment or be unexported (golint)
  • Line 30: warning: exported function NewRedisEventRepository should have comment or be unexported (golint)
  • Line 34: warning: exported method RedisEventRepository.ReportEvent should have comment or be unexported (golint)
  • Line 38: warning: exported method RedisEventRepository.ReportEvents should have comment or be unexported (golint)
  • Line 75: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)
  • Line 84: warning: exported method RedisEventRepository.ReadEvents should have comment or be unexported (golint)
  • Line 119: warning: exported method RedisEventRepository.GetLastMessageId should have comment or be unexported (golint)

• armada/internal/executor/configuration/types.go
  • Line 10: warning: exported type ApplicationConfiguration should have comment or be unexported (golint)
  • Line 15: warning: exported type KubernetesConfiguration should have comment or be unexported (golint)
  • Line 25: warning: exported type TaskConfiguration should have comment or be unexported (golint)
  • Line 37: warning: exported type MetricConfiguration should have comment or be unexported (golint)
  • Line 42: warning: exported type ExecutorConfiguration should have comment or be unexported (golint)

• armada/internal/armada/server/lease.go
  • Line 20: warning: exported type AggregatedQueueServer should have comment or be unexported (golint)
  • Line 31: warning: exported function NewAggregatedQueueServer should have comment or be unexported (golint)
  • Line 52: warning: exported method AggregatedQueueServer.LeaseJobs should have comment or be unexported (golint)
  • Line 130: warning: exported method AggregatedQueueServer.RenewLease should have comment or be unexported (golint)
  • Line 138: warning: exported method AggregatedQueueServer.ReturnLease should have comment or be unexported (golint)
  • Line 178: warning: exported method AggregatedQueueServer.ReportDone should have comment or be unexported (golint)

• armada/pkg/client/auth/oidc/device.go
  • Line 18: warning: exported type DeviceDetails should have comment or be unexported (golint)
  • Line 24: warning: exported function AuthenticateDevice should have comment or be unexported (golint)

• armada/internal/armada/authorization/permissions/permissions.go
  • Line 3: warning: exported type Permission should have comment or be unexported (golint)
  • Line 6: warning: exported const SubmitJobs should have comment (or a comment on this block) or be unexported (golint)

• armada/pkg/client/auth/oidc/client_credentials.go
  • Line 10: warning: exported type ClientCredentialsDetails should have comment or be unexported (golint)
  • Line 17: warning: exported function AuthenticateWithClientCredentials should have comment or be unexported (golint)

• armada/internal/lookout/metrics/db_metrics_provider.go
  • Line 9: warning: exported type LookoutDbMetricsProvider should have comment or be unexported (golint)
  • Line 14: warning: exported type LookoutSqlDbMetricsProvider should have comment or be unexported (golint)
  • Line 19: warning: exported function NewLookoutSqlDbMetricsProvider should have comment or be unexported (golint)
  • Line 26: warning: exported method LookoutSqlDbMetricsProvider.GetOpenConnections should have comment or be unexported (golint)
  • Line 30: warning: exported method LookoutSqlDbMetricsProvider.GetOpenConnectionsUtilization should have comment or be unexported (golint)

• armada/internal/common/client.go
  • Line 8: warning: exported function ContextWithDefaultTimeout should have comment or be unexported (golint)

• armada/internal/executor/service/cluster_utilisation.go
  • Line 14: warning: should not use dot imports (golint)
  • Line 18: warning: exported type UtilisationService should have comment or be unexported (golint)
  • Line 24: warning: exported type ClusterUtilisationService should have comment or be unexported (golint)
  • Line 32: warning: exported function NewClusterUtilisationService should have comment or be unexported (golint)
  • Line 48: warning: exported method ClusterUtilisationService.ReportClusterUtilisation should have comment or be unexported (golint)
  • Line 88: warning: exported type ClusterAvailableCapacityReport should have comment or be unexported (golint)
  • Line 93: warning: exported method ClusterUtilisationService.GetAvailableClusterCapacity should have comment or be unexported (golint)
  • Line 150: warning: exported method ClusterUtilisationService.GetTotalAllocatableClusterCapacity should have comment or be unexported (golint)
  • Line 189: warning: exported method ClusterUtilisationService.GetAllAvailableProcessingNodes should have comment or be unexported (golint)

• armada/pkg/client/submit.go
  • Line 9: warning: exported const MaxJobsPerRequest should have comment or be unexported (golint)
  • Line 11: warning: exported function CreateQueue should have comment or be unexported (golint)
  • Line 19: warning: exported function DeleteQueue should have comment or be unexported (golint)
  • Line 26: warning: exported function SubmitJobs should have comment or be unexported (golint)
  • Line 33: warning: exported function CreateChunkedSubmitRequests should have comment or be unexported (golint)
  • Line 51: warning: exported function AddClientIds should have comment or be unexported (golint)

• armada/pkg/api/event_util.go
  • Line 10: warning: exported type Event should have comment or be unexported (golint)
  • Line 17: warning: exported type KubernetesEvent should have comment or be unexported (golint)
  • Line 26: warning: comment on exported method EventMessage.MarshalJSON should be of the form "MarshalJSON ..." (golint)
  • Line 30: warning: exported method EventMessage.UnmarshalJSON should have comment or be unexported (golint)
  • Line 34: warning: exported function UnwrapEvent should have comment or be unexported (golint)
  • Line 74: warning: exported function Wrap should have comment or be unexported (golint)

• armada/internal/lookout/repository/jobs.go
  • Line 16: warning: exported method SQLJobRepository.GetJobs should have comment or be unexported (golint)
  • Line 244: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• armada/internal/armada/metrics/metrics.go
  • Line 15: warning: exported const MetricPrefix should have comment or be unexported (golint)
  • Line 17: warning: exported type QueueMetricProvider should have comment or be unexported (golint)
  • Line 21: warning: exported function ExposeDataMetrics should have comment or be unexported (golint)
  • Line 38: warning: exported type QueueInfoCollector should have comment or be unexported (golint)
  • Line 200: warning: exported method QueueInfoCollector.Describe should have comment or be unexported (golint)
  • Line 219: warning: exported method QueueInfoCollector.Collect should have comment or be unexported (golint)

• armada/internal/armada/server/permissions.go
  • Line 13: warning: context.Context should be the first parameter of a function (golint)

• armada/internal/common/util/map.go
  • Line 3: warning: exported function GetOrDefault should have comment or be unexported (golint)

• armada/cmd/armadactl/cmd/watch.go
  • Line 37: warning: don't use underscores in Go names; var exit_on_inactive should be exitOnInactive (golint)

• armada/internal/executor/metrics/pod_metrics/cluster_context.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 61: warning: exported type ClusterContextMetrics should have comment or be unexported (golint)
  • Line 70: warning: exported function ExposeClusterContextMetrics should have comment or be unexported (golint)
  • Line 119: warning: exported method ClusterContextMetrics.Describe should have comment or be unexported (golint)
  • Line 128: warning: exported method ClusterContextMetrics.Collect should have comment or be unexported (golint)
  • Line 178: warning: should omit 2nd value from range; this loop is equivalent to `for q := range ...` (golint)

• armada/internal/armada/cache/queue.go
  • Line 19: warning: exported type QueueCache should have comment or be unexported (golint)
  • Line 30: warning: exported function NewQueueCache should have comment or be unexported (golint)
  • Line 46: warning: exported method QueueCache.Refresh should have comment or be unexported (golint)
  • Line 134: warning: exported method QueueCache.GetQueueMetrics should have comment or be unexported (golint)
  • Line 149: warning: exported method QueueCache.PeekClusterQueue should have comment or be unexported (golint)
  • Line 177: warning: exported method QueueCache.TryLeaseJobs should have comment or be unexported (golint)

• armada/internal/executor/domain/kubernetes_extensions.go
  • Line 5: warning: exported type Patch should have comment or be unexported (golint)

• armada/internal/common/constants.go
  • Line 3: warning: exported const PodNamePrefix should have comment or be unexported (golint)

• armada/pkg/client/watch.go
  • Line 17: warning: context.Context should be the first parameter of a function (golint)
  • Line 17: warning: exported function GetJobSetState should have comment or be unexported (golint)
  • Line 26: warning: context.Context should be the first parameter of a function (golint)
  • Line 26: warning: exported function WatchJobSet should have comment or be unexported (golint)
  • Line 30: warning: context.Context should be the first parameter of a function (golint)
  • Line 30: warning: exported function WatchJobSetWithJobIdsFilter should have comment or be unexported (golint)

• armada/internal/armada/protoutils/json_marshaller.go
  • Line 15: warning: exported type JSONMarshaller should have comment or be unexported (golint)
  • Line 17: warning: exported method JSONMarshaller.ContentType should have comment or be unexported (golint)
  • Line 21: warning: exported method JSONMarshaller.Marshal should have comment or be unexported (golint)
  • Line 25: warning: exported method JSONMarshaller.Unmarshal should have comment or be unexported (golint)
  • Line 29: warning: exported method JSONMarshaller.NewDecoder should have comment or be unexported (golint)
  • Line 33: warning: exported method JSONMarshaller.NewEncoder should have comment or be unexported (golint)
  • Line 37: warning: exported method JSONMarshaller.Delimiter should have comment or be unexported (golint)

• armada/internal/common/authentication.go
  • Line 8: warning: exported const UsernameField should have comment or be unexported (golint)
  • Line 9: warning: exported const PasswordField should have comment or be unexported (golint)
  • Line 11: warning: exported type LoginCredentials should have comment or be unexported (golint)
  • Line 16: warning: exported method LoginCredentials.GetRequestMetadata should have comment or be unexported (golint)
  • Line 23: warning: exported method LoginCredentials.RequireTransportSecurity should have comment or be unexported (golint)

• armada/internal/common/validation/podspec.go
  • Line 9: warning: exported function ValidatePodSpec should have comment or be unexported (golint)
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• armada/internal/lookout/configuration/types.go
  • Line 5: warning: exported type NatsConfig should have comment or be unexported (golint)
  • Line 12: warning: exported type LookoutUIConfig should have comment or be unexported (golint)
  • Line 17: warning: exported type PostgresConfig should have comment or be unexported (golint)
  • Line 24: warning: exported type LookoutConfiguration should have comment or be unexported (golint)

• armada/internal/executor/domain/pod_labels.go
  • Line 4: warning: exported const JobId should have comment (or a comment on this block) or be unexported (golint)

• armada/internal/lookout/repository/util.go
  • Line 15: warning: exported type Clock should have comment or be unexported (golint)
  • Line 19: warning: exported type DefaultClock should have comment or be unexported (golint)
  • Line 21: warning: exported method DefaultClock.Now should have comment or be unexported (golint)
  • Line 23: warning: exported function ToUTC should have comment or be unexported (golint)
  • Line 58: warning: exported function StartsWith should have comment or be unexported (golint)
  • Line 62: warning: exported function ParseNullString should have comment or be unexported (golint)
  • Line 69: warning: exported function ParseNullBool should have comment or be unexported (golint)
  • Line 76: warning: exported function ParseNullInt should have comment or be unexported (golint)
  • Line 83: warning: exported function ParseNullFloat should have comment or be unexported (golint)
  • Line 90: warning: exported function ParseNullTime should have comment or be unexported (golint)
  • Line 97: warning: exported function ParseNullTimeDefault should have comment or be unexported (golint)

• armada/internal/armada/metrics/domain.go
  • Line 3: warning: exported type QueueMetrics should have comment or be unexported (golint)

• armada/internal/armada/metrics/recorder.go
  • Line 8: warning: exported type FloatMetricsRecorder should have comment or be unexported (golint)
  • Line 17: warning: exported function NewFloatMetricsRecorder should have comment or be unexported (golint)
  • Line 28: warning: exported function NewDefaultJobDurationMetricsRecorder should have comment or be unexported (golint)
  • Line 41: warning: exported method FloatMetricsRecorder.Record should have comment or be unexported (golint)
  • Line 73: warning: exported method FloatMetricsRecorder.GetMetrics should have comment or be unexported (golint)
  • Line 88: warning: exported type FloatMetrics should have comment or be unexported (golint)
  • Line 97: warning: exported method FloatMetrics.GetMin should have comment or be unexported (golint)
  • Line 101: warning: exported method FloatMetrics.GetMax should have comment or be unexported (golint)
  • Line 105: warning: exported method FloatMetrics.GetMedian should have comment or be unexported (golint)
  • Line 109: warning: exported method FloatMetrics.GetCount should have comment or be unexported (golint)
  • Line 113: warning: exported method FloatMetrics.GetSum should have comment or be unexported (golint)
  • Line 117: warning: exported method FloatMetrics.GetBuckets should have comment or be unexported (golint)

• armada/internal/armada/repository/job.go
  • Line 32: warning: exported const JobNotFound should have comment or be unexported (golint)
  • Line 34: warning: exported type JobRepository should have comment or be unexported (golint)
  • Line 57: warning: exported type RedisJobRepository should have comment or be unexported (golint)
  • Line 62: warning: exported function NewRedisJobRepository should have comment or be unexported (golint)
  • Line 69: warning: exported method RedisJobRepository.CreateJobs should have comment or be unexported (golint)
  • Line 142: warning: exported type SubmitJobResult should have comment or be unexported (golint)
  • Line 149: warning: exported method RedisJobRepository.AddJobs should have comment or be unexported (golint)
  • Line 182: warning: exported method RedisJobRepository.RenewLease should have comment or be unexported (golint)
  • Line 190: warning: exported method RedisJobRepository.ReturnLease should have comment or be unexported (golint)
  • Line 222: warning: exported method RedisJobRepository.DeleteJobs should have comment or be unexported (golint)
  • Line 335: warning: exported method RedisJobRepository.PeekQueue should have comment or be unexported (golint)
  • Line 343: warning: comment on exported method RedisJobRepository.TryLeaseJobs should be of the form "TryLeaseJobs ..." (golint)
  • Line 362: warning: comment on exported method RedisJobRepository.GetExistingJobsByIds should be of the form "GetExistingJobsByIds ..." (golint)
  • Line 405: warning: exported method RedisJobRepository.FilterActiveQueues should have comment or be unexported (golint)
  • Line 426: warning: exported method RedisJobRepository.GetQueueSizes should have comment or be unexported (golint)
  • Line 444: warning: exported method RedisJobRepository.IterateQueueJobs should have comment or be unexported (golint)
  • Line 468: warning: exported method RedisJobRepository.GetLeasedJobIds should have comment or be unexported (golint)
  • Line 500: warning: exported method RedisJobRepository.UpdateStartTime should have comment or be unexported (golint)
  • Line 538: warning: exported type RunInfo should have comment or be unexported (golint)
  • Line 543: warning: comment on exported method RedisJobRepository.GetJobRunInfos should be of the form "GetJobRunInfos ..." (golint)
  • Line 588: warning: exported method RedisJobRepository.GetQueueJobIds should have comment or be unexported (golint)
  • Line 593: warning: exported method RedisJobRepository.GetActiveJobIds should have comment or be unexported (golint)
  • Line 624: warning: exported method RedisJobRepository.GetQueueActiveJobSets should have comment or be unexported (golint)
  • Line 675: warning: exported method RedisJobRepository.ExpireLeases should have comment or be unexported (golint)
  • Line 717: warning: exported method RedisJobRepository.AddRetryAttempt should have comment or be unexported (golint)
  • Line 722: warning: exported method RedisJobRepository.GetNumberOfRetryAttempts should have comment or be unexported (golint)

• armada/internal/armada/repository/queue.go
  • Line 12: warning: exported type QueueRepository should have comment or be unexported (golint)
  • Line 19: warning: exported type RedisQueueRepository should have comment or be unexported (golint)
  • Line 23: warning: exported function NewRedisQueueRepository should have comment or be unexported (golint)
  • Line 27: warning: exported method RedisQueueRepository.GetAllQueues should have comment or be unexported (golint)
  • Line 45: warning: exported method RedisQueueRepository.GetQueue should have comment or be unexported (golint)
  • Line 58: warning: exported method RedisQueueRepository.CreateQueue should have comment or be unexported (golint)
  • Line 67: warning: exported method RedisQueueRepository.DeleteQueue should have comment or be unexported (golint)

• armada/internal/executor/service/stuck_pod_detector.go
  • Line 17: warning: exported type StuckPodDetector should have comment or be unexported (golint)
  • Line 33: warning: exported function NewPodProgressMonitorService should have comment or be unexported (golint)
  • Line 63: warning: error should be the last type when returning multiple items (golint)
  • Line 122: warning: exported method StuckPodDetector.HandleStuckPods should have comment or be unexported (golint)

• armada/internal/armada/scheduling/lease_manager.go
  • Line 12: warning: exported type LeaseManager should have comment or be unexported (golint)
  • Line 19: warning: exported function NewLeaseManager should have comment or be unexported (golint)
  • Line 31: warning: exported method LeaseManager.ExpireLeases should have comment or be unexported (golint)

• armada/internal/armada/repository/event_job_status.go
  • Line 17: warning: exported type NatsEventJobStatusProcessor should have comment or be unexported (golint)
  • Line 24: warning: exported function NewNatsEventJobStatusProcessor should have comment or be unexported (golint)
  • Line 28: warning: exported method NatsEventJobStatusProcessor.Start should have comment or be unexported (golint)
  • Line 73: warning: exported type KafkaEventJobStatusProcessor should have comment or be unexported (golint)
  • Line 78: warning: exported function NewKafkaJobStatusProcessor should have comment or be unexported (golint)
  • Line 82: warning: exported method KafkaEventJobStatusProcessor.ProcessEvents should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words

• armada/pkg/api/api.swagger.go
  • Line 1973: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2817: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2991: warning: "nto" is a misspelling of "not" (misspell)
  • Line 3187: warning: "nto" is a misspelling of "not" (misspell)
  • Line 3219: warning: "nto" is a misspelling of "not" (misspell)
  • Line 3323: warning: "nto" is a misspelling of "not" (misspell)
  • Line 3372: warning: "nto" is a misspelling of "not" (misspell)
  • Line 4056: warning: "nto" is a misspelling of "not" (misspell)
  • Line 4104: warning: "nto" is a misspelling of "not" (misspell)

• armada/pkg/api/lookout/api.swagger.go
  • Line 1266: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2110: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2284: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2480: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2512: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2616: warning: "nto" is a misspelling of "not" (misspell)
  • Line 2665: warning: "nto" is a misspelling of "not" (misspell)
  • Line 3349: warning: "nto" is a misspelling of "not" (misspell)
  • Line 3397: warning: "nto" is a misspelling of "not" (misspell)