gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• zookeeper-operator/controllers/workload/rollout/rollingupdate.go
  • Line 20: warning: cyclomatic complexity 30 of function (*Rollout).RollingUpgrades() is high (> 15) (gocyclo)

golint16%

Golint is a linter for Go source code.

• zookeeper-operator/controllers/workload/common/svc/new.go
  • Line 9: warning: exported method SVC.GenerateService should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/cm/config.go
  • Line 12: warning: exported function GenZkConfig should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/scale/upscale.go
  • Line 14: warning: exported method Scale.UpScale should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/provision/monitor.go
  • Line 13: warning: exported method Provision.ProvisionMonitor should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/provision/svc.go
  • Line 16: warning: comment on exported method Provision.ProvisionService should be of the form "ProvisionService ..." (golint)

• zookeeper-operator/controllers/workload/common/prometheus/generic_client.go
  • Line 9: warning: exported type GenericClientset should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/monitor/monitor.go
  • Line 10: warning: exported type Monitor should have comment or be unexported (golint)
  • Line 15: warning: exported function NewMonitor should have comment or be unexported (golint)
  • Line 22: warning: exported method Monitor.GenerateMongodbServiceMonitor should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/volume/default.go
  • Line 27: warning: exported var DefaultDataVolumeMount should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/observer/const.go
  • Line 5: warning: exported type State should have comment or be unexported (golint)

• zookeeper-operator/api/v1alpha1/workload_webhook.go
  • Line 35: warning: exported method Workload.SetupWebhookWithManager should have comment or be unexported (golint)
  • Line 127: warning: exported method Workload.CheckResourceMem should have comment or be unexported (golint)
  • Line 140: warning: exported method Workload.CheckResourceCpu should have comment or be unexported (golint)
  • Line 154: warning: exported function ResourceMemString2Int should have comment or be unexported (golint)
  • Line 170: warning: exported function ResourceCpuString2Int should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/provision/cm.go
  • Line 17: warning: exported method Provision.ProvisionConfigMap should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/scale/downscale.go
  • Line 14: warning: exported method Scale.DownScale should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/zk/base.go
  • Line 15: warning: exported type BaseClient should have comment or be unexported (golint)
  • Line 22: warning: exported method BaseClient.Get should have comment or be unexported (golint)
  • Line 26: warning: exported method BaseClient.Post should have comment or be unexported (golint)
  • Line 85: warning: exported method BaseClient.Close should have comment or be unexported (golint)
  • Line 95: warning: exported method BaseClient.Equal should have comment or be unexported (golint)
  • Line 105: warning: exported method BaseClient.IsAlive should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/observer/manager.go
  • Line 58: warning: exported method Manager.ObservedStateResolver should have comment or be unexported (golint)
  • Line 88: warning: exported method Manager.StopObserving should have comment or be unexported (golint)

• zookeeper-operator/controllers/k8s/discovery.go
  • Line 10: warning: comment on exported function WrapDiscoveryClient should be of the form "WrapDiscoveryClient ..." (golint)
  • Line 18: warning: comment on exported type DisClient should be of the form "DisClient ..." (with optional leading article) (golint)
  • Line 28: warning: exported type ClusterDiscoveryClient should have comment or be unexported (golint)
  • Line 40: warning: exported method ClusterDiscoveryClient.OpenAPISchema should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/scale/reconfig.go
  • Line 20: warning: exported type AddMember should have comment or be unexported (golint)
  • Line 24: warning: exported method Scale.ReConfig should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/cm/new.go
  • Line 13: warning: exported type ZkConfigMap should have comment or be unexported (golint)
  • Line 18: warning: exported method CM.GenerateConfigMap should have comment or be unexported (golint)
  • Line 85: warning: exported function GenConfigMap should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/sts/sts.go
  • Line 5: warning: exported type STS should have comment or be unexported (golint)
  • Line 10: warning: exported function NewSTS should have comment or be unexported (golint)

• zookeeper-operator/controllers/getter.go
  • Line 21: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 26: warning: exported type ServiceGetter should have comment or be unexported (golint)
  • Line 31: warning: exported type GetOptions should have comment or be unexported (golint)
  • Line 45: warning: exported type ServiceGetterImpl should have comment or be unexported (golint)
  • Line 48: warning: exported method ServiceGetterImpl.Workload should have comment or be unexported (golint)

• zookeeper-operator/controllers/k8s/new.go
  • Line 18: warning: exported function NewKubeClient should have comment or be unexported (golint)
  • Line 38: warning: exported type Factory should have comment or be unexported (golint)
  • Line 68: warning: exported function NewFactory should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/provision/provision.go
  • Line 23: warning: exported type Provision should have comment or be unexported (golint)
  • Line 40: warning: exported method Provision.Reconcile should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/model/const.go
  • Line 4: warning: exported const AppLabel should have comment (or a comment on this block) or be unexported (golint)
  • Line 11: warning: exported const ZooKeeperStatefulset should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported const ExporterPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: exported const AgentPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: exported const ClientPort should have comment (or a comment on this block) or be unexported (golint)
  • Line 70: warning: exported const ServiceMonitorInterval should have comment (or a comment on this block) or be unexported (golint)

• zookeeper-operator/controllers/workload_controller.go
  • Line 62: warning: exported var ReconcileWaitResult should have comment or be unexported (golint)
  • Line 75: warning: exported method WorkloadReconciler.Reconcile should have comment or be unexported (golint)
  • Line 124: warning: exported method WorkloadReconciler.SetupWithManager should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/scale/scale.go
  • Line 12: warning: exported type Scale should have comment or be unexported (golint)
  • Line 23: warning: exported method Scale.Reconcile should have comment or be unexported (golint)

• zookeeper-operator/agent/http/run.go
  • Line 20: warning: exported type AddMember should have comment or be unexported (golint)
  • Line 47: warning: exported function Health should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/utils/stringutil.go
  • Line 5: warning: exported function Joins should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/provision/sts.go
  • Line 17: warning: exported method Provision.ProvisionStatefulset should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/cm/agent.go
  • Line 4: warning: exported const AgentConfigKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 7: warning: exported function GenZkAgentConfig should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/sts/utils.go
  • Line 76: warning: exported function GetExporterImage should have comment or be unexported (golint)
  • Line 80: warning: exported method STS.CreateExporterContainer should have comment or be unexported (golint)
  • Line 140: warning: comment on exported function GenJvmHeapSize should be of the form "GenJvmHeapSize ..." (golint)
  • Line 238: warning: exported function GetDataVolume should have comment or be unexported (golint)
  • Line 269: warning: exported method STS.CreateAgentContainer should have comment or be unexported (golint)
  • Line 335: warning: exported function GetStatefulSet should have comment or be unexported (golint)

• zookeeper-operator/controllers/k8s/dynamic.go
  • Line 37: warning: exported type ClusterDynamicClient should have comment or be unexported (golint)
  • Line 92: warning: comment on exported method ClusterDynamicClient.List should be of the form "List ..." (golint)

• zookeeper-operator/agent/g/cfg.go
  • Line 12: warning: exported type HttpConfig should have comment or be unexported (golint)
  • Line 18: warning: exported type GlobalConfig should have comment or be unexported (golint)
  • Line 28: warning: exported var ConfigFile should have comment or be unexported (golint)
  • Line 33: warning: exported function Config should have comment or be unexported (golint)
  • Line 39: warning: exported function Hostname should have comment or be unexported (golint)
  • Line 57: warning: exported function ParseConfig should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/rollout/rollingupdate.go
  • Line 20: warning: exported method Rollout.RollingUpgrades should have comment or be unexported (golint)
  • Line 224: warning: exported function NodesInCluster should have comment or be unexported (golint)
  • Line 248: warning: exported function PodRevision should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/sts/const.go
  • Line 4: warning: comment on exported const PrepareFilesystemContainerName should be of the form "PrepareFilesystemContainerName ..." (golint)
  • Line 12: warning: exported const EnvPodIP should have comment (or a comment on this block) or be unexported (golint)

• zookeeper-operator/controllers/k8s/client.go
  • Line 45: warning: exported type ClusterClient should have comment or be unexported (golint)
  • Line 87: warning: exported method ClusterClient.WriteStatus should have comment or be unexported (golint)

• zookeeper-operator/agent/http/http.go
  • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 12: warning: exported type Dto should have comment or be unexported (golint)
  • Line 17: warning: exported function RenderJson should have comment or be unexported (golint)
  • Line 28: warning: exported function RenderDataJson should have comment or be unexported (golint)
  • Line 32: warning: exported function RenderMsgJson should have comment or be unexported (golint)
  • Line 36: warning: exported function AutoRender should have comment or be unexported (golint)
  • Line 45: warning: exported function Start should have comment or be unexported (golint)

• zookeeper-operator/agent/http/routes.go
  • Line 9: warning: exported type Route should have comment or be unexported (golint)
  • Line 28: warning: exported function NewRouter should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/provision/finalizer.go
  • Line 9: warning: exported method Provision.FinalizersFor should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/scale/sts.go
  • Line 13: warning: exported method Scale.StatefulSet should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/provision/observer.go
  • Line 25: warning: exported const DefaultObservationInterval should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: exported method Provision.Observer should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/svc/svc.go
  • Line 5: warning: exported type SVC should have comment or be unexported (golint)
  • Line 10: warning: exported function NewSVC should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/workload.go
  • Line 39: warning: exported method ReconcileWorkload.Reconcile should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/sts/volume.go
  • Line 8: warning: exported function BuildDefaultVolumes should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/utils/pod.go
  • Line 42: warning: exported function PodNames should have comment or be unexported (golint)
  • Line 50: warning: exported function GetReplicas should have comment or be unexported (golint)
  • Line 57: warning: exported function GetByName should have comment or be unexported (golint)
  • Line 69: warning: comment on exported function IsPodReady should be of the form "IsPodReady ..." (golint)
  • Line 80: warning: exported function GetStatefulSetPods should have comment or be unexported (golint)
  • Line 102: warning: exported function GetCurrentPods should have comment or be unexported (golint)
  • Line 146: warning: comment on exported function GetPodIp should be of the form "GetPodIp ..." (golint)
  • Line 162: warning: exported function GetServiceUrl should have comment or be unexported (golint)

• zookeeper-operator/agent/api/base.go
  • Line 18: warning: comment on exported function WriteJSON should be of the form "WriteJSON ..." (golint)

• zookeeper-operator/controllers/workload/rollout/rollout.go
  • Line 13: warning: exported type Rollout should have comment or be unexported (golint)
  • Line 24: warning: exported method Rollout.Reconcile should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/getter.go
  • Line 27: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 32: warning: exported type Getter should have comment or be unexported (golint)
  • Line 43: warning: exported type GetOptions should have comment or be unexported (golint)
  • Line 59: warning: exported type GetterImpl should have comment or be unexported (golint)
  • Line 62: warning: exported method ReconcileWorkload.GetOptions should have comment or be unexported (golint)
  • Line 78: warning: exported method GetterImpl.ProvisionWorkload should have comment or be unexported (golint)
  • Line 95: warning: exported method GetterImpl.ScaleWorkload should have comment or be unexported (golint)
  • Line 106: warning: exported method GetterImpl.RolloutWorkload should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/volume/volume.go
  • Line 7: warning: exported type ConfigMapVolume should have comment or be unexported (golint)
  • Line 18: warning: exported method ConfigMapVolume.Volume should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/observer/observer.go
  • Line 36: warning: exported type Observer should have comment or be unexported (golint)
  • Line 78: warning: exported method Observer.Stop should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/sts/new.go
  • Line 13: warning: exported method STS.GenerateStatefulset should have comment or be unexported (golint)

• zookeeper-operator/agent/g/const.go
  • Line 4: warning: exported const VERSION should have comment (or a comment on this block) or be unexported (golint)

• zookeeper-operator/controllers/workload/common/zk/client.go
  • Line 29: warning: exported type ClusterStats should have comment or be unexported (golint)
  • Line 34: warning: exported method BaseClient.GetClusterStatus should have comment or be unexported (golint)
  • Line 39: warning: exported method BaseClient.GetClusterUp should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/volume/const.go
  • Line 4: warning: exported const DataVolClaimName should have comment (or a comment on this block) or be unexported (golint)
  • Line 9: warning: exported const ConfigFileName should have comment (or a comment on this block) or be unexported (golint)

• zookeeper-operator/controllers/workload/common/cm/cm.go
  • Line 8: warning: exported type CM should have comment or be unexported (golint)
  • Line 15: warning: exported function NewCM should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/sts/initcontainer.go
  • Line 24: warning: exported function NewPrepareFSInitContainer should have comment or be unexported (golint)
  • Line 56: warning: exported function InitContainerVolumeMount should have comment or be unexported (golint)
  • Line 63: warning: exported function InitContainerVolumeMounts should have comment or be unexported (golint)

• zookeeper-operator/controllers/merge_labels.go
  • Line 7: warning: exported function GenerateLabels should have comment or be unexported (golint)
  • Line 18: warning: exported function MergeLabels should have comment or be unexported (golint)

• zookeeper-operator/agent/g/logger.go
  • Line 5: warning: exported function InitLog should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/prometheus/registry.go
  • Line 11: warning: exported function NewRegistry should have comment or be unexported (golint)
  • Line 20: warning: exported function GetGenericClient should have comment or be unexported (golint)

• zookeeper-operator/api/v1alpha1/workload_types.go
  • Line 61: warning: exported type UpdateStrategy should have comment or be unexported (golint)
  • Line 78: warning: exported function Int32 should have comment or be unexported (golint)
  • Line 80: warning: exported type ClusterSpec should have comment or be unexported (golint)
  • Line 92: warning: exported type ExporterSpec should have comment or be unexported (golint)
  • Line 99: warning: comment on exported type Resources should be of the form "Resources ..." (with optional leading article) (golint)
  • Line 111: warning: comment on exported type Storage should be of the form "Storage ..." (with optional leading article) (golint)
  • Line 119: warning: exported type PodAffinity should have comment or be unexported (golint)
  • Line 161: warning: exported type ZkResource should have comment or be unexported (golint)
  • Line 168: warning: exported type ZooKeeperOrchestrationPhase should have comment or be unexported (golint)
  • Line 171: warning: comment on exported const ZooKeeperReadyPhase should be of the form "ZooKeeperReadyPhase ..." (golint)
  • Line 179: warning: exported const ZooKeeperDownScaling should have comment (or a comment on this block) or be unexported (golint)

• zookeeper-operator/controllers/workload/common/cm/const.go
  • Line 4: warning: exported const ConfigFileName should have comment (or a comment on this block) or be unexported (golint)

• zookeeper-operator/controllers/workload/common/cm/init_script.go
  • Line 13: warning: exported var ConfigVolume should have comment or be unexported (golint)
  • Line 40: warning: exported method SharedVolumeArray.Volumes should have comment or be unexported (golint)
  • Line 53: warning: comment on exported type SharedVolumeArray should be of the form "SharedVolumeArray ..." (with optional leading article) (golint)
  • Line 97: warning: exported const PrepareFsScriptConfigKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 160: warning: exported function RenderPrepareFsScript should have comment or be unexported (golint)

• zookeeper-operator/controllers/workload/common/sts/resource.go
  • Line 65: warning: exported function IsUpgradeStsResource should have comment or be unexported (golint)
  • Line 74: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!