Preparing report...

Report for github.com/IBM/dataset-lifecycle-framework

A    Great!    Found 30 issues across 54 files

Tweet

gofmt74%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint64%

Golint is a linter for Go source code.

    • dataset-lifecycle-framework/src/csi-driver-nfs/pkg/nfs/controllerserver.go
    • Line 11: warning: exported type ControllerServer should have comment or be unexported (golint)
    • Line 15: warning: exported method ControllerServer.CreateVolume should have comment or be unexported (golint)
    • Line 19: warning: exported method ControllerServer.DeleteVolume should have comment or be unexported (golint)
    • Line 23: warning: exported method ControllerServer.ControllerPublishVolume should have comment or be unexported (golint)
    • Line 27: warning: exported method ControllerServer.ControllerUnpublishVolume should have comment or be unexported (golint)
    • Line 31: warning: exported method ControllerServer.ValidateVolumeCapabilities should have comment or be unexported (golint)
    • Line 35: warning: exported method ControllerServer.ListVolumes should have comment or be unexported (golint)
    • Line 39: warning: exported method ControllerServer.GetCapacity should have comment or be unexported (golint)
    • Line 53: warning: exported method ControllerServer.CreateSnapshot should have comment or be unexported (golint)
    • Line 57: warning: exported method ControllerServer.DeleteSnapshot should have comment or be unexported (golint)
    • Line 61: warning: exported method ControllerServer.ListSnapshots should have comment or be unexported (golint)
    • Line 65: warning: exported method ControllerServer.ControllerExpandVolume should have comment or be unexported (golint)
    • dataset-lifecycle-framework/src/dataset-operator/pkg/apis/com/v1alpha1/zz_generated.openapi.go
    • Line 12: warning: exported function GetOpenAPIDefinitions should have comment or be unexported (golint)
    • Line 20: warning: don't use underscores in Go names; func schema_pkg_apis_com_v1alpha1_Dataset should be schemaPkgApisComV1alpha1Dataset (golint)
    • Line 63: warning: don't use underscores in Go names; func schema_pkg_apis_com_v1alpha1_DatasetSpec should be schemaPkgApisComV1alpha1DatasetSpec (golint)
    • Line 103: warning: don't use underscores in Go names; func schema_pkg_apis_com_v1alpha1_DatasetStatus should be schemaPkgApisComV1alpha1DatasetStatus (golint)
    • dataset-lifecycle-framework/src/dataset-operator/pkg/admissioncontroller/mutate.go
    • Line 1: warning: package comment should be of the form "Package admissioncontroller ..." (golint)
    • Line 71: warning: don't use underscores in Go names; var existing_volumes_id should be existingVolumesID (golint)
    • Line 72: warning: don't use underscores in Go names; var datasets_tomount should be datasetsTomount (golint)
    • Line 73: warning: don't use underscores in Go names; var configs_toinject should be configsToinject (golint)
    • Line 96: warning: don't use underscores in Go names; var existing_volumes_id should be existingVolumesID (golint)
    • Line 108: warning: don't use underscores in Go names; range var container_idx should be containerIdx (golint)
    • Line 110: warning: don't use underscores in Go names; var mount_names should be mountNames (golint)
    • Line 112: warning: don't use underscores in Go names; var mount_name should be mountName (golint)
    • Line 115: warning: don't use underscores in Go names; var mount_idx should be mountIdx (golint)
    • Line 117: warning: don't use underscores in Go names; range var dataset_tomount should be datasetTomount (golint)
    • Line 130: warning: don't use underscores in Go names; var mount_idx should be mountIdx (golint)
    • Line 135: warning: don't use underscores in Go names; range var config_toinject should be configToinject (golint)
    • Line 138: warning: don't use underscores in Go names; var configmap_ref should be configmapRef (golint)
    • Line 146: warning: don't use underscores in Go names; var secret_ref should be secretRef (golint)
    • Line 202: warning: don't use underscores in Go names; func in_array should be inArray (golint)
    • dataset-lifecycle-framework/src/csi-driver-nfs/pkg/nfs/utils.go
    • Line 13: warning: exported function NewDefaultIdentityServer should have comment or be unexported (golint)
    • Line 19: warning: exported function NewControllerServer should have comment or be unexported (golint)
    • Line 25: warning: exported function NewControllerServiceCapability should have comment or be unexported (golint)
    • Line 35: warning: exported function ParseEndpoint should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign90%

IneffAssign detects ineffectual assignments in Go code.


misspell96%

Misspell Finds commonly misspelled English words