gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• kombustion/internal/genplugin/genplugin.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kombustion/internal/tasks/events_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kombustion/internal/plugins/add_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint98%

Golint is a linter for Go source code.

• kombustion/internal/manifest/init.go
  • Line 12: warning: exported type InitialisePrompter should have comment or be unexported (golint)
  • Line 18: warning: comment on exported function InitialiseNewManifest should be of the form "InitialiseNewManifest ..." (golint)

• kombustion/internal/plugins/lock/load.go
  • Line 13: warning: exported function GetLockObject should have comment or be unexported (golint)

• kombustion/internal/cloudformation/wrapper.go
  • Line 8: warning: comment on exported type StackEventer should be of the form "StackEventer ..." (with optional leading article) (golint)
  • Line 16: warning: comment on exported type StackUpserter should be of the form "StackUpserter ..." (with optional leading article) (golint)
  • Line 31: warning: exported type StackDeleter should have comment or be unexported (golint)
  • Line 39: warning: exported type Wrapper should have comment or be unexported (golint)
  • Line 43: warning: comment on exported function NewWrapper should be of the form "NewWrapper ..." (golint)
  • Line 51: warning: exported method Wrapper.Open should have comment or be unexported (golint)
  • Line 57: warning: exported method Wrapper.DescribeStackEvents should have comment or be unexported (golint)
  • Line 64: warning: exported method Wrapper.DescribeStackEventsPages should have comment or be unexported (golint)
  • Line 71: warning: exported method Wrapper.DescribeStacks should have comment or be unexported (golint)
  • Line 78: warning: exported method Wrapper.DeleteStack should have comment or be unexported (golint)
  • Line 85: warning: exported method Wrapper.CreateChangeSet should have comment or be unexported (golint)
  • Line 92: warning: exported method Wrapper.DescribeChangeSet should have comment or be unexported (golint)
  • Line 99: warning: exported method Wrapper.WaitUntilChangeSetCreateComplete should have comment or be unexported (golint)
  • Line 106: warning: exported method Wrapper.ExecuteChangeSet should have comment or be unexported (golint)
  • Line 113: warning: exported method Wrapper.DeleteChangeSet should have comment or be unexported (golint)

• kombustion/types/types.go
  • Line 3: warning: exported type Validatable should have comment or be unexported (golint)

• kombustion/internal/plugins/lock/plugin.go
  • Line 9: warning: exported method Plugin.Match should have comment or be unexported (golint)
  • Line 13: warning: exported method Plugin.Resolve should have comment or be unexported (golint)
  • Line 22: warning: exported method Plugin.ResolveForRuntime should have comment or be unexported (golint)

• kombustion/tools/vscode-helper/main.go
  • Line 18: warning: exported type TypeDefinition should have comment or be unexported (golint)
  • Line 24: warning: exported type FieldDefinition should have comment or be unexported (golint)

• kombustion/internal/cloudformation/types.go
  • Line 36: warning: comment on exported type Parameter should be of the form "Parameter ..." (with optional leading article) (golint)

• kombustion/internal/manifest/environment.go
  • Line 3: warning: exported method Environment.IsAllowlistedAccount should have comment or be unexported (golint)

• kombustion/internal/manifest/write.go
  • Line 8: warning: comment on exported function WriteManifestObject should be of the form "WriteManifestObject ..." (golint)

• kombustion/internal/plugins/lock/write.go
  • Line 10: warning: exported method Lock.Save should have comment or be unexported (golint)

• kombustion/internal/cloudformation/tasks/upsert.go
  • Line 17: warning: exported function UpsertStackBody should have comment or be unexported (golint)
  • Line 38: warning: exported function UpsertStackURL should have comment or be unexported (golint)
  • Line 113: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• kombustion/internal/genplugin/genplugin.go
  • Line 20: warning: exported type YamlConfig should have comment or be unexported (golint)
  • Line 31: warning: exported type CfResource should have comment or be unexported (golint)
  • Line 39: warning: exported type CfParameter should have comment or be unexported (golint)
  • Line 53: warning: exported type ResourceMap should have comment or be unexported (golint)
  • Line 54: warning: exported type ParameterMap should have comment or be unexported (golint)
  • Line 119: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 377: warning: exported function GetCloudformationClientn should have comment or be unexported (golint)

• kombustion/internal/coretest/object_store.go
  • Line 11: warning: exported type MockObjectStore should have comment or be unexported (golint)
  • Line 15: warning: exported function NewMockObjectStore should have comment or be unexported (golint)

• kombustion/internal/manifest/manifest.go
  • Line 11: warning: exported function CheckManifestExists should have comment or be unexported (golint)
  • Line 19: warning: exported function GetManifestObject should have comment or be unexported (golint)

• kombustion/internal/tasks/init.go
  • Line 21: warning: comment on exported function InitialiseNewManifestTask should be of the form "InitialiseNewManifestTask ..." (golint)

• kombustion/generate/util.go
  • Line 161: warning: comment on exported type ByType should be of the form "ByType ..." (with optional leading article) (golint)
  • Line 170: warning: exported type ByName should have comment or be unexported (golint)

• kombustion/internal/core/object_store.go
  • Line 15: warning: exported type ObjectStore should have comment or be unexported (golint)
  • Line 20: warning: exported type FileSystemStore should have comment or be unexported (golint)
  • Line 24: warning: exported function NewFilesystemStore should have comment or be unexported (golint)
  • Line 31: warning: exported method FileSystemStore.Get should have comment or be unexported (golint)
  • Line 53: warning: exported method FileSystemStore.Put should have comment or be unexported (golint)
  • Line 77: warning: exported type S3ObjectStore should have comment or be unexported (golint)
  • Line 83: warning: exported function NewS3ObjectStore should have comment or be unexported (golint)
  • Line 93: warning: exported method S3ObjectStore.Get should have comment or be unexported (golint)
  • Line 112: warning: exported method S3ObjectStore.Put should have comment or be unexported (golint)

gocyclo99%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• kombustion/internal/genplugin/genplugin.go
  • Line 232: warning: cyclomatic complexity 26 of function generateResources() is high (> 15) (gocyclo)
  • Line 108: warning: cyclomatic complexity 16 of function printMap() is high (> 15) (gocyclo)

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• kombustion/internal/genplugin/genplugin.go
  • Line 111: warning: ineffectual assignment to hasSubmaps (ineffassign)

• kombustion/internal/plugins/add.go
  • Line 29: warning: ineffectual assignment to err (ineffassign)

• kombustion/internal/core/update.go
  • Line 181: warning: ineffectual assignment to err (ineffassign)

• kombustion/internal/cloudformation/template.go
  • Line 30: warning: ineffectual assignment to coreParsers (ineffassign)
  • Line 31: warning: ineffectual assignment to pluginParsers (ineffassign)
  • Line 95: warning: ineffectual assignment to conditions (ineffassign)
  • Line 96: warning: ineffectual assignment to metadata (ineffassign)
  • Line 97: warning: ineffectual assignment to mappings (ineffassign)
  • Line 98: warning: ineffectual assignment to outputs (ineffassign)
  • Line 99: warning: ineffectual assignment to parameters (ineffassign)
  • Line 100: warning: ineffectual assignment to resources (ineffassign)
  • Line 101: warning: ineffectual assignment to transform (ineffassign)
  • Line 307: warning: ineffectual assignment to result (ineffassign)
  • Line 329: warning: ineffectual assignment to result (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!