Report for github.com/Kindling-project/kindling/collector
(v0.0.0-20220215021813-6bd230137baa)
A+ Excellent! Found 77 issues across 118 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo99%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
analyzer/network/protocol/dns/dns_helper.go
- Line 60: warning: cyclomatic complexity 17 of function unpackDomainName() is high (> 15) (gocyclo)
golint34%
Golint is a linter for Go source code.
-
-
analyzer/network/protocol/kafka/kafka_api.go
- Line 67: warning: don't use underscores in Go names; var kafka_apis should be kafkaApis (golint)
- Line 126: warning: exported function IsValidVersion should have comment or be unexported (golint)
-
-
analyzer/network/protocol/kafka/kafka_parser.go
- Line 7: warning: comment on exported function NewKafkaParser should be of the form "NewKafkaParser ..." (golint)
-
-
analyzer/network/protocol/dns/dns_parser.go
- Line 9: warning: exported const DNSHeaderSize should have comment (or a comment on this block) or be unexported (golint)
- Line 18: warning: comment on exported function NewDnsParser should be of the form "NewDnsParser ..." (golint)
-
-
analyzer/tools/traceid_parser.go
- Line 5: warning: exported function ParseTraceHeader should have comment or be unexported (golint)
-
-
metadata/kubernetes/initk8s.go
- Line 26: warning: comment on exported const DefaultKubeConfigPath should be of the form "DefaultKubeConfigPath ..." (golint)
- Line 56: warning: exported var MetaDataCache should have comment or be unexported (golint)
- Line 61: warning: exported function InitK8sHandler should have comment or be unexported (golint)
-
-
analyzer/tcpmetricanalyzer/config.go
- Line 3: warning: exported type Config should have comment or be unexported (golint)
-
-
consumer/processor/kindlingformatprocessor/relabel_processor.go
- Line 12: warning: exported const ProcessorName should have comment or be unexported (golint)
- Line 21: warning: exported function NewRelabelProcessor should have comment or be unexported (golint)
- Line 29: warning: exported method RelabelProcessor.Consume should have comment or be unexported (golint)
- Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
metadata/kubernetes/config.go
- Line 9: warning: exported type Option should have comment or be unexported (golint)
-
-
consumer/processor/nodemetricprocessor/config.go
- Line 3: warning: exported type Config should have comment or be unexported (golint)
-
-
consumer/processor/nodemetricprocessor/node_metric_processor.go
- Line 17: warning: exported const Type should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported type NodeMetricProcessor should have comment or be unexported (golint)
- Line 27: warning: exported function New should have comment or be unexported (golint)
- Line 39: warning: exported method NodeMetricProcessor.Consume should have comment or be unexported (golint)
-
-
analyzer/network/protocol/mysql/tools/sql_merger.go
- Line 10: warning: exported var SQL_MERGER should have comment or be unexported (golint)
- Line 13: warning: exported type SqlMerger should have comment or be unexported (golint)
- Line 17: warning: exported type SqlParser should have comment or be unexported (golint)
- Line 24: warning: exported function NewSqlMerger should have comment or be unexported (golint)
- Line 39: warning: exported method SqlMerger.ParseStatement should have comment or be unexported (golint)
-
-
consumer/processor/kindlingformatprocessor/inner_dictionary.go
- Line 11: warning: exported const GreenStatus should have comment (or a comment on this block) or be unexported (golint)
- Line 51: warning: exported type Relabel should have comment or be unexported (golint)
- Line 60: warning: exported function MetricName should have comment or be unexported (golint)
- Line 73: warning: exported function TraceName should have comment or be unexported (golint)
- Line 87: warning: exported function ProtocolDetailMetricName should have comment or be unexported (golint)
- Line 96: warning: exported function ServiceK8sInfo should have comment or be unexported (golint)
- Line 109: warning: exported function TopologyTraceK8sInfo should have comment or be unexported (golint)
- Line 125: warning: exported function TopologyK8sInfo should have comment or be unexported (golint)
- Line 141: warning: exported function SrcDockerInfo should have comment or be unexported (golint)
- Line 148: warning: exported function ServiceInstanceInfo should have comment or be unexported (golint)
- Line 155: warning: exported function TopologyTraceInstanceInfo should have comment or be unexported (golint)
- Line 160: warning: exported function TopologyInstanceInfo should have comment or be unexported (golint)
- Line 168: warning: exported function DstInstanceInfo should have comment or be unexported (golint)
- Line 182: warning: exported function ServiceProtocolInfo should have comment or be unexported (golint)
- Line 187: warning: exported function TopologyProtocolInfo should have comment or be unexported (golint)
- Line 192: warning: exported function ProtocolDetailInfo should have comment or be unexported (golint)
- Line 196: warning: exported function TraceStatusInfo should have comment or be unexported (golint)
-
-
model/trace.go
- Line 3: warning: exported type Trace should have comment or be unexported (golint)
-
-
metadata/kubernetes/node_watch.go
- Line 13: warning: exported type NodeInfo should have comment or be unexported (golint)
- Line 67: warning: exported function NodeWatch should have comment or be unexported (golint)
- Line 92: warning: exported function AddNode should have comment or be unexported (golint)
- Line 108: warning: exported function UpdateNode should have comment or be unexported (golint)
- Line 113: warning: exported function DeleteNode should have comment or be unexported (golint)
-
-
observability/logger/logger.go
- Line 12: warning: exported type Config should have comment or be unexported (golint)
- Line 27: warning: exported function CreateConsoleLogger should have comment or be unexported (golint)
- Line 32: warning: exported function CreateFileRotationLogger should have comment or be unexported (golint)
- Line 37: warning: exported function InitLogger should have comment or be unexported (golint)
- Line 63: warning: exported function CreateDefaultLogger should have comment or be unexported (golint)
-
-
metadata/conntracker/conntracker_cache.go
- Line 22: warning: exported type IPTranslation should have comment or be unexported (golint)
-
-
observability/histogram_boundary.go
- Line 3: warning: exported const Int64BoundaryMultiplier should have comment or be unexported (golint)
-
-
consumer/exporter/otelexporter/gauge_chan.go
- Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
metadata/kubernetes/k8scache.go
- Line 9: warning: exported type K8sContainerInfo should have comment or be unexported (golint)
- Line 15: warning: exported type K8sPodInfo should have comment or be unexported (golint)
- Line 28: warning: exported type K8sServiceInfo should have comment or be unexported (golint)
- Line 49: warning: exported type K8sMetaDataCache should have comment or be unexported (golint)
- Line 72: warning: exported function New should have comment or be unexported (golint)
- Line 82: warning: exported method K8sMetaDataCache.AddByContainerId should have comment or be unexported (golint)
- Line 88: warning: exported method K8sMetaDataCache.GetByContainerId should have comment or be unexported (golint)
- Line 98: warning: exported method K8sMetaDataCache.GetPodByContainerId should have comment or be unexported (golint)
- Line 108: warning: exported method K8sMetaDataCache.DeleteByContainerId should have comment or be unexported (golint)
- Line 114: warning: exported method K8sMetaDataCache.AddContainerByIpPort should have comment or be unexported (golint)
- Line 131: warning: exported method K8sMetaDataCache.GetContainerByIpPort should have comment or be unexported (golint)
- Line 152: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 160: warning: exported method K8sMetaDataCache.GetPodByIpPort should have comment or be unexported (golint)
- Line 168: warning: exported method K8sMetaDataCache.GetPodByIp should have comment or be unexported (golint)
- Line 184: warning: exported method K8sMetaDataCache.DeleteContainerByIpPort should have comment or be unexported (golint)
- Line 199: warning: exported method K8sMetaDataCache.AddServiceByIpPort should have comment or be unexported (golint)
- Line 216: warning: exported method K8sMetaDataCache.GetServiceByIpPort should have comment or be unexported (golint)
- Line 230: warning: exported method K8sMetaDataCache.DeleteServiceByIpPort should have comment or be unexported (golint)
- Line 245: warning: exported method K8sMetaDataCache.ClearAll should have comment or be unexported (golint)
- Line 267: warning: exported method K8sMetaDataCache.GetNodeNameByIp should have comment or be unexported (golint)
-
-
component/telemetry.go
- Line 13: warning: exported const ObservabilityConfig should have comment (or a comment on this block) or be unexported (golint)
- Line 18: warning: exported type TelemetryManager should have comment or be unexported (golint)
- Line 22: warning: exported function NewTelemetryManager should have comment or be unexported (golint)
- Line 28: warning: exported method TelemetryManager.ConstructConfig should have comment or be unexported (golint)
- Line 58: warning: exported type TelemetryTools should have comment or be unexported (golint)
- Line 63: warning: exported function NewDefaultTelemetryTools should have comment or be unexported (golint)
-
-
analyzer/analyzer.go
- Line 5: warning: exported type Type should have comment or be unexported (golint)
- Line 11: warning: exported type Analyzer should have comment or be unexported (golint)
-
-
receiver/udsreceiver/udsreceiver.go
- Line 24: warning: exported const Uds should have comment (or a comment on this block) or be unexported (golint)
- Line 27: warning: exported type Socket should have comment or be unexported (golint)
- Line 31: warning: exported type UdsReceiver should have comment or be unexported (golint)
- Line 42: warning: exported type Config should have comment or be unexported (golint)
- Line 47: warning: exported type ZeroMqPullSettings should have comment or be unexported (golint)
- Line 53: warning: exported type SubEvent should have comment or be unexported (golint)
- Line 58: warning: exported type ZeroMqReqSettings should have comment or be unexported (golint)
- Line 103: warning: exported function NewUdsReceiver should have comment or be unexported (golint)
- Line 194: warning: exported method UdsReceiver.Start should have comment or be unexported (golint)
- Line 215: warning: exported method UdsReceiver.Shutdown should have comment or be unexported (golint)
- Line 228: warning: exported method UdsReceiver.SendToNextConsumer should have comment or be unexported (golint)
-
-
analyzer/network/network_analyzer.go
- Line 24: warning: exported const CACHE_ADD_THRESHOLD should have comment (or a comment on this block) or be unexported (golint)
- Line 30: warning: exported type NetworkAnalyzer should have comment or be unexported (golint)
- Line 44: warning: exported function NewNetworkAnalyzer should have comment or be unexported (golint)
- Line 53: warning: exported method NetworkAnalyzer.Start should have comment or be unexported (golint)
- Line 93: warning: exported method NetworkAnalyzer.Shutdown should have comment or be unexported (golint)
- Line 98: warning: exported method NetworkAnalyzer.Type should have comment or be unexported (golint)
- Line 102: warning: exported method NetworkAnalyzer.ConsumeEvent should have comment or be unexported (golint)
- Line 143: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 204: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 372: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
analyzer/network/protocol/factory/factory.go
- Line 16: warning: don't use underscores in Go names; var cache_port_parsers_map should be cachePortParsersMap (golint)
- Line 19: warning: don't use underscores in Go names; var generic_parser should be genericParser (golint)
- Line 20: warning: don't use underscores in Go names; var http_parser should be httpParser (golint)
- Line 21: warning: don't use underscores in Go names; var kafka_parser should be kafkaParser (golint)
- Line 22: warning: don't use underscores in Go names; var mysql_parser should be mysqlParser (golint)
- Line 23: warning: don't use underscores in Go names; var redis_parser should be redisParser (golint)
- Line 24: warning: don't use underscores in Go names; var dns_parser should be dnsParser (golint)
- Line 27: warning: exported function GetParser should have comment or be unexported (golint)
- Line 44: warning: exported function GetGenericParser should have comment or be unexported (golint)
- Line 48: warning: exported function GetCachedParsersByPort should have comment or be unexported (golint)
- Line 56: warning: exported function AddCachedParser should have comment or be unexported (golint)
- Line 86: warning: exported function RemoveCachedParser should have comment or be unexported (golint)
-
-
observability/logger/lumberjack.go
- Line 29: warning: exported function ToString should have comment or be unexported (golint)
-
-
metadata/conntracker/conntracker.go
- Line 28: warning: exported type Conntracker should have comment or be unexported (golint)
- Line 37: warning: exported function NewConntracker should have comment or be unexported (golint)
- Line 150: warning: comment on exported method Conntracker.GetDNATTuple should be of the form "GetDNATTuple ..." (golint)
- Line 170: warning: exported method Conntracker.GetDNATTupleWithString should have comment or be unexported (golint)
- Line 179: warning: exported method Conntracker.GetStats should have comment or be unexported (golint)
- Line 190: warning: exported method Conntracker.Close should have comment or be unexported (golint)
-
-
model/metric.go
- Line 17: warning: exported type Gauge should have comment or be unexported (golint)
- Line 22: warning: exported function NewGaugeGroup should have comment or be unexported (golint)
- Line 31: warning: exported method GaugeGroup.GetValue should have comment or be unexported (golint)
-
-
consumer/exporter/otelexporter/otelexporter.go
- Line 34: warning: exported const Otel should have comment (or a comment on this block) or be unexported (golint)
- Line 46: warning: exported type OtelOutputExporters should have comment or be unexported (golint)
- Line 51: warning: exported type OtelExporter should have comment or be unexported (golint)
- Line 61: warning: exported function NewExporter should have comment or be unexported (golint)
- Line 193: warning: exported method OtelExporter.Consume should have comment or be unexported (golint)
- Line 231: warning: exported function ToStringKeyValues should have comment or be unexported (golint)
-
-
metadata/kubernetes/replicaset_watch.go
- Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 12: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 18: warning: exported const ReplicaSetKind should have comment or be unexported (golint)
- Line 20: warning: exported type ReplicaSetMap should have comment or be unexported (golint)
- Line 29: warning: exported type Controller should have comment or be unexported (golint)
- Line 47: warning: exported method ReplicaSetMap.GetOwnerReference should have comment or be unexported (golint)
- Line 60: warning: exported function RsWatch should have comment or be unexported (golint)
- Line 99: warning: exported function OnUpdateReplicaSet should have comment or be unexported (golint)
-
-
analyzer/tcpmetricanalyzer/tcp_analyzer.go
- Line 17: warning: exported const TcpMetric should have comment (or a comment on this block) or be unexported (golint)
- Line 31: warning: exported type TcpMetricAnalyzer should have comment or be unexported (golint)
- Line 37: warning: exported function NewTcpMetricAnalyzer should have comment or be unexported (golint)
- Line 50: warning: exported method TcpMetricAnalyzer.Start should have comment or be unexported (golint)
-
-
model/constlabels/relabel_metric_const.go
- Line 13: warning: exported const TopologyRequestIoMetric should have comment (or a comment on this block) or be unexported (golint)
- Line 23: warning: exported const NPMPrefixKindling should have comment (or a comment on this block) or be unexported (golint)
- Line 29: warning: exported function ToKindlingTraceAsMetricName should have comment or be unexported (golint)
- Line 33: warning: exported function ToKindlingMetricName should have comment or be unexported (golint)
- Line 36: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
consumer/processor/kindlingformatprocessor/protocol.go
- Line 9: warning: exported type ProtocolType should have comment or be unexported (golint)
-
-
model/attribute_map.go
- Line 8: warning: exported type AttributeMap should have comment or be unexported (golint)
- Line 12: warning: exported function NewAttributeMap should have comment or be unexported (golint)
- Line 17: warning: exported function NewAttributeMapWithValues should have comment or be unexported (golint)
- Line 21: warning: exported function NewStringValue should have comment or be unexported (golint)
- Line 25: warning: exported function NewIntValue should have comment or be unexported (golint)
- Line 29: warning: exported function NewBoolValue should have comment or be unexported (golint)
- Line 33: warning: exported method AttributeMap.Merge should have comment or be unexported (golint)
- Line 42: warning: exported method AttributeMap.Size should have comment or be unexported (golint)
- Line 46: warning: exported method AttributeMap.IsEmpty should have comment or be unexported (golint)
- Line 50: warning: exported method AttributeMap.HasAttribute should have comment or be unexported (golint)
- Line 55: warning: exported method AttributeMap.GetStringValue should have comment or be unexported (golint)
- Line 63: warning: exported method AttributeMap.AddStringValue should have comment or be unexported (golint)
- Line 69: warning: exported method AttributeMap.GetIntValue should have comment or be unexported (golint)
- Line 77: warning: exported method AttributeMap.AddIntValue should have comment or be unexported (golint)
- Line 83: warning: exported method AttributeMap.GetBoolValue should have comment or be unexported (golint)
- Line 91: warning: exported method AttributeMap.AddBoolValue should have comment or be unexported (golint)
- Line 97: warning: exported method AttributeMap.RemoveAttribute should have comment or be unexported (golint)
- Line 101: warning: exported method AttributeMap.ClearAttributes should have comment or be unexported (golint)
- Line 105: warning: exported method AttributeMap.ToStringMap should have comment or be unexported (golint)
- Line 113: warning: exported method AttributeMap.GetValues should have comment or be unexported (golint)
- Line 125: warning: exported type AttributeValue should have comment or be unexported (golint)
-
-
observability/config.go
- Line 3: warning: exported type Config should have comment or be unexported (golint)
- Line 7: warning: exported var DefaultConfig should have comment or be unexported (golint)
-
-
consumer/exporter/exporter.go
- Line 7: warning: exported type Exporter should have comment or be unexported (golint)
-
-
analyzer/network/protocol/http/http_parser.go
- Line 9: warning: exported function NewHttpParser should have comment or be unexported (golint)
-
-
application/factory.go
- Line 14: warning: exported const ReceiversKey should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported var ComponentsKeyMap should have comment or be unexported (golint)
- Line 22: warning: exported type ComponentsFactory should have comment or be unexported (golint)
- Line 29: warning: exported type NewReceiverFunc should have comment or be unexported (golint)
- Line 30: warning: exported type NewAnalyzerFunc should have comment or be unexported (golint)
- Line 31: warning: exported type NewProcessorFunc should have comment or be unexported (golint)
- Line 32: warning: exported type NewExporterFunc should have comment or be unexported (golint)
- Line 34: warning: exported type ReceiverFactory should have comment or be unexported (golint)
- Line 39: warning: exported type AnalyzerFactory should have comment or be unexported (golint)
- Line 44: warning: exported type ProcessorFactory should have comment or be unexported (golint)
- Line 49: warning: exported type ExporterFactory should have comment or be unexported (golint)
- Line 54: warning: exported function NewComponentsFactory should have comment or be unexported (golint)
- Line 62: warning: exported method ComponentsFactory.RegisterReceiver should have comment or be unexported (golint)
- Line 73: warning: exported method ComponentsFactory.RegisterAnalyzer should have comment or be unexported (golint)
- Line 84: warning: exported method ComponentsFactory.RegisterProcessor should have comment or be unexported (golint)
- Line 95: warning: exported method ComponentsFactory.RegisterExporter should have comment or be unexported (golint)
- Line 106: warning: exported method ComponentsFactory.ConstructConfig should have comment or be unexported (golint)
-
-
model/constvalues/const.go
- Line 4: warning: exported const RequestTotalTime should have comment (or a comment on this block) or be unexported (golint)
-
-
analyzer/network/protocol/redis/redis_parser.go
- Line 7: warning: exported function NewRedisParser should have comment or be unexported (golint)
-
-
observability/logger/console.go
- Line 8: warning: exported var ConsoleEncodingConfig should have comment or be unexported (golint)
-
-
analyzer/network/config.go
- Line 9: warning: exported type Config should have comment or be unexported (golint)
- Line 24: warning: exported type ProtocolConfig should have comment or be unexported (golint)
- Line 31: warning: exported method Config.GetConnectTimeout should have comment or be unexported (golint)
- Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 39: warning: exported method Config.GetRequestTimeout should have comment or be unexported (golint)
- Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
metadata/kubernetes/service_watch.go
- Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 17: warning: exported type ServiceMap should have comment or be unexported (golint)
- Line 91: warning: exported function ServiceWatch should have comment or be unexported (golint)
- Line 160: warning: exported function OnUpdateService should have comment or be unexported (golint)
-
-
consumer/consumer.go
- Line 5: warning: exported type Consumer should have comment or be unexported (golint)
-
-
analyzer/network/protocol/dns/dns_response.go
- Line 12: warning: exported const TypeA should have comment (or a comment on this block) or be unexported (golint)
-
-
metadata/conntracker/utils.go
- Line 10: warning: exported function IPToUInt32 should have comment or be unexported (golint)
- Line 18: warning: exported function StringToUint32 should have comment or be unexported (golint)
- Line 31: warning: exported function IsNAT should have comment or be unexported (golint)
-
-
consumer/processor/k8sprocessor/kubernetes_processor.go
- Line 15: warning: exported const K8sMetadata should have comment (or a comment on this block) or be unexported (golint)
- Line 19: warning: exported type K8sMetadataProcessor should have comment or be unexported (golint)
- Line 27: warning: exported function NewKubernetesProcessor should have comment or be unexported (golint)
- Line 57: warning: exported type Config should have comment or be unexported (golint)
- Line 62: warning: exported method K8sMetadataProcessor.Consume should have comment or be unexported (golint)
-
-
receiver/mock_receiver.go
- Line 10: warning: exported const Mock should have comment or be unexported (golint)
- Line 12: warning: exported type MockReceiver should have comment or be unexported (golint)
- Line 18: warning: exported function NewMockReceiver should have comment or be unexported (golint)
- Line 30: warning: exported method MockReceiver.Start should have comment or be unexported (golint)
- Line 49: warning: exported method MockReceiver.Shutdown should have comment or be unexported (golint)
- Line 54: warning: exported type Config should have comment or be unexported (golint)
-
-
receiver/receiver.go
- Line 3: warning: exported type Receiver should have comment or be unexported (golint)
-
-
consumer/exporter/otelexporter/agg_kind.go
- Line 3: warning: exported type MetricAggregationKind should have comment or be unexported (golint)
- Line 6: warning: exported const MAGaugeKind should have comment (or a comment on this block) or be unexported (golint)
-
-
application/application.go
- Line 22: warning: exported type Application should have comment or be unexported (golint)
- Line 30: warning: exported function New should have comment or be unexported (golint)
- Line 52: warning: exported method Application.Run should have comment or be unexported (golint)
- Line 65: warning: exported method Application.Shutdown should have comment or be unexported (golint)
-
-
analyzer/network/message_pair.go
- Line 12: warning: exported const LOWER32 should have comment (or a comment on this block) or be unexported (golint)
-
-
consumer/exporter/otelexporter/prometheus.go
- Line 9: warning: exported function StartServer should have comment or be unexported (golint)
-
-
analyzer/network/protocol/generic/generic_parser.go
- Line 7: warning: exported function NewGenericParser should have comment or be unexported (golint)
-
-
consumer/processor/processor.go
- Line 7: warning: exported type Processor should have comment or be unexported (golint)
-
-
receiver/udsreceiver/metrics.go
- Line 11: warning: exported function NewSelfMetrics should have comment or be unexported (golint)
-
-
analyzer/network/protocol/redis/redis_command.go
- Line 307: warning: exported function IsRedisCommand should have comment or be unexported (golint)
-
-
observability/telemetry.go
- Line 24: warning: exported const KindlingServiceNamePrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 27: warning: exported function InitTelemetry should have comment or be unexported (golint)
- Line 72: warning: exported function StartServer should have comment or be unexported (golint)
-
-
metadata/kubernetes/helper.go
- Line 13: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
metadata/kubernetes/pod_watch.go
- Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 18: warning: exported type PodInfo should have comment or be unexported (golint)
- Line 85: warning: exported function PodWatch should have comment or be unexported (golint)
- Line 211: warning: exported function OnUpdate should have comment or be unexported (golint)
-
-
analyzer/network/protocol/protocol.go
- Line 4: warning: exported const HTTP should have comment (or a comment on this block) or be unexported (golint)
-
-
analyzer/network/protocol/mysql/mysql_parser.go
- Line 7: warning: comment on exported function NewMysqlParser should be of the form "NewMysqlParser ..." (golint)
-
-
analyzer/network/protocol/dns/dns_helper.go
- Line 9: warning: exported var ErrBuf should have comment or be unexported (golint)
- Line 11: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
-
-
model/kindling_event_helper.go
- Line 10: warning: exported const LOWER32 should have comment (or a comment on this block) or be unexported (golint)
- Line 15: warning: exported var ErrMessageNotSocket should have comment or be unexported (golint)
- Line 18: warning: exported method KindlingEvent.GetData should have comment or be unexported (golint)
- Line 26: warning: exported method KindlingEvent.GetDataLen should have comment or be unexported (golint)
- Line 34: warning: exported method KindlingEvent.GetResVal should have comment or be unexported (golint)
- Line 42: warning: exported method KindlingEvent.GetLatency should have comment or be unexported (golint)
- Line 50: warning: exported method KindlingEvent.GetStartTime should have comment or be unexported (golint)
- Line 54: warning: exported method KindlingEvent.GetUserAttribute should have comment or be unexported (golint)
- Line 66: warning: exported method KindlingEvent.GetPid should have comment or be unexported (golint)
- Line 78: warning: exported method KindlingEvent.GetContainerId should have comment or be unexported (golint)
- Line 90: warning: exported method KindlingEvent.GetFd should have comment or be unexported (golint)
- Line 102: warning: exported method KindlingEvent.GetSip should have comment or be unexported (golint)
- Line 115: warning: exported method KindlingEvent.GetDip should have comment or be unexported (golint)
- Line 128: warning: exported function IPLong2String should have comment or be unexported (golint)
- Line 142: warning: exported method KindlingEvent.GetSport should have comment or be unexported (golint)
- Line 154: warning: exported method KindlingEvent.GetDport should have comment or be unexported (golint)
- Line 166: warning: exported method KindlingEvent.IsUdp should have comment or be unexported (golint)
- Line 173: warning: exported method KindlingEvent.IsConnect should have comment or be unexported (golint)
- Line 177: warning: exported method KindlingEvent.IsRequest should have comment or be unexported (golint)
- Line 203: warning: exported method KindlingEvent.GetSocketKey should have comment or be unexported (golint)
-
-
analyzer/manager.go
- Line 8: warning: exported type Manager should have comment or be unexported (golint)
- Line 10: warning: exported function NewManager should have comment or be unexported (golint)
- Line 21: warning: exported method Manager.GetAnalyzer should have comment or be unexported (golint)
- Line 26: warning: exported method Manager.StartAll should have comment or be unexported (golint)
- Line 37: warning: exported method Manager.ShutdownAll should have comment or be unexported (golint)
-
-
analyzer/mock_analyzer.go
- Line 10: warning: exported const MockAnalyzerType should have comment or be unexported (golint)
- Line 12: warning: exported type MockAnalyzer should have comment or be unexported (golint)
- Line 18: warning: exported function NewMockAnalyzer should have comment or be unexported (golint)
- Line 30: warning: exported method MockAnalyzer.Start should have comment or be unexported (golint)
- Line 34: warning: exported method MockAnalyzer.ConsumeEvent should have comment or be unexported (golint)
- Line 39: warning: exported method MockAnalyzer.Shutdown should have comment or be unexported (golint)
- Line 43: warning: exported method MockAnalyzer.Type should have comment or be unexported (golint)
- Line 47: warning: exported type Config should have comment or be unexported (golint)
-
-
analyzer/network/protocol/protocol_parser.go
- Line 14: warning: exported const PARSE_FAIL should have comment (or a comment on this block) or be unexported (golint)
- Line 22: warning: exported var ErrMessageComplete should have comment or be unexported (golint)
- Line 29: warning: exported type PayloadMessage should have comment or be unexported (golint)
- Line 35: warning: exported function NewRequestMessage should have comment or be unexported (golint)
- Line 43: warning: exported function NewResponseMessage should have comment or be unexported (golint)
- Line 51: warning: exported method PayloadMessage.IsComplete should have comment or be unexported (golint)
- Line 55: warning: exported method PayloadMessage.HasMoreLength should have comment or be unexported (golint)
- Line 59: warning: exported method PayloadMessage.GetData should have comment or be unexported (golint)
- Line 66: warning: comment on exported method PayloadMessage.GetAttributes should be of the form "GetAttributes ..." (golint)
- Line 71: warning: exported method PayloadMessage.AddIntAttribute should have comment or be unexported (golint)
- Line 75: warning: exported method PayloadMessage.AddStringAttribute should have comment or be unexported (golint)
- Line 79: warning: exported method PayloadMessage.AddBoolAttribute should have comment or be unexported (golint)
- Line 83: warning: exported method PayloadMessage.GetIntAttribute should have comment or be unexported (golint)
- Line 87: warning: exported method PayloadMessage.GetStringAttribute should have comment or be unexported (golint)
- Line 91: warning: exported method PayloadMessage.GetBoolAttribute should have comment or be unexported (golint)
- Line 95: warning: exported method PayloadMessage.HasAttribute should have comment or be unexported (golint)
- Line 99: warning: comment on exported method PayloadMessage.ReadLittleEndianInt should be of the form "ReadLittleEndianInt ..." (golint)
- Line 113: warning: exported method PayloadMessage.ReadUnsignedIntByThreeBytes should have comment or be unexported (golint)
- Line 117: warning: exported method PayloadMessage.ReadUInt16 should have comment or be unexported (golint)
- Line 124: warning: exported method PayloadMessage.ReadInt16 should have comment or be unexported (golint)
- Line 132: warning: exported method PayloadMessage.ReadInt32 should have comment or be unexported (golint)
- Line 143: warning: exported method PayloadMessage.ReadThreeBytes should have comment or be unexported (golint)
- Line 148: warning: exported method PayloadMessage.ReadInt64 should have comment or be unexported (golint)
- Line 159: warning: exported method PayloadMessage.ReadByte should have comment or be unexported (golint)
- Line 167: warning: exported method PayloadMessage.ReadFull should have comment or be unexported (golint)
- Line 194: warning: exported method PayloadMessage.ReadBytes should have comment or be unexported (golint)
- Line 222: warning: exported method PayloadMessage.ReadUnsignedVarInt should have comment or be unexported (golint)
- Line 226: warning: exported method PayloadMessage.ReadVarInt should have comment or be unexported (golint)
- Line 230: warning: exported method PayloadMessage.ReadNullableString should have comment or be unexported (golint)
- Line 269: warning: exported method PayloadMessage.ReadArraySize should have comment or be unexported (golint)
- Line 310: warning: exported method PayloadMessage.ReadString should have comment or be unexported (golint)
- Line 353: warning: exported method PayloadMessage.ReadUntilBlank should have comment or be unexported (golint)
- Line 364: warning: exported method PayloadMessage.ReadUntilBlankWithLength should have comment or be unexported (golint)
- Line 378: warning: comment on exported method PayloadMessage.ReadUntilCRLF should be of the form "ReadUntilCRLF ..." (golint)
- Line 410: warning: exported type FastFailFn should have comment or be unexported (golint)
- Line 411: warning: exported type ParsePkgFn should have comment or be unexported (golint)
- Line 412: warning: exported type PairMatch should have comment or be unexported (golint)
- Line 414: warning: exported type ProtocolParser should have comment or be unexported (golint)
- Line 423: warning: exported function NewProtocolParser should have comment or be unexported (golint)
- Line 433: warning: exported method ProtocolParser.EnableMultiFrame should have comment or be unexported (golint)
- Line 437: warning: exported method ProtocolParser.GetProtocol should have comment or be unexported (golint)
- Line 441: warning: exported method ProtocolParser.MultiRequests should have comment or be unexported (golint)
- Line 445: warning: exported method ProtocolParser.PairMatch should have comment or be unexported (golint)
- Line 452: warning: exported method ProtocolParser.ParseRequest should have comment or be unexported (golint)
- Line 456: warning: exported method ProtocolParser.ParseResponse should have comment or be unexported (golint)
- Line 460: warning: exported type PkgParser should have comment or be unexported (golint)
- Line 466: warning: exported function CreatePkgParser should have comment or be unexported (golint)
- Line 474: warning: exported method PkgParser.Add should have comment or be unexported (golint)
- Line 483: warning: receiver name current should be consistent with previous receiver name parent for PkgParser (golint)
- Line 495: warning: receiver name current should be consistent with previous receiver name parent for PkgParser (golint)
- Line 521: warning: exported method ProtocolParser.AddPortCount should have comment or be unexported (golint)
- Line 525: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 532: warning: exported method ProtocolParser.ResetPort should have comment or be unexported (golint)
-
-
analyzer/uprobeanalyzer/config.go
- Line 3: warning: exported type Config should have comment or be unexported (golint)
-
-
analyzer/uprobeanalyzer/uprobeanalyzer.go
- Line 21: warning: exported const UprobeType should have comment (or a comment on this block) or be unexported (golint)
- Line 29: warning: exported type UprobeAnalyzer should have comment or be unexported (golint)
- Line 37: warning: exported function NewUprobeAnalyzer should have comment or be unexported (golint)
- Line 55: warning: exported method UprobeAnalyzer.Start should have comment or be unexported (golint)
- Line 59: warning: exported method UprobeAnalyzer.ConsumeEvent should have comment or be unexported (golint)
- Line 162: warning: exported method UprobeAnalyzer.Shutdown should have comment or be unexported (golint)
- Line 166: warning: exported method UprobeAnalyzer.Type should have comment or be unexported (golint)
-
-
analyzer/tools/http_merger.go
- Line 11: warning: exported const KEY_THRESHOLD should have comment (or a comment on this block) or be unexported (golint)
- Line 14: warning: exported type HttpMerger should have comment or be unexported (golint)
- Line 19: warning: exported function NewHttpMergeCache should have comment or be unexported (golint)
- Line 27: warning: exported method HttpMerger.GetContentKey should have comment or be unexported (golint)
- Line 105: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
consumer/processor/kindlingformatprocessor/config.go
- Line 3: warning: exported type Config should have comment or be unexported (golint)
-
-
consumer/exporter/otelexporter/config.go
- Line 7: warning: exported type Config should have comment or be unexported (golint)
- Line 16: warning: exported type PrometheusConfig should have comment or be unexported (golint)
- Line 20: warning: exported type OtlpGrpcConfig should have comment or be unexported (golint)
- Line 25: warning: exported type StdoutConfig should have comment or be unexported (golint)
-
-
metadata/kubernetes/scheme.go
- Line 7: warning: exported type BuiltInScheme should have comment or be unexported (golint)
- Line 11: warning: exported function NewKnownScheme should have comment or be unexported (golint)
- Line 22: warning: exported method BuiltInScheme.IsBuiltInGV should have comment or be unexported (golint)
-
-
model/constlabels/const.go
- Line 4: warning: exported const NoError should have comment (or a comment on this block) or be unexported (golint)
- Line 11: warning: exported const Pid should have comment (or a comment on this block) or be unexported (golint)
- Line 69: warning: exported const STR_EMPTY should have comment (or a comment on this block) or be unexported (golint)
-
-
model/constnames/const.go
- Line 4: warning: exported const TcpCloseEvent should have comment (or a comment on this block) or be unexported (golint)
-
-
consumer/exporter/otelexporter/helper.go
- Line 17: warning: exported const CmonitorServiceNamePrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 50: warning: exported function GetCommonLabels should have comment or be unexported (golint)
- Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 71: warning: exported function GetLabels should have comment or be unexported (golint)
-
-
consumer/exporter/otelexporter/instrument.go
- Line 40: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 81: warning: exported function WithDescription should have comment or be unexported (golint)
- Line 96: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
model/constlabels/protocols.go
- Line 4: warning: exported const ContentKey should have comment (or a comment on this block) or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell99%
Misspell Finds commonly misspelled English words
-
-
metadata/conntracker/conntracker.go
- Line 114: warning: "occured" is a misspelling of "occurred" (misspell)