Preparing report...

Report for github.com/MEIZUPUSH/go-meizu-push-sdk

A    Great!    Found 14 issues across 14 files

Tweet

gofmt92%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint0%

Golint is a linter for Go source code.

    • go-meizu-push-sdk/notification-message.go
    • Line 1: warning: don't use MixedCaps in package name; goPushSdk should be gopushsdk (golint)
    • Line 7: warning: comment on exported type NoticeBarInfo should be of the form "NoticeBarInfo ..." (with optional leading article) (golint)
    • Line 23: warning: exported type NoticeExpandInfo should have comment or be unexported (golint)
    • Line 28: warning: comment on exported type ClickTypeInfo should be of the form "ClickTypeInfo ..." (with optional leading article) (golint)
    • Line 43: warning: comment on exported type PushTimeInfo should be of the form "PushTimeInfo ..." (with optional leading article) (golint)
    • Line 52: warning: comment on exported type AdvanceInfo should be of the form "AdvanceInfo ..." (with optional leading article) (golint)
    • Line 73: warning: exported type NotificationType should have comment or be unexported (golint)
    • Line 79: warning: exported type NotificationMessage should have comment or be unexported (golint)
    • Line 87: warning: exported function BuildNotificationMessage should have comment or be unexported (golint)
    • Line 210: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • go-meizu-push-sdk/through-message.go
    • Line 1: warning: don't use MixedCaps in package name; goPushSdk should be gopushsdk (golint)
    • Line 18: warning: comment on exported type ThroughMessage should be of the form "ThroughMessage ..." (with optional leading article) (golint)
    • Line 26: warning: don't use underscores in Go names; type T_PushTimeInfo should be TPushTimeInfo (golint)
    • Line 26: warning: exported type T_PushTimeInfo should have comment or be unexported (golint)
    • Line 31: warning: don't use underscores in Go names; type T_AdvanceInfo should be TAdvanceInfo (golint)
    • Line 31: warning: exported type T_AdvanceInfo should have comment or be unexported (golint)
    • go-meizu-push-sdk/pushstatics.go
    • Line 1: warning: don't use MixedCaps in package name; goPushSdk should be gopushsdk (golint)
    • Line 7: warning: comment on exported function GetTaskStatistics should be of the form "GetTaskStatistics ..." (golint)
    • go-meizu-push-sdk/common.go
    • Line 1: warning: don't use MixedCaps in package name; goPushSdk should be gopushsdk (golint)
    • Line 13: warning: exported const SERVER should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: comment on exported const PUSH_API_SERVER should be of the form "PUSH_API_SERVER ..." (golint)
    • Line 19: warning: exported type PushResponse should have comment or be unexported (golint)
    • Line 24: warning: comment on exported function GenerateSign should be of the form "GenerateSign ..." (golint)
    • Line 30: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)
    • Line 44: warning: exported function PushParamMD5 should have comment or be unexported (golint)
    • Line 50: warning: comment on exported function ResolvePushResponse should be of the form "ResolvePushResponse ..." (golint)
    • go-meizu-push-sdk/non-task-push.go
    • Line 1: warning: don't use MixedCaps in package name; goPushSdk should be gopushsdk (golint)
    • Line 12: warning: comment on exported function PushThroughMessageByPushId should be of the form "PushThroughMessageByPushId ..." (golint)
    • Line 30: warning: comment on exported function PushNotificationMessageByPushId should be of the form "PushNotificationMessageByPushId ..." (golint)
    • Line 46: warning: comment on exported function PushThroughMessageByAlias should be of the form "PushThroughMessageByAlias ..." (golint)
    • Line 62: warning: comment on exported function PushNotificationMessageByAlias should be of the form "PushNotificationMessageByAlias ..." (golint)
    • go-meizu-push-sdk/pushapi.go
    • Line 1: warning: don't use MixedCaps in package name; goPushSdk should be gopushsdk (golint)
    • Line 7: warning: comment on exported function Register should be of the form "Register ..." (golint)
    • go-meizu-push-sdk/registerservice.go
    • Line 1: warning: don't use MixedCaps in package name; goPushSdk should be gopushsdk (golint)
    • Line 22: warning: exported const APP_ID should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: comment on exported function GetRegisterSwitch should be of the form "GetRegisterSwitch ..." (golint)
    • Line 50: warning: comment on exported function ChangeRegisterSwitch should be of the form "ChangeRegisterSwitch ..." (golint)
    • Line 73: warning: comment on exported function ChangeAllSwitch should be of the form "ChangeAllSwitch ..." (golint)
    • Line 95: warning: comment on exported function SubscribeAlias should be of the form "SubscribeAlias ..." (golint)
    • Line 111: warning: comment on exported function UnSubscribeAlias should be of the form "UnSubscribeAlias ..." (golint)
    • Line 126: warning: comment on exported function GetSubAlias should be of the form "GetSubAlias ..." (golint)
    • Line 141: warning: comment on exported function SubscribeTags should be of the form "SubscribeTags ..." (golint)
    • Line 157: warning: comment on exported function UnSubscribeTags should be of the form "UnSubscribeTags ..." (golint)
    • Line 173: warning: comment on exported function GetSubTags should be of the form "GetSubTags ..." (golint)
    • Line 188: warning: comment on exported function UnSubAllTags should be of the form "UnSubAllTags ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell92%

Misspell Finds commonly misspelled English words