Last refresh: 4 years ago

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

- Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

- Line 35: warning: cyclomatic complexity 19 of function run() is high (> 15) (gocyclo)

- Line 32: warning: cyclomatic complexity 18 of function getStatus() is high (> 15) (gocyclo)

- Line 64: warning: cyclomatic complexity 23 of function copyRecursive() is high (> 15) (gocyclo)

- Line 556: warning: cyclomatic complexity 25 of function (*scheduler).BuildDependencyGraph() is high (> 15) (gocyclo)
- Line 664: warning: cyclomatic complexity 17 of function (*scheduler).fillDependencyGraph() is high (> 15) (gocyclo)

- Line 898: warning: cyclomatic complexity 23 of function TestCleanupResources() is high (> 15) (gocyclo)

- Line 188: warning: cyclomatic complexity 23 of function createResources() is high (> 15) (gocyclo)

- Line 27: warning: cyclomatic complexity 18 of function TestAllocateReplicas() is high (> 15) (gocyclo)

golint84%

Golint is a linter for Go source code.

- Line 27: warning: exported type AppsInterface should have comment or be unexported (golint)
- Line 37: warning: exported method AppsClient.PetSets should have comment or be unexported (golint)

- Line 55: warning: exported function Convert_v1alpha1_PetSetSpec_To_apps_PetSetSpec should have comment or be unexported (golint)
- Line 55: warning: don't use underscores in Go names; func Convert_v1alpha1_PetSetSpec_To_apps_PetSetSpec should be ConvertV1alpha1PetSetSpecToAppsPetSetSpec (golint)
- Line 86: warning: exported function Convert_apps_PetSetSpec_To_v1alpha1_PetSetSpec should have comment or be unexported (golint)
- Line 86: warning: don't use underscores in Go names; func Convert_apps_PetSetSpec_To_v1alpha1_PetSetSpec should be ConvertAppsPetSetSpecToV1alpha1PetSetSpec (golint)

- Line 31: warning: exported var OriginalGroupVersion should have comment or be unexported (golint)
- Line 34: warning: exported var SchemeBuilder should have comment or be unexported (golint)
- Line 55: warning: exported method PetSet.GetObjectKind should have comment or be unexported (golint)
- Line 56: warning: exported method PetSetList.GetObjectKind should have comment or be unexported (golint)

- Line 47: warning: exported function DeepCopy_v1alpha1_PetSet should have comment or be unexported (golint)
- Line 47: warning: don't use underscores in Go names; func DeepCopy_v1alpha1_PetSet should be DeepCopyV1alpha1PetSet (golint)
- Line 65: warning: exported function DeepCopy_v1alpha1_PetSetList should have comment or be unexported (golint)
- Line 65: warning: don't use underscores in Go names; func DeepCopy_v1alpha1_PetSetList should be DeepCopyV1alpha1PetSetList (golint)
- Line 86: warning: exported function DeepCopy_v1alpha1_PetSetSpec should have comment or be unexported (golint)
- Line 86: warning: don't use underscores in Go names; func DeepCopy_v1alpha1_PetSetSpec should be DeepCopyV1alpha1PetSetSpec (golint)
- Line 125: warning: exported function DeepCopy_v1alpha1_PetSetStatus should have comment or be unexported (golint)
- Line 125: warning: don't use underscores in Go names; func DeepCopy_v1alpha1_PetSetStatus should be DeepCopyV1alpha1PetSetStatus (golint)

- Line 31: warning: should not use dot imports (golint)
- Line 32: warning: should not use dot imports (golint)

- Line 26: warning: exported var SchemeBuilder should have comment or be unexported (golint)
- Line 35: warning: exported var OriginalGroupVersion should have comment or be unexported (golint)

- Line 47: warning: exported function DeepCopy_apps_PetSet should have comment or be unexported (golint)
- Line 47: warning: don't use underscores in Go names; func DeepCopy_apps_PetSet should be DeepCopyAppsPetSet (golint)
- Line 65: warning: exported function DeepCopy_apps_PetSetList should have comment or be unexported (golint)
- Line 65: warning: don't use underscores in Go names; func DeepCopy_apps_PetSetList should be DeepCopyAppsPetSetList (golint)
- Line 86: warning: exported function DeepCopy_apps_PetSetSpec should have comment or be unexported (golint)
- Line 86: warning: don't use underscores in Go names; func DeepCopy_apps_PetSetSpec should be DeepCopyAppsPetSetSpec (golint)
- Line 119: warning: exported function DeepCopy_apps_PetSetStatus should have comment or be unexported (golint)
- Line 119: warning: don't use underscores in Go names; func DeepCopy_apps_PetSetStatus should be DeepCopyAppsPetSetStatus (golint)

- Line 30: warning: don't use underscores in Go names; var map_PetSet should be mapPetSet (golint)
- Line 36: warning: exported method PetSet.SwaggerDoc should have comment or be unexported (golint)
- Line 40: warning: don't use underscores in Go names; var map_PetSetList should be mapPetSetList (golint)
- Line 44: warning: exported method PetSetList.SwaggerDoc should have comment or be unexported (golint)
- Line 48: warning: don't use underscores in Go names; var map_PetSetSpec should be mapPetSetSpec (golint)
- Line 57: warning: exported method PetSetSpec.SwaggerDoc should have comment or be unexported (golint)
- Line 61: warning: don't use underscores in Go names; var map_PetSetStatus should be mapPetSetStatus (golint)
- Line 67: warning: exported method PetSetStatus.SwaggerDoc should have comment or be unexported (golint)

- Line 19: warning: exported type PetSetExpansion should have comment or be unexported (golint)

- Line 30: warning: exported function SetDefaults_PetSet should have comment or be unexported (golint)
- Line 30: warning: don't use underscores in Go names; func SetDefaults_PetSet should be SetDefaultsPetSet (golint)

- Line 23: warning: should not use dot imports (golint)
- Line 24: warning: should not use dot imports (golint)

- Line 25: warning: exported type FakeApps should have comment or be unexported (golint)
- Line 29: warning: exported method FakeApps.PetSets should have comment or be unexported (golint)

- Line 36: warning: exported method FakePetSets.Create should have comment or be unexported (golint)
- Line 46: warning: exported method FakePetSets.Update should have comment or be unexported (golint)
- Line 56: warning: exported method FakePetSets.UpdateStatus should have comment or be unexported (golint)
- Line 66: warning: exported method FakePetSets.Delete should have comment or be unexported (golint)
- Line 73: warning: exported method FakePetSets.DeleteCollection should have comment or be unexported (golint)
- Line 80: warning: exported method FakePetSets.Get should have comment or be unexported (golint)
- Line 90: warning: exported method FakePetSets.List should have comment or be unexported (golint)

- Line 19: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

- Line 50: warning: don't use underscores in Go names; func autoConvert_v1alpha1_PetSet_To_apps_PetSet should be autoConvertV1alpha1PetSetToAppsPetSet (golint)
- Line 68: warning: exported function Convert_v1alpha1_PetSet_To_apps_PetSet should have comment or be unexported (golint)
- Line 68: warning: don't use underscores in Go names; func Convert_v1alpha1_PetSet_To_apps_PetSet should be ConvertV1alpha1PetSetToAppsPetSet (golint)
- Line 72: warning: don't use underscores in Go names; func autoConvert_apps_PetSet_To_v1alpha1_PetSet should be autoConvertAppsPetSetToV1alpha1PetSet (golint)
- Line 89: warning: exported function Convert_apps_PetSet_To_v1alpha1_PetSet should have comment or be unexported (golint)
- Line 89: warning: don't use underscores in Go names; func Convert_apps_PetSet_To_v1alpha1_PetSet should be ConvertAppsPetSetToV1alpha1PetSet (golint)
- Line 93: warning: don't use underscores in Go names; func autoConvert_v1alpha1_PetSetList_To_apps_PetSetList should be autoConvertV1alpha1PetSetListToAppsPetSetList (golint)
- Line 114: warning: exported function Convert_v1alpha1_PetSetList_To_apps_PetSetList should have comment or be unexported (golint)
- Line 114: warning: don't use underscores in Go names; func Convert_v1alpha1_PetSetList_To_apps_PetSetList should be ConvertV1alpha1PetSetListToAppsPetSetList (golint)
- Line 118: warning: don't use underscores in Go names; func autoConvert_apps_PetSetList_To_v1alpha1_PetSetList should be autoConvertAppsPetSetListToV1alpha1PetSetList (golint)
- Line 139: warning: exported function Convert_apps_PetSetList_To_v1alpha1_PetSetList should have comment or be unexported (golint)
- Line 139: warning: don't use underscores in Go names; func Convert_apps_PetSetList_To_v1alpha1_PetSetList should be ConvertAppsPetSetListToV1alpha1PetSetList (golint)
- Line 143: warning: don't use underscores in Go names; func autoConvert_v1alpha1_PetSetSpec_To_apps_PetSetSpec should be autoConvertV1alpha1PetSetSpecToAppsPetSetSpec (golint)
- Line 165: warning: don't use underscores in Go names; func autoConvert_apps_PetSetSpec_To_v1alpha1_PetSetSpec should be autoConvertAppsPetSetSpecToV1alpha1PetSetSpec (golint)
- Line 187: warning: don't use underscores in Go names; func autoConvert_v1alpha1_PetSetStatus_To_apps_PetSetStatus should be autoConvertV1alpha1PetSetStatusToAppsPetSetStatus (golint)
- Line 193: warning: exported function Convert_v1alpha1_PetSetStatus_To_apps_PetSetStatus should have comment or be unexported (golint)
- Line 193: warning: don't use underscores in Go names; func Convert_v1alpha1_PetSetStatus_To_apps_PetSetStatus should be ConvertV1alpha1PetSetStatusToAppsPetSetStatus (golint)
- Line 197: warning: don't use underscores in Go names; func autoConvert_apps_PetSetStatus_To_v1alpha1_PetSetStatus should be autoConvertAppsPetSetStatusToV1alpha1PetSetStatus (golint)
- Line 203: warning: exported function Convert_apps_PetSetStatus_To_v1alpha1_PetSetStatus should have comment or be unexported (golint)
- Line 203: warning: don't use underscores in Go names; func Convert_apps_PetSetStatus_To_v1alpha1_PetSetStatus should be ConvertAppsPetSetStatusToV1alpha1PetSetStatus (golint)

- Line 27: warning: should not use dot imports (golint)
- Line 28: warning: should not use dot imports (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

- Line 127: warning: ineffectual assignment to status (ineffassign)

- Line 701: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

- Line 293: warning: "reffered" is a misspelling of "referred" (misspell)

- Line 609: warning: "succeded" is a misspelling of "succeeded" (misspell)

- Line 113: warning: "unexpectadly" is a misspelling of "unexpectedly" (misspell)

Go Report Card

Preparing report...

Report for github.com/Mirantis/k8s-AppController