Preparing report...

Report for github.com/OpenLiberty/open-liberty-operator

A+    Excellent!    Found 16 issues across 44 files

Tweet

gofmt90%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo84%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint86%

Golint is a linter for Go source code.

    • open-liberty-operator/pkg/apis/openliberty/v1beta1/zz_generated.openapi.go
    • Line 12: warning: exported function GetOpenAPIDefinitions should have comment or be unexported (golint)
    • Line 42: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_GithubLogin should be schemaPkgApisOpenlibertyV1beta1GithubLogin (golint)
    • Line 61: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OAuth2Client should be schemaPkgApisOpenlibertyV1beta1OAuth2Client (golint)
    • Line 165: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OidcClient should be schemaPkgApisOpenlibertyV1beta1OidcClient (golint)
    • Line 239: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplication should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplication (golint)
    • Line 283: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationAffinity should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationAffinity (golint)
    • Line 345: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationAutoScaling should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationAutoScaling (golint)
    • Line 376: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationMonitoring should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationMonitoring (golint)
    • Line 422: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationRoute should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationRoute (golint)
    • Line 485: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationSSO should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationSSO (golint)
    • Line 552: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationService should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationService (golint)
    • Line 656: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationServiceability should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationServiceability (golint)
    • Line 687: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationSpec should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationSpec (golint)
    • Line 947: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationStatus should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationStatus (golint)
    • Line 1036: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyApplicationStorage should be schemaPkgApisOpenlibertyV1beta1OpenLibertyApplicationStorage (golint)
    • Line 1068: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyDump should be schemaPkgApisOpenlibertyV1beta1OpenLibertyDump (golint)
    • Line 1112: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyDumpSpec should be schemaPkgApisOpenlibertyV1beta1OpenLibertyDumpSpec (golint)
    • Line 1150: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyDumpStatus should be schemaPkgApisOpenlibertyV1beta1OpenLibertyDumpStatus (golint)
    • Line 1188: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyTrace should be schemaPkgApisOpenlibertyV1beta1OpenLibertyTrace (golint)
    • Line 1232: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyTraceSpec should be schemaPkgApisOpenlibertyV1beta1OpenLibertyTraceSpec (golint)
    • Line 1276: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OpenLibertyTraceStatus should be schemaPkgApisOpenlibertyV1beta1OpenLibertyTraceStatus (golint)
    • Line 1313: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OperatedResource should be schemaPkgApisOpenlibertyV1beta1OperatedResource (golint)
    • Line 1338: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_OperationStatusCondition should be schemaPkgApisOpenlibertyV1beta1OperationStatusCondition (golint)
    • Line 1387: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_ServiceBindingConsumes should be schemaPkgApisOpenlibertyV1beta1ServiceBindingConsumes (golint)
    • Line 1425: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_ServiceBindingProvides should be schemaPkgApisOpenlibertyV1beta1ServiceBindingProvides (golint)
    • Line 1464: warning: don't use underscores in Go names; func schema_pkg_apis_openliberty_v1beta1_StatusCondition should be schemaPkgApisOpenlibertyV1beta1StatusCondition (golint)
    • open-liberty-operator/test/util/util.go
    • Line 364: warning: exported function CheckEnvVarValue should have comment or be unexported (golint)
    • Line 542: warning: exported function CreateSecretForSSO should have comment or be unexported (golint)
    • Line 560: warning: exported function WaitForPodUpdates should have comment or be unexported (golint)
    • Line 594: warning: comment on exported function LogTestUpdates should be of the form "LogTestUpdates ..." (golint)
    • open-liberty-operator/pkg/utils/register.go
    • Line 17: warning: exported type RegisterData should have comment or be unexported (golint)
    • Line 31: warning: exported function RegisterWithOidcProvider should have comment or be unexported (golint)
    • Line 109: warning: don't use underscores in Go names; struct field Access_token should be AccessToken (golint)
    • Line 122: warning: don't use underscores in Go names; struct field Client_id should be ClientID (golint)
    • Line 123: warning: don't use underscores in Go names; struct field Client_secret should be ClientSecret (golint)
    • Line 205: warning: don't use underscores in Go names; struct field Registration_endpoint should be RegistrationEndpoint (golint)
    • Line 209: warning: don't use underscores in Go names; struct field Token_endpoint should be TokenEndpoint (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign90%

IneffAssign detects ineffectual assignments in Go code.


misspell93%

Misspell Finds commonly misspelled English words