gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• pkg/types/types_test.go
  • Line 144: warning: cyclomatic complexity 21 of function setProps() is high (> 15) (gocyclo)

• test/get.go
  • Line 39: warning: cyclomatic complexity 19 of function DescribeGetTestsfor() is high (> 15) (gocyclo)

• storage/postgres/query_builder.go
  • Line 291: warning: cyclomatic complexity 17 of function (*pgQuery).WithCriteria() is high (> 15) (gocyclo)

• storage/interceptors/broker_notifications_interceptor.go
  • Line 16: warning: cyclomatic complexity 16 of function NewBrokerNotificationsInterceptor() is high (> 15) (gocyclo)

• storage/interceptors/broker_update_catalog_interceptor.go
  • Line 73: warning: cyclomatic complexity 33 of function (*brokerUpdateCatalogInterceptor).OnTxUpdate() is high (> 15) (gocyclo)

• operations/scheduler.go
  • Line 250: warning: cyclomatic complexity 30 of function (*Scheduler).checkForConcurrentOperations() is high (> 15) (gocyclo)
  • Line 495: warning: cyclomatic complexity 20 of function (*Scheduler).handleActionResponseFailure() is high (> 15) (gocyclo)
  • Line 661: warning: cyclomatic complexity 16 of function (*Scheduler).executeOperationPreconditions() is high (> 15) (gocyclo)

• storage/interceptors/smaap_service_instance_interceptor.go
  • Line 127: warning: cyclomatic complexity 27 of function (*ServiceInstanceInterceptor).AroundTxCreate() is high (> 15) (gocyclo)
  • Line 260: warning: cyclomatic complexity 26 of function (*ServiceInstanceInterceptor).AroundTxUpdate() is high (> 15) (gocyclo)
  • Line 451: warning: cyclomatic complexity 24 of function (*ServiceInstanceInterceptor).deleteSingleInstance() is high (> 15) (gocyclo)
  • Line 561: warning: cyclomatic complexity 20 of function (*ServiceInstanceInterceptor).pollServiceInstance() is high (> 15) (gocyclo)

• api/base_controller.go
  • Line 247: warning: cyclomatic complexity 19 of function (*BaseController).DeleteSingleObject() is high (> 15) (gocyclo)

• pkg/types/service_plan.go
  • Line 49: warning: cyclomatic complexity 30 of function (*ServicePlan).Equals() is high (> 15) (gocyclo)

• api/filters/shared_instance_update_filter.go
  • Line 84: warning: cyclomatic complexity 17 of function (*sharedInstanceUpdateFilter).handleServiceUpdate() is high (> 15) (gocyclo)

• operations/maintainer.go
  • Line 418: warning: cyclomatic complexity 21 of function (*Maintainer).pollPendingCascadeOperations() is high (> 15) (gocyclo)

• api/common/sharing/utils.go
  • Line 135: warning: cyclomatic complexity 20 of function filterInstancesBySelectors() is high (> 15) (gocyclo)
  • Line 95: warning: cyclomatic complexity 17 of function validateParameters() is high (> 15) (gocyclo)

• test/delete.go
  • Line 31: warning: cyclomatic complexity 20 of function DescribeDeleteTestsfor() is high (> 15) (gocyclo)

• storage/interceptors/smaap_service_binding_interceptor.go
  • Line 99: warning: cyclomatic complexity 35 of function (*ServiceBindingInterceptor).AroundTxCreate() is high (> 15) (gocyclo)
  • Line 554: warning: cyclomatic complexity 22 of function (*ServiceBindingInterceptor).pollServiceBinding() is high (> 15) (gocyclo)
  • Line 345: warning: cyclomatic complexity 18 of function (*ServiceBindingInterceptor).deleteSingleBinding() is high (> 15) (gocyclo)

• api/osb/osb_store_plugin.go
  • Line 613: warning: cyclomatic complexity 31 of function (*storePlugin).PollInstance() is high (> 15) (gocyclo)
  • Line 528: warning: cyclomatic complexity 23 of function (*storePlugin).PollBinding() is high (> 15) (gocyclo)

• test/list.go
  • Line 54: warning: cyclomatic complexity 30 of function DescribeListTestsFor() is high (> 15) (gocyclo)

• test/delete_list.go
  • Line 42: warning: cyclomatic complexity 24 of function DescribeDeleteListFor() is high (> 15) (gocyclo)

• pkg/query/selection.go
  • Line 150: warning: cyclomatic complexity 22 of function (Criterion).Validate() is high (> 15) (gocyclo)

• pkg/util/errors.go
  • Line 246: warning: cyclomatic complexity 20 of function HandleInstanceSharingError() is high (> 15) (gocyclo)

• test/common/operation.go
  • Line 107: warning: cyclomatic complexity 19 of function VerifyOperationExists() is high (> 15) (gocyclo)

• storage/interceptors/notifications_interceptor.go
  • Line 79: warning: cyclomatic complexity 18 of function (*NotificationsInterceptor).OnTxUpdate() is high (> 15) (gocyclo)

golint49%

Golint is a linter for Go source code.

• storage/interceptors/visibility_notifications_interceptor.go
  • Line 13: warning: exported function NewVisibilityNotificationsInterceptor should have comment or be unexported (golint)
  • Line 143: warning: exported type VisibilityAdditional should have comment or be unexported (golint)
  • Line 149: warning: exported method VisibilityAdditional.Validate should have comment or be unexported (golint)
  • Line 163: warning: exported type VisibilityCreateNotificationsInterceptorProvider should have comment or be unexported (golint)
  • Line 166: warning: exported method VisibilityCreateNotificationsInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 170: warning: exported method VisibilityCreateNotificationsInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 174: warning: exported type VisibilityUpdateNotificationsInterceptorProvider should have comment or be unexported (golint)
  • Line 177: warning: exported method VisibilityUpdateNotificationsInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 181: warning: exported method VisibilityUpdateNotificationsInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 185: warning: exported type VisibilityDeleteNotificationsInterceptorProvider should have comment or be unexported (golint)
  • Line 188: warning: exported method VisibilityDeleteNotificationsInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 192: warning: exported method VisibilityDeleteNotificationsInterceptorProvider.Provide should have comment or be unexported (golint)

• api/agents.go
  • Line 11: warning: exported type AgentsController should have comment or be unexported (golint)
  • Line 15: warning: exported function NewAgentsController should have comment or be unexported (golint)
  • Line 20: warning: exported method AgentsController.GetSupportedVersions should have comment or be unexported (golint)
  • Line 36: warning: exported method AgentsController.Routes should have comment or be unexported (golint)

• api/filters/brokers_filter_by_visibility.go
  • Line 15: warning: exported const BrokersVisibilityFilterName should have comment or be unexported (golint)
  • Line 17: warning: exported function NewBrokersFilterByVisibility should have comment or be unexported (golint)
  • Line 26: warning: exported type BrokersFilterByVisibility should have comment or be unexported (golint)
  • Line 78: warning: exported method BrokersFilterByVisibility.FilterMatchers should have comment or be unexported (golint)
  • Line 89: warning: exported method BrokersFilterByVisibility.Name should have comment or be unexported (golint)

• api/osb/check_instance_visibility_plugin.go
  • Line 15: warning: exported const CheckVisibilityPluginName should have comment or be unexported (golint)

• test/tls_settings/settings.go
  • Line 1: warning: package comment should be of the form "Package tls_settings ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 16: warning: don't use an underscore in package name (golint)
  • Line 19: warning: exported var SMRootCaCertificate should have comment or be unexported (golint)

• pkg/types/service_binding.go
  • Line 30: warning: comment on exported type ServiceBinding should be of the form "ServiceBinding ..." (with optional leading article) (golint)
  • Line 49: warning: exported method ServiceBinding.Encrypt should have comment or be unexported (golint)
  • Line 53: warning: exported method ServiceBinding.Decrypt should have comment or be unexported (golint)
  • Line 57: warning: exported method ServiceBinding.IntegralData should have comment or be unexported (golint)
  • Line 61: warning: exported method ServiceBinding.SetIntegrity should have comment or be unexported (golint)
  • Line 65: warning: exported method ServiceBinding.GetIntegrity should have comment or be unexported (golint)
  • Line 81: warning: exported method ServiceBinding.Equals should have comment or be unexported (golint)

• storage/interceptors/broker_delete_catalog_interceptor.go
  • Line 11: warning: exported const BrokerDeleteCatalogInterceptorName should have comment or be unexported (golint)
  • Line 18: warning: exported method BrokerDeleteCatalogInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 24: warning: exported method BrokerDeleteCatalogInterceptorProvider.Name should have comment or be unexported (golint)

• api/osb/osb.go
  • Line 29: warning: exported const InstanceIDPathParam should have comment (or a comment on this block) or be unexported (golint)

• api/osb/platform_termination_plugin.go
  • Line 14: warning: exported const PlatformTerminationPluginName should have comment or be unexported (golint)

• cmd/smgen/api_type_template.go
  • Line 19: warning: exported const ApiTypeTemplate should have comment or be unexported (golint)

• cmd/smgen/storage_type.go
  • Line 27: warning: exported const StorageTypesDirectory should have comment or be unexported (golint)
  • Line 29: warning: exported type StorageType should have comment or be unexported (golint)
  • Line 44: warning: exported function GenerateStorageEntityFile should have comment or be unexported (golint)

• cmd/smgen/storage_type_template.go
  • Line 19: warning: exported const StorageTypeTemplate should have comment or be unexported (golint)

• api/notifications/notifications.go
  • Line 23: warning: exported const LastKnownRevisionHeader should have comment (or a comment on this block) or be unexported (golint)

• api/service_plan_controller.go
  • Line 33: warning: exported function NewServicePlanController should have comment or be unexported (golint)
  • Line 41: warning: exported method ServicePlanController.Routes should have comment or be unexported (golint)

• api/filters/check_instance_visibility_filter.go
  • Line 33: warning: exported const ServiceInstanceVisibilityFilterName should have comment or be unexported (golint)

• test/service_instance_and_binding_test/context_signature/suit_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• storage/interceptors/operations_create_interceptor.go
  • Line 28: warning: exported const OperationsCreateInterceptorName should have comment or be unexported (golint)
  • Line 30: warning: exported type OperationsCreateInsterceptorProvider should have comment or be unexported (golint)
  • Line 34: warning: exported method OperationsCreateInsterceptorProvider.Name should have comment or be unexported (golint)
  • Line 38: warning: exported method OperationsCreateInsterceptorProvider.Provide should have comment or be unexported (golint)

• storage/postgres/base_entity.go
  • Line 26: warning: exported type BaseEntity should have comment or be unexported (golint)
  • Line 34: warning: exported method BaseEntity.GetID should have comment or be unexported (golint)
  • Line 38: warning: exported type BaseLabelEntity should have comment or be unexported (golint)
  • Line 46: warning: exported method BaseLabelEntity.GetKey should have comment or be unexported (golint)
  • Line 50: warning: exported method BaseLabelEntity.GetValue should have comment or be unexported (golint)
  • Line 54: warning: exported method BaseLabelEntity.LabelsPrimaryColumn should have comment or be unexported (golint)

• api/filters/tenant_filter.go
  • Line 10: warning: comment on exported const LabelName should be of the form "LabelName ..." (golint)

• pkg/security/http/authz/oauth_scopes.go
  • Line 13: warning: exported function NewScopesAuthorizer should have comment or be unexported (golint)
  • Line 34: warning: exported function PrefixScopes should have comment or be unexported (golint)
  • Line 57: warning: comment on exported function HasScope should be of the form "HasScope ..." (golint)

• storage/postgres/operation.go
  • Line 54: warning: exported method Operation.ToObject should have comment or be unexported (golint)
  • Line 96: warning: exported method Operation.FromObject should have comment or be unexported (golint)

• test/common/common.go
  • Line 55: warning: should not use dot imports (golint)
  • Line 58: warning: exported type Object should have comment or be unexported (golint)
  • Line 59: warning: exported type Array should have comment or be unexported (golint)
  • Line 69: warning: exported type FakeServer should have comment or be unexported (golint)
  • Line 74: warning: exported type FlagValue should have comment or be unexported (golint)
  • Line 78: warning: exported method FlagValue.Set should have comment or be unexported (golint)
  • Line 86: warning: exported function RemoveNonNumericOrDateArgs should have comment or be unexported (golint)
  • Line 90: warning: exported function RemoveNumericAndDateArgs should have comment or be unexported (golint)
  • Line 94: warning: exported function RemoveBooleanArgs should have comment or be unexported (golint)
  • Line 98: warning: exported function RemoveNonJSONArgs should have comment or be unexported (golint)
  • Line 167: warning: exported function RemoveNotNullableFieldAndLabels should have comment or be unexported (golint)
  • Line 181: warning: exported function CopyLabels should have comment or be unexported (golint)
  • Line 186: warning: exported function CopyFields should have comment or be unexported (golint)
  • Line 192: warning: exported function CopyObject should have comment or be unexported (golint)
  • Line 212: warning: exported function MapContains should have comment or be unexported (golint)
  • Line 227: warning: exported function RemoveResourceByCriterion should have comment or be unexported (golint)
  • Line 241: warning: exported function RemoveAllOperations should have comment or be unexported (golint)
  • Line 245: warning: exported function RemoveAllNotifications should have comment or be unexported (golint)
  • Line 249: warning: exported function RemoveAllInstances should have comment or be unexported (golint)
  • Line 271: warning: exported function RemoveAllBindings should have comment or be unexported (golint)
  • Line 294: warning: exported function RemoveAllBrokers should have comment or be unexported (golint)
  • Line 298: warning: exported function RemoveAllPlatforms should have comment or be unexported (golint)
  • Line 302: warning: exported function RemoveAllVisibilities should have comment or be unexported (golint)
  • Line 326: warning: exported function RegisterBrokerInSM should have comment or be unexported (golint)
  • Line 332: warning: exported function RegisterVisibilityForPlanAndPlatform should have comment or be unexported (golint)
  • Line 340: warning: exported function CreateVisibilitiesForAllBrokerPlans should have comment or be unexported (golint)
  • Line 353: warning: exported function RegisterPlatformInSMQuery should have comment or be unexported (golint)
  • Line 364: warning: exported function RegisterPlatformInSM should have comment or be unexported (golint)
  • Line 407: warning: exported function ExtractResourceIDs should have comment or be unexported (golint)
  • Line 451: warning: exported function MakePlatform should have comment or be unexported (golint)
  • Line 460: warning: exported function GenerateRandomNotification should have comment or be unexported (golint)
  • Line 477: warning: exported function GenerateRandomPlatform should have comment or be unexported (golint)
  • Line 490: warning: exported function GenerateRandomBroker should have comment or be unexported (golint)
  • Line 516: warning: exported function Print should have comment or be unexported (golint)
  • Line 528: warning: exported type HTTPReaction should have comment or be unexported (golint)
  • Line 534: warning: exported type HTTPExpectations should have comment or be unexported (golint)
  • Line 541: warning: exported type NopCloser should have comment or be unexported (golint)
  • Line 545: warning: exported method NopCloser.Close should have comment or be unexported (golint)
  • Line 547: warning: exported function Closer should have comment or be unexported (golint)
  • Line 591: warning: exported function DoHTTPWithClient should have comment or be unexported (golint)
  • Line 597: warning: exported function DoHTTP should have comment or be unexported (golint)
  • Line 603: warning: exported type HTTPCouple should have comment or be unexported (golint)
  • Line 608: warning: exported function DoHTTPSequence should have comment or be unexported (golint)
  • Line 617: warning: exported function ExtractTenantFunc should have comment or be unexported (golint)

• pkg/multitenancy/settings.go
  • Line 5: warning: exported type Settings should have comment or be unexported (golint)
  • Line 9: warning: exported function DefaultSettings should have comment or be unexported (golint)

• operations/maintainer.go
  • Line 34: warning: exported const ZeroTime should have comment (or a comment on this block) or be unexported (golint)
  • Line 197: warning: exported method Maintainer.PollUpdateCascadeOperations should have comment or be unexported (golint)
  • Line 245: warning: comment on exported method Maintainer.CleanupFinishedCascadeOperations should be of the form "CleanupFinishedCascadeOperations ..." (golint)
  • Line 315: warning: exported method Maintainer.CleanupResourcelessOperations should have comment or be unexported (golint)

• api/osb/check_platform_id_plugin.go
  • Line 14: warning: exported const CheckPlatformIDPluginName should have comment or be unexported (golint)

• pkg/web/plugin.go
  • Line 97: warning: exported type CredentialsAdapter should have comment or be unexported (golint)

• test/delete_list.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)
  • Line 42: warning: exported function DescribeDeleteListFor should have comment or be unexported (golint)

• test/common/service_instance.go
  • Line 14: warning: should not use dot imports (golint)
  • Line 17: warning: exported function CreateInstanceInPlatform should have comment or be unexported (golint)
  • Line 22: warning: exported function CreateInstanceInPlatformForPlan should have comment or be unexported (golint)
  • Line 66: warning: exported function CreateReferenceInstanceInPlatform should have comment or be unexported (golint)
  • Line 110: warning: exported function DeleteInstance should have comment or be unexported (golint)

• pkg/types/base.go
  • Line 21: warning: exported type Base should have comment or be unexported (golint)
  • Line 32: warning: exported method Base.SetID should have comment or be unexported (golint)
  • Line 36: warning: exported method Base.GetID should have comment or be unexported (golint)
  • Line 40: warning: exported method Base.SetCreatedAt should have comment or be unexported (golint)
  • Line 44: warning: exported method Base.GetCreatedAt should have comment or be unexported (golint)
  • Line 48: warning: exported method Base.SetUpdatedAt should have comment or be unexported (golint)
  • Line 52: warning: exported method Base.GetUpdatedAt should have comment or be unexported (golint)
  • Line 56: warning: exported method Base.SetLabels should have comment or be unexported (golint)
  • Line 60: warning: exported method Base.GetLabels should have comment or be unexported (golint)
  • Line 64: warning: exported method Base.GetPagingSequence should have comment or be unexported (golint)
  • Line 68: warning: exported method Base.SetReady should have comment or be unexported (golint)
  • Line 72: warning: exported method Base.GetReady should have comment or be unexported (golint)
  • Line 76: warning: exported method Base.SetLastOperation should have comment or be unexported (golint)
  • Line 80: warning: exported method Base.GetLastOperation should have comment or be unexported (golint)

• pkg/types/service_plan.go
  • Line 28: warning: comment on exported type ServicePlan should be of the form "ServicePlan ..." (with optional leading article) (golint)
  • Line 49: warning: exported method ServicePlan.Equals should have comment or be unexported (golint)

• test/patch.go
  • Line 12: warning: should not use dot imports (golint)
  • Line 15: warning: should not use dot imports (golint)
  • Line 18: warning: exported function DescribePatchTestsFor should have comment or be unexported (golint)

• storage/interceptors_create.go
  • Line 52: warning: comment on exported type CreateOnTxInterceptorProvider should be of the form "CreateOnTxInterceptorProvider ..." (with optional leading article) (golint)
  • Line 58: warning: exported type OrderedCreateOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 63: warning: comment on exported type CreateAroundTxInterceptorProvider should be of the form "CreateAroundTxInterceptorProvider ..." (with optional leading article) (golint)
  • Line 69: warning: exported type OrderedCreateAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 81: warning: exported type OrderedCreateInterceptorProvider should have comment or be unexported (golint)
  • Line 86: warning: exported type CreateAroundTxInterceptorChain should have comment or be unexported (golint)
  • Line 101: warning: exported type CreateOnTxInterceptorChain should have comment or be unexported (golint)

• storage/postgres/service_offering.go
  • Line 28: warning: comment on exported type ServiceOffering should be of the form "ServiceOffering ..." (with optional leading article) (golint)
  • Line 51: warning: exported method ServiceOffering.ToObject should have comment or be unexported (golint)
  • Line 86: warning: exported method ServiceOffering.FromObject should have comment or be unexported (golint)

• test/common/operation.go
  • Line 32: warning: should not use dot imports (golint)
  • Line 33: warning: should not use dot imports (golint)
  • Line 36: warning: exported type OperationExpectations should have comment or be unexported (golint)
  • Line 45: warning: exported type ResourceExpectations should have comment or be unexported (golint)
  • Line 51: warning: exported function VerifyResource should have comment or be unexported (golint)
  • Line 60: warning: exported function VerifyResourceExists should have comment or be unexported (golint)
  • Line 87: warning: exported function VerifyResourceDoesNotExist should have comment or be unexported (golint)
  • Line 107: warning: exported function VerifyOperationExists should have comment or be unexported (golint)
  • Line 190: warning: exported type TransitiveResourcesExpectation should have comment or be unexported (golint)
  • Line 196: warning: exported function AssertTransitiveResources should have comment or be unexported (golint)

• pkg/health/types.go
  • Line 37: warning: exported const MonitoredPlatformsHealthIndicatorName should have comment or be unexported (golint)
  • Line 127: warning: exported type StatusListener should have comment or be unexported (golint)
  • Line 129: warning: exported method StatusListener.HealthCheckFailed should have comment or be unexported (golint)
  • Line 138: warning: exported method StatusListener.HealthCheckRecovered should have comment or be unexported (golint)

• pkg/query/operators.go
  • Line 28: warning: comment on exported const ContainsOperator should be of the form "ContainsOperator ..." (golint)
  • Line 47: warning: exported const NoOperator should have comment (or a comment on this block) or be unexported (golint)

• operations/scheduler.go
  • Line 68: warning: comment on exported method Scheduler.ScheduleStorageAction should be of the form "ScheduleStorageAction ..." (golint)

• api/filters/services_filter_by_visibility.go
  • Line 15: warning: exported const ServicesVisibilityFilterName should have comment or be unexported (golint)
  • Line 17: warning: exported function NewServicesFilterByVisibility should have comment or be unexported (golint)
  • Line 26: warning: exported type ServicesFilterByVisibility should have comment or be unexported (golint)
  • Line 60: warning: exported method ServicesFilterByVisibility.FilterMatchers should have comment or be unexported (golint)
  • Line 71: warning: exported method ServicesFilterByVisibility.Name should have comment or be unexported (golint)

• api/filters/technical_platform_filter.go
  • Line 16: warning: exported const TechnicalPlatformFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: comment on exported type TechnicalPlatformFilter should be of the form "TechnicalPlatformFilter ..." (with optional leading article) (golint)
  • Line 25: warning: exported method TechnicalPlatformFilter.Name should have comment or be unexported (golint)
  • Line 29: warning: exported method TechnicalPlatformFilter.Run should have comment or be unexported (golint)
  • Line 73: warning: exported method TechnicalPlatformFilter.FilterMatchers should have comment or be unexported (golint)

• storage/interceptors/broker_notifications_interceptor.go
  • Line 16: warning: exported function NewBrokerNotificationsInterceptor should have comment or be unexported (golint)
  • Line 104: warning: exported type BrokerAdditional should have comment or be unexported (golint)
  • Line 108: warning: exported method BrokerAdditional.Validate should have comment or be unexported (golint)
  • Line 117: warning: exported const BrokerCreateNotificationInterceptorName should have comment (or a comment on this block) or be unexported (golint)
  • Line 122: warning: exported type BrokerNotificationsCreateInterceptorProvider should have comment or be unexported (golint)
  • Line 127: warning: exported method BrokerNotificationsCreateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 131: warning: exported method BrokerNotificationsCreateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 135: warning: exported type BrokerNotificationsUpdateInterceptorProvider should have comment or be unexported (golint)
  • Line 140: warning: exported method BrokerNotificationsUpdateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 144: warning: exported method BrokerNotificationsUpdateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 148: warning: exported type BrokerNotificationsDeleteInterceptorProvider should have comment or be unexported (golint)
  • Line 153: warning: exported method BrokerNotificationsDeleteInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 157: warning: exported method BrokerNotificationsDeleteInterceptorProvider.Provide should have comment or be unexported (golint)

• storage/postgres/query_builder.go
  • Line 17: warning: exported const PrimaryKeyColumn should have comment or be unexported (golint)
  • Line 19: warning: exported const CountQueryTemplate should have comment or be unexported (golint)
  • Line 30: warning: exported const CountLabelValuesQueryTemplate should have comment or be unexported (golint)
  • Line 39: warning: exported const SelectQueryTemplate should have comment or be unexported (golint)
  • Line 69: warning: exported const SelectNoLabelsQueryTemplate should have comment or be unexported (golint)
  • Line 90: warning: exported const DeleteQueryTemplate should have comment or be unexported (golint)

• pkg/types/cascade/service_broker_cascade.go
  • Line 17: warning: package comment should be of the form "Package cascade ..." (golint)
  • Line 25: warning: exported type ServiceBrokerCascade should have comment or be unexported (golint)
  • Line 29: warning: exported method ServiceBrokerCascade.GetChildrenCriterion should have comment or be unexported (golint)

• test/test.go
  • Line 42: warning: should not use dot imports (golint)
  • Line 45: warning: should not use dot imports (golint)
  • Line 48: warning: exported type Op should have comment or be unexported (golint)
  • Line 50: warning: exported type ResponseMode should have comment or be unexported (golint)
  • Line 53: warning: exported const Get should have comment (or a comment on this block) or be unexported (golint)
  • Line 63: warning: exported type MultitenancySettings should have comment or be unexported (golint)
  • Line 72: warning: exported type TestCase should have comment or be unexported (golint)
  • Line 103: warning: exported function APIResourcePatch should have comment or be unexported (golint)
  • Line 131: warning: exported function StorageResourcePatch should have comment or be unexported (golint)
  • Line 144: warning: exported function EnsurePublicPlanVisibility should have comment or be unexported (golint)
  • Line 148: warning: exported function EnsurePublicPlanVisibilityForPlatform should have comment or be unexported (golint)
  • Line 152: warning: exported function EnsurePlanVisibilityDoesNotExist should have comment or be unexported (golint)
  • Line 172: warning: exported function EnsurePlanVisibility should have comment or be unexported (golint)
  • Line 202: warning: exported function DescribeTestsFor should have comment or be unexported (golint)
  • Line 282: warning: exported function RegisterBrokerPlatformCredentialsExpect should have comment or be unexported (golint)
  • Line 286: warning: exported function RegisterBrokerPlatformCredentials should have comment or be unexported (golint)
  • Line 290: warning: exported function RegisterBrokerPlatformCredentialsWithNotificationID should have comment or be unexported (golint)
  • Line 294: warning: exported function RegisterBrokerPlatformCredentialsWithNotificationIDExpect should have comment or be unexported (golint)
  • Line 307: warning: exported function RegisterBrokerPlatformCredentialsWithNotificationIDNoActivateExpect should have comment or be unexported (golint)

• storage/postgres/interfaces.go
  • Line 29: warning: exported type PostgresEntity should have comment or be unexported (golint)
  • Line 36: warning: exported type PostgresLabel should have comment or be unexported (golint)
  • Line 43: warning: exported type EntityLabelRowCreator should have comment or be unexported (golint)
  • Line 45: warning: exported type EntityLabelRow should have comment or be unexported (golint)

• api/healthcheck/monitored_platforms_indicator.go
  • Line 11: warning: exported function NewMonitoredPlatformsIndicator should have comment or be unexported (golint)

• api/filters/shared_instance_update_filter.go
  • Line 30: warning: exported const SharedInstanceUpdateFilterName should have comment or be unexported (golint)
  • Line 37: warning: exported function NewSharedInstanceUpdateFilter should have comment or be unexported (golint)

• storage/service_plans/resolver.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported function ResolveSupportedPlatformIDsForPlans should have comment or be unexported (golint)
  • Line 24: warning: exported function ResolveSupportedPlatformsForTenant should have comment or be unexported (golint)
  • Line 47: warning: exported function ResolveSupportedPlatformsForPlans should have comment or be unexported (golint)

• api/osb/check_instance_owner_plugin.go
  • Line 16: warning: exported const CheckInstanceOwnerhipPluginName should have comment or be unexported (golint)

• storage/sub_query.go
  • Line 5: warning: exported type SubQuery should have comment or be unexported (golint)
  • Line 8: warning: exported const QueryForAllLastOperationsPerResource should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type SubQueryParams should have comment or be unexported (golint)
  • Line 56: warning: exported function GetSubQuery should have comment or be unexported (golint)
  • Line 60: warning: exported function GetSubQueryWithParams should have comment or be unexported (golint)

• test/common/catalog.go
  • Line 243: warning: exported type SBCatalog should have comment or be unexported (golint)
  • Line 245: warning: exported method SBCatalog.AddService should have comment or be unexported (golint)
  • Line 254: warning: exported method SBCatalog.AddPlanToService should have comment or be unexported (golint)
  • Line 263: warning: exported method SBCatalog.RemoveService should have comment or be unexported (golint)
  • Line 275: warning: exported method SBCatalog.RemovePlan should have comment or be unexported (golint)
  • Line 314: warning: comment on exported function NewShareableCatalog should be of the form "NewShareableCatalog ..." (golint)
  • Line 336: warning: exported function GenerateTestServiceWithPlansWithID should have comment or be unexported (golint)
  • Line 358: warning: exported function GenerateTestServiceWithPlansWithIDNonBindable should have comment or be unexported (golint)
  • Line 380: warning: exported function GenerateTestServiceWithPlans should have comment or be unexported (golint)
  • Line 389: warning: exported function GenerateTestServiceWithPlansNonBindable should have comment or be unexported (golint)
  • Line 399: warning: exported function GenerateTestPlanWithID should have comment or be unexported (golint)
  • Line 402: warning: exported function GenerateShareableTestPlanWithID should have comment or be unexported (golint)
  • Line 406: warning: exported function GenerateTestPlan should have comment or be unexported (golint)
  • Line 415: warning: exported function GenerateFreeTestPlan should have comment or be unexported (golint)
  • Line 422: warning: exported function GenerateShareableFreeTestPlan should have comment or be unexported (golint)
  • Line 429: warning: exported function GenerateShareablePaidTestPlan should have comment or be unexported (golint)
  • Line 437: warning: exported function GenerateShareableNonBindablePlan should have comment or be unexported (golint)
  • Line 445: warning: exported function GeneratePaidTestPlan should have comment or be unexported (golint)
  • Line 453: warning: exported function GenerateTestPlanFromTemplate should have comment or be unexported (golint)

• storage/postgres/notificator.go
  • Line 44: warning: exported type Notificator should have comment or be unexported (golint)
  • Line 152: warning: exported method Notificator.RegisterConsumer should have comment or be unexported (golint)
  • Line 255: warning: exported method Notificator.UnregisterConsumer should have comment or be unexported (golint)
  • Line 299: warning: context.Context should be the first parameter of a function (golint)
  • Line 336: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• storage/postgres/service_binding.go
  • Line 45: warning: exported method ServiceBinding.ToObject should have comment or be unexported (golint)
  • Line 68: warning: exported method ServiceBinding.FromObject should have comment or be unexported (golint)

• api/notifications/ws_connection.go
  • Line 18: warning: exported const MaxPingPeriodHeader should have comment (or a comment on this block) or be unexported (golint)

• api/service_offering_controller.go
  • Line 33: warning: exported function NewServiceOfferingController should have comment or be unexported (golint)
  • Line 40: warning: exported method ServiceOfferingController.Routes should have comment or be unexported (golint)

• api/filters/checkBrokerCredentials.go
  • Line 15: warning: exported const CheckBrokerCredentialsFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported method CheckBrokerCredentialsFilter.Name should have comment or be unexported (golint)
  • Line 28: warning: exported method CheckBrokerCredentialsFilter.Run should have comment or be unexported (golint)
  • Line 58: warning: exported method CheckBrokerCredentialsFilter.FilterMatchers should have comment or be unexported (golint)

• api/filters/check_instance_transfer_filter.go
  • Line 33: warning: exported const ServiceInstanceTransferFilterName should have comment or be unexported (golint)
  • Line 40: warning: exported function NewServiceInstanceTransferFilter should have comment or be unexported (golint)

• api/filters/context_timeout_filter.go
  • Line 41: warning: exported function NewContextTimeoutFilter should have comment or be unexported (golint)

• pkg/web/routes.go
  • Line 48: warning: exported const ParametersURL should have comment (or a comment on this block) or be unexported (golint)

• pkg/types/platform.go
  • Line 30: warning: exported const CFPlatformType should have comment or be unexported (golint)
  • Line 31: warning: exported const K8sPlatformType should have comment or be unexported (golint)
  • Line 32: warning: exported const SMPlatform should have comment or be unexported (golint)
  • Line 33: warning: exported const Monitored should have comment or be unexported (golint)
  • Line 37: warning: comment on exported function GetSMSupportedPlatformTypes should be of the form "GetSMSupportedPlatformTypes ..." (golint)
  • Line 42: warning: exported function SetSMSupportedPlatformTypes should have comment or be unexported (golint)
  • Line 46: warning: comment on exported type Platform should be of the form "Platform ..." (with optional leading article) (golint)
  • Line 66: warning: exported method Platform.Equals should have comment or be unexported (golint)
  • Line 85: warning: exported method Platform.Sanitize should have comment or be unexported (golint)
  • Line 94: warning: exported method Platform.Encrypt should have comment or be unexported (golint)
  • Line 101: warning: exported method Platform.Decrypt should have comment or be unexported (golint)
  • Line 135: warning: exported method Platform.IntegralData should have comment or be unexported (golint)
  • Line 150: warning: exported method Platform.SetIntegrity should have comment or be unexported (golint)
  • Line 154: warning: exported method Platform.GetIntegrity should have comment or be unexported (golint)

• pkg/types/service_broker.go
  • Line 35: warning: comment on exported type ServiceBroker should be of the form "ServiceBroker ..." (with optional leading article) (golint)
  • Line 49: warning: exported method ServiceBroker.GetTLSConfig should have comment or be unexported (golint)
  • Line 71: warning: exported method ServiceBroker.Sanitize should have comment or be unexported (golint)
  • Line 75: warning: exported method ServiceBroker.Encrypt should have comment or be unexported (golint)
  • Line 79: warning: exported method ServiceBroker.Decrypt should have comment or be unexported (golint)
  • Line 83: warning: exported method ServiceBroker.IntegralData should have comment or be unexported (golint)
  • Line 98: warning: exported method ServiceBroker.SetIntegrity should have comment or be unexported (golint)
  • Line 102: warning: exported method ServiceBroker.GetIntegrity should have comment or be unexported (golint)
  • Line 146: warning: exported method ServiceBroker.Equals should have comment or be unexported (golint)

• pkg/client/broker_client.go
  • Line 1: warning: package comment should be of the form "Package client ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 29: warning: exported type BrokerClient should have comment or be unexported (golint)
  • Line 35: warning: context.Context should be the first parameter of a function (golint)
  • Line 35: warning: exported function NewBrokerClient should have comment or be unexported (golint)
  • Line 77: warning: exported method BrokerClient.SendRequest should have comment or be unexported (golint)

• api/service_binding_controller.go
  • Line 41: warning: exported function NewServiceBindingController should have comment or be unexported (golint)
  • Line 50: warning: exported method ServiceBindingController.Routes should have comment or be unexported (golint)
  • Line 96: warning: exported method ServiceBindingController.GetParameters should have comment or be unexported (golint)

• api/filters/service_binding_strip_filter.go
  • Line 27: warning: exported const ServiceBindingStripFilterName should have comment or be unexported (golint)
  • Line 37: warning: exported method ServiceBindingStripFilter.Name should have comment or be unexported (golint)
  • Line 41: warning: exported method ServiceBindingStripFilter.Run should have comment or be unexported (golint)
  • Line 58: warning: exported method ServiceBindingStripFilter.FilterMatchers should have comment or be unexported (golint)

• pkg/types/cascade/tenant_cascade.go
  • Line 8: warning: exported type TenantCascade should have comment or be unexported (golint)
  • Line 12: warning: exported method TenantCascade.CleanDuplicates should have comment or be unexported (golint)
  • Line 53: warning: exported method TenantCascade.GetChildrenCriterion should have comment or be unexported (golint)

• storage/postgres/notification_connection/connection.go
  • Line 17: warning: don't use an underscore in package name (golint)

• pkg/util/state_context.go
  • Line 17: warning: exported method StateContext.Value should have comment or be unexported (golint)
  • Line 21: warning: exported method StateContext.Deadline should have comment or be unexported (golint)
  • Line 25: warning: exported method StateContext.Done should have comment or be unexported (golint)
  • Line 29: warning: exported method StateContext.Err should have comment or be unexported (golint)

• storage/interceptors/secured_generate_credentials_interceptor.go
  • Line 34: warning: exported type GeneratePlatformCredentialsInterceptorProvider should have comment or be unexported (golint)
  • Line 37: warning: exported type RegeneratePlatformCredentialsInterceptorProvider should have comment or be unexported (golint)
  • Line 40: warning: exported method GeneratePlatformCredentialsInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 44: warning: exported method GeneratePlatformCredentialsInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 48: warning: exported method RegeneratePlatformCredentialsInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 52: warning: exported method RegeneratePlatformCredentialsInterceptorProvider.Name should have comment or be unexported (golint)

• api/osb/utils.go
  • Line 14: warning: context.Context should be the first parameter of a function (golint)
  • Line 14: warning: exported function Get should have comment or be unexported (golint)

• test/common/oauth_tls_server.go
  • Line 34: warning: exported type OAuthTLSServer should have comment or be unexported (golint)
  • Line 45: warning: exported function NewOAuthTLSServer should have comment or be unexported (golint)
  • Line 79: warning: exported method OAuthTLSServer.Close should have comment or be unexported (golint)
  • Line 86: warning: exported method OAuthTLSServer.URL should have comment or be unexported (golint)
  • Line 90: warning: exported method OAuthTLSServer.TokenKeysRequestCallCount should have comment or be unexported (golint)
  • Line 102: warning: exported method OAuthTLSServer.RotateTokenKey should have comment or be unexported (golint)
  • Line 117: warning: exported method OAuthTLSServer.CreateToken should have comment or be unexported (golint)

• api/tenant_controller.go
  • Line 11: warning: exported type TenantController should have comment or be unexported (golint)
  • Line 15: warning: exported function NewTenantController should have comment or be unexported (golint)
  • Line 19: warning: exported method TenantController.GetOperation should have comment or be unexported (golint)
  • Line 23: warning: exported method TenantController.Routes should have comment or be unexported (golint)

• pkg/util/credentials.go
  • Line 1: warning: package comment should be of the form "Package util ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• pkg/types/service_plan_utils.go
  • Line 25: warning: comment on exported method ServicePlan.SupportsPlatformType should be of the form "SupportsPlatformType ..." (golint)
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• storage/named_query.go
  • Line 3: warning: exported type NamedQuery should have comment or be unexported (golint)
  • Line 6: warning: exported const QueryByMissingLabel should have comment (or a comment on this block) or be unexported (golint)
  • Line 106: warning: exported function GetNamedQuery should have comment or be unexported (golint)

• storage/utils.go
  • Line 13: warning: context.Context should be the first parameter of a function (golint)
  • Line 13: warning: exported function GetServiceOfferingAndPlanByServiceInstanceId should have comment or be unexported (golint)
  • Line 37: warning: exported function GetObjectByField should have comment or be unexported (golint)
  • Line 55: warning: exported function IsReferencePlan should have comment or be unexported (golint)
  • Line 66: warning: exported function GetInstanceReferencesByID should have comment or be unexported (golint)

• api/filters/disabled_query_parameters.go
  • Line 26: warning: exported const DisabledQueryParametersName should have comment or be unexported (golint)
  • Line 28: warning: exported type DisabledQueryParametersFilter should have comment or be unexported (golint)
  • Line 32: warning: exported method DisabledQueryParametersFilter.Name should have comment or be unexported (golint)
  • Line 36: warning: exported method DisabledQueryParametersFilter.Run should have comment or be unexported (golint)
  • Line 51: warning: exported method DisabledQueryParametersFilter.FilterMatchers should have comment or be unexported (golint)

• api/filters/regenerate_platform_credentials_filter.go
  • Line 9: warning: exported const RegeneratePlatformCredentialsFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported method RegeneratePlatformCredentialsFilter.Name should have comment or be unexported (golint)
  • Line 21: warning: exported method RegeneratePlatformCredentialsFilter.Run should have comment or be unexported (golint)
  • Line 31: warning: exported method RegeneratePlatformCredentialsFilter.FilterMatchers should have comment or be unexported (golint)

• api/filters/supported_encodings_filter.go
  • Line 24: warning: exported const SupportedEncodingsFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type SupportedEncodingsFilter should have comment or be unexported (golint)
  • Line 30: warning: exported method SupportedEncodingsFilter.Name should have comment or be unexported (golint)
  • Line 34: warning: comment on exported method SupportedEncodingsFilter.Run should be of the form "Run ..." (golint)
  • Line 40: warning: exported method SupportedEncodingsFilter.FilterMatchers should have comment or be unexported (golint)

• pkg/httpclient/settings.go
  • Line 31: warning: exported type Settings should have comment or be unexported (golint)
  • Line 102: warning: exported function GetHttpClientGlobalSettings should have comment or be unexported (golint)
  • Line 106: warning: exported function SetHTTPClientGlobalSettings should have comment or be unexported (golint)
  • Line 110: warning: comment on exported function Configure should be of the form "Configure ..." (golint)
  • Line 117: warning: exported function ConfigureTransport should have comment or be unexported (golint)

• api/osb/osb_store_plugin.go
  • Line 53: warning: exported const PreserveInstanceKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 59: warning: exported const READY should have comment (or a comment on this block) or be unexported (golint)
  • Line 720: warning: don't use underscores in Go names; method parameter operation_id should be operationID (golint)
  • Line 1037: warning: exported function ExtractPlatformFromContext should have comment or be unexported (golint)
  • Line 1059: warning: exported function DeleteSignatureField should have comment or be unexported (golint)

• storage/integrity_repository.go
  • Line 159: warning: exported method TransactionalIntegrityRepository.InTransaction should have comment or be unexported (golint)

• pkg/agents/agents_version.go
  • Line 8: warning: exported type Settings should have comment or be unexported (golint)
  • Line 12: warning: exported function DefaultSettings should have comment or be unexported (golint)
  • Line 18: warning: exported method Settings.Validate should have comment or be unexported (golint)

• operations/opcontext/context.go
  • Line 29: warning: exported function Get should have comment or be unexported (golint)
  • Line 37: warning: exported function Set should have comment or be unexported (golint)

• api/filters/force_delete_validation_filter.go
  • Line 11: warning: exported const ForceDeleteFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: exported type ForceDeleteValidationFilter should have comment or be unexported (golint)
  • Line 19: warning: exported method ForceDeleteValidationFilter.Name should have comment or be unexported (golint)
  • Line 22: warning: exported method ForceDeleteValidationFilter.FilterMatchers should have comment or be unexported (golint)
  • Line 31: warning: exported method ForceDeleteValidationFilter.Run should have comment or be unexported (golint)

• pkg/web/context_keys.go
  • Line 28: warning: exported function ContextWithSMAAPOperatedFlag should have comment or be unexported (golint)
  • Line 32: warning: exported function IsGeneratePlatformCredentialsRequired should have comment or be unexported (golint)
  • Line 37: warning: exported function ContextWithGeneratePlatformCredentialsFlag should have comment or be unexported (golint)
  • Line 47: warning: comment on exported function ContextWithStoreBindingsFlag should be of the form "ContextWithStoreBindingsFlag ..." (golint)
  • Line 94: warning: exported function ContextWithAuthenticationError should have comment or be unexported (golint)
  • Line 98: warning: exported function AuthenticationErrorFromContext should have comment or be unexported (golint)
  • Line 103: warning: exported function ContextWithAuthorizationError should have comment or be unexported (golint)
  • Line 111: warning: exported function AuthorizationErrorFromContext should have comment or be unexported (golint)

• pkg/types/service_offering.go
  • Line 27: warning: comment on exported type ServiceOffering should be of the form "ServiceOffering ..." (with optional leading article) (golint)
  • Line 51: warning: exported method ServiceOffering.Equals should have comment or be unexported (golint)

• storage/postgres/storage.go
  • Line 38: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 40: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 48: warning: exported type Storage should have comment or be unexported (golint)
  • Line 60: warning: exported method Storage.Introduce should have comment or be unexported (golint)
  • Line 64: warning: exported method Storage.SelectContext should have comment or be unexported (golint)
  • Line 69: warning: exported method Storage.Open should have comment or be unexported (golint)
  • Line 139: warning: exported method Storage.Close should have comment or be unexported (golint)
  • Line 173: warning: exported method Storage.PingContext should have comment or be unexported (golint)
  • Line 178: warning: exported method Storage.Create should have comment or be unexported (golint)
  • Line 315: warning: exported method Storage.Get should have comment or be unexported (golint)
  • Line 326: warning: exported method Storage.QueryForList should have comment or be unexported (golint)
  • Line 348: warning: exported method Storage.GetForUpdate should have comment or be unexported (golint)
  • Line 359: warning: exported method Storage.List should have comment or be unexported (golint)
  • Line 363: warning: exported method Storage.ListNoLabels should have comment or be unexported (golint)
  • Line 399: warning: exported method Storage.Count should have comment or be unexported (golint)
  • Line 407: warning: exported method Storage.CountLabelValues should have comment or be unexported (golint)
  • Line 415: warning: exported method Storage.DeleteReturning should have comment or be unexported (golint)
  • Line 447: warning: exported method Storage.Delete should have comment or be unexported (golint)
  • Line 471: warning: exported method Storage.Update should have comment or be unexported (golint)
  • Line 492: warning: exported method Storage.UpdateLabels should have comment or be unexported (golint)
  • Line 496: warning: exported method Storage.GetEntities should have comment or be unexported (golint)
  • Line 532: warning: exported method Storage.InTransaction should have comment or be unexported (golint)

• pkg/types/cascade/platform_cascade.go
  • Line 17: warning: package comment should be of the form "Package cascade ..." (golint)
  • Line 25: warning: exported type PlatformCascade should have comment or be unexported (golint)
  • Line 29: warning: exported method PlatformCascade.GetChildrenCriterion should have comment or be unexported (golint)

• pkg/types/labels.go
  • Line 28: warning: exported method Labels.Validate should have comment or be unexported (golint)
  • Line 69: warning: exported method LabelChange.Validate should have comment or be unexported (golint)
  • Line 79: warning: exported type LabelChanges should have comment or be unexported (golint)
  • Line 81: warning: exported method LabelChanges.Validate should have comment or be unexported (golint)

• test/common/service_binding.go
  • Line 15: warning: exported function DeleteBinding should have comment or be unexported (golint)

• cmd/smgen/api_type.go
  • Line 27: warning: exported const APITypesDirectory should have comment or be unexported (golint)
  • Line 29: warning: exported type ApiType should have comment or be unexported (golint)
  • Line 38: warning: exported function GenerateApiTypeFile should have comment or be unexported (golint)

• pkg/security/http/authz/base_authorizer.go
  • Line 14: warning: exported function NewBaseAuthorizer should have comment or be unexported (golint)

• api/osb/instance_sharing_plugin.go
  • Line 18: warning: exported const InstanceSharingPluginName should have comment or be unexported (golint)
  • Line 21: warning: exported type OperationCategory should have comment or be unexported (golint)

• pkg/sm/security_builder.go
  • Line 181: warning: comment on exported method SecurityBuilder.WithClientIDSuffixes should be of the form "WithClientIDSuffixes ..." (golint)
  • Line 269: warning: comment on exported method SecurityBuilder.Build should be of the form "Build ..." (golint)

• pkg/types/notification.go
  • Line 44: warning: comment on exported type Notification should be of the form "Notification ..." (with optional leading article) (golint)
  • Line 56: warning: exported method Notification.Equals should have comment or be unexported (golint)
  • Line 75: warning: receiver name n should be consistent with previous receiver name e for Notification (golint)

• storage/interceptors/smaap_service_binding_interceptor.go
  • Line 43: warning: exported const ServiceBindingCreateInterceptorProviderName should have comment or be unexported (golint)
  • Line 57: warning: exported method ServiceBindingCreateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 67: warning: exported method ServiceBindingCreateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 67: warning: receiver name c should be consistent with previous receiver name p for ServiceBindingCreateInterceptorProvider (golint)
  • Line 71: warning: exported const ServiceBindingDeleteInterceptorProviderName should have comment or be unexported (golint)
  • Line 78: warning: exported method ServiceBindingDeleteInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 87: warning: exported method ServiceBindingDeleteInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 87: warning: receiver name c should be consistent with previous receiver name p for ServiceBindingDeleteInterceptorProvider (golint)
  • Line 91: warning: exported type ServiceBindingInterceptor should have comment or be unexported (golint)
  • Line 99: warning: exported method ServiceBindingInterceptor.AroundTxCreate should have comment or be unexported (golint)
  • Line 282: warning: exported method ServiceBindingInterceptor.AroundTxDelete should have comment or be unexported (golint)

• pkg/types/credentials.go
  • Line 33: warning: exported type TLS should have comment or be unexported (golint)
  • Line 133: warning: exported method Credentials.CertificateExists should have comment or be unexported (golint)
  • Line 136: warning: exported method Credentials.TLSExists should have comment or be unexported (golint)
  • Line 140: warning: exported method Credentials.BasicExists should have comment or be unexported (golint)

• pkg/types/virtual_types.go
  • Line 8: warning: exported const TenantType should have comment or be unexported (golint)
  • Line 10: warning: exported type VirtualType should have comment or be unexported (golint)
  • Line 14: warning: exported method VirtualType.Validate should have comment or be unexported (golint)
  • Line 21: warning: exported method VirtualType.Equals should have comment or be unexported (golint)
  • Line 25: warning: exported type Tenant should have comment or be unexported (golint)
  • Line 30: warning: exported method Tenant.GetType should have comment or be unexported (golint)
  • Line 34: warning: exported function NewTenant should have comment or be unexported (golint)
  • Line 45: warning: exported function IsVirtualType should have comment or be unexported (golint)

• pkg/client/broker_transport.go
  • Line 1: warning: package comment should be of the form "Package client ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 25: warning: exported function GetTransportWithTLS should have comment or be unexported (golint)

• api/base_controller.go
  • Line 378: warning: exported function GetResourceOperation should have comment or be unexported (golint)

• api/filters/platform_termination_filter.go
  • Line 32: warning: exported const PlatformTerminationFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported function NewPlatformTerminationFilter should have comment or be unexported (golint)

• api/filters/rate_limiter_filter.go
  • Line 17: warning: exported type RateLimiterFilter should have comment or be unexported (golint)
  • Line 25: warning: exported type RateLimiterMiddleware should have comment or be unexported (golint)
  • Line 30: warning: exported function NewRateLimiterMiddleware should have comment or be unexported (golint)
  • Line 37: warning: exported function NewRateLimiterFilter should have comment or be unexported (golint)
  • Line 47: warning: context.Context should be the first parameter of a function (golint)
  • Line 84: warning: exported method RateLimiterFilter.Name should have comment or be unexported (golint)
  • Line 97: warning: exported method RateLimiterFilter.Run should have comment or be unexported (golint)
  • Line 138: warning: exported method RateLimiterFilter.FilterMatchers should have comment or be unexported (golint)

• pkg/security/filters/authentication.go
  • Line 26: warning: exported const AuthenticationFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported function NewAuthenticationFilter should have comment or be unexported (golint)
  • Line 39: warning: exported type AuthenticationFilter should have comment or be unexported (golint)
  • Line 46: warning: exported method AuthenticationFilter.Name should have comment or be unexported (golint)
  • Line 50: warning: exported method AuthenticationFilter.FilterMatchers should have comment or be unexported (golint)

• pkg/types/broker_platform_credential.go
  • Line 1: warning: package comment should be of the form "Package types ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 26: warning: comment on exported type BrokerPlatformCredential should be of the form "BrokerPlatformCredential ..." (with optional leading article) (golint)
  • Line 45: warning: exported method BrokerPlatformCredential.Encrypt should have comment or be unexported (golint)
  • Line 49: warning: exported method BrokerPlatformCredential.Decrypt should have comment or be unexported (golint)
  • Line 70: warning: exported method BrokerPlatformCredential.IntegralData should have comment or be unexported (golint)
  • Line 74: warning: exported method BrokerPlatformCredential.SetIntegrity should have comment or be unexported (golint)
  • Line 78: warning: exported method BrokerPlatformCredential.GetIntegrity should have comment or be unexported (golint)
  • Line 82: warning: exported method BrokerPlatformCredential.Equals should have comment or be unexported (golint)

• storage/encrypting_repository.go
  • Line 221: warning: receiver name cr should be consistent with previous receiver name er for encryptingRepository (golint)

• storage/interceptors_delete.go
  • Line 38: warning: comment on exported type DeleteOnTxInterceptorProvider should be of the form "DeleteOnTxInterceptorProvider ..." (with optional leading article) (golint)
  • Line 44: warning: exported type OrderedDeleteOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type DeleteAroundTxInterceptorProvider should be of the form "DeleteAroundTxInterceptorProvider ..." (with optional leading article) (golint)
  • Line 55: warning: exported type OrderedDeleteAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 67: warning: exported type OrderedDeleteInterceptorProvider should have comment or be unexported (golint)
  • Line 72: warning: exported type DeleteAroundTxInterceptorChain should have comment or be unexported (golint)
  • Line 87: warning: exported type DeleteOnTxInterceptorChain should have comment or be unexported (golint)

• test/service_instance_and_binding_test/context_signature/context_signature_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• storage/interceptors/smaap_cascade_operation_create_interceptor.go
  • Line 29: warning: exported const CascadeOperationCreateInterceptorProviderName should have comment or be unexported (golint)
  • Line 34: warning: exported type CascadeOperationCreateInterceptorProvider should have comment or be unexported (golint)
  • Line 37: warning: exported method CascadeOperationCreateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 41: warning: exported method CascadeOperationCreateInterceptorProvider.Name should have comment or be unexported (golint)

• storage/postgres/broker.go
  • Line 46: warning: exported method Broker.ToObject should have comment or be unexported (golint)
  • Line 93: warning: exported method Broker.FromObject should have comment or be unexported (golint)

• api/filters/labeling_filter.go
  • Line 19: warning: exported const LabelCriteriaFilterNameSuffix should have comment or be unexported (golint)
  • Line 20: warning: exported const ResourceLabelingFilterNameSuffix should have comment or be unexported (golint)

• pkg/web/filter.go
  • Line 43: warning: exported method Request.SetResponseWriter should have comment or be unexported (golint)
  • Line 47: warning: exported method Request.IsResponseWriterHijacked should have comment or be unexported (golint)
  • Line 51: warning: exported method Request.HijackResponseWriter should have comment or be unexported (golint)
  • Line 190: warning: exported function Matching should have comment or be unexported (golint)

• test/get.go
  • Line 33: warning: should not use dot imports (golint)
  • Line 36: warning: should not use dot imports (golint)
  • Line 39: warning: exported function DescribeGetTestsfor should have comment or be unexported (golint)

• storage/postgres/platform.go
  • Line 29: warning: comment on exported type Platform should be of the form "Platform ..." (with optional leading article) (golint)
  • Line 49: warning: exported method Platform.FromObject should have comment or be unexported (golint)
  • Line 93: warning: exported method Platform.ToObject should have comment or be unexported (golint)

• test/common/context_signature.go
  • Line 18: warning: should not use dot imports (golint)
  • Line 19: warning: should not use dot imports (golint)
  • Line 26: warning: exported var CFContext should have comment or be unexported (golint)
  • Line 43: warning: exported function GetVerifyContextHandlerFunc should have comment or be unexported (golint)
  • Line 92: warning: exported function VerifySignatureNotPersisted should have comment or be unexported (golint)
  • Line 108: warning: exported function GetOsbProvisionFunc should have comment or be unexported (golint)
  • Line 118: warning: exported function GetSMAAPProvisionInstanceFunc should have comment or be unexported (golint)
  • Line 135: warning: exported function OsbBind should have comment or be unexported (golint)
  • Line 142: warning: exported function SmaapBind should have comment or be unexported (golint)
  • Line 157: warning: exported function ProvisionInstanceAndVerifySignature should have comment or be unexported (golint)

• test/common/service_instance_sharing.go
  • Line 15: warning: exported function GetInstanceObjectByID should have comment or be unexported (golint)
  • Line 25: warning: exported function ShareInstance should have comment or be unexported (golint)
  • Line 40: warning: exported function ShareInstanceOnDB should have comment or be unexported (golint)
  • Line 58: warning: exported function GetReferencePlanOfExistingPlan should have comment or be unexported (golint)
  • Line 73: warning: exported function GetPlanByKey should have comment or be unexported (golint)
  • Line 79: warning: exported function CreateReferenceInstance should have comment or be unexported (golint)
  • Line 114: warning: exported function CreateBindingByInstanceID should have comment or be unexported (golint)

• api/filters/patch_labels_only.go
  • Line 26: warning: exported const PatchOnlyLabelsFilterName should have comment or be unexported (golint)
  • Line 32: warning: exported method PatchOnlyLabelsFilter.Name should have comment or be unexported (golint)
  • Line 36: warning: exported method PatchOnlyLabelsFilter.Run should have comment or be unexported (golint)
  • Line 50: warning: exported method PatchOnlyLabelsFilter.FilterMatchers should have comment or be unexported (golint)

• api/filters/platform_id_instance_validation_filter.go
  • Line 33: warning: exported const PlatformIDInstanceValidationFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: exported method PlatformIDInstanceValidationFilter.Name should have comment or be unexported (golint)
  • Line 46: warning: exported method PlatformIDInstanceValidationFilter.Run should have comment or be unexported (golint)
  • Line 85: warning: exported method PlatformIDInstanceValidationFilter.FilterMatchers should have comment or be unexported (golint)

• pkg/auth/util/util.go
  • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 80: warning: exported function ConvertBackSlashN should have comment or be unexported (golint)

• storage/interceptors_update.go
  • Line 52: warning: comment on exported type UpdateOnTxInterceptorProvider should be of the form "UpdateOnTxInterceptorProvider ..." (with optional leading article) (golint)
  • Line 58: warning: exported type OrderedUpdateOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 63: warning: comment on exported type UpdateAroundTxInterceptorProvider should be of the form "UpdateAroundTxInterceptorProvider ..." (with optional leading article) (golint)
  • Line 69: warning: exported type OrderedUpdateAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 81: warning: exported type OrderedUpdateInterceptorProvider should have comment or be unexported (golint)
  • Line 86: warning: exported type UpdateAroundTxInterceptorChain should have comment or be unexported (golint)
  • Line 101: warning: exported type UpdateOnTxInterceptorChain should have comment or be unexported (golint)

• storage/interceptors/smaap_service_instance_interceptor.go
  • Line 47: warning: exported const ServiceInstanceCreateInterceptorProviderName should have comment (or a comment on this block) or be unexported (golint)
  • Line 51: warning: exported type BaseSMAAPInterceptorProvider should have comment or be unexported (golint)
  • Line 64: warning: exported method ServiceInstanceCreateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 74: warning: exported method ServiceInstanceCreateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 74: warning: receiver name c should be consistent with previous receiver name p for ServiceInstanceCreateInterceptorProvider (golint)
  • Line 78: warning: exported const ServiceInstanceUpdateInterceptorProviderName should have comment or be unexported (golint)
  • Line 85: warning: exported method ServiceInstanceUpdateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 95: warning: exported method ServiceInstanceUpdateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 95: warning: receiver name c should be consistent with previous receiver name p for ServiceInstanceUpdateInterceptorProvider (golint)
  • Line 99: warning: exported const ServiceInstanceDeleteInterceptorProviderName should have comment or be unexported (golint)
  • Line 106: warning: exported method ServiceInstanceDeleteInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 115: warning: exported method ServiceInstanceDeleteInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 115: warning: receiver name c should be consistent with previous receiver name p for ServiceInstanceDeleteInterceptorProvider (golint)
  • Line 119: warning: exported type ServiceInstanceInterceptor should have comment or be unexported (golint)
  • Line 127: warning: exported method ServiceInstanceInterceptor.AroundTxCreate should have comment or be unexported (golint)
  • Line 260: warning: exported method ServiceInstanceInterceptor.AroundTxUpdate should have comment or be unexported (golint)
  • Line 405: warning: exported method ServiceInstanceInterceptor.AroundTxDelete should have comment or be unexported (golint)

• storage/postgres/broker_platform_credential.go
  • Line 44: warning: exported method BrokerPlatformCredential.ToObject should have comment or be unexported (golint)
  • Line 65: warning: exported method BrokerPlatformCredential.FromObject should have comment or be unexported (golint)

• api/filters/check_platform_suspended_filter.go
  • Line 27: warning: exported const CheckPlatformSuspendedFilterName should have comment or be unexported (golint)
  • Line 29: warning: comment on exported type CheckPlatformSuspendedFilter should be of the form "CheckPlatformSuspendedFilter ..." (with optional leading article) (golint)
  • Line 33: warning: exported method CheckPlatformSuspendedFilter.Name should have comment or be unexported (golint)
  • Line 37: warning: exported method CheckPlatformSuspendedFilter.Run should have comment or be unexported (golint)
  • Line 57: warning: exported method CheckPlatformSuspendedFilter.FilterMatchers should have comment or be unexported (golint)

• schemas/predefined_plans.go
  • Line 12: warning: exported function BuildReferencePlanSchema should have comment or be unexported (golint)
  • Line 116: warning: exported function CreatePlanOutOfSchema should have comment or be unexported (golint)

• api/osb/context_signature_plugin.go
  • Line 20: warning: exported const ContextSignaturePluginName should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type ContextSignaturePlugin should have comment or be unexported (golint)
  • Line 28: warning: exported type ContextSigner should have comment or be unexported (golint)
  • Line 33: warning: exported function NewCtxSignaturePlugin should have comment or be unexported (golint)
  • Line 39: warning: exported method ContextSignaturePlugin.Name should have comment or be unexported (golint)
  • Line 43: warning: exported method ContextSignaturePlugin.Provision should have comment or be unexported (golint)
  • Line 47: warning: exported method ContextSignaturePlugin.Bind should have comment or be unexported (golint)
  • Line 51: warning: exported method ContextSignaturePlugin.UpdateService should have comment or be unexported (golint)
  • Line 95: warning: exported method ContextSigner.Sign should have comment or be unexported (golint)

• storage/interceptors/smaap_virtual_resource_cascade_operation_create_interceptor.go
  • Line 28: warning: exported const VirtualResourceCascadeOperationCreateInterceptorProviderName should have comment or be unexported (golint)
  • Line 30: warning: exported type VirtualResourceCascadeOperationCreateInterceptor should have comment or be unexported (golint)
  • Line 34: warning: exported type VirtualResourceCascadeOperationCreateInterceptorProvider should have comment or be unexported (golint)
  • Line 38: warning: exported method VirtualResourceCascadeOperationCreateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 44: warning: exported method VirtualResourceCascadeOperationCreateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 48: warning: exported method VirtualResourceCascadeOperationCreateInterceptor.OnTxCreate should have comment or be unexported (golint)

• storage/postgres/notification.go
  • Line 40: warning: exported method Notification.ToObject should have comment or be unexported (golint)
  • Line 58: warning: exported method Notification.FromObject should have comment or be unexported (golint)

• pkg/env/env.go
  • Line 120: warning: exported method ViperEnv.AllSettings should have comment or be unexported (golint)

• api/healthcheck/helper.go
  • Line 8: warning: exported function CheckPlatformsState should have comment or be unexported (golint)

• pkg/sm/sm.go
  • Line 58: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 388: warning: exported method ServiceManagerBuilder.RegisterNotificationReceiversFilter should have comment or be unexported (golint)
  • Line 392: warning: exported method ServiceManagerBuilder.RegisterExtension should have comment or be unexported (golint)
  • Line 399: warning: exported method ServiceManagerBuilder.WithCreateAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 416: warning: exported method ServiceManagerBuilder.WithCreateOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 433: warning: exported method ServiceManagerBuilder.WithCreateInterceptorProvider should have comment or be unexported (golint)
  • Line 450: warning: exported method ServiceManagerBuilder.WithUpdateAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 467: warning: exported method ServiceManagerBuilder.WithUpdateOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 484: warning: exported method ServiceManagerBuilder.WithUpdateInterceptorProvider should have comment or be unexported (golint)
  • Line 501: warning: exported method ServiceManagerBuilder.WithDeleteAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 518: warning: exported method ServiceManagerBuilder.WithDeleteOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 535: warning: exported method ServiceManagerBuilder.WithDeleteInterceptorProvider should have comment or be unexported (golint)
  • Line 628: warning: exported function DefaultGetVisibilityMetadataFunc should have comment or be unexported (golint)

• pkg/util/template.go
  • Line 1: warning: package comment should be of the form "Package util ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 23: warning: comment on exported function Tsprintf should be of the form "Tsprintf ..." (golint)

• pkg/types/operartion_utils.go
  • Line 3: warning: exported method Operation.IsAsyncResponse should have comment or be unexported (golint)
  • Line 7: warning: exported method Operation.GetUserInfo should have comment or be unexported (golint)

• storage/registry.go
  • Line 29: warning: exported function InitializeWithSafeTermination should have comment or be unexported (golint)

• pkg/security/filters/authz.go
  • Line 10: warning: exported const AuthorizationFilterName should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type AuthorizationFilter should have comment or be unexported (golint)
  • Line 30: warning: exported method AuthorizationFilter.Name should have comment or be unexported (golint)

• pkg/types/interfaces.go
  • Line 68: warning: exported function Equals should have comment or be unexported (golint)
  • Line 84: warning: exported function ObjectListIDsToStringArray should have comment or be unexported (golint)
  • Line 105: warning: exported function NewObjectArray should have comment or be unexported (golint)
  • Line 109: warning: exported method ObjectArray.Add should have comment or be unexported (golint)
  • Line 113: warning: exported method ObjectArray.ItemAt should have comment or be unexported (golint)
  • Line 117: warning: exported method ObjectArray.Len should have comment or be unexported (golint)

• storage/postgres/service_plan.go
  • Line 28: warning: comment on exported type ServicePlan should be of the form "ServicePlan ..." (with optional leading article) (golint)
  • Line 48: warning: exported method ServicePlan.ToObject should have comment or be unexported (golint)
  • Line 72: warning: exported method ServicePlan.FromObject should have comment or be unexported (golint)
  • Line 82: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• storage/postgres/where_clause_tree.go
  • Line 29: warning: exported const AND should have comment (or a comment on this block) or be unexported (golint)
  • Line 129: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• test/common/broker.go
  • Line 36: warning: exported type BrokerServer should have comment or be unexported (golint)
  • Line 68: warning: exported method BrokerServer.URL should have comment or be unexported (golint)
  • Line 72: warning: exported function JSONToMap should have comment or be unexported (golint)
  • Line 80: warning: exported function NewBrokerServer should have comment or be unexported (golint)
  • Line 84: warning: exported function NewBrokerServerMTLS should have comment or be unexported (golint)
  • Line 87: warning: exported function NewBrokerServerWithCatalog should have comment or be unexported (golint)
  • Line 98: warning: exported function NewBrokerServerWithTLSAndCatalog should have comment or be unexported (golint)
  • Line 129: warning: exported method BrokerServer.ShouldRecordRequests should have comment or be unexported (golint)
  • Line 136: warning: exported method BrokerServer.Reset should have comment or be unexported (golint)
  • Line 142: warning: exported method BrokerServer.ResetProperties should have comment or be unexported (golint)
  • Line 153: warning: exported method BrokerServer.ResetHandlers should have comment or be unexported (golint)
  • Line 164: warning: exported method BrokerServer.ResetCallHistory should have comment or be unexported (golint)
  • Line 253: warning: exported method BrokerServer.ServiceInstanceHandlerFunc should have comment or be unexported (golint)
  • Line 268: warning: exported method BrokerServer.ServiceInstanceLastOpHandlerFunc should have comment or be unexported (golint)
  • Line 287: warning: exported method BrokerServer.BindingHandlerFunc should have comment or be unexported (golint)
  • Line 302: warning: exported method BrokerServer.BindingLastOpHandlerFunc should have comment or be unexported (golint)
  • Line 433: warning: exported function SetResponse should have comment or be unexported (golint)
  • Line 441: warning: exported function DelayingHandler should have comment or be unexported (golint)
  • Line 453: warning: exported function ParameterizedHandler should have comment or be unexported (golint)
  • Line 459: warning: exported function MultiplePollsRequiredHandler should have comment or be unexported (golint)
  • Line 465: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 471: warning: exported function MultipleErrorsBeforeSuccessHandler should have comment or be unexported (golint)
  • Line 477: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• pkg/instance_sharing/types.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 4: warning: exported const ReferencePlanDescription should have comment (or a comment on this block) or be unexported (golint)

• api/api.go
  • Line 97: warning: exported type Options should have comment or be unexported (golint)

• api/rate_limiter.go
  • Line 21: warning: exported type RateLimiterConfiguration should have comment or be unexported (golint)

• api/filters/service_instance_strip_filter.go
  • Line 30: warning: exported const ServiceInstanceStripFilterName should have comment or be unexported (golint)
  • Line 40: warning: exported method ServiceInstanceStripFilter.Name should have comment or be unexported (golint)
  • Line 44: warning: exported method ServiceInstanceStripFilter.Run should have comment or be unexported (golint)
  • Line 61: warning: exported method ServiceInstanceStripFilter.FilterMatchers should have comment or be unexported (golint)

• storage/interceptors/notifications_interceptor.go
  • Line 22: warning: exported type Payload should have comment or be unexported (golint)
  • Line 28: warning: exported type ObjectPayload should have comment or be unexported (golint)
  • Line 35: warning: exported type NotificationsInterceptor should have comment or be unexported (golint)
  • Line 41: warning: exported method NotificationsInterceptor.OnTxCreate should have comment or be unexported (golint)
  • Line 79: warning: exported method NotificationsInterceptor.OnTxUpdate should have comment or be unexported (golint)
  • Line 186: warning: exported method NotificationsInterceptor.OnTxDelete should have comment or be unexported (golint)
  • Line 230: warning: exported function CreateNotification should have comment or be unexported (golint)

• storage/postgres/service_instance.go
  • Line 45: warning: exported method ServiceInstance.ToObject should have comment or be unexported (golint)
  • Line 75: warning: exported method ServiceInstance.FromObject should have comment or be unexported (golint)

• api/filters/plans_filter_by_visibility.go
  • Line 16: warning: exported const PlanVisibilityFilterName should have comment or be unexported (golint)
  • Line 18: warning: exported function NewPlansFilterByVisibility should have comment or be unexported (golint)
  • Line 27: warning: exported type PlanFilterByVisibility should have comment or be unexported (golint)
  • Line 49: warning: exported method PlanFilterByVisibility.FilterMatchers should have comment or be unexported (golint)
  • Line 60: warning: exported method PlanFilterByVisibility.Name should have comment or be unexported (golint)

• api/filters/reference_instance_filter.go
  • Line 34: warning: exported const ReferenceInstanceFilterName should have comment or be unexported (golint)
  • Line 42: warning: exported function NewReferenceInstanceFilter should have comment or be unexported (golint)

• pkg/types/cascade/interface.go
  • Line 16: warning: exported type ChildrenCriterion should have comment or be unexported (golint)
  • Line 18: warning: exported type CascadeChildren should have comment or be unexported (golint)
  • Line 20: warning: comment on exported type ParentInstanceLabelKeys should be of the form "ParentInstanceLabelKeys ..." (with optional leading article) (golint)
  • Line 23: warning: exported type Cascade should have comment or be unexported (golint)
  • Line 27: warning: exported type DuplicatesCleaner should have comment or be unexported (golint)
  • Line 31: warning: exported type CascadedOperations should have comment or be unexported (golint)
  • Line 40: warning: exported type Error should have comment or be unexported (golint)
  • Line 48: warning: exported type CascadeErrors should have comment or be unexported (golint)
  • Line 52: warning: exported method CascadeErrors.Add should have comment or be unexported (golint)
  • Line 56: warning: exported function GetCascadeObject should have comment or be unexported (golint)

• pkg/types/cascade/service_instance_cascade.go
  • Line 17: warning: package comment should be of the form "Package cascade ..." (golint)
  • Line 28: warning: exported type ServiceInstanceCascade should have comment or be unexported (golint)
  • Line 35: warning: exported method ServiceInstanceCascade.GetChildrenCriterion should have comment or be unexported (golint)

• storage/interceptors/operation_sanitizer_interceptor.go
  • Line 25: warning: exported const OperationSanitizerInterceptorName should have comment or be unexported (golint)
  • Line 27: warning: exported type OperationSanitizerInterceptorProvider should have comment or be unexported (golint)
  • Line 30: warning: exported method OperationSanitizerInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 34: warning: exported method OperationSanitizerInterceptorProvider.Provide should have comment or be unexported (golint)

• storage/postgres/locker.go
  • Line 28: warning: exported var ErrLockAcquisition should have comment or be unexported (golint)
  • Line 29: warning: exported var ErrUnlockAcquisition should have comment or be unexported (golint)
  • Line 31: warning: exported type Locker should have comment or be unexported (golint)
  • Line 73: warning: comment on exported method Locker.TryLock should be of the form "TryLock ..." (golint)

• test/delete.go
  • Line 23: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 31: warning: exported function DescribeDeleteTestsfor should have comment or be unexported (golint)

• storage/interfaces.go
  • Line 37: warning: exported type Entity should have comment or be unexported (golint)
  • Line 44: warning: exported type Label should have comment or be unexported (golint)
  • Line 49: warning: exported type EntityMetadata should have comment or be unexported (golint)
  • Line 178: warning: exported type Repository should have comment or be unexported (golint)

• pkg/auth/strategy.go
  • Line 77: warning: exported method Options.MtlsEnabled should have comment or be unexported (golint)

• pkg/auth/oidc/oidc.go
  • Line 38: warning: exported type MTLSEndpointAliases should have comment or be unexported (golint)
  • Line 83: warning: exported function RetrieveAuthEndpoints should have comment or be unexported (golint)

• api/filters/extract_plan_id_by_service_and_plan_name_filter.go
  • Line 31: warning: exported const ExtractPlanIDByServiceAndPlanName should have comment or be unexported (golint)

• pkg/security/http/authz/oauth_client.go
  • Line 12: warning: exported function NewOauthClientAuthorizer should have comment or be unexported (golint)

• pkg/util/client.go
  • Line 35: warning: exported type DoRequestWithClientFunc should have comment or be unexported (golint)
  • Line 37: warning: exported function ClientRequest should have comment or be unexported (golint)

• pkg/types/service_instance.go
  • Line 29: warning: comment on exported type ServiceInstance should be of the form "ServiceInstance ..." (with optional leading article) (golint)
  • Line 48: warning: exported type SharedInstance should have comment or be unexported (golint)
  • Line 50: warning: exported type InstanceUpdateValues should have comment or be unexported (golint)
  • Line 55: warning: exported method ServiceInstance.Equals should have comment or be unexported (golint)
  • Line 97: warning: exported method ServiceInstance.IsShared should have comment or be unexported (golint)

• storage/interceptors/unique_instance_names_interceptor.go
  • Line 36: warning: exported const UniqueInstanceNameCreateInterceptorName should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported method UniqueInstanceNameCreateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 51: warning: exported method UniqueInstanceNameCreateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 64: warning: exported method UniqueInstanceNameUpdateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 68: warning: exported method UniqueInstanceNameUpdateInterceptorProvider.Provide should have comment or be unexported (golint)

• storage/postgres/visibility.go
  • Line 28: warning: comment on exported type Visibility should be of the form "Visibility ..." (with optional leading article) (golint)
  • Line 35: warning: exported method Visibility.ToObject should have comment or be unexported (golint)
  • Line 50: warning: exported method Visibility.FromObject should have comment or be unexported (golint)

• pkg/ws/settings.go
  • Line 8: warning: exported type Settings should have comment or be unexported (golint)

• pkg/web/user.go
  • Line 25: warning: exported const Basic should have comment (or a comment on this block) or be unexported (golint)

• storage/postgres/keystore.go
  • Line 32: warning: exported const SafeTable should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported method Safe.GetID should have comment or be unexported (golint)
  • Line 51: warning: exported method Safe.ToObject should have comment or be unexported (golint)
  • Line 55: warning: exported method Safe.FromObject should have comment or be unexported (golint)
  • Line 59: warning: exported method Safe.NewLabel should have comment or be unexported (golint)
  • Line 63: warning: exported method Safe.TableName should have comment or be unexported (golint)
  • Line 67: warning: exported method Safe.RowsToList should have comment or be unexported (golint)
  • Line 71: warning: exported method Safe.LabelEntity should have comment or be unexported (golint)

• operations/cascade_utils.go
  • Line 16: warning: exported function FindCascadeOperationForResource should have comment or be unexported (golint)
  • Line 35: warning: exported function GetAllLevelsCascadeOperations should have comment or be unexported (golint)
  • Line 69: warning: exported function ListCascadeChildren should have comment or be unexported (golint)
  • Line 89: warning: exported function GetObjectChildren should have comment or be unexported (golint)
  • Line 105: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 117: warning: exported function EnrichBrokersOfferings should have comment or be unexported (golint)
  • Line 137: warning: exported function GetSubOperations should have comment or be unexported (golint)
  • Line 227: warning: exported function PrepareAggregatedErrorsArray should have comment or be unexported (golint)

• api/filters/visibility_for_platform.go
  • Line 28: warning: exported const PlatformAwareVisibilityFilterName should have comment or be unexported (golint)
  • Line 30: warning: exported type PlatformAwareVisibilityFilter should have comment or be unexported (golint)
  • Line 33: warning: exported method PlatformAwareVisibilityFilter.Name should have comment or be unexported (golint)
  • Line 37: warning: exported method PlatformAwareVisibilityFilter.Run should have comment or be unexported (golint)
  • Line 67: warning: exported method PlatformAwareVisibilityFilter.FilterMatchers should have comment or be unexported (golint)

• pkg/security/http/authz/and_authorizer.go
  • Line 17: warning: exported function NewAndAuthorizer should have comment or be unexported (golint)
  • Line 70: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• pkg/types/visibility.go
  • Line 26: warning: comment on exported type Visibility should be of the form "Visibility ..." (with optional leading article) (golint)
  • Line 34: warning: exported method Visibility.Equals should have comment or be unexported (golint)

• storage/interceptors/broker_create_catalog_interceptor.go
  • Line 33: warning: exported const BrokerCreateCatalogInterceptorName should have comment or be unexported (golint)
  • Line 35: warning: exported type BrokerCreateCatalogInterceptorProvider should have comment or be unexported (golint)
  • Line 39: warning: exported method BrokerCreateCatalogInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 43: warning: exported method BrokerCreateCatalogInterceptorProvider.Provide should have comment or be unexported (golint)

• test/common/oauth_server.go
  • Line 33: warning: exported type OAuthServer should have comment or be unexported (golint)
  • Line 46: warning: exported function NewOAuthServer should have comment or be unexported (golint)
  • Line 64: warning: exported method OAuthServer.Start should have comment or be unexported (golint)
  • Line 72: warning: exported method OAuthServer.Close should have comment or be unexported (golint)
  • Line 79: warning: exported method OAuthServer.URL should have comment or be unexported (golint)
  • Line 83: warning: exported method OAuthServer.TokenKeysRequestCallCount should have comment or be unexported (golint)
  • Line 95: warning: exported method OAuthServer.RotateTokenKey should have comment or be unexported (golint)
  • Line 110: warning: exported method OAuthServer.CreateToken should have comment or be unexported (golint)

• pkg/security/http/authn/or_authenticator.go
  • Line 16: warning: exported function NewOrAuthenticator should have comment or be unexported (golint)

• api/operations_controller.go
  • Line 25: warning: exported method OperationsController.Routes should have comment or be unexported (golint)

• api/filters/check_binding_visibility_filter.go
  • Line 33: warning: exported const ServiceBindingVisibilityFilterName should have comment or be unexported (golint)

• pkg/util/api.go
  • Line 180: warning: exported function BytesToObjectNoLabels should have comment or be unexported (golint)
  • Line 194: warning: exported function ValidateJSONContentType should have comment or be unexported (golint)
  • Line 209: warning: exported function IsJSONContentType should have comment or be unexported (golint)
  • Line 274: warning: exported function NewJSONResponseWithHeaders should have comment or be unexported (golint)
  • Line 295: warning: exported function NewLocationResponse should have comment or be unexported (golint)
  • Line 305: warning: exported function LabelsOnly should have comment or be unexported (golint)

• pkg/util/wg.go
  • Line 8: warning: exported function StartInWaitGroup should have comment or be unexported (golint)
  • Line 16: warning: exported function StartInWaitGroupWithContext should have comment or be unexported (golint)

• pkg/types/operation.go
  • Line 60: warning: exported type RelatedType should have comment or be unexported (golint)
  • Line 67: warning: comment on exported type Operation should be of the form "Operation ..." (with optional leading article) (golint)
  • Line 92: warning: exported type UserInfo should have comment or be unexported (golint)
  • Line 97: warning: exported type OperationContext should have comment or be unexported (golint)
  • Line 107: warning: exported method Operation.Equals should have comment or be unexported (golint)
  • Line 164: warning: exported method Operation.InOrphanMitigationState should have comment or be unexported (golint)
  • Line 168: warning: exported method Operation.Sanitize should have comment or be unexported (golint)
  • Line 174: warning: exported method Operation.IsForceDeleteCascadeOperation should have comment or be unexported (golint)

• storage/interceptable_repository.go
  • Line 32: warning: exported function NewInterceptableTransactionalRepository should have comment or be unexported (golint)
  • Line 88: warning: exported type InterceptableTransactionalRepository should have comment or be unexported (golint)
  • Line 405: warning: exported method InterceptableTransactionalRepository.InTransaction should have comment or be unexported (golint)
  • Line 416: warning: exported method InterceptableTransactionalRepository.QueryForList should have comment or be unexported (golint)
  • Line 420: warning: exported method InterceptableTransactionalRepository.AddCreateAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 432: warning: exported method InterceptableTransactionalRepository.AddCreateOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 444: warning: exported method InterceptableTransactionalRepository.AddCreateInterceptorProvider should have comment or be unexported (golint)
  • Line 457: warning: exported method InterceptableTransactionalRepository.AddUpdateAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 469: warning: exported method InterceptableTransactionalRepository.AddUpdateOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 481: warning: exported method InterceptableTransactionalRepository.AddUpdateInterceptorProvider should have comment or be unexported (golint)
  • Line 494: warning: exported method InterceptableTransactionalRepository.AddDeleteAroundTxInterceptorProvider should have comment or be unexported (golint)
  • Line 506: warning: exported method InterceptableTransactionalRepository.AddDeleteOnTxInterceptorProvider should have comment or be unexported (golint)
  • Line 518: warning: exported method InterceptableTransactionalRepository.AddDeleteInterceptorProvider should have comment or be unexported (golint)
  • Line 531: warning: exported method InterceptableTransactionalRepository.Create should have comment or be unexported (golint)
  • Line 568: warning: exported method InterceptableTransactionalRepository.Get should have comment or be unexported (golint)
  • Line 577: warning: exported method InterceptableTransactionalRepository.GetForUpdate should have comment or be unexported (golint)
  • Line 586: warning: exported method InterceptableTransactionalRepository.List should have comment or be unexported (golint)
  • Line 590: warning: exported method InterceptableTransactionalRepository.ListNoLabels should have comment or be unexported (golint)
  • Line 610: warning: exported method InterceptableTransactionalRepository.Count should have comment or be unexported (golint)
  • Line 614: warning: exported method InterceptableTransactionalRepository.CountLabelValues should have comment or be unexported (golint)
  • Line 618: warning: exported method InterceptableTransactionalRepository.DeleteReturning should have comment or be unexported (golint)
  • Line 651: warning: exported method InterceptableTransactionalRepository.Delete should have comment or be unexported (golint)
  • Line 681: warning: exported method InterceptableTransactionalRepository.Update should have comment or be unexported (golint)
  • Line 718: warning: exported method InterceptableTransactionalRepository.UpdateLabels should have comment or be unexported (golint)
  • Line 760: warning: exported method InterceptableTransactionalRepository.GetEntities should have comment or be unexported (golint)
  • Line 924: warning: exported type InterceptorPosition should have comment or be unexported (golint)
  • Line 929: warning: exported type InterceptorOrder should have comment or be unexported (golint)

• test/osb_and_plugin_test/provision_timeout_test/provision_timeout_suite_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• api/common/sharing/utils.go
  • Line 15: warning: exported function ExtractReferencedInstanceID should have comment or be unexported (golint)
  • Line 52: warning: exported function IsValidReferenceInstancePatchRequest should have comment or be unexported (golint)

• pkg/query/selection.go
  • Line 121: warning: exported function ByNotExists should have comment or be unexported (golint)
  • Line 125: warning: exported function ByExists should have comment or be unexported (golint)
  • Line 145: warning: exported function NewCriterion should have comment or be unexported (golint)

• api/service_instance_controller.go
  • Line 40: warning: exported function NewServiceInstanceController should have comment or be unexported (golint)
  • Line 50: warning: exported method ServiceInstanceController.Routes should have comment or be unexported (golint)
  • Line 106: warning: exported method ServiceInstanceController.GetParameters should have comment or be unexported (golint)

• api/filters/protected_labels.go
  • Line 31: warning: exported const ProtectedLabelsFilterName should have comment or be unexported (golint)
  • Line 49: warning: exported method ProtectedLabelsFilter.Name should have comment or be unexported (golint)
  • Line 53: warning: exported method ProtectedLabelsFilter.Run should have comment or be unexported (golint)
  • Line 111: warning: exported method ProtectedLabelsFilter.FilterMatchers should have comment or be unexported (golint)

• api/filters/protected_sm_platform_filter.go
  • Line 12: warning: exported const ProtectedSMPlatformFilterName should have comment or be unexported (golint)
  • Line 18: warning: exported method ProtectedSMPlatformFilter.Name should have comment or be unexported (golint)
  • Line 22: warning: exported method ProtectedSMPlatformFilter.Run should have comment or be unexported (golint)
  • Line 34: warning: exported method ProtectedSMPlatformFilter.FilterMatchers should have comment or be unexported (golint)

• pkg/types/context_keys.go
  • Line 21: warning: comment on exported function SharedInstanceFromContext should be of the form "SharedInstanceFromContext ..." (golint)
  • Line 38: warning: comment on exported function ContextWithSharedInstance should be of the form "ContextWithSharedInstance ..." (golint)

• test/osb_and_plugin_test/provision_timeout_test/provision_timeout_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• storage/interceptors/broker_update_catalog_interceptor.go
  • Line 36: warning: exported const BrokerUpdateCatalogInterceptorName should have comment or be unexported (golint)
  • Line 44: warning: exported method BrokerUpdateCatalogInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 51: warning: exported method BrokerUpdateCatalogInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 331: warning: context.Context should be the first parameter of a function (golint)

• test/common/test_context.go
  • Line 64: warning: exported const SMServer should have comment or be unexported (golint)
  • Line 65: warning: exported const OauthServer should have comment or be unexported (golint)
  • Line 66: warning: exported const TenantOauthServer should have comment or be unexported (golint)
  • Line 67: warning: exported const BrokerServerPrefix should have comment or be unexported (golint)
  • Line 68: warning: exported const BrokerServerPrefixTLS should have comment or be unexported (golint)
  • Line 70: warning: exported type TestContextBuilder should have comment or be unexported (golint)
  • Line 88: warning: exported type BrokerContext should have comment or be unexported (golint)
  • Line 95: warning: exported type BrokerUtilsContext should have comment or be unexported (golint)
  • Line 101: warning: exported type BrokerUtils should have comment or be unexported (golint)
  • Line 108: warning: exported method BrokerUtils.Cleanup should have comment or be unexported (golint)
  • Line 112: warning: exported method BrokerUtils.GetBrokerAsParams should have comment or be unexported (golint)
  • Line 116: warning: exported method BrokerUtils.SelectBroker should have comment or be unexported (golint)
  • Line 121: warning: exported method BrokerUtils.GetPlanCatalogId should have comment or be unexported (golint)
  • Line 126: warning: exported method BrokerUtils.GetBrokerOSBURL should have comment or be unexported (golint)
  • Line 130: warning: exported method BrokerUtils.GetServiceCatalogId should have comment or be unexported (golint)
  • Line 135: warning: exported method BrokerUtils.RegisterPlatformToBroker should have comment or be unexported (golint)
  • Line 152: warning: exported method BrokerUtils.SetAuthContext should have comment or be unexported (golint)
  • Line 156: warning: exported method BrokerUtils.GetServiceOfferings should have comment or be unexported (golint)
  • Line 161: warning: exported method BrokerUtils.AddPlanVisibilityForPlatform should have comment or be unexported (golint)
  • Line 185: warning: exported method BrokerUtils.GetServicePlans should have comment or be unexported (golint)
  • Line 190: warning: exported method BrokerUtils.GetPlan should have comment or be unexported (golint)
  • Line 195: warning: exported method BrokerUtils.GetAsServiceInstancePayload should have comment or be unexported (golint)
  • Line 206: warning: exported method BrokerUtils.Get should have comment or be unexported (golint)
  • Line 212: warning: exported type TestContext should have comment or be unexported (golint)
  • Line 236: warning: exported type SMExpect should have comment or be unexported (golint)
  • Line 240: warning: exported method SMExpect.List should have comment or be unexported (golint)
  • Line 244: warning: exported method SMExpect.ListWithQuery should have comment or be unexported (golint)
  • Line 266: warning: exported method SMExpect.SetBasicCredentials should have comment or be unexported (golint)
  • Line 292: warning: exported function NewTestContextBuilderWithSecurity should have comment or be unexported (golint)
  • Line 349: warning: exported function SetTestFileLocation should have comment or be unexported (golint)
  • Line 358: warning: exported function SetNotificationsCleanerSettings should have comment or be unexported (golint)
  • Line 369: warning: exported function SetLogOutput should have comment or be unexported (golint)
  • Line 376: warning: exported function TestEnv should have comment or be unexported (golint)
  • Line 397: warning: exported method TestContextBuilder.WithBasicAuthPlatformName should have comment or be unexported (golint)
  • Line 403: warning: exported method TestContextBuilder.SkipBasicAuthClientSetup should have comment or be unexported (golint)
  • Line 409: warning: exported method TestContextBuilder.WithDefaultEnv should have comment or be unexported (golint)
  • Line 415: warning: exported method TestContextBuilder.WithAdditionalFakeServers should have comment or be unexported (golint)
  • Line 427: warning: exported method TestContextBuilder.WithTenantTokenClaims should have comment or be unexported (golint)
  • Line 433: warning: exported method TestContextBuilder.WithDefaultTokenClaims should have comment or be unexported (golint)
  • Line 439: warning: exported method TestContextBuilder.WithEnvPreExtensions should have comment or be unexported (golint)
  • Line 445: warning: exported method TestContextBuilder.WithEnvPostExtensions should have comment or be unexported (golint)
  • Line 451: warning: exported method TestContextBuilder.WithSMExtensions should have comment or be unexported (golint)
  • Line 457: warning: exported method TestContextBuilder.ShouldUseSeparateOAuthServerForTenantAccess should have comment or be unexported (golint)
  • Line 462: warning: exported method TestContextBuilder.Build should have comment or be unexported (golint)
  • Line 466: warning: exported method TestContextBuilder.BuildWithCleanup should have comment or be unexported (golint)
  • Line 470: warning: exported method TestContextBuilder.BuildWithoutCleanup should have comment or be unexported (golint)
  • Line 474: warning: exported method TestContextBuilder.BuildWithListener should have comment or be unexported (golint)
  • Line 576: warning: exported function NewSMListener should have comment or be unexported (golint)
  • Line 639: warning: exported method TestContext.RegisterBrokerWithCatalogAndLabels should have comment or be unexported (golint)
  • Line 643: warning: exported method TestContext.RegisterBrokerWithRandomCatalogAndTLS should have comment or be unexported (golint)
  • Line 685: warning: exported method TestContext.RegisterBrokerWithCatalogAndLabelsExpect should have comment or be unexported (golint)
  • Line 705: warning: exported method TestContext.TryRegisterBrokerWithCatalogAndLabels should have comment or be unexported (golint)
  • Line 733: warning: exported function MergeObjects should have comment or be unexported (golint)
  • Line 757: warning: exported method TestContext.RegisterBrokerWithCatalog should have comment or be unexported (golint)
  • Line 761: warning: exported method TestContext.RegisterBroker should have comment or be unexported (golint)
  • Line 765: warning: exported method TestContext.RegisterPlatform should have comment or be unexported (golint)
  • Line 769: warning: exported method TestContext.RegisterPlatformAndActivate should have comment or be unexported (golint)
  • Line 773: warning: exported method TestContext.RegisterTenantPlatform should have comment or be unexported (golint)
  • Line 777: warning: exported method TestContext.RegisterPlatformWithType should have comment or be unexported (golint)
  • Line 781: warning: exported method TestContext.RegisterPlatformWithTypeAndActivate should have comment or be unexported (golint)
  • Line 804: warning: exported method TestContext.NewTenantExpect should have comment or be unexported (golint)
  • Line 821: warning: exported method TestContext.CleanupBroker should have comment or be unexported (golint)
  • Line 828: warning: exported method TestContext.Cleanup should have comment or be unexported (golint)
  • Line 832: warning: exported method TestContext.CleanupAll should have comment or be unexported (golint)
  • Line 849: warning: exported method TestContext.CleanupPlatforms should have comment or be unexported (golint)
  • Line 857: warning: exported method TestContext.CleanupAdditionalResources should have comment or be unexported (golint)
  • Line 887: warning: exported method TestContext.ConnectWebSocket should have comment or be unexported (golint)
  • Line 917: warning: exported method TestContext.CloseWebSocket should have comment or be unexported (golint)

• pkg/web/dynamic_matching_filter.go
  • Line 7: warning: exported type DynamicMatchingFilter should have comment or be unexported (golint)
  • Line 12: warning: exported function NewDynamicMatchingFilter should have comment or be unexported (golint)
  • Line 18: warning: exported method DynamicMatchingFilter.AddFilter should have comment or be unexported (golint)
  • Line 22: warning: exported method DynamicMatchingFilter.ClearFilters should have comment or be unexported (golint)
  • Line 26: warning: exported method DynamicMatchingFilter.Name should have comment or be unexported (golint)
  • Line 30: warning: exported method DynamicMatchingFilter.Run should have comment or be unexported (golint)
  • Line 43: warning: exported method DynamicMatchingFilter.FilterMatchers should have comment or be unexported (golint)

• storage/interceptors/osb_tenant_labeling_interceptor.go
  • Line 30: warning: exported const ServiceInstanceCreateInterceptorName should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported function NewOSBServiceInstanceTenantLabelingInterceptor should have comment or be unexported (golint)
  • Line 54: warning: exported function NewOSBBindingTenantLabelingInterceptor should have comment or be unexported (golint)

• api/osb/catalog_filter_by_visibility_plugin.go
  • Line 19: warning: exported const CatalogFilterByVisibilityPluginName should have comment or be unexported (golint)
  • Line 21: warning: exported function NewCatalogFilterByVisibilityPlugin should have comment or be unexported (golint)
  • Line 27: warning: exported method CatalogFilterByVisibilityPlugin.Name should have comment or be unexported (golint)
  • Line 31: warning: exported type CatalogFilterByVisibilityPlugin should have comment or be unexported (golint)
  • Line 35: warning: exported method CatalogFilterByVisibilityPlugin.FetchCatalog should have comment or be unexported (golint)

• pkg/util/errors.go
  • Line 60: warning: exported function ToHTTPError should have comment or be unexported (golint)
  • Line 197: warning: exported function HandleReferencesError should have comment or be unexported (golint)
  • Line 227: warning: exported var ErrCatalogUsesReservedPlanName should have comment or be unexported (golint)
  • Line 246: warning: exported function HandleInstanceSharingError should have comment or be unexported (golint)

• test/list.go
  • Line 34: warning: should not use dot imports (golint)
  • Line 38: warning: should not use dot imports (golint)
  • Line 39: warning: should not use dot imports (golint)
  • Line 54: warning: exported function DescribeListTestsFor should have comment or be unexported (golint)

• storage/interceptors/broker_public_plans_interceptor.go
  • Line 32: warning: exported const CreateBrokerPublicPlanInterceptorName should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: exported type PublicPlanCreateInterceptorProvider should have comment or be unexported (golint)
  • Line 45: warning: exported method PublicPlanCreateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 53: warning: exported method PublicPlanCreateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 57: warning: exported type PublicPlanUpdateInterceptorProvider should have comment or be unexported (golint)
  • Line 63: warning: exported method PublicPlanUpdateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 67: warning: exported method PublicPlanUpdateInterceptorProvider.Provide should have comment or be unexported (golint)
  • Line 159: warning: context.Context should be the first parameter of a function (golint)

• storage/interceptors/unique_binding_names_interceptor.go
  • Line 36: warning: exported const UniqueBindingNameCreateInterceptorName should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported method UniqueBindingNameCreateInterceptorProvider.Name should have comment or be unexported (golint)
  • Line 48: warning: exported method UniqueBindingNameCreateInterceptorProvider.Provide should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!