Preparing report...

Report for github.com/Regner/albiondata-client

A+    Excellent!    Found 14 issues across 44 files

Tweet

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint68%

Golint is a linter for Go source code.

    • albiondata-client/client/client.go
    • Line 8: warning: exported type Client should have comment or be unexported (golint)
    • Line 11: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 15: warning: exported method Client.Run should have comment or be unexported (golint)
    • albiondata-client/systray/systray_others.go
    • Line 5: warning: exported var ConsoleHidden should have comment or be unexported (golint)
    • Line 7: warning: exported const CanHideConsole should have comment or be unexported (golint)
    • Line 9: warning: exported function HideConsole should have comment or be unexported (golint)
    • Line 13: warning: exported function ShowConsole should have comment or be unexported (golint)
    • Line 17: warning: exported function Run should have comment or be unexported (golint)
    • albiondata-client/lib/market.go
    • Line 19: warning: exported method MarketOrder.StringArray should have comment or be unexported (golint)
    • Line 34: warning: exported const SalesTax should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported type MarketNotificationType should have comment or be unexported (golint)
    • Line 40: warning: exported const SalesNotification should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: exported type MarketNotification should have comment or be unexported (golint)
    • Line 48: warning: exported type MarketSellNotification should have comment or be unexported (golint)
    • Line 57: warning: exported type MarketExpiryNotification should have comment or be unexported (golint)
    • Line 63: warning: exported method MarketSellNotification.Type should have comment or be unexported (golint)
    • Line 67: warning: exported method MarketExpiryNotification.Type should have comment or be unexported (golint)
    • Line 71: warning: exported type MarketNotificationUpload should have comment or be unexported (golint)
    • albiondata-client/lib/nats.go
    • Line 4: warning: comment on exported const NatsGoldPricesIngest should be of the form "NatsGoldPricesIngest ..." (golint)
    • Line 6: warning: exported const NatsGoldPricesDeduped should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: comment on exported const NatsSkillData should be of the form "NatsSkillData ..." (golint)
    • albiondata-client/lib/common.go
    • Line 10: warning: exported type PrivateUpload should have comment or be unexported (golint)
    • Line 15: warning: exported method PrivateUpload.Personalize should have comment or be unexported (golint)
    • Line 20: warning: exported type PersonalizedUpload should have comment or be unexported (golint)
    • Line 24: warning: comment on exported type CharacterID should be of the form "CharacterID ..." (with optional leading article) (golint)
    • Line 27: warning: exported method CharacterID.Base64 should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!