Preparing report...

Report for github.com/SAP/go-dblib

A+    Excellent!    Found 50 issues across 153 files

Tweet

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint73%

Golint is a linter for Go source code.

    • go-dblib/tds/packageCurInfo.go
    • Line 16: warning: exported const TDS_CUR_CMD_SETCURROWS should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported const TDS_CUR_ISTAT_UNUSED should have comment (or a comment on this block) or be unexported (golint)
    • go-dblib/asetypes/decimal.go
    • Line 57: warning: comment on exported function DecimalByteSize should be of the form "DecimalByteSize ..." (golint)
    • Line 203: warning: comment on exported method Decimal.SetString should be of the form "SetString ..." (golint)
    • go-dblib/tds/packageLoginAck.go
    • Line 12: warning: comment on exported type LoginAckStatus should be of the form "LoginAckStatus ..." (with optional leading article) (golint)
    • Line 16: warning: exported const TDS_LOG_SUCCEED should have comment (or a comment on this block) or be unexported (golint)
    • go-dblib/dsn/tagToField.go
    • Line 12: warning: exported type TagType should have comment or be unexported (golint)
    • Line 15: warning: exported const OnlyJSON should have comment (or a comment on this block) or be unexported (golint)
    • go-dblib/tds/field.go
    • Line 49: warning: exported const TDS_PARAM_NOSTATUS should have comment (or a comment on this block) or be unexported (golint)
    • Line 61: warning: exported const TDS_ROW_NOSTATUS should have comment (or a comment on this block) or be unexported (golint)
    • Line 76: warning: exported const TDS_DATA_NONNULL should have comment (or a comment on this block) or be unexported (golint)
    • Line 462: warning: exported type BitFieldFmt should have comment or be unexported (golint)
    • Line 463: warning: exported type DateTimeFieldFmt should have comment or be unexported (golint)
    • Line 464: warning: exported type DateFieldFmt should have comment or be unexported (golint)
    • Line 465: warning: exported type ShortDateFieldFmt should have comment or be unexported (golint)
    • Line 466: warning: exported type Flt4FieldFmt should have comment or be unexported (golint)
    • Line 467: warning: exported type Flt8FieldFmt should have comment or be unexported (golint)
    • Line 468: warning: exported type Int1FieldFmt should have comment or be unexported (golint)
    • Line 469: warning: exported type Int2FieldFmt should have comment or be unexported (golint)
    • Line 470: warning: exported type Int4FieldFmt should have comment or be unexported (golint)
    • Line 471: warning: exported type Int8FieldFmt should have comment or be unexported (golint)
    • Line 472: warning: exported type IntervalFieldFmt should have comment or be unexported (golint)
    • Line 473: warning: exported type Sint1FieldFmt should have comment or be unexported (golint)
    • Line 474: warning: exported type Uint2FieldFmt should have comment or be unexported (golint)
    • Line 475: warning: exported type Uint4FieldFmt should have comment or be unexported (golint)
    • Line 476: warning: exported type Uint8FieldFmt should have comment or be unexported (golint)
    • Line 477: warning: exported type MoneyFieldFmt should have comment or be unexported (golint)
    • Line 478: warning: exported type ShortMoneyFieldFmt should have comment or be unexported (golint)
    • Line 479: warning: exported type TimeFieldFmt should have comment or be unexported (golint)
    • Line 480: warning: exported type BinaryFieldFmt should have comment or be unexported (golint)
    • Line 481: warning: exported type BoundaryFieldFmt should have comment or be unexported (golint)
    • Line 482: warning: exported type CharFieldFmt should have comment or be unexported (golint)
    • Line 483: warning: exported type DateNFieldFmt should have comment or be unexported (golint)
    • Line 484: warning: exported type DateTimeNFieldFmt should have comment or be unexported (golint)
    • Line 485: warning: exported type FltNFieldFmt should have comment or be unexported (golint)
    • Line 486: warning: exported type IntNFieldFmt should have comment or be unexported (golint)
    • Line 487: warning: exported type UintNFieldFmt should have comment or be unexported (golint)
    • Line 488: warning: exported type LongBinaryFieldFmt should have comment or be unexported (golint)
    • Line 489: warning: exported type LongCharFieldFmt should have comment or be unexported (golint)
    • Line 490: warning: exported type MoneyNFieldFmt should have comment or be unexported (golint)
    • Line 491: warning: exported type SensitivityFieldFmt should have comment or be unexported (golint)
    • Line 492: warning: exported type TimeNFieldFmt should have comment or be unexported (golint)
    • Line 493: warning: exported type VarBinaryFieldFmt should have comment or be unexported (golint)
    • Line 494: warning: exported type VarCharFieldFmt should have comment or be unexported (golint)
    • Line 508: warning: exported type BitFieldData should have comment or be unexported (golint)
    • Line 509: warning: exported type DateTimeFieldData should have comment or be unexported (golint)
    • Line 510: warning: exported type DateFieldData should have comment or be unexported (golint)
    • Line 511: warning: exported type ShortDateFieldData should have comment or be unexported (golint)
    • Line 512: warning: exported type Flt4FieldData should have comment or be unexported (golint)
    • Line 513: warning: exported type Flt8FieldData should have comment or be unexported (golint)
    • Line 514: warning: exported type Int1FieldData should have comment or be unexported (golint)
    • Line 515: warning: exported type Int2FieldData should have comment or be unexported (golint)
    • Line 516: warning: exported type Int4FieldData should have comment or be unexported (golint)
    • Line 517: warning: exported type Int8FieldData should have comment or be unexported (golint)
    • Line 518: warning: exported type IntervalFieldData should have comment or be unexported (golint)
    • Line 519: warning: exported type Sint1FieldData should have comment or be unexported (golint)
    • Line 520: warning: exported type Uint2FieldData should have comment or be unexported (golint)
    • Line 521: warning: exported type Uint4FieldData should have comment or be unexported (golint)
    • Line 522: warning: exported type Uint8FieldData should have comment or be unexported (golint)
    • Line 523: warning: exported type MoneyFieldData should have comment or be unexported (golint)
    • Line 524: warning: exported type ShortMoneyFieldData should have comment or be unexported (golint)
    • Line 525: warning: exported type TimeFieldData should have comment or be unexported (golint)
    • Line 526: warning: exported type BinaryFieldData should have comment or be unexported (golint)
    • Line 527: warning: exported type BoundaryFieldData should have comment or be unexported (golint)
    • Line 528: warning: exported type CharFieldData should have comment or be unexported (golint)
    • Line 529: warning: exported type DateNFieldData should have comment or be unexported (golint)
    • Line 530: warning: exported type DateTimeNFieldData should have comment or be unexported (golint)
    • Line 531: warning: exported type FltNFieldData should have comment or be unexported (golint)
    • Line 532: warning: exported type IntNFieldData should have comment or be unexported (golint)
    • Line 533: warning: exported type UintNFieldData should have comment or be unexported (golint)
    • Line 534: warning: exported type LongBinaryFieldData should have comment or be unexported (golint)
    • Line 535: warning: exported type LongCharFieldData should have comment or be unexported (golint)
    • Line 536: warning: exported type MoneyNFieldData should have comment or be unexported (golint)
    • Line 537: warning: exported type SensitivityFieldData should have comment or be unexported (golint)
    • Line 538: warning: exported type TimeNFieldData should have comment or be unexported (golint)
    • Line 539: warning: exported type VarBinaryFieldData should have comment or be unexported (golint)
    • Line 540: warning: exported type VarCharFieldData should have comment or be unexported (golint)
    • Line 603: warning: exported type BigDateTimeNFieldFmt should have comment or be unexported (golint)
    • Line 604: warning: exported type BigTimeNFieldFmt should have comment or be unexported (golint)
    • Line 606: warning: exported type BigDateTimeNFieldData should have comment or be unexported (golint)
    • Line 607: warning: exported type BigTimeNFieldData should have comment or be unexported (golint)
    • Line 680: warning: exported type DecNFieldFmt should have comment or be unexported (golint)
    • Line 681: warning: exported type NumNFieldFmt should have comment or be unexported (golint)
    • Line 713: warning: exported type DecNFieldData should have comment or be unexported (golint)
    • Line 714: warning: exported type NumNFieldData should have comment or be unexported (golint)
    • Line 724: warning: exported const TDS_BLOB_FULLCLASSNAME should have comment (or a comment on this block) or be unexported (golint)
    • Line 740: warning: exported const NativeJavaSerialization should have comment (or a comment on this block) or be unexported (golint)
    • Line 819: warning: exported type BlobFieldFmt should have comment or be unexported (golint)
    • Line 1035: warning: exported type BlobFieldData should have comment or be unexported (golint)
    • Line 1092: warning: exported type ImageFieldFmt should have comment or be unexported (golint)
    • Line 1093: warning: exported type TextFieldFmt should have comment or be unexported (golint)
    • Line 1094: warning: exported type UniTextFieldFmt should have comment or be unexported (golint)
    • Line 1095: warning: exported type XMLFieldFmt should have comment or be unexported (golint)
    • Line 1189: warning: exported type ImageFieldData should have comment or be unexported (golint)
    • Line 1190: warning: exported type TextFieldData should have comment or be unexported (golint)
    • Line 1191: warning: exported type UniTextFieldData should have comment or be unexported (golint)
    • Line 1192: warning: exported type XMLFieldData should have comment or be unexported (golint)
    • go-dblib/tds/packageCurDeclare.go
    • Line 16: warning: exported const TDS_CUR_DOPT_UNUSED should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported const TDS_CUR_DSTAT_UNUSED should have comment (or a comment on this block) or be unexported (golint)
    • go-dblib/tds/packageDone.go
    • Line 51: warning: exported type DoneProcPackage should have comment or be unexported (golint)
    • Line 52: warning: exported type DoneInProcPackage should have comment or be unexported (golint)
    • go-dblib/doc.go
    • Line 12: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)
    • go-dblib/tds/packageCapability.go
    • Line 288: warning: comment on exported method CapabilityPackage.HasResponseCapability should be of the form "HasResponseCapability ..." (golint)
    • Line 294: warning: comment on exported method CapabilityPackage.HasSecurityCapability should be of the form "HasSecurityCapability ..." (golint)
    • go-dblib/tds/packageMsg.go
    • Line 16: warning: exported const TDS_MSG_HASNOARGS should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported const TDS_MSG_SEC_ENCRYPT should have comment (or a comment on this block) or be unexported (golint)
    • Line 67: warning: exported const TDS_SEC_SECSESS should have comment (or a comment on this block) or be unexported (golint)
    • Line 113: warning: comment on exported method MsgPackage.WriteTo should be of the form "WriteTo ..." (golint)
    • go-dblib/tds/packetHeader.go
    • Line 16: warning: comment on exported const PacketHeaderSize should be of the form "PacketHeaderSize ..." (golint)
    • Line 26: warning: exported const TDS_BUF_LANG should have comment (or a comment on this block) or be unexported (golint)
    • Line 57: warning: comment on exported const TDS_BUFSTAT_EOM should be of the form "TDS_BUFSTAT_EOM ..." (golint)
    • Line 59: warning: comment on exported const TDS_BUFSTAT_ATTNACK should be of the form "TDS_BUFSTAT_ATTNACK ..." (golint)
    • Line 61: warning: comment on exported const TDS_BUFSTAT_ATTN should be of the form "TDS_BUFSTAT_ATTN ..." (golint)
    • Line 63: warning: comment on exported const TDS_BUFSTAT_EVENT should be of the form "TDS_BUFSTAT_EVENT ..." (golint)
    • Line 65: warning: comment on exported const TDS_BUFSTAT_SEAL should be of the form "TDS_BUFSTAT_SEAL ..." (golint)
    • Line 67: warning: comment on exported const TDS_BUFSTAT_ENCRYPT should be of the form "TDS_BUFSTAT_ENCRYPT ..." (golint)
    • Line 69: warning: comment on exported const TDS_BUFSTAT_SYMENCRYPT should be of the form "TDS_BUFSTAT_SYMENCRYPT ..." (golint)
    • go-dblib/tds/packageControl.go
    • Line 10: warning: exported type ControlPackage should have comment or be unexported (golint)
    • Line 13: warning: exported method ControlPackage.ReadFrom should have comment or be unexported (golint)
    • Line 17: warning: exported method ControlPackage.WriteTo should have comment or be unexported (golint)
    • go-dblib/tds/packageOptionCmd.go
    • Line 20: warning: exported const TDS_OPT_SET should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported const TDS_OPT_UNUSED should have comment (or a comment on this block) or be unexported (golint)
    • go-dblib/tds/envChange.go
    • Line 14: warning: comment on exported method Channel.RegisterEnvChangeHooks should be of the form "RegisterEnvChangeHooks ..." (golint)
    • go-dblib/tds/channel.go
    • Line 22: warning: exported var ErrNoPackageReady should have comment or be unexported (golint)
    • Line 270: warning: exported method Channel.SetLastPkgRx should have comment or be unexported (golint)
    • Line 278: warning: exported method Channel.SetLastPkgTx should have comment or be unexported (golint)
    • Line 458: warning: comment on exported method Channel.QueuePackage should be of the form "QueuePackage ..." (golint)
    • Line 484: warning: comment on exported method Channel.SendRemainingPackets should be of the form "SendRemainingPackets ..." (golint)

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!