Preparing report...

Report for github.com/SimonWaldherr/saprfc

A    Great!    Found 4 issues across 5 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo80%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • saprfc/saprfc.go
    • Line 580: warning: cyclomatic complexity 35 of function wrapVariable() is high (> 15) (gocyclo)
    • Line 129: warning: cyclomatic complexity 17 of function fillVariable() is high (> 15) (gocyclo)
    • Line 1049: warning: cyclomatic complexity 16 of function (*Connection).Call() is high (> 15) (gocyclo)

golint40%

Golint is a linter for Go source code.

    • saprfc/saprfc.go
    • Line 3: warning: package comment should be of the form "Package saprfc ..." (golint)
    • Line 66: warning: exported type RfcError should have comment or be unexported (golint)
    • Line 88: warning: don't use underscores in Go names; var result_len should be resultLen (golint)
    • Line 89: warning: don't use underscores in Go names; var sapuc_size should be sapucSize (golint)
    • Line 324: warning: exported type ConnectionAttributes should have comment or be unexported (golint)
    • Line 387: warning: exported type FieldDescription should have comment or be unexported (golint)
    • Line 398: warning: exported type TypeDescription should have comment or be unexported (golint)
    • Line 475: warning: exported type ParameterDescription should have comment or be unexported (golint)
    • Line 494: warning: exported type FunctionDescription should have comment or be unexported (golint)
    • Line 865: warning: don't use underscores in Go names; struct field Snc_qop should be SncQop (golint)
    • Line 866: warning: don't use underscores in Go names; struct field Snc_myname should be SncMyname (golint)
    • Line 867: warning: don't use underscores in Go names; struct field Snc_partnername should be SncPartnername (golint)
    • Line 868: warning: don't use underscores in Go names; struct field Snc_lib should be SncLib (golint)
    • Line 873: warning: exported type Connection should have comment or be unexported (golint)
    • Line 948: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 961: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign80%

IneffAssign detects ineffectual assignments in Go code.


misspell80%

Misspell Finds commonly misspelled English words

    • saprfc/saprfc.go
    • Line 72: warning: "occured" is a misspelling of "occurred" (misspell)
    • Line 678: warning: "requried" is a misspelling of "required" (misspell)
    • Line 837: warning: "returnd" is a misspelling of "returned" (misspell)
    • Line 893: warning: "successfull" is a misspelling of "successful" (misspell)