gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• Dominator/cmd/installer/server.go
  • Line 97: warning: cyclomatic complexity 16 of function (*srpcType).Shell() is high (> 15) (gocyclo)

• Dominator/hypervisor/rpcd/connectToVmSerialPort.go
  • Line 11: warning: cyclomatic complexity 17 of function (*srpcType).ConnectToVmSerialPort() is high (> 15) (gocyclo)

• Dominator/lib/filesystem/list.go
  • Line 122: warning: cyclomatic complexity 24 of function listUntilName() is high (> 15) (gocyclo)
  • Line 187: warning: cyclomatic complexity 17 of function (FileMode).string() is high (> 15) (gocyclo)

• Dominator/lib/fsutil/copy.go
  • Line 45: warning: cyclomatic complexity 18 of function copyTree() is high (> 15) (gocyclo)

• Dominator/cmd/scan/main.go
  • Line 43: warning: cyclomatic complexity 18 of function main() is high (> 15) (gocyclo)

• Dominator/imageserver/rpcd/replicator.go
  • Line 151: warning: cyclomatic complexity 17 of function (*srpcType).addImage() is high (> 15) (gocyclo)
  • Line 55: warning: cyclomatic complexity 17 of function (*srpcType).getUpdates() is high (> 15) (gocyclo)

• Dominator/lib/net/rrdialer/impl.go
  • Line 169: warning: cyclomatic complexity 18 of function (*Dialer).dialEndpoints() is high (> 15) (gocyclo)

• Dominator/lib/rsync/getBlocks.go
  • Line 18: warning: cyclomatic complexity 16 of function getBlocks() is high (> 15) (gocyclo)

• Dominator/lib/srpc/server.go
  • Line 273: warning: cyclomatic complexity 21 of function httpHandler() is high (> 15) (gocyclo)

• Dominator/lib/fsutil/compare.go
  • Line 39: warning: cyclomatic complexity 16 of function compareFiles() is high (> 15) (gocyclo)

• Dominator/imagepublishers/amipublisher/copyBootstrapImage.go
  • Line 34: warning: cyclomatic complexity 18 of function copyBootstrapImage() is high (> 15) (gocyclo)

• Dominator/imagepublishers/amipublisher/publish.go
  • Line 100: warning: cyclomatic complexity 16 of function (*publishData).publishToTarget() is high (> 15) (gocyclo)

• Dominator/hypervisor/manager/vm.go
  • Line 1290: warning: cyclomatic complexity 39 of function (*Manager).migrateVm() is high (> 15) (gocyclo)
  • Line 618: warning: cyclomatic complexity 37 of function (*Manager).createVm() is high (> 15) (gocyclo)
  • Line 1668: warning: cyclomatic complexity 30 of function (*Manager).patchVmImage() is high (> 15) (gocyclo)
  • Line 1904: warning: cyclomatic complexity 27 of function (*Manager).replaceVmImage() is high (> 15) (gocyclo)
  • Line 1129: warning: cyclomatic complexity 27 of function (*Manager).importLocalVm() is high (> 15) (gocyclo)
  • Line 492: warning: cyclomatic complexity 24 of function (*Manager).copyVm() is high (> 15) (gocyclo)
  • Line 2686: warning: cyclomatic complexity 21 of function (*vmInfoType).startManaging() is high (> 15) (gocyclo)
  • Line 2814: warning: cyclomatic complexity 18 of function (*vmInfoType).startVm() is high (> 15) (gocyclo)
  • Line 213: warning: cyclomatic complexity 16 of function (*Manager).allocateVm() is high (> 15) (gocyclo)
  • Line 2552: warning: cyclomatic complexity 16 of function (*vmInfoType).processMonitorResponses() is high (> 15) (gocyclo)

• Dominator/lib/net/configurator/compute.go
  • Line 56: warning: cyclomatic complexity 18 of function compute() is high (> 15) (gocyclo)

• Dominator/cmd/installer/configureStorage.go
  • Line 147: warning: cyclomatic complexity 32 of function configureStorage() is high (> 15) (gocyclo)

• Dominator/cmd/dominator/main.go
  • Line 85: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• Dominator/lib/filesystem/scanner/walk.go
  • Line 109: warning: cyclomatic complexity 27 of function scanDirectory() is high (> 15) (gocyclo)

• Dominator/imageunpacker/unpacker/exportImage.go
  • Line 47: warning: cyclomatic complexity 23 of function (*streamManagerState).export() is high (> 15) (gocyclo)

• Dominator/imagepublishers/amipublisher/unusedImages.go
  • Line 119: warning: cyclomatic complexity 17 of function listUnusedImagesCS() is high (> 15) (gocyclo)

• Dominator/imagepublishers/amipublisher/delete.go
  • Line 28: warning: cyclomatic complexity 16 of function deleteResource() is high (> 15) (gocyclo)

• Dominator/lib/fsbench/fsbench.go
  • Line 38: warning: cyclomatic complexity 18 of function getDevnodeForFile() is high (> 15) (gocyclo)

• Dominator/dom/herd/subStatus.go
  • Line 7: warning: cyclomatic complexity 36 of function (subStatus).string() is high (> 15) (gocyclo)

• Dominator/cmd/vm-control/importVirshVm.go
  • Line 190: warning: cyclomatic complexity 37 of function importVirshVm() is high (> 15) (gocyclo)

• Dominator/cmd/vm-control/copyVm.go
  • Line 60: warning: cyclomatic complexity 17 of function copyVmFromHypervisor() is high (> 15) (gocyclo)

• Dominator/imageunpacker/unpacker/prepareForUnpack.go
  • Line 44: warning: cyclomatic complexity 16 of function (*streamManagerState).scan() is high (> 15) (gocyclo)

• Dominator/sub/rpcd/update.go
  • Line 126: warning: cyclomatic complexity 17 of function runTriggers() is high (> 15) (gocyclo)

• Dominator/cmd/hypervisor/main.go
  • Line 88: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)

• Dominator/cmd/subd/main.go
  • Line 256: warning: cyclomatic complexity 35 of function main() is high (> 15) (gocyclo)

• Dominator/fleetmanager/hypervisors/listVMs.go
  • Line 75: warning: cyclomatic complexity 23 of function (*Manager).listVMsHandler() is high (> 15) (gocyclo)

• Dominator/imageserver/rpcd/getImageUpdates.go
  • Line 9: warning: cyclomatic complexity 19 of function (*srpcType).GetImageUpdates() is high (> 15) (gocyclo)

• Dominator/cmd/vm-control/createVm.go
  • Line 117: warning: cyclomatic complexity 23 of function createVmOnHypervisor() is high (> 15) (gocyclo)

• Dominator/cmd/vm-control/getVmVolume.go
  • Line 29: warning: cyclomatic complexity 16 of function getVmVolumeOnHypervisor() is high (> 15) (gocyclo)

• Dominator/imagebuilder/builder/image.go
  • Line 45: warning: cyclomatic complexity 29 of function (*imageStreamType).getManifest() is high (> 15) (gocyclo)

• Dominator/lib/logbuf/impl.go
  • Line 209: warning: cyclomatic complexity 16 of function (*LogBuffer).enforceQuota() is high (> 15) (gocyclo)

• Dominator/lib/net/util/getDefaultRoute.go
  • Line 19: warning: cyclomatic complexity 16 of function getDefaultRoute() is high (> 15) (gocyclo)

• Dominator/proto/hypervisor/methods.go
  • Line 215: warning: cyclomatic complexity 24 of function (*VmInfo).Equal() is high (> 15) (gocyclo)

• Dominator/cmd/hyper-control/rolloutImage.go
  • Line 99: warning: cyclomatic complexity 30 of function rolloutImage() is high (> 15) (gocyclo)

• Dominator/dom/lib/buildUpdateRequest.go
  • Line 55: warning: cyclomatic complexity 21 of function (*Sub).compareDirectories() is high (> 15) (gocyclo)

• Dominator/lib/awsutil/iterators.go
  • Line 42: warning: cyclomatic complexity 20 of function (*CredentialsStore).forEachTarget() is high (> 15) (gocyclo)

• Dominator/imagebuilder/builder/processManifest.go
  • Line 123: warning: cyclomatic complexity 17 of function processManifest() is high (> 15) (gocyclo)

• Dominator/dom/herd/sub.go
  • Line 265: warning: cyclomatic complexity 46 of function (*Sub).poll() is high (> 15) (gocyclo)
  • Line 98: warning: cyclomatic complexity 17 of function (*Sub).connectAndPoll() is high (> 15) (gocyclo)

• Dominator/fleetmanager/hypervisors/update.go
  • Line 489: warning: cyclomatic complexity 22 of function (*Manager).processAddressPoolUpdates() is high (> 15) (gocyclo)

• Dominator/cmd/vm-control/exportVirshVm.go
  • Line 30: warning: cyclomatic complexity 16 of function (vmExporterVirsh).createVm() is high (> 15) (gocyclo)

• Dominator/hypervisor/manager/start.go
  • Line 33: warning: cyclomatic complexity 31 of function newManager() is high (> 15) (gocyclo)

• Dominator/objectserver/rpcd/lib/addObjectsWithMaster.go
  • Line 18: warning: cyclomatic complexity 19 of function addObjectsWithMaster() is high (> 15) (gocyclo)

golint65%

Golint is a linter for Go source code.

• Dominator/lib/srpc/client.go
  • Line 111: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/imagebuilder/builder/bootstrapImage.go
  • Line 94: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/connpool/api.go
  • Line 1: warning: package comment should not have leading space (golint)

• Dominator/lib/filesystem/util/unpack.go
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 50: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 273: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/terminal/client/impl.go
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/objectserver/filesystem/scan/scan.go
  • Line 16: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/logbuf/impl.go
  • Line 103: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/sub/rpcd/poll.go
  • Line 73: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/mdbd/httpd.go
  • Line 15: warning: exported type HtmlWriter should have comment or be unexported (golint)

• Dominator/cmd/installer/lib.go
  • Line 29: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/tftpbootd/api.go
  • Line 19: warning: exported type TftpbootServer should have comment or be unexported (golint)
  • Line 33: warning: exported function New should have comment or be unexported (golint)
  • Line 38: warning: exported method TftpbootServer.RegisterFiles should have comment or be unexported (golint)
  • Line 42: warning: exported method TftpbootServer.SetImageStreamName should have comment or be unexported (golint)
  • Line 46: warning: exported method TftpbootServer.UnregisterFiles should have comment or be unexported (golint)

• Dominator/lib/logbuf/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 48: warning: exported type Options should have comment or be unexported (golint)

• Dominator/lib/objectserver/cachingreader/lru.go
  • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/slavedriver/smallstack/impl.go
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/objectserver/filesystem/add.go
  • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 77: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/lib/rpcclientpool/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 47: warning: exported method Client.Call should have comment or be unexported (golint)
  • Line 58: warning: exported method Client.Go should have comment or be unexported (golint)
  • Line 75: warning: exported type ClientResource should have comment or be unexported (golint)

• Dominator/cmd/hyper-control/reinstall.go
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imagebuilder/httpd/api.go
  • Line 13: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 23: warning: exported function StartServer should have comment or be unexported (golint)
  • Line 43: warning: exported function AddHtmlWriter should have comment or be unexported (golint)

• Dominator/lib/awsutil/accounts.go
  • Line 17: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 26: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filegen/util/api.go
  • Line 7: warning: exported function LoadConfiguration should have comment or be unexported (golint)

• Dominator/lib/flagutil/size.go
  • Line 48: warning: exported method Size.Set should have comment or be unexported (golint)
  • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/mdb/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 13: warning: exported type AwsMetadata should have comment or be unexported (golint)
  • Line 34: warning: exported method Machine.Compare should have comment or be unexported (golint)
  • Line 39: warning: receiver name dest should be consistent with previous receiver name left for Machine (golint)

• Dominator/fleetmanager/hypervisors/fsstorer/mutate.go
  • Line 35: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 85: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/changeVmTags.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/pprof/api.go
  • Line 3: warning: exported function StartCpuProfile should have comment or be unexported (golint)
  • Line 7: warning: exported function StopCpuProfile should have comment or be unexported (golint)

• Dominator/lib/pprof/impl.go
  • Line 18: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/reverseconnection/dialer.go
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/proto/hypervisor/messages.go
  • Line 11: warning: exported const ConsoleNone should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type AcknowledgeVmRequest should have comment or be unexported (golint)
  • Line 32: warning: exported type AcknowledgeVmResponse should have comment or be unexported (golint)
  • Line 36: warning: exported type Address should have comment or be unexported (golint)
  • Line 41: warning: exported type BecomePrimaryVmOwnerRequest should have comment or be unexported (golint)
  • Line 45: warning: exported type BecomePrimaryVmOwnerResponse should have comment or be unexported (golint)
  • Line 49: warning: exported type ChangeAddressPoolRequest should have comment or be unexported (golint)
  • Line 55: warning: exported type ChangeAddressPoolResponse should have comment or be unexported (golint)
  • Line 59: warning: exported type ChangeOwnersRequest should have comment or be unexported (golint)
  • Line 64: warning: exported type ChangeOwnersResponse should have comment or be unexported (golint)
  • Line 68: warning: exported type ChangeVmConsoleTypeRequest should have comment or be unexported (golint)
  • Line 73: warning: exported type ChangeVmConsoleTypeResponse should have comment or be unexported (golint)
  • Line 77: warning: exported type ChangeVmDestroyProtectionRequest should have comment or be unexported (golint)
  • Line 82: warning: exported type ChangeVmDestroyProtectionResponse should have comment or be unexported (golint)
  • Line 86: warning: exported type ChangeVmOwnerUsersRequest should have comment or be unexported (golint)
  • Line 91: warning: exported type ChangeVmOwnerUsersResponse should have comment or be unexported (golint)
  • Line 95: warning: exported type ChangeVmTagsRequest should have comment or be unexported (golint)
  • Line 100: warning: exported type ChangeVmTagsResponse should have comment or be unexported (golint)
  • Line 104: warning: exported type CommitImportedVmRequest should have comment or be unexported (golint)
  • Line 108: warning: exported type CommitImportedVmResponse should have comment or be unexported (golint)
  • Line 112: warning: comment on exported type ConnectToVmConsoleRequest should be of the form "ConnectToVmConsoleRequest ..." (with optional leading article) (golint)
  • Line 119: warning: exported type ConnectToVmConsoleResponse should have comment or be unexported (golint)
  • Line 123: warning: comment on exported type ConnectToVmSerialPortRequest should be of the form "ConnectToVmSerialPortRequest ..." (with optional leading article) (golint)
  • Line 131: warning: exported type ConnectToVmSerialPortResponse should have comment or be unexported (golint)
  • Line 135: warning: exported type ConsoleType should have comment or be unexported (golint)
  • Line 137: warning: exported type CopyVmRequest should have comment or be unexported (golint)
  • Line 144: warning: exported type CopyVmResponse should have comment or be unexported (golint)
  • Line 151: warning: exported type CreateVmRequest should have comment or be unexported (golint)
  • Line 164: warning: exported type CreateVmResponse should have comment or be unexported (golint)
  • Line 172: warning: exported type DeleteVmVolumeRequest should have comment or be unexported (golint)
  • Line 178: warning: exported type DeleteVmVolumeResponse should have comment or be unexported (golint)
  • Line 182: warning: exported type DestroyVmRequest should have comment or be unexported (golint)
  • Line 187: warning: exported type DestroyVmResponse should have comment or be unexported (golint)
  • Line 191: warning: exported type DiscardVmAccessTokenRequest should have comment or be unexported (golint)
  • Line 196: warning: exported type DiscardVmAccessTokenResponse should have comment or be unexported (golint)
  • Line 200: warning: exported type DiscardVmOldImageRequest should have comment or be unexported (golint)
  • Line 204: warning: exported type DiscardVmOldImageResponse should have comment or be unexported (golint)
  • Line 208: warning: exported type DiscardVmOldUserDataRequest should have comment or be unexported (golint)
  • Line 212: warning: exported type DiscardVmOldUserDataResponse should have comment or be unexported (golint)
  • Line 216: warning: exported type DiscardVmSnapshotRequest should have comment or be unexported (golint)
  • Line 220: warning: exported type DiscardVmSnapshotResponse should have comment or be unexported (golint)
  • Line 224: warning: exported type ExportLocalVmInfo should have comment or be unexported (golint)
  • Line 229: warning: exported type ExportLocalVmRequest should have comment or be unexported (golint)
  • Line 234: warning: exported type ExportLocalVmResponse should have comment or be unexported (golint)
  • Line 243: warning: exported type GetUpdateRequest should have comment or be unexported (golint)
  • Line 245: warning: exported type Update should have comment or be unexported (golint)
  • Line 258: warning: exported type GetVmAccessTokenRequest should have comment or be unexported (golint)
  • Line 263: warning: exported type GetVmAccessTokenResponse should have comment or be unexported (golint)
  • Line 268: warning: exported type GetVmInfoRequest should have comment or be unexported (golint)
  • Line 272: warning: exported type GetVmInfoResponse should have comment or be unexported (golint)
  • Line 277: warning: exported type GetVmUserDataRequest should have comment or be unexported (golint)
  • Line 282: warning: exported type GetVmUserDataResponse should have comment or be unexported (golint)
  • Line 289: warning: exported type GetVmVolumeRequest should have comment or be unexported (golint)
  • Line 295: warning: exported type GetVmVolumeResponse should have comment or be unexported (golint)
  • Line 299: warning: exported type ImportLocalVmRequest should have comment or be unexported (golint)
  • Line 305: warning: exported type ImportLocalVmResponse should have comment or be unexported (golint)
  • Line 309: warning: exported type ListVMsRequest should have comment or be unexported (golint)
  • Line 314: warning: exported type ListVMsResponse should have comment or be unexported (golint)
  • Line 318: warning: exported type ListVolumeDirectoriesRequest should have comment or be unexported (golint)
  • Line 320: warning: exported type ListVolumeDirectoriesResponse should have comment or be unexported (golint)
  • Line 325: warning: exported type LocalVolume should have comment or be unexported (golint)
  • Line 330: warning: exported type LocalVmInfo should have comment or be unexported (golint)
  • Line 335: warning: exported type MigrateVmRequest should have comment or be unexported (golint)
  • Line 342: warning: exported type MigrateVmResponse should have comment or be unexported (golint)
  • Line 349: warning: exported type MigrateVmResponseResponse should have comment or be unexported (golint)
  • Line 353: warning: exported type NetbootMachineRequest should have comment or be unexported (golint)
  • Line 364: warning: exported type NetbootMachineResponse should have comment or be unexported (golint)
  • Line 368: warning: exported type PatchVmImageRequest should have comment or be unexported (golint)
  • Line 374: warning: exported type PatchVmImageResponse should have comment or be unexported (golint)
  • Line 380: warning: exported type PrepareVmForMigrationRequest should have comment or be unexported (golint)
  • Line 386: warning: exported type PrepareVmForMigrationResponse should have comment or be unexported (golint)
  • Line 390: warning: exported type ProbeVmPortRequest should have comment or be unexported (golint)
  • Line 396: warning: exported type ProbeVmPortResponse should have comment or be unexported (golint)
  • Line 401: warning: exported type ReplaceVmImageRequest should have comment or be unexported (golint)
  • Line 413: warning: exported type ReplaceVmImageResponse should have comment or be unexported (golint)
  • Line 420: warning: exported type ReplaceVmUserDataRequest should have comment or be unexported (golint)
  • Line 425: warning: exported type ReplaceVmUserDataResponse should have comment or be unexported (golint)
  • Line 429: warning: exported type RestoreVmFromSnapshotRequest should have comment or be unexported (golint)
  • Line 434: warning: exported type RestoreVmFromSnapshotResponse should have comment or be unexported (golint)
  • Line 438: warning: exported type RestoreVmImageRequest should have comment or be unexported (golint)
  • Line 442: warning: exported type RestoreVmImageResponse should have comment or be unexported (golint)
  • Line 446: warning: exported type RestoreVmUserDataRequest should have comment or be unexported (golint)
  • Line 450: warning: exported type RestoreVmUserDataResponse should have comment or be unexported (golint)
  • Line 454: warning: exported type SnapshotVmRequest should have comment or be unexported (golint)
  • Line 460: warning: exported type SnapshotVmResponse should have comment or be unexported (golint)
  • Line 464: warning: exported type StartVmRequest should have comment or be unexported (golint)
  • Line 470: warning: exported type StartVmResponse should have comment or be unexported (golint)
  • Line 475: warning: exported type StopVmRequest should have comment or be unexported (golint)
  • Line 480: warning: exported type StopVmResponse should have comment or be unexported (golint)
  • Line 484: warning: exported type State should have comment or be unexported (golint)
  • Line 486: warning: exported type Subnet should have comment or be unexported (golint)
  • Line 498: warning: exported type TraceVmMetadataRequest should have comment or be unexported (golint)
  • Line 502: warning: exported type TraceVmMetadataResponse should have comment or be unexported (golint)
  • Line 506: warning: exported type UpdateSubnetsRequest should have comment or be unexported (golint)
  • Line 512: warning: exported type UpdateSubnetsResponse should have comment or be unexported (golint)
  • Line 516: warning: exported type VmInfo should have comment or be unexported (golint)
  • Line 538: warning: exported type Volume should have comment or be unexported (golint)
  • Line 543: warning: exported type VolumeFormat should have comment or be unexported (golint)

• Dominator/lib/log/debuglogger/api.go
  • Line 7: warning: exported type Logger should have comment or be unexported (golint)

• Dominator/lib/filesystem/api.go
  • Line 12: warning: exported type NumLinksTable should have comment or be unexported (golint)
  • Line 14: warning: exported type ListSelector should have comment or be unexported (golint)
  • Line 17: warning: exported const ListSelectSkipMode should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported type GenericInode should have comment or be unexported (golint)
  • Line 39: warning: exported type InodeTable should have comment or be unexported (golint)
  • Line 40: warning: exported type InodeToFilenamesTable should have comment or be unexported (golint)
  • Line 41: warning: exported type FilenameToInodeTable should have comment or be unexported (golint)
  • Line 42: warning: exported type HashToInodesTable should have comment or be unexported (golint)
  • Line 44: warning: exported type FileSystem should have comment or be unexported (golint)
  • Line 56: warning: exported function Decode should have comment or be unexported (golint)
  • Line 60: warning: exported method FileSystem.ComputeTotalDataBytes should have comment or be unexported (golint)
  • Line 64: warning: exported method FileSystem.Encode should have comment or be unexported (golint)
  • Line 68: warning: exported method FileSystem.EstimateUsage should have comment or be unexported (golint)
  • Line 72: warning: exported method FileSystem.FilenameToInodeTable should have comment or be unexported (golint)
  • Line 76: warning: exported method FileSystem.Filter should have comment or be unexported (golint)
  • Line 80: warning: exported method FileSystem.ForEachFile should have comment or be unexported (golint)
  • Line 85: warning: exported method FileSystem.GetObjects should have comment or be unexported (golint)
  • Line 89: warning: exported method FileSystem.HashToInodesTable should have comment or be unexported (golint)
  • Line 93: warning: exported method FileSystem.InodeToFilenamesTable should have comment or be unexported (golint)
  • Line 97: warning: exported method FileSystem.List should have comment or be unexported (golint)
  • Line 101: warning: exported method FileSystem.Listf should have comment or be unexported (golint)
  • Line 106: warning: exported method FileSystem.NumComputedRegularInodes should have comment or be unexported (golint)
  • Line 110: warning: exported method FileSystem.RebuildInodePointers should have comment or be unexported (golint)
  • Line 121: warning: exported type DirectoryInode should have comment or be unexported (golint)
  • Line 129: warning: exported method DirectoryInode.BuildEntryMap should have comment or be unexported (golint)
  • Line 133: warning: exported method DirectoryInode.GetGid should have comment or be unexported (golint)
  • Line 133: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 137: warning: exported method DirectoryInode.GetUid should have comment or be unexported (golint)
  • Line 137: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 141: warning: exported method DirectoryInode.List should have comment or be unexported (golint)
  • Line 141: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 147: warning: exported method DirectoryInode.ReplaceStrings should have comment or be unexported (golint)
  • Line 147: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 151: warning: exported method DirectoryInode.SetGid should have comment or be unexported (golint)
  • Line 151: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 155: warning: exported method DirectoryInode.SetUid should have comment or be unexported (golint)
  • Line 155: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 159: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 163: warning: exported method DirectoryInode.WriteMetadata should have comment or be unexported (golint)
  • Line 163: warning: receiver name inode should be consistent with previous receiver name directory for DirectoryInode (golint)
  • Line 167: warning: exported type DirectoryEntry should have comment or be unexported (golint)
  • Line 173: warning: exported method DirectoryEntry.Inode should have comment or be unexported (golint)
  • Line 177: warning: exported method DirectoryEntry.SetInode should have comment or be unexported (golint)
  • Line 185: warning: exported type RegularInode should have comment or be unexported (golint)
  • Line 195: warning: exported method RegularInode.GetGid should have comment or be unexported (golint)
  • Line 199: warning: exported method RegularInode.GetUid should have comment or be unexported (golint)
  • Line 203: warning: exported method RegularInode.List should have comment or be unexported (golint)
  • Line 209: warning: exported method RegularInode.SetGid should have comment or be unexported (golint)
  • Line 213: warning: exported method RegularInode.SetUid should have comment or be unexported (golint)
  • Line 217: warning: exported method RegularInode.WriteMetadata should have comment or be unexported (golint)
  • Line 221: warning: exported type ComputedRegularInode should have comment or be unexported (golint)
  • Line 228: warning: exported method ComputedRegularInode.GetGid should have comment or be unexported (golint)
  • Line 232: warning: exported method ComputedRegularInode.GetUid should have comment or be unexported (golint)
  • Line 236: warning: exported method ComputedRegularInode.List should have comment or be unexported (golint)
  • Line 242: warning: exported method ComputedRegularInode.SetGid should have comment or be unexported (golint)
  • Line 246: warning: exported method ComputedRegularInode.SetUid should have comment or be unexported (golint)
  • Line 250: warning: exported method ComputedRegularInode.WriteMetadata should have comment or be unexported (golint)
  • Line 254: warning: exported type SymlinkInode should have comment or be unexported (golint)
  • Line 260: warning: exported method SymlinkInode.GetGid should have comment or be unexported (golint)
  • Line 264: warning: exported method SymlinkInode.GetUid should have comment or be unexported (golint)
  • Line 268: warning: exported method SymlinkInode.List should have comment or be unexported (golint)
  • Line 274: warning: exported method SymlinkInode.SetGid should have comment or be unexported (golint)
  • Line 278: warning: exported method SymlinkInode.SetUid should have comment or be unexported (golint)
  • Line 286: warning: exported method SymlinkInode.WriteMetadata should have comment or be unexported (golint)
  • Line 290: warning: exported type SpecialInode should have comment or be unexported (golint)
  • Line 299: warning: exported method SpecialInode.GetGid should have comment or be unexported (golint)
  • Line 303: warning: exported method SpecialInode.GetUid should have comment or be unexported (golint)
  • Line 307: warning: exported method SpecialInode.List should have comment or be unexported (golint)
  • Line 313: warning: exported method SpecialInode.SetGid should have comment or be unexported (golint)
  • Line 317: warning: exported method SpecialInode.SetUid should have comment or be unexported (golint)
  • Line 325: warning: exported method SpecialInode.WriteMetadata should have comment or be unexported (golint)
  • Line 329: warning: exported type FileMode should have comment or be unexported (golint)
  • Line 335: warning: exported function CompareFileSystems should have comment or be unexported (golint)
  • Line 339: warning: exported function CompareDirectoryInodes should have comment or be unexported (golint)
  • Line 344: warning: exported function CompareDirectoriesMetadata should have comment or be unexported (golint)
  • Line 349: warning: exported function CompareDirectoryEntries should have comment or be unexported (golint)
  • Line 354: warning: exported function CompareInodes should have comment or be unexported (golint)
  • Line 359: warning: exported function CompareRegularInodes should have comment or be unexported (golint)
  • Line 363: warning: exported function CompareRegularInodesMetadata should have comment or be unexported (golint)
  • Line 368: warning: exported function CompareRegularInodesData should have comment or be unexported (golint)
  • Line 373: warning: exported function CompareSymlinkInodes should have comment or be unexported (golint)
  • Line 377: warning: exported function CompareSymlinkInodesMetadata should have comment or be unexported (golint)
  • Line 382: warning: exported function CompareSymlinkInodesData should have comment or be unexported (golint)
  • Line 387: warning: exported function CompareSpecialInodes should have comment or be unexported (golint)
  • Line 391: warning: exported function CompareSpecialInodesMetadata should have comment or be unexported (golint)
  • Line 396: warning: exported function CompareSpecialInodesData should have comment or be unexported (golint)
  • Line 401: warning: exported function ForceWriteMetadata should have comment or be unexported (golint)

• Dominator/cmd/scan/main.go
  • Line 68: warning: don't use underscores in Go names; var prev_fs should be prevFs (golint)

• Dominator/lib/configwatch/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 13: warning: exported type Decoder should have comment or be unexported (golint)

• Dominator/lib/awsutil/tags.go
  • Line 18: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/imagebuilder/builder/html.go
  • Line 238: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/connectToVmSerialPort.go
  • Line 25: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/getVmVolume.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/util/getResolverConfiguration.go
  • Line 40: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/fleetmanager/topology/api.go
  • Line 13: warning: exported type Directory should have comment or be unexported (golint)
  • Line 26: warning: exported method Directory.GetPath should have comment or be unexported (golint)
  • Line 30: warning: exported method Directory.Walk should have comment or be unexported (golint)
  • Line 39: warning: exported type Subnet should have comment or be unexported (golint)
  • Line 47: warning: exported method Subnet.CheckIfIpIsReserved should have comment or be unexported (golint)
  • Line 52: warning: exported method Subnet.Shrink should have comment or be unexported (golint)
  • Line 52: warning: receiver name subnet should be consistent with previous receiver name s for Subnet (golint)
  • Line 56: warning: exported type Topology should have comment or be unexported (golint)
  • Line 62: warning: exported function Load should have comment or be unexported (golint)
  • Line 66: warning: exported function Watch should have comment or be unexported (golint)
  • Line 73: warning: exported method Topology.CheckIfIpIsReserved should have comment or be unexported (golint)
  • Line 78: warning: exported method Topology.CheckIfMachineHasSubnet should have comment or be unexported (golint)
  • Line 83: warning: exported method Topology.FindDirectory should have comment or be unexported (golint)
  • Line 87: warning: exported method Topology.GetLocationOfMachine should have comment or be unexported (golint)
  • Line 91: warning: exported method Topology.GetNumMachines should have comment or be unexported (golint)
  • Line 95: warning: exported method Topology.GetSubnetsForMachine should have comment or be unexported (golint)
  • Line 99: warning: exported method Topology.ListMachines should have comment or be unexported (golint)
  • Line 103: warning: exported method Topology.Walk should have comment or be unexported (golint)

• Dominator/cmd/installer/configureStorage.go
  • Line 189: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 382: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 394: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 517: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 552: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 560: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 576: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 607: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/hash/api.go
  • Line 3: warning: exported type Hash should have comment or be unexported (golint)
  • Line 5: warning: exported method Hash.MarshalText should have comment or be unexported (golint)

• Dominator/lib/fsrateio/api.go
  • Line 11: warning: exported type ReaderContext should have comment or be unexported (golint)
  • Line 17: warning: exported function NewReaderContext should have comment or be unexported (golint)
  • Line 22: warning: exported method ReaderContext.GetContext should have comment or be unexported (golint)
  • Line 24: warning: exported method ReaderContext.NewReader should have comment or be unexported (golint)
  • Line 28: warning: exported method ReaderContext.RegisterMetrics should have comment or be unexported (golint)

• Dominator/cmd/vm-control/exportVirshVm.go
  • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/manager/memory.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/client/impl.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/srpc/clientProxy.go
  • Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 150: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/fleetmanager/hypervisors/fsstorer/load.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 61: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 105: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/fleetmanager/hypervisors/ipmi.go
  • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/cmd/vm-control/migrateVm.go
  • Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/stringutil/dedup.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/reverseconnection/api.go
  • Line 23: warning: exported type Dialer should have comment or be unexported (golint)
  • Line 34: warning: exported type Listener should have comment or be unexported (golint)
  • Line 60: warning: exported method Listener.Accept should have comment or be unexported (golint)
  • Line 64: warning: exported method Listener.Addr should have comment or be unexported (golint)
  • Line 68: warning: exported method Listener.Close should have comment or be unexported (golint)

• Dominator/imageserver/client/api.go
  • Line 11: warning: exported function AddImage should have comment or be unexported (golint)
  • Line 15: warning: exported function AddImageTrusted should have comment or be unexported (golint)
  • Line 19: warning: exported function ChangeImageExpiration should have comment or be unexported (golint)
  • Line 24: warning: exported function CheckDirectory should have comment or be unexported (golint)
  • Line 28: warning: exported function CheckImage should have comment or be unexported (golint)
  • Line 32: warning: exported function ChownDirectory should have comment or be unexported (golint)
  • Line 36: warning: exported function DeleteImage should have comment or be unexported (golint)
  • Line 40: warning: exported function DeleteUnreferencedObjects should have comment or be unexported (golint)
  • Line 45: warning: exported function FindLatestImage should have comment or be unexported (golint)
  • Line 50: warning: exported function GetImage should have comment or be unexported (golint)
  • Line 54: warning: exported function GetImageExpiration should have comment or be unexported (golint)
  • Line 58: warning: exported function GetImageWithTimeout should have comment or be unexported (golint)
  • Line 63: warning: exported function ListDirectories should have comment or be unexported (golint)
  • Line 67: warning: exported function ListImages should have comment or be unexported (golint)
  • Line 71: warning: exported function ListUnreferencedObjects should have comment or be unexported (golint)
  • Line 76: warning: exported function MakeDirectory should have comment or be unexported (golint)

• Dominator/cmd/mdbd/server.go
  • Line 73: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/imagebuilder/builder/api.go
  • Line 97: warning: exported type Builder should have comment or be unexported (golint)
  • Line 115: warning: exported function Load should have comment or be unexported (golint)
  • Line 122: warning: exported method Builder.BuildImage should have comment or be unexported (golint)
  • Line 128: warning: exported method Builder.GetCurrentBuildLog should have comment or be unexported (golint)
  • Line 132: warning: exported method Builder.GetLatestBuildLog should have comment or be unexported (golint)
  • Line 136: warning: exported method Builder.ShowImageStream should have comment or be unexported (golint)
  • Line 140: warning: exported method Builder.ShowImageStreams should have comment or be unexported (golint)
  • Line 144: warning: exported method Builder.WriteHtml should have comment or be unexported (golint)
  • Line 148: warning: exported function BuildImageFromManifest should have comment or be unexported (golint)
  • Line 161: warning: exported function BuildTreeFromManifest should have comment or be unexported (golint)
  • Line 167: warning: exported function ProcessManifest should have comment or be unexported (golint)
  • Line 172: warning: exported function UnpackImageAndProcessManifest should have comment or be unexported (golint)

• Dominator/cmd/imagetool/getFileInImage.go
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/cmd/hyper-control/rolloutImage.go
  • Line 94: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 143: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 336: warning: don't use underscores in Go names; range var hypervisor_ should be hypervisor (golint)
  • Line 477: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 480: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 573: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/cmd/vm-control/discardVmSnapshot.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filesystem/util/replaceComputedFiles.go
  • Line 162: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 193: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/netspeed/api.go
  • Line 3: warning: exported function GetSpeedToAddress should have comment or be unexported (golint)
  • Line 7: warning: exported function GetSpeedToHost should have comment or be unexported (golint)

• Dominator/lib/objectserver/memory/api.go
  • Line 11: warning: exported type ObjectServer should have comment or be unexported (golint)
  • Line 16: warning: exported function NewObjectServer should have comment or be unexported (golint)
  • Line 20: warning: exported method ObjectServer.AddObject should have comment or be unexported (golint)
  • Line 25: warning: exported method ObjectServer.CheckObjects should have comment or be unexported (golint)
  • Line 29: warning: exported method ObjectServer.GetObject should have comment or be unexported (golint)
  • Line 34: warning: exported method ObjectServer.GetObjects should have comment or be unexported (golint)
  • Line 39: warning: exported method ObjectServer.ListObjectSizes should have comment or be unexported (golint)
  • Line 43: warning: exported method ObjectServer.ListObjects should have comment or be unexported (golint)
  • Line 47: warning: exported method ObjectServer.NumObjects should have comment or be unexported (golint)
  • Line 53: warning: exported type ObjectsReader should have comment or be unexported (golint)
  • Line 60: warning: exported method ObjectsReader.Close should have comment or be unexported (golint)
  • Line 64: warning: exported method ObjectsReader.NextObject should have comment or be unexported (golint)
  • Line 68: warning: exported method ObjectsReader.ObjectSizes should have comment or be unexported (golint)

• Dominator/lib/srpc/serverutil/perUserMethodLimiter.go
  • Line 31: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 39: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/manager/subnets.go
  • Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 184: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/restoreVmImage.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/manager/addressPool.go
  • Line 140: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 157: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/objectcache/api.go
  • Line 9: warning: exported type ObjectCache should have comment or be unexported (golint)
  • Line 11: warning: exported function ScanObjectCache should have comment or be unexported (golint)
  • Line 16: warning: exported function Decode should have comment or be unexported (golint)
  • Line 20: warning: exported method ObjectCache.Encode should have comment or be unexported (golint)
  • Line 24: warning: exported function CompareObjects should have comment or be unexported (golint)
  • Line 28: warning: exported function FilenameToHash should have comment or be unexported (golint)
  • Line 32: warning: exported function HashToFilename should have comment or be unexported (golint)
  • Line 36: warning: exported function ObjectMapToCache should have comment or be unexported (golint)
  • Line 40: warning: exported function ReadObject should have comment or be unexported (golint)

• Dominator/lib/objectserver/api.go
  • Line 10: warning: exported type FullObjectServer should have comment or be unexported (golint)
  • Line 19: warning: exported type AddCallback should have comment or be unexported (golint)
  • Line 21: warning: exported type AddCallbackSetter should have comment or be unexported (golint)
  • Line 25: warning: exported type GarbageCollector should have comment or be unexported (golint)
  • Line 28: warning: exported type GarbageCollectorSetter should have comment or be unexported (golint)
  • Line 32: warning: exported type ObjectLinker should have comment or be unexported (golint)
  • Line 36: warning: exported type ObjectGetter should have comment or be unexported (golint)
  • Line 40: warning: exported type ObjectsChecker should have comment or be unexported (golint)
  • Line 44: warning: exported type ObjectsGetter should have comment or be unexported (golint)
  • Line 48: warning: exported type FullObjectsReader should have comment or be unexported (golint)
  • Line 53: warning: exported type ObjectsReader should have comment or be unexported (golint)
  • Line 58: warning: exported type ObjectServer should have comment or be unexported (golint)
  • Line 66: warning: exported type StashingObjectServer should have comment or be unexported (golint)
  • Line 74: warning: exported function CopyObject should have comment or be unexported (golint)
  • Line 79: warning: exported function GetObject should have comment or be unexported (golint)
  • Line 84: warning: exported function LinkObject should have comment or be unexported (golint)

• Dominator/proto/proxy/messages.go
  • Line 5: warning: exported type ConnectRequest should have comment or be unexported (golint)
  • Line 11: warning: exported type ConnectResponse should have comment or be unexported (golint)

• Dominator/hypervisor/rpcd/connectToVmSerialPort.go
  • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/mdbd/loadHypervisor.go
  • Line 70: warning: don't use underscores in Go names; method parameter unused_datacentre should be unusedDatacentre (golint)

• Dominator/imageserver/scanner/load.go
  • Line 30: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 34: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/lib/net/proxy/common.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/objectserver/client/getObjects.go
  • Line 21: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/proto/mdbserver/messages.go
  • Line 13: warning: exported type MdbUpdate should have comment or be unexported (golint)

• Dominator/cmd/hypervisor/control.go
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imageserver/httpd/api.go
  • Line 14: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 25: warning: exported function StartServer should have comment or be unexported (golint)
  • Line 51: warning: exported function AddHtmlWriter should have comment or be unexported (golint)

• Dominator/lib/filegen/httpd/api.go
  • Line 13: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 23: warning: exported function StartServer should have comment or be unexported (golint)
  • Line 39: warning: exported function AddHtmlWriter should have comment or be unexported (golint)

• Dominator/lib/filesystem/util/computedFiles.go
  • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/slavedriver/impl.go
  • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 121: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/proto/rsync/messages.go
  • Line 7: warning: exported type GetBlocksRequest should have comment or be unexported (golint)
  • Line 12: warning: exported type Block should have comment or be unexported (golint)

• Dominator/cmd/hyper-control/netbootMachine.go
  • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/log/api.go
  • Line 3: warning: exported type Logger should have comment or be unexported (golint)
  • Line 15: warning: exported type DebugLogger should have comment or be unexported (golint)
  • Line 22: warning: exported type DebugLogLevelGetter should have comment or be unexported (golint)
  • Line 26: warning: exported type DebugLogLevelSetter should have comment or be unexported (golint)
  • Line 30: warning: exported type FullDebugLogger should have comment or be unexported (golint)

• Dominator/proto/sub/messages.go
  • Line 12: warning: exported type BoostCpuLimitRequest should have comment or be unexported (golint)
  • Line 14: warning: exported type BoostCpuLimitResponse should have comment or be unexported (golint)
  • Line 16: warning: exported type Configuration should have comment or be unexported (golint)
  • Line 23: warning: exported type FetchRequest should have comment or be unexported (golint)
  • Line 29: warning: exported type FetchResponse should have comment or be unexported (golint)
  • Line 31: warning: exported type GetConfigurationRequest should have comment or be unexported (golint)
  • Line 33: warning: exported type GetConfigurationResponse should have comment or be unexported (golint)
  • Line 41: warning: exported type GetFileResponse should have comment or be unexported (golint)
  • Line 46: warning: exported type PollRequest should have comment or be unexported (golint)
  • Line 51: warning: exported type PollResponse should have comment or be unexported (golint)
  • Line 71: warning: exported type SetConfigurationRequest should have comment or be unexported (golint)
  • Line 73: warning: exported type SetConfigurationResponse should have comment or be unexported (golint)
  • Line 75: warning: exported type FileToCopyToCache should have comment or be unexported (golint)
  • Line 81: warning: exported type Hardlink should have comment or be unexported (golint)
  • Line 86: warning: exported type Inode should have comment or be unexported (golint)
  • Line 91: warning: exported type UpdateRequest should have comment or be unexported (golint)
  • Line 105: warning: exported type UpdateResponse should have comment or be unexported (golint)
  • Line 107: warning: exported type CleanupRequest should have comment or be unexported (golint)
  • Line 111: warning: exported type CleanupResponse should have comment or be unexported (golint)

• Dominator/proto/logger/messages.go
  • Line 3: warning: exported type DebugRequest should have comment or be unexported (golint)
  • Line 9: warning: exported type DebugResponse should have comment or be unexported (golint)
  • Line 11: warning: exported type PrintRequest should have comment or be unexported (golint)
  • Line 16: warning: exported type PrintResponse should have comment or be unexported (golint)
  • Line 18: warning: exported type SetDebugLevelRequest should have comment or be unexported (golint)
  • Line 23: warning: exported type SetDebugLevelResponse should have comment or be unexported (golint)
  • Line 25: warning: exported type WatchRequest should have comment or be unexported (golint)
  • Line 32: warning: exported type WatchResponse should have comment or be unexported (golint)

• Dominator/cmd/subd/vCpu.go
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 31: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/errors/api.go
  • Line 5: warning: exported function New should have comment or be unexported (golint)
  • Line 12: warning: exported function ErrorToString should have comment or be unexported (golint)

• Dominator/lib/filegen/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 48: warning: exported type Manager should have comment or be unexported (golint)

• Dominator/lib/log/testlogger/api.go
  • Line 7: warning: exported type Logger should have comment or be unexported (golint)

• Dominator/lib/resourcepool/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 40: warning: exported var ErrorPutTimeout should have comment or be unexported (golint)

• Dominator/lib/srpc/setupclient/api.go
  • Line 1: warning: package comment should not have leading space (golint)

• Dominator/proto/test/messages.go
  • Line 3: warning: exported type EchoRequest should have comment or be unexported (golint)
  • Line 7: warning: exported type EchoResponse should have comment or be unexported (golint)

• Dominator/fleetmanager/hypervisors/fsstorer/check.go
  • Line 11: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imageunpacker/unpacker/addDevice.go
  • Line 103: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/cmd/objecttool/getObject.go
  • Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/meminfo/api.go
  • Line 3: warning: exported type MemInfo should have comment or be unexported (golint)
  • Line 9: warning: exported function GetMemInfo should have comment or be unexported (golint)

• Dominator/lib/net/api.go
  • Line 13: warning: exported const InterfaceTypeBonding should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type TCPConn should have comment or be unexported (golint)
  • Line 117: warning: comment on exported method MeasuringConnection.CumulativeWriteTime should be of the form "CumulativeWriteTime ..." (golint)

• Dominator/lib/rateio/reader.go
  • Line 12: warning: exported const DEFAULT_SPEED_PERCENT should have comment (or a comment on this block) or be unexported (golint)

• Dominator/dom/rpcd/api.go
  • Line 14: warning: exported function Setup should have comment or be unexported (golint)

• Dominator/fleetmanager/topology/check.go
  • Line 11: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/mbr/tableType.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 27: warning: receiver name tt should be consistent with previous receiver name tableType for TableType (golint)
  • Line 37: warning: receiver name tt should be consistent with previous receiver name tableType for TableType (golint)
  • Line 40: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/slavedriver/smallstack/api.go
  • Line 12: warning: exported type SlaveTrader should have comment or be unexported (golint)
  • Line 19: warning: exported function NewSlaveTrader should have comment or be unexported (golint)
  • Line 24: warning: exported method SlaveTrader.Close should have comment or be unexported (golint)
  • Line 28: warning: exported method SlaveTrader.CreateSlave should have comment or be unexported (golint)
  • Line 32: warning: exported method SlaveTrader.DestroySlave should have comment or be unexported (golint)

• Dominator/lib/objectserver/cachingreader/get.go
  • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 91: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 192: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/wsyscall/api.go
  • Line 6: warning: exported const MS_BIND should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported type Rusage should have comment or be unexported (golint)
  • Line 33: warning: don't use underscores in Go names; type Stat_t should be StatT (golint)
  • Line 33: warning: exported type Stat_t should have comment or be unexported (golint)
  • Line 49: warning: exported type Timeval should have comment or be unexported (golint)
  • Line 54: warning: exported function Fallocate should have comment or be unexported (golint)
  • Line 58: warning: exported function Ioctl should have comment or be unexported (golint)
  • Line 62: warning: exported function Lstat should have comment or be unexported (golint)
  • Line 66: warning: exported function Mount should have comment or be unexported (golint)
  • Line 71: warning: exported function Getrusage should have comment or be unexported (golint)
  • Line 75: warning: exported function SetAllGid should have comment or be unexported (golint)
  • Line 79: warning: exported function SetAllUid should have comment or be unexported (golint)
  • Line 83: warning: exported function SetNetNamespace should have comment or be unexported (golint)
  • Line 87: warning: exported function Stat should have comment or be unexported (golint)
  • Line 91: warning: exported function UnshareMountNamespace should have comment or be unexported (golint)
  • Line 95: warning: exported function UnshareNetNamespace should have comment or be unexported (golint)

• Dominator/hypervisor/dhcpd/api.go
  • Line 11: warning: exported type DhcpServer should have comment or be unexported (golint)
  • Line 30: warning: exported function New should have comment or be unexported (golint)
  • Line 34: warning: exported method DhcpServer.AddLease should have comment or be unexported (golint)
  • Line 40: warning: exported method DhcpServer.AddNetbootLease should have comment or be unexported (golint)
  • Line 45: warning: exported method DhcpServer.AddSubnet should have comment or be unexported (golint)
  • Line 49: warning: exported method DhcpServer.MakeAcknowledgmentChannel should have comment or be unexported (golint)
  • Line 53: warning: exported method DhcpServer.MakeRequestChannel should have comment or be unexported (golint)
  • Line 57: warning: exported method DhcpServer.RemoveLease should have comment or be unexported (golint)
  • Line 61: warning: exported method DhcpServer.RemoveSubnet should have comment or be unexported (golint)
  • Line 65: warning: exported method DhcpServer.SetNetworkBootImage should have comment or be unexported (golint)

• Dominator/cmd/imagetool/testDownloadSpeed.go
  • Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/mdbd/loadAws.go
  • Line 80: warning: don't use underscores in Go names; method parameter unused_datacentre should be unusedDatacentre (golint)

• Dominator/cmd/vm-control/importLocalVm.go
  • Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 179: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 184: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/log/serverlogger/impl.go
  • Line 284: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 297: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 309: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/proto/imaginator/messages.go
  • Line 9: warning: exported type BuildImageRequest should have comment or be unexported (golint)
  • Line 20: warning: exported type BuildImageResponse should have comment or be unexported (golint)

• Dominator/lib/net/createTapDevice_linux.go
  • Line 13: warning: don't use underscores in Go names; const cIFF_TUN should be cIFFTUN (golint)
  • Line 14: warning: don't use underscores in Go names; const cIFF_TAP should be cIFFTAP (golint)
  • Line 15: warning: don't use underscores in Go names; const cIFF_NO_PI should be cIFFNOPI (golint)
  • Line 16: warning: don't use underscores in Go names; const cIFF_MULTI_QUEUE should be cIFFMULTIQUEUE (golint)

• Dominator/lib/tags/api.go
  • Line 3: warning: exported type Tag should have comment or be unexported (golint)
  • Line 12: warning: exported method Tag.Set should have comment or be unexported (golint)
  • Line 16: warning: exported type Tags should have comment or be unexported (golint)
  • Line 18: warning: exported method Tags.Copy should have comment or be unexported (golint)
  • Line 22: warning: exported method Tags.Equal should have comment or be unexported (golint)
  • Line 22: warning: receiver name left should be consistent with previous receiver name tags for Tags (golint)
  • Line 26: warning: exported method Tags.Merge should have comment or be unexported (golint)
  • Line 26: warning: receiver name to should be consistent with previous receiver name tags for Tags (golint)
  • Line 34: warning: exported method Tags.Set should have comment or be unexported (golint)

• Dominator/dom/lib/buildMissingLists.go
  • Line 31: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imageunpacker/unpacker/associateWithDevice.go
  • Line 87: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/fleetmanager/topology/read.go
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 273: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 330: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 365: warning: receiver name to should be consistent with previous receiver name owners for ownersType (golint)

• Dominator/cmd/vm-control/destroyVm.go
  • Line 21: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/findHypervisor.go
  • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/image/api.go
  • Line 14: warning: exported type Annotation should have comment or be unexported (golint)
  • Line 19: warning: exported type DirectoryMetadata should have comment or be unexported (golint)
  • Line 23: warning: exported type Directory should have comment or be unexported (golint)
  • Line 28: warning: exported type Image should have comment or be unexported (golint)
  • Line 40: warning: exported type Package should have comment or be unexported (golint)
  • Line 61: warning: exported method Image.ListMissingObjects should have comment or be unexported (golint)
  • Line 72: warning: exported method Image.ReplaceStrings should have comment or be unexported (golint)
  • Line 82: warning: exported method Image.VerifyObjects should have comment or be unexported (golint)
  • Line 96: warning: exported function SortDirectories should have comment or be unexported (golint)

• Dominator/lib/wsyscall/wrappers_linux.go
  • Line 11: warning: don't use underscores in Go names; const sys_SETNS should be sysSETNS (golint)

• Dominator/cmd/vm-control/copyVm.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/startVm.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/proxy/socks.go
  • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/terminal/client/api.go
  • Line 7: warning: exported type FlushReadWriter should have comment or be unexported (golint)
  • Line 12: warning: exported function StartTerminal should have comment or be unexported (golint)

• Dominator/lib/x509util/api.go
  • Line 1: warning: package comment should not have leading space (golint)

• Dominator/fleetmanager/topology/list.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/objectserver/filesystem/check.go
  • Line 39: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/proto/imageunpacker/messages.go
  • Line 6: warning: exported const StatusStreamNoDevice should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: exported type DeviceInfo should have comment or be unexported (golint)
  • Line 31: warning: exported type AssociateStreamWithDeviceRequest should have comment or be unexported (golint)
  • Line 36: warning: exported type AssociateStreamWithDeviceResponse should have comment or be unexported (golint)
  • Line 38: warning: exported type ExportImageRequest should have comment or be unexported (golint)
  • Line 44: warning: exported type ExportImageResponse should have comment or be unexported (golint)
  • Line 46: warning: exported type GetStatusRequest should have comment or be unexported (golint)
  • Line 48: warning: exported type GetStatusResponse should have comment or be unexported (golint)
  • Line 54: warning: exported type ImageStreamInfo should have comment or be unexported (golint)
  • Line 59: warning: exported type PrepareForCaptureRequest should have comment or be unexported (golint)
  • Line 63: warning: exported type PrepareForCaptureResponse should have comment or be unexported (golint)
  • Line 65: warning: exported type PrepareForCopyRequest should have comment or be unexported (golint)
  • Line 69: warning: exported type PrepareForCopyResponse should have comment or be unexported (golint)
  • Line 71: warning: exported type PrepareForUnpackRequest should have comment or be unexported (golint)
  • Line 77: warning: exported type PrepareForUnpackResponse should have comment or be unexported (golint)
  • Line 79: warning: exported type RemoveDeviceRequest should have comment or be unexported (golint)
  • Line 83: warning: exported type RemoveDeviceResponse should have comment or be unexported (golint)
  • Line 85: warning: exported type StreamStatus should have comment or be unexported (golint)
  • Line 91: warning: exported type UnpackImageRequest should have comment or be unexported (golint)
  • Line 96: warning: exported type UnpackImageResponse should have comment or be unexported (golint)

• Dominator/dom/lib/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 26: warning: exported var ErrorFailedToGetObject should have comment or be unexported (golint)

• Dominator/fleetmanager/hypervisors/fsstorer/api.go
  • Line 12: warning: exported type IP should have comment or be unexported (golint)
  • Line 14: warning: exported type Storer should have comment or be unexported (golint)
  • Line 22: warning: exported function New should have comment or be unexported (golint)
  • Line 39: warning: exported method Storer.AddIPsForHypervisor should have comment or be unexported (golint)
  • Line 44: warning: exported method Storer.CheckIpIsRegistered should have comment or be unexported (golint)
  • Line 48: warning: exported method Storer.DeleteVm should have comment or be unexported (golint)
  • Line 52: warning: exported method Storer.GetHypervisorForIp should have comment or be unexported (golint)
  • Line 56: warning: exported method Storer.ListVMs should have comment or be unexported (golint)
  • Line 60: warning: exported method Storer.ReadMachineSerialNumber should have comment or be unexported (golint)
  • Line 64: warning: exported method Storer.ReadMachineTags should have comment or be unexported (golint)
  • Line 68: warning: exported method Storer.ReadVm should have comment or be unexported (golint)
  • Line 73: warning: exported method Storer.SetIPsForHypervisor should have comment or be unexported (golint)
  • Line 78: warning: exported method Storer.UnregisterHypervisor should have comment or be unexported (golint)
  • Line 82: warning: exported method Storer.WriteMachineSerialNumber should have comment or be unexported (golint)
  • Line 87: warning: exported method Storer.WriteMachineTags should have comment or be unexported (golint)
  • Line 91: warning: exported method Storer.WriteVm should have comment or be unexported (golint)

• Dominator/imageunpacker/unpacker/removeDevice.go
  • Line 13: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imagepublishers/amipublisher/unusedImages.go
  • Line 220: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 241: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/imagepublishers/amipublisher/usedImages.go
  • Line 144: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 157: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/cmd/vm-control/changeVmOwnerUsers.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/objectserver/client/addObject.go
  • Line 37: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 51: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/lib/objectserver/filesystem/stash.go
  • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/httpd/api.go
  • Line 13: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 23: warning: exported function StartServer should have comment or be unexported (golint)
  • Line 44: warning: exported function AddHtmlWriter should have comment or be unexported (golint)

• Dominator/cmd/imagetool/matchTriggers.go
  • Line 14: warning: error var quitEarly should have name of the form errFoo (golint)

• Dominator/cmd/hyper-control/getMachineInfo.go
  • Line 28: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/installer/configureNetwork.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 83: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/changeVmDestroyProtection.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/fsrateio/reader.go
  • Line 11: warning: exported type ReadMeasurer should have comment or be unexported (golint)
  • Line 20: warning: exported method ReadMeasurer.MeasureReadIO should have comment or be unexported (golint)
  • Line 32: warning: exported method ReadMeasurer.Reset should have comment or be unexported (golint)

• Dominator/lib/objectserver/cachingreader/api.go
  • Line 26: warning: exported type ObjectServer should have comment or be unexported (golint)
  • Line 42: warning: exported function NewObjectServer should have comment or be unexported (golint)
  • Line 47: warning: exported method ObjectServer.GetObjects should have comment or be unexported (golint)
  • Line 52: warning: exported method ObjectServer.LinkObject should have comment or be unexported (golint)
  • Line 57: warning: exported method ObjectServer.WriteHtml should have comment or be unexported (golint)

• Dominator/lib/url/urlutil/api.go
  • Line 17: warning: exported type CachedReadCloser should have comment or be unexported (golint)
  • Line 23: warning: exported method CachedReadCloser.Close should have comment or be unexported (golint)
  • Line 31: warning: exported method CachedReadCloser.SaveCache should have comment or be unexported (golint)

• Dominator/lib/srpc/server.go
  • Line 521: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/fleetmanager/rpcd/api.go
  • Line 24: warning: exported function Setup should have comment or be unexported (golint)

• Dominator/fleetmanager/hypervisors/update.go
  • Line 439: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/objectserver/rpcd/lib/api.go
  • Line 12: warning: exported type ObjectAdder should have comment or be unexported (golint)
  • Line 17: warning: exported function AddObjects should have comment or be unexported (golint)
  • Line 22: warning: exported function AddObjectsWithMaster should have comment or be unexported (golint)

• Dominator/proto/imageserver/messages.go
  • Line 10: warning: exported type AddImageRequest should have comment or be unexported (golint)
  • Line 15: warning: exported type AddImageResponse should have comment or be unexported (golint)
  • Line 17: warning: exported type ChangeImageExpirationRequest should have comment or be unexported (golint)
  • Line 22: warning: exported type ChangeImageExpirationResponse should have comment or be unexported (golint)
  • Line 26: warning: exported type ChangeOwnerRequest should have comment or be unexported (golint)
  • Line 31: warning: exported type ChangeOwnerResponse should have comment or be unexported (golint)
  • Line 33: warning: exported type CheckDirectoryRequest should have comment or be unexported (golint)
  • Line 37: warning: exported type CheckDirectoryResponse should have comment or be unexported (golint)
  • Line 41: warning: exported type CheckImageRequest should have comment or be unexported (golint)
  • Line 45: warning: exported type CheckImageResponse should have comment or be unexported (golint)
  • Line 49: warning: exported type DeleteImageRequest should have comment or be unexported (golint)
  • Line 53: warning: exported type DeleteImageResponse should have comment or be unexported (golint)
  • Line 55: warning: exported type DeleteUnreferencedObjectsRequest should have comment or be unexported (golint)
  • Line 60: warning: exported type DeleteUnreferencedObjectsResponse should have comment or be unexported (golint)
  • Line 62: warning: exported type FindLatestImageRequest should have comment or be unexported (golint)
  • Line 67: warning: exported type FindLatestImageResponse should have comment or be unexported (golint)
  • Line 72: warning: exported type GetImageExpirationRequest should have comment or be unexported (golint)
  • Line 76: warning: exported type GetImageExpirationResponse should have comment or be unexported (golint)
  • Line 81: warning: exported type GetImageRequest should have comment or be unexported (golint)
  • Line 88: warning: exported type GetImageResponse should have comment or be unexported (golint)
  • Line 93: warning: exported const OperationAddImage should have comment (or a comment on this block) or be unexported (golint)
  • Line 102: warning: exported type ImageUpdate should have comment or be unexported (golint)
  • Line 123: warning: exported type Object should have comment or be unexported (golint)
  • Line 128: warning: exported type MakeDirectoryRequest should have comment or be unexported (golint)
  • Line 132: warning: exported type MakeDirectoryResponse should have comment or be unexported (golint)

• Dominator/lib/log/teelogger/api.go
  • Line 14: warning: exported type Logger should have comment or be unexported (golint)
  • Line 19: warning: exported function New should have comment or be unexported (golint)
  • Line 23: warning: exported method Logger.Debug should have comment or be unexported (golint)
  • Line 28: warning: exported method Logger.Debugf should have comment or be unexported (golint)
  • Line 33: warning: exported method Logger.Debugln should have comment or be unexported (golint)
  • Line 38: warning: exported method Logger.Fatal should have comment or be unexported (golint)
  • Line 47: warning: exported method Logger.Fatalf should have comment or be unexported (golint)
  • Line 56: warning: exported method Logger.Fatalln should have comment or be unexported (golint)
  • Line 65: warning: exported method Logger.Panic should have comment or be unexported (golint)
  • Line 71: warning: exported method Logger.Panicf should have comment or be unexported (golint)
  • Line 77: warning: exported method Logger.Panicln should have comment or be unexported (golint)
  • Line 83: warning: exported method Logger.Print should have comment or be unexported (golint)
  • Line 89: warning: exported method Logger.Printf should have comment or be unexported (golint)
  • Line 95: warning: exported method Logger.Println should have comment or be unexported (golint)

• Dominator/proto/installer/messages.go
  • Line 4: warning: exported const FileSystemTypeExt4 should have comment (or a comment on this block) or be unexported (golint)
  • Line 7: warning: exported type FileSystemType should have comment or be unexported (golint)
  • Line 9: warning: exported type Partition should have comment or be unexported (golint)
  • Line 15: warning: exported type StorageLayout should have comment or be unexported (golint)

• Dominator/lib/constants/constants.go
  • Line 4: warning: exported const SubPortNumber should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported var RequiredPaths should have comment or be unexported (golint)
  • Line 33: warning: exported var ScanExcludeList should have comment or be unexported (golint)

• Dominator/lib/awsutil/regions.go
  • Line 39: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/proto/fleetmanager/messages.go
  • Line 10: warning: exported type ChangeMachineTagsRequest should have comment or be unexported (golint)
  • Line 15: warning: exported type ChangeMachineTagsResponse should have comment or be unexported (golint)
  • Line 19: warning: exported type GetHypervisorForVMRequest should have comment or be unexported (golint)
  • Line 23: warning: exported type GetHypervisorForVMResponse should have comment or be unexported (golint)
  • Line 28: warning: exported type GetMachineInfoRequest should have comment or be unexported (golint)
  • Line 32: warning: exported type GetMachineInfoResponse should have comment or be unexported (golint)
  • Line 43: warning: exported type GetUpdatesRequest should have comment or be unexported (golint)
  • Line 48: warning: exported type Update should have comment or be unexported (golint)
  • Line 56: warning: exported type HardwareAddr should have comment or be unexported (golint)
  • Line 58: warning: exported type ListHypervisorLocationsRequest should have comment or be unexported (golint)
  • Line 62: warning: exported type ListHypervisorLocationsResponse should have comment or be unexported (golint)
  • Line 67: warning: exported type ListHypervisorsInLocationRequest should have comment or be unexported (golint)
  • Line 73: warning: exported type ListHypervisorsInLocationResponse should have comment or be unexported (golint)
  • Line 78: warning: exported type ListVMsInLocationRequest should have comment or be unexported (golint)
  • Line 82: warning: comment on exported type ListVMsInLocationResponse should be of the form "ListVMsInLocationResponse ..." (with optional leading article) (golint)
  • Line 89: warning: exported type Machine should have comment or be unexported (golint)
  • Line 98: warning: exported type MoveIpAddressesRequest should have comment or be unexported (golint)
  • Line 103: warning: exported type MoveIpAddressesResponse should have comment or be unexported (golint)
  • Line 107: warning: exported type NetworkEntry should have comment or be unexported (golint)

• Dominator/hypervisor/rpcd/api.go
  • Line 13: warning: exported type DhcpServer should have comment or be unexported (golint)
  • Line 27: warning: exported type TftpbootServer should have comment or be unexported (golint)
  • Line 38: warning: exported function Setup should have comment or be unexported (golint)

• Dominator/fleetmanager/httpd/api.go
  • Line 15: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 19: warning: exported type Server should have comment or be unexported (golint)
  • Line 26: warning: exported function StartServer should have comment or be unexported (golint)
  • Line 37: warning: exported method Server.AddHtmlWriter should have comment or be unexported (golint)
  • Line 41: warning: exported method Server.UpdateTopology should have comment or be unexported (golint)

• Dominator/imageunpacker/unpacker/streamManager.go
  • Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/getVmInfo.go
  • Line 25: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 39: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/fsbench/fsbench.go
  • Line 18: warning: exported const BUFLEN should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported function GetDevnumForFile should have comment or be unexported (golint)
  • Line 43: warning: don't use underscores in Go names; var fi_list should be fiList (golint)
  • Line 101: warning: comment on exported function GetReadSpeed should be of the form "GetReadSpeed ..." (golint)
  • Line 117: warning: don't use underscores in Go names; var rusage_start should be rusageStart (golint)
  • Line 117: warning: don't use underscores in Go names; var rusage_stop should be rusageStop (golint)
  • Line 121: warning: don't use underscores in Go names; var time_start should be timeStart (golint)

• Dominator/cmd/installer/objects.go
  • Line 358: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/mdb/mdbd/watchd.go
  • Line 146: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/tags/tags.go
  • Line 31: warning: receiver name left should be consistent with previous receiver name tags for Tags (golint)
  • Line 43: warning: receiver name to should be consistent with previous receiver name tags for Tags (golint)

• Dominator/lib/url/last.go
  • Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imagebuilder/client/api.go
  • Line 10: warning: exported function BuildImage should have comment or be unexported (golint)

• Dominator/lib/bufwriter/api.go
  • Line 11: warning: exported type FlushWriter should have comment or be unexported (golint)
  • Line 16: warning: exported type Writer should have comment or be unexported (golint)
  • Line 38: warning: exported method Writer.Flush should have comment or be unexported (golint)

• Dominator/hypervisor/tftpbootd/impl.go
  • Line 207: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/replaceVmImage.go
  • Line 64: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 88: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/objectcache/filename.go
  • Line 11: warning: don't use underscores in Go names; var prev_nibble should be prevNibble (golint)

• Dominator/lib/net/util/api.go
  • Line 7: warning: exported type DefaultRouteInfo should have comment or be unexported (golint)
  • Line 13: warning: exported type ResolverConfiguration should have comment or be unexported (golint)
  • Line 19: warning: exported function GetDefaultRoute should have comment or be unexported (golint)
  • Line 23: warning: exported function GetMyIP should have comment or be unexported (golint)
  • Line 27: warning: exported function GetResolverConfiguration should have comment or be unexported (golint)
  • Line 31: warning: exported function ShrinkIP should have comment or be unexported (golint)

• Dominator/lib/verstr/api.go
  • Line 1: warning: package comment should not have leading space (golint)

• Dominator/fleetmanager/hypervisors/get.go
  • Line 17: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 33: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/imagetool/addImageCommon.go
  • Line 155: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filegen/client/api.go
  • Line 13: warning: exported type ComputedFile should have comment or be unexported (golint)
  • Line 23: warning: exported type Machine should have comment or be unexported (golint)
  • Line 44: warning: exported type Manager should have comment or be unexported (golint)

• Dominator/imageunpacker/httpd/api.go
  • Line 13: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 23: warning: exported function StartServer should have comment or be unexported (golint)
  • Line 40: warning: exported function AddHtmlWriter should have comment or be unexported (golint)

• Dominator/lib/filesystem/untar/api.go
  • Line 12: warning: exported type Hasher should have comment or be unexported (golint)
  • Line 16: warning: exported function Decode should have comment or be unexported (golint)

• Dominator/lib/log/cmdlogger/api.go
  • Line 10: warning: exported type Options should have comment or be unexported (golint)

• Dominator/proto/filegenerator/messages.go
  • Line 8: warning: exported type GetObjectRequest should have comment or be unexported (golint)
  • Line 12: warning: exported type YieldRequest should have comment or be unexported (golint)
  • Line 17: warning: exported type ClientRequest should have comment or be unexported (golint)
  • Line 22: warning: exported type GetObjectResponse should have comment or be unexported (golint)
  • Line 27: warning: exported type FileInfo should have comment or be unexported (golint)
  • Line 33: warning: exported type YieldResponse should have comment or be unexported (golint)

• Dominator/sub/httpd/api.go
  • Line 13: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 19: warning: exported function StartServer should have comment or be unexported (golint)
  • Line 36: warning: exported function AddHtmlWriter should have comment or be unexported (golint)

• Dominator/imagebuilder/rpcd/api.go
  • Line 24: warning: exported function Setup should have comment or be unexported (golint)

• Dominator/cmd/mdbd/loadFleetManager.go
  • Line 84: warning: don't use underscores in Go names; method parameter unused_datacentre should be unusedDatacentre (golint)

• Dominator/imageserver/scanner/api.go
  • Line 33: warning: exported type ImageDataBase should have comment or be unexported (golint)
  • Line 54: warning: exported function LoadImageDataBase should have comment or be unexported (golint)
  • Line 59: warning: exported method ImageDataBase.AddImage should have comment or be unexported (golint)
  • Line 64: warning: exported method ImageDataBase.ChangeImageExpiration should have comment or be unexported (golint)
  • Line 69: warning: exported method ImageDataBase.CheckDirectory should have comment or be unexported (golint)
  • Line 73: warning: exported method ImageDataBase.CheckImage should have comment or be unexported (golint)
  • Line 77: warning: exported method ImageDataBase.ChownDirectory should have comment or be unexported (golint)
  • Line 82: warning: exported method ImageDataBase.CountDirectories should have comment or be unexported (golint)
  • Line 86: warning: exported method ImageDataBase.CountImages should have comment or be unexported (golint)
  • Line 90: warning: exported method ImageDataBase.DeleteImage should have comment or be unexported (golint)
  • Line 105: warning: exported method ImageDataBase.DoWithPendingImage should have comment or be unexported (golint)
  • Line 110: warning: exported method ImageDataBase.FindLatestImage should have comment or be unexported (golint)
  • Line 115: warning: exported method ImageDataBase.GetImage should have comment or be unexported (golint)
  • Line 119: warning: exported method ImageDataBase.GetUnreferencedObjectsStatistics should have comment or be unexported (golint)
  • Line 123: warning: exported method ImageDataBase.ListDirectories should have comment or be unexported (golint)
  • Line 127: warning: exported method ImageDataBase.ListImages should have comment or be unexported (golint)
  • Line 140: warning: exported method ImageDataBase.MakeDirectory should have comment or be unexported (golint)
  • Line 145: warning: exported method ImageDataBase.ObjectServer should have comment or be unexported (golint)
  • Line 149: warning: exported method ImageDataBase.RegisterAddNotifier should have comment or be unexported (golint)
  • Line 153: warning: exported method ImageDataBase.RegisterDeleteNotifier should have comment or be unexported (golint)
  • Line 157: warning: exported method ImageDataBase.RegisterMakeDirectoryNotifier should have comment or be unexported (golint)
  • Line 161: warning: exported method ImageDataBase.UnregisterAddNotifier should have comment or be unexported (golint)
  • Line 165: warning: exported method ImageDataBase.UnregisterDeleteNotifier should have comment or be unexported (golint)
  • Line 169: warning: exported method ImageDataBase.UnregisterMakeDirectoryNotifier should have comment or be unexported (golint)
  • Line 174: warning: exported method ImageDataBase.UpdateDirectory should have comment or be unexported (golint)
  • Line 178: warning: exported method ImageDataBase.WriteHtml should have comment or be unexported (golint)

• Dominator/imagebuilder/builder/getLatestImage.go
  • Line 25: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 35: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/restoreVmFromSnapshot.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/objectserver/rpcd/api.go
  • Line 28: warning: exported function Setup should have comment or be unexported (golint)

• Dominator/lib/srpc/call_test.go
  • Line 33: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/changeVmConsoleType.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/flags/loadflags/api.go
  • Line 8: warning: exported function LoadForCli should have comment or be unexported (golint)
  • Line 13: warning: exported function LoadForDaemon should have comment or be unexported (golint)

• Dominator/lib/log/serverlogger/api.go
  • Line 22: warning: exported type Logger should have comment or be unexported (golint)

• Dominator/lib/awsutil/api.go
  • Line 22: warning: exported function CreateService should have comment or be unexported (golint)
  • Line 26: warning: exported function CreateSession should have comment or be unexported (golint)
  • Line 164: warning: exported function ForEachTarget should have comment or be unexported (golint)
  • Line 171: warning: exported function GetLocalRegion should have comment or be unexported (golint)
  • Line 175: warning: exported function ListAccountNames should have comment or be unexported (golint)
  • Line 180: warning: exported function ListAccountNamesWithOptions should have comment or be unexported (golint)
  • Line 184: warning: exported function ListRegions should have comment or be unexported (golint)
  • Line 188: warning: exported function MakeFilterFromTag should have comment or be unexported (golint)
  • Line 192: warning: exported function CreateTagsFromList should have comment or be unexported (golint)
  • Line 196: warning: exported function MakeFiltersFromTags should have comment or be unexported (golint)
  • Line 200: warning: exported type Target should have comment or be unexported (golint)
  • Line 205: warning: exported type TargetList should have comment or be unexported (golint)
  • Line 211: warning: exported method TargetList.Set should have comment or be unexported (golint)

• Dominator/hypervisor/manager/volumes.go
  • Line 58: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 69: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/fsutil/renamingWriter.go
  • Line 60: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/logtool/main.go
  • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imageunpacker/client/api.go
  • Line 8: warning: exported function AddDevice should have comment or be unexported (golint)
  • Line 12: warning: exported function AssociateStreamWithDevice should have comment or be unexported (golint)
  • Line 17: warning: exported function ExportImage should have comment or be unexported (golint)
  • Line 22: warning: exported function GetStatus should have comment or be unexported (golint)
  • Line 26: warning: exported function PrepareForCapture should have comment or be unexported (golint)
  • Line 30: warning: exported function PrepareForCopy should have comment or be unexported (golint)
  • Line 34: warning: exported function PrepareForUnpack should have comment or be unexported (golint)
  • Line 40: warning: exported function RemoveDevice should have comment or be unexported (golint)
  • Line 44: warning: exported function UnpackImage should have comment or be unexported (golint)

• Dominator/hypervisor/manager/vm.go
  • Line 704: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 754: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1031: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1606: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1973: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 2798: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/net/tls/api.go
  • Line 14: warning: exported type TlsDialer should have comment or be unexported (golint)

• Dominator/sub/lib/api.go
  • Line 12: warning: exported type TriggersRunner should have comment or be unexported (golint)
  • Line 27: warning: exported function Update should have comment or be unexported (golint)

• Dominator/imageserver/scanner/imdb.go
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 279: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 531: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 550: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/cmd/vm-control/patchVmImage.go
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/format/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 7: warning: exported var TimeFormatSeconds should have comment or be unexported (golint)

• Dominator/lib/net/configurator/debian.go
  • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/listBroadcastInterfaces.go
  • Line 19: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/url/urlutil/watchUrlCached.go
  • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/imagetool/diffImages.go
  • Line 112: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/deleteVmVolume.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/json/api.go
  • Line 8: warning: exported function ReadFromFile should have comment or be unexported (golint)
  • Line 12: warning: exported function WriteToFile should have comment or be unexported (golint)
  • Line 17: warning: exported function WriteWithIndent should have comment or be unexported (golint)

• Dominator/lib/objectcache/encoding.go
  • Line 23: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 41: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/cmd/vm-control/discardVmOldUserData.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/manager/api.go
  • Line 21: warning: exported type DhcpServer should have comment or be unexported (golint)
  • Line 30: warning: exported type Manager should have comment or be unexported (golint)
  • Line 49: warning: exported type StartOptions should have comment or be unexported (golint)
  • Line 82: warning: exported function New should have comment or be unexported (golint)
  • Line 86: warning: exported method Manager.AcknowledgeVm should have comment or be unexported (golint)
  • Line 91: warning: exported method Manager.AddAddressesToPool should have comment or be unexported (golint)
  • Line 95: warning: exported method Manager.BecomePrimaryVmOwner should have comment or be unexported (golint)
  • Line 100: warning: exported method Manager.ChangeOwners should have comment or be unexported (golint)
  • Line 104: warning: exported method Manager.ChangeVmConsoleType should have comment or be unexported (golint)
  • Line 109: warning: exported method Manager.ChangeVmDestroyProtection should have comment or be unexported (golint)
  • Line 114: warning: exported method Manager.ChangeVmOwnerUsers should have comment or be unexported (golint)
  • Line 119: warning: exported method Manager.ChangeVmTags should have comment or be unexported (golint)
  • Line 124: warning: exported method Manager.CheckOwnership should have comment or be unexported (golint)
  • Line 128: warning: exported method Manager.CheckVmHasHealthAgent should have comment or be unexported (golint)
  • Line 132: warning: exported method Manager.CloseUpdateChannel should have comment or be unexported (golint)
  • Line 136: warning: exported method Manager.CommitImportedVm should have comment or be unexported (golint)
  • Line 141: warning: exported method Manager.ConnectToVmConsole should have comment or be unexported (golint)
  • Line 146: warning: exported method Manager.ConnectToVmSerialPort should have comment or be unexported (golint)
  • Line 152: warning: exported method Manager.CopyVm should have comment or be unexported (golint)
  • Line 156: warning: exported method Manager.CreateVm should have comment or be unexported (golint)
  • Line 160: warning: exported method Manager.DeleteVmVolume should have comment or be unexported (golint)
  • Line 165: warning: exported method Manager.DestroyVm should have comment or be unexported (golint)
  • Line 170: warning: exported method Manager.DiscardVmAccessToken should have comment or be unexported (golint)
  • Line 175: warning: exported method Manager.DiscardVmOldImage should have comment or be unexported (golint)
  • Line 180: warning: exported method Manager.DiscardVmOldUserData should have comment or be unexported (golint)
  • Line 185: warning: exported method Manager.DiscardVmSnapshot should have comment or be unexported (golint)
  • Line 190: warning: exported method Manager.ExportLocalVm should have comment or be unexported (golint)
  • Line 195: warning: exported method Manager.GetHealthStatus should have comment or be unexported (golint)
  • Line 199: warning: exported method Manager.GetImageServerAddress should have comment or be unexported (golint)
  • Line 203: warning: exported method Manager.GetNumVMs should have comment or be unexported (golint)
  • Line 207: warning: exported method Manager.GetVmBootLog should have comment or be unexported (golint)
  • Line 211: warning: exported method Manager.GetVmAccessToken should have comment or be unexported (golint)
  • Line 216: warning: exported method Manager.GetVmInfo should have comment or be unexported (golint)
  • Line 220: warning: exported method Manager.GetVmUserData should have comment or be unexported (golint)
  • Line 227: warning: exported method Manager.GetVmUserDataRPC should have comment or be unexported (golint)
  • Line 233: warning: exported method Manager.GetVmVolume should have comment or be unexported (golint)
  • Line 237: warning: exported method Manager.ImportLocalVm should have comment or be unexported (golint)
  • Line 242: warning: exported method Manager.ListAvailableAddresses should have comment or be unexported (golint)
  • Line 246: warning: exported method Manager.ListSubnets should have comment or be unexported (golint)
  • Line 250: warning: exported method Manager.ListVMs should have comment or be unexported (golint)
  • Line 254: warning: exported method Manager.ListVolumeDirectories should have comment or be unexported (golint)
  • Line 258: warning: exported method Manager.MakeSubnetChannel should have comment or be unexported (golint)
  • Line 262: warning: exported method Manager.MakeUpdateChannel should have comment or be unexported (golint)
  • Line 266: warning: exported method Manager.MigrateVm should have comment or be unexported (golint)
  • Line 270: warning: exported method Manager.NotifyVmMetadataRequest should have comment or be unexported (golint)
  • Line 274: warning: exported method Manager.PatchVmImage should have comment or be unexported (golint)
  • Line 279: warning: exported method Manager.PrepareVmForMigration should have comment or be unexported (golint)
  • Line 284: warning: exported method Manager.RemoveAddressesFromPool should have comment or be unexported (golint)
  • Line 288: warning: exported method Manager.RemoveExcessAddressesFromPool should have comment or be unexported (golint)
  • Line 292: warning: exported method Manager.RegisterVmMetadataNotifier should have comment or be unexported (golint)
  • Line 297: warning: exported method Manager.ReplaceVmImage should have comment or be unexported (golint)
  • Line 302: warning: exported method Manager.ReplaceVmUserData should have comment or be unexported (golint)
  • Line 307: warning: exported method Manager.RestoreVmFromSnapshot should have comment or be unexported (golint)
  • Line 312: warning: exported method Manager.RestoreVmImage should have comment or be unexported (golint)
  • Line 317: warning: exported method Manager.RestoreVmUserData should have comment or be unexported (golint)
  • Line 322: warning: exported method Manager.ShutdownVMsAndExit should have comment or be unexported (golint)
  • Line 326: warning: exported method Manager.SnapshotVm should have comment or be unexported (golint)
  • Line 331: warning: exported method Manager.StartVm should have comment or be unexported (golint)
  • Line 337: warning: exported method Manager.StopVm should have comment or be unexported (golint)
  • Line 342: warning: exported method Manager.UpdateSubnets should have comment or be unexported (golint)
  • Line 346: warning: exported method Manager.UnregisterVmMetadataNotifier should have comment or be unexported (golint)
  • Line 351: warning: exported method Manager.WriteHtml should have comment or be unexported (golint)

• Dominator/lib/log/nulllogger/api.go
  • Line 3: warning: exported type Logger should have comment or be unexported (golint)
  • Line 5: warning: exported function New should have comment or be unexported (golint)
  • Line 9: warning: exported method Logger.Fatal should have comment or be unexported (golint)
  • Line 10: warning: exported method Logger.Fatalf should have comment or be unexported (golint)
  • Line 11: warning: exported method Logger.Fatalln should have comment or be unexported (golint)
  • Line 12: warning: exported method Logger.Panic should have comment or be unexported (golint)
  • Line 13: warning: exported method Logger.Panicf should have comment or be unexported (golint)
  • Line 14: warning: exported method Logger.Panicln should have comment or be unexported (golint)
  • Line 15: warning: exported method Logger.Print should have comment or be unexported (golint)
  • Line 16: warning: exported method Logger.Printf should have comment or be unexported (golint)
  • Line 17: warning: exported method Logger.Println should have comment or be unexported (golint)
  • Line 18: warning: exported method Logger.Debug should have comment or be unexported (golint)
  • Line 19: warning: exported method Logger.Debugf should have comment or be unexported (golint)
  • Line 20: warning: exported method Logger.Debugln should have comment or be unexported (golint)

• Dominator/lib/filesystem/scanner/api.go
  • Line 14: warning: exported type Hasher should have comment or be unexported (golint)
  • Line 25: warning: exported type FileSystem should have comment or be unexported (golint)
  • Line 36: warning: exported function MakeRegularInode should have comment or be unexported (golint)
  • Line 40: warning: exported function MakeSymlinkInode should have comment or be unexported (golint)
  • Line 44: warning: exported function MakeSpecialInode should have comment or be unexported (golint)
  • Line 48: warning: exported function ScanFileSystem should have comment or be unexported (golint)
  • Line 56: warning: exported method FileSystem.GetObject should have comment or be unexported (golint)
  • Line 61: warning: exported function GetSimpleHasher should have comment or be unexported (golint)
  • Line 69: warning: exported function NewCpuLimitedHasher should have comment or be unexported (golint)

• Dominator/lib/filesystem/util/writeRaw.go
  • Line 30: warning: exported const BLKGETSIZE should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 171: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 298: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 491: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 504: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 563: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/cmd/vm-control/probeVmPort.go
  • Line 26: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imageserver/rpcd/api.go
  • Line 45: warning: exported function Setup should have comment or be unexported (golint)

• Dominator/cmd/installer/server.go
  • Line 24: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 90: warning: exported function AddHtmlWriter should have comment or be unexported (golint)
  • Line 170: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filesystem/untar/decode.go
  • Line 80: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 100: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 152: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 181: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 188: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Dominator/lib/awsutil/credentials.go
  • Line 130: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 133: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/discardVmOldImage.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filesystem/scanner/walk.go
  • Line 109: warning: error should be the last type when returning multiple items (golint)
  • Line 188: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/fleetmanager/topology/impl.go
  • Line 69: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imagebuilder/builder/build.go
  • Line 163: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 205: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 296: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 308: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/snapshotVm.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/net/proxy/api.go
  • Line 12: warning: exported function NewDialer should have comment or be unexported (golint)

• Dominator/lib/fsutil/api.go
  • Line 15: warning: exported const DirPerms should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported var ErrorChecksumMismatch should have comment or be unexported (golint)
  • Line 37: warning: exported function CopyFile should have comment or be unexported (golint)
  • Line 166: warning: exported type ChecksumReader should have comment or be unexported (golint)
  • Line 171: warning: exported function NewChecksumReader should have comment or be unexported (golint)
  • Line 175: warning: exported method ChecksumReader.GetChecksum should have comment or be unexported (golint)
  • Line 183: warning: exported method ChecksumReader.ReadByte should have comment or be unexported (golint)
  • Line 187: warning: exported method ChecksumReader.VerifyChecksum should have comment or be unexported (golint)
  • Line 191: warning: exported type ChecksumWriter should have comment or be unexported (golint)
  • Line 196: warning: exported function NewChecksumWriter should have comment or be unexported (golint)
  • Line 204: warning: exported method ChecksumWriter.WriteChecksum should have comment or be unexported (golint)

• Dominator/sub/lib/update.go
  • Line 167: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 178: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imageunpacker/unpacker/api.go
  • Line 66: warning: exported type Unpacker should have comment or be unexported (golint)
  • Line 76: warning: exported function Load should have comment or be unexported (golint)
  • Line 81: warning: exported method Unpacker.AddDevice should have comment or be unexported (golint)
  • Line 85: warning: exported method Unpacker.AssociateStreamWithDevice should have comment or be unexported (golint)
  • Line 90: warning: exported method Unpacker.ExportImage should have comment or be unexported (golint)
  • Line 95: warning: exported method Unpacker.GetFileSystem should have comment or be unexported (golint)
  • Line 100: warning: exported method Unpacker.GetStatus should have comment or be unexported (golint)
  • Line 104: warning: exported method Unpacker.PrepareForCapture should have comment or be unexported (golint)
  • Line 108: warning: exported method Unpacker.PrepareForCopy should have comment or be unexported (golint)
  • Line 112: warning: exported method Unpacker.PrepareForUnpack should have comment or be unexported (golint)
  • Line 117: warning: exported method Unpacker.PrepareForAddDevice should have comment or be unexported (golint)
  • Line 121: warning: exported method Unpacker.RemoveDevice should have comment or be unexported (golint)
  • Line 125: warning: exported method Unpacker.UnpackImage should have comment or be unexported (golint)
  • Line 129: warning: exported method Unpacker.WriteHtml should have comment or be unexported (golint)

• Dominator/lib/net/bind.go
  • Line 12: warning: exported const SO_REUSEPORT should have comment or be unexported (golint)

• Dominator/sub/rpcd/api.go
  • Line 46: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 50: warning: exported function Setup should have comment or be unexported (golint)
  • Line 87: warning: exported method HtmlWriter.WriteHtml should have comment or be unexported (golint)

• Dominator/fleetmanager/hypervisors/api.go
  • Line 60: warning: exported type Manager should have comment or be unexported (golint)
  • Line 84: warning: exported type StartOptions should have comment or be unexported (golint)
  • Line 91: warning: exported type Storer should have comment or be unexported (golint)
  • Line 123: warning: exported function New should have comment or be unexported (golint)
  • Line 127: warning: exported method Manager.ChangeMachineTags should have comment or be unexported (golint)
  • Line 132: warning: exported method Manager.CloseUpdateChannel should have comment or be unexported (golint)
  • Line 136: warning: exported method Manager.GetHypervisorForVm should have comment or be unexported (golint)
  • Line 140: warning: exported method Manager.GetMachineInfo should have comment or be unexported (golint)
  • Line 144: warning: exported method Manager.GetTopology should have comment or be unexported (golint)
  • Line 148: warning: exported method Manager.ListHypervisorsInLocation should have comment or be unexported (golint)
  • Line 153: warning: exported method Manager.ListLocations should have comment or be unexported (golint)
  • Line 157: warning: exported method Manager.ListVMsInLocation should have comment or be unexported (golint)
  • Line 161: warning: exported method Manager.MakeUpdateChannel should have comment or be unexported (golint)
  • Line 165: warning: exported method Manager.MoveIpAddresses should have comment or be unexported (golint)
  • Line 169: warning: exported method Manager.WriteHtml should have comment or be unexported (golint)
  • Line 173: warning: exported method Manager.UpdateTopology should have comment or be unexported (golint)

• Dominator/cmd/vm-control/getVmUserData.go
  • Line 25: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/subd/main.go
  • Line 71: warning: don't use underscores in Go names; var r_devnum should be rDevnum (golint)
  • Line 78: warning: don't use underscores in Go names; var s_devnum should be sDevnum (golint)
  • Line 227: warning: exported type DumpableFileSystemHistory should have comment or be unexported (golint)
  • Line 231: warning: exported method DumpableFileSystemHistory.WriteHtml should have comment or be unexported (golint)

• Dominator/sub/scanner/api.go
  • Line 20: warning: exported type Configuration should have comment or be unexported (golint)
  • Line 28: warning: exported method Configuration.BoostCpuLimit should have comment or be unexported (golint)
  • Line 32: warning: exported method Configuration.RegisterMetrics should have comment or be unexported (golint)
  • Line 37: warning: exported method Configuration.RestoreCpuLimit should have comment or be unexported (golint)
  • Line 41: warning: exported method Configuration.WriteHtml should have comment or be unexported (golint)
  • Line 45: warning: exported type FileSystemHistory should have comment or be unexported (golint)
  • Line 55: warning: exported method FileSystemHistory.DurationOfLastScan should have comment or be unexported (golint)
  • Line 61: warning: exported method FileSystemHistory.FileSystem should have comment or be unexported (golint)
  • Line 67: warning: exported method FileSystemHistory.GenerationCount should have comment or be unexported (golint)
  • Line 73: warning: exported method FileSystemHistory.ScanCount should have comment or be unexported (golint)
  • Line 85: warning: exported method FileSystemHistory.Update should have comment or be unexported (golint)
  • Line 89: warning: exported method FileSystemHistory.UpdateObjectCacheOnly should have comment or be unexported (golint)
  • Line 93: warning: exported method FileSystemHistory.WriteHtml should have comment or be unexported (golint)
  • Line 99: warning: exported type FileSystem should have comment or be unexported (golint)
  • Line 107: warning: exported function ScanFileSystem should have comment or be unexported (golint)
  • Line 113: warning: exported method FileSystem.ScanObjectCache should have comment or be unexported (golint)
  • Line 117: warning: exported method FileSystem.Configuration should have comment or be unexported (golint)
  • Line 121: warning: exported method FileSystem.RootDirectoryName should have comment or be unexported (golint)
  • Line 133: warning: exported method FileSystem.WriteHtml should have comment or be unexported (golint)
  • Line 137: warning: exported function CompareFileSystems should have comment or be unexported (golint)
  • Line 141: warning: exported function StartScannerDaemon should have comment or be unexported (golint)
  • Line 148: warning: exported function StartScanning should have comment or be unexported (golint)

• Dominator/fleetmanager/topology/get.go
  • Line 10: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 18: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/dom/images/api.go
  • Line 11: warning: exported type Manager should have comment or be unexported (golint)
  • Line 25: warning: exported function New should have comment or be unexported (golint)
  • Line 29: warning: exported method Manager.Get should have comment or be unexported (golint)
  • Line 39: warning: exported method Manager.GetNoError should have comment or be unexported (golint)
  • Line 47: warning: exported method Manager.SetImageInterestList should have comment or be unexported (golint)

• Dominator/lib/net/configurator/api.go
  • Line 24: warning: exported type NetworkConfig should have comment or be unexported (golint)
  • Line 32: warning: exported function FindMatchingSubnet should have comment or be unexported (golint)
  • Line 37: warning: exported function GetNetworkEntries should have comment or be unexported (golint)
  • Line 42: warning: exported function Compute should have comment or be unexported (golint)
  • Line 48: warning: exported method NetworkConfig.PrintDebian should have comment or be unexported (golint)
  • Line 52: warning: exported method NetworkConfig.Update should have comment or be unexported (golint)
  • Line 57: warning: exported method NetworkConfig.UpdateDebian should have comment or be unexported (golint)
  • Line 61: warning: exported method NetworkConfig.WriteDebian should have comment or be unexported (golint)
  • Line 65: warning: exported function PrintResolvConf should have comment or be unexported (golint)
  • Line 69: warning: exported function UpdateResolvConf should have comment or be unexported (golint)
  • Line 74: warning: exported function WriteResolvConf should have comment or be unexported (golint)

• Dominator/lib/url/api.go
  • Line 9: warning: exported const OutputTypeHtml should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported type ParsedQuery should have comment or be unexported (golint)
  • Line 19: warning: exported function ParseQuery should have comment or be unexported (golint)
  • Line 23: warning: exported method ParsedQuery.Last should have comment or be unexported (golint)
  • Line 27: warning: exported method ParsedQuery.OutputType should have comment or be unexported (golint)

• Dominator/proto/common/messages.go
  • Line 3: warning: exported type StatusResponse should have comment or be unexported (golint)

• Dominator/sub/client/api.go
  • Line 11: warning: exported function BoostCpuLimit should have comment or be unexported (golint)
  • Line 15: warning: exported function Cleanup should have comment or be unexported (golint)
  • Line 19: warning: exported function Fetch should have comment or be unexported (golint)
  • Line 24: warning: exported function GetConfiguration should have comment or be unexported (golint)
  • Line 28: warning: exported function CallPoll should have comment or be unexported (golint)
  • Line 33: warning: exported function SetConfiguration should have comment or be unexported (golint)
  • Line 37: warning: exported function CallUpdate should have comment or be unexported (golint)
  • Line 42: warning: exported function GetFiles should have comment or be unexported (golint)

• Dominator/lib/rateio/api.go
  • Line 11: warning: exported type ReadIOMeasurer should have comment or be unexported (golint)
  • Line 16: warning: exported type ReadMeasurer should have comment or be unexported (golint)
  • Line 18: warning: exported method ReadMeasurer.MeasureReadIO should have comment or be unexported (golint)
  • Line 23: warning: exported method ReadMeasurer.Reset should have comment or be unexported (golint)
  • Line 25: warning: exported type ReaderContext should have comment or be unexported (golint)
  • Line 35: warning: exported function NewReaderContext should have comment or be unexported (golint)
  • Line 40: warning: exported method ReaderContext.InitialiseMaximumSpeed should have comment or be unexported (golint)
  • Line 44: warning: exported method ReaderContext.MaximumSpeed should have comment or be unexported (golint)
  • Line 46: warning: exported method ReaderContext.SpeedPercent should have comment or be unexported (golint)
  • Line 48: warning: exported method ReaderContext.SetSpeedPercent should have comment or be unexported (golint)
  • Line 52: warning: exported method ReaderContext.NewReader should have comment or be unexported (golint)
  • Line 56: warning: exported method ReaderContext.RegisterMetrics should have comment or be unexported (golint)
  • Line 65: warning: exported type Reader should have comment or be unexported (golint)

• Dominator/hypervisor/dhcpd/impl.go
  • Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 61: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 241: warning: exported method DhcpServer.ServeDHCP should have comment or be unexported (golint)
  • Line 298: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/fleetmanager/hypervisors/fsstorer/get.go
  • Line 10: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/cpusharer/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 43: warning: exported type FifoCpuSharer should have comment or be unexported (golint)
  • Line 125: warning: exported method FifoCpuSharer.ReleaseCpu should have comment or be unexported (golint)
  • Line 129: warning: exported method FifoCpuSharer.Sleep should have comment or be unexported (golint)
  • Line 133: warning: exported type Statistics should have comment or be unexported (golint)

• Dominator/cmd/vm-control/stopVm.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/html/api.go
  • Line 8: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 12: warning: exported function BenchmarkedHandler should have comment or be unexported (golint)
  • Line 17: warning: exported function HandleFunc should have comment or be unexported (golint)
  • Line 22: warning: exported function RegisterHtmlWriterForPattern should have comment or be unexported (golint)
  • Line 27: warning: exported function ServeMuxHandleFunc should have comment or be unexported (golint)
  • Line 32: warning: exported function SetSecurityHeaders should have comment or be unexported (golint)
  • Line 36: warning: exported function WriteFooter should have comment or be unexported (golint)
  • Line 40: warning: exported function WriteHeader should have comment or be unexported (golint)
  • Line 44: warning: exported function WriteHeaderNoGC should have comment or be unexported (golint)
  • Line 48: warning: exported function WriteHeaderWithRequest should have comment or be unexported (golint)
  • Line 52: warning: exported function WriteHeaderWithRequestNoGC should have comment or be unexported (golint)

• Dominator/lib/objectserver/memory/get.go
  • Line 18: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/client/api.go
  • Line 11: warning: exported function AcknowledgeVm should have comment or be unexported (golint)
  • Line 15: warning: exported function CreateVm should have comment or be unexported (golint)
  • Line 20: warning: exported function DeleteVmVolume should have comment or be unexported (golint)
  • Line 25: warning: exported function DestroyVm should have comment or be unexported (golint)
  • Line 29: warning: exported function ExportLocalVm should have comment or be unexported (golint)
  • Line 34: warning: exported function GetVmInfo should have comment or be unexported (golint)
  • Line 38: warning: exported function PrepareVmForMigration should have comment or be unexported (golint)
  • Line 43: warning: exported function StartVm should have comment or be unexported (golint)
  • Line 47: warning: exported function StopVm should have comment or be unexported (golint)

• Dominator/lib/mdb/mdbd/api.go
  • Line 1: warning: package comment should not have leading space (golint)

• Dominator/lib/flagutil/stringList.go
  • Line 11: warning: exported method StringList.Set should have comment or be unexported (golint)

• Dominator/lib/net/measuringDialer.go
  • Line 12: warning: exported method MeasuringDialer.Dial should have comment or be unexported (golint)

• Dominator/lib/objectserver/client/api.go
  • Line 11: warning: exported type ObjectClient should have comment or be unexported (golint)
  • Line 17: warning: exported function NewObjectClient should have comment or be unexported (golint)
  • Line 21: warning: exported function AttachObjectClient should have comment or be unexported (golint)
  • Line 25: warning: exported method ObjectClient.AddObject should have comment or be unexported (golint)
  • Line 30: warning: exported method ObjectClient.CheckObjects should have comment or be unexported (golint)
  • Line 35: warning: exported method ObjectClient.Close should have comment or be unexported (golint)
  • Line 39: warning: exported method ObjectClient.GetObject should have comment or be unexported (golint)
  • Line 44: warning: exported method ObjectClient.GetObjects should have comment or be unexported (golint)
  • Line 49: warning: exported method ObjectClient.SetExclusiveGetObjects should have comment or be unexported (golint)
  • Line 53: warning: exported type ObjectsReader should have comment or be unexported (golint)
  • Line 60: warning: exported method ObjectsReader.Close should have comment or be unexported (golint)
  • Line 64: warning: exported method ObjectsReader.NextObject should have comment or be unexported (golint)
  • Line 68: warning: exported method ObjectsReader.ObjectSizes should have comment or be unexported (golint)
  • Line 72: warning: exported type ObjectAdderQueue should have comment or be unexported (golint)
  • Line 79: warning: exported function NewObjectAdderQueue should have comment or be unexported (golint)
  • Line 83: warning: exported method ObjectAdderQueue.Add should have comment or be unexported (golint)
  • Line 88: warning: exported method ObjectAdderQueue.AddData should have comment or be unexported (golint)
  • Line 92: warning: exported method ObjectAdderQueue.Close should have comment or be unexported (golint)

• Dominator/lib/memstats/memstats.go
  • Line 15: warning: exported function WriteMemoryStats should have comment or be unexported (golint)

• Dominator/proto/hypervisor/methods.go
  • Line 54: warning: exported function ShrinkIP should have comment or be unexported (golint)
  • Line 61: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 69: warning: exported method Address.Equal should have comment or be unexported (golint)
  • Line 79: warning: exported method Address.Shrink should have comment or be unexported (golint)
  • Line 79: warning: receiver name address should be consistent with previous receiver name left for Address (golint)
  • Line 95: warning: exported method ConsoleType.CheckValid should have comment or be unexported (golint)
  • Line 98: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 103: warning: exported method ConsoleType.MarshalText should have comment or be unexported (golint)
  • Line 106: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 111: warning: exported method ConsoleType.Set should have comment or be unexported (golint)
  • Line 114: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 128: warning: exported method ConsoleType.UnmarshalText should have comment or be unexported (golint)
  • Line 133: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 138: warning: exported method State.MarshalText should have comment or be unexported (golint)
  • Line 141: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 149: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 154: warning: exported method State.UnmarshalText should have comment or be unexported (golint)
  • Line 159: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 164: warning: exported method Subnet.Equal should have comment or be unexported (golint)
  • Line 195: warning: exported function IpListsEqual should have comment or be unexported (golint)
  • Line 207: warning: exported method Subnet.Shrink should have comment or be unexported (golint)
  • Line 207: warning: receiver name subnet should be consistent with previous receiver name left for Subnet (golint)
  • Line 215: warning: exported method VmInfo.Equal should have comment or be unexported (golint)
  • Line 286: warning: exported method VolumeFormat.MarshalText should have comment or be unexported (golint)
  • Line 289: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 297: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 302: warning: exported method VolumeFormat.UnmarshalText should have comment or be unexported (golint)
  • Line 307: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/mbr/api.go
  • Line 9: warning: exported const TABLE_TYPE_AIX should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type Mbr should have comment or be unexported (golint)
  • Line 25: warning: exported type TableType should have comment or be unexported (golint)
  • Line 27: warning: exported function Decode should have comment or be unexported (golint)
  • Line 31: warning: exported method Mbr.GetNumPartitions should have comment or be unexported (golint)
  • Line 35: warning: exported method Mbr.GetPartitionOffset should have comment or be unexported (golint)
  • Line 39: warning: exported method Mbr.GetPartitionSize should have comment or be unexported (golint)
  • Line 43: warning: exported method TableType.Set should have comment or be unexported (golint)
  • Line 51: warning: exported function WriteDefault should have comment or be unexported (golint)

• Dominator/lib/srpc/proxy/api.go
  • Line 12: warning: exported function New should have comment or be unexported (golint)

• Dominator/cmd/installer/configureLocalNetwork.go
  • Line 157: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 161: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/flagutil/stringToRuneMap.go
  • Line 25: warning: exported method StringToRuneMap.Set should have comment or be unexported (golint)

• Dominator/cmd/vm-control/restoreVmUserData.go
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/hypervisor/manager/start.go
  • Line 169: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filesystem/tar/api.go
  • Line 11: warning: exported function Encode should have comment or be unexported (golint)
  • Line 16: warning: exported function Write should have comment or be unexported (golint)

• Dominator/lib/log/prefixlogger/api.go
  • Line 10: warning: exported type Logger should have comment or be unexported (golint)
  • Line 15: warning: exported function New should have comment or be unexported (golint)
  • Line 19: warning: exported method Logger.Debug should have comment or be unexported (golint)
  • Line 23: warning: exported method Logger.Debugf should have comment or be unexported (golint)
  • Line 27: warning: exported method Logger.Debugln should have comment or be unexported (golint)
  • Line 31: warning: exported method Logger.Fatal should have comment or be unexported (golint)
  • Line 35: warning: exported method Logger.Fatalf should have comment or be unexported (golint)
  • Line 39: warning: exported method Logger.Fatalln should have comment or be unexported (golint)
  • Line 43: warning: exported method Logger.Panic should have comment or be unexported (golint)
  • Line 47: warning: exported method Logger.Panicf should have comment or be unexported (golint)
  • Line 51: warning: exported method Logger.Panicln should have comment or be unexported (golint)
  • Line 55: warning: exported method Logger.Print should have comment or be unexported (golint)
  • Line 59: warning: exported method Logger.Printf should have comment or be unexported (golint)
  • Line 63: warning: exported method Logger.Println should have comment or be unexported (golint)

• Dominator/lib/srpc/proxy/impl.go
  • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/proto/dominator/messages.go
  • Line 7: warning: exported type ClearSafetyShutoffRequest should have comment or be unexported (golint)
  • Line 11: warning: exported type ClearSafetyShutoffResponse should have comment or be unexported (golint)
  • Line 13: warning: exported type ConfigureSubsRequest should have comment or be unexported (golint)
  • Line 15: warning: exported type ConfigureSubsResponse should have comment or be unexported (golint)
  • Line 17: warning: exported type DisableUpdatesRequest should have comment or be unexported (golint)
  • Line 21: warning: exported type DisableUpdatesResponse should have comment or be unexported (golint)
  • Line 23: warning: exported type EnableUpdatesRequest should have comment or be unexported (golint)
  • Line 27: warning: exported type EnableUpdatesResponse should have comment or be unexported (golint)
  • Line 29: warning: exported type GetDefaultImageRequest should have comment or be unexported (golint)
  • Line 31: warning: exported type GetDefaultImageResponse should have comment or be unexported (golint)
  • Line 35: warning: exported type GetSubsConfigurationRequest should have comment or be unexported (golint)
  • Line 37: warning: exported type GetSubsConfigurationResponse should have comment or be unexported (golint)
  • Line 39: warning: exported type SetDefaultImageRequest should have comment or be unexported (golint)
  • Line 43: warning: exported type SetDefaultImageResponse should have comment or be unexported (golint)

• Dominator/proto/fleetmanager/methods.go
  • Line 50: warning: exported method Machine.Equal should have comment or be unexported (golint)
  • Line 77: warning: exported method NetworkEntry.Equal should have comment or be unexported (golint)
  • Line 90: warning: exported method HardwareAddr.MarshalText should have comment or be unexported (golint)
  • Line 98: warning: exported method HardwareAddr.UnmarshalText should have comment or be unexported (golint)
  • Line 106: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/srpc/setupserver/api.go
  • Line 1: warning: package comment should not have leading space (golint)

• Dominator/proto/objectserver/messages.go
  • Line 8: warning: comment on exported type AddObjectRequest should be of the form "AddObjectRequest ..." (with optional leading article) (golint)
  • Line 18: warning: exported type AddObjectResponse should have comment or be unexported (golint)
  • Line 24: warning: exported type CheckObjectsRequest should have comment or be unexported (golint)
  • Line 28: warning: exported type CheckObjectsResponse should have comment or be unexported (golint)
  • Line 32: warning: comment on exported type GetObjectsRequest should be of the form "GetObjectsRequest ..." (with optional leading article) (golint)
  • Line 38: warning: exported type GetObjectsResponse should have comment or be unexported (golint)
  • Line 43: warning: exported type TestBandwidthRequest should have comment or be unexported (golint)
  • Line 51: warning: exported type TestBandwidthResponse should have comment or be unexported (golint)

• Dominator/cmd/logtool/watch.go
  • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imagepublishers/amipublisher/api.go
  • Line 12: warning: exported const ExpiresAtFormat should have comment or be unexported (golint)
  • Line 14: warning: exported type Image should have comment or be unexported (golint)
  • Line 24: warning: exported type Instance should have comment or be unexported (golint)
  • Line 32: warning: exported type InstanceResult should have comment or be unexported (golint)
  • Line 39: warning: exported method InstanceResult.MarshalJSON should have comment or be unexported (golint)
  • Line 59: warning: exported type PublishOptions should have comment or be unexported (golint)
  • Line 63: warning: exported type Resource should have comment or be unexported (golint)
  • Line 72: warning: exported type Results should have comment or be unexported (golint)
  • Line 74: warning: exported type TargetResult should have comment or be unexported (golint)
  • Line 85: warning: exported type TargetUnpackers should have comment or be unexported (golint)
  • Line 90: warning: exported type Unpacker should have comment or be unexported (golint)
  • Line 97: warning: exported type UnusedImagesResult should have comment or be unexported (golint)
  • Line 102: warning: exported type UsedImagesResult should have comment or be unexported (golint)
  • Line 107: warning: exported method TargetResult.MarshalJSON should have comment or be unexported (golint)
  • Line 111: warning: exported function AddVolumes should have comment or be unexported (golint)
  • Line 117: warning: exported function CopyBootstrapImage should have comment or be unexported (golint)
  • Line 128: warning: exported function DeleteResources should have comment or be unexported (golint)
  • Line 132: warning: exported function DeleteTags should have comment or be unexported (golint)
  • Line 137: warning: exported function DeleteTagsOnUnpackers should have comment or be unexported (golint)
  • Line 143: warning: exported function DeleteUnusedImages should have comment or be unexported (golint)
  • Line 150: warning: exported function ExpireResources should have comment or be unexported (golint)
  • Line 155: warning: exported function ImportKeyPair should have comment or be unexported (golint)
  • Line 160: warning: exported function LaunchInstances should have comment or be unexported (golint)
  • Line 170: warning: exported function LaunchInstancesForImages should have comment or be unexported (golint)
  • Line 179: warning: exported function ListImages should have comment or be unexported (golint)
  • Line 186: warning: exported function ListStreams should have comment or be unexported (golint)
  • Line 191: warning: exported function ListUnpackers should have comment or be unexported (golint)
  • Line 197: warning: exported function ListUnusedImages should have comment or be unexported (golint)
  • Line 204: warning: exported function ListUsedImages should have comment or be unexported (golint)
  • Line 211: warning: exported function PrepareUnpackers should have comment or be unexported (golint)
  • Line 216: warning: exported function Publish should have comment or be unexported (golint)
  • Line 238: warning: exported function RemoveUnusedVolumes should have comment or be unexported (golint)
  • Line 243: warning: exported function SetExclusiveTags should have comment or be unexported (golint)
  • Line 248: warning: exported function SetTags should have comment or be unexported (golint)
  • Line 253: warning: exported function StartInstances should have comment or be unexported (golint)
  • Line 259: warning: exported function StopIdleUnpackers should have comment or be unexported (golint)
  • Line 264: warning: exported function TerminateInstances should have comment or be unexported (golint)

• Dominator/lib/rsync/api.go
  • Line 7: warning: exported type Conn should have comment or be unexported (golint)
  • Line 13: warning: exported type Decoder should have comment or be unexported (golint)
  • Line 17: warning: exported type Encoder should have comment or be unexported (golint)
  • Line 21: warning: exported type Stats should have comment or be unexported (golint)
  • Line 26: warning: exported function GetBlocks should have comment or be unexported (golint)
  • Line 32: warning: exported function ServeBlocks should have comment or be unexported (golint)

• Dominator/lib/srpc/serverutil/api.go
  • Line 9: warning: exported type PerUserMethodLimiter should have comment or be unexported (golint)
  • Line 20: warning: exported function NewPerUserMethodLimiter should have comment or be unexported (golint)
  • Line 25: warning: exported method PerUserMethodLimiter.BlockMethod should have comment or be unexported (golint)

• Dominator/lib/net/rrdialer/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 22: warning: exported type Dialer should have comment or be unexported (golint)

• Dominator/lib/triggers/api.go
  • Line 7: warning: exported type MergeableTriggers should have comment or be unexported (golint)
  • Line 17: warning: exported type Trigger should have comment or be unexported (golint)
  • Line 25: warning: exported method Trigger.ReplaceStrings should have comment or be unexported (golint)
  • Line 29: warning: exported type Triggers should have comment or be unexported (golint)
  • Line 36: warning: exported function Decode should have comment or be unexported (golint)
  • Line 40: warning: exported function Load should have comment or be unexported (golint)
  • Line 44: warning: exported function New should have comment or be unexported (golint)
  • Line 56: warning: exported method Triggers.ReplaceStrings should have comment or be unexported (golint)
  • Line 65: warning: exported method MergeableTriggers.ExportTriggers should have comment or be unexported (golint)
  • Line 69: warning: exported method MergeableTriggers.Merge should have comment or be unexported (golint)
  • Line 73: warning: exported method Triggers.Match should have comment or be unexported (golint)
  • Line 77: warning: exported method Triggers.GetMatchedTriggers should have comment or be unexported (golint)
  • Line 81: warning: exported method Triggers.GetMatchStatistics should have comment or be unexported (golint)

• Dominator/lib/srpc/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 60: warning: exported var ErrorConnectionRefused should have comment or be unexported (golint)
  • Line 103: warning: exported type AuthInformation should have comment or be unexported (golint)
  • Line 114: warning: exported type Decoder should have comment or be unexported (golint)
  • Line 118: warning: exported type Encoder should have comment or be unexported (golint)
  • Line 157: warning: exported function RegisterNameWithOptions should have comment or be unexported (golint)
  • Line 191: warning: exported type ClientResource should have comment or be unexported (golint)
  • Line 272: warning: exported method ClientResource.ScheduleClose should have comment or be unexported (golint)
  • Line 276: warning: exported type Client should have comment or be unexported (golint)
  • Line 378: warning: exported type Conn should have comment or be unexported (golint)
  • Line 438: warning: exported type ReceiverOptions should have comment or be unexported (golint)

• Dominator/lib/cpulimiter/api.go
  • Line 10: warning: exported type CpuLimiter should have comment or be unexported (golint)
  • Line 18: warning: exported function New should have comment or be unexported (golint)
  • Line 22: warning: exported method CpuLimiter.Limit should have comment or be unexported (golint)
  • Line 26: warning: exported method CpuLimiter.CpuPercent should have comment or be unexported (golint)
  • Line 30: warning: exported method CpuLimiter.SetCpuPercent should have comment or be unexported (golint)

• Dominator/cmd/vm-control/becomePrimaryVmOwner.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/logbuf/http.go
  • Line 17: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 230: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/replaceVmUserData.go
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/traceMetadata.go
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 62: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filegen/connect.go
  • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/lib/log/logutil/api.go
  • Line 5: warning: exported function LogMemory should have comment or be unexported (golint)

• Dominator/lib/fsutil/readDirnames.go
  • Line 11: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/cmd/vm-control/createVm.go
  • Line 82: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 154: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 168: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 180: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 224: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 253: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/dom/herd/api.go
  • Line 67: warning: exported type HtmlWriter should have comment or be unexported (golint)
  • Line 71: warning: exported type Sub should have comment or be unexported (golint)
  • Line 121: warning: exported type Herd should have comment or be unexported (golint)
  • Line 145: warning: exported function NewHerd should have comment or be unexported (golint)
  • Line 150: warning: exported method Herd.AddHtmlWriter should have comment or be unexported (golint)
  • Line 154: warning: exported method Herd.ClearSafetyShutoff should have comment or be unexported (golint)
  • Line 158: warning: exported method Herd.ConfigureSubs should have comment or be unexported (golint)
  • Line 162: warning: exported method Herd.DisableUpdates should have comment or be unexported (golint)
  • Line 166: warning: exported method Herd.EnableUpdates should have comment or be unexported (golint)
  • Line 170: warning: exported method Herd.GetDefaultImage should have comment or be unexported (golint)
  • Line 174: warning: exported method Herd.GetSubsConfiguration should have comment or be unexported (golint)
  • Line 178: warning: exported method Herd.LockWithTimeout should have comment or be unexported (golint)
  • Line 182: warning: exported method Herd.MdbUpdate should have comment or be unexported (golint)
  • Line 186: warning: exported method Herd.PollNextSub should have comment or be unexported (golint)
  • Line 190: warning: exported method Herd.RLockWithTimeout should have comment or be unexported (golint)
  • Line 194: warning: exported method Herd.SetDefaultImage should have comment or be unexported (golint)
  • Line 198: warning: exported method Herd.StartServer should have comment or be unexported (golint)

• Dominator/lib/objectserver/filesystem/garbageCollector.go
  • Line 44: warning: receiver name t should be consistent with previous receiver name objSrv for ObjectServer (golint)
  • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/slavedriver/api.go
  • Line 12: warning: exported type SlaveTrader should have comment or be unexported (golint)
  • Line 18: warning: exported type SlaveDriver should have comment or be unexported (golint)
  • Line 29: warning: exported type SlaveDriverOptions should have comment or be unexported (golint)
  • Line 37: warning: exported type SlaveInfo should have comment or be unexported (golint)
  • Line 42: warning: exported type Slave should have comment or be unexported (golint)
  • Line 50: warning: exported function NewSlaveDriver should have comment or be unexported (golint)
  • Line 55: warning: exported method SlaveDriver.GetSlave should have comment or be unexported (golint)
  • Line 59: warning: exported method SlaveDriver.WriteHtml should have comment or be unexported (golint)
  • Line 63: warning: exported method Slave.Destroy should have comment or be unexported (golint)
  • Line 67: warning: exported method Slave.GetClient should have comment or be unexported (golint)
  • Line 71: warning: exported method Slave.Release should have comment or be unexported (golint)

• Dominator/fleetmanager/hypervisors/fsstorer/vm.go
  • Line 16: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 33: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 70: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Dominator/hypervisor/metadatad/api.go
  • Line 26: warning: exported function StartServer should have comment or be unexported (golint)

• Dominator/cmd/hyper-control/netbootHost.go
  • Line 150: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 189: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 192: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/imageunpacker/rpcd/api.go
  • Line 24: warning: exported function Setup should have comment or be unexported (golint)

• Dominator/lib/stringutil/api.go
  • Line 5: warning: exported type StringDeduplicator should have comment or be unexported (golint)
  • Line 12: warning: exported type StringDuplicationStatistics should have comment or be unexported (golint)

• Dominator/lib/objectserver/filesystem/api.go
  • Line 21: warning: exported type ObjectServer should have comment or be unexported (golint)
  • Line 32: warning: exported function NewObjectServer should have comment or be unexported (golint)
  • Line 48: warning: exported method ObjectServer.CheckObjects should have comment or be unexported (golint)
  • Line 57: warning: exported method ObjectServer.DeleteObject should have comment or be unexported (golint)
  • Line 61: warning: exported method ObjectServer.DeleteStashedObject should have comment or be unexported (golint)
  • Line 65: warning: exported method ObjectServer.SetAddCallback should have comment or be unexported (golint)
  • Line 69: warning: exported method ObjectServer.SetGarbageCollector should have comment or be unexported (golint)
  • Line 74: warning: exported method ObjectServer.GetObject should have comment or be unexported (golint)
  • Line 79: warning: exported method ObjectServer.GetObjects should have comment or be unexported (golint)
  • Line 84: warning: exported method ObjectServer.LastMutationTime should have comment or be unexported (golint)
  • Line 90: warning: exported method ObjectServer.ListObjectSizes should have comment or be unexported (golint)
  • Line 94: warning: exported method ObjectServer.ListObjects should have comment or be unexported (golint)
  • Line 98: warning: exported method ObjectServer.NumObjects should have comment or be unexported (golint)
  • Line 116: warning: exported method ObjectServer.WriteHtml should have comment or be unexported (golint)
  • Line 120: warning: exported type ObjectsReader should have comment or be unexported (golint)
  • Line 127: warning: exported method ObjectsReader.Close should have comment or be unexported (golint)
  • Line 131: warning: exported method ObjectsReader.NextObject should have comment or be unexported (golint)
  • Line 135: warning: exported method ObjectsReader.ObjectSizes should have comment or be unexported (golint)

• Dominator/lib/concurrent/api.go
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 32: warning: exported function NewStateWithLinearConcurrencyIncrease should have comment or be unexported (golint)

• Dominator/lib/flagutil/api.go
  • Line 1: warning: package comment should not have leading space (golint)

• Dominator/cmd/vm-control/connectToVmConsole.go
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Dominator/lib/filesystem/util/api.go
  • Line 15: warning: exported type BootInfoType should have comment or be unexported (golint)
  • Line 24: warning: exported type ComputedFile should have comment or be unexported (golint)
  • Line 29: warning: exported type ComputedFilesData should have comment or be unexported (golint)
  • Line 42: warning: exported function DeletedFilteredFiles should have comment or be unexported (golint)
  • Line 46: warning: exported function GetBootInfo should have comment or be unexported (golint)
  • Line 51: warning: exported function GetUnsupportedExt4fsOptions should have comment or be unexported (golint)
  • Line 56: warning: exported function LoadComputedFiles should have comment or be unexported (golint)
  • Line 60: warning: exported function MakeBootable should have comment or be unexported (golint)
  • Line 67: warning: exported function MakeExt4fs should have comment or be unexported (golint)
  • Line 73: warning: exported function MakeKernelOptions should have comment or be unexported (golint)
  • Line 78: warning: exported function ReplaceComputedFiles should have comment or be unexported (golint)
  • Line 85: warning: exported function SpliceComputedFiles should have comment or be unexported (golint)
  • Line 90: warning: exported function Unpack should have comment or be unexported (golint)
  • Line 95: warning: exported method BootInfoType.WriteBootloaderConfig should have comment or be unexported (golint)
  • Line 100: warning: exported function WriteFstabEntry should have comment or be unexported (golint)
  • Line 107: warning: exported type WriteRawOptions should have comment or be unexported (golint)
  • Line 117: warning: exported function WriteRaw should have comment or be unexported (golint)
  • Line 133: warning: exported function WriteRawWithOptions should have comment or be unexported (golint)

• Dominator/lib/net/rrdialer/impl.go
  • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 117: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 132: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• Dominator/cmd/builder-tool/buildRaw.go
  • Line 88: warning: ineffectual assignment to err (ineffassign)

• Dominator/imagebuilder/builder/processManifest.go
  • Line 87: warning: ineffectual assignment to directoriesToDelete (ineffassign)

• Dominator/hypervisor/manager/vm.go
  • Line 1806: warning: ineffectual assignment to startTime (ineffassign)

misspell99%

Misspell Finds commonly misspelled English words

• Dominator/sub/lib/update.go
  • Line 67: warning: "Hardlinked" is a misspelling of "Hardline" (misspell)

• Dominator/dom/lib/buildUpdateRequest.go
  • Line 348: warning: "hardlinked" is a misspelling of "hardline" (misspell)

• Dominator/dom/lib/buildUpdateRequest_test.go
  • Line 115: warning: "hardlinked" is a misspelling of "hardline" (misspell)
  • Line 164: warning: "hardlinked" is a misspelling of "hardline" (misspell)
  • Line 192: warning: "hardlinked" is a misspelling of "hardline" (misspell)

• Dominator/lib/filesystem/scanner/walk.go
  • Line 202: warning: "hardlinked" is a misspelling of "hardline" (misspell)