Report for github.com/TarantulaTechnology/fabric
(v0.0.0-20160907010646-1d5e6b2922f2)
A+ Excellent! Found 83 issues across 333 files
gofmt84%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
consensus/executor/executor_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/chaincode/shim/chaincode.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/chaintool/example02/src/chaincode/chaincode_example02.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
tools/dbutility/dump_db_stats.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
consensus/obcpbft/obc-sieve.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
protos/transaction.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/container/dockercontroller/dockercontroller.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/chaincode/handler.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/chaincode/shim/handler.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/primitives/ecies/spi_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/statemgmt/trie/pkg_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/go/asset_management/app/app_internal.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
protos/block.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/validator_confidentiality.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/ledger.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/statemgmt/buckettree/bucket_hash.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/statemgmt/buckettree/pkg_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/tca.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/primitives/primitives_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/go/asset_management/asset_management.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/eca.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/tlsca_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/client_tca.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/devops.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/primitives/x509.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/statemgmt/state_delta.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/peer/handler.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/go/asset_management_with_roles/asset_management_with_roles.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
protos/block_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/go/utxo/util/utxo_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/go/rbac_tcerts_no_attrs/rbac.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/aca_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/eca_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/container/vm.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/statemgmt/trie/trie_node.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/go/rbac_tcerts_no_attrs/rbac_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
consensus/obcpbft/mock_utilities_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/tca_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/tlsca.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/node_eca.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/attributes/attributes_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
events/events_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/rest/api.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/blockchain_indexes.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/ledger/statemgmt/buckettree/bucket_node.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
examples/chaincode/go/utxo/store.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/client_tx.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/node_tlsca.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
core/crypto/peer_impl.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
membersrvc/ca/ca.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint93%
Golint is a linter for Go source code.
-
-
core/system_chaincode/systemchaincode_test.go
- Line 17: warning: don't use an underscore in package name (golint)
-
-
consensus/executor/executor_test.go
- Line 161: warning: error should be the last type when returning multiple items (golint)
-
-
consensus/noops/noops.go
- Line 312: warning: comment on exported method Noops.StateUpdated should be of the form "StateUpdated ..." (golint)
-
-
core/system_chaincode/importsysccs.go
- Line 17: warning: don't use an underscore in package name (golint)
-
-
core/system_chaincode/config.go
- Line 17: warning: don't use an underscore in package name (golint)
-
-
core/peer/config.go
- Line 138: warning: exported function GetPeerEndpoint should have comment or be unexported (golint)
- Line 177: warning: exported function SecurityEnabled should have comment or be unexported (golint)
-
-
examples/chaincode/go/chaincode_example02/chaincode_example02.go
- Line 37: warning: exported method SimpleChaincode.Init should have comment or be unexported (golint)
- Line 73: warning: comment on exported method SimpleChaincode.Invoke should be of the form "Invoke ..." (golint)
-
-
core/chaincode/platforms/platforms.go
- Line 28: warning: comment on exported type Platform should be of the form "Platform ..." (with optional leading article) (golint)
-
-
consensus/executor/executor.go
- Line 49: warning: comment on exported function NewImpl should be of the form "NewImpl ..." (golint)
-
-
core/devops.go
- Line 311: warning: don't use underscores in Go names; method EXP_GetApplicationTCert should be EXPGetApplicationTCert (golint)
- Line 340: warning: don't use underscores in Go names; method EXP_PrepareForTx should be EXPPrepareForTx (golint)
- Line 377: warning: don't use underscores in Go names; method EXP_ProduceSigma should be EXPProduceSigma (golint)
- Line 428: warning: don't use underscores in Go names; method EXP_ExecuteWithBinding should be EXPExecuteWithBinding (golint)
-
-
core/chaincode/shim/chaincode.go
- Line 834: warning: comment on exported method ChaincodeStub.SetEvent should be of the form "SetEvent ..." (golint)
-
-
core/ledger/testutil/test_util.go
- Line 36: warning: exported type TestRandomNumberGenerator should have comment or be unexported (golint)
- Line 41: warning: exported function NewTestRandomNumberGenerator should have comment or be unexported (golint)
- Line 48: warning: exported method TestRandomNumberGenerator.Next should have comment or be unexported (golint)
- Line 52: warning: exported function SetupTestConfig should have comment or be unexported (golint)
- Line 71: warning: exported function SetLogLevel should have comment or be unexported (golint)
- Line 75: warning: exported function ParseTestParams should have comment or be unexported (golint)
- Line 86: warning: exported function AssertNil should have comment or be unexported (golint)
- Line 92: warning: exported function AssertNotNil should have comment or be unexported (golint)
- Line 98: warning: exported function AssertSame should have comment or be unexported (golint)
- Line 105: warning: exported function AssertEquals should have comment or be unexported (golint)
- Line 115: warning: exported function AssertNotEquals should have comment or be unexported (golint)
- Line 121: warning: exported function AssertError should have comment or be unexported (golint)
- Line 127: warning: exported function AssertNoError should have comment or be unexported (golint)
- Line 133: warning: exported function AssertContains should have comment or be unexported (golint)
- Line 143: warning: exported function AssertContainsAll should have comment or be unexported (golint)
- Line 161: warning: exported function AssertPanic should have comment or be unexported (golint)
- Line 170: warning: exported function ComputeCryptoHash should have comment or be unexported (golint)
- Line 174: warning: exported function AppendAll should have comment or be unexported (golint)
- Line 182: warning: exported function GenerateUUID should have comment or be unexported (golint)
- Line 187: warning: exported function ConstructRandomBytes should have comment or be unexported (golint)
-
-
examples/chaincode/go/utxo/consensus/consensus.go
- Line 85: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 90: warning: don't use underscores in Go names; var Swig_escape_always_false should be SwigEscapeAlwaysFalse (golint)
- Line 90: warning: exported var Swig_escape_always_false should have comment or be unexported (golint)
- Line 91: warning: don't use underscores in Go names; var Swig_escape_val should be SwigEscapeVal (golint)
- Line 91: warning: exported var Swig_escape_val should have comment or be unexported (golint)
- Line 93: warning: don't use underscores in Go names; type _swig_fnptr should be _swigFnptr (golint)
- Line 94: warning: don't use underscores in Go names; type _swig_memberptr should be _swigMemberptr (golint)
- Line 98: warning: exported function Swig_free should have comment or be unexported (golint)
- Line 98: warning: don't use underscores in Go names; func Swig_free should be SwigFree (golint)
- Line 99: warning: don't use underscores in Go names; var _swig_i_0 should be _swigI0 (golint)
- Line 103: warning: exported const LIBBITCOIN_CONSENSUS_VERSION should have comment or be unexported (golint)
- Line 104: warning: exported const LIBBITCOIN_CONSENSUS_MAJOR_VERSION should have comment or be unexported (golint)
- Line 105: warning: exported const LIBBITCOIN_CONSENSUS_MINOR_VERSION should have comment or be unexported (golint)
- Line 106: warning: exported const LIBBITCOIN_CONSENSUS_PATCH_VERSION should have comment or be unexported (golint)
- Line 108: warning: don't use underscores in Go names; type LibbitcoinConsensusVerify_result_type should be LibbitcoinConsensusVerifyResultType (golint)
- Line 108: warning: exported type LibbitcoinConsensusVerify_result_type should have comment or be unexported (golint)
- Line 110: warning: don't use underscores in Go names; func _swig_getverify_result_eval_false should be _swigGetverifyResultEvalFalse (golint)
- Line 110: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 111: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 116: warning: don't use underscores in Go names; var Verify_result_eval_false should be VerifyResultEvalFalse (golint)
- Line 116: warning: exported var Verify_result_eval_false should have comment or be unexported (golint)
- Line 118: warning: don't use underscores in Go names; func _swig_getverify_result_eval_true should be _swigGetverifyResultEvalTrue (golint)
- Line 118: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 119: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 124: warning: don't use underscores in Go names; var Verify_result_eval_true should be VerifyResultEvalTrue (golint)
- Line 124: warning: exported var Verify_result_eval_true should have comment or be unexported (golint)
- Line 126: warning: don't use underscores in Go names; func _swig_getverify_result_script_size should be _swigGetverifyResultScriptSize (golint)
- Line 126: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 127: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 132: warning: don't use underscores in Go names; var Verify_result_script_size should be VerifyResultScriptSize (golint)
- Line 132: warning: exported var Verify_result_script_size should have comment or be unexported (golint)
- Line 134: warning: don't use underscores in Go names; func _swig_getverify_result_push_size should be _swigGetverifyResultPushSize (golint)
- Line 134: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 135: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 140: warning: don't use underscores in Go names; var Verify_result_push_size should be VerifyResultPushSize (golint)
- Line 140: warning: exported var Verify_result_push_size should have comment or be unexported (golint)
- Line 142: warning: don't use underscores in Go names; func _swig_getverify_result_op_count should be _swigGetverifyResultOpCount (golint)
- Line 142: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 143: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 148: warning: don't use underscores in Go names; var Verify_result_op_count should be VerifyResultOpCount (golint)
- Line 148: warning: exported var Verify_result_op_count should have comment or be unexported (golint)
- Line 150: warning: don't use underscores in Go names; func _swig_getverify_result_stack_size should be _swigGetverifyResultStackSize (golint)
- Line 150: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 151: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 156: warning: don't use underscores in Go names; var Verify_result_stack_size should be VerifyResultStackSize (golint)
- Line 156: warning: exported var Verify_result_stack_size should have comment or be unexported (golint)
- Line 158: warning: don't use underscores in Go names; func _swig_getverify_result_sig_count should be _swigGetverifyResultSigCount (golint)
- Line 158: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 159: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 164: warning: don't use underscores in Go names; var Verify_result_sig_count should be VerifyResultSigCount (golint)
- Line 164: warning: exported var Verify_result_sig_count should have comment or be unexported (golint)
- Line 166: warning: don't use underscores in Go names; func _swig_getverify_result_pubkey_count should be _swigGetverifyResultPubkeyCount (golint)
- Line 166: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 167: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 172: warning: don't use underscores in Go names; var Verify_result_pubkey_count should be VerifyResultPubkeyCount (golint)
- Line 172: warning: exported var Verify_result_pubkey_count should have comment or be unexported (golint)
- Line 174: warning: don't use underscores in Go names; func _swig_getverify_result_verify should be _swigGetverifyResultVerify (golint)
- Line 174: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 175: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 180: warning: don't use underscores in Go names; var Verify_result_verify should be VerifyResultVerify (golint)
- Line 180: warning: exported var Verify_result_verify should have comment or be unexported (golint)
- Line 182: warning: don't use underscores in Go names; func _swig_getverify_result_equalverify should be _swigGetverifyResultEqualverify (golint)
- Line 182: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 183: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 188: warning: don't use underscores in Go names; var Verify_result_equalverify should be VerifyResultEqualverify (golint)
- Line 188: warning: exported var Verify_result_equalverify should have comment or be unexported (golint)
- Line 190: warning: don't use underscores in Go names; func _swig_getverify_result_checkmultisigverify should be _swigGetverifyResultCheckmultisigverify (golint)
- Line 190: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 191: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 196: warning: don't use underscores in Go names; var Verify_result_checkmultisigverify should be VerifyResultCheckmultisigverify (golint)
- Line 196: warning: exported var Verify_result_checkmultisigverify should have comment or be unexported (golint)
- Line 198: warning: don't use underscores in Go names; func _swig_getverify_result_checksigverify should be _swigGetverifyResultChecksigverify (golint)
- Line 198: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 199: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 204: warning: don't use underscores in Go names; var Verify_result_checksigverify should be VerifyResultChecksigverify (golint)
- Line 204: warning: exported var Verify_result_checksigverify should have comment or be unexported (golint)
- Line 206: warning: don't use underscores in Go names; func _swig_getverify_result_numequalverify should be _swigGetverifyResultNumequalverify (golint)
- Line 206: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 207: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 212: warning: don't use underscores in Go names; var Verify_result_numequalverify should be VerifyResultNumequalverify (golint)
- Line 212: warning: exported var Verify_result_numequalverify should have comment or be unexported (golint)
- Line 214: warning: don't use underscores in Go names; func _swig_getverify_result_bad_opcode should be _swigGetverifyResultBadOpcode (golint)
- Line 214: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 215: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 220: warning: don't use underscores in Go names; var Verify_result_bad_opcode should be VerifyResultBadOpcode (golint)
- Line 220: warning: exported var Verify_result_bad_opcode should have comment or be unexported (golint)
- Line 222: warning: don't use underscores in Go names; func _swig_getverify_result_disabled_opcode should be _swigGetverifyResultDisabledOpcode (golint)
- Line 222: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 223: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 228: warning: don't use underscores in Go names; var Verify_result_disabled_opcode should be VerifyResultDisabledOpcode (golint)
- Line 228: warning: exported var Verify_result_disabled_opcode should have comment or be unexported (golint)
- Line 230: warning: don't use underscores in Go names; func _swig_getverify_result_invalid_stack_operation should be _swigGetverifyResultInvalidStackOperation (golint)
- Line 230: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 231: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 236: warning: don't use underscores in Go names; var Verify_result_invalid_stack_operation should be VerifyResultInvalidStackOperation (golint)
- Line 236: warning: exported var Verify_result_invalid_stack_operation should have comment or be unexported (golint)
- Line 238: warning: don't use underscores in Go names; func _swig_getverify_result_invalid_altstack_operation should be _swigGetverifyResultInvalidAltstackOperation (golint)
- Line 238: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 239: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 244: warning: don't use underscores in Go names; var Verify_result_invalid_altstack_operation should be VerifyResultInvalidAltstackOperation (golint)
- Line 244: warning: exported var Verify_result_invalid_altstack_operation should have comment or be unexported (golint)
- Line 246: warning: don't use underscores in Go names; func _swig_getverify_result_unbalanced_conditional should be _swigGetverifyResultUnbalancedConditional (golint)
- Line 246: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 247: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 252: warning: don't use underscores in Go names; var Verify_result_unbalanced_conditional should be VerifyResultUnbalancedConditional (golint)
- Line 252: warning: exported var Verify_result_unbalanced_conditional should have comment or be unexported (golint)
- Line 254: warning: don't use underscores in Go names; func _swig_getverify_result_sig_hashtype should be _swigGetverifyResultSigHashtype (golint)
- Line 254: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 255: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 260: warning: don't use underscores in Go names; var Verify_result_sig_hashtype should be VerifyResultSigHashtype (golint)
- Line 260: warning: exported var Verify_result_sig_hashtype should have comment or be unexported (golint)
- Line 262: warning: don't use underscores in Go names; func _swig_getverify_result_sig_der should be _swigGetverifyResultSigDer (golint)
- Line 262: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 263: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 268: warning: don't use underscores in Go names; var Verify_result_sig_der should be VerifyResultSigDer (golint)
- Line 268: warning: exported var Verify_result_sig_der should have comment or be unexported (golint)
- Line 270: warning: don't use underscores in Go names; func _swig_getverify_result_minimaldata should be _swigGetverifyResultMinimaldata (golint)
- Line 270: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 271: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 276: warning: don't use underscores in Go names; var Verify_result_minimaldata should be VerifyResultMinimaldata (golint)
- Line 276: warning: exported var Verify_result_minimaldata should have comment or be unexported (golint)
- Line 278: warning: don't use underscores in Go names; func _swig_getverify_result_sig_pushonly should be _swigGetverifyResultSigPushonly (golint)
- Line 278: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 279: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 284: warning: don't use underscores in Go names; var Verify_result_sig_pushonly should be VerifyResultSigPushonly (golint)
- Line 284: warning: exported var Verify_result_sig_pushonly should have comment or be unexported (golint)
- Line 286: warning: don't use underscores in Go names; func _swig_getverify_result_sig_high_s should be _swigGetverifyResultSigHighS (golint)
- Line 286: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 287: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 292: warning: don't use underscores in Go names; var Verify_result_sig_high_s should be VerifyResultSigHighS (golint)
- Line 292: warning: exported var Verify_result_sig_high_s should have comment or be unexported (golint)
- Line 294: warning: don't use underscores in Go names; func _swig_getverify_result_sig_nulldummy should be _swigGetverifyResultSigNulldummy (golint)
- Line 294: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 295: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 300: warning: don't use underscores in Go names; var Verify_result_sig_nulldummy should be VerifyResultSigNulldummy (golint)
- Line 300: warning: exported var Verify_result_sig_nulldummy should have comment or be unexported (golint)
- Line 302: warning: don't use underscores in Go names; func _swig_getverify_result_pubkeytype should be _swigGetverifyResultPubkeytype (golint)
- Line 302: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 303: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 308: warning: don't use underscores in Go names; var Verify_result_pubkeytype should be VerifyResultPubkeytype (golint)
- Line 308: warning: exported var Verify_result_pubkeytype should have comment or be unexported (golint)
- Line 310: warning: don't use underscores in Go names; func _swig_getverify_result_cleanstack should be _swigGetverifyResultCleanstack (golint)
- Line 310: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 311: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 316: warning: don't use underscores in Go names; var Verify_result_cleanstack should be VerifyResultCleanstack (golint)
- Line 316: warning: exported var Verify_result_cleanstack should have comment or be unexported (golint)
- Line 318: warning: don't use underscores in Go names; func _swig_getverify_result_discourage_upgradable_nops should be _swigGetverifyResultDiscourageUpgradableNops (golint)
- Line 318: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 319: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 324: warning: don't use underscores in Go names; var Verify_result_discourage_upgradable_nops should be VerifyResultDiscourageUpgradableNops (golint)
- Line 324: warning: exported var Verify_result_discourage_upgradable_nops should have comment or be unexported (golint)
- Line 326: warning: don't use underscores in Go names; func _swig_getverify_result_op_return should be _swigGetverifyResultOpReturn (golint)
- Line 326: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 327: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 332: warning: don't use underscores in Go names; var Verify_result_op_return should be VerifyResultOpReturn (golint)
- Line 332: warning: exported var Verify_result_op_return should have comment or be unexported (golint)
- Line 334: warning: don't use underscores in Go names; func _swig_getverify_result_unknown_error should be _swigGetverifyResultUnknownError (golint)
- Line 334: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 335: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 340: warning: don't use underscores in Go names; var Verify_result_unknown_error should be VerifyResultUnknownError (golint)
- Line 340: warning: exported var Verify_result_unknown_error should have comment or be unexported (golint)
- Line 342: warning: don't use underscores in Go names; func _swig_getverify_result_tx_invalid should be _swigGetverifyResultTxInvalid (golint)
- Line 342: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 343: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 348: warning: don't use underscores in Go names; var Verify_result_tx_invalid should be VerifyResultTxInvalid (golint)
- Line 348: warning: exported var Verify_result_tx_invalid should have comment or be unexported (golint)
- Line 350: warning: don't use underscores in Go names; func _swig_getverify_result_tx_size_invalid should be _swigGetverifyResultTxSizeInvalid (golint)
- Line 350: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 351: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 356: warning: don't use underscores in Go names; var Verify_result_tx_size_invalid should be VerifyResultTxSizeInvalid (golint)
- Line 356: warning: exported var Verify_result_tx_size_invalid should have comment or be unexported (golint)
- Line 358: warning: don't use underscores in Go names; func _swig_getverify_result_tx_input_invalid should be _swigGetverifyResultTxInputInvalid (golint)
- Line 358: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 359: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 364: warning: don't use underscores in Go names; var Verify_result_tx_input_invalid should be VerifyResultTxInputInvalid (golint)
- Line 364: warning: exported var Verify_result_tx_input_invalid should have comment or be unexported (golint)
- Line 366: warning: don't use underscores in Go names; func _swig_getverify_result_negative_locktime should be _swigGetverifyResultNegativeLocktime (golint)
- Line 366: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 367: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 372: warning: don't use underscores in Go names; var Verify_result_negative_locktime should be VerifyResultNegativeLocktime (golint)
- Line 372: warning: exported var Verify_result_negative_locktime should have comment or be unexported (golint)
- Line 374: warning: don't use underscores in Go names; func _swig_getverify_result_unsatisfied_locktime should be _swigGetverifyResultUnsatisfiedLocktime (golint)
- Line 374: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 375: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 380: warning: don't use underscores in Go names; var Verify_result_unsatisfied_locktime should be VerifyResultUnsatisfiedLocktime (golint)
- Line 380: warning: exported var Verify_result_unsatisfied_locktime should have comment or be unexported (golint)
- Line 382: warning: don't use underscores in Go names; type LibbitcoinConsensusVerify_flags_type should be LibbitcoinConsensusVerifyFlagsType (golint)
- Line 382: warning: exported type LibbitcoinConsensusVerify_flags_type should have comment or be unexported (golint)
- Line 384: warning: don't use underscores in Go names; func _swig_getverify_flags_none should be _swigGetverifyFlagsNone (golint)
- Line 384: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 385: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 390: warning: don't use underscores in Go names; var Verify_flags_none should be VerifyFlagsNone (golint)
- Line 390: warning: exported var Verify_flags_none should have comment or be unexported (golint)
- Line 392: warning: don't use underscores in Go names; func _swig_getverify_flags_p2sh should be _swigGetverifyFlagsP2sh (golint)
- Line 392: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 393: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 398: warning: don't use underscores in Go names; var Verify_flags_p2sh should be VerifyFlagsP2sh (golint)
- Line 398: warning: exported var Verify_flags_p2sh should have comment or be unexported (golint)
- Line 400: warning: don't use underscores in Go names; func _swig_getverify_flags_strictenc should be _swigGetverifyFlagsStrictenc (golint)
- Line 400: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 401: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 406: warning: don't use underscores in Go names; var Verify_flags_strictenc should be VerifyFlagsStrictenc (golint)
- Line 406: warning: exported var Verify_flags_strictenc should have comment or be unexported (golint)
- Line 408: warning: don't use underscores in Go names; func _swig_getverify_flags_dersig should be _swigGetverifyFlagsDersig (golint)
- Line 408: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 409: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 414: warning: don't use underscores in Go names; var Verify_flags_dersig should be VerifyFlagsDersig (golint)
- Line 414: warning: exported var Verify_flags_dersig should have comment or be unexported (golint)
- Line 416: warning: don't use underscores in Go names; func _swig_getverify_flags_low_s should be _swigGetverifyFlagsLowS (golint)
- Line 416: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 417: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 422: warning: don't use underscores in Go names; var Verify_flags_low_s should be VerifyFlagsLowS (golint)
- Line 422: warning: exported var Verify_flags_low_s should have comment or be unexported (golint)
- Line 424: warning: don't use underscores in Go names; func _swig_getverify_flags_nulldummy should be _swigGetverifyFlagsNulldummy (golint)
- Line 424: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 425: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 430: warning: don't use underscores in Go names; var Verify_flags_nulldummy should be VerifyFlagsNulldummy (golint)
- Line 430: warning: exported var Verify_flags_nulldummy should have comment or be unexported (golint)
- Line 432: warning: don't use underscores in Go names; func _swig_getverify_flags_sigpushonly should be _swigGetverifyFlagsSigpushonly (golint)
- Line 432: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 433: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 438: warning: don't use underscores in Go names; var Verify_flags_sigpushonly should be VerifyFlagsSigpushonly (golint)
- Line 438: warning: exported var Verify_flags_sigpushonly should have comment or be unexported (golint)
- Line 440: warning: don't use underscores in Go names; func _swig_getverify_flags_minimaldata should be _swigGetverifyFlagsMinimaldata (golint)
- Line 440: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 441: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 446: warning: don't use underscores in Go names; var Verify_flags_minimaldata should be VerifyFlagsMinimaldata (golint)
- Line 446: warning: exported var Verify_flags_minimaldata should have comment or be unexported (golint)
- Line 448: warning: don't use underscores in Go names; func _swig_getverify_flags_discourage_upgradable_nops should be _swigGetverifyFlagsDiscourageUpgradableNops (golint)
- Line 448: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 449: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 454: warning: don't use underscores in Go names; var Verify_flags_discourage_upgradable_nops should be VerifyFlagsDiscourageUpgradableNops (golint)
- Line 454: warning: exported var Verify_flags_discourage_upgradable_nops should have comment or be unexported (golint)
- Line 456: warning: don't use underscores in Go names; func _swig_getverify_flags_cleanstack should be _swigGetverifyFlagsCleanstack (golint)
- Line 456: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 457: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 462: warning: don't use underscores in Go names; var Verify_flags_cleanstack should be VerifyFlagsCleanstack (golint)
- Line 462: warning: exported var Verify_flags_cleanstack should have comment or be unexported (golint)
- Line 464: warning: don't use underscores in Go names; func _swig_getverify_flags_checklocktimeverify should be _swigGetverifyFlagsChecklocktimeverify (golint)
- Line 464: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 465: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 470: warning: don't use underscores in Go names; var Verify_flags_checklocktimeverify should be VerifyFlagsChecklocktimeverify (golint)
- Line 470: warning: exported var Verify_flags_checklocktimeverify should have comment or be unexported (golint)
- Line 472: warning: exported function Verify_script should have comment or be unexported (golint)
- Line 472: warning: don't use underscores in Go names; func Verify_script should be VerifyScript (golint)
- Line 472: warning: don't use underscores in Go names; func result _swig_ret should be _swigRet (golint)
- Line 473: warning: don't use underscores in Go names; var swig_r should be swigR (golint)
- Line 474: warning: don't use underscores in Go names; var _swig_i_0 should be _swigI0 (golint)
- Line 475: warning: don't use underscores in Go names; var _swig_i_1 should be _swigI1 (golint)
- Line 476: warning: don't use underscores in Go names; var _swig_i_2 should be _swigI2 (golint)
- Line 477: warning: don't use underscores in Go names; var _swig_i_3 should be _swigI3 (golint)
- Line 478: warning: don't use underscores in Go names; var _swig_i_4 should be _swigI4 (golint)
- Line 479: warning: don't use underscores in Go names; var _swig_i_5 should be _swigI5 (golint)
-
-
core/peer/statetransfer/statetransfer.go
- Line 106: warning: error should be the last type when returning multiple items (golint)
- Line 619: warning: error should be the last type when returning multiple items (golint)
-
-
core/crypto/node_ks.go
- Line 31: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
-
-
core/chaincode/shim/crypto/ecdsa/ecdsa.go
- Line 65: warning: exported function NewX509ECDSASignatureVerifier should have comment or be unexported (golint)
-
-
core/chaincode/handler.go
- Line 335: warning: context.Context should be the first parameter of a function (golint)
-
-
examples/chaincode/chaintool/example02/src/chaincode/chaincode_example02.go
- Line 32: warning: exported type ChaincodeExample should have comment or be unexported (golint)
- Line 35: warning: comment on exported method ChaincodeExample.Init should be of the form "Init ..." (golint)
- Line 56: warning: comment on exported method ChaincodeExample.MakePayment should be of the form "MakePayment ..." (golint)
- Line 92: warning: comment on exported method ChaincodeExample.DeleteAccount should be of the form "DeleteAccount ..." (golint)
- Line 104: warning: comment on exported method ChaincodeExample.CheckBalance should be of the form "CheckBalance ..." (golint)
- Line 131: warning: comment on exported method ChaincodeExample.PutState should be of the form "PutState ..." (golint)
- Line 138: warning: exported method ChaincodeExample.GetState should have comment or be unexported (golint)
-
-
core/ledger/ledger.go
- Line 383: warning: comment on exported method Ledger.GetTransactionResultByUUID should be of the form "GetTransactionResultByUUID ..." (golint)
-
-
examples/chaincode/go/chaincode_example01/chaincode_example01.go
- Line 31: warning: exported var B should have its own declaration (golint)
- Line 32: warning: exported var Bval should have its own declaration (golint)
- Line 72: warning: exported method SimpleChaincode.Invoke should have comment or be unexported (golint)
gocyclo92%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
core/crypto/node_eca.go
- Line 331: warning: cyclomatic complexity 19 of function (*nodeImpl).getEnrollmentCertificateFromECA() is high (> 15) (gocyclo)
-
-
core/crypto/client_confidentiality.go
- Line 94: warning: cyclomatic complexity 17 of function (*clientImpl).encryptTxVersion1_2() is high (> 15) (gocyclo)
-
-
core/crypto/primitives/primitives_test.go
- Line 198: warning: cyclomatic complexity 39 of function TestECDSAKeys() is high (> 15) (gocyclo)
- Line 418: warning: cyclomatic complexity 17 of function TestX509() is high (> 15) (gocyclo)
- Line 135: warning: cyclomatic complexity 16 of function TestECDSA() is high (> 15) (gocyclo)
-
-
consensus/obcpbft/viewchange.go
- Line 314: warning: cyclomatic complexity 29 of function (*pbftCore).processNewView() is high (> 15) (gocyclo)
- Line 581: warning: cyclomatic complexity 25 of function (*pbftCore).assignSequenceNumbers() is high (> 15) (gocyclo)
- Line 184: warning: cyclomatic complexity 16 of function (*pbftCore).recvViewChange() is high (> 15) (gocyclo)
-
-
peer/main.go
- Line 390: warning: cyclomatic complexity 23 of function serve() is high (> 15) (gocyclo)
- Line 902: warning: cyclomatic complexity 22 of function chaincodeInvokeOrQuery() is high (> 15) (gocyclo)
-
-
core/peer/statetransfer/statetransfer.go
- Line 318: warning: cyclomatic complexity 23 of function (*coordinatorImpl).syncBlocks() is high (> 15) (gocyclo)
- Line 715: warning: cyclomatic complexity 20 of function (*coordinatorImpl).playStateUpToBlockNumber() is high (> 15) (gocyclo)
- Line 465: warning: cyclomatic complexity 17 of function (*coordinatorImpl).verifyAndRecoverBlockchain() is high (> 15) (gocyclo)
- Line 619: warning: cyclomatic complexity 16 of function (*coordinatorImpl).attemptStateTransfer() is high (> 15) (gocyclo)
-
-
core/chaincode/exectransaction.go
- Line 32: warning: cyclomatic complexity 22 of function Execute() is high (> 15) (gocyclo)
-
-
tools/busywork/counters/counters.go
- Line 135: warning: cyclomatic complexity 19 of function (*counters).incDec() is high (> 15) (gocyclo)
-
-
core/crypto/node_conf.go
- Line 68: warning: cyclomatic complexity 16 of function (*configuration).init() is high (> 15) (gocyclo)
-
-
bddtests/chaincode/go/table/table.go
- Line 63: warning: cyclomatic complexity 38 of function (*SimpleChaincode).Invoke() is high (> 15) (gocyclo)
- Line 289: warning: cyclomatic complexity 32 of function (*SimpleChaincode).Query() is high (> 15) (gocyclo)
-
-
consensus/obcpbft/pbft-core.go
- Line 311: warning: cyclomatic complexity 28 of function (*pbftCore).ProcessEvent() is high (> 15) (gocyclo)
- Line 550: warning: cyclomatic complexity 18 of function (*pbftCore).recvMsg() is high (> 15) (gocyclo)
- Line 703: warning: cyclomatic complexity 16 of function (*pbftCore).recvPrePrepare() is high (> 15) (gocyclo)
-
-
core/rest/rest_api.go
- Line 1110: warning: cyclomatic complexity 22 of function (*ServerOpenchainREST).ProcessChaincode() is high (> 15) (gocyclo)
- Line 958: warning: cyclomatic complexity 17 of function (*ServerOpenchainREST).Query() is high (> 15) (gocyclo)
- Line 672: warning: cyclomatic complexity 16 of function (*ServerOpenchainREST).Deploy() is high (> 15) (gocyclo)
-
-
membersrvc/ca/eca.go
- Line 276: warning: cyclomatic complexity 20 of function (*ECAP).CreateCertificatePair() is high (> 15) (gocyclo)
-
-
core/peer/statetransfer/statetransfer_mock_test.go
- Line 708: warning: cyclomatic complexity 19 of function TestMockLedger() is high (> 15) (gocyclo)
- Line 379: warning: cyclomatic complexity 17 of function (*MockLedger).getRemoteStateDeltas() is high (> 15) (gocyclo)
-
-
core/crypto/client_tca.go
- Line 379: warning: cyclomatic complexity 17 of function (*clientImpl).getTCertsFromTCA() is high (> 15) (gocyclo)
-
-
core/crypto/crypto_test.go
- Line 1081: warning: cyclomatic complexity 33 of function TestValidatorQueryTransaction() is high (> 15) (gocyclo)
- Line 1214: warning: cyclomatic complexity 21 of function TestValidatorStateEncryptor() is high (> 15) (gocyclo)
- Line 161: warning: cyclomatic complexity 19 of function TestParallelInitClose() is high (> 15) (gocyclo)
- Line 937: warning: cyclomatic complexity 18 of function TestValidatorDeployTransaction() is high (> 15) (gocyclo)
-
-
core/chaincode/chaincode_support.go
- Line 382: warning: cyclomatic complexity 24 of function (*ChaincodeSupport).Launch() is high (> 15) (gocyclo)
-
-
core/crypto/client_tcert_pool_mt.go
- Line 117: warning: cyclomatic complexity 22 of function (*tCertPoolEntry).filler() is high (> 15) (gocyclo)
-
-
core/chaincode/shim/chaincode.go
- Line 387: warning: cyclomatic complexity 21 of function (*ChaincodeStub).CreateTable() is high (> 15) (gocyclo)
-
-
consensus/obcpbft/obc-batch.go
- Line 379: warning: cyclomatic complexity 19 of function (*obcBatch).ProcessEvent() is high (> 15) (gocyclo)
-
-
core/ledger/ledger_test.go
- Line 213: warning: cyclomatic complexity 17 of function TestLedgerSetRawState() is high (> 15) (gocyclo)
-
-
tools/busywork/benchmarks/benchmarks.go
- Line 49: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)
-
-
membersrvc/ca/aca.go
- Line 444: warning: cyclomatic complexity 20 of function (*ACAP).RequestAttributes() is high (> 15) (gocyclo)
-
-
core/crypto/primitives/aes/gcm_test.go
- Line 193: warning: cyclomatic complexity 18 of function TestAES256GSMSPI() is high (> 15) (gocyclo)
-
-
core/chaincode/shim/shim_test.go
- Line 31: warning: cyclomatic complexity 18 of function TestShimLogging() is high (> 15) (gocyclo)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!