Go Report Card

Preparing report...

Report for github.com/Venafi/vcert

A    Great!    Found 43 issues across 69 files

Tweet
Last refresh:

Refresh now

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo66%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • vcert/pkg/venafi/tpp/connector_test.go
    • Line 1631: warning: cyclomatic complexity 38 of function TestGetPolicy() is high (> 15) (gocyclo)
    • Line 1904: warning: cyclomatic complexity 17 of function TestSetPolicyValuesAndValidate() is high (> 15) (gocyclo)
    • Line 1813: warning: cyclomatic complexity 17 of function TestSetDefaultPolicyValuesAndValidate() is high (> 15) (gocyclo)
    • Line 1409: warning: cyclomatic complexity 16 of function TestEnrollWithLocation() is high (> 15) (gocyclo)
    • vcert/pkg/venafi/cloud/cloud.go
    • Line 544: warning: cyclomatic complexity 26 of function buildPolicySpecification() is high (> 15) (gocyclo)
    • Line 239: warning: cyclomatic complexity 16 of function (*Connector).request() is high (> 15) (gocyclo)
    • vcert/cmd/vcert/commands.go
    • Line 537: warning: cyclomatic complexity 37 of function doCommandCredMgmt1() is high (> 15) (gocyclo)
    • Line 998: warning: cyclomatic complexity 29 of function doCommandRenew1() is high (> 15) (gocyclo)
    • Line 363: warning: cyclomatic complexity 20 of function doCommandEnrollSshCert() is high (> 15) (gocyclo)
    • vcert/cmd/vcert/validators.go
    • Line 450: warning: cyclomatic complexity 45 of function validateRenewFlags1() is high (> 15) (gocyclo)
    • Line 238: warning: cyclomatic complexity 43 of function validateEnrollFlags() is high (> 15) (gocyclo)
    • Line 373: warning: cyclomatic complexity 25 of function validateCredMgmtFlags1() is high (> 15) (gocyclo)
    • Line 75: warning: cyclomatic complexity 24 of function validateCommonFlags() is high (> 15) (gocyclo)
    • Line 121: warning: cyclomatic complexity 22 of function validateConnectionFlags() is high (> 15) (gocyclo)
    • Line 191: warning: cyclomatic complexity 21 of function validateJKSFlags() is high (> 15) (gocyclo)
    • vcert/config.go
    • Line 49: warning: cyclomatic complexity 23 of function LoadConfigFromFile() is high (> 15) (gocyclo)
    • Line 170: warning: cyclomatic complexity 19 of function validateSection() is high (> 15) (gocyclo)
    • vcert/pkg/policy/policyUtils.go
    • Line 278: warning: cyclomatic complexity 91 of function BuildTppPolicy() is high (> 15) (gocyclo)
    • Line 875: warning: cyclomatic complexity 58 of function BuildCloudCitRequest() is high (> 15) (gocyclo)
    • Line 720: warning: cyclomatic complexity 57 of function ValidateCloudPolicySpecification() is high (> 15) (gocyclo)
    • Line 456: warning: cyclomatic complexity 32 of function BuildPolicySpecificationForTPP() is high (> 15) (gocyclo)
    • Line 164: warning: cyclomatic complexity 31 of function validateDefaultSubject() is high (> 15) (gocyclo)
    • Line 1152: warning: cyclomatic complexity 25 of function IsPolicyEmpty() is high (> 15) (gocyclo)
    • Line 215: warning: cyclomatic complexity 23 of function validateDefaultKeyPairWithPolicySubject() is high (> 15) (gocyclo)
    • Line 1242: warning: cyclomatic complexity 21 of function IsDefaultEmpty() is high (> 15) (gocyclo)
    • vcert/pkg/endpoint/endpoint.go
    • Line 209: warning: cyclomatic complexity 27 of function (*Policy).ValidateCertificateRequest() is high (> 15) (gocyclo)
    • Line 413: warning: cyclomatic complexity 19 of function (*ZoneConfiguration).UpdateCertificateRequest() is high (> 15) (gocyclo)
    • vcert/pkg/venafi/cloud/connector.go
    • Line 493: warning: cyclomatic complexity 33 of function (*Connector).RetrieveCertificate() is high (> 15) (gocyclo)
    • Line 637: warning: cyclomatic complexity 25 of function (*Connector).RenewCertificate() is high (> 15) (gocyclo)
    • Line 137: warning: cyclomatic complexity 25 of function (*Connector).SetPolicy() is high (> 15) (gocyclo)
    • vcert/pkg/venafi/tpp/connector.go
    • Line 739: warning: cyclomatic complexity 49 of function (*Connector).SetPolicy() is high (> 15) (gocyclo)
    • Line 431: warning: cyclomatic complexity 22 of function prepareRequest() is high (> 15) (gocyclo)
    • Line 1524: warning: cyclomatic complexity 17 of function resetTPPAttributes() is high (> 15) (gocyclo)
    • Line 586: warning: cyclomatic complexity 17 of function (*Connector).RequestCertificate() is high (> 15) (gocyclo)

golint55%

Golint is a linter for Go source code.

    • vcert/pkg/endpoint/endpoint.go
    • Line 34: warning: exported const SDKName should have comment or be unexported (golint)
    • Line 36: warning: exported var LocalIP should have comment or be unexported (golint)
    • Line 42: warning: exported const ConnectorTypeUndefined should have comment (or a comment on this block) or be unexported (golint)
    • Line 104: warning: exported type Filter should have comment or be unexported (golint)
    • Line 121: warning: comment on exported type ErrRetrieveCertificateTimeout should be of the form "ErrRetrieveCertificateTimeout ..." (with optional leading article) (golint)
    • Line 131: warning: comment on exported type ErrCertificatePending should be of the form "ErrCertificatePending ..." (with optional leading article) (golint)
    • Line 145: warning: exported type ErrCertificateRejected should have comment or be unexported (golint)
    • vcert/pkg/policy/policySpecification.go
    • Line 3: warning: exported type PolicySpecification should have comment or be unexported (golint)
    • Line 12: warning: exported type Policy should have comment or be unexported (golint)
    • Line 23: warning: exported type Subject should have comment or be unexported (golint)
    • Line 31: warning: exported type KeyPair should have comment or be unexported (golint)
    • Line 39: warning: exported type SubjectAltNames should have comment or be unexported (golint)
    • Line 47: warning: exported type Default should have comment or be unexported (golint)
    • Line 54: warning: exported type DefaultSubject should have comment or be unexported (golint)
    • Line 62: warning: exported type DefaultKeyPair should have comment or be unexported (golint)
    • vcert/pkg/venafi/tpp/sshCertUtils.go
    • Line 17: warning: exported const CaRootPath should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: exported function RequestSshCertificate should have comment or be unexported (golint)
    • Line 123: warning: exported function RetrieveSshCertificate should have comment or be unexported (golint)
    • vcert/pkg/policy/policyStructures.go
    • Line 3: warning: exported type PolicyPayloadRequest should have comment or be unexported (golint)
    • Line 8: warning: exported type PolicySetAttributePayloadRequest should have comment or be unexported (golint)
    • Line 16: warning: exported type PolicySetAttributeResponse should have comment or be unexported (golint)
    • Line 21: warning: exported type PolicyGetAttributePayloadRequest should have comment or be unexported (golint)
    • Line 28: warning: exported type PolicyExistPayloadRequest should have comment or be unexported (golint)
    • Line 32: warning: exported type PolicyIsValidResponse should have comment or be unexported (golint)
    • Line 38: warning: exported type PolicyGetAttributeResponse should have comment or be unexported (golint)
    • Line 44: warning: exported type CloudPolicyRequest should have comment or be unexported (golint)
    • Line 62: warning: exported type Product should have comment or be unexported (golint)
    • Line 71: warning: exported type KeyTypes should have comment or be unexported (golint)
    • Line 76: warning: exported type TrackingData should have comment or be unexported (golint)
    • Line 83: warning: exported type RecommendedSettings should have comment or be unexported (golint)
    • Line 95: warning: exported type Key should have comment or be unexported (golint)
    • Line 100: warning: exported type ApplicationCreateRequest should have comment or be unexported (golint)
    • Line 117: warning: exported type OwnerIdType should have comment or be unexported (golint)
    • Line 122: warning: exported type TppPolicy should have comment or be unexported (golint)
    • Line 153: warning: exported type LockedAttribute should have comment or be unexported (golint)
    • Line 157: warning: exported type LockedIntAttribute should have comment or be unexported (golint)
    • Line 161: warning: exported type LockedArrayAttribute should have comment or be unexported (golint)
    • Line 166: warning: exported type CertificateAuthorityInfo should have comment or be unexported (golint)
    • Line 172: warning: exported type Accounts should have comment or be unexported (golint)
    • Line 176: warning: exported type AccountDetails should have comment or be unexported (golint)
    • Line 181: warning: exported type Account should have comment or be unexported (golint)
    • Line 187: warning: exported type ProductOption should have comment or be unexported (golint)
    • Line 193: warning: exported type ProductDetails should have comment or be unexported (golint)
    • Line 197: warning: exported type ProductTemplate should have comment or be unexported (golint)
    • Line 201: warning: exported type PolicyObject should have comment or be unexported (golint)
    • Line 212: warning: exported type CheckPolicyResponse should have comment or be unexported (golint)
    • Line 217: warning: exported type PolicyResponse should have comment or be unexported (golint)
    • Line 235: warning: exported type KeyPairResponse should have comment or be unexported (golint)
    • Line 240: warning: exported type SubjectResponse should have comment or be unexported (golint)
    • Line 248: warning: exported type CheckPolicyRequest should have comment or be unexported (golint)
    • Line 252: warning: exported type ClearTTPAttributesRequest should have comment or be unexported (golint)
    • Line 258: warning: exported type CADetails should have comment or be unexported (golint)
    • vcert/pkg/certificate/certificate.go
    • Line 69: warning: exported const EllipticCurveNotSet should have comment (or a comment on this block) or be unexported (golint)
    • Line 81: warning: exported function AllSupportedCurves should have comment or be unexported (golint)
    • Line 84: warning: exported function AllSupportedKeySizes should have comment or be unexported (golint)
    • Line 102: warning: exported method KeyType.X509Type should have comment or be unexported (golint)
    • Line 132: warning: exported type CSrOriginOption should have comment or be unexported (golint)
    • Line 143: warning: exported type CustomFieldType should have comment or be unexported (golint)
    • Line 146: warning: exported const CustomFieldPlain should have comment (or a comment on this block) or be unexported (golint)
    • Line 163: warning: exported type Location should have comment or be unexported (golint)
    • Line 206: warning: comment on exported type SshCertRequest should be of the form "SshCertRequest ..." (with optional leading article) (golint)
    • Line 231: warning: exported type TPPSshCertRequest should have comment or be unexported (golint)
    • Line 245: warning: exported type TppSshCertRequestResponse should have comment or be unexported (golint)
    • Line 253: warning: exported type TppSshCertResponseInfo should have comment or be unexported (golint)
    • Line 259: warning: exported type TppSshCertRetrieveRequest should have comment or be unexported (golint)
    • Line 268: warning: exported type TppSshCertRetrieveResponse should have comment or be unexported (golint)
    • Line 281: warning: exported type SshCertRetrieveDetails should have comment or be unexported (golint)
    • Line 292: warning: exported type SshCertificateDetails should have comment or be unexported (golint)
    • Line 308: warning: exported type RevocationRequest should have comment or be unexported (golint)
    • Line 316: warning: exported type RenewalRequest should have comment or be unexported (golint)
    • Line 322: warning: exported type ImportRequest should have comment or be unexported (golint)
    • Line 332: warning: exported type ImportResponse should have comment or be unexported (golint)
    • Line 340: warning: exported type CertificateInfo should have comment or be unexported (golint)
    • Line 515: warning: exported function PublicKey should have comment or be unexported (golint)
    • vcert/cmd/vcert/utils.go
    • Line 52: warning: exported const JKSFormat should have comment (or a comment on this block) or be unexported (golint)
    • Line 374: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 666: warning: exported function AddLineEnding should have comment or be unexported (golint)
    • vcert/cmd/vcert/validators.go
    • Line 40: warning: comment on exported const JKSMinPasswordLen should be of the form "JKSMinPasswordLen ..." (golint)
    • Line 215: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 719: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 772: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • vcert/pkg/venafi/tpp/connector.go
    • Line 84: warning: exported method Connector.SetZone should have comment or be unexported (golint)
    • Line 88: warning: exported method Connector.GetType should have comment or be unexported (golint)
    • Line 150: warning: comment on exported method Connector.GetRefreshToken should be of the form "GetRefreshToken ..." (golint)
    • Line 187: warning: comment on exported method Connector.RefreshAccessToken should be of the form "RefreshAccessToken ..." (golint)
    • Line 206: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 665: warning: exported method Connector.GetPolicy should have comment or be unexported (golint)
    • Line 711: warning: exported function PolicyExist should have comment or be unexported (golint)
    • Line 739: warning: exported method Connector.SetPolicy should have comment or be unexported (golint)
    • Line 1163: warning: exported method Connector.ReadPolicyConfiguration should have comment or be unexported (golint)
    • Line 1235: warning: exported method Connector.ImportCertificate should have comment or be unexported (golint)
    • Line 1283: warning: exported method Connector.SetHTTPClient should have comment or be unexported (golint)
    • Line 1287: warning: exported method Connector.ListCertificates should have comment or be unexported (golint)
    • Line 1653: warning: exported method Connector.RequestSSHCertificate should have comment or be unexported (golint)
    • Line 1659: warning: exported method Connector.RetrieveSSHCertificate should have comment or be unexported (golint)
    • vcert/pkg/venafi/tpp/tpp.go
    • Line 106: warning: exported type RevocationReason should have comment or be unexported (golint)
    • Line 185: warning: don't use underscores in Go names; struct field Client_id should be ClientID (golint)
    • Line 186: warning: don't use underscores in Go names; struct field Refresh_token should be RefreshToken (golint)
    • Line 190: warning: don't use underscores in Go names; struct field Client_id should be ClientID (golint)
    • Line 195: warning: exported type OauthGetRefreshTokenResponse should have comment or be unexported (golint)
    • Line 196: warning: don't use underscores in Go names; struct field Access_token should be AccessToken (golint)
    • Line 199: warning: don't use underscores in Go names; struct field Refresh_token should be RefreshToken (golint)
    • Line 201: warning: don't use underscores in Go names; struct field Token_type should be TokenType (golint)
    • Line 205: warning: don't use underscores in Go names; struct field Refresh_token should be RefreshToken (golint)
    • Line 206: warning: don't use underscores in Go names; struct field Client_id should be ClientID (golint)
    • Line 210: warning: don't use underscores in Go names; struct field Client_id should be ClientID (golint)
    • Line 214: warning: exported type OauthRefreshAccessTokenResponse should have comment or be unexported (golint)
    • Line 215: warning: don't use underscores in Go names; struct field Access_token should be AccessToken (golint)
    • Line 218: warning: don't use underscores in Go names; struct field Refresh_token should be RefreshToken (golint)
    • Line 219: warning: don't use underscores in Go names; struct field Token_type should be TokenType (golint)
    • Line 222: warning: exported type OauthVerifyTokenResponse should have comment or be unexported (golint)
    • vcert/test/context.go
    • Line 23: warning: exported type Context should have comment or be unexported (golint)
    • Line 39: warning: exported function GetEnvContext should have comment or be unexported (golint)
    • vcert/pkg/policy/constants.go
    • Line 4: warning: exported const JsonExtension should have comment (or a comment on this block) or be unexported (golint)
    • Line 11: warning: comment on exported const TppContact should be of the form "TppContact ..." (golint)
    • vcert/pkg/policy/policyUtils.go
    • Line 10: warning: comment on exported var TppKeyType should be of the form "TppKeyType ..." (golint)
    • Line 13: warning: exported var TppRsaKeySize should have comment or be unexported (golint)
    • Line 14: warning: exported var CloudRsaKeySize should have comment or be unexported (golint)
    • Line 15: warning: exported var TppEllipticCurves should have comment or be unexported (golint)
    • Line 17: warning: exported function GetFileType should have comment or be unexported (golint)
    • Line 29: warning: exported function GetParent should have comment or be unexported (golint)
    • Line 35: warning: exported function ValidateTppPolicySpecification should have comment or be unexported (golint)
    • Line 278: warning: exported function BuildTppPolicy should have comment or be unexported (golint)
    • Line 456: warning: exported function BuildPolicySpecificationForTPP should have comment or be unexported (golint)
    • Line 720: warning: exported function ValidateCloudPolicySpecification should have comment or be unexported (golint)
    • Line 875: warning: exported function BuildCloudCitRequest should have comment or be unexported (golint)
    • Line 1075: warning: exported function ConvertToRegex should have comment or be unexported (golint)
    • Line 1093: warning: exported function RemoveRegex should have comment or be unexported (golint)
    • Line 1111: warning: exported function GetApplicationName should have comment or be unexported (golint)
    • Line 1119: warning: exported function GetCitName should have comment or be unexported (golint)
    • Line 1127: warning: exported function GetCertAuthorityInfo should have comment or be unexported (golint)
    • Line 1145: warning: exported function IsWildcardAllowed should have comment or be unexported (golint)
    • Line 1152: warning: exported function IsPolicyEmpty should have comment or be unexported (golint)
    • Line 1242: warning: exported function IsDefaultEmpty should have comment or be unexported (golint)
    • vcert/pkg/venafi/cloud/connector.go
    • Line 81: warning: exported method Connector.RetrieveSSHCertificate should have comment or be unexported (golint)
    • Line 85: warning: exported method Connector.RequestSSHCertificate should have comment or be unexported (golint)
    • Line 89: warning: exported method Connector.GetPolicy should have comment or be unexported (golint)
    • Line 123: warning: exported function PolicyExist should have comment or be unexported (golint)
    • Line 137: warning: exported method Connector.SetPolicy should have comment or be unexported (golint)
    • Line 340: warning: exported method Connector.SetZone should have comment or be unexported (golint)
    • Line 345: warning: exported method Connector.GetType should have comment or be unexported (golint)
    • Line 374: warning: exported method Connector.ReadPolicyConfiguration should have comment or be unexported (golint)
    • Line 839: warning: exported method Connector.ImportCertificate should have comment or be unexported (golint)
    • Line 908: warning: exported method Connector.SetHTTPClient should have comment or be unexported (golint)
    • Line 912: warning: exported method Connector.ListCertificates should have comment or be unexported (golint)
    • vcert/pkg/verror/errors.go
    • Line 6: warning: error var VcertError should have name of the form ErrFoo (golint)
    • Line 6: warning: exported var VcertError should have comment or be unexported (golint)
    • Line 7: warning: error var ServerError should have name of the form ErrFoo (golint)
    • Line 8: warning: error var ServerUnavailableError should have name of the form ErrFoo (golint)
    • Line 9: warning: error var ServerTemporaryUnavailableError should have name of the form ErrFoo (golint)
    • Line 10: warning: error var ServerBadDataResponce should have name of the form ErrFoo (golint)
    • Line 11: warning: error var UserDataError should have name of the form ErrFoo (golint)
    • Line 12: warning: error var PolicyValidationError should have name of the form ErrFoo (golint)
    • Line 13: warning: error var CertificateCheckError should have name of the form ErrFoo (golint)
    • Line 14: warning: error var AuthError should have name of the form ErrFoo (golint)
    • Line 15: warning: error var ZoneNotFoundError should have name of the form ErrFoo (golint)
    • Line 16: warning: error var ApplicationNotFoundError should have name of the form ErrFoo (golint)
    • vcert/test/fixtures.go
    • Line 41: warning: exported function RandCN should have comment or be unexported (golint)
    • Line 45: warning: exported function RandAppName should have comment or be unexported (golint)
    • Line 49: warning: exported function RandCitName should have comment or be unexported (golint)
    • Line 53: warning: exported function RandTppPolicyName should have comment or be unexported (golint)
    • Line 57: warning: exported function GetCloudPolicySpecification should have comment or be unexported (golint)
    • Line 122: warning: exported function GetTppPolicySpecification should have comment or be unexported (golint)
    • Line 192: warning: exported function IsArrayStringEqual should have comment or be unexported (golint)
    • Line 211: warning: exported function IsArrayIntEqual should have comment or be unexported (golint)
    • Line 230: warning: exported function RandSshKeyId should have comment or be unexported (golint)
    • vcert/pkg/util/utils.go
    • Line 8: warning: exported function ConvertSecondsToTime should have comment or be unexported (golint)
    • Line 12: warning: exported function GetJsonAsString should have comment or be unexported (golint)
    • vcert/pkg/venafi/fake/connector.go
    • Line 37: warning: exported type Connector should have comment or be unexported (golint)
    • Line 41: warning: exported method Connector.RetrieveSSHCertificate should have comment or be unexported (golint)
    • Line 45: warning: exported method Connector.RequestSSHCertificate should have comment or be unexported (golint)
    • Line 49: warning: exported method Connector.GetPolicy should have comment or be unexported (golint)
    • Line 115: warning: exported method Connector.SetPolicy should have comment or be unexported (golint)
    • Line 119: warning: exported function NewConnector should have comment or be unexported (golint)
    • Line 124: warning: exported method Connector.GetType should have comment or be unexported (golint)
    • Line 128: warning: exported method Connector.SetZone should have comment or be unexported (golint)
    • Line 131: warning: exported method Connector.Ping should have comment or be unexported (golint)
    • Line 135: warning: exported method Connector.Authenticate should have comment or be unexported (golint)
    • Line 151: warning: exported method Connector.RequestCertificate should have comment or be unexported (golint)
    • Line 222: warning: exported method Connector.RetrieveCertificate should have comment or be unexported (golint)
    • Line 276: warning: don't use underscores in Go names; var cert_pem should be certPem (golint)
    • Line 308: warning: exported method Connector.ReadZoneConfiguration should have comment or be unexported (golint)
    • Line 320: warning: exported method Connector.ImportCertificate should have comment or be unexported (golint)
    • Line 324: warning: exported method Connector.ReadPolicyConfiguration should have comment or be unexported (golint)
    • Line 347: warning: exported method Connector.SetHTTPClient should have comment or be unexported (golint)
    • Line 350: warning: exported method Connector.ListCertificates should have comment or be unexported (golint)
    • vcert/pkg/venafi/cloud/cloud.go
    • Line 104: warning: exported type CertificateStatusErrorInformation should have comment or be unexported (golint)
    • Line 153: warning: exported type ApplicationDetails should have comment or be unexported (golint)
    • vcert/pkg/venafi/cloud/search.go
    • Line 27: warning: exported type SearchRequest should have comment or be unexported (golint)
    • Line 35: warning: exported type Expression should have comment or be unexported (golint)
    • Line 40: warning: exported type Operand should have comment or be unexported (golint)
    • Line 46: warning: exported type Field should have comment or be unexported (golint)
    • Line 47: warning: exported type Operator should have comment or be unexported (golint)
    • Line 49: warning: exported type Paging should have comment or be unexported (golint)
    • Line 55: warning: exported const EQ should have comment (or a comment on this block) or be unexported (golint)
    • Line 66: warning: exported type CertificateSearchResponse should have comment or be unexported (golint)
    • Line 71: warning: exported type Certificate should have comment or be unexported (golint)
    • Line 84: warning: exported method Certificate.ToCertificateInfo should have comment or be unexported (golint)
    • Line 111: warning: exported function ParseCertificateSearchResponse should have comment or be unexported (golint)
    • vcert/cmd/vcert/result_writer.go
    • Line 35: warning: exported type Config should have comment or be unexported (golint)
    • Line 52: warning: exported type Result should have comment or be unexported (golint)
    • Line 58: warning: exported type Output should have comment or be unexported (golint)
    • Line 66: warning: exported method Output.AsPKCS12 should have comment or be unexported (golint)
    • Line 80: warning: don't use underscores in Go names; var chain_list should be chainList (golint)
    • Line 81: warning: don't use underscores in Go names; range var chain_cert should be chainCert (golint)
    • Line 125: warning: exported method Output.AsJKS should have comment or be unexported (golint)
    • Line 225: warning: exported method Output.Format should have comment or be unexported (golint)
    • Line 262: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 271: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 280: warning: exported method Result.Flush should have comment or be unexported (golint)
    • vcert/pkg/util/sshKeyGenerator.go
    • Line 15: warning: exported const RsaPrivKeyType should have comment (or a comment on this block) or be unexported (golint)
    • Line 73: warning: exported function GenerateSshKeyPair should have comment or be unexported (golint)
    • vcert/pkg/venafi/tpp/search.go
    • Line 28: warning: exported type SearchRequest should have comment or be unexported (golint)
    • Line 30: warning: exported type ConfigReadDNRequest should have comment or be unexported (golint)
    • Line 35: warning: exported type ConfigReadDNResponse should have comment or be unexported (golint)
    • Line 40: warning: exported type CertificateDetailsResponse should have comment or be unexported (golint)
    • Line 48: warning: exported type CertificateSearchResponse should have comment or be unexported (golint)
    • Line 53: warning: exported type Certificate should have comment or be unexported (golint)
    • Line 130: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 136: warning: exported function ParseCertificateSearchResponse should have comment or be unexported (golint)
    • Line 148: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • vcert/vcert.go
    • Line 1: warning: package comment should be of the form "Package vcert ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 34: warning: exported function GetFormatedBuildTimeStamp should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign94%

IneffAssign detects ineffectual assignments in Go code.

    • vcert/pkg/venafi/tpp/connector_test.go
    • Line 834: warning: ineffectual assignment to certDN (ineffassign)
    • Line 1266: warning: ineffectual assignment to modifiedURL (ineffassign)
    • Line 1276: warning: ineffectual assignment to modifiedURL (ineffassign)
    • Line 1286: warning: ineffectual assignment to modifiedURL (ineffassign)
    • Line 1296: warning: ineffectual assignment to modifiedURL (ineffassign)
    • Line 1793: warning: ineffectual assignment to err (ineffassign)
    • Line 1825: warning: ineffectual assignment to err (ineffassign)
    • Line 1912: warning: ineffectual assignment to err (ineffassign)
    • Line 1996: warning: ineffectual assignment to err (ineffassign)
    • Line 2060: warning: ineffectual assignment to err (ineffassign)
    • Line 2165: warning: ineffectual assignment to err (ineffassign)

misspell89%

Misspell Finds commonly misspelled English words

    • vcert/cmd/vcert/config.go
    • Line 46: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 66: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 71: warning: "enviroment" is a misspelling of "environment" (misspell)