Report for github.com/Wattpad/ship-it
A+ Excellent! Found 29 issues across 60 files
gofmt98%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
ship-it/internal/image/ref_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint55%
Golint is a linter for Go source code.
-
-
ship-it/internal/syncd/middleware/logger.go
- Line 11: warning: exported function Logger should have comment or be unexported (golint)
-
-
ship-it/internal/api/integrations/helm/helm.go
- Line 9: warning: exported type ReleaseStatuser should have comment or be unexported (golint)
- Line 13: warning: exported type ReleaseResources should have comment or be unexported (golint)
- Line 17: warning: exported function New should have comment or be unexported (golint)
- Line 21: warning: exported method ReleaseResources.Get should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/middleware/timer.go
- Line 12: warning: exported function Timer should have comment or be unexported (golint)
-
-
ship-it/internal/api/service/service.go
- Line 11: warning: exported type ReleaseLister should have comment or be unexported (golint)
- Line 16: warning: exported type ResourcesGetter should have comment or be unexported (golint)
- Line 20: warning: exported function New should have comment or be unexported (golint)
- Line 28: warning: exported type Service should have comment or be unexported (golint)
- Line 34: warning: exported method Service.ListReleases should have comment or be unexported (golint)
- Line 38: warning: exported method Service.GetRelease should have comment or be unexported (golint)
- Line 42: warning: exported method Service.GetReleaseResources should have comment or be unexported (golint)
-
-
ship-it/internal/api/integrations/k8s/k8s.go
- Line 15: warning: exported type K8sClient should have comment or be unexported (golint)
- Line 19: warning: exported function New should have comment or be unexported (golint)
- Line 42: warning: exported method K8sClient.Get should have comment or be unexported (golint)
- Line 59: warning: exported method K8sClient.List should have comment or be unexported (golint)
-
-
ship-it/operator/chartdownloader/factory.go
- Line 12: warning: exported type ChartDownloader should have comment or be unexported (golint)
- Line 20: warning: exported function New should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/config/config.go
- Line 43: warning: exported method Config.HelmTimeout should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/syncd.go
- Line 48: warning: exported function New should have comment or be unexported (golint)
- Line 58: warning: exported method Syncd.Run should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/integrations/ecr/chart_editor.go
- Line 18: warning: exported type GitService should have comment or be unexported (golint)
- Line 36: warning: exported function NewChartEditor should have comment or be unexported (golint)
-
-
ship-it/internal/api/router.go
- Line 12: warning: exported type Controller should have comment or be unexported (golint)
- Line 19: warning: comment on exported function NewRouter should be of the form "NewRouter ..." (golint)
-
-
ship-it/internal/syncd/integrations/ecr/listener.go
- Line 21: warning: exported type ImageListener should have comment or be unexported (golint)
- Line 44: warning: exported function NewListener should have comment or be unexported (golint)
- Line 57: warning: exported method ImageListener.Listen should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/integrations/ecr/reconciler.go
- Line 23: warning: exported type ImageReconciler should have comment or be unexported (golint)
- Line 28: warning: exported function NewReconciler should have comment or be unexported (golint)
- Line 35: warning: exported method ImageReconciler.Reconcile should have comment or be unexported (golint)
-
-
ship-it/operator/api/v1beta1/helmrelease_types.go
- Line 31: warning: exported type HelmReleaseStatusReason should have comment or be unexported (golint)
- Line 34: warning: exported const ReasonUnknown should have comment (or a comment on this block) or be unexported (golint)
- Line 62: warning: exported type HelmReleaseCondition should have comment or be unexported (golint)
- Line 77: warning: exported method ChartSpec.URL should have comment or be unexported (golint)
- Line 94: warning: exported method HelmRelease.HelmValues should have comment or be unexported (golint)
- Line 105: warning: exported method HelmReleaseStatus.SetCondition should have comment or be unexported (golint)
- Line 126: warning: exported method HelmReleaseStatus.GetCondition should have comment or be unexported (golint)
-
-
ship-it/internal/api/controller.go
- Line 14: warning: exported type Service should have comment or be unexported (golint)
- Line 24: warning: exported function NewController should have comment or be unexported (golint)
-
-
ship-it/internal/api/responses.go
- Line 8: warning: exported function Success200 should have comment or be unexported (golint)
- Line 24: warning: exported function NewError should have comment or be unexported (golint)
- Line 31: warning: exported function ErrorJSON should have comment or be unexported (golint)
- Line 35: warning: exported function Error400 should have comment or be unexported (golint)
- Line 39: warning: exported function Error404 should have comment or be unexported (golint)
- Line 43: warning: exported function Error500 should have comment or be unexported (golint)
-
-
ship-it/operator/controllers/helmrelease_controller.go
- Line 44: warning: exported type ChartDownloader should have comment or be unexported (golint)
- Line 53: warning: exported type HelmClient should have comment or be unexported (golint)
- Line 74: warning: exported type ReconcilerOption should have comment or be unexported (golint)
- Line 81: warning: exported function Namespace should have comment or be unexported (golint)
- Line 87: warning: exported function GracePeriod should have comment or be unexported (golint)
- Line 93: warning: exported function NewHelmReleaseReconciler should have comment or be unexported (golint)
- Line 118: warning: exported method HelmReleaseReconciler.Reconcile should have comment or be unexported (golint)
- Line 151: warning: exported method HelmReleaseReconciler.SetupWithManager should have comment or be unexported (golint)
-
-
ship-it/operator/chartdownloader/s3.go
- Line 19: warning: exported type S3DownloadManager should have comment or be unexported (golint)
- Line 23: warning: exported type S3Downloader should have comment or be unexported (golint)
- Line 27: warning: exported function NewS3Downloader should have comment or be unexported (golint)
- Line 44: warning: exported method S3Downloader.Download should have comment or be unexported (golint)
-
-
ship-it/internal/api/models/release.go
- Line 7: warning: exported type Release should have comment or be unexported (golint)
- Line 20: warning: exported type Owner should have comment or be unexported (golint)
- Line 25: warning: exported type SourceCode should have comment or be unexported (golint)
- Line 34: warning: exported type Monitoring should have comment or be unexported (golint)
- Line 39: warning: exported type Datadog should have comment or be unexported (golint)
- Line 44: warning: exported type Artifacts should have comment or be unexported (golint)
- Line 49: warning: exported type DockerArtifact should have comment or be unexported (golint)
- Line 54: warning: exported type HelmArtifact should have comment or be unexported (golint)
-
-
ship-it/internal/api/models/release_resources.go
- Line 3: warning: exported type ReleaseResources should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/integrations/k8s/informer.go
- Line 43: warning: exported function NewInformer should have comment or be unexported (golint)
- Line 63: warning: exported function NewInformerWithCache should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/integrations/github/downloader.go
- Line 12: warning: exported type RepositoriesService should have comment or be unexported (golint)
-
-
ship-it/internal/api/middleware/timer.go
- Line 21: warning: exported function Timer should have comment or be unexported (golint)
-
-
ship-it/internal/image/ref.go
- Line 28: warning: exported method Ref.URI should have comment or be unexported (golint)
- Line 32: warning: comment on exported method Ref.Matches should be of the form "Matches ..." (golint)
- Line 37: warning: exported function Parse should have comment or be unexported (golint)
- Line 50: warning: exported function FromYaml should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/integrations/github/listener.go
- Line 22: warning: exported type RegistryChartListener should have comment or be unexported (golint)
- Line 29: warning: exported function NewListener should have comment or be unexported (golint)
- Line 43: warning: exported method RegistryChartListener.Listen should have comment or be unexported (golint)
-
-
ship-it/internal/syncd/integrations/github/reconciler.go
- Line 18: warning: exported type Reconciler should have comment or be unexported (golint)
- Line 26: warning: exported function NewReconciler should have comment or be unexported (golint)
- Line 35: warning: exported method Reconciler.Reconcile should have comment or be unexported (golint)
-
-
ship-it/operator/api/v1beta1/groupversion_info.go
- Line 42: warning: exported function Kind should have comment or be unexported (golint)
-
-
ship-it/operator/controllers/release_manager.go
- Line 28: warning: exported method ReleaseManager.Install should have comment or be unexported (golint)
- Line 47: warning: exported method ReleaseManager.Delete should have comment or be unexported (golint)
- Line 60: warning: exported method ReleaseManager.Upgrade should have comment or be unexported (golint)
- Line 77: warning: exported method ReleaseManager.Rollback should have comment or be unexported (golint)
- Line 90: warning: exported method ReleaseManager.Deployed should have comment or be unexported (golint)
- Line 117: warning: exported method ReleaseManager.Failed should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell98%
Misspell Finds commonly misspelled English words
-
-
ship-it/operator/api/v1beta1/helmrelease_types_test.go
- Line 48: warning: "additonal" is a misspelling of "additional" (misspell)