Report for github.com/Wondertan/go-blockstream
A+ Excellent! Found 13 issues across 27 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-blockstream/session.go
- Line 286: warning: cyclomatic complexity 18 of function (*Session).worker() is high (> 15) (gocyclo)
golint51%
Golint is a linter for Go source code.
-
-
go-blockstream/exchange/exchange.go
- Line 20: warning: exported function New should have comment or be unexported (golint)
-
-
go-blockstream/ipld/testing.go
- Line 17: warning: context.Context should be the first parameter of a function (golint)
- Line 28: warning: context.Context should be the first parameter of a function (golint)
-
-
go-blockstream/options.go
- Line 7: warning: exported function Offline should have comment or be unexported (golint)
- Line 13: warning: exported function Blockstore should have comment or be unexported (golint)
- Line 19: warning: exported function Save should have comment or be unexported (golint)
- Line 25: warning: exported type SessionOption should have comment or be unexported (golint)
-
-
go-blockstream/test/testing.go
- Line 14: warning: exported function EmptyBlockstore should have comment or be unexported (golint)
- Line 18: warning: exported function RandBlockstore should have comment or be unexported (golint)
- Line 31: warning: exported function RandBlocks should have comment or be unexported (golint)
-
-
go-blockstream/blockstream.go
- Line 19: warning: exported var ErrNoProviders should have comment or be unexported (golint)
- Line 23: warning: exported const Protocol should have comment or be unexported (golint)
- Line 27: warning: exported type BlockStream should have comment or be unexported (golint)
- Line 41: warning: exported type Option should have comment or be unexported (golint)
- Line 43: warning: exported function Collectors should have comment or be unexported (golint)
- Line 49: warning: exported function NewBlockStream should have comment or be unexported (golint)
- Line 76: warning: exported method BlockStream.Close should have comment or be unexported (golint)
-
-
go-blockstream/net.go
- Line 20: warning: error var unknownError should have name of the form errFoo (golint)
-
-
go-blockstream/session.go
- Line 18: warning: comment on exported type Session should be of the form "Session ..." (with optional leading article) (golint)
-
-
go-blockstream/streamer.go
- Line 9: warning: comment on exported type Streamer should be of the form "Streamer ..." (with optional leading article) (golint)
-
-
go-blockstream/testing.go
- Line 40: warning: context.Context should be the first parameter of a function (golint)
- Line 46: warning: context.Context should be the first parameter of a function (golint)
-
-
go-blockstream/block/request_queue.go
- Line 8: warning: exported type RequestQueue should have comment or be unexported (golint)
- Line 15: warning: exported function NewRequestQueue should have comment or be unexported (golint)
- Line 23: warning: exported method RequestQueue.Len should have comment or be unexported (golint)
- Line 29: warning: exported method RequestQueue.Enqueue should have comment or be unexported (golint)
- Line 39: warning: exported method RequestQueue.Back should have comment or be unexported (golint)
- Line 55: warning: exported method RequestQueue.BackPopDone should have comment or be unexported (golint)
- Line 80: warning: exported method RequestQueue.PopBack should have comment or be unexported (golint)
- Line 89: warning: exported method RequestQueue.Cancel should have comment or be unexported (golint)
-
-
go-blockstream/block/result.go
- Line 8: warning: exported type Result should have comment or be unexported (golint)
- Line 15: warning: exported method Result.Cid should have comment or be unexported (golint)
-
-
go-blockstream/exchange/context.go
- Line 15: warning: exported var ErrNoProviders should have comment or be unexported (golint)
- Line 18: warning: exported function WithProviders should have comment or be unexported (golint)
- Line 26: warning: exported function GetProviders should have comment or be unexported (golint)
-
-
go-blockstream/block/stream.go
- Line 15: warning: exported type Stream should have comment or be unexported (golint)
- Line 22: warning: exported function NewStream should have comment or be unexported (golint)
- Line 35: warning: exported method Stream.Done should have comment or be unexported (golint)
- Line 39: warning: exported method Stream.Close should have comment or be unexported (golint)
- Line 43: warning: exported method Stream.Enqueue should have comment or be unexported (golint)
- Line 47: warning: exported method Stream.Output should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!