gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• Gaea/proxy/server/manager.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• Gaea/proxy/plan/plan_select_subquery.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• Gaea/parser/model/model_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• Gaea/stats/prometheus/collectors.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• Gaea/stats/prometheus/prometheus_backend.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• Gaea/models/namespace_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• Gaea/proxy/router/shard_mycat.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• Gaea/proxy/server/executor.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• Gaea/parser/tidb-types/parser_driver/value_expr.go
  • Line 74: warning: cyclomatic complexity 17 of function (*ValueExpr).Restore() is high (> 15) (gocyclo)

• Gaea/proxy/router/rule.go
  • Line 348: warning: cyclomatic complexity 34 of function parseRuleSliceInfos() is high (> 15) (gocyclo)

• Gaea/proxy/server/executor_handle.go
  • Line 200: warning: cyclomatic complexity 30 of function (*SessionExecutor).handleSetVariable() is high (> 15) (gocyclo)

• Gaea/proxy/server/executor.go
  • Line 452: warning: cyclomatic complexity 23 of function (*SessionExecutor).executeInMultiSlices() is high (> 15) (gocyclo)
  • Line 270: warning: cyclomatic complexity 21 of function (*SessionExecutor).ExecuteCommand() is high (> 15) (gocyclo)

• Gaea/mysql/result.go
  • Line 100: warning: cyclomatic complexity 33 of function (RowData).ParseBinary() is high (> 15) (gocyclo)
  • Line 613: warning: cyclomatic complexity 17 of function formatValue() is high (> 15) (gocyclo)

• Gaea/mysql/encoding_test.go
  • Line 209: warning: cyclomatic complexity 31 of function TestEncString() is high (> 15) (gocyclo)
  • Line 177: warning: cyclomatic complexity 16 of function TestEncUint64() is high (> 15) (gocyclo)

• Gaea/proxy/plan/plan_select.go
  • Line 715: warning: cyclomatic complexity 18 of function handleBinaryOperationExprMathCompare() is high (> 15) (gocyclo)

• Gaea/util/testleak/leaktest.go
  • Line 31: warning: cyclomatic complexity 22 of function interestingGoroutines() is high (> 15) (gocyclo)

• Gaea/parser/types/field_type.go
  • Line 198: warning: cyclomatic complexity 25 of function (*FieldType).Restore() is high (> 15) (gocyclo)
  • Line 253: warning: cyclomatic complexity 20 of function (*FieldType).FormatAsCastType() is high (> 15) (gocyclo)

• Gaea/util/resource_pool_test.go
  • Line 56: warning: cyclomatic complexity 36 of function TestOpen() is high (> 15) (gocyclo)
  • Line 390: warning: cyclomatic complexity 26 of function TestIdleTimeout() is high (> 15) (gocyclo)
  • Line 197: warning: cyclomatic complexity 25 of function TestShrinking() is high (> 15) (gocyclo)

• Gaea/proxy/router/rule_test.go
  • Line 71: warning: cyclomatic complexity 16 of function TestParseMycatRule() is high (> 15) (gocyclo)

• Gaea/proxy/server/namespace.go
  • Line 87: warning: cyclomatic complexity 16 of function NewNamespace() is high (> 15) (gocyclo)

• Gaea/mysql/resultset_sort.go
  • Line 103: warning: cyclomatic complexity 17 of function cmpValue() is high (> 15) (gocyclo)

• Gaea/mysql/variables.go
  • Line 76: warning: cyclomatic complexity 16 of function (*SessionVariables).SetEqualsWith() is high (> 15) (gocyclo)

• Gaea/parser/format/format.go
  • Line 78: warning: cyclomatic complexity 28 of function (*indentFormatter).format() is high (> 15) (gocyclo)

• Gaea/stats/prometheus/prometheus_backend.go
  • Line 37: warning: cyclomatic complexity 19 of function (PromBackend).publishPrometheusMetric() is high (> 15) (gocyclo)

• Gaea/parser/analyzer.go
  • Line 50: warning: cyclomatic complexity 17 of function Preview() is high (> 15) (gocyclo)
  • Line 107: warning: cyclomatic complexity 16 of function StmtType() is high (> 15) (gocyclo)

• Gaea/mysql/sql_fingerprint.go
  • Line 95: warning: cyclomatic complexity 182 of function GetFingerprint() is high (> 15) (gocyclo)

• Gaea/mysql/encoding.go
  • Line 464: warning: cyclomatic complexity 34 of function AppendBinaryValue() is high (> 15) (gocyclo)

• Gaea/models/numkey.go
  • Line 131: warning: cyclomatic complexity 17 of function ParseMonthRange() is high (> 15) (gocyclo)

• Gaea/parser/parser_test.go
  • Line 3082: warning: cyclomatic complexity 35 of function (*nodeTextCleaner).Enter() is high (> 15) (gocyclo)

• Gaea/parser/lexer.go
  • Line 147: warning: cyclomatic complexity 21 of function (*Scanner).Lex() is high (> 15) (gocyclo)
  • Line 629: warning: cyclomatic complexity 18 of function startWithNumber() is high (> 15) (gocyclo)

• Gaea/proxy/server/executor_stmt.go
  • Line 223: warning: cyclomatic complexity 27 of function (*SessionExecutor).bindStmtArgs() is high (> 15) (gocyclo)

• Gaea/mysql/sql_fingerprint_test.go
  • Line 33: warning: cyclomatic complexity 29 of function TestFingerprintBasic() is high (> 15) (gocyclo)

• Gaea/proxy/plan/merge_result.go
  • Line 674: warning: cyclomatic complexity 17 of function formatValue() is high (> 15) (gocyclo)

golint91%

Golint is a linter for Go source code.

• Gaea/proxy/sequence/sequence.go
  • Line 25: warning: exported type SequenceManager should have comment or be unexported (golint)
  • Line 29: warning: exported function NewSequenceManager should have comment or be unexported (golint)
  • Line 35: warning: exported method SequenceManager.SetSequence should have comment or be unexported (golint)
  • Line 47: warning: exported method SequenceManager.GetSequence should have comment or be unexported (golint)

• Gaea/proxy/router/rule.go
  • Line 42: warning: exported const DefaultRuleType should have comment (or a comment on this block) or be unexported (golint)
  • Line 62: warning: exported type Rule should have comment or be unexported (golint)
  • Line 79: warning: exported type MycatRule should have comment or be unexported (golint)
  • Line 85: warning: exported type BaseRule should have comment or be unexported (golint)
  • Line 101: warning: exported type LinkedRule should have comment or be unexported (golint)
  • Line 109: warning: exported function NewDefaultRule should have comment or be unexported (golint)
  • Line 119: warning: exported method BaseRule.GetDB should have comment or be unexported (golint)
  • Line 123: warning: exported method BaseRule.GetTable should have comment or be unexported (golint)
  • Line 127: warning: exported method BaseRule.GetShardingColumn should have comment or be unexported (golint)
  • Line 131: warning: exported method BaseRule.IsLinkedRule should have comment or be unexported (golint)
  • Line 135: warning: exported method BaseRule.GetShard should have comment or be unexported (golint)
  • Line 139: warning: exported method BaseRule.FindTableIndex should have comment or be unexported (golint)
  • Line 143: warning: comment on exported method BaseRule.GetSlice should be of the form "GetSlice ..." (golint)
  • Line 148: warning: exported method BaseRule.GetSliceIndexFromTableIndex should have comment or be unexported (golint)
  • Line 156: warning: comment on exported method BaseRule.GetSlices should be of the form "GetSlices ..." (golint)
  • Line 162: warning: exported method BaseRule.GetSubTableIndexes should have comment or be unexported (golint)
  • Line 166: warning: exported method BaseRule.GetFirstTableIndex should have comment or be unexported (golint)
  • Line 170: warning: exported method BaseRule.GetLastTableIndex should have comment or be unexported (golint)
  • Line 174: warning: exported method BaseRule.GetType should have comment or be unexported (golint)
  • Line 178: warning: exported method BaseRule.GetDatabaseNameByTableIndex should have comment or be unexported (golint)
  • Line 188: warning: exported method BaseRule.GetTableIndexByDatabaseName should have comment or be unexported (golint)
  • Line 193: warning: exported method BaseRule.GetDatabases should have comment or be unexported (golint)
  • Line 197: warning: exported method LinkedRule.GetDB should have comment or be unexported (golint)
  • Line 201: warning: exported method LinkedRule.GetTable should have comment or be unexported (golint)
  • Line 205: warning: exported method LinkedRule.GetParentDB should have comment or be unexported (golint)
  • Line 209: warning: exported method LinkedRule.GetParentTable should have comment or be unexported (golint)
  • Line 213: warning: exported method LinkedRule.GetShardingColumn should have comment or be unexported (golint)
  • Line 217: warning: exported method LinkedRule.IsLinkedRule should have comment or be unexported (golint)
  • Line 221: warning: exported method LinkedRule.GetShard should have comment or be unexported (golint)
  • Line 225: warning: exported method LinkedRule.FindTableIndex should have comment or be unexported (golint)
  • Line 229: warning: exported method LinkedRule.GetFirstTableIndex should have comment or be unexported (golint)
  • Line 233: warning: exported method LinkedRule.GetLastTableIndex should have comment or be unexported (golint)
  • Line 237: warning: exported method LinkedRule.GetSlice should have comment or be unexported (golint)
  • Line 241: warning: exported method LinkedRule.GetSliceIndexFromTableIndex should have comment or be unexported (golint)
  • Line 245: warning: exported method LinkedRule.GetSlices should have comment or be unexported (golint)
  • Line 249: warning: exported method LinkedRule.GetSubTableIndexes should have comment or be unexported (golint)
  • Line 253: warning: exported method LinkedRule.GetType should have comment or be unexported (golint)
  • Line 257: warning: exported method LinkedRule.GetDatabaseNameByTableIndex should have comment or be unexported (golint)
  • Line 261: warning: exported method LinkedRule.GetDatabases should have comment or be unexported (golint)
  • Line 265: warning: exported method LinkedRule.GetTableIndexByDatabaseName should have comment or be unexported (golint)
  • Line 636: warning: exported function IsMycatShardingRule should have comment or be unexported (golint)

• Gaea/proxy/router/shard.go
  • Line 47: warning: comment on exported type KeyError should be of the form "KeyError ..." (with optional leading article) (golint)
  • Line 50: warning: exported function NewKeyError should have comment or be unexported (golint)
  • Line 54: warning: exported function NewInvalidDateFormatKeyError should have comment or be unexported (golint)
  • Line 77: warning: comment on exported function EncodeValue should be of the form "EncodeValue ..." (golint)
  • Line 94: warning: exported function GetString should have comment or be unexported (golint)
  • Line 113: warning: exported function HashValue should have comment or be unexported (golint)
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 133: warning: exported function NumValue should have comment or be unexported (golint)
  • Line 157: warning: exported type Shard should have comment or be unexported (golint)
  • Line 161: warning: comment on exported type RangeShard should be of the form "RangeShard ..." (with optional leading article) (golint)
  • Line 167: warning: exported type HashShard should have comment or be unexported (golint)
  • Line 171: warning: exported method HashShard.FindForKey should have comment or be unexported (golint)
  • Line 177: warning: exported type ModShard should have comment or be unexported (golint)
  • Line 181: warning: exported method ModShard.FindForKey should have comment or be unexported (golint)
  • Line 186: warning: exported type NumRangeShard should have comment or be unexported (golint)
  • Line 190: warning: exported method NumRangeShard.FindForKey should have comment or be unexported (golint)
  • Line 200: warning: exported method NumRangeShard.EqualStart should have comment or be unexported (golint)
  • Line 205: warning: exported type DateYearShard should have comment or be unexported (golint)
  • Line 222: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 229: warning: comment on exported method DateYearShard.FindForKey should be of the form "FindForKey ..." (golint)
  • Line 234: warning: exported method DateYearShard.EqualStart should have comment or be unexported (golint)
  • Line 243: warning: exported type DateMonthShard should have comment or be unexported (golint)
  • Line 283: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 290: warning: comment on exported method DateMonthShard.FindForKey should be of the form "FindForKey ..." (golint)
  • Line 295: warning: exported method DateMonthShard.EqualStart should have comment or be unexported (golint)
  • Line 304: warning: exported type DateDayShard should have comment or be unexported (golint)
  • Line 344: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 351: warning: comment on exported method DateDayShard.FindForKey should be of the form "FindForKey ..." (golint)
  • Line 356: warning: exported method DateDayShard.EqualStart should have comment or be unexported (golint)
  • Line 365: warning: exported type DefaultShard should have comment or be unexported (golint)
  • Line 368: warning: exported method DefaultShard.FindForKey should have comment or be unexported (golint)
  • Line 372: warning: exported type GlobalTableShard should have comment or be unexported (golint)
  • Line 375: warning: exported method GlobalTableShard.FindForKey should have comment or be unexported (golint)
  • Line 379: warning: exported function NewGlobalTableShard should have comment or be unexported (golint)

• Gaea/proxy/router/shard_mycat_test.go
  • Line 1221: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Gaea/proxy/server/executor_stmt.go
  • Line 103: warning: exported method Stmt.SetParamTypes should have comment or be unexported (golint)
  • Line 107: warning: exported method Stmt.GetParamTypes should have comment or be unexported (golint)

• Gaea/proxy/sequence/mysql.go
  • Line 96: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• Gaea/models/shard.go
  • Line 108: warning: exported function IsMycatShardingRule should have comment or be unexported (golint)

• Gaea/proxy/plan/plan.go
  • Line 81: warning: exported method Checker.GetUnshardTableNames should have comment or be unexported (golint)

• Gaea/parser/format/format.go
  • Line 224: warning: exported const EscapeRestoreFlags should have comment (or a comment on this block) or be unexported (golint)

• Gaea/models/namespace.go
  • Line 303: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• Gaea/models/namespace_test.go
  • Line 508: warning: don't use underscores in Go names; func testVerifyShardRules_Error_ShardMycatMod should be testVerifyShardRulesErrorShardMycatMod (golint)
  • Line 539: warning: don't use underscores in Go names; func testVerifyShardRules_Error_ShardMycatLong should be testVerifyShardRulesErrorShardMycatLong (golint)

• Gaea/proxy/plan/plan_select.go
  • Line 858: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Gaea/proxy/server/manager.go
  • Line 393: warning: should omit 2nd value from range; this loop is equivalent to `for nameSpaceName := range ...` (golint)

• Gaea/backend/slice.go
  • Line 98: warning: exported method Slice.GetDirectConn should have comment or be unexported (golint)

• Gaea/cc/server.go
  • Line 265: warning: exported method Server.Run should have comment or be unexported (golint)
  • Line 288: warning: exported method Server.Close should have comment or be unexported (golint)

• Gaea/backend/interface.go
  • Line 10: warning: exported type PooledConnect should have comment or be unexported (golint)
  • Line 29: warning: exported type ConnectionPool should have comment or be unexported (golint)

• Gaea/util/string.go
  • Line 19: warning: exported function Concat should have comment or be unexported (golint)

• Gaea/proxy/router/router.go
  • Line 1: warning: package comment should be of the form "Package router ..." (golint)
  • Line 23: warning: exported type Router should have comment or be unexported (golint)
  • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 103: warning: exported method Router.GetShardRule should have comment or be unexported (golint)
  • Line 113: warning: exported method Router.GetRule should have comment or be unexported (golint)
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• Gaea/proxy/server/namespace.go
  • Line 208: warning: exported method Namespace.GetSequences should have comment or be unexported (golint)
  • Line 249: warning: exported method Namespace.GetMaxExecuteTime should have comment or be unexported (golint)
  • Line 253: warning: exported method Namespace.GetMaxResultSize should have comment or be unexported (golint)
  • Line 300: warning: exported method Namespace.GetPhysicalDBs should have comment or be unexported (golint)

• Gaea/proxy/server/var.go
  • Line 10: warning: exported function OpenProcessGeneralQueryLog should have comment or be unexported (golint)

• Gaea/core/errors/errors.go
  • Line 100: warning: exported var ErrTimeLimitExceeded should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign93%

IneffAssign detects ineffectual assignments in Go code.

• Gaea/parser/ast/expressions.go
  • Line 1176: warning: ineffectual assignment to ok (ineffassign)

• Gaea/parser/ast/misc_test.go
  • Line 179: warning: ineffectual assignment to pwd (ineffassign)

• Gaea/util/hack/hack_test.go
  • Line 36: warning: ineffectual assignment to b (ineffassign)

• Gaea/mysql/conn.go
  • Line 560: warning: ineffectual assignment to pos (ineffassign)
  • Line 582: warning: ineffectual assignment to pos (ineffassign)
  • Line 605: warning: ineffectual assignment to pos (ineffassign)
  • Line 628: warning: ineffectual assignment to pos (ineffassign)
  • Line 664: warning: ineffectual assignment to ok (ineffassign)
  • Line 697: warning: ineffectual assignment to pos (ineffassign)

• Gaea/proxy/server/client_conn.go
  • Line 193: warning: ineffectual assignment to pos (ineffassign)

• Gaea/proxy/server/executor_stmt.go
  • Line 114: warning: ineffectual assignment to tmp (ineffassign)
  • Line 115: warning: ineffectual assignment to pos (ineffassign)
  • Line 117: warning: ineffectual assignment to quote (ineffassign)
  • Line 333: warning: ineffectual assignment to ok (ineffassign)

• Gaea/proxy/plan/plan.go
  • Line 517: warning: ineffectual assignment to sliceSQLs (ineffassign)
  • Line 540: warning: ineffectual assignment to sliceSQLs (ineffassign)

• Gaea/backend/direct_connection.go
  • Line 305: warning: ineffectual assignment to pos (ineffassign)
  • Line 352: warning: ineffectual assignment to pos (ineffassign)
  • Line 726: warning: ineffectual assignment to pos (ineffassign)
  • Line 734: warning: ineffectual assignment to pos (ineffassign)

• Gaea/proxy/router/list_test.go
  • Line 174: warning: ineffectual assignment to days (ineffassign)

• Gaea/parser/parser_test.go
  • Line 1953: warning: ineffectual assignment to stmt (ineffassign)
  • Line 1955: warning: ineffectual assignment to stmt (ineffassign)
  • Line 1958: warning: ineffectual assignment to stmt (ineffassign)

• Gaea/mysql/encoding_test.go
  • Line 79: warning: ineffectual assignment to got (ineffassign)
  • Line 79: warning: ineffectual assignment to pos (ineffassign)
  • Line 104: warning: ineffectual assignment to got16 (ineffassign)
  • Line 104: warning: ineffectual assignment to pos (ineffassign)
  • Line 129: warning: ineffectual assignment to got (ineffassign)
  • Line 129: warning: ineffectual assignment to pos (ineffassign)
  • Line 140: warning: ineffectual assignment to b (ineffassign)
  • Line 140: warning: ineffectual assignment to pos (ineffassign)
  • Line 164: warning: ineffectual assignment to got32 (ineffassign)
  • Line 164: warning: ineffectual assignment to pos (ineffassign)
  • Line 196: warning: ineffectual assignment to got64 (ineffassign)
  • Line 196: warning: ineffectual assignment to pos (ineffassign)
  • Line 271: warning: ineffectual assignment to got (ineffassign)
  • Line 271: warning: ineffectual assignment to pos (ineffassign)
  • Line 277: warning: ineffectual assignment to got (ineffassign)
  • Line 277: warning: ineffectual assignment to pos (ineffassign)
  • Line 289: warning: ineffectual assignment to pos (ineffassign)
  • Line 295: warning: ineffectual assignment to pos (ineffassign)
  • Line 307: warning: ineffectual assignment to gotb (ineffassign)
  • Line 307: warning: ineffectual assignment to pos (ineffassign)
  • Line 313: warning: ineffectual assignment to gotb (ineffassign)
  • Line 313: warning: ineffectual assignment to pos (ineffassign)
  • Line 337: warning: ineffectual assignment to got (ineffassign)
  • Line 337: warning: ineffectual assignment to pos (ineffassign)

• Gaea/mysql/field.go
  • Line 87: warning: ineffectual assignment to ok (ineffassign)

• Gaea/mysql/result.go
  • Line 60: warning: ineffectual assignment to ok (ineffassign)
  • Line 204: warning: ineffectual assignment to ok (ineffassign)

• Gaea/log/xlog/util.go
  • Line 53: warning: ineffectual assignment to resultLevel (ineffassign)

• Gaea/parser/model/model_test.go
  • Line 303: warning: ineffectual assignment to err (ineffassign)

• Gaea/proxy/plan/plan_unshard.go
  • Line 141: warning: ineffectual assignment to r (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• Gaea/parser/parser_test.go
  • Line 1509: warning: "ect" is a misspelling of "etc" (misspell)
  • Line 1509: warning: "ect" is a misspelling of "etc" (misspell)

• Gaea/stats/rates.go
  • Line 170: warning: "devided" is a misspelling of "divided" (misspell)

• Gaea/util/cache/lru_cache.go
  • Line 67: warning: "lenght" is a misspelling of "length" (misspell)

• Gaea/mysql/encoding.go
  • Line 120: warning: "lenght" is a misspelling of "length" (misspell)

• Gaea/mysql/encoding_test.go
  • Line 72: warning: "succesful" is a misspelling of "successful" (misspell)
  • Line 264: warning: "succesful" is a misspelling of "successful" (misspell)
  • Line 282: warning: "succesful" is a misspelling of "successful" (misspell)
  • Line 300: warning: "succesful" is a misspelling of "successful" (misspell)
  • Line 330: warning: "succesful" is a misspelling of "successful" (misspell)

• Gaea/util/hack/hack.go
  • Line 45: warning: "seperation" is a misspelling of "separation" (misspell)