gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• ZanRedisDB/pkg/testutil/leak.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/rockredis/t_zset_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint54%

Golint is a linter for Go source code.

• ZanRedisDB/server/config.go
  • Line 7: warning: exported type ServerConfig should have comment or be unexported (golint)
  • Line 36: warning: exported type NamespaceNodeConfig should have comment or be unexported (golint)
  • Line 41: warning: exported type ConfigFile should have comment or be unexported (golint)

• ZanRedisDB/node/list.go
  • Line 210: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/node/secondary_index.go
  • Line 13: warning: exported type HindexSearchResults should have comment or be unexported (golint)
  • Line 194: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/node/util.go
  • Line 15: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 19: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 24: warning: exported function SetSyncerOnly should have comment or be unexported (golint)
  • Line 32: warning: exported function IsSyncerOnly should have comment or be unexported (golint)

• ZanRedisDB/rockredis/doc.go
  • Line 1: warning: package comment should be of the form "Package rockredis ..." (golint)

• ZanRedisDB/rockredis/t_ttl.go
  • Line 114: warning: exported method RockDB.KVTtl should have comment or be unexported (golint)
  • Line 118: warning: exported method RockDB.HashTtl should have comment or be unexported (golint)
  • Line 122: warning: exported method RockDB.ListTtl should have comment or be unexported (golint)
  • Line 126: warning: exported method RockDB.SetTtl should have comment or be unexported (golint)
  • Line 130: warning: exported method RockDB.ZSetTtl should have comment or be unexported (golint)
  • Line 134: warning: exported type TTLChecker should have comment or be unexported (golint)

• ZanRedisDB/snap/message.go
  • Line 39: warning: exported function NewMessage should have comment or be unexported (golint)
  • Line 55: warning: exported method Message.CloseWithError should have comment or be unexported (golint)

• ZanRedisDB/common/file_sync.go
  • Line 17: warning: exported function RunFileSync should have comment or be unexported (golint)

• ZanRedisDB/node/ttl.go
  • Line 18: warning: exported var ErrExpiredBatchedBuffFull should have comment or be unexported (golint)
  • Line 83: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 91: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 99: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 107: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 197: warning: exported type ExpireHandler should have comment or be unexported (golint)
  • Line 208: warning: exported function NewExpireHandler should have comment or be unexported (golint)
  • Line 217: warning: exported method ExpireHandler.Start should have comment or be unexported (golint)
  • Line 230: warning: exported method ExpireHandler.Stop should have comment or be unexported (golint)
  • Line 237: warning: exported method ExpireHandler.LeaderChanged should have comment or be unexported (golint)
  • Line 375: warning: receiver name raftBuff should be consistent with previous receiver name raftBuffer for raftExpiredBuffer (golint)
  • Line 406: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/cluster/coordinator_stats.go
  • Line 16: warning: exported function AddCounter should have comment or be unexported (golint)
  • Line 25: warning: exported function IncCounter should have comment or be unexported (golint)
  • Line 29: warning: exported function IncCounterBy should have comment or be unexported (golint)
  • Line 44: warning: exported type CoordErrStatsData should have comment or be unexported (golint)
  • Line 50: warning: exported type CoordErrStats should have comment or be unexported (golint)
  • Line 61: warning: exported method CoordErrStats.GetCopy should have comment or be unexported (golint)
  • Line 61: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 73: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 77: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 81: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 94: warning: exported type ISRStat should have comment or be unexported (golint)
  • Line 99: warning: exported type NamespaceCoordStat should have comment or be unexported (golint)
  • Line 106: warning: exported type CoordStats should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_coordinator.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 19: warning: exported var ErrAlreadyExist should have comment or be unexported (golint)
  • Line 43: warning: exported function ChangeIntervalForTest should have comment or be unexported (golint)
  • Line 51: warning: exported type PDCoordinator should have comment or be unexported (golint)
  • Line 76: warning: exported function NewPDCoordinator should have comment or be unexported (golint)
  • Line 105: warning: exported method PDCoordinator.SetBalanceInterval should have comment or be unexported (golint)
  • Line 109: warning: exported method PDCoordinator.SetRegister should have comment or be unexported (golint)
  • Line 113: warning: exported method PDCoordinator.AutoBalanceEnabled should have comment or be unexported (golint)
  • Line 117: warning: exported method PDCoordinator.Start should have comment or be unexported (golint)
  • Line 146: warning: exported method PDCoordinator.Stop should have comment or be unexported (golint)
  • Line 922: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 961: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/rockredis/t_hll.go
  • Line 134: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 170: warning: exported method RockDB.PFCount should have comment or be unexported (golint)
  • Line 293: warning: exported method RockDB.PFAdd should have comment or be unexported (golint)

• ZanRedisDB/snap/snapshotter.go
  • Line 44: warning: exported var ErrNoSnapshot should have comment or be unexported (golint)
  • Line 55: warning: exported type Snapshotter should have comment or be unexported (golint)
  • Line 59: warning: exported function New should have comment or be unexported (golint)
  • Line 65: warning: exported method Snapshotter.SaveSnap should have comment or be unexported (golint)
  • Line 82: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 98: warning: exported method Snapshotter.RemoveSnap should have comment or be unexported (golint)
  • Line 103: warning: exported method Snapshotter.Load should have comment or be unexported (golint)

• ZanRedisDB/pkg/types/urls.go
  • Line 26: warning: exported type URLs should have comment or be unexported (golint)
  • Line 28: warning: exported function NewURLs should have comment or be unexported (golint)
  • Line 56: warning: exported function MustNewURLs should have comment or be unexported (golint)
  • Line 68: warning: exported method URLs.Sort should have comment or be unexported (golint)
  • Line 75: warning: exported method URLs.StringSlice should have comment or be unexported (golint)

• ZanRedisDB/common/logger.go
  • Line 14: warning: exported type Logger should have comment or be unexported (golint)
  • Line 28: warning: exported function NewDefaultLogger should have comment or be unexported (golint)
  • Line 49: warning: exported type GLogger should have comment or be unexported (golint)
  • Line 52: warning: exported method GLogger.Output should have comment or be unexported (golint)
  • Line 57: warning: exported method GLogger.OutputErr should have comment or be unexported (golint)
  • Line 62: warning: exported method GLogger.OutputWarning should have comment or be unexported (golint)
  • Line 68: warning: exported const LOG_ERR should have comment (or a comment on this block) or be unexported (golint)
  • Line 75: warning: exported type LevelLogger should have comment or be unexported (golint)
  • Line 80: warning: exported function NewLevelLogger should have comment or be unexported (golint)
  • Line 87: warning: exported method LevelLogger.SetLevel should have comment or be unexported (golint)
  • Line 91: warning: exported method LevelLogger.Level should have comment or be unexported (golint)
  • Line 95: warning: exported method LevelLogger.InfoDepth should have comment or be unexported (golint)
  • Line 101: warning: exported method LevelLogger.Infof should have comment or be unexported (golint)
  • Line 107: warning: exported method LevelLogger.DebugDepth should have comment or be unexported (golint)
  • Line 113: warning: exported method LevelLogger.Debugf should have comment or be unexported (golint)
  • Line 119: warning: exported method LevelLogger.Errorf should have comment or be unexported (golint)
  • Line 125: warning: exported method LevelLogger.ErrorDepth should have comment or be unexported (golint)
  • Line 131: warning: exported method LevelLogger.Warningf should have comment or be unexported (golint)
  • Line 137: warning: exported method LevelLogger.Fatalf should have comment or be unexported (golint)
  • Line 144: warning: exported method LevelLogger.Panicf should have comment or be unexported (golint)
  • Line 152: warning: exported method LevelLogger.Info should have comment or be unexported (golint)
  • Line 158: warning: exported method LevelLogger.Debug should have comment or be unexported (golint)
  • Line 170: warning: exported method LevelLogger.Warning should have comment or be unexported (golint)
  • Line 176: warning: exported method LevelLogger.Fatal should have comment or be unexported (golint)
  • Line 183: warning: exported method LevelLogger.Panic should have comment or be unexported (golint)
  • Line 250: warning: exported function NewMergeLogger should have comment or be unexported (golint)
  • Line 259: warning: exported method MergeLogger.MergeInfo should have comment or be unexported (golint)
  • Line 266: warning: exported method MergeLogger.MergeInfof should have comment or be unexported (golint)
  • Line 273: warning: exported method MergeLogger.MergeWarning should have comment or be unexported (golint)
  • Line 280: warning: exported method MergeLogger.MergeWarningf should have comment or be unexported (golint)
  • Line 287: warning: exported method MergeLogger.MergeError should have comment or be unexported (golint)
  • Line 294: warning: exported method MergeLogger.MergeErrorf should have comment or be unexported (golint)

• ZanRedisDB/node/syncer_learner.go
  • Line 18: warning: exported function EnableForTest should have comment or be unexported (golint)
  • Line 28: warning: exported function SetSyncerNormalInit should have comment or be unexported (golint)
  • Line 54: warning: exported function NewLogSyncerSM should have comment or be unexported (golint)
  • Line 102: warning: exported function GetLogLatencyStats should have comment or be unexported (golint)

• ZanRedisDB/rockredis/scan.go
  • Line 13: warning: exported method RockDB.Scan should have comment or be unexported (golint)
  • Line 21: warning: exported method RockDB.ScanWithBuffer should have comment or be unexported (golint)
  • Line 312: warning: exported method RockDB.HScan should have comment or be unexported (golint)
  • Line 344: warning: exported method RockDB.SScan should have comment or be unexported (golint)
  • Line 383: warning: exported method RockDB.ZScan should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_ttl_l.go
  • Line 22: warning: exported var ErrLocalBatchFullToCommit should have comment or be unexported (golint)
  • Line 56: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 168: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 171: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 177: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 326: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/pkg/logutil/merge_logger.go
  • Line 87: warning: exported function NewMergeLogger should have comment or be unexported (golint)
  • Line 96: warning: exported method MergeLogger.MergeInfo should have comment or be unexported (golint)
  • Line 103: warning: exported method MergeLogger.MergeInfof should have comment or be unexported (golint)
  • Line 110: warning: exported method MergeLogger.MergeNotice should have comment or be unexported (golint)
  • Line 117: warning: exported method MergeLogger.MergeNoticef should have comment or be unexported (golint)
  • Line 124: warning: exported method MergeLogger.MergeWarning should have comment or be unexported (golint)
  • Line 131: warning: exported method MergeLogger.MergeWarningf should have comment or be unexported (golint)
  • Line 138: warning: exported method MergeLogger.MergeError should have comment or be unexported (golint)
  • Line 145: warning: exported method MergeLogger.MergeErrorf should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_learner_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 127: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 202: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/pdserver/server.go
  • Line 17: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 22: warning: exported function SLogger should have comment or be unexported (golint)
  • Line 26: warning: exported type Server should have comment or be unexported (golint)
  • Line 36: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 99: warning: exported method Server.Stop should have comment or be unexported (golint)
  • Line 106: warning: exported method Server.Start should have comment or be unexported (golint)

• ZanRedisDB/node/conflict_checker.go
  • Line 9: warning: exported type ConflictCheckFunc should have comment or be unexported (golint)
  • Line 15: warning: exported function NewConflictRouter should have comment or be unexported (golint)

• ZanRedisDB/stats/leader.go
  • Line 24: warning: comment on exported type PeersStats should be of the form "PeersStats ..." (with optional leading article) (golint)
  • Line 33: warning: exported function NewPeersStats should have comment or be unexported (golint)
  • Line 39: warning: exported method PeersStats.JSON should have comment or be unexported (golint)
  • Line 49: warning: exported method PeersStats.RemovePeer should have comment or be unexported (golint)
  • Line 55: warning: exported method PeersStats.Peer should have comment or be unexported (golint)

• ZanRedisDB/pkg/transport/unix_listener.go
  • Line 24: warning: exported function NewUnixListener should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_hash.go
  • Line 170: warning: exported method RockDB.HLen should have comment or be unexported (golint)
  • Line 186: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 198: warning: exported method RockDB.HSet should have comment or be unexported (golint)
  • Line 232: warning: exported method RockDB.HMset should have comment or be unexported (golint)
  • Line 302: warning: exported method RockDB.HGetVer should have comment or be unexported (golint)
  • Line 319: warning: exported method RockDB.HGet should have comment or be unexported (golint)
  • Line 335: warning: exported method RockDB.HKeyExists should have comment or be unexported (golint)
  • Line 347: warning: exported method RockDB.HMget should have comment or be unexported (golint)
  • Line 362: warning: exported method RockDB.HDel should have comment or be unexported (golint)
  • Line 466: warning: exported method RockDB.HClear should have comment or be unexported (golint)
  • Line 532: warning: exported method RockDB.HMclear should have comment or be unexported (golint)
  • Line 538: warning: exported method RockDB.HIncrBy should have comment or be unexported (golint)
  • Line 584: warning: exported method RockDB.HGetAll should have comment or be unexported (golint)
  • Line 636: warning: exported method RockDB.HKeys should have comment or be unexported (golint)
  • Line 676: warning: exported method RockDB.HValues should have comment or be unexported (golint)
  • Line 717: warning: exported method RockDB.HExpire should have comment or be unexported (golint)
  • Line 720: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 723: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 729: warning: exported method RockDB.HPersist should have comment or be unexported (golint)
  • Line 741: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 744: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/rockredis/t_zset.go
  • Line 13: warning: exported const MinScore should have comment (or a comment on this block) or be unexported (golint)
  • Line 241: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 276: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 288: warning: exported method RockDB.ZAdd should have comment or be unexported (golint)
  • Line 329: warning: exported method RockDB.ZFixKey should have comment or be unexported (golint)
  • Line 425: warning: exported method RockDB.ZGetVer should have comment or be unexported (golint)
  • Line 432: warning: exported method RockDB.ZCard should have comment or be unexported (golint)
  • Line 440: warning: exported method RockDB.ZScore should have comment or be unexported (golint)
  • Line 459: warning: exported method RockDB.ZRem should have comment or be unexported (golint)
  • Line 497: warning: exported method RockDB.ZIncrBy should have comment or be unexported (golint)
  • Line 545: warning: exported method RockDB.ZCount should have comment or be unexported (golint)
  • Line 583: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 586: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 617: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 834: warning: exported method RockDB.ZClear should have comment or be unexported (golint)
  • Line 844: warning: exported method RockDB.ZMclear should have comment or be unexported (golint)
  • Line 879: warning: exported method RockDB.ZRange should have comment or be unexported (golint)
  • Line 883: warning: comment on exported method RockDB.ZRangeByScore should be of the form "ZRangeByScore ..." (golint)
  • Line 890: warning: exported method RockDB.ZRank should have comment or be unexported (golint)
  • Line 894: warning: exported method RockDB.ZRemRangeByRank should have comment or be unexported (golint)
  • Line 916: warning: comment on exported method RockDB.ZRemRangeByScore should be of the form "ZRemRangeByScore ..." (golint)
  • Line 928: warning: exported method RockDB.ZRevRange should have comment or be unexported (golint)
  • Line 932: warning: exported method RockDB.ZRevRank should have comment or be unexported (golint)
  • Line 936: warning: comment on exported method RockDB.ZRevRangeByScore should be of the form "ZRevRangeByScore ..." (golint)
  • Line 942: warning: exported method RockDB.ZRangeGeneric should have comment or be unexported (golint)
  • Line 956: warning: comment on exported method RockDB.ZRangeByScoreGeneric should be of the form "ZRangeByScoreGeneric ..." (golint)
  • Line 988: warning: exported method RockDB.ZRangeByLex should have comment or be unexported (golint)
  • Line 1041: warning: exported method RockDB.ZRemRangeByLex should have comment or be unexported (golint)
  • Line 1104: warning: exported method RockDB.ZLexCount should have comment or be unexported (golint)
  • Line 1133: warning: exported method RockDB.ZKeyExists should have comment or be unexported (golint)
  • Line 1145: warning: exported method RockDB.ZExpire should have comment or be unexported (golint)
  • Line 1148: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1151: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1157: warning: exported method RockDB.ZPersist should have comment or be unexported (golint)
  • Line 1169: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1172: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/pkg/fileutil/purge.go
  • Line 25: warning: exported function PurgeFile should have comment or be unexported (golint)

• ZanRedisDB/server/scan_merge.go
  • Line 98: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/node/config.go
  • Line 8: warning: exported type NamespaceConfig should have comment or be unexported (golint)
  • Line 23: warning: exported function NewNSConfig should have comment or be unexported (golint)
  • Line 31: warning: exported type NamespaceDynamicConf should have comment or be unexported (golint)
  • Line 34: warning: exported type RaftGroupConfig should have comment or be unexported (golint)
  • Line 39: warning: exported type MachineConfig should have comment or be unexported (golint)
  • Line 56: warning: exported type ReplicaInfo should have comment or be unexported (golint)
  • Line 62: warning: exported type RaftConfig should have comment or be unexported (golint)

• ZanRedisDB/node/geo.go
  • Line 24: warning: exported const RADIUS_COORDS should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported const SORT_NONE should have comment (or a comment on this block) or be unexported (golint)
  • Line 412: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/pkg/wait/wait_time.go
  • Line 19: warning: exported type WaitTime should have comment or be unexported (golint)
  • Line 38: warning: exported function NewTimeList should have comment or be unexported (golint)

• ZanRedisDB/pkg/transport/limit_listen.go
  • Line 27: warning: exported var ErrNotTCP should have comment or be unexported (golint)

• ZanRedisDB/wal/util.go
  • Line 26: warning: error var badWalName should have name of the form errFoo (golint)
  • Line 29: warning: exported function Exist should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_api.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: comment on exported method PDCoordinator.IsClusterStable should be of the form "IsClusterStable ..." (golint)
  • Line 19: warning: exported method PDCoordinator.IsMineLeader should have comment or be unexported (golint)
  • Line 23: warning: exported method PDCoordinator.GetAllPDNodes should have comment or be unexported (golint)
  • Line 27: warning: exported method PDCoordinator.GetPDLeader should have comment or be unexported (golint)
  • Line 31: warning: exported method PDCoordinator.GetAllDataNodes should have comment or be unexported (golint)
  • Line 35: warning: comment on exported method PDCoordinator.GetAllNamespaces should be of the form "GetAllNamespaces ..." (golint)
  • Line 41: warning: exported method PDCoordinator.SwitchAutoBalance should have comment or be unexported (golint)
  • Line 51: warning: exported method PDCoordinator.SetClusterStableNodeNum should have comment or be unexported (golint)
  • Line 59: warning: exported method PDCoordinator.SetClusterUpgradeState should have comment or be unexported (golint)
  • Line 81: warning: exported method PDCoordinator.MarkNodeAsRemoving should have comment or be unexported (golint)
  • Line 103: warning: exported method PDCoordinator.DeleteNamespace should have comment or be unexported (golint)
  • Line 153: warning: exported method PDCoordinator.ChangeNamespaceMetaParam should have comment or be unexported (golint)
  • Line 172: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 210: warning: exported method PDCoordinator.CreateNamespace should have comment or be unexported (golint)
  • Line 298: warning: exported method PDCoordinator.AddHIndexSchema should have comment or be unexported (golint)
  • Line 303: warning: exported method PDCoordinator.DelHIndexSchema should have comment or be unexported (golint)
  • Line 307: warning: exported method PDCoordinator.RemoveLearnerFromNs should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/http.go
  • Line 44: warning: exported var RaftPrefix should have comment or be unexported (golint)
  • Line 135: warning: exported type ISnapSaver should have comment or be unexported (golint)

• ZanRedisDB/node/raft_storage.go
  • Line 15: warning: exported function NewRaftPersistStorage should have comment or be unexported (golint)

• ZanRedisDB/internal/test/helper.go
  • Line 3: warning: exported type TbLog should have comment or be unexported (golint)
  • Line 7: warning: exported type TestLogger should have comment or be unexported (golint)
  • Line 12: warning: exported method TestLogger.Output should have comment or be unexported (golint)
  • Line 17: warning: exported method TestLogger.OutputErr should have comment or be unexported (golint)
  • Line 22: warning: exported method TestLogger.OutputWarning should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_schema_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported var ErrInvalidSchema should have comment or be unexported (golint)

• ZanRedisDB/pdserver/config.go
  • Line 8: warning: exported type ServerConfig should have comment or be unexported (golint)
  • Line 27: warning: exported function NewServerConfig should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/transport.go
  • Line 38: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 42: warning: exported type Raft should have comment or be unexported (golint)
  • Line 49: warning: exported type Transporter should have comment or be unexported (golint)
  • Line 132: warning: exported method Transport.Start should have comment or be unexported (golint)
  • Line 148: warning: exported method Transport.IsStarted should have comment or be unexported (golint)
  • Line 154: warning: exported method Transport.Handler should have comment or be unexported (golint)
  • Line 166: warning: exported method Transport.Get should have comment or be unexported (golint)
  • Line 172: warning: exported method Transport.Send should have comment or be unexported (golint)
  • Line 202: warning: exported method Transport.Stop should have comment or be unexported (golint)
  • Line 252: warning: exported method Transport.AddRemote should have comment or be unexported (golint)
  • Line 295: warning: exported method Transport.RemovePeer should have comment or be unexported (golint)
  • Line 301: warning: exported method Transport.RemoveAllPeers should have comment or be unexported (golint)
  • Line 309: warning: exported method Transport.GetAllPeers should have comment or be unexported (golint)
  • Line 333: warning: exported method Transport.UpdatePeer should have comment or be unexported (golint)
  • Line 359: warning: exported method Transport.ActiveSince should have comment or be unexported (golint)
  • Line 368: warning: exported method Transport.SendSnapshot should have comment or be unexported (golint)
  • Line 385: warning: exported method Transport.Pause should have comment or be unexported (golint)
  • Line 391: warning: exported method Transport.Resume should have comment or be unexported (golint)
  • Line 399: warning: exported function NewNopTransporter should have comment or be unexported (golint)
  • Line 424: warning: exported function NewSnapTransporter should have comment or be unexported (golint)

• ZanRedisDB/raft/node.go
  • Line 25: warning: exported type SnapshotStatus should have comment or be unexported (golint)
  • Line 28: warning: exported const SnapshotFinish should have comment (or a comment on this block) or be unexported (golint)
  • Line 179: warning: exported type Peer should have comment or be unexported (golint)

• ZanRedisDB/raft/raft.go
  • Line 44: warning: exported type ReadOnlyOption should have comment or be unexported (golint)
  • Line 230: warning: exported function IsFromLocalNodeMsg should have comment or be unexported (golint)

• ZanRedisDB/node/namespace.go
  • Line 23: warning: exported var ErrNamespaceAlreadyExist should have comment or be unexported (golint)
  • Line 39: warning: exported type NamespaceNode should have comment or be unexported (golint)
  • Line 45: warning: exported method NamespaceNode.IsReady should have comment or be unexported (golint)
  • Line 49: warning: exported method NamespaceNode.FullName should have comment or be unexported (golint)
  • Line 53: warning: exported method NamespaceNode.SwitchForLearnerLeader should have comment or be unexported (golint)
  • Line 57: warning: exported method NamespaceNode.SetDynamicInfo should have comment or be unexported (golint)
  • Line 60: warning: exported method NamespaceNode.SetMagicCode should have comment or be unexported (golint)
  • Line 64: warning: exported method NamespaceNode.SetDataFixState should have comment or be unexported (golint)
  • Line 67: warning: exported method NamespaceNode.GetLastLeaderChangedTime should have comment or be unexported (golint)
  • Line 71: warning: exported method NamespaceNode.GetRaftID should have comment or be unexported (golint)
  • Line 75: warning: exported method NamespaceNode.CheckRaftConf should have comment or be unexported (golint)
  • Line 88: warning: exported method NamespaceNode.Close should have comment or be unexported (golint)
  • Line 94: warning: exported method NamespaceNode.Destroy should have comment or be unexported (golint)
  • Line 98: warning: exported method NamespaceNode.IsDataNeedFix should have comment or be unexported (golint)
  • Line 102: warning: comment on exported method NamespaceNode.IsNsNodeFullReady should be of the form "IsNsNodeFullReady ..." (golint)
  • Line 114: warning: exported method NamespaceNode.GetLearners should have comment or be unexported (golint)
  • Line 118: warning: exported method NamespaceNode.GetMembers should have comment or be unexported (golint)
  • Line 122: warning: exported method NamespaceNode.Start should have comment or be unexported (golint)
  • Line 130: warning: exported method NamespaceNode.TransferMyLeader should have comment or be unexported (golint)
  • Line 147: warning: exported type NamespaceMeta should have comment or be unexported (golint)
  • Line 151: warning: exported type NamespaceMgr should have comment or be unexported (golint)
  • Line 165: warning: exported function NewNamespaceMgr should have comment or be unexported (golint)
  • Line 183: warning: exported method NamespaceMgr.SetIClusterInfo should have comment or be unexported (golint)
  • Line 187: warning: exported method NamespaceMgr.LoadMachineRegID should have comment or be unexported (golint)
  • Line 201: warning: exported method NamespaceMgr.SaveMachineRegID should have comment or be unexported (golint)
  • Line 209: warning: exported method NamespaceMgr.Start should have comment or be unexported (golint)
  • Line 236: warning: exported method NamespaceMgr.Stop should have comment or be unexported (golint)
  • Line 252: warning: exported method NamespaceMgr.IsAllRecoveryDone should have comment or be unexported (golint)
  • Line 265: warning: exported method NamespaceMgr.GetNamespaces should have comment or be unexported (golint)
  • Line 275: warning: exported method NamespaceMgr.InitNamespaceNode should have comment or be unexported (golint)
  • Line 356: warning: exported function GetHashedPartitionID should have comment or be unexported (golint)
  • Line 360: warning: exported method NamespaceMgr.GetNamespaceNodeWithPrimaryKey should have comment or be unexported (golint)
  • Line 381: warning: exported method NamespaceMgr.GetNamespaceNodes should have comment or be unexported (golint)
  • Line 402: warning: exported method NamespaceMgr.GetNamespaceNode should have comment or be unexported (golint)
  • Line 414: warning: exported method NamespaceMgr.GetNamespaceNodeFromGID should have comment or be unexported (golint)
  • Line 434: warning: exported method NamespaceMgr.GetDBStats should have comment or be unexported (golint)
  • Line 451: warning: exported method NamespaceMgr.GetLogSyncStatsInSyncer should have comment or be unexported (golint)
  • Line 472: warning: exported method NamespaceMgr.GetLogSyncStats should have comment or be unexported (golint)
  • Line 501: warning: exported method NamespaceMgr.GetStats should have comment or be unexported (golint)
  • Line 521: warning: exported method NamespaceMgr.OptimizeDB should have comment or be unexported (golint)
  • Line 542: warning: exported method NamespaceMgr.DeleteRange should have comment or be unexported (golint)
  • Line 606: warning: comment on exported method NamespaceMgr.SetNamespaceMagicCode should be of the form "SetNamespaceMagicCode ..." (golint)
  • Line 611: warning: exported method NamespaceMgr.CheckMagicCode should have comment or be unexported (golint)
  • Line 694: warning: exported function SetPerfLevel should have comment or be unexported (golint)
  • Line 699: warning: exported function IsPerfEnabled should have comment or be unexported (golint)
  • Line 704: warning: exported function GetPerfLevel should have comment or be unexported (golint)

• ZanRedisDB/apps/restore/main.go
  • Line 34: warning: exported const MAGIC should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/internal/test/fakes.go
  • Line 8: warning: exported type FakeNetConn should have comment or be unexported (golint)
  • Line 21: warning: exported method FakeNetConn.Close should have comment or be unexported (golint)
  • Line 22: warning: exported method FakeNetConn.LocalAddr should have comment or be unexported (golint)
  • Line 23: warning: exported method FakeNetConn.RemoteAddr should have comment or be unexported (golint)
  • Line 24: warning: exported method FakeNetConn.SetDeadline should have comment or be unexported (golint)
  • Line 25: warning: exported method FakeNetConn.SetReadDeadline should have comment or be unexported (golint)
  • Line 26: warning: exported method FakeNetConn.SetWriteDeadline should have comment or be unexported (golint)
  • Line 33: warning: exported function NewFakeNetConn should have comment or be unexported (golint)

• ZanRedisDB/pkg/crc/crc.go
  • Line 14: warning: comment on exported const Size should be of the form "Size ..." (golint)

• ZanRedisDB/common/api_request.go
  • Line 28: warning: exported function NewDeadlineTransport should have comment or be unexported (golint)
  • Line 41: warning: comment on exported function APIRequest should be of the form "APIRequest ..." (golint)

• ZanRedisDB/server/util.go
  • Line 15: warning: exported var ErrUnknownCommand should have comment or be unexported (golint)
  • Line 20: warning: exported function GetIPv4ForInterfaceName should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_set.go
  • Line 256: warning: exported method RockDB.SAdd should have comment or be unexported (golint)
  • Line 297: warning: exported method RockDB.SGetVer should have comment or be unexported (golint)
  • Line 301: warning: exported method RockDB.SCard should have comment or be unexported (golint)
  • Line 305: warning: exported method RockDB.SKeyExists should have comment or be unexported (golint)
  • Line 317: warning: exported method RockDB.SIsMember should have comment or be unexported (golint)
  • Line 332: warning: exported method RockDB.SMembers should have comment or be unexported (golint)
  • Line 372: warning: exported method RockDB.SPop should have comment or be unexported (golint)
  • Line 382: warning: exported method RockDB.SRem should have comment or be unexported (golint)
  • Line 422: warning: exported method RockDB.SClear should have comment or be unexported (golint)
  • Line 434: warning: exported method RockDB.SMclear should have comment or be unexported (golint)
  • Line 464: warning: exported method RockDB.SExpire should have comment or be unexported (golint)
  • Line 467: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 470: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 476: warning: exported method RockDB.SPersist should have comment or be unexported (golint)
  • Line 488: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 491: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/pkg/wait/wait.go
  • Line 81: warning: exported function NewWithResponse should have comment or be unexported (golint)

• ZanRedisDB/cluster/common.go
  • Line 10: warning: exported const ErrFailedOnNotLeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported const MAX_WRITE_RETRY should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported type CoordErrType should have comment or be unexported (golint)
  • Line 20: warning: exported const CoordNoErr should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported const RpcNoErr should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported const RpcErrLeavingISRWait should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported type ErrRPCRetCode should have comment or be unexported (golint)
  • Line 50: warning: comment on exported type CoordErr should be of the form "CoordErr ..." (with optional leading article) (golint)
  • Line 58: warning: exported type CommonCoordErr should have comment or be unexported (golint)
  • Line 62: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 66: warning: exported function NewCoordErr should have comment or be unexported (golint)
  • Line 74: warning: exported function NewCoordErrWithCode should have comment or be unexported (golint)
  • Line 82: warning: exported method CoordErr.ToErrorType should have comment or be unexported (golint)
  • Line 82: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 101: warning: exported method CoordErr.HasError should have comment or be unexported (golint)
  • Line 101: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 108: warning: exported method CoordErr.IsEqual should have comment or be unexported (golint)
  • Line 108: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 131: warning: exported method CoordErr.IsNetErr should have comment or be unexported (golint)
  • Line 131: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 135: warning: exported method CoordErr.IsLocalErr should have comment or be unexported (golint)
  • Line 135: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 139: warning: exported method CoordErr.CanRetryWrite should have comment or be unexported (golint)
  • Line 139: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 154: warning: exported var ErrNamespaceInfoNotFound should have comment or be unexported (golint)
  • Line 170: warning: exported function GenNodeID should have comment or be unexported (golint)
  • Line 189: warning: exported function ExtractRegIDFromGenID should have comment or be unexported (golint)
  • Line 198: warning: exported function ExtractNodeInfoFromID should have comment or be unexported (golint)
  • Line 210: warning: exported function FindSlice should have comment or be unexported (golint)
  • Line 219: warning: exported function MergeList should have comment or be unexported (golint)
  • Line 230: warning: exported function FilterList should have comment or be unexported (golint)
  • Line 241: warning: exported type NamespaceNameInfo should have comment or be unexported (golint)
  • Line 246: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 250: warning: exported type Options should have comment or be unexported (golint)

• ZanRedisDB/cluster/register.go
  • Line 10: warning: exported var ErrKeyAlreadyExist should have comment or be unexported (golint)
  • Line 17: warning: exported type EpochType should have comment or be unexported (golint)
  • Line 19: warning: exported type NodeInfo should have comment or be unexported (golint)
  • Line 36: warning: exported method NodeInfo.GetID should have comment or be unexported (golint)
  • Line 36: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 40: warning: exported method NodeInfo.Epoch should have comment or be unexported (golint)
  • Line 40: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 44: warning: exported method NodeInfo.GetRegisterID should have comment or be unexported (golint)
  • Line 44: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 48: warning: exported type ClusterMetaInfo should have comment or be unexported (golint)
  • Line 53: warning: exported type NamespaceMetaInfo should have comment or be unexported (golint)
  • Line 67: warning: exported method NamespaceMetaInfo.MetaEpoch should have comment or be unexported (golint)
  • Line 67: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 71: warning: exported type RemovingInfo should have comment or be unexported (golint)
  • Line 76: warning: exported type PartitionReplicaInfo should have comment or be unexported (golint)
  • Line 85: warning: exported method PartitionReplicaInfo.IsLearner should have comment or be unexported (golint)
  • Line 85: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 96: warning: exported method PartitionReplicaInfo.GetISR should have comment or be unexported (golint)
  • Line 96: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 110: warning: exported method PartitionReplicaInfo.Epoch should have comment or be unexported (golint)
  • Line 110: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 114: warning: exported method PartitionReplicaInfo.DeepClone should have comment or be unexported (golint)
  • Line 114: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 138: warning: exported type RealLeader should have comment or be unexported (golint)
  • Line 143: warning: exported type PartitionMetaInfo should have comment or be unexported (golint)
  • Line 151: warning: exported method PartitionMetaInfo.IsISRQuorum should have comment or be unexported (golint)
  • Line 151: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 155: warning: exported method PartitionMetaInfo.GetRealLeader should have comment or be unexported (golint)
  • Line 155: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 159: warning: exported method PartitionMetaInfo.GetCopy should have comment or be unexported (golint)
  • Line 159: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 180: warning: exported method PartitionMetaInfo.GetDesp should have comment or be unexported (golint)
  • Line 180: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 184: warning: exported type ConsistentStore should have comment or be unexported (golint)
  • Line 190: warning: exported type SchemaInfo should have comment or be unexported (golint)
  • Line 195: warning: exported type Register should have comment or be unexported (golint)
  • Line 215: warning: comment on exported type PDRegister should be of the form "PDRegister ..." (with optional leading article) (golint)
  • Line 248: warning: exported type DataNodeRegister should have comment or be unexported (golint)

• ZanRedisDB/cluster/datanode_coord/dn_schema_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/common/binary.go
  • Line 9: warning: exported var VerBinary should have comment or be unexported (golint)
  • Line 14: warning: exported function VerString should have comment or be unexported (golint)

• ZanRedisDB/node/keys.go
  • Line 11: warning: exported method KVNode.Lookup should have comment or be unexported (golint)
  • Line 93: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/cluster/util.go
  • Line 9: warning: exported function CoordLog should have comment or be unexported (golint)
  • Line 13: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 17: warning: exported function SetLogger should have comment or be unexported (golint)

• ZanRedisDB/pkg/testutil/pauseable_handler.go
  • Line 22: warning: exported type PauseableHandler should have comment or be unexported (golint)
  • Line 47: warning: exported method PauseableHandler.Pause should have comment or be unexported (golint)
  • Line 53: warning: exported method PauseableHandler.Resume should have comment or be unexported (golint)

• ZanRedisDB/pkg/testutil/recorder.go
  • Line 24: warning: exported type Action should have comment or be unexported (golint)
  • Line 29: warning: exported type Recorder should have comment or be unexported (golint)
  • Line 47: warning: exported method RecorderBuffered.Record should have comment or be unexported (golint)
  • Line 52: warning: exported method RecorderBuffered.Action should have comment or be unexported (golint)
  • Line 59: warning: exported method RecorderBuffered.Wait should have comment or be unexported (golint)
  • Line 69: warning: exported method RecorderBuffered.Chan should have comment or be unexported (golint)
  • Line 86: warning: exported function NewRecorderStream should have comment or be unexported (golint)

• ZanRedisDB/pkg/ioutil/readcloser.go
  • Line 30: warning: exported var ErrShortRead should have comment or be unexported (golint)

• ZanRedisDB/pkg/fileutil/lock.go
  • Line 23: warning: exported var ErrLocked should have comment or be unexported (golint)
  • Line 26: warning: exported type LockedFile should have comment or be unexported (golint)

• ZanRedisDB/rockredis/iterator.go
  • Line 10: warning: exported type Iterator should have comment or be unexported (golint)
  • Line 26: warning: exported type Range should have comment or be unexported (golint)
  • Line 32: warning: exported type Limit should have comment or be unexported (golint)
  • Line 37: warning: exported type DBIterator should have comment or be unexported (golint)
  • Line 47: warning: comment on exported function NewDBIterator should be of the form "NewDBIterator ..." (golint)
  • Line 90: warning: exported method DBIterator.RefKey should have comment or be unexported (golint)
  • Line 94: warning: exported method DBIterator.Key should have comment or be unexported (golint)
  • Line 98: warning: exported method DBIterator.RefValue should have comment or be unexported (golint)
  • Line 106: warning: exported method DBIterator.Value should have comment or be unexported (golint)
  • Line 114: warning: exported method DBIterator.NoTimestamp should have comment or be unexported (golint)
  • Line 118: warning: exported method DBIterator.Close should have comment or be unexported (golint)
  • Line 137: warning: comment on exported function NewDBRangeLimitIterator should be of the form "NewDBRangeLimitIterator ..." (golint)
  • Line 157: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 163: warning: exported function NewSnapshotDBRangeLimitIterator should have comment or be unexported (golint)
  • Line 179: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 185: warning: exported function NewDBRangeIterator should have comment or be unexported (golint)
  • Line 200: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 205: warning: exported function NewSnapshotDBRangeIterator should have comment or be unexported (golint)
  • Line 220: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 225: warning: exported type RangeLimitedIterator should have comment or be unexported (golint)
  • Line 234: warning: exported method RangeLimitedIterator.Valid should have comment or be unexported (golint)
  • Line 250: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 259: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 267: warning: exported method RangeLimitedIterator.Next should have comment or be unexported (golint)
  • Line 276: warning: exported function NewRangeLimitIterator should have comment or be unexported (golint)
  • Line 279: warning: exported function NewRevRangeLimitIterator should have comment or be unexported (golint)
  • Line 282: warning: exported function NewRangeIterator should have comment or be unexported (golint)
  • Line 285: warning: exported function NewRevRangeIterator should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_ttl_c.go
  • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 114: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/stats/stats.go
  • Line 18: warning: exported type Stats should have comment or be unexported (golint)

• ZanRedisDB/common/geohash/util.go
  • Line 23: warning: exported const MERCATOR_MAX should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: comment on exported const EARTH_RADIUS_IN_METERS should be of the form "EARTH_RADIUS_IN_METERS ..." (golint)
  • Line 28: warning: don't use underscores in Go names; const D_R should be DR (golint)
  • Line 93: warning: exported function DistBetweenGeoHashWGS84 should have comment or be unexported (golint)
  • Line 100: warning: comment on exported function GetDistance should be of the form "GetDistance ..." (golint)
  • Line 117: warning: exported function EncodeToBase32 should have comment or be unexported (golint)
  • Line 127: warning: exported function GetAreasByRadiusWGS84 should have comment or be unexported (golint)
  • Line 273: warning: exported function GetNeighbors should have comment or be unexported (golint)

• ZanRedisDB/pdserver/http.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 28: warning: exported type PartitionNodeInfo should have comment or be unexported (golint)
  • Line 33: warning: exported function GetValidPartitionNum should have comment or be unexported (golint)
  • Line 44: warning: exported function GetValidPartitionID should have comment or be unexported (golint)
  • Line 55: warning: exported function GetValidReplicator should have comment or be unexported (golint)
  • Line 298: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 316: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 674: warning: exported method Server.IsTombstonePDNode should have comment or be unexported (golint)
  • Line 681: warning: exported method Server.TombstonePDNode should have comment or be unexported (golint)
  • Line 687: warning: exported method Server.DelTombstonePDNode should have comment or be unexported (golint)

• ZanRedisDB/rockredis/encode.go
  • Line 9: warning: exported function PutRocksdbUint64 should have comment or be unexported (golint)
  • Line 15: warning: exported function GetRocksdbUint64 should have comment or be unexported (golint)

• ZanRedisDB/cluster/datanode_coord/data_node_coordinator.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported var MaxRetryWait should have comment or be unexported (golint)
  • Line 26: warning: comment on exported var TransferLeaderWait should be of the form "TransferLeaderWait ..." (golint)
  • Line 31: warning: comment on exported var ChangeLeaderInRaftWait should be of the form "ChangeLeaderInRaftWait ..." (golint)
  • Line 38: warning: exported function ChangeIntervalForTest should have comment or be unexported (golint)
  • Line 47: warning: exported const MaxRaftJoinRunning should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: exported function GetNamespacePartitionFileName should have comment or be unexported (golint)
  • Line 59: warning: exported function GetNamespacePartitionBasePath should have comment or be unexported (golint)
  • Line 63: warning: exported type PartitionList should have comment or be unexported (golint)
  • Line 73: warning: exported type DataCoordinator should have comment or be unexported (golint)
  • Line 88: warning: exported function NewDataCoordinator should have comment or be unexported (golint)
  • Line 101: warning: exported method DataCoordinator.GetClusterName should have comment or be unexported (golint)
  • Line 105: warning: exported method DataCoordinator.GetMyID should have comment or be unexported (golint)
  • Line 109: warning: exported method DataCoordinator.GetMyRegID should have comment or be unexported (golint)
  • Line 113: warning: exported method DataCoordinator.SetRegister should have comment or be unexported (golint)
  • Line 140: warning: exported method DataCoordinator.Start should have comment or be unexported (golint)
  • Line 179: warning: exported method DataCoordinator.Stop should have comment or be unexported (golint)
  • Line 188: warning: exported method DataCoordinator.GetCurrentPD should have comment or be unexported (golint)
  • Line 1163: warning: exported method DataCoordinator.RestartAsStandalone should have comment or be unexported (golint)
  • Line 1190: warning: exported method DataCoordinator.GetSnapshotSyncInfo should have comment or be unexported (golint)
  • Line 1218: warning: exported method DataCoordinator.IsRemovingMember should have comment or be unexported (golint)
  • Line 1240: warning: exported method DataCoordinator.UpdateMeForNamespaceLeader should have comment or be unexported (golint)
  • Line 1307: warning: exported method DataCoordinator.Stats should have comment or be unexported (golint)

• ZanRedisDB/common/api_response.go
  • Line 16: warning: exported var ErrDeprecatedAPI should have comment or be unexported (golint)
  • Line 19: warning: exported type Decorator should have comment or be unexported (golint)
  • Line 21: warning: exported type APIHandler should have comment or be unexported (golint)
  • Line 23: warning: exported type HttpErr should have comment or be unexported (golint)
  • Line 32: warning: exported function PlainText should have comment or be unexported (golint)
  • Line 54: warning: exported function V1 should have comment or be unexported (golint)
  • Line 66: warning: exported function RespondV1 should have comment or be unexported (golint)
  • Line 101: warning: exported function Decorate should have comment or be unexported (golint)
  • Line 111: warning: exported function HttpLog should have comment or be unexported (golint)

• ZanRedisDB/raft/progress.go
  • Line 24: warning: exported const ProgressStateProbe should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported type ProgressStateType should have comment or be unexported (golint)

• ZanRedisDB/node/schema.go
  • Line 10: warning: exported method KVNode.GetIndexSchema should have comment or be unexported (golint)

• ZanRedisDB/rockredis/memcmp_codec.go
  • Line 22: warning: exported const NilFlag should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: comment on exported function EncodeMemCmpKey should be of the form "EncodeMemCmpKey ..." (golint)
  • Line 82: warning: exported function EncodeMaxKey should have comment or be unexported (golint)
  • Line 87: warning: exported function EncodeMinNotNull should have comment or be unexported (golint)
  • Line 117: warning: exported function DecodeOne should have comment or be unexported (golint)
  • Line 146: warning: exported function CutOne should have comment or be unexported (golint)

• ZanRedisDB/pkg/idutil/id.go
  • Line 56: warning: exported function NewGenerator should have comment or be unexported (golint)

• ZanRedisDB/pkg/ioutil/pagewriter.go
  • Line 98: warning: exported method PageWriter.Flush should have comment or be unexported (golint)

• ZanRedisDB/common/listener.go
  • Line 23: warning: comment on exported type StoppableListener should be of the form "StoppableListener ..." (with optional leading article) (golint)
  • Line 30: warning: exported function NewStoppableListener should have comment or be unexported (golint)
  • Line 38: warning: exported method StoppableListener.Accept should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_list.go
  • Line 362: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 573: warning: exported method RockDB.LIndex should have comment or be unexported (golint)
  • Line 603: warning: exported method RockDB.LVer should have comment or be unexported (golint)
  • Line 613: warning: exported method RockDB.LLen should have comment or be unexported (golint)
  • Line 623: warning: exported method RockDB.LFixKey should have comment or be unexported (golint)
  • Line 627: warning: exported method RockDB.LPop should have comment or be unexported (golint)
  • Line 631: warning: exported method RockDB.LTrim should have comment or be unexported (golint)
  • Line 635: warning: exported method RockDB.LTrimFront should have comment or be unexported (golint)
  • Line 639: warning: exported method RockDB.LTrimBack should have comment or be unexported (golint)
  • Line 643: warning: exported method RockDB.LPush should have comment or be unexported (golint)
  • Line 649: warning: exported method RockDB.LSet should have comment or be unexported (golint)
  • Line 689: warning: exported method RockDB.LRange should have comment or be unexported (golint)
  • Line 754: warning: exported method RockDB.RPop should have comment or be unexported (golint)
  • Line 758: warning: exported method RockDB.RPush should have comment or be unexported (golint)
  • Line 765: warning: exported method RockDB.LClear should have comment or be unexported (golint)
  • Line 779: warning: exported method RockDB.LMclear should have comment or be unexported (golint)
  • Line 815: warning: exported method RockDB.LKeyExists should have comment or be unexported (golint)
  • Line 827: warning: exported method RockDB.LExpire should have comment or be unexported (golint)
  • Line 830: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 833: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 839: warning: exported method RockDB.LPersist should have comment or be unexported (golint)
  • Line 851: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 854: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/apps/backup/main.go
  • Line 39: warning: exported const MAGIC should have comment (or a comment on this block) or be unexported (golint)

• ZanRedisDB/pkg/testutil/assert.go
  • Line 23: warning: exported function AssertEqual should have comment or be unexported (golint)
  • Line 38: warning: exported function AssertNil should have comment or be unexported (golint)
  • Line 42: warning: exported function AssertNotNil should have comment or be unexported (golint)
  • Line 48: warning: exported function AssertTrue should have comment or be unexported (golint)
  • Line 52: warning: exported function AssertFalse should have comment or be unexported (golint)

• ZanRedisDB/pkg/transport/listener.go
  • Line 37: warning: exported function NewListener should have comment or be unexported (golint)
  • Line 59: warning: exported type TLSInfo should have comment or be unexported (golint)
  • Line 89: warning: exported method TLSInfo.Empty should have comment or be unexported (golint)
  • Line 93: warning: exported function SelfCert should have comment or be unexported (golint)

• ZanRedisDB/pkg/fileutil/lock_linux.go
  • Line 58: warning: exported function TryLockFile should have comment or be unexported (golint)
  • Line 79: warning: exported function LockFile should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/stream.go
  • Line 304: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 346: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 416: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 427: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 511: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 518: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 524: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)

• ZanRedisDB/node/node.go
  • Line 37: warning: exported const RedisReq should have comment (or a comment on this block) or be unexported (golint)
  • Line 45: warning: don't use underscores in Go names; const ProposeOp_Backup should be ProposeOpBackup (golint)
  • Line 45: warning: exported const ProposeOp_Backup should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: don't use underscores in Go names; const ProposeOp_TransferRemoteSnap should be ProposeOpTransferRemoteSnap (golint)
  • Line 47: warning: don't use underscores in Go names; const ProposeOp_ApplyRemoteSnap should be ProposeOpApplyRemoteSnap (golint)
  • Line 48: warning: don't use underscores in Go names; const ProposeOp_RemoteConfChange should be ProposeOpRemoteConfChange (golint)
  • Line 49: warning: don't use underscores in Go names; const ProposeOp_ApplySkippedRemoteSnap should be ProposeOpApplySkippedRemoteSnap (golint)
  • Line 50: warning: don't use underscores in Go names; const ProposeOp_DeleteTable should be ProposeOpDeleteTable (golint)
  • Line 53: warning: exported type DeleteTableRange should have comment or be unexported (golint)
  • Line 62: warning: exported method DeleteTableRange.CheckValid should have comment or be unexported (golint)
  • Line 96: warning: comment on exported type KVNode should be of the form "KVNode ..." (with optional leading article) (golint)
  • Line 120: warning: exported type KVSnapInfo should have comment or be unexported (golint)
  • Line 130: warning: exported method KVSnapInfo.GetData should have comment or be unexported (golint)
  • Line 142: warning: exported function NewKVNode should have comment or be unexported (golint)
  • Line 188: warning: exported method KVNode.Start should have comment or be unexported (golint)
  • Line 219: warning: exported method KVNode.StopRaft should have comment or be unexported (golint)
  • Line 223: warning: exported method KVNode.Stop should have comment or be unexported (golint)
  • Line 239: warning: exported method KVNode.OptimizeDB should have comment or be unexported (golint)
  • Line 257: warning: exported method KVNode.DeleteRange should have comment or be unexported (golint)
  • Line 282: warning: exported method KVNode.IsLead should have comment or be unexported (golint)
  • Line 286: warning: exported method KVNode.GetRaftStatus should have comment or be unexported (golint)
  • Line 290: warning: comment on exported method KVNode.IsReplicaRaftReady should be of the form "IsReplicaRaftReady ..." (golint)
  • Line 309: warning: exported method KVNode.GetLeadMember should have comment or be unexported (golint)
  • Line 313: warning: exported method KVNode.GetMembers should have comment or be unexported (golint)
  • Line 317: warning: exported method KVNode.GetLearners should have comment or be unexported (golint)
  • Line 321: warning: exported method KVNode.GetLocalMemberInfo should have comment or be unexported (golint)
  • Line 334: warning: exported method KVNode.GetDBInternalStats should have comment or be unexported (golint)
  • Line 341: warning: exported method KVNode.GetStats should have comment or be unexported (golint)
  • Line 357: warning: exported method KVNode.CleanData should have comment or be unexported (golint)
  • Line 361: warning: exported method KVNode.GetHandler should have comment or be unexported (golint)
  • Line 365: warning: exported method KVNode.GetMergeHandler should have comment or be unexported (golint)
  • Line 493: warning: exported method KVNode.IsWriteReady should have comment or be unexported (golint)
  • Line 497: warning: exported method KVNode.ProposeRawAndWait should have comment or be unexported (golint)
  • Line 634: warning: exported method KVNode.Propose should have comment or be unexported (golint)
  • Line 649: warning: exported method KVNode.CustomPropose should have comment or be unexported (golint)
  • Line 664: warning: exported method KVNode.ProposeChangeTableSchema should have comment or be unexported (golint)
  • Line 682: warning: exported method KVNode.FillMyMemberInfo should have comment or be unexported (golint)
  • Line 686: warning: exported method KVNode.ProposeAddLearner should have comment or be unexported (golint)
  • Line 707: warning: exported method KVNode.ProposeAddMember should have comment or be unexported (golint)
  • Line 728: warning: exported method KVNode.ProposeRemoveMember should have comment or be unexported (golint)
  • Line 741: warning: exported method KVNode.ProposeUpdateMember should have comment or be unexported (golint)
  • Line 771: warning: exported method KVNode.Tick should have comment or be unexported (golint)
  • Line 775: warning: exported method KVNode.GetCommittedIndex should have comment or be unexported (golint)
  • Line 779: warning: exported method KVNode.SetCommittedIndex should have comment or be unexported (golint)
  • Line 783: warning: exported method KVNode.IsRaftSynced should have comment or be unexported (golint)
  • Line 1088: warning: exported method KVNode.GetSnapshot should have comment or be unexported (golint)
  • Line 1099: warning: exported method KVNode.RestoreFromSnapshot should have comment or be unexported (golint)
  • Line 1113: warning: exported method KVNode.CheckLocalBackup should have comment or be unexported (golint)
  • Line 1125: warning: exported method KVNode.GetLastLeaderChangedTime should have comment or be unexported (golint)
  • Line 1129: warning: exported method KVNode.ReportMeLeaderToCluster should have comment or be unexported (golint)
  • Line 1143: warning: comment on exported method KVNode.OnRaftLeaderChanged should be of the form "OnRaftLeaderChanged ..." (golint)
  • Line 1152: warning: exported method KVNode.Process should have comment or be unexported (golint)
  • Line 1156: warning: exported method KVNode.ReportUnreachable should have comment or be unexported (golint)
  • Line 1160: warning: exported method KVNode.ReportSnapshot should have comment or be unexported (golint)
  • Line 1164: warning: exported method KVNode.SaveDBFrom should have comment or be unexported (golint)
  • Line 1168: warning: exported method KVNode.IsPeerRemoved should have comment or be unexported (golint)

• ZanRedisDB/node/state_machine.go
  • Line 32: warning: exported type StateMachine should have comment or be unexported (golint)
  • Line 46: warning: exported function NewStateMachine should have comment or be unexported (golint)
  • Line 129: warning: exported function NewKVStoreSM should have comment or be unexported (golint)
  • Line 273: warning: exported function GetValidBackupInfo should have comment or be unexported (golint)

• ZanRedisDB/common/geohash/geohash.go
  • Line 10: warning: comment on exported const WGS84_LAT_MIN should be of the form "WGS84_LAT_MIN ..." (golint)
  • Line 13: warning: exported const WGS84_LAT_MAX should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: comment on exported const WGS84_GEO_STEP should be of the form "WGS84_GEO_STEP ..." (golint)
  • Line 22: warning: exported var WGS84_LONG_RANGE should have comment or be unexported (golint)
  • Line 27: warning: exported var ErrPositionOutOfRange should have comment or be unexported (golint)
  • Line 31: warning: exported function EncodeWGS84 should have comment or be unexported (golint)
  • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 43: warning: exported function DecodeWGS84 should have comment or be unexported (golint)
  • Line 51: warning: exported function DecodeToLongLatWGS84 should have comment or be unexported (golint)
  • Line 56: warning: exported function Encode should have comment or be unexported (golint)
  • Line 90: warning: exported function DecodeAreaToLongLat should have comment or be unexported (golint)

• ZanRedisDB/internal/test/assertions.go
  • Line 10: warning: exported function Assert should have comment or be unexported (golint)
  • Line 19: warning: exported function Equal should have comment or be unexported (golint)
  • Line 28: warning: exported function NotEqual should have comment or be unexported (golint)
  • Line 37: warning: exported function Nil should have comment or be unexported (golint)
  • Line 46: warning: exported function NotNil should have comment or be unexported (golint)

• ZanRedisDB/wal/wal.go
  • Line 57: warning: exported var ErrMetadataConflict should have comment or be unexported (golint)
  • Line 289: warning: exported method WAL.ChangeFsyncFlag should have comment or be unexported (golint)
  • Line 556: warning: exported method WAL.Close should have comment or be unexported (golint)
  • Line 603: warning: exported method WAL.Save should have comment or be unexported (golint)
  • Line 642: warning: exported method WAL.SaveSnapshot should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/place_driver.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 19: warning: exported var ErrBalanceNodeUnavailable should have comment or be unexported (golint)
  • Line 42: warning: exported method IntHeap.Push should have comment or be unexported (golint)
  • Line 48: warning: exported method IntHeap.Pop should have comment or be unexported (golint)
  • Line 79: warning: comment on exported function IsRaftNodeJoined should be of the form "IsRaftNodeJoined ..." (golint)
  • Line 110: warning: comment on exported function IsAllISRFullReady should be of the form "IsAllISRFullReady ..." (golint)
  • Line 121: warning: comment on exported function IsRaftNodeFullReady should be of the form "IsRaftNodeFullReady ..." (golint)
  • Line 159: warning: exported type DataPlacement should have comment or be unexported (golint)
  • Line 164: warning: exported function NewDataPlacement should have comment or be unexported (golint)
  • Line 171: warning: exported method DataPlacement.SetBalanceInterval should have comment or be unexported (golint)
  • Line 179: warning: exported method DataPlacement.DoBalance should have comment or be unexported (golint)
  • Line 510: warning: exported type SortableStrings should have comment or be unexported (golint)

• ZanRedisDB/server/httpapi.go
  • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 27: warning: exported type RaftStatus should have comment or be unexported (golint)
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/node/kvstore.go
  • Line 11: warning: comment on exported type KVStore should be of the form "KVStore ..." (with optional leading article) (golint)
  • Line 17: warning: exported type KVOptions should have comment or be unexported (golint)
  • Line 25: warning: exported function NewKVStore should have comment or be unexported (golint)
  • Line 55: warning: exported method KVStore.CleanData should have comment or be unexported (golint)
  • Line 68: warning: comment on exported method KVStore.Destroy should be of the form "Destroy ..." (golint)
  • Line 76: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 85: warning: exported method KVStore.CheckExpiredData should have comment or be unexported (golint)
  • Line 92: warning: exported method KVStore.LocalLookup should have comment or be unexported (golint)
  • Line 97: warning: exported method KVStore.LocalDelete should have comment or be unexported (golint)
  • Line 101: warning: exported method KVStore.LocalPut should have comment or be unexported (golint)
  • Line 106: warning: exported method KVStore.LocalWriteBatch should have comment or be unexported (golint)
  • Line 110: warning: exported method KVStore.IsBatchableWrite should have comment or be unexported (golint)
  • Line 113: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 118: warning: exported method KVStore.BeginBatchWrite should have comment or be unexported (golint)
  • Line 121: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 126: warning: exported method KVStore.CommitBatchWrite should have comment or be unexported (golint)
  • Line 129: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/rockredis/rockredis.go
  • Line 27: warning: exported const MAX_CHECKPOINT_NUM should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 37: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 42: warning: exported function GetCheckpointDir should have comment or be unexported (golint)
  • Line 48: warning: exported type RockOptions should have comment or be unexported (golint)
  • Line 73: warning: exported function FillDefaultOptions should have comment or be unexported (golint)
  • Line 141: warning: exported type SharedRockConfig should have comment or be unexported (golint)
  • Line 146: warning: exported type RockConfig should have comment or be unexported (golint)
  • Line 158: warning: exported function NewRockConfig should have comment or be unexported (golint)
  • Line 170: warning: exported function NewSharedRockConfig should have comment or be unexported (golint)
  • Line 200: warning: exported method SharedRockConfig.Destroy should have comment or be unexported (golint)
  • Line 212: warning: exported type CheckpointSortNames should have comment or be unexported (golint)
  • Line 214: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 218: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 222: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 263: warning: exported type RockDB should have comment or be unexported (golint)
  • Line 285: warning: exported function OpenRockDB should have comment or be unexported (golint)
  • Line 418: warning: exported function GetBackupDir should have comment or be unexported (golint)
  • Line 422: warning: exported method RockDB.CheckExpiredData should have comment or be unexported (golint)
  • Line 429: warning: exported method RockDB.GetBackupBase should have comment or be unexported (golint)
  • Line 433: warning: exported method RockDB.GetBackupDir should have comment or be unexported (golint)
  • Line 437: warning: exported function GetDataDirFromBase should have comment or be unexported (golint)
  • Line 441: warning: exported method RockDB.GetDataDir should have comment or be unexported (golint)
  • Line 481: warning: exported method RockDB.CompactRange should have comment or be unexported (golint)
  • Line 486: warning: comment on exported method RockDB.CompactTableRange should be of the form "CompactTableRange ..." (golint)
  • Line 523: warning: exported method RockDB.Close should have comment or be unexported (golint)
  • Line 559: warning: exported method RockDB.GetStatistics should have comment or be unexported (golint)
  • Line 618: warning: comment on exported method RockDB.DeleteTableRange should be of the form "DeleteTableRange ..." (golint)
  • Line 671: warning: exported method RockDB.GetBTablesSizes should have comment or be unexported (golint)
  • Line 681: warning: comment on exported method RockDB.GetTablesSizes should be of the form "GetTablesSizes ..." (golint)
  • Line 693: warning: comment on exported method RockDB.GetTableSizeInRange should be of the form "GetTableSizeInRange ..." (golint)
  • Line 726: warning: comment on exported method RockDB.GetTableApproximateNumInRange should be of the form "GetTableApproximateNumInRange ..." (golint)
  • Line 769: warning: exported method RockDB.GetInternalStatus should have comment or be unexported (golint)
  • Line 789: warning: exported method RockDB.GetInternalPropertyStatus should have comment or be unexported (golint)
  • Line 793: warning: exported type BackupInfo should have comment or be unexported (golint)
  • Line 809: warning: exported method BackupInfo.WaitReady should have comment or be unexported (golint)
  • Line 809: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 816: warning: exported method BackupInfo.GetResult should have comment or be unexported (golint)
  • Line 816: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 882: warning: exported method RockDB.Backup should have comment or be unexported (golint)
  • Line 895: warning: exported method RockDB.IsLocalBackupOK should have comment or be unexported (golint)
  • Line 959: warning: exported method RockDB.Restore should have comment or be unexported (golint)
  • Line 1032: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1045: warning: exported method RockDB.ClearBackup should have comment or be unexported (golint)
  • Line 1051: warning: exported method RockDB.GetIndexSchema should have comment or be unexported (golint)
  • Line 1055: warning: exported method RockDB.GetAllIndexSchema should have comment or be unexported (golint)
  • Line 1059: warning: exported method RockDB.AddHsetIndex should have comment or be unexported (golint)
  • Line 1075: warning: exported method RockDB.UpdateHsetIndexState should have comment or be unexported (golint)
  • Line 1079: warning: exported method RockDB.BeginBatchWrite should have comment or be unexported (golint)
  • Line 1087: warning: exported method RockDB.MaybeClearBatch should have comment or be unexported (golint)
  • Line 1094: warning: exported method RockDB.MaybeCommitBatch should have comment or be unexported (golint)
  • Line 1101: warning: exported method RockDB.CommitBatchWrite should have comment or be unexported (golint)
  • Line 1110: warning: exported function IsBatchableWrite should have comment or be unexported (golint)
  • Line 1115: warning: exported function SetPerfLevel should have comment or be unexported (golint)
  • Line 1123: warning: exported function IsPerfEnabledLevel should have comment or be unexported (golint)
  • Line 1130: warning: exported function DisablePerfLevel should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/msg_codec.go
  • Line 47: warning: exported var ErrExceedSizeLimit should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/peer.go
  • Line 38: warning: exported const ConnWriteTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported type Peer should have comment or be unexported (golint)

• ZanRedisDB/server/server.go
  • Line 36: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 41: warning: exported function SLogger should have comment or be unexported (golint)
  • Line 45: warning: exported type Server should have comment or be unexported (golint)
  • Line 59: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 173: warning: exported method Server.Stop should have comment or be unexported (golint)
  • Line 192: warning: exported method Server.GetCoord should have comment or be unexported (golint)
  • Line 196: warning: exported method Server.GetNamespace should have comment or be unexported (golint)
  • Line 199: warning: exported method Server.GetNamespaceFromFullName should have comment or be unexported (golint)
  • Line 203: warning: exported method Server.GetLogSyncStatsInSyncLearner should have comment or be unexported (golint)
  • Line 207: warning: exported method Server.GetLogSyncStats should have comment or be unexported (golint)
  • Line 211: warning: exported method Server.GetStats should have comment or be unexported (golint)
  • Line 218: warning: exported method Server.GetDBStats should have comment or be unexported (golint)
  • Line 222: warning: exported method Server.OptimizeDB should have comment or be unexported (golint)
  • Line 226: warning: exported method Server.DeleteRange should have comment or be unexported (golint)
  • Line 230: warning: exported method Server.InitKVNamespace should have comment or be unexported (golint)
  • Line 234: warning: exported method Server.RestartAsStandalone should have comment or be unexported (golint)
  • Line 241: warning: exported method Server.Start should have comment or be unexported (golint)
  • Line 278: warning: exported method Server.GetHandler should have comment or be unexported (golint)
  • Line 326: warning: comment on exported method Server.Process should be of the form "Process ..." (golint)
  • Line 343: warning: exported method Server.IsPeerRemoved should have comment or be unexported (golint)
  • Line 345: warning: exported method Server.ReportUnreachable should have comment or be unexported (golint)
  • Line 358: warning: exported method Server.ReportSnapshot should have comment or be unexported (golint)
  • Line 372: warning: comment on exported method Server.SaveDBFrom should be of the form "SaveDBFrom ..." (golint)

• ZanRedisDB/node/log_sender.go
  • Line 43: warning: exported function NewRemoteLogSender should have comment or be unexported (golint)
  • Line 82: warning: exported method RemoteLogSender.Stop should have comment or be unexported (golint)
  • Line 95: warning: exported method RemoteLogSender.GetStats should have comment or be unexported (golint)
  • Line 391: warning: exported type RaftRpcFunc should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_table.go
  • Line 167: warning: exported method RockDB.GetTables should have comment or be unexported (golint)
  • Line 187: warning: exported method RockDB.DelTableKeyCount should have comment or be unexported (golint)
  • Line 196: warning: exported method RockDB.IncrTableKeyCount should have comment or be unexported (golint)
  • Line 205: warning: exported method RockDB.GetTableKeyCount should have comment or be unexported (golint)
  • Line 249: warning: exported method RockDB.GetHsetIndexTables should have comment or be unexported (golint)
  • Line 271: warning: exported method RockDB.GetTableHsetIndexValue should have comment or be unexported (golint)
  • Line 276: warning: exported method RockDB.SetTableHsetIndexValue should have comment or be unexported (golint)

• ZanRedisDB/pkg/pbutil/pbutil.go
  • Line 24: warning: exported type Marshaler should have comment or be unexported (golint)
  • Line 28: warning: exported type Unmarshaler should have comment or be unexported (golint)
  • Line 32: warning: exported function MustMarshal should have comment or be unexported (golint)
  • Line 40: warning: exported function MustUnmarshal should have comment or be unexported (golint)
  • Line 46: warning: exported function MaybeUnmarshal should have comment or be unexported (golint)
  • Line 53: warning: exported function GetBool should have comment or be unexported (golint)
  • Line 60: warning: exported function Boolp should have comment or be unexported (golint)

• ZanRedisDB/stats/server.go
  • Line 56: warning: exported method TransportStats.JSON should have comment or be unexported (golint)
  • Line 138: warning: exported method TransportStats.BecomeLeader should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/place_driver_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/pkg/fileutil/fileutil.go
  • Line 96: warning: exported function Exist should have comment or be unexported (golint)

• ZanRedisDB/node/remote_sync_mgr.go
  • Line 12: warning: exported type SyncedState should have comment or be unexported (golint)
  • Line 20: warning: exported method SyncedState.IsNewer should have comment or be unexported (golint)
  • Line 27: warning: exported method SyncedState.IsSame should have comment or be unexported (golint)
  • Line 31: warning: exported method SyncedState.IsNewer2 should have comment or be unexported (golint)
  • Line 39: warning: exported const ApplySnapUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported type SnapApplyStatus should have comment or be unexported (golint)
  • Line 234: warning: exported method KVNode.SetRemoteClusterSyncedRaft should have comment or be unexported (golint)
  • Line 237: warning: exported method KVNode.GetRemoteClusterSyncedRaft should have comment or be unexported (golint)
  • Line 242: warning: exported method KVNode.GetLogSyncStatsInSyncLearner should have comment or be unexported (golint)
  • Line 252: warning: exported method KVNode.ApplyRemoteSnapshot should have comment or be unexported (golint)
  • Line 313: warning: exported method KVNode.BeginTransferRemoteSnap should have comment or be unexported (golint)
  • Line 356: warning: exported method KVNode.GetApplyRemoteSnapStatus should have comment or be unexported (golint)

• ZanRedisDB/node/zset.go
  • Line 579: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/pkg/types/set.go
  • Line 23: warning: exported type Set should have comment or be unexported (golint)
  • Line 34: warning: exported function NewUnsafeSet should have comment or be unexported (golint)
  • Line 42: warning: exported function NewThreadsafeSet should have comment or be unexported (golint)

• ZanRedisDB/cluster/register_etcd.go
  • Line 20: warning: exported const EVENT_WATCH_L_CREATE should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported const ETCD_TTL should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported const ROOT_DIR should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported const ETCD_LOCK_NAMESPACE should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: exported type MasterChanInfo should have comment or be unexported (golint)
  • Line 51: warning: exported function IsEtcdNotFile should have comment or be unexported (golint)
  • Line 55: warning: exported function IsEtcdNodeExist should have comment or be unexported (golint)
  • Line 109: warning: exported type EtcdRegister should have comment or be unexported (golint)
  • Line 126: warning: exported function NewEtcdRegister should have comment or be unexported (golint)
  • Line 139: warning: exported method EtcdRegister.InitClusterID should have comment or be unexported (golint)
  • Line 146: warning: exported method EtcdRegister.Start should have comment or be unexported (golint)
  • Line 159: warning: exported method EtcdRegister.Stop should have comment or be unexported (golint)
  • Line 172: warning: exported method EtcdRegister.GetAllPDNodes should have comment or be unexported (golint)
  • Line 191: warning: exported method EtcdRegister.GetAllNamespaces should have comment or be unexported (golint)
  • Line 203: warning: exported method EtcdRegister.GetNamespaceSchemas should have comment or be unexported (golint)
  • Line 226: warning: exported method EtcdRegister.GetNamespacesNotifyChan should have comment or be unexported (golint)
  • Line 444: warning: exported method EtcdRegister.GetNamespacePartInfo should have comment or be unexported (golint)
  • Line 461: warning: exported method EtcdRegister.GetRemoteNamespaceReplicaInfo should have comment or be unexported (golint)
  • Line 478: warning: exported method EtcdRegister.GetNamespaceTableSchema should have comment or be unexported (golint)
  • Line 492: warning: exported method EtcdRegister.GetNamespaceInfo should have comment or be unexported (golint)
  • Line 506: warning: exported method EtcdRegister.GetNamespaceMetaInfo should have comment or be unexported (golint)
  • Line 581: warning: comment on exported type PDEtcdRegister should be of the form "PDEtcdRegister ..." (with optional leading article) (golint)
  • Line 594: warning: exported function NewPDEtcdRegister should have comment or be unexported (golint)
  • Line 601: warning: exported method PDEtcdRegister.Register should have comment or be unexported (golint)
  • Line 644: warning: exported method PDEtcdRegister.Unregister should have comment or be unexported (golint)
  • Line 660: warning: exported method PDEtcdRegister.PrepareNamespaceMinGID should have comment or be unexported (golint)
  • Line 684: warning: exported method PDEtcdRegister.GetClusterMetaInfo should have comment or be unexported (golint)
  • Line 697: warning: exported method PDEtcdRegister.GetClusterEpoch should have comment or be unexported (golint)
  • Line 709: warning: exported method PDEtcdRegister.AcquireAndWatchLeader should have comment or be unexported (golint)
  • Line 745: warning: exported method PDEtcdRegister.CheckIfLeader should have comment or be unexported (golint)
  • Line 756: warning: exported method PDEtcdRegister.GetDataNodes should have comment or be unexported (golint)
  • Line 760: warning: exported method PDEtcdRegister.WatchDataNodes should have comment or be unexported (golint)
  • Line 787: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 842: warning: exported method PDEtcdRegister.CreateNamespacePartition should have comment or be unexported (golint)
  • Line 853: warning: exported method PDEtcdRegister.CreateNamespace should have comment or be unexported (golint)
  • Line 873: warning: exported method PDEtcdRegister.IsExistNamespace should have comment or be unexported (golint)
  • Line 878: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 885: warning: exported method PDEtcdRegister.IsExistNamespacePartition should have comment or be unexported (golint)
  • Line 890: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 897: warning: exported method PDEtcdRegister.UpdateNamespaceMetaInfo should have comment or be unexported (golint)
  • Line 921: warning: exported method PDEtcdRegister.DeleteWholeNamespace should have comment or be unexported (golint)
  • Line 930: warning: exported method PDEtcdRegister.DeleteNamespacePart should have comment or be unexported (golint)
  • Line 940: warning: exported method PDEtcdRegister.UpdateNamespacePartReplicaInfo should have comment or be unexported (golint)
  • Line 963: warning: exported method PDEtcdRegister.UpdateNamespaceSchema should have comment or be unexported (golint)
  • Line 982: warning: exported type DNEtcdRegister should have comment or be unexported (golint)
  • Line 991: warning: exported function SetEtcdLogger should have comment or be unexported (golint)
  • Line 995: warning: exported function NewDNEtcdRegister should have comment or be unexported (golint)
  • Line 1001: warning: exported method DNEtcdRegister.Register should have comment or be unexported (golint)
  • Line 1063: warning: exported method DNEtcdRegister.Unregister should have comment or be unexported (golint)
  • Line 1083: warning: exported method DNEtcdRegister.GetNamespaceLeader should have comment or be unexported (golint)
  • Line 1097: warning: exported method DNEtcdRegister.UpdateNamespaceLeader should have comment or be unexported (golint)
  • Line 1118: warning: exported method DNEtcdRegister.GetNodeInfo should have comment or be unexported (golint)
  • Line 1134: warning: exported method DNEtcdRegister.NewRegisterNodeID should have comment or be unexported (golint)
  • Line 1151: warning: exported method DNEtcdRegister.WatchPDLeader should have comment or be unexported (golint)
  • Line 1187: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/common/stats.go
  • Line 8: warning: exported type WriteStats should have comment or be unexported (golint)
  • Line 15: warning: exported method WriteStats.UpdateSizeStats should have comment or be unexported (golint)
  • Line 29: warning: exported method WriteStats.BatchUpdateLatencyStats should have comment or be unexported (golint)
  • Line 41: warning: exported method WriteStats.UpdateLatencyStats should have comment or be unexported (golint)
  • Line 53: warning: exported method WriteStats.UpdateWriteStats should have comment or be unexported (golint)
  • Line 58: warning: exported method WriteStats.Copy should have comment or be unexported (golint)
  • Line 69: warning: exported type TableStats should have comment or be unexported (golint)
  • Line 76: warning: exported type NamespaceStats should have comment or be unexported (golint)
  • Line 86: warning: exported type LogSyncStats should have comment or be unexported (golint)
  • Line 94: warning: exported type ScanStats should have comment or be unexported (golint)
  • Line 100: warning: exported method ScanStats.IncScanCount should have comment or be unexported (golint)
  • Line 104: warning: exported method ScanStats.UpdateLatencyStats should have comment or be unexported (golint)
  • Line 116: warning: exported method ScanStats.UpdateScanStats should have comment or be unexported (golint)
  • Line 121: warning: exported method ScanStats.Copy should have comment or be unexported (golint)
  • Line 130: warning: exported type ServerStats should have comment or be unexported (golint)

• ZanRedisDB/common/type.go
  • Line 15: warning: exported const DIR_PERM should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported const LearnerRoleLogSyncer should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported var SCAN_CURSOR_SEP should have comment or be unexported (golint)
  • Line 30: warning: exported var ErrInvalidCommand should have comment or be unexported (golint)
  • Line 45: warning: comment on exported type DataType should be of the form "DataType ..." (with optional leading article) (golint)
  • Line 49: warning: exported const NONE should have comment (or a comment on this block) or be unexported (golint)
  • Line 59: warning: exported const KVName should have comment (or a comment on this block) or be unexported (golint)
  • Line 67: warning: exported const KEYSEP should have comment (or a comment on this block) or be unexported (golint)
  • Line 87: warning: exported type ExpirationPolicy should have comment or be unexported (golint)
  • Line 100: warning: comment on exported const PeriodicalRotation should be of the form "PeriodicalRotation ..." (golint)
  • Line 103: warning: exported const UnknownPolicy should have comment (or a comment on this block) or be unexported (golint)
  • Line 107: warning: exported const DefaultExpirationPolicy should have comment (or a comment on this block) or be unexported (golint)
  • Line 110: warning: exported function StringToExpirationPolicy should have comment or be unexported (golint)
  • Line 121: warning: exported type WriteCmd should have comment or be unexported (golint)
  • Line 126: warning: exported type KVRecord should have comment or be unexported (golint)
  • Line 131: warning: exported type KVRecordRet should have comment or be unexported (golint)
  • Line 136: warning: exported type KVals should have comment or be unexported (golint)
  • Line 141: warning: exported type KFVals should have comment or be unexported (golint)
  • Line 147: warning: exported var MAX_BATCH_NUM should have comment or be unexported (golint)
  • Line 155: warning: exported const RangeClose should have comment (or a comment on this block) or be unexported (golint)
  • Line 161: warning: exported function ExtractTable should have comment or be unexported (golint)
  • Line 172: warning: exported type ScorePair should have comment or be unexported (golint)
  • Line 177: warning: exported type CommandFunc should have comment or be unexported (golint)
  • Line 178: warning: exported type CommandRspFunc should have comment or be unexported (golint)
  • Line 179: warning: exported type InternalCommandFunc should have comment or be unexported (golint)
  • Line 180: warning: exported type MergeCommandFunc should have comment or be unexported (golint)
  • Line 181: warning: exported type MergeWriteCommandFunc should have comment or be unexported (golint)
  • Line 183: warning: exported type CmdRouter should have comment or be unexported (golint)
  • Line 190: warning: exported function NewCmdRouter should have comment or be unexported (golint)
  • Line 199: warning: exported method CmdRouter.Register should have comment or be unexported (golint)
  • Line 211: warning: exported method CmdRouter.GetCmdHandler should have comment or be unexported (golint)
  • Line 220: warning: exported method CmdRouter.RegisterMerge should have comment or be unexported (golint)
  • Line 228: warning: exported method CmdRouter.RegisterWriteMerge should have comment or be unexported (golint)
  • Line 236: warning: comment on exported method CmdRouter.GetMergeCmdHandler should be of the form "GetMergeCmdHandler ..." (golint)
  • Line 246: warning: exported type SMCmdRouter should have comment or be unexported (golint)
  • Line 250: warning: exported function NewSMCmdRouter should have comment or be unexported (golint)
  • Line 256: warning: exported method SMCmdRouter.RegisterInternal should have comment or be unexported (golint)
  • Line 264: warning: exported method SMCmdRouter.GetInternalCmdHandler should have comment or be unexported (golint)
  • Line 269: warning: exported type StringArray should have comment or be unexported (golint)
  • Line 271: warning: exported method StringArray.Set should have comment or be unexported (golint)
  • Line 281: warning: exported const MAX_PARTITION_NUM should have comment (or a comment on this block) or be unexported (golint)
  • Line 285: warning: exported type MemberInfo should have comment or be unexported (golint)
  • Line 296: warning: exported method MemberInfo.IsEqual should have comment or be unexported (golint)
  • Line 296: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 315: warning: exported type SnapshotSyncInfo should have comment or be unexported (golint)
  • Line 324: warning: exported type IClusterInfo should have comment or be unexported (golint)
  • Line 330: warning: exported type ScanResult should have comment or be unexported (golint)
  • Line 337: warning: exported type IndexState should have comment or be unexported (golint)
  • Line 340: warning: exported const InitIndex should have comment (or a comment on this block) or be unexported (golint)
  • Line 348: warning: exported type IndexPropertyDType should have comment or be unexported (golint)
  • Line 351: warning: exported const Int64V should have comment (or a comment on this block) or be unexported (golint)
  • Line 357: warning: exported type HsetIndexSchema should have comment or be unexported (golint)
  • Line 366: warning: exported method HsetIndexSchema.IsValidNewSchema should have comment or be unexported (golint)
  • Line 370: warning: exported type HIndexRespWithValues should have comment or be unexported (golint)
  • Line 377: warning: exported type SearchResultHeap should have comment or be unexported (golint)
  • Line 420: warning: exported method SearchResultHeap.Push should have comment or be unexported (golint)
  • Line 427: warning: exported method SearchResultHeap.Pop should have comment or be unexported (golint)
  • Line 440: warning: exported type JSONIndexSchema should have comment or be unexported (golint)
  • Line 444: warning: exported type IndexSchema should have comment or be unexported (golint)
  • Line 449: warning: exported type ExpiredDataBuffer should have comment or be unexported (golint)
  • Line 453: warning: exported type FullScanResult should have comment or be unexported (golint)
  • Line 461: warning: exported type FieldPair should have comment or be unexported (golint)

• ZanRedisDB/common/util.go
  • Line 14: warning: comment on exported const APIAddNode should be of the form "APIAddNode ..." (golint)
  • Line 16: warning: exported const APIAddLearnerNode should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: comment on exported const APIIsRaftSynced should be of the form "APIIsRaftSynced ..." (golint)
  • Line 26: warning: comment on exported const APIGetSnapshotSyncInfo should be of the form "APIGetSnapshotSyncInfo ..." (golint)
  • Line 31: warning: exported const NamespaceTableSeperator should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported function GetIPv4ForInterfaceName should have comment or be unexported (golint)
  • Line 56: warning: exported const InternalPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 59: warning: exported function IsValidNamespaceName should have comment or be unexported (golint)
  • Line 63: warning: exported function IsValidTableName should have comment or be unexported (golint)
  • Line 67: warning: exported function IsInternalTableName should have comment or be unexported (golint)
  • Line 85: warning: exported function ExtractNamesapce should have comment or be unexported (golint)
  • Line 95: warning: exported function GetNsDesp should have comment or be unexported (golint)
  • Line 99: warning: exported function GetNamespaceAndPartition should have comment or be unexported (golint)
  • Line 113: warning: exported function DeepCopyCmd should have comment or be unexported (golint)
  • Line 124: warning: exported function IsMergeScanCommand should have comment or be unexported (golint)
  • Line 159: warning: exported function IsFullScanCommand should have comment or be unexported (golint)
  • Line 173: warning: exported function IsMergeIndexSearchCommand should have comment or be unexported (golint)
  • Line 177: warning: exported function IsMergeKeysCommand should have comment or be unexported (golint)
  • Line 182: warning: exported function IsMergeCommand should have comment or be unexported (golint)

• ZanRedisDB/snap/db.go
  • Line 29: warning: exported var ErrNoDBSnapshot should have comment or be unexported (golint)

• ZanRedisDB/common/geohash/type.go
  • Line 3: warning: exported type Range should have comment or be unexported (golint)
  • Line 8: warning: exported type Point should have comment or be unexported (golint)
  • Line 13: warning: exported type HashBits should have comment or be unexported (golint)
  • Line 18: warning: exported method HashBits.IsZero should have comment or be unexported (golint)
  • Line 22: warning: exported method HashBits.Clean should have comment or be unexported (golint)
  • Line 27: warning: exported type Neighbors should have comment or be unexported (golint)
  • Line 38: warning: exported type Area should have comment or be unexported (golint)
  • Line 44: warning: exported type Radius should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_hash_index.go
  • Line 17: warning: exported var ErrIndexExist should have comment or be unexported (golint)
  • Line 361: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 375: warning: comment on exported method RockDB.HsetIndexSearch should be of the form "HsetIndexSearch ..." (golint)
  • Line 389: warning: comment on exported type IndexCondition should be of the form "IndexCondition ..." (with optional leading article) (golint)
  • Line 401: warning: exported type HIndexResp should have comment or be unexported (golint)
  • Line 407: warning: exported type HsetIndex should have comment or be unexported (golint)
  • Line 412: warning: exported method HsetIndex.SearchRec should have comment or be unexported (golint)
  • Line 412: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 526: warning: exported method HsetIndex.UpdateRec should have comment or be unexported (golint)
  • Line 526: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 557: warning: exported method HsetIndex.RemoveRec should have comment or be unexported (golint)
  • Line 557: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 580: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• ZanRedisDB/rockredis/index_mgr.go
  • Line 13: warning: exported var ErrIndexStateInvalidChange should have comment or be unexported (golint)
  • Line 22: warning: exported type JSONIndex should have comment or be unexported (golint)
  • Line 27: warning: exported type TableIndexContainer should have comment or be unexported (golint)
  • Line 34: warning: exported function NewIndexContainer should have comment or be unexported (golint)
  • Line 41: warning: exported method TableIndexContainer.GetHIndexNoLock should have comment or be unexported (golint)
  • Line 77: warning: exported method TableIndexContainer.GetJSONIndexNoLock should have comment or be unexported (golint)
  • Line 89: warning: exported type IndexMgr should have comment or be unexported (golint)
  • Line 97: warning: exported function NewIndexMgr should have comment or be unexported (golint)
  • Line 104: warning: exported method IndexMgr.GetAllIndexSchemaInfo should have comment or be unexported (golint)
  • Line 134: warning: exported method IndexMgr.GetIndexSchemaInfo should have comment or be unexported (golint)
  • Line 165: warning: exported method IndexMgr.LoadIndexes should have comment or be unexported (golint)
  • Line 213: warning: exported method IndexMgr.Close should have comment or be unexported (golint)
  • Line 229: warning: exported method IndexMgr.AddHsetIndex should have comment or be unexported (golint)
  • Line 261: warning: exported method IndexMgr.UpdateHsetIndexState should have comment or be unexported (golint)
  • Line 349: warning: exported method IndexMgr.GetTableIndexes should have comment or be unexported (golint)
  • Line 359: warning: exported method IndexMgr.GetHsetIndex should have comment or be unexported (golint)
  • Line 470: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/pkg/testutil/testutil.go
  • Line 31: warning: exported function MustNewURLs should have comment or be unexported (golint)
  • Line 43: warning: exported function MustNewURL should have comment or be unexported (golint)

• ZanRedisDB/server/grpc_api.go
  • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 34: warning: exported method Server.GetSyncedRaft should have comment or be unexported (golint)
  • Line 47: warning: exported method Server.ApplyRaftReqs should have comment or be unexported (golint)
  • Line 87: warning: exported method Server.NotifyTransferSnap should have comment or be unexported (golint)
  • Line 105: warning: exported method Server.NotifyApplySnap should have comment or be unexported (golint)
  • Line 131: warning: exported method Server.GetApplySnapStatus should have comment or be unexported (golint)

• ZanRedisDB/server/merge.go
  • Line 209: warning: exported method Server.GetMergeHandlers should have comment or be unexported (golint)

• ZanRedisDB/raft/raft_test.go
  • Line 2061: warning: don't use underscores in Go names; struct field compact_index should be compactIndex (golint)

• ZanRedisDB/rockredis/const.go
  • Line 8: warning: exported const EngType should have comment (or a comment on this block) or be unexported (golint)
  • Line 11: warning: exported type ErrType should have comment or be unexported (golint)
  • Line 14: warning: exported const NotFound should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: exported var TypeName should have comment or be unexported (golint)
  • Line 81: warning: exported const MAX_BATCH_NUM should have comment (or a comment on this block) or be unexported (golint)
  • Line 96: warning: exported const MaxDatabases should have comment (or a comment on this block) or be unexported (golint)
  • Line 100: warning: comment on exported const MaxKeySize should be of the form "MaxKeySize ..." (golint)
  • Line 103: warning: comment on exported const MaxHashFieldSize should be of the form "MaxHashFieldSize ..." (golint)
  • Line 106: warning: comment on exported const MaxZSetMemberSize should be of the form "MaxZSetMemberSize ..." (golint)
  • Line 109: warning: comment on exported const MaxSetMemberSize should be of the form "MaxSetMemberSize ..." (golint)
  • Line 112: warning: comment on exported const MaxValueSize should be of the form "MaxValueSize ..." (golint)
  • Line 117: warning: exported var ErrZScoreMiss should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_ttl_c_test.go
  • Line 107: warning: don't use underscores in Go names; var hash_val should be hashVal (golint)

• ZanRedisDB/wal/walpb/record.go
  • Line 20: warning: exported var ErrCRCMismatch should have comment or be unexported (golint)
  • Line 23: warning: exported method Record.Validate should have comment or be unexported (golint)

• ZanRedisDB/cluster/datanode_coord/data_learner_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/raft/logger.go
  • Line 24: warning: exported type Logger should have comment or be unexported (golint)
  • Line 44: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 62: warning: exported method DefaultLogger.EnableTimestamps should have comment or be unexported (golint)
  • Line 66: warning: exported method DefaultLogger.EnableDebug should have comment or be unexported (golint)
  • Line 70: warning: exported method DefaultLogger.Debug should have comment or be unexported (golint)
  • Line 76: warning: exported method DefaultLogger.Debugf should have comment or be unexported (golint)
  • Line 82: warning: exported method DefaultLogger.Info should have comment or be unexported (golint)
  • Line 86: warning: exported method DefaultLogger.Infof should have comment or be unexported (golint)
  • Line 94: warning: exported method DefaultLogger.Errorf should have comment or be unexported (golint)
  • Line 98: warning: exported method DefaultLogger.Warning should have comment or be unexported (golint)
  • Line 102: warning: exported method DefaultLogger.Warningf should have comment or be unexported (golint)
  • Line 106: warning: exported method DefaultLogger.Fatal should have comment or be unexported (golint)
  • Line 111: warning: exported method DefaultLogger.Fatalf should have comment or be unexported (golint)
  • Line 116: warning: exported method DefaultLogger.Panic should have comment or be unexported (golint)
  • Line 120: warning: exported method DefaultLogger.Panicf should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_kv.go
  • Line 98: warning: comment on exported method RockDB.KVDel should be of the form "KVDel ..." (golint)
  • Line 131: warning: exported method RockDB.KVDelWithBatch should have comment or be unexported (golint)
  • Line 150: warning: exported method RockDB.Decr should have comment or be unexported (golint)
  • Line 154: warning: exported method RockDB.DecrBy should have comment or be unexported (golint)
  • Line 158: warning: exported method RockDB.DelKeys should have comment or be unexported (golint)
  • Line 181: warning: exported method RockDB.KVExists should have comment or be unexported (golint)
  • Line 203: warning: exported method RockDB.KVGetVer should have comment or be unexported (golint)
  • Line 216: warning: exported method RockDB.KVGet should have comment or be unexported (golint)
  • Line 229: warning: exported method RockDB.Incr should have comment or be unexported (golint)
  • Line 233: warning: exported method RockDB.IncrBy should have comment or be unexported (golint)
  • Line 237: warning: exported method RockDB.MGet should have comment or be unexported (golint)
  • Line 259: warning: exported method RockDB.MSet should have comment or be unexported (golint)
  • Line 309: warning: exported method RockDB.KVSet should have comment or be unexported (golint)
  • Line 336: warning: exported method RockDB.SetEx should have comment or be unexported (golint)
  • Line 367: warning: exported method RockDB.SetNX should have comment or be unexported (golint)
  • Line 392: warning: exported method RockDB.SetRange should have comment or be unexported (golint)
  • Line 456: warning: exported method RockDB.GetRange should have comment or be unexported (golint)
  • Line 472: warning: exported method RockDB.StrLen should have comment or be unexported (golint)
  • Line 482: warning: exported method RockDB.Append should have comment or be unexported (golint)
  • Line 521: warning: exported method RockDB.Expire should have comment or be unexported (golint)
  • Line 524: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 527: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 533: warning: exported method RockDB.Persist should have comment or be unexported (golint)
  • Line 545: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 548: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/rockredis/fullscan.go
  • Line 12: warning: exported type ItemContainer should have comment or be unexported (golint)
  • Line 50: warning: exported method RockDB.FullScan should have comment or be unexported (golint)
  • Line 310: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/rockredis/util.go
  • Line 15: warning: exported function Int64 should have comment or be unexported (golint)
  • Line 20: warning: exported function Uint64 should have comment or be unexported (golint)
  • Line 32: warning: exported function FormatInt64ToSlice should have comment or be unexported (golint)
  • Line 36: warning: exported function PutInt64 should have comment or be unexported (golint)
  • Line 42: warning: exported function PutFloat64 should have comment or be unexported (golint)
  • Line 49: warning: exported function Float64 should have comment or be unexported (golint)
  • Line 62: warning: exported function StrInt64 should have comment or be unexported (golint)
  • Line 72: warning: exported function StrUint64 should have comment or be unexported (golint)
  • Line 82: warning: exported function StrInt32 should have comment or be unexported (golint)
  • Line 93: warning: exported function StrInt8 should have comment or be unexported (golint)
  • Line 104: warning: exported function MinUint should have comment or be unexported (golint)
  • Line 107: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 112: warning: exported function MaxUint should have comment or be unexported (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 120: warning: exported function MinInt should have comment or be unexported (golint)
  • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 128: warning: exported function MaxInt should have comment or be unexported (golint)
  • Line 131: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 136: warning: exported function MinUint8 should have comment or be unexported (golint)
  • Line 139: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 144: warning: exported function MaxUint8 should have comment or be unexported (golint)
  • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 152: warning: exported function MinInt8 should have comment or be unexported (golint)
  • Line 155: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 160: warning: exported function MaxInt8 should have comment or be unexported (golint)
  • Line 163: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 168: warning: exported function MinUint16 should have comment or be unexported (golint)
  • Line 171: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 176: warning: exported function MaxUint16 should have comment or be unexported (golint)
  • Line 179: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 184: warning: exported function MinInt16 should have comment or be unexported (golint)
  • Line 187: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 192: warning: exported function MaxInt16 should have comment or be unexported (golint)
  • Line 195: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 200: warning: exported function MinUint32 should have comment or be unexported (golint)
  • Line 203: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 208: warning: exported function MaxUint32 should have comment or be unexported (golint)
  • Line 211: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 216: warning: exported function MinInt32 should have comment or be unexported (golint)
  • Line 219: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 224: warning: exported function MaxInt32 should have comment or be unexported (golint)
  • Line 227: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 232: warning: exported function MinUint64 should have comment or be unexported (golint)
  • Line 235: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 240: warning: exported function MaxUint64 should have comment or be unexported (golint)
  • Line 243: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 248: warning: exported function MinInt64 should have comment or be unexported (golint)
  • Line 251: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 256: warning: exported function MaxInt64 should have comment or be unexported (golint)
  • Line 259: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/raft/status.go
  • Line 23: warning: exported type Status should have comment or be unexported (golint)

• ZanRedisDB/node/raft.go
  • Line 44: warning: exported const DefaultSnapCount should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported type Snapshot should have comment or be unexported (golint)
  • Line 61: warning: exported type IRaftPersistStorage should have comment or be unexported (golint)
  • Line 72: warning: exported type DataStorage should have comment or be unexported (golint)
  • Line 218: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 717: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 980: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 983: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 986: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• ZanRedisDB/pkg/transport/transport.go
  • Line 26: warning: exported function NewTransport should have comment or be unexported (golint)

• ZanRedisDB/raft/read_only.go
  • Line 31: warning: exported type ReadState should have comment or be unexported (golint)

• ZanRedisDB/raft/util.go
  • Line 24: warning: exported method StateType.MarshalJSON should have comment or be unexported (golint)
  • Line 49: warning: exported function IsLocalMsg should have comment or be unexported (golint)
  • Line 54: warning: exported function IsResponseMsg should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_json.go
  • Line 101: warning: exported method RockDB.JSet should have comment or be unexported (golint)
  • Line 153: warning: exported method RockDB.JMset should have comment or be unexported (golint)
  • Line 206: warning: exported method RockDB.JMGet should have comment or be unexported (golint)
  • Line 210: warning: exported method RockDB.JType should have comment or be unexported (golint)
  • Line 236: warning: exported method RockDB.JGet should have comment or be unexported (golint)
  • Line 260: warning: exported method RockDB.JDel should have comment or be unexported (golint)
  • Line 302: warning: exported method RockDB.JKeyExists should have comment or be unexported (golint)
  • Line 315: warning: exported method RockDB.JArrayAppend should have comment or be unexported (golint)
  • Line 368: warning: exported method RockDB.JArrayPop should have comment or be unexported (golint)
  • Line 421: warning: exported method RockDB.JArrayLen should have comment or be unexported (golint)
  • Line 447: warning: exported method RockDB.JObjLen should have comment or be unexported (golint)
  • Line 473: warning: exported method RockDB.JObjKeys should have comment or be unexported (golint)

gocyclo78%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• ZanRedisDB/server/redis_api_fullscan_test.go
  • Line 770: warning: cyclomatic complexity 47 of function checkListFullScan() is high (> 15) (gocyclo)
  • Line 923: warning: cyclomatic complexity 47 of function checkSetFullScan() is high (> 15) (gocyclo)
  • Line 1076: warning: cyclomatic complexity 47 of function checkZSetFullScan() is high (> 15) (gocyclo)
  • Line 375: warning: cyclomatic complexity 46 of function checkHashFullScan() is high (> 15) (gocyclo)
  • Line 287: warning: cyclomatic complexity 25 of function checkKVFullScan() is high (> 15) (gocyclo)

• ZanRedisDB/node/geo_test.go
  • Line 37: warning: cyclomatic complexity 29 of function TestKVNode_GeoCommand() is high (> 15) (gocyclo)

• ZanRedisDB/node/scan.go
  • Line 109: warning: cyclomatic complexity 22 of function (*KVNode).advanceScanCommand() is high (> 15) (gocyclo)

• ZanRedisDB/node/syncer_learner.go
  • Line 197: warning: cyclomatic complexity 22 of function (*logSyncerSM).handlerRaftLogs() is high (> 15) (gocyclo)
  • Line 455: warning: cyclomatic complexity 20 of function (*logSyncerSM).ApplyRaftRequest() is high (> 15) (gocyclo)
  • Line 348: warning: cyclomatic complexity 17 of function (*logSyncerSM).RestoreFromSnapshot() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hash_test.go
  • Line 37: warning: cyclomatic complexity 28 of function TestDBHash() is high (> 15) (gocyclo)
  • Line 416: warning: cyclomatic complexity 19 of function TestHashIndexStringV() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/index_mgr.go
  • Line 389: warning: cyclomatic complexity 22 of function (*IndexMgr).dobuildIndexes() is high (> 15) (gocyclo)

• ZanRedisDB/server/util.go
  • Line 169: warning: cyclomatic complexity 73 of function qcmdlower() is high (> 15) (gocyclo)
  • Line 106: warning: cyclomatic complexity 18 of function parseCommand() is high (> 15) (gocyclo)

• ZanRedisDB/server/merge.go
  • Line 74: warning: cyclomatic complexity 20 of function (*Server).getHandlersForKeys() is high (> 15) (gocyclo)

• ZanRedisDB/node/node.go
  • Line 369: warning: cyclomatic complexity 28 of function (*KVNode).handleProposeReq() is high (> 15) (gocyclo)
  • Line 935: warning: cyclomatic complexity 20 of function (*KVNode).applyAll() is high (> 15) (gocyclo)
  • Line 497: warning: cyclomatic complexity 20 of function (*KVNode).ProposeRawAndWait() is high (> 15) (gocyclo)
  • Line 783: warning: cyclomatic complexity 18 of function (*KVNode).IsRaftSynced() is high (> 15) (gocyclo)
  • Line 579: warning: cyclomatic complexity 16 of function (*KVNode).queueRequest() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_list.go
  • Line 341: warning: cyclomatic complexity 19 of function (*RockDB).ltrim2() is high (> 15) (gocyclo)
  • Line 187: warning: cyclomatic complexity 17 of function (*RockDB).lpush() is high (> 15) (gocyclo)
  • Line 689: warning: cyclomatic complexity 16 of function (*RockDB).LRange() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_set_test.go
  • Line 86: warning: cyclomatic complexity 16 of function TestDBSet() is high (> 15) (gocyclo)

• ZanRedisDB/transport/rafthttp/msgappv2_codec.go
  • Line 190: warning: cyclomatic complexity 18 of function (*msgAppV2Decoder).decode() is high (> 15) (gocyclo)
  • Line 97: warning: cyclomatic complexity 18 of function (*msgAppV2Encoder).encode() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/pd_coordinator.go
  • Line 620: warning: cyclomatic complexity 52 of function (*PDCoordinator).doCheckNamespaces() is high (> 15) (gocyclo)
  • Line 458: warning: cyclomatic complexity 28 of function (*PDCoordinator).handleRemovingNodes() is high (> 15) (gocyclo)
  • Line 819: warning: cyclomatic complexity 20 of function (*PDCoordinator).handleNamespaceMigrate() is high (> 15) (gocyclo)
  • Line 381: warning: cyclomatic complexity 18 of function (*PDCoordinator).handleDataNodes() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hash.go
  • Line 232: warning: cyclomatic complexity 18 of function (*RockDB).HMset() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/datanode_coord/data_learner_coord.go
  • Line 82: warning: cyclomatic complexity 21 of function (*DataCoordinator).ensureJoinNamespaceGroupForLearner() is high (> 15) (gocyclo)
  • Line 13: warning: cyclomatic complexity 18 of function (*DataCoordinator).loadLocalNamespaceForLearners() is high (> 15) (gocyclo)

• ZanRedisDB/wal/wal.go
  • Line 305: warning: cyclomatic complexity 26 of function (*WAL).ReadAll() is high (> 15) (gocyclo)
  • Line 94: warning: cyclomatic complexity 16 of function Create() is high (> 15) (gocyclo)
  • Line 412: warning: cyclomatic complexity 16 of function (*WAL).cut() is high (> 15) (gocyclo)

• ZanRedisDB/server/server.go
  • Line 59: warning: cyclomatic complexity 21 of function NewServer() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_zset_test.go
  • Line 186: warning: cyclomatic complexity 27 of function TestZSetOrder() is high (> 15) (gocyclo)
  • Line 122: warning: cyclomatic complexity 18 of function TestDBZSet() is high (> 15) (gocyclo)
  • Line 66: warning: cyclomatic complexity 17 of function TestDBZSetWithEmptyMember() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_ttl_l_test.go
  • Line 227: warning: cyclomatic complexity 24 of function TestLocalDeletionTTLChecker() is high (> 15) (gocyclo)

• ZanRedisDB/pkg/testutil/leak.go
  • Line 111: warning: cyclomatic complexity 16 of function interestingGoroutines() is high (> 15) (gocyclo)

• ZanRedisDB/node/state_machine.go
  • Line 391: warning: cyclomatic complexity 40 of function (*kvStoreSM).ApplyRaftRequest() is high (> 15) (gocyclo)
  • Line 557: warning: cyclomatic complexity 18 of function (*kvStoreSM).handleCustomRequest() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/fullscan.go
  • Line 181: warning: cyclomatic complexity 22 of function (*RockDB).fullScanCommon() is high (> 15) (gocyclo)

• ZanRedisDB/wal/repair_test.go
  • Line 44: warning: cyclomatic complexity 19 of function testRepair() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/rockredis_test.go
  • Line 489: warning: cyclomatic complexity 21 of function TestRockDBScanTableForZSet() is high (> 15) (gocyclo)
  • Line 358: warning: cyclomatic complexity 21 of function TestRockDBScanTableForSet() is high (> 15) (gocyclo)
  • Line 109: warning: cyclomatic complexity 17 of function TestRockDBScanTableForHash() is high (> 15) (gocyclo)

• ZanRedisDB/common/util.go
  • Line 124: warning: cyclomatic complexity 42 of function IsMergeScanCommand() is high (> 15) (gocyclo)
  • Line 159: warning: cyclomatic complexity 17 of function IsFullScanCommand() is high (> 15) (gocyclo)

• ZanRedisDB/server/secondary_index_merge.go
  • Line 17: warning: cyclomatic complexity 26 of function (*Server).doMergeIndexSearch() is high (> 15) (gocyclo)

• ZanRedisDB/pdserver/server_test.go
  • Line 355: warning: cyclomatic complexity 18 of function TestAddRemoteClusterLogSyncLearner() is high (> 15) (gocyclo)

• ZanRedisDB/node/secondary_index.go
  • Line 100: warning: cyclomatic complexity 33 of function (*KVNode).hindexSearchCommand() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/pd_learner_coord.go
  • Line 31: warning: cyclomatic complexity 20 of function (*PDCoordinator).doCheckNamespacesForLearner() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hll.go
  • Line 170: warning: cyclomatic complexity 27 of function (*RockDB).PFCount() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_ttl_c_test.go
  • Line 15: warning: cyclomatic complexity 19 of function TestKVTTL_C() is high (> 15) (gocyclo)
  • Line 81: warning: cyclomatic complexity 16 of function TestHashTTL_C() is high (> 15) (gocyclo)
  • Line 254: warning: cyclomatic complexity 16 of function TestZSetTTL_C() is high (> 15) (gocyclo)
  • Line 198: warning: cyclomatic complexity 16 of function TestSetTTL_C() is high (> 15) (gocyclo)
  • Line 142: warning: cyclomatic complexity 16 of function TestListTTL_C() is high (> 15) (gocyclo)

• ZanRedisDB/apps/backup/main.go
  • Line 433: warning: cyclomatic complexity 21 of function backup() is high (> 15) (gocyclo)

• ZanRedisDB/pkg/types/set_test.go
  • Line 40: warning: cyclomatic complexity 19 of function driveSetTests() is high (> 15) (gocyclo)

• ZanRedisDB/pdserver/http.go
  • Line 352: warning: cyclomatic complexity 18 of function (*Server).doCreateNamespace() is high (> 15) (gocyclo)

• ZanRedisDB/raft/node.go
  • Line 290: warning: cyclomatic complexity 50 of function (*node).run() is high (> 15) (gocyclo)

• ZanRedisDB/raft/raft_test.go
  • Line 569: warning: cyclomatic complexity 18 of function testVoteFromAnyState() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_list_test.go
  • Line 41: warning: cyclomatic complexity 22 of function TestListTrim() is high (> 15) (gocyclo)
  • Line 205: warning: cyclomatic complexity 16 of function TestListPop() is high (> 15) (gocyclo)
  • Line 132: warning: cyclomatic complexity 16 of function TestDBList() is high (> 15) (gocyclo)

• ZanRedisDB/tools/bench/main.go
  • Line 461: warning: cyclomatic complexity 23 of function main() is high (> 15) (gocyclo)

• ZanRedisDB/transport/rafthttp/stream.go
  • Line 427: warning: cyclomatic complexity 16 of function (*streamReader).dial() is high (> 15) (gocyclo)
  • Line 346: warning: cyclomatic complexity 16 of function (*streamReader).decodeLoop() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api_test.go
  • Line 335: warning: cyclomatic complexity 48 of function TestKVBatch() is high (> 15) (gocyclo)
  • Line 1698: warning: cyclomatic complexity 41 of function TestZSetFloat64Score() is high (> 15) (gocyclo)
  • Line 1427: warning: cyclomatic complexity 32 of function TestSet() is high (> 15) (gocyclo)
  • Line 1583: warning: cyclomatic complexity 31 of function TestZSet() is high (> 15) (gocyclo)
  • Line 2172: warning: cyclomatic complexity 31 of function TestZsetErrorParams() is high (> 15) (gocyclo)
  • Line 2059: warning: cyclomatic complexity 30 of function TestZSetRange() is high (> 15) (gocyclo)
  • Line 123: warning: cyclomatic complexity 30 of function TestKV() is high (> 15) (gocyclo)
  • Line 965: warning: cyclomatic complexity 29 of function TestList() is high (> 15) (gocyclo)
  • Line 1965: warning: cyclomatic complexity 24 of function TestZSetRangeScore() is high (> 15) (gocyclo)
  • Line 1208: warning: cyclomatic complexity 21 of function disableTestTrim() is high (> 15) (gocyclo)
  • Line 1145: warning: cyclomatic complexity 19 of function TestPop() is high (> 15) (gocyclo)
  • Line 1821: warning: cyclomatic complexity 18 of function TestZSetCount() is high (> 15) (gocyclo)
  • Line 638: warning: cyclomatic complexity 17 of function TestHash() is high (> 15) (gocyclo)
  • Line 853: warning: cyclomatic complexity 16 of function TestHashErrorParams() is high (> 15) (gocyclo)
  • Line 257: warning: cyclomatic complexity 16 of function TestKVM() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api.go
  • Line 20: warning: cyclomatic complexity 28 of function (*Server).serverRedis() is high (> 15) (gocyclo)

• ZanRedisDB/server/scan_merge.go
  • Line 103: warning: cyclomatic complexity 26 of function (*Server).doMergeFullScan() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/rockredis.go
  • Line 73: warning: cyclomatic complexity 20 of function FillDefaultOptions() is high (> 15) (gocyclo)
  • Line 959: warning: cyclomatic complexity 19 of function (*RockDB).Restore() is high (> 15) (gocyclo)
  • Line 285: warning: cyclomatic complexity 18 of function OpenRockDB() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_ttl.go
  • Line 163: warning: cyclomatic complexity 17 of function (*TTLChecker).check() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/pd_schema_coord.go
  • Line 57: warning: cyclomatic complexity 23 of function (*PDCoordinator).doSchemaCheck() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/register_etcd.go
  • Line 1151: warning: cyclomatic complexity 24 of function (*DNEtcdRegister).WatchPDLeader() is high (> 15) (gocyclo)
  • Line 363: warning: cyclomatic complexity 17 of function (*EtcdRegister).processNamespaceNode() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/place_driver.go
  • Line 374: warning: cyclomatic complexity 37 of function (*DataPlacement).rebalanceNamespace() is high (> 15) (gocyclo)
  • Line 218: warning: cyclomatic complexity 17 of function (*DataPlacement).addNodeToNamespaceAndWaitReady() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api_merge_test.go
  • Line 167: warning: cyclomatic complexity 34 of function checkMergeAdvanceScan() is high (> 15) (gocyclo)

• ZanRedisDB/apps/restore/main.go
  • Line 211: warning: cyclomatic complexity 28 of function restore() is high (> 15) (gocyclo)

• ZanRedisDB/wal/wal_test.go
  • Line 716: warning: cyclomatic complexity 18 of function TestOpenOnTornWrite() is high (> 15) (gocyclo)
  • Line 394: warning: cyclomatic complexity 16 of function TestRecoverAfterCut() is high (> 15) (gocyclo)

• ZanRedisDB/node/geo.go
  • Line 202: warning: cyclomatic complexity 36 of function (*KVNode).geoRadiusGeneric() is high (> 15) (gocyclo)

• ZanRedisDB/raft/raft.go
  • Line 962: warning: cyclomatic complexity 53 of function stepLeader() is high (> 15) (gocyclo)
  • Line 821: warning: cyclomatic complexity 39 of function (*raft).Step() is high (> 15) (gocyclo)
  • Line 302: warning: cyclomatic complexity 21 of function newRaft() is high (> 15) (gocyclo)
  • Line 1214: warning: cyclomatic complexity 18 of function stepFollower() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/iterator.go
  • Line 288: warning: cyclomatic complexity 17 of function rangeLimitIterator() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/datanode_coord/dn_schema_coord.go
  • Line 12: warning: cyclomatic complexity 23 of function (*DataCoordinator).doSyncSchemaInfo() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/place_driver_test.go
  • Line 10: warning: cyclomatic complexity 21 of function TestClusterNodesPlacementAcrossDC() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/datanode_coord/data_node_coordinator.go
  • Line 601: warning: cyclomatic complexity 60 of function (*DataCoordinator).checkForUnsyncedNamespaces() is high (> 15) (gocyclo)
  • Line 985: warning: cyclomatic complexity 27 of function (*DataCoordinator).ensureJoinNamespaceGroup() is high (> 15) (gocyclo)
  • Line 230: warning: cyclomatic complexity 20 of function (*DataCoordinator).loadLocalNamespaceData() is high (> 15) (gocyclo)
  • Line 1101: warning: cyclomatic complexity 16 of function (*DataCoordinator).updateLocalNamespace() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_kv_test.go
  • Line 25: warning: cyclomatic complexity 47 of function TestDBKV() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hash_index.go
  • Line 412: warning: cyclomatic complexity 38 of function (*HsetIndex).SearchRec() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_zset.go
  • Line 719: warning: cyclomatic complexity 21 of function (*RockDB).zRangeBytes() is high (> 15) (gocyclo)
  • Line 1041: warning: cyclomatic complexity 17 of function (*RockDB).ZRemRangeByLex() is high (> 15) (gocyclo)

• ZanRedisDB/node/log_sender.go
  • Line 304: warning: cyclomatic complexity 19 of function (*RemoteLogSender).waitApplySnapStatus() is high (> 15) (gocyclo)

• ZanRedisDB/node/raft.go
  • Line 799: warning: cyclomatic complexity 35 of function (*raftNode).serveChannels() is high (> 15) (gocyclo)
  • Line 703: warning: cyclomatic complexity 21 of function (*raftNode).applyConfChange() is high (> 15) (gocyclo)

• ZanRedisDB/pkg/fileutil/purge_test.go
  • Line 93: warning: cyclomatic complexity 22 of function TestPurgeFileHoldingLockFile() is high (> 15) (gocyclo)
  • Line 27: warning: cyclomatic complexity 16 of function TestPurgeFile() is high (> 15) (gocyclo)

ineffassign94%

IneffAssign detects ineffectual assignments in Go code.

• ZanRedisDB/rockredis/t_set.go
  • Line 128: warning: ineffectual assignment to err (ineffassign)
  • Line 402: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/apps/backup/main.go
  • Line 569: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_hash.go
  • Line 386: warning: ineffectual assignment to newNum (ineffassign)
  • Line 393: warning: ineffectual assignment to err (ineffassign)
  • Line 470: warning: ineffectual assignment to err (ineffassign)
  • Line 510: warning: ineffectual assignment to err (ineffassign)
  • Line 640: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/node/state_machine.go
  • Line 625: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/pdserver/http.go
  • Line 247: warning: ineffectual assignment to stable (ineffassign)

• ZanRedisDB/node/node.go
  • Line 550: warning: ineffectual assignment to rsp (ineffassign)

• ZanRedisDB/rockredis/t_kv_test.go
  • Line 211: warning: ineffectual assignment to v2 (ineffassign)

• ZanRedisDB/rockredis/t_hash_test.go
  • Line 588: warning: ineffectual assignment to pkList (ineffassign)
  • Line 787: warning: ineffectual assignment to pkList (ineffassign)
  • Line 900: warning: ineffectual assignment to err (ineffassign)
  • Line 923: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_json.go
  • Line 179: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_hll.go
  • Line 297: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_json_test.go
  • Line 47: warning: ineffectual assignment to err (ineffassign)
  • Line 148: warning: ineffectual assignment to n (ineffassign)
  • Line 339: warning: ineffectual assignment to poped (ineffassign)

• ZanRedisDB/rockredis/t_list_test.go
  • Line 303: warning: ineffectual assignment to err (ineffassign)
  • Line 304: warning: ineffectual assignment to err (ineffassign)
  • Line 305: warning: ineffectual assignment to err (ineffassign)
  • Line 313: warning: ineffectual assignment to err (ineffassign)
  • Line 317: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_table.go
  • Line 149: warning: ineffectual assignment to bufLen (ineffassign)
  • Line 152: warning: ineffectual assignment to bufLen (ineffassign)

• ZanRedisDB/pdserver/http_test.go
  • Line 390: warning: ineffectual assignment to uri (ineffassign)

• ZanRedisDB/rockredis/rockredis.go
  • Line 502: warning: ineffectual assignment to err (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell99%

Misspell Finds commonly misspelled English words

• ZanRedisDB/cluster/datanode_coord/data_node_coordinator.go
  • Line 26: warning: "transfering" is a misspelling of "transferring" (misspell)

• ZanRedisDB/common/util.go
  • Line 22: warning: "allready" is a misspelling of "already" (misspell)