Report for github.com/ajankovic/smpp
A+ Excellent! Found 10 issues across 27 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo74%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
smpp/session.go
- Line 549: warning: cyclomatic complexity 49 of function toError() is high (> 15) (gocyclo)
- Line 427: warning: cyclomatic complexity 44 of function (*Session).makeTransition() is high (> 15) (gocyclo)
- Line 345: warning: cyclomatic complexity 16 of function (*Session).setState() is high (> 15) (gocyclo)
-
-
smpp/server_test.go
- Line 17: warning: cyclomatic complexity 16 of function TestSMPPServer() is high (> 15) (gocyclo)
-
-
smpp/pdu/pdu.go
- Line 346: warning: cyclomatic complexity 28 of function NewPDU() is high (> 15) (gocyclo)
-
-
smpp/pdu/deliver_sm.go
- Line 85: warning: cyclomatic complexity 25 of function (*DeliverSm).UnmarshalBinary() is high (> 15) (gocyclo)
-
-
smpp/pdu/submit_sm.go
- Line 85: warning: cyclomatic complexity 24 of function (*SubmitSm).UnmarshalBinary() is high (> 15) (gocyclo)
-
-
smpp/pdu/receipt.go
- Line 62: warning: cyclomatic complexity 24 of function ParseDeliveryReceipt() is high (> 15) (gocyclo)
-
-
smpp/internal/mock/connection.go
- Line 69: warning: cyclomatic complexity 19 of function (*Conn).read() is high (> 15) (gocyclo)
- Line 143: warning: cyclomatic complexity 18 of function (*Conn).write() is high (> 15) (gocyclo)
golint88%
Golint is a linter for Go source code.
-
-
smpp/pdu/notsupportedyet.go
- Line 11: warning: exported method ReplaceSm.CommandID should have comment or be unexported (golint)
- Line 15: warning: exported method ReplaceSm.MarshalBinary should have comment or be unexported (golint)
- Line 19: warning: exported method ReplaceSm.UnmarshalBinary should have comment or be unexported (golint)
- Line 27: warning: exported method ReplaceSmResp.CommandID should have comment or be unexported (golint)
- Line 31: warning: exported method ReplaceSmResp.MarshalBinary should have comment or be unexported (golint)
- Line 35: warning: exported method ReplaceSmResp.UnmarshalBinary should have comment or be unexported (golint)
- Line 43: warning: exported method CancelSm.CommandID should have comment or be unexported (golint)
- Line 47: warning: exported method CancelSm.MarshalBinary should have comment or be unexported (golint)
- Line 51: warning: exported method CancelSm.UnmarshalBinary should have comment or be unexported (golint)
- Line 59: warning: exported method CancelSmResp.CommandID should have comment or be unexported (golint)
- Line 63: warning: exported method CancelSmResp.MarshalBinary should have comment or be unexported (golint)
- Line 67: warning: exported method CancelSmResp.UnmarshalBinary should have comment or be unexported (golint)
- Line 75: warning: exported method Outbind.CommandID should have comment or be unexported (golint)
- Line 79: warning: exported method Outbind.MarshalBinary should have comment or be unexported (golint)
- Line 83: warning: exported method Outbind.UnmarshalBinary should have comment or be unexported (golint)
- Line 91: warning: exported method SubmitMulti.CommandID should have comment or be unexported (golint)
- Line 95: warning: exported method SubmitMulti.MarshalBinary should have comment or be unexported (golint)
- Line 99: warning: exported method SubmitMulti.UnmarshalBinary should have comment or be unexported (golint)
- Line 107: warning: exported method SubmitMultiResp.CommandID should have comment or be unexported (golint)
- Line 111: warning: exported method SubmitMultiResp.MarshalBinary should have comment or be unexported (golint)
- Line 115: warning: exported method SubmitMultiResp.UnmarshalBinary should have comment or be unexported (golint)
- Line 123: warning: exported method AlertNotification.CommandID should have comment or be unexported (golint)
- Line 127: warning: exported method AlertNotification.MarshalBinary should have comment or be unexported (golint)
- Line 131: warning: exported method AlertNotification.UnmarshalBinary should have comment or be unexported (golint)
- Line 139: warning: exported method DataSm.CommandID should have comment or be unexported (golint)
- Line 143: warning: exported method DataSm.MarshalBinary should have comment or be unexported (golint)
- Line 147: warning: exported method DataSm.UnmarshalBinary should have comment or be unexported (golint)
- Line 155: warning: exported method DataSmResp.CommandID should have comment or be unexported (golint)
- Line 159: warning: exported method DataSmResp.MarshalBinary should have comment or be unexported (golint)
- Line 163: warning: exported method DataSmResp.UnmarshalBinary should have comment or be unexported (golint)
-
-
smpp/pdu/pdu.go
- Line 48: warning: exported const DefaultEsmMode should have comment (or a comment on this block) or be unexported (golint)
- Line 56: warning: exported const DefaultEsmType should have comment (or a comment on this block) or be unexported (golint)
- Line 65: warning: exported const NoEsmFeat should have comment (or a comment on this block) or be unexported (golint)
- Line 98: warning: exported const NoDeliveryReceipt should have comment (or a comment on this block) or be unexported (golint)
- Line 104: warning: exported const NoSMEAck should have comment (or a comment on this block) or be unexported (golint)
- Line 111: warning: exported const NoInterNotification should have comment (or a comment on this block) or be unexported (golint)
- Line 284: warning: exported type EncoderOption should have comment or be unexported (golint)
- Line 286: warning: exported function EncodeSeq should have comment or be unexported (golint)
- Line 292: warning: exported function EncodeStatus should have comment or be unexported (golint)
-
-
smpp/pdu/receipt.go
- Line 24: warning: exported type DelStat should have comment or be unexported (golint)
- Line 27: warning: exported const DelStatEnRoute should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: exported var DelStatMap should have comment or be unexported (golint)
ineffassign96%
IneffAssign detects ineffectual assignments in Go code.
-
-
smpp/internal/mock/connection_test.go
- Line 72: warning: ineffectual assignment to n (ineffassign)
- Line 76: warning: ineffectual assignment to n (ineffassign)
misspell96%
Misspell Finds commonly misspelled English words
-
-
smpp/examples/client/main.go
- Line 23: warning: "comming" is a misspelling of "coming" (misspell)