gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• sofa-mosn/pkg/xds/v2/rds/routerconfignames.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/router/routers_impl_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/configmanager/featuregate_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/cases/route/route_extend_handler_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/cases/simple/variable_router_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/util/config.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/module/http2/h2c/h2c_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/stream/connpool/msgconnpool/connpool.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/wasm/abi/proxywasm010/imports_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/cases/fallback/fallback_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/cases/simple/http1_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/upstream/cluster/cluster_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/configmanager/parser_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/networkextention/discovery/fsdis/fsdis.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/integrate/filter/perfilterconfig_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/integrate/functiontest/faultinject_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/integrate/tls_extend_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/server/adapter_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/integrate/functiontest/direct_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/config/v2/json_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/upstream/cluster/subset_loadbalancer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/variable/protocolres_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/upstream/healthcheck/healthchecker_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/config/v2/config_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/filter/stream/jwtauthn/filter.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/integrate/xds_config_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/filter/stream/dubbo/dubbo.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/upstream/cluster/cluster_adapter_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/module/http2/mhttp2.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/cases/streamfilter/pluginfilter/http_headers_route_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/lib/http/client.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/router/utility_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/integrate/tcpproxy_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/lib/http/http_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/router/headerparser_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/xds/conv/update_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/log/accesslog_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/upstream/cluster/cluster_healthcheck_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/upstream/cluster/strict_dns_cluster_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/lib/http/config.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/util/genconfig.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/xds/conv/convertxds.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/configmanager/dump_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/metrics/store_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/xds/conv/convertxds_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_server_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/network/idlechecker_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/lib/http/server.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/router/base_rule_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/admin/server/server_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/istio/utils/utils_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/log/accesslog.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/filter/stream/faultinject/faultinject_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/filter/stream/gzip/gzip.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/cel/extract/attributes_builder.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/filter/stream/gzip/gzip_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/upstream/cluster/benchmark_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/mosn/mosn.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/network/listener_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/pkg/wasm/abi/proxywasm010/imports.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/cases/route/http_headers_route_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• sofa-mosn/test/lib/xprotocol/boltv1/server.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• sofa-mosn/pkg/module/http2/gotrack.go
  • Line 78: warning: cyclomatic complexity 26 of function parseUintBytes() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/mhttp2.go
  • Line 573: warning: cyclomatic complexity 24 of function (*MServerConn).processRequest() is high (> 15) (gocyclo)
  • Line 748: warning: cyclomatic complexity 20 of function (*MServerConn).processData() is high (> 15) (gocyclo)
  • Line 1451: warning: cyclomatic complexity 18 of function (*MClientConn).processData() is high (> 15) (gocyclo)
  • Line 406: warning: cyclomatic complexity 17 of function (*MServerConn).HandleFrame() is high (> 15) (gocyclo)
  • Line 1301: warning: cyclomatic complexity 16 of function (*MClientConn).HandleFrame() is high (> 15) (gocyclo)
  • Line 1130: warning: cyclomatic complexity 16 of function (*MClientStream).writeDataAndTrailer() is high (> 15) (gocyclo)

• sofa-mosn/pkg/admin/server/apis.go
  • Line 66: warning: cyclomatic complexity 20 of function configDump() is high (> 15) (gocyclo)

• sofa-mosn/pkg/protocol/xprotocol/dubbo/decoder.go
  • Line 110: warning: cyclomatic complexity 33 of function getServiceAwareMeta() is high (> 15) (gocyclo)

• sofa-mosn/pkg/stream/http2/stream.go
  • Line 728: warning: cyclomatic complexity 25 of function (*clientStreamConnection).handleFrame() is high (> 15) (gocyclo)
  • Line 302: warning: cyclomatic complexity 23 of function (*serverStreamConnection).handleFrame() is high (> 15) (gocyclo)

• sofa-mosn/pkg/xds/conv/convertxds_test.go
  • Line 883: warning: cyclomatic complexity 16 of function Test_convertPerRouteConfig() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/conn.go
  • Line 585: warning: cyclomatic complexity 55 of function (*Conn).readRecordOrCCS() is high (> 15) (gocyclo)
  • Line 992: warning: cyclomatic complexity 27 of function (*Conn).readHandshake() is high (> 15) (gocyclo)
  • Line 317: warning: cyclomatic complexity 26 of function (*halfConn).decrypt() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/transport_test.go
  • Line 3950: warning: cyclomatic complexity 35 of function testClientConnClose() is high (> 15) (gocyclo)
  • Line 796: warning: cyclomatic complexity 30 of function testTransportReqBodyAfterResponse() is high (> 15) (gocyclo)
  • Line 1066: warning: cyclomatic complexity 27 of function testTransportResPattern() is high (> 15) (gocyclo)
  • Line 3216: warning: cyclomatic complexity 24 of function TestTransportRetryAfterGOAWAY() is high (> 15) (gocyclo)
  • Line 3534: warning: cyclomatic complexity 23 of function TestTransportRequestsStallAtServerLimit() is high (> 15) (gocyclo)
  • Line 4201: warning: cyclomatic complexity 19 of function testTransportBodyReadError() is high (> 15) (gocyclo)
  • Line 2619: warning: cyclomatic complexity 18 of function testTransportReturnsUnusedFlowControl() is high (> 15) (gocyclo)

• sofa-mosn/pkg/admin/server/server_test.go
  • Line 497: warning: cyclomatic complexity 33 of function TestGetState() is high (> 15) (gocyclo)

• sofa-mosn/pkg/configmanager/effectiveconfig_test.go
  • Line 346: warning: cyclomatic complexity 27 of function TestSetRouter() is high (> 15) (gocyclo)

• sofa-mosn/pkg/xds/xdsclient.go
  • Line 60: warning: cyclomatic complexity 23 of function UnmarshalResources() is high (> 15) (gocyclo)

• sofa-mosn/test/integrate/functiontest/faultinject_test.go
  • Line 89: warning: cyclomatic complexity 17 of function (*faultInjectCase).RunCase() is high (> 15) (gocyclo)

• sofa-mosn/pkg/upstream/cluster/cluster_manager.go
  • Line 362: warning: cyclomatic complexity 20 of function (*clusterManager).getActiveConnectionPool() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/transport.go
  • Line 962: warning: cyclomatic complexity 35 of function (*ClientConn).roundTrip() is high (> 15) (gocyclo)
  • Line 1367: warning: cyclomatic complexity 30 of function (*ClientConn).encodeHeaders() is high (> 15) (gocyclo)
  • Line 1676: warning: cyclomatic complexity 25 of function (*clientConnReadLoop).run() is high (> 15) (gocyclo)
  • Line 1817: warning: cyclomatic complexity 23 of function (*clientConnReadLoop).handleResponse() is high (> 15) (gocyclo)
  • Line 1220: warning: cyclomatic complexity 20 of function (*clientStream).writeRequestBody() is high (> 15) (gocyclo)
  • Line 2042: warning: cyclomatic complexity 17 of function (*clientConnReadLoop).processData() is high (> 15) (gocyclo)

• sofa-mosn/pkg/metrics/sink/console/console_test.go
  • Line 62: warning: cyclomatic complexity 16 of function TestConsoleMetrics() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_messages_test.go
  • Line 116: warning: cyclomatic complexity 21 of function (*clientHelloMsg).Generate() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/frame_test.go
  • Line 859: warning: cyclomatic complexity 20 of function TestMetaFrameHeader() is high (> 15) (gocyclo)

• sofa-mosn/pkg/cel/extract/attributes_builder.go
  • Line 66: warning: cyclomatic complexity 54 of function (*extractAttributes).Get() is high (> 15) (gocyclo)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/default_regulator_test.go
  • Line 27: warning: cyclomatic complexity 22 of function Test_Regulator() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/h2i/h2i.go
  • Line 144: warning: cyclomatic complexity 23 of function (*h2i).Main() is high (> 15) (gocyclo)

• sofa-mosn/pkg/upstream/cluster/cluster_healthcheck_test.go
  • Line 195: warning: cyclomatic complexity 20 of function TestHealthCheckWithDynamicCluster() is high (> 15) (gocyclo)
  • Line 117: warning: cyclomatic complexity 19 of function TestClusterHealthCheck() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_server_tls13.go
  • Line 501: warning: cyclomatic complexity 33 of function illegalClientHelloChange() is high (> 15) (gocyclo)
  • Line 100: warning: cyclomatic complexity 29 of function (*serverHandshakeStateTLS13).processClientHello() is high (> 15) (gocyclo)
  • Line 257: warning: cyclomatic complexity 21 of function (*serverHandshakeStateTLS13).checkForResumption() is high (> 15) (gocyclo)
  • Line 616: warning: cyclomatic complexity 16 of function (*serverHandshakeStateTLS13).sendServerCertificate() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/generate_cert.go
  • Line 66: warning: cyclomatic complexity 22 of function main() is high (> 15) (gocyclo)

• sofa-mosn/pkg/config/v2/config_test.go
  • Line 58: warning: cyclomatic complexity 17 of function TestClusterConfigDynamicModeParse() is high (> 15) (gocyclo)

• sofa-mosn/pkg/server/handler.go
  • Line 409: warning: cyclomatic complexity 19 of function (*activeListener).OnAccept() is high (> 15) (gocyclo)

• sofa-mosn/pkg/proxy/proxy_downstream_test.go
  • Line 57: warning: cyclomatic complexity 19 of function TestProxyWithFilters() is high (> 15) (gocyclo)

• sofa-mosn/test/lib/xprotocol/boltv1/boltv1_test.go
  • Line 8: warning: cyclomatic complexity 20 of function TestBoltSimple() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/tls_test.go
  • Line 897: warning: cyclomatic complexity 35 of function TestConnectionState() is high (> 15) (gocyclo)
  • Line 627: warning: cyclomatic complexity 21 of function TestCloneNonFuncFields() is high (> 15) (gocyclo)
  • Line 428: warning: cyclomatic complexity 18 of function TestConnCloseWrite() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_server.go
  • Line 407: warning: cyclomatic complexity 33 of function (*serverHandshakeState).doFullHandshake() is high (> 15) (gocyclo)
  • Line 172: warning: cyclomatic complexity 29 of function (*serverHandshakeState).processClientHello() is high (> 15) (gocyclo)
  • Line 63: warning: cyclomatic complexity 17 of function (*serverHandshakeState).handshake() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_client.go
  • Line 459: warning: cyclomatic complexity 33 of function (*clientHandshakeState).doFullHandshake() is high (> 15) (gocyclo)
  • Line 47: warning: cyclomatic complexity 23 of function (*Conn).makeClientHello() is high (> 15) (gocyclo)
  • Line 243: warning: cyclomatic complexity 22 of function (*Conn).loadSession() is high (> 15) (gocyclo)
  • Line 668: warning: cyclomatic complexity 19 of function (*clientHandshakeState).processServerHello() is high (> 15) (gocyclo)
  • Line 381: warning: cyclomatic complexity 17 of function (*clientHandshakeState).handshake() is high (> 15) (gocyclo)

• sofa-mosn/pkg/proxy/downstream_test.go
  • Line 279: warning: cyclomatic complexity 21 of function TestProcessError() is high (> 15) (gocyclo)

• sofa-mosn/pkg/config/v2/unmarshal_test.go
  • Line 58: warning: cyclomatic complexity 23 of function TestClusterUnmarshal() is high (> 15) (gocyclo)
  • Line 173: warning: cyclomatic complexity 20 of function TestListenerUnmarshal() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/conn_test.go
  • Line 136: warning: cyclomatic complexity 19 of function runDynamicRecordSizingTest() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/tls_context.go
  • Line 192: warning: cyclomatic complexity 18 of function tlsConfigTemplate() is high (> 15) (gocyclo)

• sofa-mosn/test/lib/http/http_test.go
  • Line 8: warning: cyclomatic complexity 20 of function TestHttpSimple() is high (> 15) (gocyclo)

• sofa-mosn/test/integrate/xds_config_test.go
  • Line 117: warning: cyclomatic complexity 47 of function TestConfigAddAndUpdate() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/key_agreement.go
  • Line 139: warning: cyclomatic complexity 17 of function (*ecdheKeyAgreement).generateServerKeyExchange() is high (> 15) (gocyclo)
  • Line 235: warning: cyclomatic complexity 16 of function (*ecdheKeyAgreement).processServerKeyExchange() is high (> 15) (gocyclo)

• sofa-mosn/pkg/server/adapter_test.go
  • Line 226: warning: cyclomatic complexity 17 of function TestIdleTimeoutAndUpdate() is high (> 15) (gocyclo)
  • Line 115: warning: cyclomatic complexity 17 of function TestLDS() is high (> 15) (gocyclo)

• sofa-mosn/pkg/proxy/downstream.go
  • Line 452: warning: cyclomatic complexity 48 of function (*downStream).receive() is high (> 15) (gocyclo)
  • Line 747: warning: cyclomatic complexity 26 of function (*downStream).chooseHost() is high (> 15) (gocyclo)

• sofa-mosn/test/integrate/functiontest/redirect_test.go
  • Line 92: warning: cyclomatic complexity 16 of function (*RedirectResponseCase).RunCase() is high (> 15) (gocyclo)

• sofa-mosn/pkg/configmanager/parser.go
  • Line 194: warning: cyclomatic complexity 34 of function ParseListenerConfig() is high (> 15) (gocyclo)

• sofa-mosn/pkg/upstream/healthcheck/healthchecker_test.go
  • Line 60: warning: cyclomatic complexity 29 of function TestHealthCheck() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_client_tls13.go
  • Line 39: warning: cyclomatic complexity 17 of function (*clientHandshakeStateTLS13).handshake() is high (> 15) (gocyclo)
  • Line 177: warning: cyclomatic complexity 17 of function (*clientHandshakeStateTLS13).processHelloRetryRequest() is high (> 15) (gocyclo)
  • Line 108: warning: cyclomatic complexity 17 of function (*clientHandshakeStateTLS13).checkServerHelloOrHRR() is high (> 15) (gocyclo)
  • Line 524: warning: cyclomatic complexity 16 of function (*clientHandshakeStateTLS13).sendClientCertificate() is high (> 15) (gocyclo)
  • Line 395: warning: cyclomatic complexity 16 of function (*clientHandshakeStateTLS13).readServerCertificate() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/auth.go
  • Line 26: warning: cyclomatic complexity 16 of function pickSignatureAlgorithm() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_server_test.go
  • Line 634: warning: cyclomatic complexity 24 of function (*serverTest).run() is high (> 15) (gocyclo)

• sofa-mosn/pkg/cel/ext/types.go
  • Line 122: warning: cyclomatic complexity 19 of function ConvertValue() is high (> 15) (gocyclo)
  • Line 71: warning: cyclomatic complexity 19 of function RecoverType() is high (> 15) (gocyclo)

• sofa-mosn/pkg/configmanager/dump_test.go
  • Line 30: warning: cyclomatic complexity 18 of function TestDumpWithTransExtension() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/static_tls_test.go
  • Line 383: warning: cyclomatic complexity 22 of function TestFallback() is high (> 15) (gocyclo)

• sofa-mosn/pkg/network/connection.go
  • Line 373: warning: cyclomatic complexity 27 of function (*connection).startReadLoop() is high (> 15) (gocyclo)
  • Line 204: warning: cyclomatic complexity 24 of function (*connection).attachEventLoop() is high (> 15) (gocyclo)
  • Line 677: warning: cyclomatic complexity 20 of function (*connection).startWriteLoop() is high (> 15) (gocyclo)

• sofa-mosn/pkg/xds/conv/convertxds.go
  • Line 1374: warning: cyclomatic complexity 23 of function convertTLS() is high (> 15) (gocyclo)
  • Line 368: warning: cyclomatic complexity 20 of function convertStreamFilter() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/tls.go
  • Line 203: warning: cyclomatic complexity 25 of function X509KeyPair() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/server.go
  • Line 2333: warning: cyclomatic complexity 34 of function (*responseWriterState).writeChunk() is high (> 15) (gocyclo)
  • Line 774: warning: cyclomatic complexity 30 of function (*serverConn).serve() is high (> 15) (gocyclo)
  • Line 2649: warning: cyclomatic complexity 23 of function (*responseWriter).Push() is high (> 15) (gocyclo)
  • Line 1578: warning: cyclomatic complexity 22 of function (*serverConn).processData() is high (> 15) (gocyclo)
  • Line 1718: warning: cyclomatic complexity 18 of function (*serverConn).processHeaders() is high (> 15) (gocyclo)
  • Line 205: warning: cyclomatic complexity 17 of function ConfigureServer() is high (> 15) (gocyclo)
  • Line 1922: warning: cyclomatic complexity 16 of function (*serverConn).newWriterAndRequest() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/frame.go
  • Line 1482: warning: cyclomatic complexity 19 of function (*Framer).readMetaFrame() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/server_test.go
  • Line 87: warning: cyclomatic complexity 18 of function newServerTester() is high (> 15) (gocyclo)
  • Line 3752: warning: cyclomatic complexity 16 of function TestServerHandlerConnectionClose() is high (> 15) (gocyclo)
  • Line 1923: warning: cyclomatic complexity 16 of function TestServer_Response_LargeWrite() is high (> 15) (gocyclo)

• sofa-mosn/pkg/cel/ext/functions.go
  • Line 242: warning: cyclomatic complexity 23 of function reflectWrapFunc() is high (> 15) (gocyclo)

• sofa-mosn/pkg/plugin/plugin_test.go
  • Line 19: warning: cyclomatic complexity 32 of function TestPluginClient() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_client_test.go
  • Line 302: warning: cyclomatic complexity 39 of function (*clientTest).run() is high (> 15) (gocyclo)
  • Line 176: warning: cyclomatic complexity 18 of function (*clientTest).connFromCommand() is high (> 15) (gocyclo)
  • Line 1051: warning: cyclomatic complexity 18 of function TestLRUClientSessionCache() is high (> 15) (gocyclo)
  • Line 1472: warning: cyclomatic complexity 16 of function testVerifyPeerCertificate() is high (> 15) (gocyclo)

• sofa-mosn/pkg/module/http2/server_push_test.go
  • Line 20: warning: cyclomatic complexity 33 of function TestServer_Push_Success() is high (> 15) (gocyclo)

• sofa-mosn/pkg/admin/debug/debug_api.go
  • Line 46: warning: cyclomatic complexity 16 of function DebugUpdateMosnConfig() is high (> 15) (gocyclo)

• sofa-mosn/pkg/upstream/cluster/subset_loadbalancer_test.go
  • Line 573: warning: cyclomatic complexity 16 of function TestDynamicSubsetHost() is high (> 15) (gocyclo)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_messages.go
  • Line 354: warning: cyclomatic complexity 91 of function (*clientHelloMsg).unmarshal() is high (> 15) (gocyclo)
  • Line 745: warning: cyclomatic complexity 47 of function (*serverHelloMsg).unmarshal() is high (> 15) (gocyclo)
  • Line 1144: warning: cyclomatic complexity 29 of function (*certificateRequestMsgTLS13).unmarshal() is high (> 15) (gocyclo)
  • Line 99: warning: cyclomatic complexity 29 of function (*clientHelloMsg).marshal() is high (> 15) (gocyclo)
  • Line 1383: warning: cyclomatic complexity 22 of function unmarshalCertificate() is high (> 15) (gocyclo)
  • Line 627: warning: cyclomatic complexity 16 of function (*serverHelloMsg).marshal() is high (> 15) (gocyclo)
  • Line 1710: warning: cyclomatic complexity 16 of function (*certificateRequestMsg).unmarshal() is high (> 15) (gocyclo)

• sofa-mosn/pkg/admin/server/dumpconfig_test.go
  • Line 60: warning: cyclomatic complexity 20 of function TestDumpConfigWithParameters() is high (> 15) (gocyclo)

• sofa-mosn/pkg/configmanager/featuregate_test.go
  • Line 31: warning: cyclomatic complexity 43 of function TestFeatureDump() is high (> 15) (gocyclo)

• sofa-mosn/pkg/config/v2/json_test.go
  • Line 555: warning: cyclomatic complexity 23 of function TestRouterConfigUmarshal() is high (> 15) (gocyclo)

• sofa-mosn/pkg/filter/stream/mirror/mirror.go
  • Line 40: warning: cyclomatic complexity 18 of function (*mirror).OnReceive() is high (> 15) (gocyclo)

• sofa-mosn/pkg/track/buffer_test.go
  • Line 60: warning: cyclomatic complexity 17 of function TestTrackTransmit() is high (> 15) (gocyclo)

golint56%

Golint is a linter for Go source code.

• sofa-mosn/pkg/filter/network/faultinject/factory.go
  • Line 41: warning: exported function CreateFaultInjectFactory should have comment or be unexported (golint)
  • Line 51: warning: comment on exported function ParseFaultInjectFilter should be of the form "ParseFaultInjectFilter ..." (golint)

• sofa-mosn/pkg/filter/stream/dsl/dsl.go
  • Line 32: warning: exported type DSLFilter should have comment or be unexported (golint)
  • Line 49: warning: exported method DSLFilter.OnReceive should have comment or be unexported (golint)
  • Line 77: warning: exported method DSLFilter.Append should have comment or be unexported (golint)
  • Line 96: warning: exported method DSLFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 100: warning: exported method DSLFilter.SetSenderFilterHandler should have comment or be unexported (golint)
  • Line 104: warning: exported method DSLFilter.OnDestroy should have comment or be unexported (golint)
  • Line 106: warning: exported method DSLFilter.Log should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/default_work_pool_test.go
  • Line 46: warning: don't use underscores in Go names; var model_1 should be model1 (golint)
  • Line 47: warning: don't use underscores in Go names; var model_2 should be model2 (golint)
  • Line 48: warning: don't use underscores in Go names; var model_3 should be model3 (golint)
  • Line 58: warning: don't use underscores in Go names; var model_4 should be model4 (golint)
  • Line 59: warning: don't use underscores in Go names; var model_5 should be model5 (golint)
  • Line 60: warning: don't use underscores in Go names; var model_6 should be model6 (golint)
  • Line 70: warning: don't use underscores in Go names; var model_7 should be model7 (golint)
  • Line 71: warning: don't use underscores in Go names; var model_8 should be model8 (golint)
  • Line 72: warning: don't use underscores in Go names; var model_9 should be model9 (golint)

• sofa-mosn/pkg/admin/server/server.go
  • Line 36: warning: exported function RegisterAdminHandleFunc should have comment or be unexported (golint)
  • Line 61: warning: exported type Server should have comment or be unexported (golint)
  • Line 65: warning: exported method Server.Start should have comment or be unexported (golint)

• sofa-mosn/pkg/router/types.go
  • Line 39: warning: comment on exported const RouterLogFormat should be of the form "RouterLogFormat ..." (golint)
  • Line 43: warning: exported var ErrNilRouterConfig should have comment or be unexported (golint)
  • Line 66: warning: exported type RouteBase should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/invocation_dimension.go
  • Line 20: warning: exported type InvocationDimension should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/invocation_stat.go
  • Line 28: warning: exported const MAX_NO_INVOKE_CYCLE should have comment or be unexported (golint)
  • Line 30: warning: exported type InvocationStat should have comment or be unexported (golint)
  • Line 39: warning: exported function NewInvocationStat should have comment or be unexported (golint)
  • Line 51: warning: exported method InvocationStat.Call should have comment or be unexported (golint)
  • Line 58: warning: exported method InvocationStat.GetMeasureKey should have comment or be unexported (golint)
  • Line 62: warning: exported method InvocationStat.GetInvocationKey should have comment or be unexported (golint)
  • Line 66: warning: exported method InvocationStat.GetCall should have comment or be unexported (golint)
  • Line 70: warning: exported method InvocationStat.GetCount should have comment or be unexported (golint)
  • Line 74: warning: exported method InvocationStat.GetDowngradeTime should have comment or be unexported (golint)
  • Line 78: warning: exported method InvocationStat.AddUselessCycle should have comment or be unexported (golint)
  • Line 83: warning: exported method InvocationStat.RestUselessCycle should have comment or be unexported (golint)
  • Line 87: warning: exported method InvocationStat.GetExceptionRate should have comment or be unexported (golint)
  • Line 94: warning: exported method InvocationStat.Snapshot should have comment or be unexported (golint)
  • Line 105: warning: exported method InvocationStat.Update should have comment or be unexported (golint)
  • Line 112: warning: exported method InvocationStat.Downgrade should have comment or be unexported (golint)
  • Line 117: warning: exported method InvocationStat.Recover should have comment or be unexported (golint)
  • Line 127: warning: exported method InvocationStat.IsHealthy should have comment or be unexported (golint)

• sofa-mosn/pkg/config/v2/grpc.go
  • Line 22: warning: exported type GRPC should have comment or be unexported (golint)

• sofa-mosn/pkg/configmanager/configmanager.go
  • Line 22: warning: comment on exported function AddOrUpdateClusterConfig should be of the form "AddOrUpdateClusterConfig ..." (golint)
  • Line 29: warning: exported function RemoveClusterConfig should have comment or be unexported (golint)
  • Line 33: warning: exported function DeleteClusterHost should have comment or be unexported (golint)
  • Line 37: warning: exported function AddOrUpdateClusterHost should have comment or be unexported (golint)
  • Line 41: warning: exported function UpdateClusterManagerTLS should have comment or be unexported (golint)
  • Line 45: warning: exported function AddClusterWithRouter should have comment or be unexported (golint)
  • Line 49: warning: exported function AddOrUpdateRouterConfig should have comment or be unexported (golint)
  • Line 53: warning: exported function AddOrUpdateListener should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/hpack/hpack.go
  • Line 149: warning: exported method Decoder.SetMaxDynamicTableSize should have comment or be unexported (golint)
  • Line 214: warning: comment on exported method Decoder.DecodeFull should be of the form "DecodeFull ..." (golint)

• sofa-mosn/pkg/stream/connpool/msgconnpool/activeclient.go
  • Line 1: warning: package comment should be of the form "Package msgconnpool ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/protocol/xprotocol/tars/protocol.go
  • Line 38: warning: exported var MagicTag should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/gotrack.go
  • Line 20: warning: exported var DebugGoroutines should have comment or be unexported (golint)

• sofa-mosn/pkg/wasm/runtime/wasmer/debug.go
  • Line 30: warning: exported const SecCustom should have comment (or a comment on this block) or be unexported (golint)
  • Line 105: warning: exported type CustomSection should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faultinject/factory.go
  • Line 33: warning: exported type FilterConfigFactory should have comment or be unexported (golint)
  • Line 37: warning: exported method FilterConfigFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 42: warning: exported function CreateFaultInjectFilterFactory should have comment or be unexported (golint)
  • Line 51: warning: comment on exported function ParseStreamFaultInjectFilter should be of the form "ParseStreamFaultInjectFilter ..." (golint)

• sofa-mosn/pkg/filter/stream/stats/metric.go
  • Line 39: warning: exported type Metrics should have comment or be unexported (golint)
  • Line 50: warning: exported type Stat should have comment or be unexported (golint)
  • Line 108: warning: exported method Metrics.Stat should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter/metadata/factory.go
  • Line 80: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/protocol/mapping.go
  • Line 33: warning: exported var ErrNoMapping should have comment or be unexported (golint)
  • Line 47: warning: exported function RegisterMapping should have comment or be unexported (golint)
  • Line 51: warning: exported function MappingHeaderStatusCode should have comment or be unexported (golint)

• sofa-mosn/examples/codes/http-sample/server.go
  • Line 25: warning: exported function ServeHTTP should have comment or be unexported (golint)

• sofa-mosn/pkg/network/connpool.go
  • Line 16: warning: exported var ConnNewPoolFactories should have comment or be unexported (golint)
  • Line 18: warning: exported function RegisterNewPoolFactory should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/healthcheck/factory.go
  • Line 33: warning: exported function RegisterSessionFactory should have comment or be unexported (golint)
  • Line 53: warning: exported function RegisterCommonCallbacks should have comment or be unexported (golint)

• sofa-mosn/test/cases/extends/streamfilter_terminate.go
  • Line 20: warning: exported function CreateTerminateFilter should have comment or be unexported (golint)
  • Line 33: warning: exported type TerminateFilterFactory should have comment or be unexported (golint)
  • Line 36: warning: exported method TerminateFilterFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 46: warning: exported function NewTerminateFilter should have comment or be unexported (golint)
  • Line 50: warning: exported method TerminateFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 54: warning: exported method TerminateFilter.OnReceive should have comment or be unexported (golint)
  • Line 58: warning: exported method TerminateFilter.OnDestroy should have comment or be unexported (golint)

• sofa-mosn/pkg/xds/v2/xdsconfig.go
  • Line 43: warning: comment on exported method XDSConfig.Init should be of the form "Init ..." (golint)

• sofa-mosn/pkg/upstream/cluster/cluster_adapter.go
  • Line 25: warning: comment on exported type MngAdapter should be of the form "MngAdapter ..." (with optional leading article) (golint)
  • Line 36: warning: exported function GetClusterMngAdapterInstance should have comment or be unexported (golint)
  • Line 40: warning: exported method MngAdapter.TriggerClusterAddOrUpdate should have comment or be unexported (golint)
  • Line 44: warning: exported method MngAdapter.TriggerClusterAndHostsAddOrUpdate should have comment or be unexported (golint)
  • Line 51: warning: exported method MngAdapter.TriggerClusterDel should have comment or be unexported (golint)
  • Line 55: warning: exported method MngAdapter.TriggerClusterHostUpdate should have comment or be unexported (golint)
  • Line 59: warning: exported method MngAdapter.TriggerHostDel should have comment or be unexported (golint)
  • Line 63: warning: exported method MngAdapter.TriggerHostAppend should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/edf.go
  • Line 29: warning: exported type WeightItem should have comment or be unexported (golint)
  • Line 33: warning: comment on exported type PriorityQueue should be of the form "PriorityQueue ..." (with optional leading article) (golint)
  • Line 80: warning: exported method PriorityQueue.Push should have comment or be unexported (golint)
  • Line 84: warning: exported method PriorityQueue.Pop should have comment or be unexported (golint)

• sofa-mosn/pkg/log/types.go
  • Line 27: warning: comment on exported var DefaultCreateErrorLoggerFunc should be of the form "DefaultCreateErrorLoggerFunc ..." (golint)
  • Line 30: warning: comment on exported type Level should be of the form "Level ..." (with optional leading article) (golint)
  • Line 35: warning: exported const FATAL should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported function GetOrCreateLogger should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/hpack/encode.go
  • Line 16: warning: exported type Encoder should have comment or be unexported (golint)

• sofa-mosn/pkg/metrics/store_test.go
  • Line 175: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter/metadata/unit/unit.go
  • Line 39: warning: exported type UnitConfig should have comment or be unexported (golint)
  • Line 43: warning: exported type UnitDriver should have comment or be unexported (golint)
  • Line 47: warning: exported method UnitDriver.Init should have comment or be unexported (golint)
  • Line 67: warning: exported method UnitDriver.BuildMetadata should have comment or be unexported (golint)
  • Line 75: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/trace/skywalking/http/tracer.go
  • Line 46: warning: exported function NewHttpSkyTracer should have comment or be unexported (golint)

• sofa-mosn/test/util/genconfig.go
  • Line 18: warning: comment on exported function NewProxyFilter should be of the form "NewProxyFilter ..." (golint)
  • Line 58: warning: exported function NewFilterChain should have comment or be unexported (golint)
  • Line 64: warning: exported function NewFilterChainWithSub should have comment or be unexported (golint)
  • Line 72: warning: exported function NewXProtocolFilterChain should have comment or be unexported (golint)
  • Line 80: warning: exported function NewBasicCluster should have comment or be unexported (golint)
  • Line 99: warning: exported function NewWeightedCluster should have comment or be unexported (golint)
  • Line 119: warning: exported function NewListener should have comment or be unexported (golint)
  • Line 130: warning: exported function NewMOSNConfig should have comment or be unexported (golint)
  • Line 143: warning: comment on exported function NewHeaderWeightedRouter should be of the form "NewHeaderWeightedRouter ..." (golint)
  • Line 165: warning: comment on exported function NewHeaderRouter should be of the form "NewHeaderRouter ..." (golint)
  • Line 186: warning: exported function NewPrefixRouter should have comment or be unexported (golint)
  • Line 205: warning: exported function NewPathRouter should have comment or be unexported (golint)

• sofa-mosn/pkg/admin/store/service.go
  • Line 46: warning: exported function ListServiceListenersFile should have comment or be unexported (golint)
  • Line 69: warning: exported function AddService should have comment or be unexported (golint)
  • Line 83: warning: exported function StartService should have comment or be unexported (golint)
  • Line 142: warning: exported function StopService should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/gzip/gzip.go
  • Line 83: warning: exported function NewStreamFilter should have comment or be unexported (golint)

• sofa-mosn/pkg/log/logger_manager.go
  • Line 28: warning: exported var DefaultLogger should have comment or be unexported (golint)
  • Line 116: warning: exported method ErrorLoggerManager.SetLogLevelControl should have comment or be unexported (golint)
  • Line 124: warning: exported method ErrorLoggerManager.DisableLogLevelControl should have comment or be unexported (golint)
  • Line 132: warning: exported method ErrorLoggerManager.SetAllErrorLoggerLevel should have comment or be unexported (golint)
  • Line 144: warning: exported method ErrorLoggerManager.Disable should have comment or be unexported (golint)
  • Line 154: warning: exported method ErrorLoggerManager.Enable should have comment or be unexported (golint)
  • Line 164: warning: comment on exported function GetErrorLoggerManagerInstance should be of the form "GetErrorLoggerManagerInstance ..." (golint)
  • Line 190: warning: comment on exported function GetErrorLoggersInfo should be of the form "GetErrorLoggersInfo ..." (golint)

• sofa-mosn/pkg/stream/http/buffer.go
  • Line 1: warning: package comment should be of the form "Package http ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/exports.go
  • Line 32: warning: exported method AbiV2Impl.ProxyDecodeBufferBytes should have comment or be unexported (golint)
  • Line 41: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 47: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 53: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 59: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 71: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 79: warning: exported method AbiV2Impl.ProxyEncodeRequestBufferBytes should have comment or be unexported (golint)
  • Line 149: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 155: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 160: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 167: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 177: warning: exported method AbiV2Impl.ProxyEncodeResponseBufferBytes should have comment or be unexported (golint)
  • Line 244: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 250: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 255: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 262: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 272: warning: exported method AbiV2Impl.ProxyKeepAliveBufferBytes should have comment or be unexported (golint)
  • Line 293: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 299: warning: exported method AbiV2Impl.ProxyReplyKeepAliveBufferBytes should have comment or be unexported (golint)
  • Line 325: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 331: warning: exported method AbiV2Impl.ProxyHijackBufferBytes should have comment or be unexported (golint)
  • Line 396: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 402: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 407: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 414: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• sofa-mosn/test/lib/types/stats.go
  • Line 9: warning: exported type Records should have comment or be unexported (golint)
  • Line 15: warning: exported function NewRecords should have comment or be unexported (golint)
  • Line 21: warning: comment on exported method Records.RecordResponse should be of the form "RecordResponse ..." (golint)
  • Line 31: warning: exported method Records.RecordRequest should have comment or be unexported (golint)
  • Line 35: warning: exported method Records.ResponseInfo should have comment or be unexported (golint)
  • Line 47: warning: exported method Records.Requests should have comment or be unexported (golint)
  • Line 56: warning: exported type ServerStats should have comment or be unexported (golint)
  • Line 63: warning: exported type ServerStatsReadOnly should have comment or be unexported (golint)
  • Line 72: warning: exported function NewServerStats should have comment or be unexported (golint)
  • Line 78: warning: exported method ServerStats.ConnectionTotal should have comment or be unexported (golint)
  • Line 82: warning: exported method ServerStats.ConnectionActive should have comment or be unexported (golint)
  • Line 86: warning: exported method ServerStats.ConnectionClosed should have comment or be unexported (golint)
  • Line 90: warning: exported method ServerStats.Records should have comment or be unexported (golint)
  • Line 94: warning: exported method ServerStats.ResponseInfo should have comment or be unexported (golint)
  • Line 97: warning: exported method ServerStats.Requests should have comment or be unexported (golint)
  • Line 101: warning: exported method ServerStats.ActiveConnection should have comment or be unexported (golint)
  • Line 106: warning: exported method ServerStats.CloseConnection should have comment or be unexported (golint)
  • Line 117: warning: exported type ClientStatsReadOnly should have comment or be unexported (golint)
  • Line 123: warning: exported type ClientStats should have comment or be unexported (golint)
  • Line 129: warning: exported function NewClientStats should have comment or be unexported (golint)
  • Line 135: warning: exported method ClientStats.ExpectedResponseCount should have comment or be unexported (golint)
  • Line 139: warning: exported method ClientStats.UnexpectedResponseCount should have comment or be unexported (golint)
  • Line 143: warning: exported method ClientStats.Response should have comment or be unexported (golint)

• sofa-mosn/test/integrate/xds_config_test.go
  • Line 111: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• sofa-mosn/pkg/filter/stream/dsl/factory.go
  • Line 37: warning: exported type DSL should have comment or be unexported (golint)

• sofa-mosn/pkg/cel/ext/macros.go
  • Line 33: warning: exported var Macros should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/skywalking/driver.go
  • Line 30: warning: exported const MOSNComponentID should have comment (or a comment on this block) or be unexported (golint)
  • Line 82: warning: exported function NewSkyDriverImpl should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/healthcheck/tcpdial.go
  • Line 28: warning: exported type TCPDialSessionFactory should have comment or be unexported (golint)
  • Line 30: warning: exported method TCPDialSessionFactory.NewSession should have comment or be unexported (golint)
  • Line 36: warning: exported type TCPDialSession should have comment or be unexported (golint)
  • Line 40: warning: exported method TCPDialSession.CheckHealth should have comment or be unexported (golint)
  • Line 53: warning: exported method TCPDialSession.OnTimeout should have comment or be unexported (golint)

• sofa-mosn/pkg/variable/factory.go
  • Line 88: warning: exported function RegisterVariable should have comment or be unexported (golint)
  • Line 112: warning: exported function RegisterPrefixVariable should have comment or be unexported (golint)
  • Line 126: warning: exported function NewVariableContext should have comment or be unexported (golint)

• sofa-mosn/pkg/types/route.go
  • Line 30: warning: exported type RouterType should have comment or be unexported (golint)
  • Line 33: warning: exported const GlobalTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 78: warning: exported const DefaultRouteHandler should have comment or be unexported (golint)
  • Line 87: warning: exported type RouterWrapper should have comment or be unexported (golint)
  • Line 94: warning: exported type HeaderFormat should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/network/proxy/factory.go
  • Line 58: warning: exported function CreateProxyFactory should have comment or be unexported (golint)
  • Line 78: warning: comment on exported function ParseProxyFilter should be of the form "ParseProxyFilter ..." (golint)

• sofa-mosn/pkg/router/http_rule.go
  • Line 33: warning: exported type BaseHTTPRouteRule should have comment or be unexported (golint)
  • Line 39: warning: exported function NewBaseHTTPRouteRule should have comment or be unexported (golint)
  • Line 46: warning: exported method BaseHTTPRouteRule.HeaderMatchCriteria should have comment or be unexported (golint)
  • Line 80: warning: exported type PathRouteRuleImpl should have comment or be unexported (golint)
  • Line 85: warning: exported method PathRouteRuleImpl.PathMatchCriterion should have comment or be unexported (golint)
  • Line 89: warning: exported method PathRouteRuleImpl.RouteRule should have comment or be unexported (golint)
  • Line 93: warning: comment on exported method PathRouteRuleImpl.Matcher should be of the form "Matcher ..." (golint)
  • Line 98: warning: exported method PathRouteRuleImpl.MatchType should have comment or be unexported (golint)
  • Line 102: warning: comment on exported method PathRouteRuleImpl.FinalizeRequestHeaders should be of the form "FinalizeRequestHeaders ..." (golint)
  • Line 109: warning: exported method PathRouteRuleImpl.Match should have comment or be unexported (golint)
  • Line 132: warning: exported method PrefixRouteRuleImpl.PathMatchCriterion should have comment or be unexported (golint)
  • Line 136: warning: exported method PrefixRouteRuleImpl.RouteRule should have comment or be unexported (golint)
  • Line 140: warning: comment on exported method PrefixRouteRuleImpl.Matcher should be of the form "Matcher ..." (golint)
  • Line 145: warning: exported method PrefixRouteRuleImpl.MatchType should have comment or be unexported (golint)
  • Line 149: warning: comment on exported method PrefixRouteRuleImpl.FinalizeRequestHeaders should be of the form "FinalizeRequestHeaders ..." (golint)
  • Line 156: warning: exported method PrefixRouteRuleImpl.Match should have comment or be unexported (golint)
  • Line 178: warning: exported method RegexRouteRuleImpl.PathMatchCriterion should have comment or be unexported (golint)
  • Line 182: warning: exported method RegexRouteRuleImpl.RouteRule should have comment or be unexported (golint)
  • Line 186: warning: exported method RegexRouteRuleImpl.Matcher should have comment or be unexported (golint)
  • Line 190: warning: exported method RegexRouteRuleImpl.MatchType should have comment or be unexported (golint)
  • Line 194: warning: exported method RegexRouteRuleImpl.FinalizeRequestHeaders should have comment or be unexported (golint)
  • Line 199: warning: exported method RegexRouteRuleImpl.Match should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/frame.go
  • Line 30: warning: exported const FrameData should have comment (or a comment on this block) or be unexported (golint)
  • Line 337: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 351: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 373: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 391: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 392: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 393: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 394: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 578: warning: exported method DataFrame.StreamEnded should have comment or be unexported (golint)
  • Line 642: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 646: warning: comment on exported method Framer.WriteDataPadded should be of the form "WriteDataPadded ..." (golint)
  • Line 655: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 732: warning: exported method SettingsFrame.IsAck should have comment or be unexported (golint)
  • Line 736: warning: exported method SettingsFrame.Value should have comment or be unexported (golint)
  • Line 756: warning: exported method SettingsFrame.NumSettings should have comment or be unexported (golint)
  • Line 806: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 819: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 833: warning: exported method PingFrame.IsAck should have comment or be unexported (golint)
  • Line 847: warning: exported method Framer.WritePing should have comment or be unexported (golint)
  • Line 847: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 890: warning: exported method Framer.WriteGoAway should have comment or be unexported (golint)
  • Line 890: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 953: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 974: warning: exported method HeadersFrame.HeaderBlockFragment should have comment or be unexported (golint)
  • Line 979: warning: exported method HeadersFrame.HeadersEnded should have comment or be unexported (golint)
  • Line 983: warning: exported method HeadersFrame.StreamEnded should have comment or be unexported (golint)
  • Line 987: warning: exported method HeadersFrame.HasPriority should have comment or be unexported (golint)
  • Line 1063: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 1124: warning: exported method PriorityParam.IsZero should have comment or be unexported (golint)
  • Line 1151: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 1189: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 1212: warning: exported method ContinuationFrame.HeaderBlockFragment should have comment or be unexported (golint)
  • Line 1217: warning: exported method ContinuationFrame.HeadersEnded should have comment or be unexported (golint)
  • Line 1225: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 1246: warning: exported method PushPromiseFrame.HeaderBlockFragment should have comment or be unexported (golint)
  • Line 1251: warning: exported method PushPromiseFrame.HeadersEnded should have comment or be unexported (golint)
  • Line 1320: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 1346: warning: receiver name f should be consistent with previous receiver name fr for Framer (golint)
  • Line 1545: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/stream/client.go
  • Line 42: warning: comment on exported function NewStreamClient should be of the form "NewStreamClient ..." (golint)
  • Line 64: warning: comment on exported function NewBiDirectStreamClient should be of the form "NewBiDirectStreamClient ..." (golint)

• sofa-mosn/pkg/protocol/xprotocol/example/protocol.go
  • Line 95: warning: exported function NewCodec should have comment or be unexported (golint)

• sofa-mosn/pkg/types/upstream.go
  • Line 271: warning: exported type CreateConnectionData should have comment or be unexported (golint)
  • Line 286: warning: exported type ClusterHostFactoryCb should have comment or be unexported (golint)
  • Line 290: warning: exported type ClusterManagerFilter should have comment or be unexported (golint)
  • Line 300: warning: exported type LBSubsetInfo should have comment or be unexported (golint)
  • Line 315: warning: exported type LBOriDstInfo should have comment or be unexported (golint)
  • Line 395: warning: exported var ConnPoolFactories should have comment or be unexported (golint)
  • Line 397: warning: exported function RegisterConnPoolFactory should have comment or be unexported (golint)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/codec/command.go
  • Line 25: warning: exported type Request should have comment or be unexported (golint)
  • Line 33: warning: exported method Request.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 37: warning: exported method Request.GetTimeout should have comment or be unexported (golint)
  • Line 41: warning: exported method Request.GetHeader should have comment or be unexported (golint)
  • Line 45: warning: exported method Request.GetData should have comment or be unexported (golint)
  • Line 49: warning: exported method Request.SetData should have comment or be unexported (golint)
  • Line 55: warning: exported method Request.GetStreamType should have comment or be unexported (golint)
  • Line 59: warning: exported method Request.GetRequestId should have comment or be unexported (golint)
  • Line 63: warning: exported method Request.SetRequestId should have comment or be unexported (golint)
  • Line 67: warning: exported type Response should have comment or be unexported (golint)
  • Line 74: warning: exported method Response.GetStatusCode should have comment or be unexported (golint)
  • Line 78: warning: exported method Response.GetStreamType should have comment or be unexported (golint)
  • Line 82: warning: exported method Response.GetRequestId should have comment or be unexported (golint)
  • Line 86: warning: exported method Response.SetRequestId should have comment or be unexported (golint)
  • Line 90: warning: exported method Response.GetHeader should have comment or be unexported (golint)
  • Line 94: warning: exported type MessageCommand should have comment or be unexported (golint)
  • Line 101: warning: exported type MessageAckCommand should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/connpool/msgconnpool/connpool.go
  • Line 1: warning: package comment should be of the form "Package msgconnpool ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 35: warning: comment on exported type State should be of the form "State ..." (with optional leading article) (golint)
  • Line 39: warning: exported const Available should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/stream/connpool/msgconnpool/keepalive.go
  • Line 1: warning: package comment should be of the form "Package msgconnpool ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/trace/sofa/xprotocol/span.go
  • Line 36: warning: exported type SofaRPCSpan should have comment or be unexported (golint)
  • Line 47: warning: exported method SofaRPCSpan.TraceId should have comment or be unexported (golint)
  • Line 51: warning: exported method SofaRPCSpan.SpanId should have comment or be unexported (golint)
  • Line 55: warning: exported method SofaRPCSpan.ParentSpanId should have comment or be unexported (golint)
  • Line 59: warning: exported method SofaRPCSpan.SetOperation should have comment or be unexported (golint)
  • Line 63: warning: exported method SofaRPCSpan.SetTag should have comment or be unexported (golint)
  • Line 75: warning: exported method SofaRPCSpan.SetRequestInfo should have comment or be unexported (golint)
  • Line 89: warning: exported method SofaRPCSpan.Tag should have comment or be unexported (golint)
  • Line 93: warning: exported method SofaRPCSpan.FinishSpan should have comment or be unexported (golint)
  • Line 103: warning: exported method SofaRPCSpan.InjectContext should have comment or be unexported (golint)
  • Line 106: warning: exported method SofaRPCSpan.SpawnChild should have comment or be unexported (golint)
  • Line 110: warning: exported method SofaRPCSpan.SetStartTime should have comment or be unexported (golint)
  • Line 127: warning: exported method SofaRPCSpan.EndTime should have comment or be unexported (golint)
  • Line 131: warning: exported method SofaRPCSpan.StartTime should have comment or be unexported (golint)
  • Line 259: warning: exported function NewSpan should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/servicediscovery/dubbod/structs.go
  • Line 1: warning: package comment should be of the form "Package dubbod ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/xds/conv/update.go
  • Line 160: warning: comment on exported function ConvertUpdateEndpoints should be of the form "ConvertUpdateEndpoints ..." (golint)

• sofa-mosn/pkg/admin/server/apis.go
  • Line 197: warning: comment on exported type LogLevelData should be of the form "LogLevelData ..." (with optional leading article) (golint)

• sofa-mosn/pkg/filter/stream/flowcontrol/stream_filter_test.go
  • Line 330: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 335: warning: receiver name h should be consistent with previous receiver name headers for mockHeaderMap (golint)
  • Line 339: warning: receiver name h should be consistent with previous receiver name headers for mockHeaderMap (golint)

• sofa-mosn/pkg/protocol/config.go
  • Line 32: warning: exported function RegisterProtocolConfigHandler should have comment or be unexported (golint)
  • Line 39: warning: exported function HandleConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/factory.go
  • Line 40: warning: exported function GetProxyProtocolManager should have comment or be unexported (golint)
  • Line 44: warning: exported type ProxyProtocolManager should have comment or be unexported (golint)
  • Line 75: warning: exported type ProxyProtocolWrapper should have comment or be unexported (golint)
  • Line 128: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 231: warning: exported function ParseProtocolConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/proxy/downstream.go
  • Line 1120: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1152: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 1179: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/router/routers_manager.go
  • Line 31: warning: exported type RoutersWrapper should have comment or be unexported (golint)
  • Line 37: warning: exported method RoutersWrapper.GetRouters should have comment or be unexported (golint)
  • Line 44: warning: exported method RoutersWrapper.GetRoutersConfig should have comment or be unexported (golint)
  • Line 184: warning: comment on exported function GetRoutersMangerInstance should be of the form "GetRoutersMangerInstance ..." (golint)
  • Line 189: warning: exported function NewRouterManager should have comment or be unexported (golint)

• sofa-mosn/pkg/xds/conv/convertxds.go
  • Line 79: warning: comment on exported function ConvertListenerConfig should be of the form "ConvertListenerConfig ..." (golint)
  • Line 160: warning: exported function ConvertClustersConfig should have comment or be unexported (golint)
  • Line 206: warning: exported function ConvertEndpointsConfig should have comment or be unexported (golint)
  • Line 482: warning: don't use underscores in Go names; var fixed_delay should be fixedDelay (golint)
  • Line 828: warning: exported function ConvertRouterConf should have comment or be unexported (golint)

• sofa-mosn/pkg/cel/ext/types.go
  • Line 41: warning: exported function ConvertType should have comment or be unexported (golint)
  • Line 71: warning: exported function RecoverType should have comment or be unexported (golint)
  • Line 122: warning: exported function ConvertValue should have comment or be unexported (golint)
  • Line 178: warning: exported function RecoverValue should have comment or be unexported (golint)
  • Line 227: warning: exported function DefaultValue should have comment or be unexported (golint)
  • Line 389: warning: exported type DNSName should have comment or be unexported (golint)
  • Line 469: warning: exported function ConvertKind should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/l7/stream/stream.go
  • Line 31: warning: exported type ActiveStream should have comment or be unexported (golint)
  • Line 123: warning: exported method ActiveStream.Connection should have comment or be unexported (golint)
  • Line 123: warning: receiver name f should be consistent with previous receiver name s for ActiveStream (golint)
  • Line 127: warning: exported method ActiveStream.Route should have comment or be unexported (golint)
  • Line 127: warning: receiver name f should be consistent with previous receiver name s for ActiveStream (golint)
  • Line 133: warning: exported method ActiveStream.RequestInfo should have comment or be unexported (golint)
  • Line 133: warning: receiver name f should be consistent with previous receiver name s for ActiveStream (golint)
  • Line 139: warning: exported method ActiveStream.GetRequestUpdatedHeaders should have comment or be unexported (golint)
  • Line 143: warning: exported method ActiveStream.GetResponseUpdatedHeaders should have comment or be unexported (golint)
  • Line 147: warning: comment on exported method ActiveStream.GetRequestHeaders should be of the form "GetRequestHeaders ..." (golint)
  • Line 152: warning: exported method ActiveStream.GetRequestData should have comment or be unexported (golint)
  • Line 156: warning: exported method ActiveStream.GetRequestTrailers should have comment or be unexported (golint)
  • Line 160: warning: comment on exported method ActiveStream.AppendHeaders should be of the form "AppendHeaders ..." (golint)
  • Line 165: warning: exported method ActiveStream.AppendData should have comment or be unexported (golint)
  • Line 169: warning: exported method ActiveStream.AppendTrailers should have comment or be unexported (golint)
  • Line 173: warning: exported method ActiveStream.SendHijackReply should have comment or be unexported (golint)
  • Line 188: warning: exported method ActiveStream.SendHijackReplyWithBody should have comment or be unexported (golint)
  • Line 204: warning: exported method ActiveStream.SendDirectResponse should have comment or be unexported (golint)
  • Line 233: warning: exported method ActiveStream.TerminateStream should have comment or be unexported (golint)
  • Line 248: warning: exported method ActiveStream.SetConvert should have comment or be unexported (golint)
  • Line 252: warning: exported method ActiveStream.GetFilterCurrentPhase should have comment or be unexported (golint)
  • Line 256: warning: comment on exported method ActiveStream.GetResponseHeaders should be of the form "GetResponseHeaders ..." (golint)
  • Line 261: warning: exported method ActiveStream.GetResponseData should have comment or be unexported (golint)
  • Line 265: warning: exported method ActiveStream.GetResponseTrailers should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/xprotocol/connpool_binding.go
  • Line 64: warning: error var downstreamClosed should have name of the form errFoo (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/types.go
  • Line 27: warning: exported const ResponseType should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: exported type ProtocolConfig should have comment or be unexported (golint)

• sofa-mosn/test/integrate/filter/reroute_test.go
  • Line 57: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/proxy/mock_test.go
  • Line 96: warning: receiver name c should be consistent with previous receiver name r for mockRouteRule (golint)
  • Line 100: warning: receiver name c should be consistent with previous receiver name r for mockRouteRule (golint)
  • Line 104: warning: receiver name c should be consistent with previous receiver name r for mockRouteRule (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/measure_model_test.go
  • Line 76: warning: don't use underscores in Go names; var stat_1 should be stat1 (golint)
  • Line 77: warning: don't use underscores in Go names; var stat_2 should be stat2 (golint)
  • Line 78: warning: don't use underscores in Go names; var stat_3 should be stat3 (golint)
  • Line 79: warning: don't use underscores in Go names; var stat_4 should be stat4 (golint)
  • Line 80: warning: don't use underscores in Go names; var stat_5 should be stat5 (golint)

• sofa-mosn/pkg/filter/network/grpc/factory.go
  • Line 169: warning: exported var ErrUnknownServer should have comment or be unexported (golint)
  • Line 239: warning: exported function RegisterServerHandler should have comment or be unexported (golint)
  • Line 258: warning: exported function ParseGRPC should have comment or be unexported (golint)

• sofa-mosn/pkg/config/v2/route.go
  • Line 34: warning: exported type RouterConfigurationConfig should have comment or be unexported (golint)
  • Line 43: warning: exported type RouterConfig should have comment or be unexported (golint)
  • Line 53: warning: exported type RouterActionConfig should have comment or be unexported (golint)
  • Line 72: warning: exported type ClusterWeightConfig should have comment or be unexported (golint)
  • Line 78: warning: exported type RetryPolicyConfig should have comment or be unexported (golint)
  • Line 90: warning: exported type PatternConfig should have comment or be unexported (golint)
  • Line 95: warning: comment on exported type GoogleRe2Config should be of the form "GoogleRe2Config ..." (with optional leading article) (golint)
  • Line 100: warning: comment on exported type Router should be of the form "Router ..." (with optional leading article) (golint)
  • Line 108: warning: exported method Router.MarshalJSON should have comment or be unexported (golint)
  • Line 113: warning: exported method Router.UnmarshalJSON should have comment or be unexported (golint)
  • Line 128: warning: exported method RouteAction.MarshalJSON should have comment or be unexported (golint)
  • Line 134: warning: exported method RouteAction.UnmarshalJSON should have comment or be unexported (golint)
  • Line 143: warning: comment on exported type Decorator should be of the form "Decorator ..." (with optional leading article) (golint)
  • Line 146: warning: comment on exported type ClusterWeight should be of the form "ClusterWeight ..." (with optional leading article) (golint)
  • Line 154: warning: exported method ClusterWeight.MarshalJSON should have comment or be unexported (golint)
  • Line 159: warning: exported method ClusterWeight.UnmarshalJSON should have comment or be unexported (golint)
  • Line 173: warning: exported method RetryPolicy.MarshalJSON should have comment or be unexported (golint)
  • Line 178: warning: exported method RetryPolicy.UnmarshalJSON should have comment or be unexported (golint)
  • Line 204: warning: comment on exported method RouterConfiguration.MarshalJSON should be of the form "MarshalJSON ..." (golint)
  • Line 249: warning: exported method RouterConfiguration.UnmarshalJSON should have comment or be unexported (golint)
  • Line 344: warning: exported type DslExpressionMatcher should have comment or be unexported (golint)
  • Line 348: warning: comment on exported type StreamRouteConfig should be of the form "StreamRouteConfig ..." (with optional leading article) (golint)

• sofa-mosn/pkg/configmanager/load_config.go
  • Line 42: warning: comment on exported function GetConfigPath should be of the form "GetConfigPath ..." (golint)
  • Line 55: warning: exported function DefaultConfigLoad should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/discovery/fsdis/fsdis.go
  • Line 48: warning: comment on exported const FileSystemDiscoveryFile should be of the form "FileSystemDiscoveryFile ..." (golint)
  • Line 54: warning: exported const GetFileSystemDiscoveryRetryLoopInterval should have comment (or a comment on this block) or be unexported (golint)
  • Line 140: warning: exported type ServiceAddrInfo should have comment or be unexported (golint)
  • Line 146: warning: exported function NewServiceAddrInfo should have comment or be unexported (golint)
  • Line 154: warning: exported method ServiceAddrInfo.GetServiceIP should have comment or be unexported (golint)
  • Line 158: warning: exported method ServiceAddrInfo.GetServiceSite should have comment or be unexported (golint)
  • Line 162: warning: exported method ServiceAddrInfo.GetServicePort should have comment or be unexported (golint)
  • Line 166: warning: exported type AppService should have comment or be unexported (golint)
  • Line 172: warning: exported function NewAppService should have comment or be unexported (golint)
  • Line 187: warning: exported type FileSystemDiscovery should have comment or be unexported (golint)
  • Line 192: warning: exported function GetSignalFileSystemDiscovery should have comment or be unexported (golint)
  • Line 196: warning: exported function NewFileSystemDiscovery should have comment or be unexported (golint)
  • Line 206: warning: exported method FileSystemDiscovery.AddorUpdateAppServiceMonitor should have comment or be unexported (golint)
  • Line 226: warning: exported method FileSystemDiscovery.GetServiceAddrInfo should have comment or be unexported (golint)
  • Line 256: warning: should omit 2nd value from range; this loop is equivalent to `for index := range ...` (golint)
  • Line 263: warning: exported method FileSystemDiscovery.GetAllServiceName should have comment or be unexported (golint)
  • Line 274: warning: exported method FileSystemDiscovery.CheckAndResetServiceChange should have comment or be unexported (golint)
  • Line 288: warning: exported method FileSystemDiscovery.SetServiceChangeRetry should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/factory.go
  • Line 30: warning: exported function RegisterDriver should have comment or be unexported (golint)
  • Line 34: warning: exported function RegisterTracerBuilder should have comment or be unexported (golint)

• sofa-mosn/pkg/variable/protocolres.go
  • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/featuregate/feature_gate.go
  • Line 47: warning: exported type FeatureGate should have comment or be unexported (golint)
  • Line 61: warning: exported function NewFeatureGate should have comment or be unexported (golint)
  • Line 249: warning: exported method FeatureGate.WaitInitFinsh should have comment or be unexported (golint)

• sofa-mosn/pkg/cel/extract/attributes.go
  • Line 24: warning: exported var Attributemanifest should have comment or be unexported (golint)

• sofa-mosn/pkg/config/v2/loadbalancer.go
  • Line 24: warning: exported type LeastRequestLbConfig should have comment or be unexported (golint)
  • Line 28: warning: don't use underscores in Go names; method isCluster_LbConfig should be isClusterLbConfig (golint)
  • Line 31: warning: don't use underscores in Go names; type IsCluster_LbConfig should be IsClusterLbConfig (golint)
  • Line 31: warning: exported type IsCluster_LbConfig should have comment or be unexported (golint)
  • Line 35: warning: exported type HashPolicy should have comment or be unexported (golint)
  • Line 41: warning: exported type HeaderHashPolicy should have comment or be unexported (golint)
  • Line 45: warning: exported type CookieHashPolicy should have comment or be unexported (golint)
  • Line 51: warning: exported type SourceIPHashPolicy should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/types.go
  • Line 39: warning: error var FAILED should have name of the form ErrFoo (golint)
  • Line 39: warning: exported var FAILED should have comment or be unexported (golint)
  • Line 40: warning: error var EAGAIN should have name of the form ErrFoo (golint)
  • Line 40: warning: exported var EAGAIN should have comment or be unexported (golint)
  • Line 42: warning: exported type Client should have comment or be unexported (golint)
  • Line 63: warning: exported type ProtocolStreamFactory should have comment or be unexported (golint)

• sofa-mosn/test/util/mosn/mosn.go
  • Line 8: warning: exported type MosnWrapper should have comment or be unexported (golint)
  • Line 12: warning: comment on exported function NewMosn should be of the form "NewMosn ..." (golint)
  • Line 21: warning: comment on exported method MosnWrapper.Start should be of the form "Start ..." (golint)
  • Line 28: warning: exported method MosnWrapper.Close should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/crypto/tls/auth.go
  • Line 36: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/types/config.go
  • Line 27: warning: exported var MosnBasePath should have comment or be unexported (golint)
  • Line 44: warning: exported function InitDefaultPath should have comment or be unexported (golint)

• sofa-mosn/examples/codes/wasm/httpCall/server.go
  • Line 25: warning: exported function ServeHTTP should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/mixer/mixer.go
  • Line 159: warning: comment on exported function ParseMixerFilter should be of the form "ParseMixerFilter ..." (golint)

• sofa-mosn/pkg/config/v2/cidr_range.go
  • Line 23: warning: comment on exported method CidrRange.IsInRange should be of the form "IsInRange ..." (golint)

• sofa-mosn/pkg/config/v2/common.go
  • Line 31: warning: exported type LbMeta should have comment or be unexported (golint)
  • Line 63: warning: exported var ErrDuplicateTLSConfig should have comment or be unexported (golint)
  • Line 65: warning: exported var ErrDuplicateStaticAndDynamic should have comment or be unexported (golint)
  • Line 67: warning: exported const MaxFilePath should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/http/stream.go
  • Line 64: warning: exported var HKConnection should have comment or be unexported (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 152: warning: receiver name conn should be consistent with previous receiver name sc for streamConnection (golint)
  • Line 156: warning: receiver name conn should be consistent with previous receiver name sc for streamConnection (golint)
  • Line 160: warning: receiver name conn should be consistent with previous receiver name sc for streamConnection (golint)
  • Line 162: warning: receiver name conn should be consistent with previous receiver name sc for streamConnection (golint)
  • Line 193: warning: receiver name conn should be consistent with previous receiver name sc for streamConnection (golint)
  • Line 204: warning: receiver name conn should be consistent with previous receiver name sc for streamConnection (golint)
  • Line 347: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 370: warning: exported type StreamConfig should have comment or be unexported (golint)
  • Line 578: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 955: warning: exported function FillRequestHeadersFromCtxVar should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/http/var.go
  • Line 31: warning: exported const VarRequestMethod should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/variable/api.go
  • Line 29: warning: exported function GetVariableValue should have comment or be unexported (golint)
  • Line 64: warning: exported function SetVariableValue should have comment or be unexported (golint)

• sofa-mosn/pkg/types/log.go
  • Line 20: warning: comment on exported const ErrorModuleMosn should be of the form "ErrorModuleMosn ..." (golint)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/codec/protocol.go
  • Line 43: warning: exported type Proto should have comment or be unexported (golint)
  • Line 45: warning: exported method Proto.Name should have comment or be unexported (golint)
  • Line 49: warning: comment on exported method Proto.Encode should be of the form "Encode ..." (golint)
  • Line 62: warning: comment on exported method Proto.Decode should be of the form "Decode ..." (golint)
  • Line 88: warning: comment on exported method Proto.Trigger should be of the form "Trigger ..." (golint)
  • Line 94: warning: exported method Proto.Reply should have comment or be unexported (golint)
  • Line 99: warning: comment on exported method Proto.Hijack should be of the form "Hijack ..." (golint)
  • Line 105: warning: exported method Proto.Mapping should have comment or be unexported (golint)
  • Line 115: warning: exported method Proto.EnableWorkerPool should have comment or be unexported (golint)
  • Line 119: warning: exported method Proto.GenerateRequestID should have comment or be unexported (golint)

• sofa-mosn/examples/codes/filter/transcoder/server.go
  • Line 19: warning: exported type Server should have comment or be unexported (golint)
  • Line 25: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 45: warning: exported method Server.Run should have comment or be unexported (golint)
  • Line 60: warning: exported method Server.Serve should have comment or be unexported (golint)
  • Line 99: warning: exported method Server.HandleRequest should have comment or be unexported (golint)

• sofa-mosn/pkg/network/listener.go
  • Line 37: warning: exported type ListenerState should have comment or be unexported (golint)
  • Line 67: warning: exported function NewListener should have comment or be unexported (golint)

• sofa-mosn/pkg/server/reconfigure.go
  • Line 43: warning: exported var GracefulTimeout should have comment or be unexported (golint)
  • Line 47: warning: exported function EnableInheritOldMosnconfig should have comment or be unexported (golint)
  • Line 141: warning: exported function ReconfigureHandler should have comment or be unexported (golint)
  • Line 180: warning: exported function StopReconfigureHandler should have comment or be unexported (golint)

• sofa-mosn/examples/codes/tcpproxy-sample/rpc_server.go
  • Line 17: warning: exported type Server should have comment or be unexported (golint)
  • Line 23: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 43: warning: exported method Server.Run should have comment or be unexported (golint)
  • Line 58: warning: exported method Server.Serve should have comment or be unexported (golint)
  • Line 97: warning: exported method Server.HandleRequest should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/http2/connpool.go
  • Line 50: warning: comment on exported function NewConnPool should be of the form "NewConnPool ..." (golint)

• sofa-mosn/pkg/variable/protocolres_test.go
  • Line 42: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)

• sofa-mosn/pkg/router/handler.go
  • Line 47: warning: exported function DefaultMakeHandler should have comment or be unexported (golint)
  • Line 61: warning: exported method MakeHandlerFunc.DoRouteHandler should have comment or be unexported (golint)

• sofa-mosn/pkg/proxy/stats.go
  • Line 26: warning: exported type Stats should have comment or be unexported (golint)
  • Line 97: warning: exported method Stats.DownstreamUpdateRequestCode should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/util/calculate_util.go
  • Line 25: warning: exported function DivideInt64 should have comment or be unexported (golint)
  • Line 31: warning: exported function DivideFloat64 should have comment or be unexported (golint)

• sofa-mosn/pkg/admin/server/istio.go
  • Line 16: warning: exported const CDS_UPDATE_SUCCESS should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/header_codec.go
  • Line 24: warning: exported var GetHeaderEncodeLength should have comment or be unexported (golint)
  • Line 26: warning: exported var EncodeHeader should have comment or be unexported (golint)
  • Line 28: warning: exported var DecodeHeader should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/api.go
  • Line 25: warning: exported function NewWasmRequestWithId should have comment or be unexported (golint)
  • Line 52: warning: exported function NewWasmResponseWithId should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/decode.go
  • Line 109: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• sofa-mosn/pkg/wasm/plugin.go
  • Line 32: warning: exported var ErrEngineNotFound should have comment or be unexported (golint)
  • Line 129: warning: exported function NewWasmPlugin should have comment or be unexported (golint)
  • Line 303: warning: exported method DefaultWasmPluginHandler.OnConfigUpdate should have comment or be unexported (golint)
  • Line 305: warning: exported method DefaultWasmPluginHandler.OnPluginStart should have comment or be unexported (golint)
  • Line 307: warning: exported method DefaultWasmPluginHandler.OnPluginDestroy should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/health.go
  • Line 31: warning: exported function GetHealthFlagPointer should have comment or be unexported (golint)
  • Line 40: warning: exported function SetHealthFlag should have comment or be unexported (golint)
  • Line 49: warning: exported function ClearHealthFlag should have comment or be unexported (golint)

• sofa-mosn/test/lib/xprotocol/boltv1/config.go
  • Line 18: warning: exported type BoltServerConfig should have comment or be unexported (golint)
  • Line 23: warning: exported function NewBoltServerConfig should have comment or be unexported (golint)
  • Line 35: warning: exported type ResponseConfig should have comment or be unexported (golint)
  • Line 41: warning: exported method ResponseConfig.HandleRequest should have comment or be unexported (golint)
  • Line 63: warning: exported type Condition should have comment or be unexported (golint)
  • Line 73: warning: exported method Condition.Match should have comment or be unexported (golint)
  • Line 100: warning: exported method ResponseBuilder.Build should have comment or be unexported (golint)
  • Line 109: warning: exported var DefaultSucessBuilder should have comment or be unexported (golint)
  • Line 113: warning: exported var DefaultErrorBuilder should have comment or be unexported (golint)
  • Line 117: warning: exported type BoltClientConfig should have comment or be unexported (golint)
  • Line 124: warning: exported function NewBoltClientConfig should have comment or be unexported (golint)
  • Line 143: warning: exported method RequestConfig.BuildRequest should have comment or be unexported (golint)
  • Line 183: warning: exported method VerifyConfig.Verify should have comment or be unexported (golint)

• sofa-mosn/examples/codes/uds-sample/uds_server.go
  • Line 11: warning: exported const MaxSize should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/config/v2/server.go
  • Line 54: warning: comment on exported type ListenerType should be of the form "ListenerType ..." (with optional leading article) (golint)
  • Line 57: warning: exported const EGRESS should have comment or be unexported (golint)
  • Line 58: warning: exported const INGRESS should have comment or be unexported (golint)
  • Line 60: warning: exported type ListenerConfig should have comment or be unexported (golint)
  • Line 87: warning: exported method Listener.MarshalJSON should have comment or be unexported (golint)
  • Line 95: warning: exported var ErrNoAddrListener should have comment or be unexported (golint)
  • Line 101: warning: exported method Listener.UnmarshalJSON should have comment or be unexported (golint)
  • Line 145: warning: exported method FilterChain.MarshalJSON should have comment or be unexported (golint)
  • Line 153: warning: exported method FilterChain.UnmarshalJSON should have comment or be unexported (golint)
  • Line 173: warning: exported type StreamFilterGoPluginConfig should have comment or be unexported (golint)
  • Line 185: warning: exported type FilterChainConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/http2/buffer.go
  • Line 32: warning: exported type Http2BufferCtx should have comment or be unexported (golint)
  • Line 36: warning: exported method Http2BufferCtx.New should have comment or be unexported (golint)
  • Line 41: warning: exported method Http2BufferCtx.Reset should have comment or be unexported (golint)
  • Line 44: warning: exported type Http2Buffers should have comment or be unexported (golint)
  • Line 47: warning: exported function Http2BuffersByContext should have comment or be unexported (golint)

• sofa-mosn/pkg/streamfilter/factory.go
  • Line 74: warning: exported function CreateFactoryByPlugin should have comment or be unexported (golint)

• sofa-mosn/pkg/track/buffer.go
  • Line 43: warning: exported type TrackBuffer should have comment or be unexported (golint)
  • Line 59: warning: exported function TrackBufferByContext should have comment or be unexported (golint)
  • Line 69: warning: context.Context should be the first parameter of a function (golint)
  • Line 69: warning: exported function BindRequestAndResponse should have comment or be unexported (golint)

• sofa-mosn/pkg/types/keepalive.go
  • Line 22: warning: exported type KeepAlive should have comment or be unexported (golint)
  • Line 35: warning: exported type KeepAliveStatus should have comment or be unexported (golint)
  • Line 38: warning: exported const KeepAliveSuccess should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/test/lib/xprotocol/boltv1/client.go
  • Line 41: warning: exported function NewBoltClient should have comment or be unexported (golint)
  • Line 58: warning: exported method MockBoltClient.SyncCall should have comment or be unexported (golint)
  • Line 86: warning: comment on exported method MockBoltClient.AsyncCall should be of the form "AsyncCall ..." (golint)
  • Line 90: warning: exported method MockBoltClient.Stats should have comment or be unexported (golint)
  • Line 148: warning: exported type BoltConn should have comment or be unexported (golint)
  • Line 156: warning: exported function NewConn should have comment or be unexported (golint)
  • Line 181: warning: exported method BoltConn.OnEvent should have comment or be unexported (golint)
  • Line 190: warning: exported method BoltConn.Close should have comment or be unexported (golint)
  • Line 194: warning: exported method BoltConn.IsClosed should have comment or be unexported (golint)
  • Line 203: warning: exported method BoltConn.ReqID should have comment or be unexported (golint)
  • Line 207: warning: exported method BoltConn.AsyncSendRequest should have comment or be unexported (golint)
  • Line 218: warning: exported var ErrClosedConnection should have comment or be unexported (golint)
  • Line 222: warning: exported method BoltConn.SyncSendRequest should have comment or be unexported (golint)
  • Line 288: warning: exported type Response should have comment or be unexported (golint)
  • Line 294: warning: exported method Response.GetResponseStatus should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/regulator_interface.go
  • Line 20: warning: exported type Regulator should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/http/httputility.go
  • Line 27: warning: comment on exported function ParseQueryString should be of the form "ParseQueryString ..." (golint)

• sofa-mosn/pkg/protocol/xprotocol/engine.go
  • Line 78: warning: exported function NewXEngine should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/secret_manager.go
  • Line 37: warning: exported function RegisterSdsCallback should have comment or be unexported (golint)
  • Line 57: warning: exported function ClearSecretManager should have comment or be unexported (golint)

• sofa-mosn/pkg/wasm/abi/proxywasm010/imports.go
  • Line 35: warning: exported type DefaultImportsHandler should have comment or be unexported (golint)
  • Line 41: warning: comment on exported method DefaultImportsHandler.Log should be of the form "Log ..." (golint)
  • Line 82: warning: comment on exported method DefaultImportsHandler.HttpCall should be of the form "HttpCall ..." (golint)
  • Line 119: warning: comment on exported method DefaultImportsHandler.Wait should be of the form "Wait ..." (golint)
  • Line 141: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)
  • Line 178: warning: comment on exported method DefaultImportsHandler.GetHttpCallResponseHeaders should be of the form "GetHttpCallResponseHeaders ..." (golint)
  • Line 187: warning: comment on exported method DefaultImportsHandler.GetHttpCallResponseBody should be of the form "GetHttpCallResponseBody ..." (golint)

• sofa-mosn/pkg/router/factory.go
  • Line 33: warning: exported function RegisterMakeHandler should have comment or be unexported (golint)
  • Line 38: warning: exported function GetMakeHandlerFunc should have comment or be unexported (golint)
  • Line 42: warning: exported function MakeHandlerFuncExists should have comment or be unexported (golint)

• sofa-mosn/examples/codes/plugin/pluginfilter/pluginfilter.go
  • Line 112: warning: comment on exported function CreatePluginFilterFactory should be of the form "CreatePluginFilterFactory ..." (golint)

• sofa-mosn/examples/codes/tcpproxy-sample/rpc_client.go
  • Line 21: warning: exported type Client should have comment or be unexported (golint)
  • Line 28: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 45: warning: exported method Client.OnReceive should have comment or be unexported (golint)
  • Line 56: warning: exported method Client.OnDecodeError should have comment or be unexported (golint)
  • Line 58: warning: exported method Client.Request should have comment or be unexported (golint)

• sofa-mosn/pkg/metrics/sink/prometheus/prometheus_test.go
  • Line 480: warning: don't use underscores in Go names; var replace_msg should be replaceMsg (golint)

• sofa-mosn/pkg/trace/api.go
  • Line 32: warning: exported var ErrNoSuchDriver should have comment or be unexported (golint)
  • Line 43: warning: exported function SpanFromContext should have comment or be unexported (golint)
  • Line 52: warning: exported function Init should have comment or be unexported (golint)
  • Line 61: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 66: warning: exported function Enable should have comment or be unexported (golint)
  • Line 70: warning: exported function Disable should have comment or be unexported (golint)
  • Line 74: warning: exported function IsEnabled should have comment or be unexported (golint)
  • Line 78: warning: exported function Tracer should have comment or be unexported (golint)
  • Line 82: warning: exported function Driver should have comment or be unexported (golint)

• sofa-mosn/pkg/variable/types.go
  • Line 23: warning: exported const MOSN_VAR_FLAG_CHANGEABLE should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/types/xds.go
  • Line 60: warning: exported var ClusterID should have comment or be unexported (golint)
  • Line 77: warning: exported function InitXdsFlags should have comment or be unexported (golint)
  • Line 120: warning: exported type TrafficInterceptionMode should have comment or be unexported (golint)
  • Line 134: warning: exported type NodeType should have comment or be unexported (golint)
  • Line 147: warning: exported type XdsStats should have comment or be unexported (golint)
  • Line 154: warning: exported function IsApplicationNodeType should have comment or be unexported (golint)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/server.go
  • Line 14: warning: exported type Request should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/invocation_stat_factory.go
  • Line 27: warning: exported type InvocationStatFactory should have comment or be unexported (golint)
  • Line 34: warning: exported function GetInvocationStatFactoryInstance should have comment or be unexported (golint)
  • Line 38: warning: exported function NewInvocationStatFactory should have comment or be unexported (golint)
  • Line 46: warning: exported method InvocationStatFactory.GetInvocationStat should have comment or be unexported (golint)
  • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 61: warning: exported method InvocationStatFactory.ReleaseInvocationStat should have comment or be unexported (golint)

• sofa-mosn/pkg/metrics/sink/filter.go
  • Line 22: warning: exported type FlushFilter should have comment or be unexported (golint)
  • Line 30: warning: comment on exported function SetFilterLabels should be of the form "SetFilterLabels ..." (golint)
  • Line 38: warning: exported function SetFilterKeys should have comment or be unexported (golint)
  • Line 45: warning: comment on exported function IsExclusionLabels should be of the form "IsExclusionLabels ..." (golint)
  • Line 59: warning: exported function IsExclusionKeys should have comment or be unexported (golint)

• sofa-mosn/pkg/configmanager/featuregate.go
  • Line 25: warning: exported const ConfigAutoWrite should have comment or be unexported (golint)
  • Line 35: warning: exported method ConfigAutoFeature.InitFunc should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/flowcontrol/stream_filter.go
  • Line 35: warning: exported method StreamFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 39: warning: exported method StreamFilter.SetSenderFilterHandler should have comment or be unexported (golint)

• sofa-mosn/pkg/log/errorlog_test.go
  • Line 73: warning: don't use underscores in Go names; var alert_out should be alertOut (golint)

• sofa-mosn/pkg/module/http2/mhttp2.go
  • Line 33: warning: exported var ErrAGAIN should have comment or be unexported (golint)
  • Line 38: warning: comment on exported type MStream should be of the form "MStream ..." (with optional leading article) (golint)
  • Line 55: warning: comment on exported method MStream.WriteHeader should be of the form "WriteHeader ..." (golint)
  • Line 105: warning: exported method MStream.WriteData should have comment or be unexported (golint)
  • Line 172: warning: exported method MStream.WriteTrailers should have comment or be unexported (golint)
  • Line 180: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 206: warning: exported method MStream.Reset should have comment or be unexported (golint)
  • Line 212: warning: exported method MStream.SendResponse should have comment or be unexported (golint)
  • Line 224: warning: exported type MServerConn should have comment or be unexported (golint)
  • Line 233: warning: comment on exported function NewServerConn should be of the form "NewServerConn ..." (golint)
  • Line 458: warning: exported method MServerConn.HandleError should have comment or be unexported (golint)
  • Line 642: warning: don't use underscores in Go names; var url_ should be url (golint)
  • Line 979: warning: exported type MClientConn should have comment or be unexported (golint)
  • Line 1077: warning: exported function NewMClientStream should have comment or be unexported (golint)
  • Line 1201: warning: receiver name cs should be consistent with previous receiver name cc for MClientStream (golint)
  • Line 1231: warning: exported method MClientStream.Reset should have comment or be unexported (golint)
  • Line 1231: warning: receiver name ms should be consistent with previous receiver name cc for MClientStream (golint)
  • Line 1283: warning: exported method MClientConn.HandleError should have comment or be unexported (golint)
  • Line 1300: warning: comment on exported method MClientConn.HandleFrame should be of the form "HandleFrame ..." (golint)
  • Line 1301: warning: receiver name sc should be consistent with previous receiver name cc for MClientConn (golint)
  • Line 1628: warning: exported method MClientConn.Ping should have comment or be unexported (golint)
  • Line 1662: warning: exported method MClientConn.WritePing should have comment or be unexported (golint)
  • Line 1705: warning: receiver name sc should be consistent with previous receiver name cc for MClientConn (golint)
  • Line 1731: warning: exported type MFramer should have comment or be unexported (golint)
  • Line 1923: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 2050: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/filter/network/streamproxy/streamproxy.go
  • Line 55: warning: exported function NewProxy should have comment or be unexported (golint)
  • Line 265: warning: exported type IpRangeList should have comment or be unexported (golint)
  • Line 269: warning: exported method IpRangeList.Contains should have comment or be unexported (golint)
  • Line 296: warning: exported type PortRangeList should have comment or be unexported (golint)
  • Line 300: warning: exported method PortRangeList.Contains should have comment or be unexported (golint)
  • Line 328: warning: exported type PortRange should have comment or be unexported (golint)
  • Line 333: warning: exported function ParsePortRangeList should have comment or be unexported (golint)
  • Line 370: warning: exported function NewProxyConfig should have comment or be unexported (golint)
  • Line 486: warning: exported method LbContext.MetadataMatchCriteria should have comment or be unexported (golint)
  • Line 490: warning: exported method LbContext.DownstreamConnection should have comment or be unexported (golint)
  • Line 494: warning: comment on exported method LbContext.DownstreamHeaders should be of the form "DownstreamHeaders ..." (golint)
  • Line 499: warning: exported method LbContext.DownstreamContext should have comment or be unexported (golint)
  • Line 503: warning: exported method LbContext.DownstreamCluster should have comment or be unexported (golint)
  • Line 507: warning: exported method LbContext.DownstreamRoute should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/flowcontrol/callbacks.go
  • Line 50: warning: comment on exported function GetCallbacksByConfig should be of the form "GetCallbacksByConfig ..." (golint)
  • Line 85: warning: context.Context should be the first parameter of a function (golint)
  • Line 91: warning: context.Context should be the first parameter of a function (golint)
  • Line 106: warning: context.Context should be the first parameter of a function (golint)

• sofa-mosn/pkg/mtls/sds/subscriber.go
  • Line 20: warning: exported type SdsSubscriber should have comment or be unexported (golint)
  • Line 32: warning: exported type SdsStreamClient should have comment or be unexported (golint)
  • Line 39: warning: exported type SdsStreamConfig should have comment or be unexported (golint)
  • Line 45: warning: exported var SubscriberRetryPeriod should have comment or be unexported (golint)
  • Line 48: warning: exported function NewSdsSubscriber should have comment or be unexported (golint)
  • Line 61: warning: exported method SdsSubscriber.Start should have comment or be unexported (golint)
  • Line 85: warning: exported method SdsSubscriber.Stop should have comment or be unexported (golint)
  • Line 90: warning: exported method SdsSubscriber.SendSdsRequest should have comment or be unexported (golint)
  • Line 251: warning: exported function ACKResponse should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/tls_context.go
  • Line 139: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 178: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/upstream/cluster/host.go
  • Line 48: warning: exported function NewSimpleHost should have comment or be unexported (golint)
  • Line 178: warning: comment on exported var AddrStore should be of the form "AddrStore ..." (golint)
  • Line 189: warning: exported function GetOrCreateAddr should have comment or be unexported (golint)
  • Line 237: warning: comment on exported var UDPAddrStore should be of the form "UDPAddrStore ..." (golint)
  • Line 247: warning: exported function GetOrCreateUDPAddr should have comment or be unexported (golint)

• sofa-mosn/test/util/config.go
  • Line 17: warning: exported function CurrentMeshAddr should have comment or be unexported (golint)
  • Line 23: warning: comment on exported function CreateProxyMesh should be of the form "CreateProxyMesh ..." (golint)
  • Line 42: warning: comment on exported function CreateMeshToMeshConfig should be of the form "CreateMeshToMeshConfig ..." (golint)
  • Line 51: warning: comment on exported function CreateMeshToMeshConfigWithSub should be of the form "CreateMeshToMeshConfigWithSub ..." (golint)
  • Line 116: warning: comment on exported function CreateXProtocolProxyMesh should be of the form "CreateXProtocolProxyMesh ..." (golint)
  • Line 135: warning: comment on exported function CreateXProtocolMesh should be of the form "CreateXProtocolMesh ..." (golint)
  • Line 183: warning: comment on exported type ExtendVerifyConfig should be of the form "ExtendVerifyConfig ..." (with optional leading article) (golint)
  • Line 189: warning: exported function CreateTLSExtensionConfig should have comment or be unexported (golint)
  • Line 230: warning: exported function CreateXprotocolTLSExtensionConfig should have comment or be unexported (golint)
  • Line 271: warning: comment on exported function CreateTCPProxyConfig should be of the form "CreateTCPProxyConfig ..." (golint)
  • Line 313: warning: exported type WeightCluster should have comment or be unexported (golint)
  • Line 318: warning: exported type WeightHost should have comment or be unexported (golint)
  • Line 323: warning: comment on exported function CreateXWeightProxyMesh should be of the form "CreateXWeightProxyMesh ..." (golint)

• sofa-mosn/examples/codes/sofarpc-with-xprotocol-sample/client.go
  • Line 21: warning: exported type Client should have comment or be unexported (golint)
  • Line 28: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 45: warning: exported method Client.OnReceive should have comment or be unexported (golint)
  • Line 56: warning: exported method Client.OnDecodeError should have comment or be unexported (golint)
  • Line 58: warning: exported method Client.Request should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/listener/originaldst/factory.go
  • Line 37: warning: comment on exported function NewOriginalDst should be of the form "NewOriginalDst ..." (golint)
  • Line 43: warning: exported function CreateOriginalDstFactory should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/send_filter.go
  • Line 29: warning: exported type SendFilter should have comment or be unexported (golint)
  • Line 35: warning: exported function NewSendFilter should have comment or be unexported (golint)
  • Line 43: warning: exported method SendFilter.Append should have comment or be unexported (golint)
  • Line 64: warning: exported method SendFilter.SetSenderFilterHandler should have comment or be unexported (golint)
  • Line 68: warning: exported method SendFilter.OnDestroy should have comment or be unexported (golint)
  • Line 72: warning: exported method SendFilter.IsException should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/mirror/registry.go
  • Line 20: warning: exported function NewMirrorConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/skywalking/span.go
  • Line 35: warning: exported var NoopSpan should have comment or be unexported (golint)
  • Line 37: warning: exported type SkySpan should have comment or be unexported (golint)
  • Line 40: warning: exported method SkySpan.SpanId should have comment or be unexported (golint)
  • Line 44: warning: exported method SkySpan.ParentSpanId should have comment or be unexported (golint)
  • Line 48: warning: exported method SkySpan.SetOperation should have comment or be unexported (golint)
  • Line 52: warning: exported method SkySpan.SetTag should have comment or be unexported (golint)
  • Line 56: warning: exported method SkySpan.Tag should have comment or be unexported (golint)
  • Line 61: warning: exported method SkySpan.SpawnChild should have comment or be unexported (golint)

• sofa-mosn/pkg/admin/server/server_test.go
  • Line 58: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 76: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 93: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 315: warning: don't use underscores in Go names; var expected_string should be expectedString (golint)

• sofa-mosn/pkg/protocol/xprotocol/mapping.go
  • Line 30: warning: exported var ErrNoSubProtocolFound should have comment or be unexported (golint)

• sofa-mosn/pkg/proxy/types.go
  • Line 26: warning: comment on exported type Proxy should be of the form "Proxy ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported type UpstreamCallbacks should be of the form "UpstreamCallbacks ..." (with optional leading article) (golint)
  • Line 45: warning: comment on exported type Timeout should be of the form "Timeout ..." (with optional leading article) (golint)
  • Line 51: warning: comment on exported type UpstreamFailureReason should be of the form "UpstreamFailureReason ..." (with optional leading article) (golint)

• sofa-mosn/pkg/router/configutility.go
  • Line 40: warning: exported method StringMatch.Matches should have comment or be unexported (golint)
  • Line 58: warning: exported method KeyValueData.Key should have comment or be unexported (golint)
  • Line 62: warning: exported method KeyValueData.MatchType should have comment or be unexported (golint)
  • Line 69: warning: exported method KeyValueData.Matcher should have comment or be unexported (golint)
  • Line 73: warning: exported function NewKeyValueData should have comment or be unexported (golint)
  • Line 135: warning: exported function CreateCommonHeaderMatcher should have comment or be unexported (golint)
  • Line 233: warning: comment on exported function NewMetadataMatchCriteriaImpl should be of the form "NewMetadataMatchCriteriaImpl ..." (golint)
  • Line 248: warning: comment on exported method MetadataMatchCriteriaImpl.MetadataMatchCriteria should be of the form "MetadataMatchCriteria ..." (golint)
  • Line 253: warning: comment on exported method MetadataMatchCriteriaImpl.MergeMatchCriteria should be of the form "MergeMatchCriteria ..." (golint)

• sofa-mosn/pkg/module/http2/errors.go
  • Line 16: warning: exported const ErrCodeNo should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/examples/codes/mosn-extensions/simple_streamfilter/simple.go
  • Line 17: warning: exported function CreateDemoFactory should have comment or be unexported (golint)
  • Line 28: warning: comment on exported type DemoFactory should be of the form "DemoFactory ..." (with optional leading article) (golint)
  • Line 33: warning: exported method DemoFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 43: warning: comment on exported type DemoFilter should be of the form "DemoFilter ..." (with optional leading article) (golint)
  • Line 58: warning: exported method DemoFilter.OnReceive should have comment or be unexported (golint)
  • Line 77: warning: exported method DemoFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 81: warning: exported method DemoFilter.OnDestroy should have comment or be unexported (golint)

• sofa-mosn/pkg/cel/attribute/bag.go
  • Line 28: warning: exported var EmptyBag should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/sds/sdsclient.go
  • Line 30: warning: exported type SdsClientImpl should have comment or be unexported (golint)
  • Line 41: warning: exported var ErrSdsClientNotInit should have comment or be unexported (golint)
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 63: warning: exported function CloseSdsClient should have comment or be unexported (golint)
  • Line 74: warning: exported method SdsClientImpl.AddUpdateCallback should have comment or be unexported (golint)
  • Line 83: warning: comment on exported method SdsClientImpl.DeleteUpdateCallback should be of the form "DeleteUpdateCallback ..." (golint)
  • Line 103: warning: comment on exported function SetSdsPostCallback should be of the form "SetSdsPostCallback ..." (golint)

• sofa-mosn/pkg/protocol/xprotocol/dubbothrift/types.go
  • Line 26: warning: exported const ProtocolName should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported const EventRequest should have comment (or a comment on this block) or be unexported (golint)
  • Line 52: warning: exported const ServiceNameHeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 59: warning: exported const ResponseStatusSuccess should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/xds/conv/convertutils.go
  • Line 32: warning: exported function GetHTTPConnectionManager should have comment or be unexported (golint)
  • Line 41: warning: exported function GetTcpProxy should have comment or be unexported (golint)
  • Line 50: warning: exported function GetAccessLog should have comment or be unexported (golint)
  • Line 67: warning: exported function ConvertDuration should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/write.go
  • Line 246: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 295: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/filter/stream/payloadlimit/factory.go
  • Line 33: warning: exported type FilterConfigFactory should have comment or be unexported (golint)
  • Line 37: warning: exported method FilterConfigFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 42: warning: exported function CreatePayloadLimitFilterFactory should have comment or be unexported (golint)
  • Line 51: warning: comment on exported function ParseStreamPayloadLimitFilter should be of the form "ParseStreamPayloadLimitFilter ..." (golint)

• sofa-mosn/pkg/filter/stream/stats/config.go
  • Line 24: warning: comment on exported type StatsConfig should be of the form "StatsConfig ..." (with optional leading article) (golint)
  • Line 47: warning: exported type MetricConfig should have comment or be unexported (golint)
  • Line 59: warning: exported type MetricDefinition should have comment or be unexported (golint)
  • Line 68: warning: exported type MetricType should have comment or be unexported (golint)
  • Line 71: warning: exported const MetricTypeCounter should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/log/proxylog.go
  • Line 36: warning: exported function CreateDefaultContextLogger should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/conv.go
  • Line 31: warning: exported var ErrNotFound should have comment or be unexported (golint)
  • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/types/tls.go
  • Line 30: warning: exported type HashValue should have comment or be unexported (golint)
  • Line 34: warning: exported function NewHashValue should have comment or be unexported (golint)
  • Line 40: warning: exported method HashValue.Equal should have comment or be unexported (golint)
  • Line 76: warning: exported function NewTLSConfigContext should have comment or be unexported (golint)
  • Line 118: warning: exported type SdsSecret should have comment or be unexported (golint)
  • Line 125: warning: exported type SdsUpdateCallbackFunc should have comment or be unexported (golint)
  • Line 127: warning: exported type SdsClient should have comment or be unexported (golint)
  • Line 133: warning: exported type SecretProvider should have comment or be unexported (golint)
  • Line 137: warning: exported function SecretConvert should have comment or be unexported (golint)

• sofa-mosn/pkg/proxy/upstream.go
  • Line 199: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 231: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 264: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/protocol/xprotocol/bolt/types.go
  • Line 68: warning: comment on exported const UnKnownCmdType should be of the form "UnKnownCmdType ..." (golint)
  • Line 70: warning: exported const UnKnownCmdCode should have comment (or a comment on this block) or be unexported (golint)
  • Line 72: warning: comment on exported const SofaRPC should be of the form "SofaRPC ..." (golint)
  • Line 82: warning: comment on exported var ErrUnKnownCmdType should be of the form "ErrUnKnownCmdType ..." (golint)
  • Line 84: warning: exported var ErrUnKnownCmdCode should have comment or be unexported (golint)
  • Line 87: warning: comment on exported var DefaultSofaRPCHealthCheckConf should be of the form "DefaultSofaRPCHealthCheckConf ..." (golint)

• sofa-mosn/pkg/config/v2/upstream.go
  • Line 33: warning: exported type HealthCheckConfig should have comment or be unexported (golint)
  • Line 45: warning: exported type HostConfig should have comment or be unexported (golint)
  • Line 53: warning: comment on exported type ClusterType should be of the form "ClusterType ..." (with optional leading article) (golint)
  • Line 66: warning: comment on exported type LbType should be of the form "LbType ..." (with optional leading article) (golint)
  • Line 78: warning: exported type DnsLookupFamily should have comment or be unexported (golint)
  • Line 81: warning: exported const V4Only should have comment (or a comment on this block) or be unexported (golint)
  • Line 111: warning: exported type DnsResolverConfig should have comment or be unexported (golint)
  • Line 129: warning: comment on exported method HealthCheck.MarshalJSON should be of the form "MarshalJSON ..." (golint)
  • Line 137: warning: exported method HealthCheck.UnmarshalJSON should have comment or be unexported (golint)
  • Line 153: warning: exported method Host.MarshalJSON should have comment or be unexported (golint)
  • Line 158: warning: exported method Host.UnmarshalJSON should have comment or be unexported (golint)
  • Line 172: warning: comment on exported method CircuitBreakers.MarshalJSON should be of the form "MarshalJSON ..." (golint)
  • Line 176: warning: exported method CircuitBreakers.UnmarshalJSON should have comment or be unexported (golint)
  • Line 180: warning: exported type Thresholds should have comment or be unexported (golint)
  • Line 218: warning: exported type ClusterManagerConfigJson should have comment or be unexported (golint)
  • Line 224: warning: exported method ClusterManagerConfig.UnmarshalJSON should have comment or be unexported (golint)
  • Line 259: warning: comment on exported method ClusterManagerConfig.MarshalJSON should be of the form "MarshalJSON ..." (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter/metadata/metadata.go
  • Line 30: warning: exported type MetadataFilter should have comment or be unexported (golint)
  • Line 42: warning: exported method MetadataFilter.OnReceive should have comment or be unexported (golint)
  • Line 58: warning: exported method MetadataFilter.Append should have comment or be unexported (golint)
  • Line 63: warning: exported method MetadataFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 66: warning: exported method MetadataFilter.OnDestroy should have comment or be unexported (golint)
  • Line 68: warning: exported method MetadataFilter.Log should have comment or be unexported (golint)

• sofa-mosn/pkg/plugin/plugin.go
  • Line 14: warning: exported function InitPlugin should have comment or be unexported (golint)
  • Line 21: warning: exported function GetLogPath should have comment or be unexported (golint)
  • Line 33: warning: exported var Handshake should have comment or be unexported (golint)
  • Line 39: warning: exported var PluginMap should have comment or be unexported (golint)
  • Line 43: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 52: warning: exported method Plugin.GRPCServer should have comment or be unexported (golint)
  • Line 57: warning: exported method Plugin.GRPCClient should have comment or be unexported (golint)

• sofa-mosn/pkg/types/proxy.go
  • Line 25: warning: exported var ErrExit should have comment or be unexported (golint)
  • Line 48: warning: exported type Phase should have comment or be unexported (golint)
  • Line 51: warning: exported const InitPhase should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/router/variable_rule.go
  • Line 31: warning: exported type Model should have comment or be unexported (golint)
  • Line 34: warning: exported const AND should have comment (or a comment on this block) or be unexported (golint)
  • Line 38: warning: exported type VariableRouteRuleImpl should have comment or be unexported (golint)
  • Line 43: warning: exported method VariableRouteRuleImpl.HeaderMatchCriteria should have comment or be unexported (golint)
  • Line 47: warning: exported method VariableRouteRuleImpl.PathMatchCriterion should have comment or be unexported (golint)
  • Line 51: warning: exported method VariableRouteRuleImpl.RouteRule should have comment or be unexported (golint)
  • Line 55: warning: exported method VariableRouteRuleImpl.Matcher should have comment or be unexported (golint)
  • Line 59: warning: exported method VariableRouteRuleImpl.MatchType should have comment or be unexported (golint)
  • Line 63: warning: exported method VariableRouteRuleImpl.FinalizeRequestHeaders should have comment or be unexported (golint)
  • Line 66: warning: exported method VariableRouteRuleImpl.Match should have comment or be unexported (golint)
  • Line 108: warning: exported type VariableMatchItem should have comment or be unexported (golint)
  • Line 115: warning: exported function ParseToVariableMatchItem should have comment or be unexported (golint)

• sofa-mosn/pkg/buffer/buffer_test.go
  • Line 29: warning: don't use underscores in Go names; type mock_bufferctx should be mockBufferctx (golint)
  • Line 42: warning: don't use underscores in Go names; type mock_buffers should be mockBuffers (golint)
  • Line 46: warning: don't use underscores in Go names; func mock_BuffersByContext should be mockBuffersByContext (golint)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/codec/mapping.go
  • Line 28: warning: exported type StatusMapping should have comment or be unexported (golint)
  • Line 30: warning: exported method StatusMapping.MappingHeaderStatusCode should have comment or be unexported (golint)

• sofa-mosn/pkg/mosn/stage_manager.go
  • Line 62: warning: exported function NewStageManager should have comment or be unexported (golint)
  • Line 77: warning: exported method StageManager.AppendParamsParsedStage should have comment or be unexported (golint)
  • Line 96: warning: exported method StageManager.AppendInitStage should have comment or be unexported (golint)
  • Line 115: warning: exported method StageManager.AppendPreStartStage should have comment or be unexported (golint)
  • Line 132: warning: exported method StageManager.AppendStartStage should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/metrics.go
  • Line 25: warning: exported type TLSStats should have comment or be unexported (golint)
  • Line 29: warning: exported function NewStats should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/sofa/xprotocol/tracer.go
  • Line 37: warning: exported var PrintLog should have comment or be unexported (golint)
  • Line 39: warning: exported type Tracer should have comment or be unexported (golint)
  • Line 41: warning: exported function NewTracer should have comment or be unexported (golint)
  • Line 61: warning: exported method Tracer.Start should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/servicediscovery/dubbod/pub.go
  • Line 1: warning: package comment should be of the form "Package dubbod ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/upstream/cluster/resource_manager.go
  • Line 43: warning: exported function NewResourceManager should have comment or be unexported (golint)

• sofa-mosn/pkg/wasm/abi/proxywasm010/shim.go
  • Line 32: warning: exported method HeaderMapWrapper.Clone should have comment or be unexported (golint)
  • Line 41: warning: exported method HeaderMapWrapperBack.Clone should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/send_filter_factory.go
  • Line 36: warning: exported type SendFilterFactory should have comment or be unexported (golint)
  • Line 41: warning: exported method SendFilterFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 46: warning: exported function CreateSendFilterFactory should have comment or be unexported (golint)
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/work_pool_interface.go
  • Line 20: warning: exported type WorkPool should have comment or be unexported (golint)

• sofa-mosn/pkg/configmanager/effectiveconfig.go
  • Line 50: warning: exported function Reset should have comment or be unexported (golint)
  • Line 61: warning: exported function SetMosnConfig should have comment or be unexported (golint)
  • Line 110: warning: exported function SetHosts should have comment or be unexported (golint)
  • Line 120: warning: exported function SetRouter should have comment or be unexported (golint)
  • Line 132: warning: exported function SetExtend should have comment or be unexported (golint)
  • Line 153: warning: exported function SetClusterManagerTLS should have comment or be unexported (golint)
  • Line 168: warning: exported const CfgTypeMOSN should have comment (or a comment on this block) or be unexported (golint)
  • Line 192: warning: exported function HandleMOSNConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/metrics/nilmetrics.go
  • Line 31: warning: exported function NewNilMetrics should have comment or be unexported (golint)
  • Line 40: warning: exported method NilMetrics.Counter should have comment or be unexported (golint)
  • Line 44: warning: exported method NilMetrics.Gauge should have comment or be unexported (golint)
  • Line 48: warning: exported method NilMetrics.Histogram should have comment or be unexported (golint)
  • Line 52: warning: exported method NilMetrics.Each should have comment or be unexported (golint)
  • Line 56: warning: exported method NilMetrics.UnregisterAll should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/sds.go
  • Line 28: warning: exported function GetSdsClient should have comment or be unexported (golint)

• sofa-mosn/pkg/track/const.go
  • Line 20: warning: exported type TrackPhase should have comment or be unexported (golint)
  • Line 22: warning: exported const MaxServedField should have comment or be unexported (golint)
  • Line 24: warning: exported const NoTrack should have comment or be unexported (golint)
  • Line 27: warning: comment on exported const ProtocolDecode should be of the form "ProtocolDecode ..." (golint)
  • Line 29: warning: exported const StreamFilterBeforeRoute should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: comment on exported const MaxTrackPhase should be of the form "MaxTrackPhase ..." (golint)
  • Line 41: warning: exported type TimestampPhase should have comment or be unexported (golint)
  • Line 44: warning: exported const RequestStartTimestamp should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/track/controller.go
  • Line 24: warning: exported function TrackEnabled should have comment or be unexported (golint)
  • Line 28: warning: exported function EnableTrack should have comment or be unexported (golint)
  • Line 32: warning: exported function DisableTrack should have comment or be unexported (golint)

• sofa-mosn/pkg/router/base_rule.go
  • Line 43: warning: exported type RouteRuleImplBase should have comment or be unexported (golint)
  • Line 74: warning: exported function NewRouteRuleImplBase should have comment or be unexported (golint)
  • Line 190: warning: exported method RouteRuleImplBase.VirtualHost should have comment or be unexported (golint)
  • Line 194: warning: exported method RouteRuleImplBase.DirectResponseRule should have comment or be unexported (golint)
  • Line 198: warning: exported method RouteRuleImplBase.RedirectRule should have comment or be unexported (golint)
  • Line 205: warning: comment on exported method RouteRuleImplBase.ClusterName should be of the form "ClusterName ..." (golint)
  • Line 228: warning: exported method RouteRuleImplBase.UpstreamProtocol should have comment or be unexported (golint)
  • Line 232: warning: exported method RouteRuleImplBase.GlobalTimeout should have comment or be unexported (golint)
  • Line 236: warning: exported method RouteRuleImplBase.Policy should have comment or be unexported (golint)
  • Line 240: warning: exported method RouteRuleImplBase.MetadataMatchCriteria should have comment or be unexported (golint)
  • Line 254: warning: exported method RouteRuleImplBase.PerFilterConfig should have comment or be unexported (golint)
  • Line 258: warning: exported method RouteRuleImplBase.FinalizePathHeader should have comment or be unexported (golint)
  • Line 300: warning: exported method RouteRuleImplBase.FinalizeRequestHeaders should have comment or be unexported (golint)
  • Line 321: warning: exported method RouteRuleImplBase.FinalizeResponseHeaders should have comment or be unexported (golint)

• sofa-mosn/pkg/featuregate/default.go
  • Line 26: warning: exported function Enabled should have comment or be unexported (golint)
  • Line 30: warning: exported function Subscribe should have comment or be unexported (golint)
  • Line 34: warning: exported function Set should have comment or be unexported (golint)
  • Line 38: warning: exported function SetFromMap should have comment or be unexported (golint)
  • Line 42: warning: exported function AddFeatureSpec should have comment or be unexported (golint)
  • Line 46: warning: exported function SetFeatureState should have comment or be unexported (golint)
  • Line 50: warning: exported function KnownFeatures should have comment or be unexported (golint)
  • Line 54: warning: exported function ExecuteInitFunc should have comment or be unexported (golint)
  • Line 58: warning: exported function FinallyInitFunc should have comment or be unexported (golint)
  • Line 62: warning: exported function WaitInitFinsh should have comment or be unexported (golint)

• sofa-mosn/pkg/cel/extract/attributes_builder.go
  • Line 41: warning: exported function ExtractAttributes should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/default_regulator.go
  • Line 26: warning: exported type DefaultRegulator should have comment or be unexported (golint)
  • Line 32: warning: exported function NewDefaultRegulator should have comment or be unexported (golint)
  • Line 41: warning: exported method DefaultRegulator.Regulate should have comment or be unexported (golint)
  • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 58: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/mosn/init.go
  • Line 41: warning: comment on exported function InitDebugServe should be of the form "InitDebugServe ..." (golint)
  • Line 54: warning: comment on exported function InitializeTracing should be of the form "InitializeTracing ..." (golint)
  • Line 75: warning: exported function InitializeMetrics should have comment or be unexported (golint)
  • Line 102: warning: exported function InitializePidFile should have comment or be unexported (golint)
  • Line 110: warning: exported function InitializePlugin should have comment or be unexported (golint)
  • Line 121: warning: exported function InitializeWasm should have comment or be unexported (golint)
  • Line 132: warning: exported function InitializeThirdPartCodec should have comment or be unexported (golint)
  • Line 164: warning: exported const DefaultLoaderFunctionName should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/upstream/servicediscovery/dubbod/bootstrap.go
  • Line 1: warning: package comment should be of the form "Package dubbod ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/xds/v2/factory.go
  • Line 24: warning: exported function RegisterTypeURLHandleFunc should have comment or be unexported (golint)
  • Line 31: warning: exported function HandleTypeURL should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/loadbalancer_test.go
  • Line 172: warning: don't use underscores in Go names; struct field max_weight should be maxWeight (golint)
  • Line 217: warning: don't use underscores in Go names; struct field max_weight should be maxWeight (golint)

• sofa-mosn/pkg/protocol/xprotocol/bolt/command.go
  • Line 44: warning: comment on exported method RequestHeader.Clone should be of the form "Clone ..." (golint)
  • Line 73: warning: comment on exported method Request.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 78: warning: exported method Request.SetRequestId should have comment or be unexported (golint)
  • Line 82: warning: exported method Request.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 86: warning: exported method Request.GetTimeout should have comment or be unexported (golint)
  • Line 90: warning: exported method Request.GetStreamType should have comment or be unexported (golint)
  • Line 101: warning: exported method Request.GetHeader should have comment or be unexported (golint)
  • Line 105: warning: exported method Request.GetData should have comment or be unexported (golint)
  • Line 109: warning: exported method Request.SetData should have comment or be unexported (golint)
  • Line 117: warning: comment on exported type ResponseHeader should be of the form "ResponseHeader ..." (with optional leading article) (golint)
  • Line 134: warning: comment on exported method ResponseHeader.Clone should be of the form "Clone ..." (golint)
  • Line 163: warning: comment on exported method Response.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 168: warning: exported method Response.SetRequestId should have comment or be unexported (golint)
  • Line 172: warning: exported method Response.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 176: warning: comment on exported method Response.GetTimeout should be of the form "GetTimeout ..." (golint)
  • Line 181: warning: exported method Response.GetStreamType should have comment or be unexported (golint)
  • Line 185: warning: exported method Response.GetHeader should have comment or be unexported (golint)
  • Line 189: warning: exported method Response.GetData should have comment or be unexported (golint)
  • Line 193: warning: exported method Response.SetData should have comment or be unexported (golint)
  • Line 201: warning: exported method Response.GetStatusCode should have comment or be unexported (golint)

• sofa-mosn/pkg/plugin/client.go
  • Line 47: warning: exported type Config should have comment or be unexported (golint)
  • Line 104: warning: exported method Client.Status should have comment or be unexported (golint)
  • Line 120: warning: exported method Client.Check should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/protocol.go
  • Line 54: warning: exported function NewWasmRpcProtocol should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/server.go
  • Line 2024: warning: don't use underscores in Go names; var url_ should be url (golint)
  • Line 2619: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/module/http2/server_test.go
  • Line 1360: warning: don't use underscores in Go names; func testServer_RSTStream_Unblocks_Header_Write should be testServerRSTStreamUnblocksHeaderWrite (golint)

• sofa-mosn/pkg/featuregate/types.go
  • Line 24: warning: exported type Feature should have comment or be unexported (golint)
  • Line 29: warning: comment on exported const Alpha should be of the form "Alpha ..." (golint)
  • Line 31: warning: exported const Beta should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported type FeatureSpec should have comment or be unexported (golint)
  • Line 51: warning: exported var ErrInited should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/header.go
  • Line 22: warning: comment on exported type BytesKV should be of the form "BytesKV ..." (with optional leading article) (golint)
  • Line 25: warning: exported type Header should have comment or be unexported (golint)

• sofa-mosn/pkg/wasm/abi/proxywasm010/factory.go
  • Line 30: warning: exported function ABIContextFactory should have comment or be unexported (golint)
  • Line 45: warning: comment on exported method ABIContext.GetABIImports should be of the form "GetABIImports ..." (golint)
  • Line 50: warning: exported method ABIContext.SetABIImports should have comment or be unexported (golint)
  • Line 56: warning: exported method ABIContext.GetABIExports should have comment or be unexported (golint)
  • Line 60: warning: comment on exported method ABIContext.OnInstanceCreate should be of the form "OnInstanceCreate ..." (golint)
  • Line 65: warning: exported method ABIContext.OnInstanceStart should have comment or be unexported (golint)
  • Line 67: warning: exported method ABIContext.OnInstanceDestroy should have comment or be unexported (golint)

• sofa-mosn/pkg/wasm/manager.go
  • Line 32: warning: exported var ErrEmptyPluginName should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/subset_loadbalancer.go
  • Line 38: warning: exported function NewSubsetLoadBalancer should have comment or be unexported (golint)
  • Line 211: warning: comment on exported function ExtractSubsetMetadata should be of the form "ExtractSubsetMetadata ..." (golint)
  • Line 227: warning: exported function CreateSubset should have comment or be unexported (golint)
  • Line 239: warning: exported function HostMatches should have comment or be unexported (golint)
  • Line 250: warning: exported type LBSubsetEntryImpl should have comment or be unexported (golint)
  • Line 256: warning: exported method LBSubsetEntryImpl.Initialized should have comment or be unexported (golint)
  • Line 260: warning: exported method LBSubsetEntryImpl.Active should have comment or be unexported (golint)
  • Line 264: warning: exported method LBSubsetEntryImpl.HostNum should have comment or be unexported (golint)
  • Line 271: warning: exported method LBSubsetEntryImpl.Children should have comment or be unexported (golint)
  • Line 275: warning: exported method LBSubsetEntryImpl.CreateLoadBalancer should have comment or be unexported (golint)
  • Line 281: warning: exported method LBSubsetEntryImpl.LoadBalancer should have comment or be unexported (golint)
  • Line 285: warning: exported type LBSubsetInfoImpl should have comment or be unexported (golint)
  • Line 292: warning: exported method LBSubsetInfoImpl.IsEnabled should have comment or be unexported (golint)
  • Line 296: warning: exported method LBSubsetInfoImpl.FallbackPolicy should have comment or be unexported (golint)
  • Line 300: warning: exported method LBSubsetInfoImpl.DefaultSubset should have comment or be unexported (golint)
  • Line 304: warning: exported method LBSubsetInfoImpl.SubsetKeys should have comment or be unexported (golint)
  • Line 308: warning: exported function NewLBSubsetInfo should have comment or be unexported (golint)
  • Line 329: warning: exported function GenerateSubsetKeys should have comment or be unexported (golint)

• sofa-mosn/pkg/router/dsl_rule.go
  • Line 17: warning: exported type DslExpressionRouteRuleImpl should have comment or be unexported (golint)
  • Line 23: warning: exported method DslExpressionRouteRuleImpl.HeaderMatchCriteria should have comment or be unexported (golint)
  • Line 27: warning: exported method DslExpressionRouteRuleImpl.PathMatchCriterion should have comment or be unexported (golint)
  • Line 31: warning: exported method DslExpressionRouteRuleImpl.RouteRule should have comment or be unexported (golint)
  • Line 35: warning: exported method DslExpressionRouteRuleImpl.Matcher should have comment or be unexported (golint)
  • Line 39: warning: exported method DslExpressionRouteRuleImpl.MatchType should have comment or be unexported (golint)
  • Line 43: warning: exported method DslExpressionRouteRuleImpl.FinalizeRequestHeaders should have comment or be unexported (golint)
  • Line 46: warning: exported method DslExpressionRouteRuleImpl.Match should have comment or be unexported (golint)

• sofa-mosn/examples/codes/proxy-fallback-example/httpserver.go
  • Line 8: warning: exported function ServeHTTP should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/payloadlimit/payloadlimit.go
  • Line 27: warning: exported function NewFilter should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/boltv2/command.go
  • Line 27: warning: exported type RequestHeader should have comment or be unexported (golint)
  • Line 51: warning: comment on exported method Request.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 56: warning: exported method Request.SetRequestId should have comment or be unexported (golint)
  • Line 60: warning: exported method Request.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 64: warning: exported method Request.GetTimeout should have comment or be unexported (golint)
  • Line 68: warning: exported method Request.GetStreamType should have comment or be unexported (golint)
  • Line 79: warning: exported method Request.GetHeader should have comment or be unexported (golint)
  • Line 83: warning: exported method Request.GetData should have comment or be unexported (golint)
  • Line 87: warning: exported method Request.SetData should have comment or be unexported (golint)
  • Line 95: warning: exported type ResponseHeader should have comment or be unexported (golint)
  • Line 119: warning: comment on exported method Response.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 124: warning: exported method Response.SetRequestId should have comment or be unexported (golint)
  • Line 128: warning: exported method Response.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 132: warning: comment on exported method Response.GetTimeout should be of the form "GetTimeout ..." (golint)
  • Line 137: warning: exported method Response.GetStreamType should have comment or be unexported (golint)
  • Line 141: warning: exported method Response.GetHeader should have comment or be unexported (golint)
  • Line 145: warning: exported method Response.GetData should have comment or be unexported (golint)
  • Line 149: warning: exported method Response.SetData should have comment or be unexported (golint)
  • Line 157: warning: exported method Response.GetStatusCode should have comment or be unexported (golint)

• sofa-mosn/test/lib/framework_wrapper.go
  • Line 13: warning: exported type Config should have comment or be unexported (golint)

• sofa-mosn/test/lib/utils/fasthttp.go
  • Line 5: warning: exported function ReadFasthttpResponseHeaders should have comment or be unexported (golint)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/codec/api.go
  • Line 67: warning: exported type Codec should have comment or be unexported (golint)
  • Line 75: warning: exported method Codec.ProtocolName should have comment or be unexported (golint)
  • Line 79: warning: exported method Codec.XProtocol should have comment or be unexported (golint)
  • Line 83: warning: exported method Codec.ProtocolMatch should have comment or be unexported (golint)
  • Line 87: warning: exported method Codec.HTTPMapping should have comment or be unexported (golint)
  • Line 91: warning: comment on exported function LoadCodec should be of the form "LoadCodec ..." (golint)

• sofa-mosn/pkg/protocol/types.go
  • Line 102: warning: exported method CommonHeader.ByteSize should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/sofa/xprotocol/factory.go
  • Line 26: warning: exported function RegisterSubProtocol should have comment or be unexported (golint)

• sofa-mosn/test/cases/extends/route_handler.go
  • Line 35: warning: exported function MakeExtendHandler should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/crypto/tls/common.go
  • Line 27: warning: exported const VersionSSL30 should have comment (or a comment on this block) or be unexported (golint)
  • Line 114: warning: exported const CurveP256 should have comment (or a comment on this block) or be unexported (golint)
  • Line 241: warning: exported const NoClientCert should have comment (or a comment on this block) or be unexported (golint)
  • Line 299: warning: comment on exported const PKCS1WithSHA256 should be of the form "PKCS1WithSHA256 ..." (golint)
  • Line 301: warning: exported const PKCS1WithSHA384 should have comment (or a comment on this block) or be unexported (golint)
  • Line 304: warning: comment on exported const PSSWithSHA256 should be of the form "PSSWithSHA256 ..." (golint)
  • Line 309: warning: comment on exported const ECDSAWithP256AndSHA256 should be of the form "ECDSAWithP256AndSHA256 ..." (golint)
  • Line 314: warning: comment on exported const PKCS1WithSHA1 should be of the form "PKCS1WithSHA1 ..." (golint)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_client.go
  • Line 57: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/module/http2/transport.go
  • Line 396: warning: exported var ErrNoCachedConn should have comment or be unexported (golint)
  • Line 407: warning: exported method Transport.RoundTrip should have comment or be unexported (golint)
  • Line 604: warning: exported method Transport.NewClientConn should have comment or be unexported (golint)
  • Line 957: warning: exported method ClientConn.RoundTrip should have comment or be unexported (golint)
  • Line 1388: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/server/keeper/serverkeeper.go
  • Line 53: warning: exported function SetPid should have comment or be unexported (golint)
  • Line 66: warning: exported function WritePidFile should have comment or be unexported (golint)
  • Line 163: warning: exported function ExecuteShutdownCallbacks should have comment or be unexported (golint)
  • Line 187: warning: exported function OnProcessExit should have comment or be unexported (golint)
  • Line 191: warning: exported function OnProcessShutDown should have comment or be unexported (golint)
  • Line 204: warning: exported function AddSignalCallback should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/network/grpc/listener.go
  • Line 35: warning: exported function NewListener should have comment or be unexported (golint)
  • Line 54: warning: exported method Listener.Accept should have comment or be unexported (golint)
  • Line 62: warning: exported method Listener.Addr should have comment or be unexported (golint)
  • Line 66: warning: exported method Listener.Close should have comment or be unexported (golint)
  • Line 74: warning: exported method Listener.NewConnection should have comment or be unexported (golint)

• sofa-mosn/pkg/config/v2/config.go
  • Line 55: warning: comment on exported type TracingConfig should be of the form "TracingConfig ..." (with optional leading article) (golint)
  • Line 128: warning: exported method MOSNConfig.Mode should have comment or be unexported (golint)
  • Line 143: warning: exported method MOSNConfig.GetAdmin should have comment or be unexported (golint)

• sofa-mosn/pkg/configmanager/parser.go
  • Line 37: warning: exported type ContentKey should have comment or be unexported (golint)
  • Line 39: warning: exported var ProtocolsSupported should have comment or be unexported (golint)
  • Line 47: warning: exported const MinHostWeight should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: comment on exported function RegisterProtocolParser should be of the form "RegisterProtocolParser ..." (golint)
  • Line 78: warning: comment on exported function RegisterConfigParsedListener should be of the form "RegisterConfigParsedListener ..." (golint)
  • Line 164: warning: exported function ParseLogLevel should have comment or be unexported (golint)
  • Line 171: warning: exported function GetAddrIp should have comment or be unexported (golint)
  • Line 182: warning: exported function GetAddrPort should have comment or be unexported (golint)
  • Line 193: warning: comment on exported function ParseListenerConfig should be of the form "ParseListenerConfig ..." (golint)
  • Line 221: warning: don't use underscores in Go names; var old_pc should be oldPc (golint)
  • Line 306: warning: exported function ParseRouterConfiguration should have comment or be unexported (golint)
  • Line 323: warning: comment on exported function ParseServerConfig should be of the form "ParseServerConfig ..." (golint)

• sofa-mosn/pkg/metrics/shm/counter.go
  • Line 27: warning: comment on exported type ShmCounter should be of the form "ShmCounter ..." (with optional leading article) (golint)
  • Line 56: warning: exported function NewShmCounterFunc should have comment or be unexported (golint)
  • Line 69: warning: comment on exported method ShmCounter.Stop should be of the form "Stop ..." (golint)

• sofa-mosn/pkg/mosn/default_stages.go
  • Line 32: warning: comment on exported function DefaultInitStage should be of the form "DefaultInitStage ..." (golint)
  • Line 45: warning: comment on exported function DefaultPreStartStage should be of the form "DefaultPreStartStage ..." (golint)
  • Line 59: warning: comment on exported function DefaultStartStage should be of the form "DefaultStartStage ..." (golint)

• sofa-mosn/pkg/stream/context.go
  • Line 31: warning: comment on exported type ContextManager should be of the form "ContextManager ..." (with optional leading article) (golint)
  • Line 37: warning: exported method ContextManager.Get should have comment or be unexported (golint)
  • Line 41: warning: exported method ContextManager.Next should have comment or be unexported (golint)
  • Line 48: warning: exported method ContextManager.InjectTrace should have comment or be unexported (golint)
  • Line 56: warning: exported function NewContextManager should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/static_tls_test.go
  • Line 616: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/types/stream.go
  • Line 237: warning: comment on exported type ConnectionPool should be of the form "ConnectionPool ..." (with optional leading article) (golint)

• sofa-mosn/pkg/proxy/gomock_test.go
  • Line 99: warning: don't use underscores in Go names; func parameter cluster_name should be clusterName (golint)

• sofa-mosn/test/cases/extends/grpc.go
  • Line 35: warning: exported function NewHelloExampleGrpcServer should have comment or be unexported (golint)
  • Line 198: warning: exported function NewEchoStreamGrpcServer should have comment or be unexported (golint)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/client.go
  • Line 15: warning: exported type Response should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/network/connectionmanager/deprecated.go
  • Line 13: warning: exported function CreateProxyFactory should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/default_work_pool.go
  • Line 30: warning: exported type WorkGoroutine should have comment or be unexported (golint)
  • Line 34: warning: exported function NewWorkGoroutine should have comment or be unexported (golint)
  • Line 41: warning: exported method WorkGoroutine.AddTask should have comment or be unexported (golint)
  • Line 45: warning: exported method WorkGoroutine.Start should have comment or be unexported (golint)
  • Line 69: warning: exported type DefaultWorkPool should have comment or be unexported (golint)
  • Line 77: warning: exported function NewDefaultWorkPool should have comment or be unexported (golint)
  • Line 92: warning: exported method DefaultWorkPool.Schedule should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/transcoder/factory.go
  • Line 55: warning: exported function MustRegister should have comment or be unexported (golint)
  • Line 63: warning: exported function GetTranscoder should have comment or be unexported (golint)

• sofa-mosn/pkg/network/transfer.go
  • Line 50: warning: exported function SetTransferTimeout should have comment or be unexported (golint)

• sofa-mosn/pkg/types/alias.go
  • Line 25: warning: comment on exported type IoBuffer should be of the form "IoBuffer ..." (with optional leading article) (golint)
  • Line 28: warning: exported type ProtocolName should have comment or be unexported (golint)
  • Line 30: warning: exported type HeaderMap should have comment or be unexported (golint)
  • Line 32: warning: exported type HostInfo should have comment or be unexported (golint)
  • Line 34: warning: exported type RequestInfo should have comment or be unexported (golint)
  • Line 36: warning: exported type Route should have comment or be unexported (golint)
  • Line 38: warning: exported type VirtualHost should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/servicediscovery/dubbod/sub.go
  • Line 1: warning: package comment should be of the form "Package dubbod ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/server/handler.go
  • Line 62: warning: comment on exported function NewHandler should be of the form "NewHandler ..." (golint)
  • Line 566: warning: comment on exported function Milliseconds should be of the form "Milliseconds ..." (golint)
  • Line 863: warning: exported function GetInheritListeners should have comment or be unexported (golint)
  • Line 945: warning: exported function GetInheritConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/config/v2/extend.go
  • Line 25: warning: exported type ParseExtendConfig should have comment or be unexported (golint)
  • Line 33: warning: exported var ErrDuplicateExtendConfigParse should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter/metadata/driver.go
  • Line 36: warning: exported type Driver should have comment or be unexported (golint)
  • Line 41: warning: exported function RegisterDriver should have comment or be unexported (golint)
  • Line 45: warning: exported function InitMetadataDriver should have comment or be unexported (golint)
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/upstream/cluster/cluster.go
  • Line 37: warning: exported function RegisterClusterType should have comment or be unexported (golint)
  • Line 48: warning: exported function NewCluster should have comment or be unexported (golint)

• sofa-mosn/test/lib/http/stats_wrapper.go
  • Line 16: warning: exported function NewStatsListener should have comment or be unexported (golint)
  • Line 23: warning: exported method StatsListener.Accept should have comment or be unexported (golint)
  • Line 38: warning: exported method StatsListener.Close should have comment or be unexported (golint)
  • Line 42: warning: exported method StatsListener.Addr should have comment or be unexported (golint)
  • Line 52: warning: exported method StatsConn.Close should have comment or be unexported (golint)
  • Line 66: warning: exported method ResponseWriterWrapper.WriteHeader should have comment or be unexported (golint)

• sofa-mosn/examples/codes/filter/jwtauthn/server.go
  • Line 7: warning: exported function ServeHTTP should have comment or be unexported (golint)

• sofa-mosn/pkg/types/wasm.go
  • Line 109: warning: exported type WasmVM should have comment or be unexported (golint)
  • Line 111: warning: exported type WasmModule should have comment or be unexported (golint)
  • Line 113: warning: exported type WasmInstance should have comment or be unexported (golint)
  • Line 115: warning: exported type WasmFunction should have comment or be unexported (golint)
  • Line 141: warning: exported type ABIHandler should have comment or be unexported (golint)

• sofa-mosn/pkg/xds/v2/rds/routerconfignames.go
  • Line 49: warning: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)

• sofa-mosn/pkg/router/rpc_rule.go
  • Line 29: warning: comment on exported type RPCRouteRuleImpl should be of the form "RPCRouteRuleImpl ..." (with optional leading article) (golint)
  • Line 36: warning: exported method RPCRouteRuleImpl.HeaderMatchCriteria should have comment or be unexported (golint)
  • Line 43: warning: exported method RPCRouteRuleImpl.PathMatchCriterion should have comment or be unexported (golint)
  • Line 47: warning: exported method RPCRouteRuleImpl.RouteRule should have comment or be unexported (golint)
  • Line 51: warning: exported method RPCRouteRuleImpl.Matcher should have comment or be unexported (golint)
  • Line 55: warning: exported method RPCRouteRuleImpl.MatchType should have comment or be unexported (golint)
  • Line 59: warning: exported method RPCRouteRuleImpl.FinalizeRequestHeaders should have comment or be unexported (golint)
  • Line 63: warning: exported method RPCRouteRuleImpl.Match should have comment or be unexported (golint)
  • Line 83: warning: exported function CreateRPCRule should have comment or be unexported (golint)

• sofa-mosn/pkg/xds/conv/convertxds_test.go
  • Line 1098: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)

• sofa-mosn/pkg/xds/conv/stats.go
  • Line 8: warning: exported var Stats should have comment or be unexported (golint)
  • Line 10: warning: exported function InitStats should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/http2.go
  • Line 36: warning: exported var VerboseLogs should have comment or be unexported (golint)
  • Line 152: warning: exported const SettingHeaderTableSize should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/networkextention/discovery/dynamic_cluster.go
  • Line 53: warning: exported const DiscoveryLoopInterval should have comment (or a comment on this block) or be unexported (golint)
  • Line 125: warning: exported type MonitorDiscovery should have comment or be unexported (golint)
  • Line 137: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 143: warning: exported method MonitorDiscovery.Start should have comment or be unexported (golint)
  • Line 212: warning: exported method MonitorDiscovery.IsClosed should have comment or be unexported (golint)
  • Line 216: warning: exported method MonitorDiscovery.Stop should have comment or be unexported (golint)
  • Line 260: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 302: warning: exported function CreateHttpClient should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/l7/stream/headers.go
  • Line 25: warning: comment on exported type Headers should be of the form "Headers ..." (with optional leading article) (golint)

• sofa-mosn/pkg/protocol/xprotocol/dubbothrift/protocol.go
  • Line 56: warning: exported var MagicTag should have comment or be unexported (golint)

• sofa-mosn/pkg/server/types.go
  • Line 28: warning: exported type Config should have comment or be unexported (golint)
  • Line 37: warning: exported type Server should have comment or be unexported (golint)

• sofa-mosn/test/lib/xprotocol/boltv1/server.go
  • Line 21: warning: exported type MockBoltServer should have comment or be unexported (golint)
  • Line 32: warning: comment on exported function NewBoltServer should be of the form "NewBoltServer ..." (golint)
  • Line 59: warning: exported method MockBoltServer.Start should have comment or be unexported (golint)
  • Line 85: warning: exported method MockBoltServer.Stop should have comment or be unexported (golint)
  • Line 93: warning: exported method MockBoltServer.Stats should have comment or be unexported (golint)
  • Line 175: warning: exported type ConnectionManager should have comment or be unexported (golint)
  • Line 182: warning: exported method ConnectionManager.Add should have comment or be unexported (golint)
  • Line 191: warning: exported method ConnectionManager.Delete should have comment or be unexported (golint)
  • Line 198: warning: exported method ConnectionManager.Clean should have comment or be unexported (golint)
  • Line 208: warning: exported type ResponseToWrite should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter/metadata/zone/zone.go
  • Line 36: warning: exported type ZoneConfig should have comment or be unexported (golint)
  • Line 40: warning: exported type ZoneDriver should have comment or be unexported (golint)
  • Line 44: warning: exported method ZoneDriver.Init should have comment or be unexported (golint)
  • Line 72: warning: exported method ZoneDriver.BuildMetadata should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/stream.go
  • Line 16: warning: exported type BaseStream should have comment or be unexported (golint)
  • Line 23: warning: exported method BaseStream.AddEventListener should have comment or be unexported (golint)
  • Line 29: warning: exported method BaseStream.RemoveEventListener should have comment or be unexported (golint)
  • Line 46: warning: exported method BaseStream.ResetStream should have comment or be unexported (golint)
  • Line 59: warning: exported method BaseStream.DestroyStream should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/original_dst.go
  • Line 36: warning: comment on exported type OriginalDstLoadBalancer should be of the form "OriginalDstLoadBalancer ..." (with optional leading article) (golint)
  • Line 50: warning: exported method OriginalDstLoadBalancer.ChooseHost should have comment or be unexported (golint)
  • Line 101: warning: exported method OriginalDstLoadBalancer.IsExistsHosts should have comment or be unexported (golint)
  • Line 105: warning: exported method OriginalDstLoadBalancer.HostNum should have comment or be unexported (golint)
  • Line 109: warning: exported type LBOriDstInfoImpl should have comment or be unexported (golint)
  • Line 114: warning: exported method LBOriDstInfoImpl.IsEnabled should have comment or be unexported (golint)
  • Line 118: warning: exported method LBOriDstInfoImpl.GetHeader should have comment or be unexported (golint)
  • Line 122: warning: exported function NewLBOriDstInfo should have comment or be unexported (golint)

• sofa-mosn/test/lib/http/config.go
  • Line 23: warning: exported type HttpServerConfig should have comment or be unexported (golint)
  • Line 28: warning: exported function NewHttpServerConfig should have comment or be unexported (golint)
  • Line 40: warning: comment on exported type ResonseConfig should be of the form "ResonseConfig ..." (with optional leading article) (golint)
  • Line 57: warning: exported type Condition should have comment or be unexported (golint)
  • Line 69: warning: exported method Condition.Match should have comment or be unexported (golint)
  • Line 100: warning: exported type ResponseBuilder should have comment or be unexported (golint)
  • Line 109: warning: exported method ResponseBuilder.Build should have comment or be unexported (golint)
  • Line 124: warning: exported type HttpClientConfig should have comment or be unexported (golint)
  • Line 131: warning: exported function NewHttpClientConfig should have comment or be unexported (golint)
  • Line 152: warning: exported method RequestConfig.BuildRequest should have comment or be unexported (golint)
  • Line 203: warning: exported method VerifyConfig.Verify should have comment or be unexported (golint)

• sofa-mosn/test/util/common.go
  • Line 15: warning: exported function RandomDuration should have comment or be unexported (golint)
  • Line 22: warning: exported function IsMapEmpty should have comment or be unexported (golint)
  • Line 31: warning: exported function WaitMapEmpty should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/proxywasm/factory.go
  • Line 39: warning: exported const ProxyWasm should have comment or be unexported (golint)
  • Line 45: warning: exported type FilterConfigFactory should have comment or be unexported (golint)
  • Line 99: warning: exported method FilterConfigFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 109: warning: exported method FilterConfigFactory.GetRootContextID should have comment or be unexported (golint)
  • Line 113: warning: exported method FilterConfigFactory.GetVmConfig should have comment or be unexported (golint)
  • Line 141: warning: exported method FilterConfigFactory.GetPluginConfig should have comment or be unexported (golint)
  • Line 156: warning: exported method FilterConfigFactory.OnConfigUpdate should have comment or be unexported (golint)
  • Line 161: warning: exported method FilterConfigFactory.OnPluginStart should have comment or be unexported (golint)
  • Line 202: warning: exported method FilterConfigFactory.OnPluginDestroy should have comment or be unexported (golint)

• sofa-mosn/pkg/metrics/shm/gauge.go
  • Line 27: warning: comment on exported type ShmGauge should be of the form "ShmGauge ..." (with optional leading article) (golint)
  • Line 46: warning: exported function NewShmGaugeFunc should have comment or be unexported (golint)
  • Line 59: warning: comment on exported method ShmGauge.Stop should be of the form "Stop ..." (golint)
  • Line 60: warning: receiver name c should be consistent with previous receiver name g for ShmGauge (golint)

• sofa-mosn/pkg/mtls/provider.go
  • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/test/lib/http/client.go
  • Line 44: warning: exported function NewHttpClient should have comment or be unexported (golint)
  • Line 61: warning: exported method MockHttpClient.SyncCall should have comment or be unexported (golint)
  • Line 87: warning: comment on exported method MockHttpClient.AsyncCall should be of the form "AsyncCall ..." (golint)
  • Line 91: warning: exported method MockHttpClient.Stats should have comment or be unexported (golint)
  • Line 149: warning: exported type Response should have comment or be unexported (golint)
  • Line 156: warning: exported type HttpConn should have comment or be unexported (golint)
  • Line 163: warning: exported function NewConn should have comment or be unexported (golint)
  • Line 192: warning: exported method HttpConn.OnEvent should have comment or be unexported (golint)
  • Line 201: warning: exported method HttpConn.Close should have comment or be unexported (golint)
  • Line 205: warning: exported method HttpConn.IsClosed should have comment or be unexported (golint)
  • Line 214: warning: exported method HttpConn.AsyncSendRequest should have comment or be unexported (golint)
  • Line 226: warning: exported var ErrClosedConnection should have comment or be unexported (golint)
  • Line 230: warning: exported method HttpConn.SyncSendRequest should have comment or be unexported (golint)

• sofa-mosn/examples/codes/wasm/sofarpc/client.go
  • Line 21: warning: exported type Client should have comment or be unexported (golint)
  • Line 28: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 45: warning: exported method Client.OnReceive should have comment or be unexported (golint)
  • Line 56: warning: exported method Client.OnDecodeError should have comment or be unexported (golint)
  • Line 58: warning: exported method Client.Request should have comment or be unexported (golint)

• sofa-mosn/pkg/cel/attribute/kind.go
  • Line 26: warning: comment on exported type Kind should be of the form "Kind ..." (with optional leading article) (golint)
  • Line 67: warning: comment on exported const MOSN_CTX should be of the form "MOSN_CTX ..." (golint)
  • Line 80: warning: exported var KindName should have comment or be unexported (golint)
  • Line 95: warning: exported var KindValue should have comment or be unexported (golint)

• sofa-mosn/examples/codes/flowcontrol-sample/server.go
  • Line 7: warning: exported function ServeHTTP should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/example/command.go
  • Line 26: warning: exported type Request should have comment or be unexported (golint)
  • Line 34: warning: exported method Request.GetStreamType should have comment or be unexported (golint)
  • Line 38: warning: exported method Request.GetRequestId should have comment or be unexported (golint)
  • Line 42: warning: exported method Request.SetRequestId should have comment or be unexported (golint)
  • Line 46: warning: exported type Response should have comment or be unexported (golint)
  • Line 51: warning: exported method Response.GetStreamType should have comment or be unexported (golint)
  • Line 55: warning: exported method Response.GetRequestId should have comment or be unexported (golint)
  • Line 59: warning: exported method Response.SetRequestId should have comment or be unexported (golint)
  • Line 63: warning: exported type MessageCommand should have comment or be unexported (golint)
  • Line 70: warning: exported type MessageAckCommand should have comment or be unexported (golint)

• sofa-mosn/pkg/wasm/abi/registry.go
  • Line 38: warning: exported function GetABI should have comment or be unexported (golint)
  • Line 63: warning: exported function GetABIList should have comment or be unexported (golint)

• sofa-mosn/pkg/types/network.go
  • Line 150: warning: exported type ListenerFilter should have comment or be unexported (golint)
  • Line 231: warning: exported type FilterChainFactory should have comment or be unexported (golint)
  • Line 238: warning: exported var ErrConnectionHasClosed should have comment or be unexported (golint)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/codec/matcher.go
  • Line 24: warning: exported type Matcher should have comment or be unexported (golint)
  • Line 26: warning: comment on exported method Matcher.ExampleMatcher should be of the form "ExampleMatcher ..." (golint)

• sofa-mosn/pkg/featuregate/feature_spec.go
  • Line 32: warning: exported method BaseFeatureSpec.Default should have comment or be unexported (golint)
  • Line 36: warning: exported method BaseFeatureSpec.LockToDefault should have comment or be unexported (golint)
  • Line 40: warning: exported method BaseFeatureSpec.SetState should have comment or be unexported (golint)
  • Line 45: warning: exported method BaseFeatureSpec.State should have comment or be unexported (golint)
  • Line 52: warning: exported method BaseFeatureSpec.PreRelease should have comment or be unexported (golint)
  • Line 56: warning: exported method BaseFeatureSpec.InitFunc should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/context.go
  • Line 32: warning: exported type ContextCallback should have comment or be unexported (golint)
  • Line 48: warning: exported type Context should have comment or be unexported (golint)
  • Line 66: warning: exported method Context.GetDecodeCmd should have comment or be unexported (golint)
  • Line 70: warning: exported method Context.SetDecodeCmd should have comment or be unexported (golint)
  • Line 74: warning: exported method Context.GetDecodeBuffer should have comment or be unexported (golint)
  • Line 78: warning: exported method Context.SetDecodeBuffer should have comment or be unexported (golint)
  • Line 82: warning: exported method Context.GetEncodeCmd should have comment or be unexported (golint)
  • Line 86: warning: exported method Context.SetEncodeCmd should have comment or be unexported (golint)
  • Line 90: warning: exported method Context.SetEncodeBuffer should have comment or be unexported (golint)
  • Line 94: warning: exported method Context.GetEncodeBuffer should have comment or be unexported (golint)
  • Line 98: warning: exported method Context.ContextId should have comment or be unexported (golint)
  • Line 102: warning: exported method Context.GetCustomBuffer should have comment or be unexported (golint)

• sofa-mosn/test/lib/utils/slice.go
  • Line 9: warning: exported function StringIn should have comment or be unexported (golint)
  • Line 18: warning: exported function SliceEqual should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/loadbalancer.go
  • Line 38: warning: exported function RegisterLBType should have comment or be unexported (golint)
  • Line 62: warning: exported var VarProxyUpstreamIndex should have comment or be unexported (golint)
  • Line 77: warning: exported function NewLoadBalancer should have comment or be unexported (golint)
  • Line 178: warning: comment on exported type WRRLoadBalancer should be of the form "WRRLoadBalancer ..." (with optional leading article) (golint)
  • Line 199: warning: exported method WRRLoadBalancer.IsExistsHosts should have comment or be unexported (golint)
  • Line 203: warning: exported method WRRLoadBalancer.HostNum should have comment or be unexported (golint)
  • Line 220: warning: don't use underscores in Go names; const default_choice should be defaultChoice (golint)
  • Line 270: warning: exported type EdfLoadBalancer should have comment or be unexported (golint)
  • Line 280: warning: exported method EdfLoadBalancer.ChooseHost should have comment or be unexported (golint)
  • Line 312: warning: exported method EdfLoadBalancer.IsExistsHosts should have comment or be unexported (golint)
  • Line 316: warning: exported method EdfLoadBalancer.HostNum should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_client_test.go
  • Line 1642: warning: error var brokenConnErr should have name of the form errFoo (golint)

• sofa-mosn/pkg/module/http2/ciphers.go
  • Line 11: warning: don't use underscores in Go names; const cipher_TLS_NULL_WITH_NULL_NULL should be cipherTLSNULLWITHNULLNULL (golint)
  • Line 12: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_NULL_MD5 should be cipherTLSRSAWITHNULLMD5 (golint)
  • Line 13: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_NULL_SHA should be cipherTLSRSAWITHNULLSHA (golint)
  • Line 14: warning: don't use underscores in Go names; const cipher_TLS_RSA_EXPORT_WITH_RC4_40_MD5 should be cipherTLSRSAEXPORTWITHRC4_40MD5 (golint)
  • Line 15: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_RC4_128_MD5 should be cipherTLSRSAWITHRC4_128MD5 (golint)
  • Line 16: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_RC4_128_SHA should be cipherTLSRSAWITHRC4_128SHA (golint)
  • Line 17: warning: don't use underscores in Go names; const cipher_TLS_RSA_EXPORT_WITH_RC2_CBC_40_MD5 should be cipherTLSRSAEXPORTWITHRC2CBC40MD5 (golint)
  • Line 18: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_IDEA_CBC_SHA should be cipherTLSRSAWITHIDEACBCSHA (golint)
  • Line 19: warning: don't use underscores in Go names; const cipher_TLS_RSA_EXPORT_WITH_DES40_CBC_SHA should be cipherTLSRSAEXPORTWITHDES40CBCSHA (golint)
  • Line 20: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_DES_CBC_SHA should be cipherTLSRSAWITHDESCBCSHA (golint)
  • Line 21: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSRSAWITH3DESEDECBCSHA (golint)
  • Line 22: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_EXPORT_WITH_DES40_CBC_SHA should be cipherTLSDHDSSEXPORTWITHDES40CBCSHA (golint)
  • Line 23: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_DES_CBC_SHA should be cipherTLSDHDSSWITHDESCBCSHA (golint)
  • Line 24: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_3DES_EDE_CBC_SHA should be cipherTLSDHDSSWITH3DESEDECBCSHA (golint)
  • Line 25: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_EXPORT_WITH_DES40_CBC_SHA should be cipherTLSDHRSAEXPORTWITHDES40CBCSHA (golint)
  • Line 26: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_DES_CBC_SHA should be cipherTLSDHRSAWITHDESCBCSHA (golint)
  • Line 27: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSDHRSAWITH3DESEDECBCSHA (golint)
  • Line 28: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_EXPORT_WITH_DES40_CBC_SHA should be cipherTLSDHEDSSEXPORTWITHDES40CBCSHA (golint)
  • Line 29: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_DES_CBC_SHA should be cipherTLSDHEDSSWITHDESCBCSHA (golint)
  • Line 30: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_3DES_EDE_CBC_SHA should be cipherTLSDHEDSSWITH3DESEDECBCSHA (golint)
  • Line 31: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_EXPORT_WITH_DES40_CBC_SHA should be cipherTLSDHERSAEXPORTWITHDES40CBCSHA (golint)
  • Line 32: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_DES_CBC_SHA should be cipherTLSDHERSAWITHDESCBCSHA (golint)
  • Line 33: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSDHERSAWITH3DESEDECBCSHA (golint)
  • Line 34: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_EXPORT_WITH_RC4_40_MD5 should be cipherTLSDHAnonEXPORTWITHRC4_40MD5 (golint)
  • Line 35: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_RC4_128_MD5 should be cipherTLSDHAnonWITHRC4_128MD5 (golint)
  • Line 36: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_EXPORT_WITH_DES40_CBC_SHA should be cipherTLSDHAnonEXPORTWITHDES40CBCSHA (golint)
  • Line 37: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_DES_CBC_SHA should be cipherTLSDHAnonWITHDESCBCSHA (golint)
  • Line 38: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_3DES_EDE_CBC_SHA should be cipherTLSDHAnonWITH3DESEDECBCSHA (golint)
  • Line 40: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_DES_CBC_SHA should be cipherTLSKRB5WITHDESCBCSHA (golint)
  • Line 41: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_3DES_EDE_CBC_SHA should be cipherTLSKRB5WITH3DESEDECBCSHA (golint)
  • Line 42: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_RC4_128_SHA should be cipherTLSKRB5WITHRC4_128SHA (golint)
  • Line 43: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_IDEA_CBC_SHA should be cipherTLSKRB5WITHIDEACBCSHA (golint)
  • Line 44: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_DES_CBC_MD5 should be cipherTLSKRB5WITHDESCBCMD5 (golint)
  • Line 45: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_3DES_EDE_CBC_MD5 should be cipherTLSKRB5WITH3DESEDECBCMD5 (golint)
  • Line 46: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_RC4_128_MD5 should be cipherTLSKRB5WITHRC4_128MD5 (golint)
  • Line 47: warning: don't use underscores in Go names; const cipher_TLS_KRB5_WITH_IDEA_CBC_MD5 should be cipherTLSKRB5WITHIDEACBCMD5 (golint)
  • Line 48: warning: don't use underscores in Go names; const cipher_TLS_KRB5_EXPORT_WITH_DES_CBC_40_SHA should be cipherTLSKRB5EXPORTWITHDESCBC40SHA (golint)
  • Line 49: warning: don't use underscores in Go names; const cipher_TLS_KRB5_EXPORT_WITH_RC2_CBC_40_SHA should be cipherTLSKRB5EXPORTWITHRC2CBC40SHA (golint)
  • Line 50: warning: don't use underscores in Go names; const cipher_TLS_KRB5_EXPORT_WITH_RC4_40_SHA should be cipherTLSKRB5EXPORTWITHRC4_40SHA (golint)
  • Line 51: warning: don't use underscores in Go names; const cipher_TLS_KRB5_EXPORT_WITH_DES_CBC_40_MD5 should be cipherTLSKRB5EXPORTWITHDESCBC40MD5 (golint)
  • Line 52: warning: don't use underscores in Go names; const cipher_TLS_KRB5_EXPORT_WITH_RC2_CBC_40_MD5 should be cipherTLSKRB5EXPORTWITHRC2CBC40MD5 (golint)
  • Line 53: warning: don't use underscores in Go names; const cipher_TLS_KRB5_EXPORT_WITH_RC4_40_MD5 should be cipherTLSKRB5EXPORTWITHRC4_40MD5 (golint)
  • Line 54: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_NULL_SHA should be cipherTLSPSKWITHNULLSHA (golint)
  • Line 55: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_NULL_SHA should be cipherTLSDHEPSKWITHNULLSHA (golint)
  • Line 56: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_NULL_SHA should be cipherTLSRSAPSKWITHNULLSHA (golint)
  • Line 57: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_128_CBC_SHA should be cipherTLSRSAWITHAES128CBCSHA (golint)
  • Line 58: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_AES_128_CBC_SHA should be cipherTLSDHDSSWITHAES128CBCSHA (golint)
  • Line 59: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_AES_128_CBC_SHA should be cipherTLSDHRSAWITHAES128CBCSHA (golint)
  • Line 60: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_AES_128_CBC_SHA should be cipherTLSDHEDSSWITHAES128CBCSHA (golint)
  • Line 61: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_128_CBC_SHA should be cipherTLSDHERSAWITHAES128CBCSHA (golint)
  • Line 62: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_AES_128_CBC_SHA should be cipherTLSDHAnonWITHAES128CBCSHA (golint)
  • Line 63: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_256_CBC_SHA should be cipherTLSRSAWITHAES256CBCSHA (golint)
  • Line 64: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_AES_256_CBC_SHA should be cipherTLSDHDSSWITHAES256CBCSHA (golint)
  • Line 65: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_AES_256_CBC_SHA should be cipherTLSDHRSAWITHAES256CBCSHA (golint)
  • Line 66: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_AES_256_CBC_SHA should be cipherTLSDHEDSSWITHAES256CBCSHA (golint)
  • Line 67: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_256_CBC_SHA should be cipherTLSDHERSAWITHAES256CBCSHA (golint)
  • Line 68: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_AES_256_CBC_SHA should be cipherTLSDHAnonWITHAES256CBCSHA (golint)
  • Line 69: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_NULL_SHA256 should be cipherTLSRSAWITHNULLSHA256 (golint)
  • Line 70: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_128_CBC_SHA256 should be cipherTLSRSAWITHAES128CBCSHA256 (golint)
  • Line 71: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_256_CBC_SHA256 should be cipherTLSRSAWITHAES256CBCSHA256 (golint)
  • Line 72: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_AES_128_CBC_SHA256 should be cipherTLSDHDSSWITHAES128CBCSHA256 (golint)
  • Line 73: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_AES_128_CBC_SHA256 should be cipherTLSDHRSAWITHAES128CBCSHA256 (golint)
  • Line 74: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_AES_128_CBC_SHA256 should be cipherTLSDHEDSSWITHAES128CBCSHA256 (golint)
  • Line 75: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_CAMELLIA_128_CBC_SHA should be cipherTLSRSAWITHCAMELLIA128CBCSHA (golint)
  • Line 76: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_CAMELLIA_128_CBC_SHA should be cipherTLSDHDSSWITHCAMELLIA128CBCSHA (golint)
  • Line 77: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_CAMELLIA_128_CBC_SHA should be cipherTLSDHRSAWITHCAMELLIA128CBCSHA (golint)
  • Line 78: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_CAMELLIA_128_CBC_SHA should be cipherTLSDHEDSSWITHCAMELLIA128CBCSHA (golint)
  • Line 79: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_CAMELLIA_128_CBC_SHA should be cipherTLSDHERSAWITHCAMELLIA128CBCSHA (golint)
  • Line 80: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_CAMELLIA_128_CBC_SHA should be cipherTLSDHAnonWITHCAMELLIA128CBCSHA (golint)
  • Line 86: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_128_CBC_SHA256 should be cipherTLSDHERSAWITHAES128CBCSHA256 (golint)
  • Line 87: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_AES_256_CBC_SHA256 should be cipherTLSDHDSSWITHAES256CBCSHA256 (golint)
  • Line 88: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_AES_256_CBC_SHA256 should be cipherTLSDHRSAWITHAES256CBCSHA256 (golint)
  • Line 89: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_AES_256_CBC_SHA256 should be cipherTLSDHEDSSWITHAES256CBCSHA256 (golint)
  • Line 90: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_256_CBC_SHA256 should be cipherTLSDHERSAWITHAES256CBCSHA256 (golint)
  • Line 91: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_AES_128_CBC_SHA256 should be cipherTLSDHAnonWITHAES128CBCSHA256 (golint)
  • Line 92: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_AES_256_CBC_SHA256 should be cipherTLSDHAnonWITHAES256CBCSHA256 (golint)
  • Line 94: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_CAMELLIA_256_CBC_SHA should be cipherTLSRSAWITHCAMELLIA256CBCSHA (golint)
  • Line 95: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_CAMELLIA_256_CBC_SHA should be cipherTLSDHDSSWITHCAMELLIA256CBCSHA (golint)
  • Line 96: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_CAMELLIA_256_CBC_SHA should be cipherTLSDHRSAWITHCAMELLIA256CBCSHA (golint)
  • Line 97: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_CAMELLIA_256_CBC_SHA should be cipherTLSDHEDSSWITHCAMELLIA256CBCSHA (golint)
  • Line 98: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_CAMELLIA_256_CBC_SHA should be cipherTLSDHERSAWITHCAMELLIA256CBCSHA (golint)
  • Line 99: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_CAMELLIA_256_CBC_SHA should be cipherTLSDHAnonWITHCAMELLIA256CBCSHA (golint)
  • Line 100: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_RC4_128_SHA should be cipherTLSPSKWITHRC4_128SHA (golint)
  • Line 101: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_3DES_EDE_CBC_SHA should be cipherTLSPSKWITH3DESEDECBCSHA (golint)
  • Line 102: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_128_CBC_SHA should be cipherTLSPSKWITHAES128CBCSHA (golint)
  • Line 103: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_256_CBC_SHA should be cipherTLSPSKWITHAES256CBCSHA (golint)
  • Line 104: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_RC4_128_SHA should be cipherTLSDHEPSKWITHRC4_128SHA (golint)
  • Line 105: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_3DES_EDE_CBC_SHA should be cipherTLSDHEPSKWITH3DESEDECBCSHA (golint)
  • Line 106: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_128_CBC_SHA should be cipherTLSDHEPSKWITHAES128CBCSHA (golint)
  • Line 107: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_256_CBC_SHA should be cipherTLSDHEPSKWITHAES256CBCSHA (golint)
  • Line 108: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_RC4_128_SHA should be cipherTLSRSAPSKWITHRC4_128SHA (golint)
  • Line 109: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_3DES_EDE_CBC_SHA should be cipherTLSRSAPSKWITH3DESEDECBCSHA (golint)
  • Line 110: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_AES_128_CBC_SHA should be cipherTLSRSAPSKWITHAES128CBCSHA (golint)
  • Line 111: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_AES_256_CBC_SHA should be cipherTLSRSAPSKWITHAES256CBCSHA (golint)
  • Line 112: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_SEED_CBC_SHA should be cipherTLSRSAWITHSEEDCBCSHA (golint)
  • Line 113: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_SEED_CBC_SHA should be cipherTLSDHDSSWITHSEEDCBCSHA (golint)
  • Line 114: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_SEED_CBC_SHA should be cipherTLSDHRSAWITHSEEDCBCSHA (golint)
  • Line 115: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_SEED_CBC_SHA should be cipherTLSDHEDSSWITHSEEDCBCSHA (golint)
  • Line 116: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_SEED_CBC_SHA should be cipherTLSDHERSAWITHSEEDCBCSHA (golint)
  • Line 117: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_SEED_CBC_SHA should be cipherTLSDHAnonWITHSEEDCBCSHA (golint)
  • Line 118: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_128_GCM_SHA256 should be cipherTLSRSAWITHAES128GCMSHA256 (golint)
  • Line 119: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_256_GCM_SHA384 should be cipherTLSRSAWITHAES256GCMSHA384 (golint)
  • Line 120: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 should be cipherTLSDHERSAWITHAES128GCMSHA256 (golint)
  • Line 121: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_256_GCM_SHA384 should be cipherTLSDHERSAWITHAES256GCMSHA384 (golint)
  • Line 122: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_AES_128_GCM_SHA256 should be cipherTLSDHRSAWITHAES128GCMSHA256 (golint)
  • Line 123: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_AES_256_GCM_SHA384 should be cipherTLSDHRSAWITHAES256GCMSHA384 (golint)
  • Line 124: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_AES_128_GCM_SHA256 should be cipherTLSDHEDSSWITHAES128GCMSHA256 (golint)
  • Line 125: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_AES_256_GCM_SHA384 should be cipherTLSDHEDSSWITHAES256GCMSHA384 (golint)
  • Line 126: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_AES_128_GCM_SHA256 should be cipherTLSDHDSSWITHAES128GCMSHA256 (golint)
  • Line 127: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_AES_256_GCM_SHA384 should be cipherTLSDHDSSWITHAES256GCMSHA384 (golint)
  • Line 128: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_AES_128_GCM_SHA256 should be cipherTLSDHAnonWITHAES128GCMSHA256 (golint)
  • Line 129: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_AES_256_GCM_SHA384 should be cipherTLSDHAnonWITHAES256GCMSHA384 (golint)
  • Line 130: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_128_GCM_SHA256 should be cipherTLSPSKWITHAES128GCMSHA256 (golint)
  • Line 131: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_256_GCM_SHA384 should be cipherTLSPSKWITHAES256GCMSHA384 (golint)
  • Line 132: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_128_GCM_SHA256 should be cipherTLSDHEPSKWITHAES128GCMSHA256 (golint)
  • Line 133: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_256_GCM_SHA384 should be cipherTLSDHEPSKWITHAES256GCMSHA384 (golint)
  • Line 134: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_AES_128_GCM_SHA256 should be cipherTLSRSAPSKWITHAES128GCMSHA256 (golint)
  • Line 135: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_AES_256_GCM_SHA384 should be cipherTLSRSAPSKWITHAES256GCMSHA384 (golint)
  • Line 136: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_128_CBC_SHA256 should be cipherTLSPSKWITHAES128CBCSHA256 (golint)
  • Line 137: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_256_CBC_SHA384 should be cipherTLSPSKWITHAES256CBCSHA384 (golint)
  • Line 138: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_NULL_SHA256 should be cipherTLSPSKWITHNULLSHA256 (golint)
  • Line 139: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_NULL_SHA384 should be cipherTLSPSKWITHNULLSHA384 (golint)
  • Line 140: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_128_CBC_SHA256 should be cipherTLSDHEPSKWITHAES128CBCSHA256 (golint)
  • Line 141: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_256_CBC_SHA384 should be cipherTLSDHEPSKWITHAES256CBCSHA384 (golint)
  • Line 142: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_NULL_SHA256 should be cipherTLSDHEPSKWITHNULLSHA256 (golint)
  • Line 143: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_NULL_SHA384 should be cipherTLSDHEPSKWITHNULLSHA384 (golint)
  • Line 144: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_AES_128_CBC_SHA256 should be cipherTLSRSAPSKWITHAES128CBCSHA256 (golint)
  • Line 145: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_AES_256_CBC_SHA384 should be cipherTLSRSAPSKWITHAES256CBCSHA384 (golint)
  • Line 146: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_NULL_SHA256 should be cipherTLSRSAPSKWITHNULLSHA256 (golint)
  • Line 147: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_NULL_SHA384 should be cipherTLSRSAPSKWITHNULLSHA384 (golint)
  • Line 148: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSRSAWITHCAMELLIA128CBCSHA256 (golint)
  • Line 149: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSDHDSSWITHCAMELLIA128CBCSHA256 (golint)
  • Line 150: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSDHRSAWITHCAMELLIA128CBCSHA256 (golint)
  • Line 151: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSDHEDSSWITHCAMELLIA128CBCSHA256 (golint)
  • Line 152: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSDHERSAWITHCAMELLIA128CBCSHA256 (golint)
  • Line 153: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSDHAnonWITHCAMELLIA128CBCSHA256 (golint)
  • Line 154: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_CAMELLIA_256_CBC_SHA256 should be cipherTLSRSAWITHCAMELLIA256CBCSHA256 (golint)
  • Line 155: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_CAMELLIA_256_CBC_SHA256 should be cipherTLSDHDSSWITHCAMELLIA256CBCSHA256 (golint)
  • Line 156: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_CAMELLIA_256_CBC_SHA256 should be cipherTLSDHRSAWITHCAMELLIA256CBCSHA256 (golint)
  • Line 157: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_CAMELLIA_256_CBC_SHA256 should be cipherTLSDHEDSSWITHCAMELLIA256CBCSHA256 (golint)
  • Line 158: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_CAMELLIA_256_CBC_SHA256 should be cipherTLSDHERSAWITHCAMELLIA256CBCSHA256 (golint)
  • Line 159: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_CAMELLIA_256_CBC_SHA256 should be cipherTLSDHAnonWITHCAMELLIA256CBCSHA256 (golint)
  • Line 161: warning: don't use underscores in Go names; const cipher_TLS_EMPTY_RENEGOTIATION_INFO_SCSV should be cipherTLSEMPTYRENEGOTIATIONINFOSCSV (golint)
  • Line 163: warning: don't use underscores in Go names; const cipher_TLS_FALLBACK_SCSV should be cipherTLSFALLBACKSCSV (golint)
  • Line 165: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_NULL_SHA should be cipherTLSECDHECDSAWITHNULLSHA (golint)
  • Line 166: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_RC4_128_SHA should be cipherTLSECDHECDSAWITHRC4_128SHA (golint)
  • Line 167: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSECDHECDSAWITH3DESEDECBCSHA (golint)
  • Line 168: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA should be cipherTLSECDHECDSAWITHAES128CBCSHA (golint)
  • Line 169: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA should be cipherTLSECDHECDSAWITHAES256CBCSHA (golint)
  • Line 170: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_NULL_SHA should be cipherTLSECDHEECDSAWITHNULLSHA (golint)
  • Line 171: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_RC4_128_SHA should be cipherTLSECDHEECDSAWITHRC4_128SHA (golint)
  • Line 172: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSECDHEECDSAWITH3DESEDECBCSHA (golint)
  • Line 173: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA should be cipherTLSECDHEECDSAWITHAES128CBCSHA (golint)
  • Line 174: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA should be cipherTLSECDHEECDSAWITHAES256CBCSHA (golint)
  • Line 175: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_NULL_SHA should be cipherTLSECDHRSAWITHNULLSHA (golint)
  • Line 176: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_RC4_128_SHA should be cipherTLSECDHRSAWITHRC4_128SHA (golint)
  • Line 177: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSECDHRSAWITH3DESEDECBCSHA (golint)
  • Line 178: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_AES_128_CBC_SHA should be cipherTLSECDHRSAWITHAES128CBCSHA (golint)
  • Line 179: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_AES_256_CBC_SHA should be cipherTLSECDHRSAWITHAES256CBCSHA (golint)
  • Line 180: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_NULL_SHA should be cipherTLSECDHERSAWITHNULLSHA (golint)
  • Line 181: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_RC4_128_SHA should be cipherTLSECDHERSAWITHRC4_128SHA (golint)
  • Line 182: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSECDHERSAWITH3DESEDECBCSHA (golint)
  • Line 183: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA should be cipherTLSECDHERSAWITHAES128CBCSHA (golint)
  • Line 184: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA should be cipherTLSECDHERSAWITHAES256CBCSHA (golint)
  • Line 185: warning: don't use underscores in Go names; const cipher_TLS_ECDH_anon_WITH_NULL_SHA should be cipherTLSECDHAnonWITHNULLSHA (golint)
  • Line 186: warning: don't use underscores in Go names; const cipher_TLS_ECDH_anon_WITH_RC4_128_SHA should be cipherTLSECDHAnonWITHRC4_128SHA (golint)
  • Line 187: warning: don't use underscores in Go names; const cipher_TLS_ECDH_anon_WITH_3DES_EDE_CBC_SHA should be cipherTLSECDHAnonWITH3DESEDECBCSHA (golint)
  • Line 188: warning: don't use underscores in Go names; const cipher_TLS_ECDH_anon_WITH_AES_128_CBC_SHA should be cipherTLSECDHAnonWITHAES128CBCSHA (golint)
  • Line 189: warning: don't use underscores in Go names; const cipher_TLS_ECDH_anon_WITH_AES_256_CBC_SHA should be cipherTLSECDHAnonWITHAES256CBCSHA (golint)
  • Line 190: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_WITH_3DES_EDE_CBC_SHA should be cipherTLSSRPSHAWITH3DESEDECBCSHA (golint)
  • Line 191: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_RSA_WITH_3DES_EDE_CBC_SHA should be cipherTLSSRPSHARSAWITH3DESEDECBCSHA (golint)
  • Line 192: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_DSS_WITH_3DES_EDE_CBC_SHA should be cipherTLSSRPSHADSSWITH3DESEDECBCSHA (golint)
  • Line 193: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_WITH_AES_128_CBC_SHA should be cipherTLSSRPSHAWITHAES128CBCSHA (golint)
  • Line 194: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_RSA_WITH_AES_128_CBC_SHA should be cipherTLSSRPSHARSAWITHAES128CBCSHA (golint)
  • Line 195: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_DSS_WITH_AES_128_CBC_SHA should be cipherTLSSRPSHADSSWITHAES128CBCSHA (golint)
  • Line 196: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_WITH_AES_256_CBC_SHA should be cipherTLSSRPSHAWITHAES256CBCSHA (golint)
  • Line 197: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_RSA_WITH_AES_256_CBC_SHA should be cipherTLSSRPSHARSAWITHAES256CBCSHA (golint)
  • Line 198: warning: don't use underscores in Go names; const cipher_TLS_SRP_SHA_DSS_WITH_AES_256_CBC_SHA should be cipherTLSSRPSHADSSWITHAES256CBCSHA (golint)
  • Line 199: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256 should be cipherTLSECDHEECDSAWITHAES128CBCSHA256 (golint)
  • Line 200: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384 should be cipherTLSECDHEECDSAWITHAES256CBCSHA384 (golint)
  • Line 201: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA256 should be cipherTLSECDHECDSAWITHAES128CBCSHA256 (golint)
  • Line 202: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA384 should be cipherTLSECDHECDSAWITHAES256CBCSHA384 (golint)
  • Line 203: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 should be cipherTLSECDHERSAWITHAES128CBCSHA256 (golint)
  • Line 204: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 should be cipherTLSECDHERSAWITHAES256CBCSHA384 (golint)
  • Line 205: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_AES_128_CBC_SHA256 should be cipherTLSECDHRSAWITHAES128CBCSHA256 (golint)
  • Line 206: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_AES_256_CBC_SHA384 should be cipherTLSECDHRSAWITHAES256CBCSHA384 (golint)
  • Line 207: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 should be cipherTLSECDHEECDSAWITHAES128GCMSHA256 (golint)
  • Line 208: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 should be cipherTLSECDHEECDSAWITHAES256GCMSHA384 (golint)
  • Line 209: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_AES_128_GCM_SHA256 should be cipherTLSECDHECDSAWITHAES128GCMSHA256 (golint)
  • Line 210: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_AES_256_GCM_SHA384 should be cipherTLSECDHECDSAWITHAES256GCMSHA384 (golint)
  • Line 211: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 should be cipherTLSECDHERSAWITHAES128GCMSHA256 (golint)
  • Line 212: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 should be cipherTLSECDHERSAWITHAES256GCMSHA384 (golint)
  • Line 213: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_AES_128_GCM_SHA256 should be cipherTLSECDHRSAWITHAES128GCMSHA256 (golint)
  • Line 214: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_AES_256_GCM_SHA384 should be cipherTLSECDHRSAWITHAES256GCMSHA384 (golint)
  • Line 215: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_RC4_128_SHA should be cipherTLSECDHEPSKWITHRC4_128SHA (golint)
  • Line 216: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_3DES_EDE_CBC_SHA should be cipherTLSECDHEPSKWITH3DESEDECBCSHA (golint)
  • Line 217: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA should be cipherTLSECDHEPSKWITHAES128CBCSHA (golint)
  • Line 218: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA should be cipherTLSECDHEPSKWITHAES256CBCSHA (golint)
  • Line 219: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256 should be cipherTLSECDHEPSKWITHAES128CBCSHA256 (golint)
  • Line 220: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384 should be cipherTLSECDHEPSKWITHAES256CBCSHA384 (golint)
  • Line 221: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_NULL_SHA should be cipherTLSECDHEPSKWITHNULLSHA (golint)
  • Line 222: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_NULL_SHA256 should be cipherTLSECDHEPSKWITHNULLSHA256 (golint)
  • Line 223: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_NULL_SHA384 should be cipherTLSECDHEPSKWITHNULLSHA384 (golint)
  • Line 224: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_ARIA_128_CBC_SHA256 should be cipherTLSRSAWITHARIA128CBCSHA256 (golint)
  • Line 225: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_ARIA_256_CBC_SHA384 should be cipherTLSRSAWITHARIA256CBCSHA384 (golint)
  • Line 226: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_ARIA_128_CBC_SHA256 should be cipherTLSDHDSSWITHARIA128CBCSHA256 (golint)
  • Line 227: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_ARIA_256_CBC_SHA384 should be cipherTLSDHDSSWITHARIA256CBCSHA384 (golint)
  • Line 228: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_ARIA_128_CBC_SHA256 should be cipherTLSDHRSAWITHARIA128CBCSHA256 (golint)
  • Line 229: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_ARIA_256_CBC_SHA384 should be cipherTLSDHRSAWITHARIA256CBCSHA384 (golint)
  • Line 230: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_ARIA_128_CBC_SHA256 should be cipherTLSDHEDSSWITHARIA128CBCSHA256 (golint)
  • Line 231: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_ARIA_256_CBC_SHA384 should be cipherTLSDHEDSSWITHARIA256CBCSHA384 (golint)
  • Line 232: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_ARIA_128_CBC_SHA256 should be cipherTLSDHERSAWITHARIA128CBCSHA256 (golint)
  • Line 233: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_ARIA_256_CBC_SHA384 should be cipherTLSDHERSAWITHARIA256CBCSHA384 (golint)
  • Line 234: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_ARIA_128_CBC_SHA256 should be cipherTLSDHAnonWITHARIA128CBCSHA256 (golint)
  • Line 235: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_ARIA_256_CBC_SHA384 should be cipherTLSDHAnonWITHARIA256CBCSHA384 (golint)
  • Line 236: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_ARIA_128_CBC_SHA256 should be cipherTLSECDHEECDSAWITHARIA128CBCSHA256 (golint)
  • Line 237: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_ARIA_256_CBC_SHA384 should be cipherTLSECDHEECDSAWITHARIA256CBCSHA384 (golint)
  • Line 238: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_ARIA_128_CBC_SHA256 should be cipherTLSECDHECDSAWITHARIA128CBCSHA256 (golint)
  • Line 239: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_ARIA_256_CBC_SHA384 should be cipherTLSECDHECDSAWITHARIA256CBCSHA384 (golint)
  • Line 240: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_ARIA_128_CBC_SHA256 should be cipherTLSECDHERSAWITHARIA128CBCSHA256 (golint)
  • Line 241: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_ARIA_256_CBC_SHA384 should be cipherTLSECDHERSAWITHARIA256CBCSHA384 (golint)
  • Line 242: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_ARIA_128_CBC_SHA256 should be cipherTLSECDHRSAWITHARIA128CBCSHA256 (golint)
  • Line 243: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_ARIA_256_CBC_SHA384 should be cipherTLSECDHRSAWITHARIA256CBCSHA384 (golint)
  • Line 244: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_ARIA_128_GCM_SHA256 should be cipherTLSRSAWITHARIA128GCMSHA256 (golint)
  • Line 245: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_ARIA_256_GCM_SHA384 should be cipherTLSRSAWITHARIA256GCMSHA384 (golint)
  • Line 246: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_ARIA_128_GCM_SHA256 should be cipherTLSDHERSAWITHARIA128GCMSHA256 (golint)
  • Line 247: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_ARIA_256_GCM_SHA384 should be cipherTLSDHERSAWITHARIA256GCMSHA384 (golint)
  • Line 248: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_ARIA_128_GCM_SHA256 should be cipherTLSDHRSAWITHARIA128GCMSHA256 (golint)
  • Line 249: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_ARIA_256_GCM_SHA384 should be cipherTLSDHRSAWITHARIA256GCMSHA384 (golint)
  • Line 250: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_ARIA_128_GCM_SHA256 should be cipherTLSDHEDSSWITHARIA128GCMSHA256 (golint)
  • Line 251: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_ARIA_256_GCM_SHA384 should be cipherTLSDHEDSSWITHARIA256GCMSHA384 (golint)
  • Line 252: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_ARIA_128_GCM_SHA256 should be cipherTLSDHDSSWITHARIA128GCMSHA256 (golint)
  • Line 253: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_ARIA_256_GCM_SHA384 should be cipherTLSDHDSSWITHARIA256GCMSHA384 (golint)
  • Line 254: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_ARIA_128_GCM_SHA256 should be cipherTLSDHAnonWITHARIA128GCMSHA256 (golint)
  • Line 255: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_ARIA_256_GCM_SHA384 should be cipherTLSDHAnonWITHARIA256GCMSHA384 (golint)
  • Line 256: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_ARIA_128_GCM_SHA256 should be cipherTLSECDHEECDSAWITHARIA128GCMSHA256 (golint)
  • Line 257: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_ARIA_256_GCM_SHA384 should be cipherTLSECDHEECDSAWITHARIA256GCMSHA384 (golint)
  • Line 258: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_ARIA_128_GCM_SHA256 should be cipherTLSECDHECDSAWITHARIA128GCMSHA256 (golint)
  • Line 259: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_ARIA_256_GCM_SHA384 should be cipherTLSECDHECDSAWITHARIA256GCMSHA384 (golint)
  • Line 260: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_ARIA_128_GCM_SHA256 should be cipherTLSECDHERSAWITHARIA128GCMSHA256 (golint)
  • Line 261: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_ARIA_256_GCM_SHA384 should be cipherTLSECDHERSAWITHARIA256GCMSHA384 (golint)
  • Line 262: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_ARIA_128_GCM_SHA256 should be cipherTLSECDHRSAWITHARIA128GCMSHA256 (golint)
  • Line 263: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_ARIA_256_GCM_SHA384 should be cipherTLSECDHRSAWITHARIA256GCMSHA384 (golint)
  • Line 264: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_ARIA_128_CBC_SHA256 should be cipherTLSPSKWITHARIA128CBCSHA256 (golint)
  • Line 265: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_ARIA_256_CBC_SHA384 should be cipherTLSPSKWITHARIA256CBCSHA384 (golint)
  • Line 266: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_ARIA_128_CBC_SHA256 should be cipherTLSDHEPSKWITHARIA128CBCSHA256 (golint)
  • Line 267: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_ARIA_256_CBC_SHA384 should be cipherTLSDHEPSKWITHARIA256CBCSHA384 (golint)
  • Line 268: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_ARIA_128_CBC_SHA256 should be cipherTLSRSAPSKWITHARIA128CBCSHA256 (golint)
  • Line 269: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_ARIA_256_CBC_SHA384 should be cipherTLSRSAPSKWITHARIA256CBCSHA384 (golint)
  • Line 270: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_ARIA_128_GCM_SHA256 should be cipherTLSPSKWITHARIA128GCMSHA256 (golint)
  • Line 271: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_ARIA_256_GCM_SHA384 should be cipherTLSPSKWITHARIA256GCMSHA384 (golint)
  • Line 272: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_ARIA_128_GCM_SHA256 should be cipherTLSDHEPSKWITHARIA128GCMSHA256 (golint)
  • Line 273: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_ARIA_256_GCM_SHA384 should be cipherTLSDHEPSKWITHARIA256GCMSHA384 (golint)
  • Line 274: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_ARIA_128_GCM_SHA256 should be cipherTLSRSAPSKWITHARIA128GCMSHA256 (golint)
  • Line 275: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_ARIA_256_GCM_SHA384 should be cipherTLSRSAPSKWITHARIA256GCMSHA384 (golint)
  • Line 276: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_ARIA_128_CBC_SHA256 should be cipherTLSECDHEPSKWITHARIA128CBCSHA256 (golint)
  • Line 277: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_ARIA_256_CBC_SHA384 should be cipherTLSECDHEPSKWITHARIA256CBCSHA384 (golint)
  • Line 278: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSECDHEECDSAWITHCAMELLIA128CBCSHA256 (golint)
  • Line 279: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSECDHEECDSAWITHCAMELLIA256CBCSHA384 (golint)
  • Line 280: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSECDHECDSAWITHCAMELLIA128CBCSHA256 (golint)
  • Line 281: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSECDHECDSAWITHCAMELLIA256CBCSHA384 (golint)
  • Line 282: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSECDHERSAWITHCAMELLIA128CBCSHA256 (golint)
  • Line 283: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSECDHERSAWITHCAMELLIA256CBCSHA384 (golint)
  • Line 284: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSECDHRSAWITHCAMELLIA128CBCSHA256 (golint)
  • Line 285: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSECDHRSAWITHCAMELLIA256CBCSHA384 (golint)
  • Line 286: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSRSAWITHCAMELLIA128GCMSHA256 (golint)
  • Line 287: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSRSAWITHCAMELLIA256GCMSHA384 (golint)
  • Line 288: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSDHERSAWITHCAMELLIA128GCMSHA256 (golint)
  • Line 289: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSDHERSAWITHCAMELLIA256GCMSHA384 (golint)
  • Line 290: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSDHRSAWITHCAMELLIA128GCMSHA256 (golint)
  • Line 291: warning: don't use underscores in Go names; const cipher_TLS_DH_RSA_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSDHRSAWITHCAMELLIA256GCMSHA384 (golint)
  • Line 292: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSDHEDSSWITHCAMELLIA128GCMSHA256 (golint)
  • Line 293: warning: don't use underscores in Go names; const cipher_TLS_DHE_DSS_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSDHEDSSWITHCAMELLIA256GCMSHA384 (golint)
  • Line 294: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSDHDSSWITHCAMELLIA128GCMSHA256 (golint)
  • Line 295: warning: don't use underscores in Go names; const cipher_TLS_DH_DSS_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSDHDSSWITHCAMELLIA256GCMSHA384 (golint)
  • Line 296: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSDHAnonWITHCAMELLIA128GCMSHA256 (golint)
  • Line 297: warning: don't use underscores in Go names; const cipher_TLS_DH_anon_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSDHAnonWITHCAMELLIA256GCMSHA384 (golint)
  • Line 298: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSECDHEECDSAWITHCAMELLIA128GCMSHA256 (golint)
  • Line 299: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSECDHEECDSAWITHCAMELLIA256GCMSHA384 (golint)
  • Line 300: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSECDHECDSAWITHCAMELLIA128GCMSHA256 (golint)
  • Line 301: warning: don't use underscores in Go names; const cipher_TLS_ECDH_ECDSA_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSECDHECDSAWITHCAMELLIA256GCMSHA384 (golint)
  • Line 302: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSECDHERSAWITHCAMELLIA128GCMSHA256 (golint)
  • Line 303: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSECDHERSAWITHCAMELLIA256GCMSHA384 (golint)
  • Line 304: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSECDHRSAWITHCAMELLIA128GCMSHA256 (golint)
  • Line 305: warning: don't use underscores in Go names; const cipher_TLS_ECDH_RSA_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSECDHRSAWITHCAMELLIA256GCMSHA384 (golint)
  • Line 306: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSPSKWITHCAMELLIA128GCMSHA256 (golint)
  • Line 307: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSPSKWITHCAMELLIA256GCMSHA384 (golint)
  • Line 308: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSDHEPSKWITHCAMELLIA128GCMSHA256 (golint)
  • Line 309: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSDHEPSKWITHCAMELLIA256GCMSHA384 (golint)
  • Line 310: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_CAMELLIA_128_GCM_SHA256 should be cipherTLSRSAPSKWITHCAMELLIA128GCMSHA256 (golint)
  • Line 311: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_CAMELLIA_256_GCM_SHA384 should be cipherTLSRSAPSKWITHCAMELLIA256GCMSHA384 (golint)
  • Line 312: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSPSKWITHCAMELLIA128CBCSHA256 (golint)
  • Line 313: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSPSKWITHCAMELLIA256CBCSHA384 (golint)
  • Line 314: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSDHEPSKWITHCAMELLIA128CBCSHA256 (golint)
  • Line 315: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSDHEPSKWITHCAMELLIA256CBCSHA384 (golint)
  • Line 316: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSRSAPSKWITHCAMELLIA128CBCSHA256 (golint)
  • Line 317: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSRSAPSKWITHCAMELLIA256CBCSHA384 (golint)
  • Line 318: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_CAMELLIA_128_CBC_SHA256 should be cipherTLSECDHEPSKWITHCAMELLIA128CBCSHA256 (golint)
  • Line 319: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_CAMELLIA_256_CBC_SHA384 should be cipherTLSECDHEPSKWITHCAMELLIA256CBCSHA384 (golint)
  • Line 320: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_128_CCM should be cipherTLSRSAWITHAES128CCM (golint)
  • Line 321: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_256_CCM should be cipherTLSRSAWITHAES256CCM (golint)
  • Line 322: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_128_CCM should be cipherTLSDHERSAWITHAES128CCM (golint)
  • Line 323: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_256_CCM should be cipherTLSDHERSAWITHAES256CCM (golint)
  • Line 324: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_128_CCM_8 should be cipherTLSRSAWITHAES128CCM8 (golint)
  • Line 325: warning: don't use underscores in Go names; const cipher_TLS_RSA_WITH_AES_256_CCM_8 should be cipherTLSRSAWITHAES256CCM8 (golint)
  • Line 326: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_128_CCM_8 should be cipherTLSDHERSAWITHAES128CCM8 (golint)
  • Line 327: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_AES_256_CCM_8 should be cipherTLSDHERSAWITHAES256CCM8 (golint)
  • Line 328: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_128_CCM should be cipherTLSPSKWITHAES128CCM (golint)
  • Line 329: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_256_CCM should be cipherTLSPSKWITHAES256CCM (golint)
  • Line 330: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_128_CCM should be cipherTLSDHEPSKWITHAES128CCM (golint)
  • Line 331: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_AES_256_CCM should be cipherTLSDHEPSKWITHAES256CCM (golint)
  • Line 332: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_128_CCM_8 should be cipherTLSPSKWITHAES128CCM8 (golint)
  • Line 333: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_AES_256_CCM_8 should be cipherTLSPSKWITHAES256CCM8 (golint)
  • Line 334: warning: don't use underscores in Go names; const cipher_TLS_PSK_DHE_WITH_AES_128_CCM_8 should be cipherTLSPSKDHEWITHAES128CCM8 (golint)
  • Line 335: warning: don't use underscores in Go names; const cipher_TLS_PSK_DHE_WITH_AES_256_CCM_8 should be cipherTLSPSKDHEWITHAES256CCM8 (golint)
  • Line 336: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_128_CCM should be cipherTLSECDHEECDSAWITHAES128CCM (golint)
  • Line 337: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_256_CCM should be cipherTLSECDHEECDSAWITHAES256CCM (golint)
  • Line 338: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_128_CCM_8 should be cipherTLSECDHEECDSAWITHAES128CCM8 (golint)
  • Line 339: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_AES_256_CCM_8 should be cipherTLSECDHEECDSAWITHAES256CCM8 (golint)
  • Line 343: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 should be cipherTLSECDHERSAWITHCHACHA20POLY1305SHA256 (golint)
  • Line 344: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 should be cipherTLSECDHEECDSAWITHCHACHA20POLY1305SHA256 (golint)
  • Line 345: warning: don't use underscores in Go names; const cipher_TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256 should be cipherTLSDHERSAWITHCHACHA20POLY1305SHA256 (golint)
  • Line 346: warning: don't use underscores in Go names; const cipher_TLS_PSK_WITH_CHACHA20_POLY1305_SHA256 should be cipherTLSPSKWITHCHACHA20POLY1305SHA256 (golint)
  • Line 347: warning: don't use underscores in Go names; const cipher_TLS_ECDHE_PSK_WITH_CHACHA20_POLY1305_SHA256 should be cipherTLSECDHEPSKWITHCHACHA20POLY1305SHA256 (golint)
  • Line 348: warning: don't use underscores in Go names; const cipher_TLS_DHE_PSK_WITH_CHACHA20_POLY1305_SHA256 should be cipherTLSDHEPSKWITHCHACHA20POLY1305SHA256 (golint)
  • Line 349: warning: don't use underscores in Go names; const cipher_TLS_RSA_PSK_WITH_CHACHA20_POLY1305_SHA256 should be cipherTLSRSAPSKWITHCHACHA20POLY1305SHA256 (golint)

• sofa-mosn/pkg/track/track.go
  • Line 25: warning: exported type TrackTime should have comment or be unexported (golint)
  • Line 30: warning: exported type Tracks should have comment or be unexported (golint)
  • Line 36: warning: exported method Tracks.Begin should have comment or be unexported (golint)
  • Line 45: warning: exported method Tracks.StartTrack should have comment or be unexported (golint)
  • Line 52: warning: exported method Tracks.EndTrack should have comment or be unexported (golint)
  • Line 79: warning: exported method Tracks.VisitTimestamp should have comment or be unexported (golint)

• sofa-mosn/examples/codes/mosn-extensions/plugin/so/simple_so.go
  • Line 12: warning: comment on exported function CreateFilterFactory should be of the form "CreateFilterFactory ..." (golint)
  • Line 24: warning: comment on exported type DemoFactory should be of the form "DemoFactory ..." (with optional leading article) (golint)
  • Line 29: warning: exported method DemoFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 39: warning: comment on exported type DemoFilter should be of the form "DemoFilter ..." (with optional leading article) (golint)
  • Line 54: warning: exported method DemoFilter.OnReceive should have comment or be unexported (golint)
  • Line 73: warning: exported method DemoFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 77: warning: exported method DemoFilter.OnDestroy should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/network/streamproxy/factory.go
  • Line 51: warning: exported function CreateTCPProxyFactory should have comment or be unexported (golint)
  • Line 61: warning: exported function CreateUDPProxyFactory should have comment or be unexported (golint)
  • Line 71: warning: comment on exported function ParseStreamProxy should be of the form "ParseStreamProxy ..." (golint)

• sofa-mosn/pkg/filter/network/streamproxy/types.go
  • Line 26: warning: comment on exported type Proxy should be of the form "Proxy ..." (with optional leading article) (golint)
  • Line 35: warning: comment on exported type ProxyConfig should be of the form "ProxyConfig ..." (with optional leading article) (golint)

• sofa-mosn/pkg/cel/ext/functions.go
  • Line 91: warning: exported function StandardFunctionsEnvOption should have comment or be unexported (golint)
  • Line 102: warning: exported function StandardOverloadsEnvOption should have comment or be unexported (golint)
  • Line 125: warning: exported function RegisterOverloadBoth should have comment or be unexported (golint)
  • Line 129: warning: exported function RegisterOverload should have comment or be unexported (golint)
  • Line 133: warning: exported function RegisterInstanceOverload should have comment or be unexported (golint)
  • Line 139: warning: exported function RegisterSimpleFunctionBoth should have comment or be unexported (golint)
  • Line 148: warning: exported function RegisterSimpleFunction should have comment or be unexported (golint)
  • Line 157: warning: exported function RegisterFunction should have comment or be unexported (golint)

• sofa-mosn/pkg/istio/control/http/attributes_builder_plugin.go
  • Line 26: warning: exported type AttributesBuilderPlugin should have comment or be unexported (golint)
  • Line 30: warning: exported function RegisterAttributesBuilderPlugin should have comment or be unexported (golint)
  • Line 34: warning: exported function AddAttributesByPlugins should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/factory.go
  • Line 33: warning: exported function Register should have comment or be unexported (golint)
  • Line 37: warning: exported function CreateServerStreamConnection should have comment or be unexported (golint)
  • Line 47: warning: exported function SelectStreamFactoryProtocol should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/skywalking/tracer.go
  • Line 32: warning: error var ReporterCfgErr should have name of the form ErrFoo (golint)
  • Line 32: warning: exported var ReporterCfgErr should have comment or be unexported (golint)
  • Line 33: warning: error var BackendServiceCfgErr should have name of the form ErrFoo (golint)
  • Line 107: warning: exported type SkyTracer should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/cluster_manager.go
  • Line 82: warning: exported function NewClusterManagerSingleton should have comment or be unexported (golint)

• sofa-mosn/pkg/context/wrapper.go
  • Line 26: warning: exported function Get should have comment or be unexported (golint)
  • Line 36: warning: comment on exported function WithValue should be of the form "WithValue ..." (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter/metadata/idc/idc.go
  • Line 36: warning: exported type IdcConfig should have comment or be unexported (golint)
  • Line 40: warning: exported type IdcDriver should have comment or be unexported (golint)
  • Line 44: warning: exported method IdcDriver.Init should have comment or be unexported (golint)
  • Line 72: warning: exported method IdcDriver.BuildMetadata should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/frame_test.go
  • Line 1087: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/mtls/crypto/tls/tls_custom.go
  • Line 204: warning: comment on exported method Conn.SetALPN should be of the form "SetALPN ..." (golint)

• sofa-mosn/pkg/buffer/bytebuffer_ctx.go
  • Line 32: warning: exported type ByteBufferCtx should have comment or be unexported (golint)
  • Line 36: warning: exported method ByteBufferCtx.New should have comment or be unexported (golint)
  • Line 40: warning: exported method ByteBufferCtx.Reset should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/util/time_util.go
  • Line 24: warning: exported function GetNowMS should have comment or be unexported (golint)

• sofa-mosn/pkg/metrics/xds.go
  • Line 24: warning: comment on exported const XdsType should be of the form "XdsType ..." (golint)

• sofa-mosn/pkg/metrics/shm/zone.go
  • Line 52: warning: exported function Reset should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/init.go
  • Line 42: warning: exported const DefaultMosnConfigPath should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/protocol/http2/factory.go
  • Line 26: warning: exported function ServerProto should have comment or be unexported (golint)
  • Line 30: warning: exported function ClientProto should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/healthcheck/healthchecker.go
  • Line 32: warning: exported const DefaultTimeout should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/test/util/xprotocol_rpc.go
  • Line 37: warning: exported type RPCClient should have comment or be unexported (golint)
  • Line 50: warning: exported function NewRPCClient should have comment or be unexported (golint)
  • Line 88: warning: exported method RPCClient.ConnectTLS should have comment or be unexported (golint)
  • Line 97: warning: exported method RPCClient.Connect should have comment or be unexported (golint)
  • Line 101: warning: exported method RPCClient.Stats should have comment or be unexported (golint)
  • Line 106: warning: exported method RPCClient.Close should have comment or be unexported (golint)
  • Line 113: warning: exported method RPCClient.SendRequest should have comment or be unexported (golint)
  • Line 116: warning: exported method RPCClient.SendRequestWithData should have comment or be unexported (golint)
  • Line 143: warning: exported method RPCClient.OnReceive should have comment or be unexported (golint)
  • Line 162: warning: exported method RPCClient.OnDecodeError should have comment or be unexported (golint)
  • Line 249: warning: exported type RPCServer should have comment or be unexported (golint)
  • Line 257: warning: exported function NewRPCServer should have comment or be unexported (golint)
  • Line 279: warning: exported method RPCServer.ServeBoltV1 should have comment or be unexported (golint)
  • Line 296: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 305: warning: exported method RPCServer.ServeDubbo should have comment or be unexported (golint)
  • Line 322: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 331: warning: exported method RPCServer.ServeDubboThrift should have comment or be unexported (golint)
  • Line 348: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 357: warning: exported method RPCServer.ServeTars should have comment or be unexported (golint)
  • Line 374: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 464: warning: exported function ServeRPC should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/network/grpc/conn.go
  • Line 33: warning: exported type Connection should have comment or be unexported (golint)
  • Line 45: warning: exported function NewConn should have comment or be unexported (golint)
  • Line 115: warning: exported method Connection.LocalAddr should have comment or be unexported (golint)
  • Line 119: warning: exported method Connection.RemoteAddr should have comment or be unexported (golint)
  • Line 123: warning: comment on exported method Connection.SetDeadline should be of the form "SetDeadline ..." (golint)
  • Line 133: warning: exported method Connection.SetReadDeadline should have comment or be unexported (golint)
  • Line 140: warning: exported method Connection.SetWriteDeadline should have comment or be unexported (golint)
  • Line 147: warning: exported method Connection.OnEvent should have comment or be unexported (golint)

• sofa-mosn/pkg/log/accesslog_test.go
  • Line 47: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 53: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 66: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 290: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 292: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 297: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 299: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 312: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 354: warning: don't use underscores in Go names; type mock_HeaderMap should be mockHeaderMap (golint)
  • Line 392: warning: don't use underscores in Go names; type mock_requestInfo should be mockRequestInfo (golint)

• sofa-mosn/pkg/upstream/servicediscovery/dubbod/notify.go
  • Line 1: warning: package comment should be of the form "Package dubbod ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/test/framework/framework.go
  • Line 86: warning: exported function Scenario should have comment or be unexported (golint)
  • Line 101: warning: exported function Setup should have comment or be unexported (golint)
  • Line 111: warning: exported function TearDown should have comment or be unexported (golint)
  • Line 121: warning: exported function Case should have comment or be unexported (golint)
  • Line 131: warning: exported function Verify should have comment or be unexported (golint)

• sofa-mosn/test/lib/factory.go
  • Line 5: warning: exported type CreateMockServer should have comment or be unexported (golint)
  • Line 7: warning: exported type CreateMockClient should have comment or be unexported (golint)
  • Line 13: warning: exported function RegisterCreateClient should have comment or be unexported (golint)
  • Line 17: warning: exported function RegisterCreateServer should have comment or be unexported (golint)
  • Line 21: warning: exported function CreateServer should have comment or be unexported (golint)
  • Line 29: warning: exported function CreateClient should have comment or be unexported (golint)

• sofa-mosn/pkg/server/adapter.go
  • Line 31: warning: exported type ListenerAdapter should have comment or be unexported (golint)
  • Line 68: warning: comment on exported method ListenerAdapter.FindListenerByName should be of the form "FindListenerByName ..." (golint)
  • Line 77: warning: exported function GetListenerAdapterInstance should have comment or be unexported (golint)
  • Line 120: warning: exported method ListenerAdapter.DeleteListener should have comment or be unexported (golint)

• sofa-mosn/pkg/router/virtualhost.go
  • Line 30: warning: exported type VirtualHostImpl should have comment or be unexported (golint)
  • Line 41: warning: exported method VirtualHostImpl.Name should have comment or be unexported (golint)
  • Line 73: warning: exported method VirtualHostImpl.GetRouteFromEntries should have comment or be unexported (golint)
  • Line 84: warning: exported method VirtualHostImpl.GetAllRoutesFromEntries should have comment or be unexported (golint)
  • Line 96: warning: exported method VirtualHostImpl.GetRouteFromHeaderKV should have comment or be unexported (golint)
  • Line 107: warning: exported method VirtualHostImpl.AddRoute should have comment or be unexported (golint)
  • Line 111: warning: exported method VirtualHostImpl.RemoveAllRoutes should have comment or be unexported (golint)
  • Line 121: warning: exported method VirtualHostImpl.PerFilterConfig should have comment or be unexported (golint)
  • Line 125: warning: exported method VirtualHostImpl.FinalizeRequestHeaders should have comment or be unexported (golint)
  • Line 130: warning: exported method VirtualHostImpl.FinalizeResponseHeaders should have comment or be unexported (golint)
  • Line 156: warning: exported function NewRouteBase should have comment or be unexported (golint)

• sofa-mosn/pkg/config/v2/filter.go
  • Line 28: warning: exported type HealthCheckFilterConfig should have comment or be unexported (golint)
  • Line 35: warning: exported type FaultInjectConfig should have comment or be unexported (golint)
  • Line 40: warning: exported type DelayInjectConfig should have comment or be unexported (golint)
  • Line 45: warning: exported type StreamGzip should have comment or be unexported (golint)
  • Line 66: warning: exported type FaultToleranceFilterConfig should have comment or be unexported (golint)
  • Line 106: warning: comment on exported type HealthCheckFilter should be of the form "HealthCheckFilter ..." (with optional leading article) (golint)
  • Line 112: warning: exported method HealthCheckFilter.MarshalJSON should have comment or be unexported (golint)
  • Line 117: warning: exported method HealthCheckFilter.UnmarshalJSON should have comment or be unexported (golint)
  • Line 125: warning: comment on exported type StreamTranscoder should be of the form "StreamTranscoder ..." (with optional leading article) (golint)
  • Line 130: warning: comment on exported type FaultInject should be of the form "FaultInject ..." (with optional leading article) (golint)
  • Line 136: warning: comment on exported type StreamPayloadLimit should be of the form "StreamPayloadLimit ..." (with optional leading article) (golint)
  • Line 142: warning: exported method FaultInject.MarshalJSON should have comment or be unexported (golint)
  • Line 147: warning: exported method FaultInject.UnmarshalJSON should have comment or be unexported (golint)
  • Line 155: warning: comment on exported type StreamFaultInject should be of the form "StreamFaultInject ..." (with optional leading article) (golint)
  • Line 163: warning: exported type DelayInject should have comment or be unexported (golint)
  • Line 168: warning: exported method DelayInject.MarshalJSON should have comment or be unexported (golint)
  • Line 173: warning: exported method DelayInject.UnmarshalJSON should have comment or be unexported (golint)
  • Line 181: warning: exported type AbortInject should have comment or be unexported (golint)
  • Line 186: warning: exported type Mixer should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/buffer.go
  • Line 39: warning: exported type ProtocolBuffers should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/sofa/http/tracer.go
  • Line 41: warning: exported var PrintLog should have comment or be unexported (golint)
  • Line 43: warning: exported type Tracer should have comment or be unexported (golint)
  • Line 45: warning: exported function NewTracer should have comment or be unexported (golint)
  • Line 50: warning: exported method Tracer.Start should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/sofa/xprotocol/types.go
  • Line 29: warning: exported const TRACE_ID should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported const MOSN_PROCESS_TIME should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: exported type SubProtocolDelegate should have comment or be unexported (golint)

• sofa-mosn/pkg/proxy/streamfilters_test.go
  • Line 478: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/stream/connpool/msgconnpool/backoff.go
  • Line 1: warning: package comment should be of the form "Package msgconnpool ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/examples/codes/tcpproxy-sample/http.go
  • Line 8: warning: exported function ServeHTTP should have comment or be unexported (golint)

• sofa-mosn/pkg/admin/store/state.go
  • Line 25: warning: exported type State should have comment or be unexported (golint)
  • Line 30: warning: exported const Init should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: don't use underscores in Go names; const Active_Reconfiguring should be ActiveReconfiguring (golint)
  • Line 33: warning: don't use underscores in Go names; const Passive_Reconfiguring should be PassiveReconfiguring (golint)
  • Line 40: warning: exported function GetMosnState should have comment or be unexported (golint)
  • Line 44: warning: exported function SetMosnState should have comment or be unexported (golint)
  • Line 52: warning: exported type OnStateChanged should have comment or be unexported (golint)
  • Line 56: warning: exported function RegisterOnStateChanged should have comment or be unexported (golint)
  • Line 60: warning: exported function SetStateCode should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/measure_model.go
  • Line 29: warning: exported type MeasureModel should have comment or be unexported (golint)
  • Line 38: warning: exported function NewMeasureModel should have comment or be unexported (golint)
  • Line 50: warning: exported method MeasureModel.GetKey should have comment or be unexported (golint)
  • Line 54: warning: exported method MeasureModel.AddInvocationStat should have comment or be unexported (golint)
  • Line 69: warning: exported method MeasureModel.Measure should have comment or be unexported (golint)
  • Line 118: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 162: warning: exported method MeasureModel.IsArrivalTime should have comment or be unexported (golint)
  • Line 169: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 173: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/filter/stream/proxywasm/filter.go
  • Line 36: warning: exported type Filter should have comment or be unexported (golint)
  • Line 69: warning: exported function NewFilter should have comment or be unexported (golint)
  • Line 122: warning: exported method Filter.OnDestroy should have comment or be unexported (golint)
  • Line 141: warning: exported method Filter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 145: warning: exported method Filter.SetSenderFilterHandler should have comment or be unexported (golint)
  • Line 162: warning: exported method Filter.OnReceive should have comment or be unexported (golint)
  • Line 201: warning: exported method Filter.Append should have comment or be unexported (golint)
  • Line 240: warning: exported method Filter.GetRootContextID should have comment or be unexported (golint)
  • Line 244: warning: exported method Filter.GetVmConfig should have comment or be unexported (golint)
  • Line 248: warning: exported method Filter.GetPluginConfig should have comment or be unexported (golint)
  • Line 252: warning: exported method Filter.GetHttpRequestHeader should have comment or be unexported (golint)
  • Line 260: warning: exported method Filter.GetHttpRequestBody should have comment or be unexported (golint)
  • Line 268: warning: exported method Filter.GetHttpRequestTrailer should have comment or be unexported (golint)
  • Line 276: warning: exported method Filter.GetHttpResponseHeader should have comment or be unexported (golint)
  • Line 284: warning: exported method Filter.GetHttpResponseBody should have comment or be unexported (golint)
  • Line 292: warning: exported method Filter.GetHttpResponseTrailer should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter/echo/echo.go
  • Line 30: warning: exported type EchoFilter should have comment or be unexported (golint)
  • Line 44: warning: exported method EchoFilter.OnReceive should have comment or be unexported (golint)
  • Line 64: warning: exported method EchoFilter.Append should have comment or be unexported (golint)
  • Line 69: warning: exported method EchoFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 73: warning: exported method EchoFilter.SetSenderFilterHandler should have comment or be unexported (golint)
  • Line 77: warning: exported method EchoFilter.OnDestroy should have comment or be unexported (golint)
  • Line 79: warning: exported method EchoFilter.Log should have comment or be unexported (golint)

• sofa-mosn/pkg/networkextention/l7/stream/filter_manager.go
  • Line 27: warning: comment on exported const DefaultFilterChainName should be of the form "DefaultFilterChainName ..." (golint)
  • Line 31: warning: exported function AddOrUpdateFilter should have comment or be unexported (golint)
  • Line 35: warning: exported function CreateStreamFilter should have comment or be unexported (golint)
  • Line 42: warning: exported function DestoryStreamFilter should have comment or be unexported (golint)

• sofa-mosn/pkg/plugin/admin.go
  • Line 21: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 59: warning: comment on exported function NewHttp should be of the form "NewHttp ..." (golint)
  • Line 73: warning: exported function AdminApi should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/server_push_test.go
  • Line 325: warning: don't use underscores in Go names; func testServer_Push_RejectSingleRequest should be testServerPushRejectSingleRequest (golint)

• sofa-mosn/pkg/buffer/buffer.go
  • Line 46: warning: exported method TempBufferCtx.Index should have comment or be unexported (golint)
  • Line 50: warning: exported method TempBufferCtx.New should have comment or be unexported (golint)
  • Line 54: warning: exported method TempBufferCtx.Reset should have comment or be unexported (golint)
  • Line 70: warning: exported function RegisterBuffer should have comment or be unexported (golint)
  • Line 117: warning: context.Context should be the first parameter of a function (golint)

• sofa-mosn/pkg/configmanager/dump_action.go
  • Line 41: warning: exported function DumpLock should have comment or be unexported (golint)
  • Line 45: warning: exported function DumpUnlock should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/dubbo/types.go
  • Line 26: warning: exported const ProtocolName should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: exported const EventRequest should have comment (or a comment on this block) or be unexported (golint)
  • Line 81: warning: exported const FrameworkVersionNameHeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 90: warning: exported const EgressDubbo should have comment (or a comment on this block) or be unexported (golint)
  • Line 95: warning: exported const ResponseStatusSuccess should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/wasm/abi/ext/xproxywasm020/impl.go
  • Line 21: warning: exported const AbiV2 should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/test/cases/extends/pluginsource/simple_so.go
  • Line 29: warning: comment on exported function CreateFilterFactory should be of the form "CreateFilterFactory ..." (golint)
  • Line 42: warning: comment on exported type DemoFactory should be of the form "DemoFactory ..." (with optional leading article) (golint)
  • Line 47: warning: exported method DemoFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 57: warning: comment on exported type DemoFilter should be of the form "DemoFilter ..." (with optional leading article) (golint)
  • Line 72: warning: exported method DemoFilter.OnReceive should have comment or be unexported (golint)
  • Line 91: warning: exported method DemoFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 95: warning: exported method DemoFilter.OnDestroy should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/mock_test.go
  • Line 333: warning: context.Context should be the first parameter of a function (golint)

• sofa-mosn/examples/codes/sofarpc-with-xprotocol-sample/server.go
  • Line 17: warning: exported type Server should have comment or be unexported (golint)
  • Line 23: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 43: warning: exported method Server.Run should have comment or be unexported (golint)
  • Line 58: warning: exported method Server.Serve should have comment or be unexported (golint)
  • Line 97: warning: exported method Server.HandleRequest should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/invocation_stat_factory_test.go
  • Line 34: warning: don't use underscores in Go names; var dimension_1 should be dimension1 (golint)
  • Line 35: warning: don't use underscores in Go names; var dimension_2 should be dimension2 (golint)
  • Line 36: warning: don't use underscores in Go names; var dimension_3 should be dimension3 (golint)

• sofa-mosn/pkg/protocol/http/types.go
  • Line 25: warning: exported type Code should have comment or be unexported (golint)
  • Line 28: warning: exported const Continue should have comment (or a comment on this block) or be unexported (golint)
  • Line 92: warning: exported type RequestHeader should have comment or be unexported (golint)
  • Line 148: warning: exported method RequestHeader.Clone should have comment or be unexported (golint)
  • Line 154: warning: exported method RequestHeader.ByteSize should have comment or be unexported (golint)
  • Line 161: warning: exported type ResponseHeader should have comment or be unexported (golint)
  • Line 217: warning: exported method ResponseHeader.Clone should have comment or be unexported (golint)
  • Line 223: warning: exported method ResponseHeader.ByteSize should have comment or be unexported (golint)

• sofa-mosn/pkg/shm/types.go
  • Line 42: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 48: warning: exported type ShmSpan should have comment or be unexported (golint)
  • Line 57: warning: exported function NewShmSpan should have comment or be unexported (golint)
  • Line 66: warning: exported method ShmSpan.Alloc should have comment or be unexported (golint)
  • Line 76: warning: exported method ShmSpan.Data should have comment or be unexported (golint)
  • Line 80: warning: exported method ShmSpan.Origin should have comment or be unexported (golint)

• sofa-mosn/test/framework/assert.go
  • Line 13: warning: exported var Equal should have comment or be unexported (golint)

• sofa-mosn/pkg/xds/v2/adssubscriber.go
  • Line 100: warning: exported function DisableReconnect should have comment or be unexported (golint)
  • Line 104: warning: exported function EnableReconnect should have comment or be unexported (golint)

• sofa-mosn/examples/codes/filter/mirror/http1/main.go
  • Line 38: warning: exported function Encrypt should have comment or be unexported (golint)
  • Line 42: warning: exported function EncryptBytes should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/default_regulator_test.go
  • Line 33: warning: don't use underscores in Go names; var dimension_1 should be dimension1 (golint)
  • Line 34: warning: don't use underscores in Go names; var dimension_2 should be dimension2 (golint)
  • Line 35: warning: don't use underscores in Go names; var dimension_3 should be dimension3 (golint)
  • Line 36: warning: don't use underscores in Go names; var dimension_4 should be dimension4 (golint)
  • Line 37: warning: don't use underscores in Go names; var stat_1 should be stat1 (golint)
  • Line 38: warning: don't use underscores in Go names; var stat_2 should be stat2 (golint)
  • Line 39: warning: don't use underscores in Go names; var stat_3 should be stat3 (golint)
  • Line 40: warning: don't use underscores in Go names; var stat_4 should be stat4 (golint)

• sofa-mosn/pkg/mosn/mosn.go
  • Line 45: warning: exported type Mosn should have comment or be unexported (golint)
  • Line 56: warning: exported function NewMosn should have comment or be unexported (golint)
  • Line 187: warning: should omit 2nd value from range; this loop is equivalent to `for idx := range ...` (golint)
  • Line 213: warning: exported method Mosn.TransferConnection should have comment or be unexported (golint)
  • Line 251: warning: exported method Mosn.CleanUpgrade should have comment or be unexported (golint)
  • Line 269: warning: exported method Mosn.StartXdsClient should have comment or be unexported (golint)
  • Line 279: warning: exported method Mosn.HandleExtendConfig should have comment or be unexported (golint)
  • Line 292: warning: exported method Mosn.Start should have comment or be unexported (golint)
  • Line 319: warning: exported method Mosn.Wait should have comment or be unexported (golint)
  • Line 323: warning: exported method Mosn.Close should have comment or be unexported (golint)

• sofa-mosn/pkg/variable/var.go
  • Line 22: warning: comment on exported type BasicVariable should be of the form "BasicVariable ..." (with optional leading article) (golint)
  • Line 32: warning: exported method BasicVariable.Name should have comment or be unexported (golint)
  • Line 36: warning: exported method BasicVariable.Data should have comment or be unexported (golint)
  • Line 40: warning: exported method BasicVariable.Flags should have comment or be unexported (golint)
  • Line 44: warning: exported method BasicVariable.Setter should have comment or be unexported (golint)
  • Line 48: warning: exported method BasicVariable.Getter should have comment or be unexported (golint)
  • Line 52: warning: comment on exported type IndexedVariable should be of the form "IndexedVariable ..." (with optional leading article) (golint)
  • Line 60: warning: exported method IndexedVariable.SetIndex should have comment or be unexported (golint)
  • Line 64: warning: exported method IndexedVariable.GetIndex should have comment or be unexported (golint)
  • Line 68: warning: comment on exported function NewBasicVariable should be of the form "NewBasicVariable ..." (golint)
  • Line 79: warning: comment on exported function NewIndexedVariable should be of the form "NewIndexedVariable ..." (golint)

• sofa-mosn/test/lib/mosn/mosn.go
  • Line 17: warning: exported type MosnOperator should have comment or be unexported (golint)
  • Line 23: warning: exported function NewMosnOperator should have comment or be unexported (golint)
  • Line 31: warning: exported method MosnOperator.Start should have comment or be unexported (golint)
  • Line 48: warning: exported method MosnOperator.Stop should have comment or be unexported (golint)
  • Line 52: warning: comment on exported method MosnOperator.Restart should be of the form "Restart ..." (golint)
  • Line 58: warning: exported method MosnOperator.UpdateConfig should have comment or be unexported (golint)
  • Line 76: warning: exported method MosnOperator.UpdateRoute should have comment or be unexported (golint)
  • Line 94: warning: exported method MosnOperator.GetMosnConfig should have comment or be unexported (golint)
  • Line 107: warning: exported method MosnOperator.GetMosnMetrics should have comment or be unexported (golint)
  • Line 120: warning: exported method MosnOperator.LoadMosnConfig should have comment or be unexported (golint)
  • Line 126: warning: exported function StartMosn should have comment or be unexported (golint)
  • Line 144: warning: exported const TempTestConfig should have comment or be unexported (golint)
  • Line 146: warning: exported function WriteTestConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/featuregate/mosn_features.go
  • Line 21: warning: exported const XdsMtlsEnable should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/filter/stream/transcoder/types.go
  • Line 27: warning: exported const RequestTranscodeFail should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/util.go
  • Line 37: warning: comment on exported method IDGenerator.GetString should be of the form "GetString ..." (golint)

• sofa-mosn/examples/codes/mosn-extensions/plugin/filter/checker_filter.go
  • Line 18: warning: exported function CreateDemoFactory should have comment or be unexported (golint)
  • Line 44: warning: exported type DemoFilter should have comment or be unexported (golint)
  • Line 49: warning: exported function NewDemoFilter should have comment or be unexported (golint)
  • Line 55: warning: exported method DemoFilter.SetReceiveFilterHandler should have comment or be unexported (golint)
  • Line 59: warning: exported method DemoFilter.OnDestroy should have comment or be unexported (golint)
  • Line 61: warning: exported method DemoFilter.OnReceive should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/dubbo/command.go
  • Line 28: warning: exported type Header should have comment or be unexported (golint)
  • Line 42: warning: exported type Frame should have comment or be unexported (golint)
  • Line 53: warning: comment on exported method Frame.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 58: warning: exported method Frame.SetRequestId should have comment or be unexported (golint)
  • Line 62: warning: exported method Frame.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 66: warning: comment on exported method Frame.GetTimeout should be of the form "GetTimeout ..." (golint)
  • Line 72: warning: exported method Frame.GetStreamType should have comment or be unexported (golint)
  • Line 83: warning: exported method Frame.GetHeader should have comment or be unexported (golint)
  • Line 87: warning: exported method Frame.GetData should have comment or be unexported (golint)
  • Line 91: warning: exported method Frame.SetData should have comment or be unexported (golint)
  • Line 97: warning: exported method Frame.GetStatusCode should have comment or be unexported (golint)
  • Line 101: warning: exported method Frame.Clone should have comment or be unexported (golint)

• sofa-mosn/cmd/mosn/main/control.go
  • Line 171: warning: exported function DefaultParamsParsed should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/regulator/invocation_dimension_factory.go
  • Line 29: warning: exported type NewDimension should have comment or be unexported (golint)
  • Line 33: warning: exported function RegisterNewDimension should have comment or be unexported (golint)
  • Line 37: warning: exported function GetNewDimensionFunc should have comment or be unexported (golint)
  • Line 57: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/filter/network/grpc/filter.go
  • Line 35: warning: comment on exported function NewGrpcFilter should be of the form "NewGrpcFilter ..." (golint)

• sofa-mosn/pkg/config/v2/wasm.go
  • Line 20: warning: exported type WasmPluginConfig should have comment or be unexported (golint)
  • Line 26: warning: exported type WasmVmConfig should have comment or be unexported (golint)
  • Line 34: warning: exported method WasmPluginConfig.Clone should have comment or be unexported (golint)

• sofa-mosn/pkg/network/connection.go
  • Line 290: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 313: warning: exported var OptimizeLocalWrite should have comment or be unexported (golint)
  • Line 315: warning: exported function SetOptimizeLocalWrite should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faultinject/faultinject.go
  • Line 88: warning: exported function NewFilter should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/gzip/factory.go
  • Line 34: warning: exported type FilterConfigFactory should have comment or be unexported (golint)
  • Line 38: warning: exported method FilterConfigFactory.CreateFilterChain should have comment or be unexported (golint)
  • Line 44: warning: exported function CreateGzipFilterFactory should have comment or be unexported (golint)
  • Line 57: warning: comment on exported function ParseStreamGzipFilter should be of the form "ParseStreamGzipFilter ..." (golint)

• sofa-mosn/pkg/config/v2/skywalking.go
  • Line 21: warning: exported const LogReporter should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type SkyWalkingTraceConfig should have comment or be unexported (golint)
  • Line 35: warning: exported type SkyWalkingTraceTLSConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/tars/command.go
  • Line 28: warning: exported type Request should have comment or be unexported (golint)
  • Line 37: warning: comment on exported method Request.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 42: warning: exported method Request.SetRequestId should have comment or be unexported (golint)
  • Line 46: warning: exported method Request.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 51: warning: comment on exported method Request.GetTimeout should be of the form "GetTimeout ..." (golint)
  • Line 56: warning: exported method Request.GetStreamType should have comment or be unexported (golint)
  • Line 60: warning: exported method Request.GetHeader should have comment or be unexported (golint)
  • Line 64: warning: exported method Request.GetData should have comment or be unexported (golint)
  • Line 68: warning: exported method Request.SetData should have comment or be unexported (golint)
  • Line 72: warning: exported type Response should have comment or be unexported (golint)
  • Line 81: warning: comment on exported method Response.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 86: warning: exported method Response.SetRequestId should have comment or be unexported (golint)
  • Line 90: warning: exported method Response.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 95: warning: comment on exported method Response.GetTimeout should be of the form "GetTimeout ..." (golint)
  • Line 100: warning: exported method Response.GetStreamType should have comment or be unexported (golint)
  • Line 104: warning: exported method Response.GetHeader should have comment or be unexported (golint)
  • Line 108: warning: exported method Response.GetData should have comment or be unexported (golint)
  • Line 112: warning: exported method Response.SetData should have comment or be unexported (golint)
  • Line 116: warning: exported method Response.GetStatusCode should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/tars/types.go
  • Line 21: warning: exported const ProtocolName should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported const MessageSizeLen should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported const CmdTypeResponse should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: exported const ServiceNameHeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported const ResponseStatusSuccess should have comment (or a comment on this block) or be unexported (golint)

• sofa-mosn/pkg/upstream/cluster/tls.go
  • Line 31: warning: exported function DisableClientSideTLS should have comment or be unexported (golint)
  • Line 35: warning: exported function EnableClientSideTLS should have comment or be unexported (golint)

• sofa-mosn/pkg/module/http2/transport_test.go
  • Line 1334: warning: don't use underscores in Go names; func testTransportInvalidTrailer_Pseudo should be testTransportInvalidTrailerPseudo (golint)
  • Line 1347: warning: don't use underscores in Go names; func testTransportInvalidTrailer_Capital should be testTransportInvalidTrailerCapital (golint)

• sofa-mosn/pkg/config/v2/proxy.go
  • Line 22: warning: comment on exported type StreamProxy should be of the form "StreamProxy ..." (with optional leading article) (golint)
  • Line 31: warning: comment on exported type WebSocketProxy should be of the form "WebSocketProxy ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported type Proxy should be of the form "Proxy ..." (with optional leading article) (golint)

• sofa-mosn/pkg/config/v2/tls.go
  • Line 49: warning: exported type SdsConfig should have comment or be unexported (golint)
  • Line 54: warning: exported type SecretConfigWrapper should have comment or be unexported (golint)
  • Line 58: warning: exported method SecretConfigWrapper.MarshalJSON should have comment or be unexported (golint)
  • Line 65: warning: exported method SecretConfigWrapper.UnmarshalJSON should have comment or be unexported (golint)

• sofa-mosn/pkg/log/accesslog.go
  • Line 43: warning: exported const AccessLogLen should have comment or be unexported (golint)
  • Line 49: warning: exported function DisableAllAccessLog should have comment or be unexported (golint)
  • Line 56: warning: exported function EnableAllAccessLog should have comment or be unexported (golint)
  • Line 88: warning: comment on exported function NewAccessLog should be of the form "NewAccessLog ..." (golint)

• sofa-mosn/pkg/protocol/http2/types.go
  • Line 28: warning: exported type HeaderMap should have comment or be unexported (golint)
  • Line 32: warning: exported type ReqHeader should have comment or be unexported (golint)
  • Line 37: warning: exported type RspHeader should have comment or be unexported (golint)
  • Line 42: warning: exported function NewHeaderMap should have comment or be unexported (golint)
  • Line 48: warning: exported function NewReqHeader should have comment or be unexported (golint)
  • Line 55: warning: exported function NewRspHeader should have comment or be unexported (golint)
  • Line 72: warning: comment on exported method HeaderMap.Set should be of the form "Set ..." (golint)
  • Line 79: warning: comment on exported method HeaderMap.Add should be of the form "Add ..." (golint)
  • Line 89: warning: exported method HeaderMap.Clone should have comment or be unexported (golint)
  • Line 101: warning: exported method ReqHeader.Clone should have comment or be unexported (golint)
  • Line 110: warning: exported method ReqHeader.Get should have comment or be unexported (golint)
  • Line 126: warning: exported method RspHeader.Clone should have comment or be unexported (golint)
  • Line 146: warning: exported method HeaderMap.ByteSize should have comment or be unexported (golint)
  • Line 155: warning: exported function EncodeHeader should have comment or be unexported (golint)
  • Line 164: warning: exported function DecodeHeader should have comment or be unexported (golint)

• sofa-mosn/test/lib/http/server.go
  • Line 17: warning: exported type MockHttpServer should have comment or be unexported (golint)
  • Line 28: warning: exported function NewHTTPServer should have comment or be unexported (golint)
  • Line 81: warning: exported method MockHttpServer.Start should have comment or be unexported (golint)
  • Line 101: warning: exported method MockHttpServer.Stop should have comment or be unexported (golint)
  • Line 108: warning: exported method MockHttpServer.Stats should have comment or be unexported (golint)

• sofa-mosn/test/integrate/case.go
  • Line 18: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 33: warning: exported type TestCase should have comment or be unexported (golint)
  • Line 44: warning: exported function NewTestCase should have comment or be unexported (golint)
  • Line 55: warning: comment on exported method TestCase.StartProxy should be of the form "StartProxy ..." (golint)
  • Line 75: warning: comment on exported method TestCase.Start should be of the form "Start ..." (golint)
  • Line 94: warning: comment on exported method TestCase.FinishCase should be of the form "FinishCase ..." (golint)
  • Line 100: warning: exported const HTTPTestPath should have comment or be unexported (golint)
  • Line 102: warning: comment on exported method TestCase.RunCase should be of the form "RunCase ..." (golint)
  • Line 164: warning: comment on exported type XTestCase should be of the form "XTestCase ..." (with optional leading article) (golint)
  • Line 170: warning: exported function NewXTestCase should have comment or be unexported (golint)
  • Line 184: warning: comment on exported method XTestCase.StartProxy should be of the form "StartProxy ..." (golint)
  • Line 204: warning: exported method XTestCase.Start should have comment or be unexported (golint)
  • Line 222: warning: comment on exported method XTestCase.RunCase should be of the form "RunCase ..." (golint)

• sofa-mosn/test/util/server.go
  • Line 16: warning: exported type UpstreamServer should have comment or be unexported (golint)
  • Line 22: warning: exported type ServeConn should have comment or be unexported (golint)
  • Line 33: warning: exported function NewUpstreamServer should have comment or be unexported (golint)
  • Line 101: warning: comment on exported type HTTPHandler should be of the form "HTTPHandler ..." (with optional leading article) (golint)
  • Line 111: warning: exported type HTTP2Server should have comment or be unexported (golint)
  • Line 117: warning: exported method HTTP2Server.ServeConn should have comment or be unexported (golint)
  • Line 121: warning: exported function NewUpstreamHTTP2 should have comment or be unexported (golint)
  • Line 133: warning: comment on exported type HTTPServer should be of the form "HTTPServer ..." (with optional leading article) (golint)
  • Line 140: warning: exported method HTTPServer.GoServe should have comment or be unexported (golint)
  • Line 143: warning: exported method HTTPServer.Close should have comment or be unexported (golint)
  • Line 146: warning: exported method HTTPServer.Addr should have comment or be unexported (golint)
  • Line 154: warning: exported function NewHTTPServer should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/impl.go
  • Line 38: warning: comment on exported type AbiV2Impl should be of the form "AbiV2Impl ..." (with optional leading article) (golint)
  • Line 43: warning: exported method AbiV2Impl.Name should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/faulttolerance/config/fault_tolerance_config.go
  • Line 20: warning: exported type FaultToleranceRuleJson should have comment or be unexported (golint)

• sofa-mosn/pkg/admin/server/types.go
  • Line 4: warning: should not use dot imports (golint)
  • Line 7: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)

• sofa-mosn/pkg/log/errorlog.go
  • Line 24: warning: exported function CreateDefaultErrorLogger should have comment or be unexported (golint)

• sofa-mosn/pkg/shm/shm.go
  • Line 28: warning: exported function Alloc should have comment or be unexported (golint)
  • Line 65: warning: exported function Free should have comment or be unexported (golint)
  • Line 70: warning: exported function Clear should have comment or be unexported (golint)

• sofa-mosn/pkg/network/requestinfo.go
  • Line 30: warning: comment on exported type RequestInfo should be of the form "RequestInfo ..." (with optional leading article) (golint)
  • Line 57: warning: comment on exported function NewRequestInfo should be of the form "NewRequestInfo ..." (golint)
  • Line 64: warning: exported method RequestInfo.StartTime should have comment or be unexported (golint)
  • Line 68: warning: exported method RequestInfo.SetStartTime should have comment or be unexported (golint)
  • Line 72: warning: exported method RequestInfo.RequestReceivedDuration should have comment or be unexported (golint)
  • Line 76: warning: exported method RequestInfo.SetRequestReceivedDuration should have comment or be unexported (golint)
  • Line 80: warning: exported method RequestInfo.ResponseReceivedDuration should have comment or be unexported (golint)
  • Line 84: warning: exported method RequestInfo.SetResponseReceivedDuration should have comment or be unexported (golint)
  • Line 88: warning: exported method RequestInfo.RequestFinishedDuration should have comment or be unexported (golint)
  • Line 92: warning: exported method RequestInfo.SetRequestFinishedDuration should have comment or be unexported (golint)
  • Line 97: warning: exported method RequestInfo.ProcessTimeDuration should have comment or be unexported (golint)
  • Line 101: warning: exported method RequestInfo.SetProcessTimeDuration should have comment or be unexported (golint)
  • Line 105: warning: exported method RequestInfo.BytesSent should have comment or be unexported (golint)
  • Line 109: warning: exported method RequestInfo.SetBytesSent should have comment or be unexported (golint)
  • Line 113: warning: exported method RequestInfo.BytesReceived should have comment or be unexported (golint)
  • Line 117: warning: exported method RequestInfo.SetBytesReceived should have comment or be unexported (golint)
  • Line 121: warning: exported method RequestInfo.Protocol should have comment or be unexported (golint)
  • Line 125: warning: exported method RequestInfo.SetProtocol should have comment or be unexported (golint)
  • Line 129: warning: exported method RequestInfo.ResponseCode should have comment or be unexported (golint)
  • Line 133: warning: exported method RequestInfo.SetResponseCode should have comment or be unexported (golint)
  • Line 137: warning: exported method RequestInfo.Duration should have comment or be unexported (golint)
  • Line 141: warning: exported method RequestInfo.GetResponseFlag should have comment or be unexported (golint)
  • Line 145: warning: exported method RequestInfo.GetResponseFlagResult should have comment or be unexported (golint)
  • Line 149: warning: exported method RequestInfo.SetResponseFlag should have comment or be unexported (golint)
  • Line 153: warning: exported method RequestInfo.UpstreamHost should have comment or be unexported (golint)
  • Line 157: warning: exported method RequestInfo.OnUpstreamHostSelected should have comment or be unexported (golint)
  • Line 161: warning: exported method RequestInfo.UpstreamLocalAddress should have comment or be unexported (golint)
  • Line 165: warning: exported method RequestInfo.SetUpstreamLocalAddress should have comment or be unexported (golint)
  • Line 169: warning: exported method RequestInfo.IsHealthCheck should have comment or be unexported (golint)
  • Line 173: warning: exported method RequestInfo.SetHealthCheck should have comment or be unexported (golint)
  • Line 177: warning: exported method RequestInfo.DownstreamLocalAddress should have comment or be unexported (golint)
  • Line 181: warning: exported method RequestInfo.SetDownstreamLocalAddress should have comment or be unexported (golint)
  • Line 185: warning: exported method RequestInfo.DownstreamRemoteAddress should have comment or be unexported (golint)
  • Line 189: warning: exported method RequestInfo.SetDownstreamRemoteAddress should have comment or be unexported (golint)
  • Line 193: warning: exported method RequestInfo.RouteEntry should have comment or be unexported (golint)
  • Line 197: warning: exported method RequestInfo.SetRouteEntry should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/idgen.go
  • Line 34: warning: exported type IdGenerator should have comment or be unexported (golint)
  • Line 40: warning: exported type SpanKey should have comment or be unexported (golint)
  • Line 45: warning: exported method SpanKey.UniqueKey should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type SpanIdGenerator should be of the form "SpanIdGenerator ..." (with optional leading article) (golint)
  • Line 55: warning: exported method SpanIdGenerator.GenerateNextChildIndex should have comment or be unexported (golint)
  • Line 60: warning: exported function IdGen should have comment or be unexported (golint)
  • Line 64: warning: exported function NewSpanIdGenerator should have comment or be unexported (golint)
  • Line 74: warning: exported function AddSpanIdGenerator should have comment or be unexported (golint)
  • Line 78: warning: exported function GetSpanIdGenerator should have comment or be unexported (golint)
  • Line 82: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 87: warning: exported function DeleteSpanIdGenerator should have comment or be unexported (golint)
  • Line 102: warning: exported method IdGenerator.GenerateTraceId should have comment or be unexported (golint)
  • Line 118: warning: exported function GetIp should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/dubbothrift/command.go
  • Line 30: warning: exported type Header should have comment or be unexported (golint)
  • Line 41: warning: exported type Frame should have comment or be unexported (golint)
  • Line 52: warning: comment on exported method Frame.GetRequestId should be of the form "GetRequestId ..." (golint)
  • Line 57: warning: exported method Frame.SetRequestId should have comment or be unexported (golint)
  • Line 61: warning: exported method Frame.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 66: warning: comment on exported method Frame.GetTimeout should be of the form "GetTimeout ..." (golint)
  • Line 72: warning: exported method Frame.GetStreamType should have comment or be unexported (golint)
  • Line 83: warning: exported method Frame.GetHeader should have comment or be unexported (golint)
  • Line 87: warning: exported method Frame.GetData should have comment or be unexported (golint)
  • Line 91: warning: exported method Frame.SetData should have comment or be unexported (golint)
  • Line 96: warning: exported method Frame.GetStatusCode should have comment or be unexported (golint)
  • Line 104: warning: exported method Frame.Clone should have comment or be unexported (golint)

• sofa-mosn/pkg/upstream/servicediscovery/dubbod/common.go
  • Line 1: warning: package comment should be of the form "Package dubbod ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• sofa-mosn/pkg/upstream/cluster/strict_dns_cluster.go
  • Line 51: warning: exported var DefaultRefreshTimeout should have comment or be unexported (golint)
  • Line 52: warning: exported var DefaultRefreshInterval should have comment or be unexported (golint)
  • Line 54: warning: exported type ResolveTarget should have comment or be unexported (golint)
  • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 233: warning: exported method ResolveTarget.StopResolve should have comment or be unexported (golint)
  • Line 237: warning: exported method ResolveTarget.StartResolve should have comment or be unexported (golint)
  • Line 280: warning: exported method ResolveTarget.OnTimeout should have comment or be unexported (golint)
  • Line 284: warning: exported method ResolveTarget.OnResolve should have comment or be unexported (golint)

• sofa-mosn/pkg/mtls/crypto/tls/conn_test.go
  • Line 113: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• sofa-mosn/pkg/filter/stream/dubbo/var.go
  • Line 21: warning: exported function Init should have comment or be unexported (golint)

• sofa-mosn/pkg/trace/sofa/log.go
  • Line 37: warning: exported var ErrIngressLogger should have comment or be unexported (golint)
  • Line 41: warning: exported function Init should have comment or be unexported (golint)
  • Line 81: warning: exported function GetIngressLogger should have comment or be unexported (golint)
  • Line 85: warning: exported function GetEgressLogger should have comment or be unexported (golint)

• sofa-mosn/pkg/network/dns.go
  • Line 30: warning: exported const V4Only should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported var DefaultResolverFile should have comment or be unexported (golint)
  • Line 37: warning: exported type DnsResolver should have comment or be unexported (golint)
  • Line 42: warning: exported type DnsResponse should have comment or be unexported (golint)
  • Line 47: warning: exported function NewDnsResolver should have comment or be unexported (golint)
  • Line 62: warning: exported function NewDnsResolverFromFile should have comment or be unexported (golint)
  • Line 110: warning: exported method DnsResolver.DnsResolve should have comment or be unexported (golint)

• sofa-mosn/pkg/network/udpreceiver.go
  • Line 31: warning: exported const UdpPacketMaxSize should have comment or be unexported (golint)
  • Line 34: warning: exported var ProxyMap should have comment or be unexported (golint)
  • Line 37: warning: exported function GetProxyMapKey should have comment or be unexported (golint)
  • Line 45: warning: exported function SetUDPProxyMap should have comment or be unexported (golint)
  • Line 49: warning: exported function DelUDPProxyMap should have comment or be unexported (golint)

• sofa-mosn/pkg/protocol/xprotocol/wasm/command.go
  • Line 26: warning: exported type RpcHeader should have comment or be unexported (golint)
  • Line 36: warning: exported type RequestHeader should have comment or be unexported (golint)
  • Line 41: warning: exported method RequestHeader.Clone should have comment or be unexported (golint)
  • Line 51: warning: exported type Request should have comment or be unexported (golint)
  • Line 61: warning: exported method Request.GetTimeout should have comment or be unexported (golint)
  • Line 65: warning: exported method Request.GetRequestId should have comment or be unexported (golint)
  • Line 69: warning: exported method Request.GetId should have comment or be unexported (golint)
  • Line 73: warning: exported method Request.SetRequestId should have comment or be unexported (golint)
  • Line 81: warning: exported method Request.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 85: warning: exported method Request.GetStreamType should have comment or be unexported (golint)
  • Line 97: warning: exported method Request.GetHeader should have comment or be unexported (golint)
  • Line 101: warning: exported method Request.GetData should have comment or be unexported (golint)
  • Line 105: warning: exported method Request.SetData should have comment or be unexported (golint)
  • Line 123: warning: exported type ResponseHeader should have comment or be unexported (golint)
  • Line 128: warning: exported method ResponseHeader.Clone should have comment or be unexported (golint)
  • Line 138: warning: exported type Response should have comment or be unexported (golint)
  • Line 148: warning: exported method Response.GetRequestId should have comment or be unexported (golint)
  • Line 152: warning: exported method Response.SetRequestId should have comment or be unexported (golint)
  • Line 159: warning: exported method Response.IsHeartbeatFrame should have comment or be unexported (golint)
  • Line 163: warning: exported method Response.GetStreamType should have comment or be unexported (golint)
  • Line 167: warning: exported method Response.GetHeader should have comment or be unexported (golint)
  • Line 171: warning: exported method Response.GetData should have comment or be unexported (golint)
  • Line 175: warning: exported method Response.SetData should have comment or be unexported (golint)
  • Line 182: warning: exported method Response.GetStatusCode should have comment or be unexported (golint)
  • Line 186: warning: exported method Response.GetId should have comment or be unexported (golint)
  • Line 190: warning: exported method Response.GetTimeout should have comment or be unexported (golint)

• sofa-mosn/examples/codes/protocol-auto-sample/server.go
  • Line 8: warning: exported function ServeHTTP should have comment or be unexported (golint)

• sofa-mosn/pkg/configmanager/dump_test.go
  • Line 132: warning: don't use underscores in Go names; var read_clusters should be readClusters (golint)

• sofa-mosn/pkg/configmanager/load_config_test.go
  • Line 28: warning: don't use underscores in Go names; var dynamic_mode should be dynamicMode (golint)
  • Line 33: warning: don't use underscores in Go names; var static_mode should be staticMode (golint)

• sofa-mosn/pkg/module/http2/h2i/h2i.go
  • Line 316: warning: receiver name a should be consistent with previous receiver name app for h2i (golint)
  • Line 324: warning: receiver name a should be consistent with previous receiver name app for h2i (golint)

• sofa-mosn/pkg/trace/driver.go
  • Line 61: warning: exported function NewDefaultDriverImpl should have comment or be unexported (golint)

• sofa-mosn/pkg/filter/stream/dubbo/stats.go
  • Line 13: warning: exported var ServiceInfo should have comment or be unexported (golint)
  • Line 32: warning: exported type Stats should have comment or be unexported (golint)

• sofa-mosn/pkg/configmanager/effectiveconfig_test.go
  • Line 253: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• sofa-mosn/pkg/protocol/xprotocol/dubbo/protocol.go
  • Line 60: warning: exported var MagicTag should have comment or be unexported (golint)

• sofa-mosn/pkg/metrics/store.go
  • Line 32: warning: exported const MaxLabelCount should have comment or be unexported (golint)
  • Line 37: warning: exported var ErrLabelCountExceeded should have comment or be unexported (golint)
  • Line 222: warning: comment on exported function GetMetricsFilter should be of the form "GetMetricsFilter ..." (golint)

• sofa-mosn/examples/codes/filter/mirror/http2/main.go
  • Line 49: warning: exported function Encrypt should have comment or be unexported (golint)
  • Line 53: warning: exported function EncryptBytes should have comment or be unexported (golint)

• sofa-mosn/pkg/network/idlechecker_test.go
  • Line 141: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)

• sofa-mosn/pkg/stream/http2/stream.go
  • Line 84: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 150: warning: exported type StreamConfig should have comment or be unexported (golint)

• sofa-mosn/pkg/wasm/abi/ext/xproxywasm020/interface.go
  • Line 26: warning: exported type Exports should have comment or be unexported (golint)

• sofa-mosn/pkg/stream/http/connpool.go
  • Line 57: warning: exported function NewConnPool should have comment or be unexported (golint)
  • Line 140: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• sofa-mosn/pkg/router/routers_manager_test.go
  • Line 273: warning: don't use underscores in Go names; var routers0_ should be routers0 (golint)
  • Line 274: warning: don't use underscores in Go names; var routers1_ should be routers1 (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• sofa-mosn/pkg/filter/network/streamproxy/streamproxy.go
  • Line 341: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/filter/stream/flowcontrol/callbacks_test.go
  • Line 39: warning: ineffectual assignment to ctx (ineffassign)

• sofa-mosn/pkg/metrics/shm/hashset_test.go
  • Line 96: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/log/logger_manager_test.go
  • Line 230: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/log/proxylog_test.go
  • Line 56: warning: ineffectual assignment to err (ineffassign)
  • Line 93: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/examples/codes/udpproxy-sample/udp.go
  • Line 87: warning: ineffectual assignment to n (ineffassign)

• sofa-mosn/pkg/trace/sofa/xprotocol/span.go
  • Line 180: warning: ineffectual assignment to code (ineffassign)

• sofa-mosn/pkg/admin/store/service_test.go
  • Line 95: warning: ineffectual assignment to err (ineffassign)
  • Line 120: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/xds/v2/xdsconfig.go
  • Line 275: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/upstream/cluster/loadbalancer_test.go
  • Line 280: warning: ineffectual assignment to actual (ineffassign)

• sofa-mosn/pkg/plugin/plugin_test.go
  • Line 44: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/shm/shm_test.go
  • Line 44: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/server/reconfigure.go
  • Line 105: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/variable/protocolres_test.go
  • Line 66: warning: ineffectual assignment to vv (ineffassign)

• sofa-mosn/test/integrate/protocol_auto_test.go
  • Line 95: warning: ineffectual assignment to err (ineffassign)
  • Line 101: warning: ineffectual assignment to prot (ineffassign)
  • Line 106: warning: ineffectual assignment to prot (ineffassign)
  • Line 118: warning: ineffectual assignment to err (ineffassign)
  • Line 124: warning: ineffectual assignment to err (ineffassign)
  • Line 130: warning: ineffectual assignment to prot (ineffassign)
  • Line 136: warning: ineffectual assignment to prot (ineffassign)
  • Line 193: warning: ineffectual assignment to err (ineffassign)
  • Line 202: warning: ineffectual assignment to err (ineffassign)
  • Line 220: warning: ineffectual assignment to prot (ineffassign)

• sofa-mosn/pkg/filter/listener/originaldst/originaldst.go
  • Line 46: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/mtls/mock_test.go
  • Line 95: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/protocol/xprotocol/dubbothrift/protocol_test.go
  • Line 109: warning: ineffectual assignment to err (ineffassign)

• sofa-mosn/pkg/stream/xprotocol/connpool_binding_test.go
  • Line 103: warning: ineffectual assignment to host (ineffassign)
  • Line 148: warning: ineffectual assignment to host (ineffassign)

• sofa-mosn/pkg/module/http2/mhttp2.go
  • Line 1143: warning: ineffectual assignment to err (ineffassign)

misspell95%

Misspell Finds commonly misspelled English words

• sofa-mosn/pkg/filter/network/grpc/factory.go
  • Line 175: warning: "becasue" is a misspelling of "because" (misspell)

• sofa-mosn/pkg/log/logger_manager_test.go
  • Line 93: warning: "controled" is a misspelling of "controlled" (misspell)

• sofa-mosn/pkg/stream/xprotocol/keepalive_test.go
  • Line 83: warning: "conenction" is a misspelling of "connection" (misspell)

• sofa-mosn/pkg/module/http2/mhttp2.go
  • Line 988: warning: "conncetion" is a misspelling of "connections" (misspell)

• sofa-mosn/test/integrate/xds_config_test.go
  • Line 111: warning: "unkown" is a misspelling of "unknown" (misspell)
  • Line 138: warning: "listners" is a misspelling of "listeners" (misspell)

• sofa-mosn/examples/codes/xprotocol_with_goplugin_example/codec/protocol.go
  • Line 62: warning: "responce" is a misspelling of "response" (misspell)
  • Line 62: warning: "responce" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/module/http2/h2c/h2c.go
  • Line 335: warning: "withold" is a misspelling of "withhold" (misspell)

• sofa-mosn/pkg/mtls/sds/sdsclient_test.go
  • Line 92: warning: "reponse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/router/routers_manager.go
  • Line 84: warning: "becasue" is a misspelling of "because" (misspell)

• sofa-mosn/test/cases/streamfilter/terminate/terminate_test.go
  • Line 29: warning: "becasue" is a misspelling of "because" (misspell)

• sofa-mosn/examples/codes/filter/transcoder/server.go
  • Line 106: warning: "reponse" is a misspelling of "response" (misspell)
  • Line 112: warning: "reponse" is a misspelling of "response" (misspell)

• sofa-mosn/examples/codes/sofarpc-with-xprotocol-sample/server.go
  • Line 104: warning: "reponse" is a misspelling of "response" (misspell)
  • Line 108: warning: "reponse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/mtls/sds/subscriber.go
  • Line 168: warning: "repsonse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/configmanager/configmanager.go
  • Line 23: warning: "compatiable" is a misspelling of "compatible" (misspell)

• sofa-mosn/pkg/networkextention/discovery/factory.go
  • Line 26: warning: "discoverys" is a misspelling of "discovers" (misspell)

• sofa-mosn/test/framework/assert.go
  • Line 9: warning: "fucntions" is a misspelling of "functions" (misspell)

• sofa-mosn/examples/codes/tcpproxy-sample/rpc_server.go
  • Line 104: warning: "reponse" is a misspelling of "response" (misspell)
  • Line 108: warning: "reponse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/config/v2/extend.go
  • Line 44: warning: "registed" is a misspelling of "registered" (misspell)

• sofa-mosn/pkg/config/v2/json_test.go
  • Line 560: warning: "vitrual" is a misspelling of "virtual" (misspell)

• sofa-mosn/pkg/upstream/cluster/cluster_healthcheck_test.go
  • Line 62: warning: "addtional" is a misspelling of "additional" (misspell)

• sofa-mosn/pkg/upstream/cluster/cluster_manager.go
  • Line 394: warning: "becasue" is a misspelling of "because" (misspell)

• sofa-mosn/test/integrate/retry_test.go
  • Line 123: warning: "reponse" is a misspelling of "response" (misspell)
  • Line 293: warning: "reponse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/upstream/cluster/original_dst.go
  • Line 81: warning: "useing" is a misspelling of "using" (misspell)

• sofa-mosn/pkg/mtls/crypto/tls/handshake_client_test.go
  • Line 31: warning: "accelleration" is a misspelling of "acceleration" (misspell)

• sofa-mosn/pkg/networkextention/l7_golang_extention.go
  • Line 136: warning: "extention" is a misspelling of "extension" (misspell)
  • Line 158: warning: "extention" is a misspelling of "extension" (misspell)
  • Line 200: warning: "extention" is a misspelling of "extension" (misspell)
  • Line 238: warning: "extention" is a misspelling of "extension" (misspell)

• sofa-mosn/pkg/upstream/cluster/host_set.go
  • Line 34: warning: "becasue" is a misspelling of "because" (misspell)

• sofa-mosn/test/lib/http/config.go
  • Line 41: warning: "repsonse" is a misspelling of "response" (misspell)
  • Line 105: warning: "repsonse" is a misspelling of "response" (misspell)

• sofa-mosn/test/lib/xprotocol/boltv1/config.go
  • Line 96: warning: "repsonse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/stream/http/stream_test.go
  • Line 150: warning: "reponse" is a misspelling of "response" (misspell)
  • Line 181: warning: "reponse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/router/base_rule.go
  • Line 137: warning: "repsonse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/types/alias.go
  • Line 25: warning: "compatiable" is a misspelling of "compatible" (misspell)

• sofa-mosn/pkg/proxy/streamfilters_test.go
  • Line 301: warning: "repsonse" is a misspelling of "response" (misspell)

• sofa-mosn/pkg/wasm/manager_test.go
  • Line 174: warning: "shrinked" is a misspelling of "shrunk" (misspell)

• sofa-mosn/cmd/mosn/main/control.go
  • Line 131: warning: "registerd" is a misspelling of "registered" (misspell)

• sofa-mosn/pkg/filter/stream/mirror/mirror.go
  • Line 62: warning: "protocal" is a misspelling of "protocol" (misspell)

• sofa-mosn/pkg/protocol/xprotocol/dubbothrift/command.go
  • Line 66: warning: "defualt" is a misspelling of "default" (misspell)