Preparing report...

Report for github.com/alvinlaw/go-etherdelta

A+    Excellent!    Found 6 issues across 16 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • go-etherdelta/etherdelta.go
    • Line 276: warning: cyclomatic complexity 36 of function (*Service).GetTokenTicker() is high (> 15) (gocyclo)
    • Line 85: warning: cyclomatic complexity 29 of function (*Service).GetOrderBook() is high (> 15) (gocyclo)

golint68%

Golint is a linter for Go source code.

    • go-etherdelta/types.go
    • Line 109: warning: comment on exported type MakeTradeOpts should be of the form "MakeTradeOpts ..." (with optional leading article) (golint)
    • go-etherdelta/helpers/ethereum.go
    • Line 15: warning: exported function DecimalsToWei should have comment or be unexported (golint)
    • Line 25: warning: exported function EthToWei should have comment or be unexported (golint)
    • Line 30: warning: exported function GetAccountBalance should have comment or be unexported (golint)
    • Line 41: warning: exported function GetTokenBalance should have comment or be unexported (golint)
    • Line 61: warning: exported function GetTokenAllowance should have comment or be unexported (golint)
    • Line 82: warning: exported function GetTokenDecimals should have comment or be unexported (golint)
    • Line 102: warning: exported function TransferTokens should have comment or be unexported (golint)
    • Line 120: warning: exported function GetLatestBlockNumber should have comment or be unexported (golint)
    • Line 126: warning: exported function GetSigRSV should have comment or be unexported (golint)
    • Line 138: warning: exported function GetSigRSVBytes should have comment or be unexported (golint)
    • go-etherdelta/helpers/ethereum_test.go
    • Line 47: warning: don't use underscores in Go names; var expected_R should be expectedR (golint)
    • Line 48: warning: don't use underscores in Go names; var expected_S should be expectedS (golint)
    • Line 49: warning: don't use underscores in Go names; var expected_V should be expectedV (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!