Preparing report...

Report for github.com/ant-libs-go/redis

A    Great!    Found 6 issues across 6 files

Tweet

gofmt83%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint16%

Golint is a linter for Go source code.

    • redis/storer/storer.go
    • Line 15: warning: exported type Operator should have comment or be unexported (golint)
    • Line 24: warning: exported type Storer should have comment or be unexported (golint)
    • Line 31: warning: exported function NewStorer should have comment or be unexported (golint)
    • Line 50: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 71: warning: exported method Storer.Reload should have comment or be unexported (golint)
    • Line 71: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 75: warning: exported method Storer.GetOperator should have comment or be unexported (golint)
    • Line 75: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 79: warning: exported method Storer.GetToken should have comment or be unexported (golint)
    • Line 79: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 83: warning: exported method Storer.Release should have comment or be unexported (golint)
    • Line 83: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • redis/timer/timer.go
    • Line 20: warning: exported type Timer should have comment or be unexported (golint)
    • Line 28: warning: exported function NewTimer should have comment or be unexported (golint)
    • Line 34: warning: exported method Timer.Start should have comment or be unexported (golint)
    • Line 34: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 46: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 69: warning: exported method Timer.Add should have comment or be unexported (golint)
    • Line 69: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 84: warning: exported method Timer.Stop should have comment or be unexported (golint)
    • Line 84: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 88: warning: exported method Timer.Close should have comment or be unexported (golint)
    • Line 88: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • redis/lock/lock.go
    • Line 27: warning: exported type LockStatus should have comment or be unexported (golint)
    • Line 30: warning: exported var ErrLock should have comment or be unexported (golint)
    • Line 37: warning: exported const LockStatusNormal should have comment (or a comment on this block) or be unexported (golint)
    • Line 42: warning: exported type Lock should have comment or be unexported (golint)
    • Line 49: warning: exported function New should have comment or be unexported (golint)
    • Line 67: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 81: warning: exported method Lock.GetLockStatus should have comment or be unexported (golint)
    • Line 81: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 85: warning: exported method Lock.Transaction should have comment or be unexported (golint)
    • Line 85: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 90: warning: exported method Lock.Wait should have comment or be unexported (golint)
    • Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 108: warning: exported method Lock.Lock should have comment or be unexported (golint)
    • Line 108: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 129: warning: exported method Lock.WaitAndLock should have comment or be unexported (golint)
    • Line 129: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 142: warning: exported method Lock.Commit should have comment or be unexported (golint)
    • Line 142: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 167: warning: exported method Lock.Release should have comment or be unexported (golint)
    • Line 167: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • redis/redis.go
    • Line 16: warning: exported function NewRedisPool should have comment or be unexported (golint)
    • Line 72: warning: exported function HasError should have comment or be unexported (golint)
    • redis/redis_mgr.go
    • Line 34: warning: exported type Cfg should have comment or be unexported (golint)
    • Line 52: warning: comment on exported function Valid should be of the form "Valid ..." (golint)
    • Line 60: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 79: warning: exported function DefaultClient should have comment or be unexported (golint)
    • Line 83: warning: exported function DefaultPool should have comment or be unexported (golint)
    • Line 87: warning: exported function Client should have comment or be unexported (golint)
    • Line 92: warning: exported function SafeClient should have comment or be unexported (golint)
    • Line 102: warning: exported function Pool should have comment or be unexported (golint)
    • Line 110: warning: exported function SafePool should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign83%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!