Go Report Card

Preparing report...

Report for github.com/apache/dubbo-go

A+    Excellent!    Found 249 issues across 529 files

Tweet
Last refresh:

Refresh now

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint53%

Golint is a linter for Go source code.

    • dubbo-go/config_center/file/impl.go
    • Line 50: warning: exported const ParamNamePrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 56: warning: comment on exported type FileSystemDynamicConfiguration should be of the form "FileSystemDynamicConfiguration ..." (with optional leading article) (golint)
    • dubbo-go/remoting/kubernetes/listener.go
    • Line 33: warning: exported type EventListener should have comment or be unexported (golint)
    • Line 40: warning: exported function NewEventListener should have comment or be unexported (golint)
    • Line 47: warning: comment on exported method EventListener.ListenServiceNodeEvent should be of the form "ListenServiceNodeEvent ..." (golint)
    • Line 120: warning: comment on exported method EventListener.ListenServiceNodeEventWithPrefix should be of the form "ListenServiceNodeEventWithPrefix ..." (golint)
    • Line 153: warning: comment on exported method EventListener.ListenServiceEvent should be of the form "ListenServiceEvent ..." (golint)
    • Line 210: warning: exported method EventListener.Close should have comment or be unexported (golint)
    • dubbo-go/config/metadata_report_config.go
    • Line 35: warning: comment on exported type MetadataReportConfig should be of the form "MetadataReportConfig ..." (with optional leading article) (golint)
    • Line 43: warning: comment on exported method MetadataReportConfig.Prefix should be of the form "Prefix ..." (golint)
    • Line 60: warning: comment on exported method MetadataReportConfig.ToUrl should be of the form "ToUrl ..." (golint)
    • Line 90: warning: exported method MetadataReportConfig.IsValid should have comment or be unexported (golint)
    • dubbo-go/config/graceful_shutdown_config.go
    • Line 60: warning: comment on exported method ShutdownConfig.Prefix should be of the form "Prefix ..." (golint)
    • Line 65: warning: comment on exported method ShutdownConfig.GetTimeout should be of the form "GetTimeout ..." (golint)
    • Line 76: warning: comment on exported method ShutdownConfig.GetStepTimeout should be of the form "GetStepTimeout ..." (golint)
    • dubbo-go/common/constant/serializtion.go
    • Line 21: warning: don't use underscores in Go names; const S_Hessian2 should be SHessian2 (golint)
    • Line 21: warning: exported const S_Hessian2 should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: don't use underscores in Go names; const S_Proto should be SProto (golint)
    • Line 26: warning: exported const HESSIAN2_SERIALIZATION should have comment (or a comment on this block) or be unexported (golint)
    • dubbo-go/metadata/mapping/mock_service_name_mapping.go
    • Line 24: warning: exported type MockServiceNameMapping should have comment or be unexported (golint)
    • Line 26: warning: exported function NewMockServiceNameMapping should have comment or be unexported (golint)
    • Line 30: warning: exported method MockServiceNameMapping.Map should have comment or be unexported (golint)
    • Line 34: warning: exported method MockServiceNameMapping.Get should have comment or be unexported (golint)
    • dubbo-go/registry/registry.go
    • Line 24: warning: comment on exported type Registry should be of the form "Registry ..." (with optional leading article) (golint)
    • Line 69: warning: comment on exported type NotifyListener should be of the form "NotifyListener ..." (with optional leading article) (golint)
    • dubbo-go/config/config_loader.go
    • Line 41: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 64: warning: comment on exported function DefaultInit should be of the form "DefaultInit ..." (golint)
    • Line 389: warning: exported function LoadWithOptions should have comment or be unexported (golint)
    • Line 475: warning: exported function GetBaseConfig should have comment or be unexported (golint)
    • Line 492: warning: exported function GetSslEnabled should have comment or be unexported (golint)
    • Line 496: warning: exported function SetSslEnabled should have comment or be unexported (golint)
    • Line 500: warning: exported function IsProvider should have comment or be unexported (golint)
    • dubbo-go/cluster/router/router.go
    • Line 29: warning: comment on exported type PriorityRouterFactory should be of the form "PriorityRouterFactory ..." (with optional leading article) (golint)
    • Line 45: warning: comment on exported type PriorityRouter should be of the form "PriorityRouter ..." (with optional leading article) (golint)
    • Line 69: warning: comment on exported type AddrMetadata should be of the form "AddrMetadata ..." (with optional leading article) (golint)
    • dubbo-go/common/metadata_info.go
    • Line 36: warning: exported var IncludeKeys should have comment or be unexported (golint)
    • Line 59: warning: comment on exported function NewMetadataInfWithApp should be of the form "NewMetadataInfWithApp ..." (golint)
    • Line 64: warning: comment on exported function NewMetadataInfo should be of the form "NewMetadataInfo ..." (golint)
    • Line 74: warning: comment on exported method MetadataInfo.JavaClassName should be of the form "JavaClassName ..." (golint)
    • Line 118: warning: comment on exported method MetadataInfo.HasReported should be of the form "HasReported ..." (golint)
    • Line 123: warning: comment on exported method MetadataInfo.MarkReported should be of the form "MarkReported ..." (golint)
    • Line 128: warning: comment on exported method MetadataInfo.AddService should be of the form "AddService ..." (golint)
    • Line 136: warning: comment on exported method MetadataInfo.RemoveService should be of the form "RemoveService ..." (golint)
    • Line 158: warning: comment on exported function NewServiceInfoWithURL should be of the form "NewServiceInfoWithURL ..." (golint)
    • Line 181: warning: comment on exported function NewServiceInfo should be of the form "NewServiceInfo ..." (golint)
    • Line 197: warning: comment on exported method ServiceInfo.JavaClassName should be of the form "JavaClassName ..." (golint)
    • Line 202: warning: comment on exported method ServiceInfo.GetMethods should be of the form "GetMethods ..." (golint)
    • Line 209: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 218: warning: comment on exported method ServiceInfo.GetParams should be of the form "GetParams ..." (golint)
    • Line 232: warning: comment on exported method ServiceInfo.GetMatchKey should be of the form "GetMatchKey ..." (golint)
    • Line 242: warning: comment on exported method ServiceInfo.GetServiceKey should be of the form "GetServiceKey ..." (golint)
    • dubbo-go/protocol/dubbo/dubbo_codec.go
    • Line 1: warning: package comment should be of the form "Package dubbo ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 48: warning: comment on exported type DubboCodec should be of the form "DubboCodec ..." (with optional leading article) (golint)
    • Line 51: warning: comment on exported method DubboCodec.EncodeRequest should be of the form "EncodeRequest ..." (golint)
    • Line 129: warning: comment on exported method DubboCodec.EncodeResponse should be of the form "EncodeResponse ..." (golint)
    • dubbo-go/registry/mock_registry.go
    • Line 57: warning: comment on exported method MockRegistry.UnRegister should be of the form "UnRegister ..." (golint)
    • Line 62: warning: comment on exported method MockRegistry.Destroy should be of the form "Destroy ..." (golint)
    • Line 73: warning: comment on exported method MockRegistry.GetURL should be of the form "GetURL ..." (golint)
    • Line 82: warning: comment on exported method MockRegistry.Subscribe should be of the form "Subscribe ..." (golint)
    • Line 146: warning: comment on exported method MockRegistry.MockEvent should be of the form "MockEvent ..." (golint)
    • Line 151: warning: comment on exported method MockRegistry.MockEvents should be of the form "MockEvents ..." (golint)
    • dubbo-go/test/integrate/dubbo/go-server/user.go
    • Line 37: warning: exported type User should have comment or be unexported (golint)
    • Line 44: warning: exported type UserProvider should have comment or be unexported (golint)
    • Line 46: warning: exported method UserProvider.GetUser should have comment or be unexported (golint)
    • Line 54: warning: exported method UserProvider.Reference should have comment or be unexported (golint)
    • Line 58: warning: exported method User.JavaClassName should have comment or be unexported (golint)
    • dubbo-go/config/remote_config.go
    • Line 34: warning: comment on exported type RemoteConfig should be of the form "RemoteConfig ..." (with optional leading article) (golint)
    • Line 47: warning: comment on exported method RemoteConfig.Prefix should be of the form "Prefix ..." (golint)
    • Line 54: warning: receiver name rc should be consistent with previous receiver name c for RemoteConfig (golint)
    • Line 64: warning: receiver name rc should be consistent with previous receiver name c for RemoteConfig (golint)
    • Line 72: warning: receiver name rc should be consistent with previous receiver name c for RemoteConfig (golint)
    • dubbo-go/registry/service_instance.go
    • Line 75: warning: comment on exported type Endpoint should be of the form "Endpoint ..." (with optional leading article) (golint)
    • Line 143: warning: comment on exported method DefaultServiceInstance.ToURLs should be of the form "ToURLs ..." (golint)
    • dubbo-go/registry/consul/service_discovery.go
    • Line 46: warning: don't use underscores in Go names; const watch_type should be watchType (golint)
    • Line 47: warning: don't use underscores in Go names; const watch_type_service should be watchTypeService (golint)
    • Line 48: warning: don't use underscores in Go names; const watch_service should be watchService (golint)
    • Line 49: warning: don't use underscores in Go names; const watch_passingonly should be watchPassingonly (golint)
    • Line 50: warning: don't use underscores in Go names; const watch_passingonly_true should be watchPassingonlyTrue (golint)
    • dubbo-go/remoting/zookeeper/curator_discovery/service_discovery.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 46: warning: comment on exported type ServiceDiscovery should be of the form "ServiceDiscovery ..." (with optional leading article) (golint)
    • Line 230: warning: comment on exported method ServiceDiscovery.QueryForNames should be of the form "QueryForNames ..." (golint)
    • Line 240: warning: comment on exported method ServiceDiscovery.ListenServiceInstanceEvent should be of the form "ListenServiceInstanceEvent ..." (golint)
    • Line 280: warning: exported method ServiceDiscovery.Close should have comment or be unexported (golint)
    • dubbo-go/config/config_loader_options.go
    • Line 28: warning: exported type LoaderInitOption should have comment or be unexported (golint)
    • Line 46: warning: exported function ConsumerInitOption should have comment or be unexported (golint)
    • Line 50: warning: exported function ConsumerMustInitOption should have comment or be unexported (golint)
    • Line 78: warning: exported function ProviderInitOption should have comment or be unexported (golint)
    • Line 82: warning: exported function ProviderMustInitOption should have comment or be unexported (golint)
    • Line 110: warning: exported function RouterInitOption should have comment or be unexported (golint)
    • Line 121: warning: exported function BaseInitOption should have comment or be unexported (golint)
    • dubbo-go/protocol/invocation/rpcinvocation.go
    • Line 36: warning: comment on exported type RPCInvocation should be of the form "RPCInvocation ..." (with optional leading article) (golint)
    • Line 183: warning: comment on exported method RPCInvocation.SetInvoker should be of the form "SetInvoker ..." (golint)
    • Line 200: warning: exported method RPCInvocation.ServiceKey should have comment or be unexported (golint)
    • dubbo-go/test/integrate/dubbo/go-client/user.go
    • Line 37: warning: exported type User should have comment or be unexported (golint)
    • Line 44: warning: exported type UserProvider should have comment or be unexported (golint)
    • Line 48: warning: exported method UserProvider.Reference should have comment or be unexported (golint)
    • Line 52: warning: exported method User.JavaClassName should have comment or be unexported (golint)
    • dubbo-go/metadata/service/inmemory/service.go
    • Line 1: warning: package comment should be of the form "Package inmemory ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 64: warning: comment on exported function GetInMemoryMetadataService should be of the form "GetInMemoryMetadataService ..." (golint)
    • Line 195: warning: comment on exported method MetadataService.PublishServiceDefinition should be of the form "PublishServiceDefinition ..." (golint)
    • Line 218: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 236: warning: comment on exported method MetadataService.GetServiceDefinitionByServiceKey should be of the form "GetServiceDefinitionByServiceKey ..." (golint)
    • Line 273: warning: comment on exported method MetadataService.SetMetadataServiceURL should be of the form "SetMetadataServiceURL ..." (golint)
    • dubbo-go/metadata/definition/mock.go
    • Line 25: warning: exported type User should have comment or be unexported (golint)
    • Line 32: warning: exported type UserProvider should have comment or be unexported (golint)
    • Line 34: warning: exported method UserProvider.GetUser should have comment or be unexported (golint)
    • Line 39: warning: exported method UserProvider.Reference should have comment or be unexported (golint)
    • Line 43: warning: exported method User.JavaClassName should have comment or be unexported (golint)
    • dubbo-go/registry/zookeeper/registry.go
    • Line 87: warning: comment on exported type Options should be of the form "Options ..." (with optional leading article) (golint)
    • Line 92: warning: comment on exported type Option should be of the form "Option ..." (with optional leading article) (golint)
    • Line 256: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • dubbo-go/common/extension/service_name_mapping.go
    • Line 24: warning: exported type ServiceNameMappingCreator should have comment or be unexported (golint)
    • Line 28: warning: exported function SetGlobalServiceNameMapping should have comment or be unexported (golint)
    • Line 32: warning: exported function GetGlobalServiceNameMapping should have comment or be unexported (golint)
    • dubbo-go/protocol/invoker.go
    • Line 37: warning: comment on exported var ErrNoReply should be of the form "ErrNoReply ..." (golint)
    • Line 39: warning: comment on exported var ErrDestroyedInvoker should be of the form "ErrDestroyedInvoker ..." (golint)
    • dubbo-go/protocol/dubbo/hessian2/const.go
    • Line 155: warning: don't use underscores in Go names; const Response_OK should be ResponseOK (golint)
    • Line 156: warning: don't use underscores in Go names; const Response_CLIENT_TIMEOUT should be ResponseCLIENTTIMEOUT (golint)
    • Line 157: warning: don't use underscores in Go names; const Response_SERVER_TIMEOUT should be ResponseSERVERTIMEOUT (golint)
    • Line 158: warning: don't use underscores in Go names; const Response_BAD_REQUEST should be ResponseBADREQUEST (golint)
    • Line 159: warning: don't use underscores in Go names; const Response_BAD_RESPONSE should be ResponseBADRESPONSE (golint)
    • Line 160: warning: don't use underscores in Go names; const Response_SERVICE_NOT_FOUND should be ResponseSERVICENOTFOUND (golint)
    • Line 161: warning: don't use underscores in Go names; const Response_SERVICE_ERROR should be ResponseSERVICEERROR (golint)
    • Line 162: warning: don't use underscores in Go names; const Response_SERVER_ERROR should be ResponseSERVERERROR (golint)
    • Line 163: warning: don't use underscores in Go names; const Response_CLIENT_ERROR should be ResponseCLIENTERROR (golint)
    • Line 231: warning: comment on exported var DescRegex should be of the form "DescRegex ..." (golint)
    • Line 234: warning: exported var NilValue should have comment or be unexported (golint)
    • dubbo-go/metadata/service/service.go
    • Line 79: warning: exported function NewBaseMetadataService should have comment or be unexported (golint)
    • Line 85: warning: exported method BaseMetadataService.MethodMapper should have comment or be unexported (golint)
    • Line 97: warning: comment on exported method BaseMetadataService.Reference should be of the form "Reference ..." (golint)
    • Line 102: warning: exported type MetadataServiceProxyFactory should have comment or be unexported (golint)
    • Line 106: warning: exported type MetadataServiceProxyCreator should have comment or be unexported (golint)
    • Line 108: warning: exported type BaseMetadataServiceProxyFactory should have comment or be unexported (golint)
    • Line 113: warning: exported function NewBaseMetadataServiceProxyFactory should have comment or be unexported (golint)
    • Line 119: warning: exported method BaseMetadataServiceProxyFactory.GetProxy should have comment or be unexported (golint)
    • Line 133: warning: exported function ConvertURLArrToIntfArr should have comment or be unexported (golint)
    • dubbo-go/cluster/router/v3router/judger/string_match_judger.go
    • Line 29: warning: comment on exported type StringMatchJudger should be of the form "StringMatchJudger ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported method StringMatchJudger.Judge should be of the form "Judge ..." (golint)
    • Line 55: warning: comment on exported function NewStringMatchJudger should be of the form "NewStringMatchJudger ..." (golint)
    • dubbo-go/config/base_config.go
    • Line 60: warning: exported method BaseConfig.Prefix should have comment or be unexported (golint)
    • Line 64: warning: exported function BaseInit should have comment or be unexported (golint)
    • Line 77: warning: comment on exported method BaseConfig.GetServiceDiscoveries should be of the form "GetServiceDiscoveries ..." (golint)
    • dubbo-go/remoting/codec.go
    • Line 1: warning: package comment should be of the form "Package remoting ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 23: warning: comment on exported type Codec should be of the form "Codec ..." (with optional leading article) (golint)
    • Line 30: warning: exported type DecodeResult should have comment or be unexported (golint)
    • Line 37: warning: exported function RegistryCodec should have comment or be unexported (golint)
    • Line 41: warning: exported function GetCodec should have comment or be unexported (golint)
    • dubbo-go/remoting/exchange_client.go
    • Line 1: warning: package comment should be of the form "Package remoting ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 34: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
    • Line 48: warning: comment on exported type ExchangeClient should be of the form "ExchangeClient ..." (with optional leading article) (golint)
    • Line 62: warning: comment on exported function NewExchangeClient should be of the form "NewExchangeClient ..." (golint)
    • Line 95: warning: comment on exported method ExchangeClient.IncreaseActiveNumber should be of the form "IncreaseActiveNumber ..." (golint)
    • Line 96: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • Line 100: warning: comment on exported method ExchangeClient.DecreaseActiveNumber should be of the form "DecreaseActiveNumber ..." (golint)
    • Line 101: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • Line 105: warning: comment on exported method ExchangeClient.GetActiveNumber should be of the form "GetActiveNumber ..." (golint)
    • Line 106: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • Line 110: warning: comment on exported method ExchangeClient.Request should be of the form "Request ..." (golint)
    • Line 111: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • Line 140: warning: comment on exported method ExchangeClient.AsyncRequest should be of the form "AsyncRequest ..." (golint)
    • Line 141: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • Line 166: warning: comment on exported method ExchangeClient.Send should be of the form "Send ..." (golint)
    • Line 167: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • Line 186: warning: comment on exported method ExchangeClient.Close should be of the form "Close ..." (golint)
    • Line 187: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • Line 194: warning: receiver name client should be consistent with previous receiver name cl for ExchangeClient (golint)
    • dubbo-go/config/reference_config.go
    • Line 70: warning: comment on exported method ReferenceConfig.Prefix should be of the form "Prefix ..." (golint)
    • Line 210: warning: comment on exported method ReferenceConfig.Implement should be of the form "Implement ..." (golint)
    • dubbo-go/filter/filter_impl/hystrix_filter.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 42: warning: comment on exported const HYSTRIX_CONSUMER should be of the form "HYSTRIX_CONSUMER ..." (golint)
    • Line 44: warning: comment on exported const HYSTRIX_PROVIDER should be of the form "HYSTRIX_PROVIDER ..." (golint)
    • Line 46: warning: comment on exported const HYSTRIX should be of the form "HYSTRIX ..." (golint)
    • Line 86: warning: comment on exported type HystrixFilter should be of the form "HystrixFilter ..." (with optional leading article) (golint)
    • Line 296: warning: comment on exported type CommandConfigWithError should be of the form "CommandConfigWithError ..." (with optional leading article) (golint)
    • Line 314: warning: comment on exported type HystrixFilterConfig should be of the form "HystrixFilterConfig ..." (with optional leading article) (golint)
    • Line 321: warning: comment on exported type ServiceHystrixConfig should be of the form "ServiceHystrixConfig ..." (with optional leading article) (golint)
    • dubbo-go/protocol/jsonrpc/json.go
    • Line 49: warning: comment on exported const CodeParseError should be of the form "CodeParseError ..." (golint)
    • Line 52: warning: exported const CodeInvalidRequest should have comment (or a comment on this block) or be unexported (golint)
    • dubbo-go/protocol/protocolwrapper/protocol_filter_wrapper.go
    • Line 42: warning: comment on exported type ProtocolFilterWrapper should be of the form "ProtocolFilterWrapper ..." (with optional leading article) (golint)
    • Line 74: warning: exported function BuildInvokerChain should have comment or be unexported (golint)
    • Line 91: warning: comment on exported function GetProtocol should be of the form "GetProtocol ..." (golint)
    • dubbo-go/remoting/exchange.go
    • Line 1: warning: package comment should be of the form "Package remoting ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 41: warning: exported type SequenceType should have comment or be unexported (golint)
    • Line 48: warning: exported function SequenceID should have comment or be unexported (golint)
    • Line 54: warning: comment on exported type Request should be of the form "Request ..." (with optional leading article) (golint)
    • Line 76: warning: comment on exported type Response should be of the form "Response ..." (with optional leading article) (golint)
    • Line 95: warning: comment on exported method Response.IsHeartbeat should be of the form "IsHeartbeat ..." (golint)
    • Line 100: warning: exported method Response.Handle should have comment or be unexported (golint)
    • Line 117: warning: exported type Options should have comment or be unexported (golint)
    • Line 132: warning: comment on exported type PendingResponse should be of the form "PendingResponse ..." (with optional leading article) (golint)
    • Line 155: warning: exported method PendingResponse.SetResponse should have comment or be unexported (golint)
    • Line 170: warning: comment on exported function AddPendingResponse should be of the form "AddPendingResponse ..." (golint)
    • Line 187: warning: comment on exported function GetPendingResponse should be of the form "GetPendingResponse ..." (golint)
    • dubbo-go/remoting/getty/getty_client.go
    • Line 92: warning: comment on exported function SetClientConf should be of the form "SetClientConf ..." (golint)
    • Line 130: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 148: warning: exported method Client.SetExchangeClient should have comment or be unexported (golint)
    • Line 151: warning: comment on exported method Client.Connect should be of the form "Connect ..." (golint)
    • Line 166: warning: comment on exported method Client.Close should be of the form "Close ..." (golint)
    • Line 178: warning: comment on exported method Client.Request should be of the form "Request ..." (golint)
    • Line 213: warning: comment on exported method Client.IsAvailable should be of the form "IsAvailable ..." (golint)
    • dubbo-go/cluster/router/v3router/k8s_api/listener_handler_impl.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 36: warning: exported const VirtualServiceEventKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: comment on exported type VirtualServiceListenerHandler should be of the form "VirtualServiceListenerHandler ..." (with optional leading article) (golint)
    • Line 48: warning: comment on exported method VirtualServiceListenerHandler.AddFunc should be of the form "AddFunc ..." (golint)
    • Line 60: warning: comment on exported method VirtualServiceListenerHandler.UpdateFunc should be of the form "UpdateFunc ..." (golint)
    • Line 73: warning: comment on exported method VirtualServiceListenerHandler.DeleteFunc should be of the form "DeleteFunc ..." (golint)
    • Line 85: warning: comment on exported method VirtualServiceListenerHandler.Watch should be of the form "Watch ..." (golint)
    • Line 96: warning: comment on exported method VirtualServiceListenerHandler.List should be of the form "List ..." (golint)
    • Line 110: warning: comment on exported method VirtualServiceListenerHandler.GetObject should be of the form "GetObject ..." (golint)
    • Line 122: warning: comment on exported type DestRuleListenerHandler should be of the form "DestRuleListenerHandler ..." (with optional leading article) (golint)
    • Line 127: warning: comment on exported method DestRuleListenerHandler.AddFunc should be of the form "AddFunc ..." (golint)
    • Line 140: warning: comment on exported method DestRuleListenerHandler.UpdateFunc should be of the form "UpdateFunc ..." (golint)
    • Line 152: warning: comment on exported method DestRuleListenerHandler.DeleteFunc should be of the form "DeleteFunc ..." (golint)
    • Line 164: warning: comment on exported method DestRuleListenerHandler.Watch should be of the form "Watch ..." (golint)
    • Line 175: warning: comment on exported method DestRuleListenerHandler.List should be of the form "List ..." (golint)
    • Line 189: warning: comment on exported method DestRuleListenerHandler.GetObject should be of the form "GetObject ..." (golint)
    • dubbo-go/registry/protocol/protocol.go
    • Line 38: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 42: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 99: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • dubbo-go/remoting/kubernetes/registry_controller.go
    • Line 60: warning: comment on exported const DubboIOAnnotationKey should be of the form "DubboIOAnnotationKey ..." (golint)
    • Line 62: warning: comment on exported const DubboIOLabelKey should be of the form "DubboIOLabelKey ..." (golint)
    • Line 64: warning: exported const DubboIOConsumerLabelValue should have comment (or a comment on this block) or be unexported (golint)
    • Line 71: warning: exported var ErrDubboLabelAlreadyExist should have comment or be unexported (golint)
    • Line 144: warning: comment on exported function GetInClusterKubernetesClient should be of the form "GetInClusterKubernetesClient ..." (golint)
    • dubbo-go/protocol/dubbo3/dubbo3_protocol.go
    • Line 1: warning: package comment should be of the form "Package dubbo3 ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 54: warning: comment on exported type DubboProtocol should be of the form "DubboProtocol ..." (with optional leading article) (golint)
    • Line 146: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 167: warning: exported type Dubbo3HessianService should have comment or be unexported (golint)
    • Line 176: warning: exported method Dubbo3HessianService.GetReqParamsInteface should have comment or be unexported (golint)
    • Line 185: warning: exported method Dubbo3HessianService.InvokeWithArgs should have comment or be unexported (golint)
    • dubbo-go/registry/servicediscovery/synthesizer/rest/rest_subscribed_urls_synthesizer.go
    • Line 36: warning: comment on exported type RestSubscribedURLsSynthesizer should be of the form "RestSubscribedURLsSynthesizer ..." (with optional leading article) (golint)
    • Line 39: warning: exported method RestSubscribedURLsSynthesizer.Support should have comment or be unexported (golint)
    • Line 43: warning: exported method RestSubscribedURLsSynthesizer.Synthesize should have comment or be unexported (golint)
    • Line 59: warning: exported function NewRestSubscribedURLsSynthesizer should have comment or be unexported (golint)
    • dubbo-go/metadata/mapping/memory/service_name_mapping.go
    • Line 38: warning: exported type InMemoryServiceNameMapping should have comment or be unexported (golint)
    • Line 40: warning: exported method InMemoryServiceNameMapping.Map should have comment or be unexported (golint)
    • Line 44: warning: exported method InMemoryServiceNameMapping.Get should have comment or be unexported (golint)
    • Line 53: warning: exported function GetNameMappingInstance should have comment or be unexported (golint)
    • dubbo-go/remoting/kubernetes/client.go
    • Line 39: warning: exported type Client should have comment or be unexported (golint)
    • Line 130: warning: comment on exported method Client.Valid should be of the form "Valid ..." (golint)
    • Line 142: warning: comment on exported method Client.Done should be of the form "Done ..." (golint)
    • Line 147: warning: comment on exported method Client.Close should be of the form "Close ..." (golint)
    • dubbo-go/common/constant/key.go
    • Line 20: warning: exported type DubboCtxKey should have comment or be unexported (golint)
    • Line 23: warning: exported const ASYNC_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported const GROUP_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 52: warning: comment on exported const SSL_ENABLED_KEY should be of the form "SSL_ENABLED_KEY ..." (golint)
    • Line 55: warning: don't use underscores in Go names; const PARAMS_TYPE_Key should be PARAMSTYPEKey (golint)
    • Line 59: warning: exported const SERVICE_FILTER_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 64: warning: exported const TIMESTAMP_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 100: warning: exported const DUBBOGO_CTX_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 104: warning: exported const REGISTRY_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 117: warning: exported const APPLICATION_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 139: warning: exported const CONFIG_NAMESPACE_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 151: warning: exported const RegistryConfigPrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 167: warning: exported const CONFIGURATORS_SUFFIX should have comment (or a comment on this block) or be unexported (golint)
    • Line 171: warning: exported const NACOS_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 187: warning: exported const FILE_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 191: warning: exported const ZOOKEEPER_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 195: warning: exported const ETCDV3_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 199: warning: exported const CONSUL_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 201: warning: comment on exported const DEFAULT_CHECK_PASS_INTERVAL should be of the form "DEFAULT_CHECK_PASS_INTERVAL ..." (golint)
    • Line 205: warning: comment on exported const DEFAULT_DEREGISTER_TIME should be of the form "DEFAULT_DEREGISTER_TIME ..." (golint)
    • Line 213: warning: exported const TRACING_REMOTE_SPAN_CTX should have comment (or a comment on this block) or be unexported (golint)
    • Line 246: warning: comment on exported const CONSUMER_SIGN_FILTER should be of the form "CONSUMER_SIGN_FILTER ..." (golint)
    • Line 248: warning: comment on exported const PROVIDER_AUTH_FILTER should be of the form "PROVIDER_AUTH_FILTER ..." (golint)
    • Line 250: warning: comment on exported const SERVICE_AUTH_KEY should be of the form "SERVICE_AUTH_KEY ..." (golint)
    • Line 252: warning: comment on exported const AUTHENTICATOR_KEY should be of the form "AUTHENTICATOR_KEY ..." (golint)
    • Line 254: warning: comment on exported const DEFAULT_AUTHENTICATOR should be of the form "DEFAULT_AUTHENTICATOR ..." (golint)
    • Line 256: warning: comment on exported const DEFAULT_ACCESS_KEY_STORAGE should be of the form "DEFAULT_ACCESS_KEY_STORAGE ..." (golint)
    • Line 258: warning: comment on exported const ACCESS_KEY_STORAGE_KEY should be of the form "ACCESS_KEY_STORAGE_KEY ..." (golint)
    • Line 260: warning: comment on exported const REQUEST_TIMESTAMP_KEY should be of the form "REQUEST_TIMESTAMP_KEY ..." (golint)
    • Line 262: warning: comment on exported const REQUEST_SIGNATURE_KEY should be of the form "REQUEST_SIGNATURE_KEY ..." (golint)
    • Line 264: warning: comment on exported const AK_KEY should be of the form "AK_KEY ..." (golint)
    • Line 266: warning: comment on exported const SIGNATURE_STRING_FORMAT should be of the form "SIGNATURE_STRING_FORMAT ..." (golint)
    • Line 268: warning: comment on exported const PARAMETER_SIGNATURE_ENABLE_KEY should be of the form "PARAMETER_SIGNATURE_ENABLE_KEY ..." (golint)
    • Line 270: warning: comment on exported const CONSUMER should be of the form "CONSUMER ..." (golint)
    • Line 272: warning: comment on exported const ACCESS_KEY_ID_KEY should be of the form "ACCESS_KEY_ID_KEY ..." (golint)
    • Line 274: warning: comment on exported const SECRET_ACCESS_KEY_KEY should be of the form "SECRET_ACCESS_KEY_KEY ..." (golint)
    • Line 281: warning: exported const METACONFIG_REMOTE should have comment (or a comment on this block) or be unexported (golint)
    • Line 287: warning: comment on exported const METADATA_SERVICE_NAME should be of the form "METADATA_SERVICE_NAME ..." (golint)
    • dubbo-go/metadata/service/inmemory/service_proxy.go
    • Line 33: warning: comment on exported type MetadataServiceProxy should be of the form "MetadataServiceProxy ..." (with optional leading article) (golint)
    • Line 46: warning: comment on exported method MetadataServiceProxy.GetExportedURLs should be of the form "GetExportedURLs ..." (golint)
    • Line 79: warning: comment on exported method MetadataServiceProxy.GetExportedServiceURLs should be of the form "GetExportedServiceURLs ..." (golint)
    • Line 85: warning: comment on exported method MetadataServiceProxy.GetMetadataServiceURL should be of the form "GetMetadataServiceURL ..." (golint)
    • Line 91: warning: comment on exported method MetadataServiceProxy.SetMetadataServiceURL should be of the form "SetMetadataServiceURL ..." (golint)
    • Line 96: warning: comment on exported method MetadataServiceProxy.MethodMapper should be of the form "MethodMapper ..." (golint)
    • Line 101: warning: comment on exported method MetadataServiceProxy.Reference should be of the form "Reference ..." (golint)
    • Line 107: warning: comment on exported method MetadataServiceProxy.ServiceName should be of the form "ServiceName ..." (golint)
    • Line 113: warning: comment on exported method MetadataServiceProxy.ExportURL should be of the form "ExportURL ..." (golint)
    • Line 119: warning: comment on exported method MetadataServiceProxy.UnexportURL should be of the form "UnexportURL ..." (golint)
    • Line 125: warning: comment on exported method MetadataServiceProxy.SubscribeURL should be of the form "SubscribeURL ..." (golint)
    • Line 131: warning: comment on exported method MetadataServiceProxy.UnsubscribeURL should be of the form "UnsubscribeURL ..." (golint)
    • Line 137: warning: comment on exported method MetadataServiceProxy.PublishServiceDefinition should be of the form "PublishServiceDefinition ..." (golint)
    • Line 143: warning: comment on exported method MetadataServiceProxy.GetSubscribedURLs should be of the form "GetSubscribedURLs ..." (golint)
    • Line 149: warning: comment on exported method MetadataServiceProxy.GetServiceDefinition should be of the form "GetServiceDefinition ..." (golint)
    • Line 155: warning: comment on exported method MetadataServiceProxy.GetServiceDefinitionByServiceKey should be of the form "GetServiceDefinitionByServiceKey ..." (golint)
    • Line 161: warning: comment on exported method MetadataServiceProxy.RefreshMetadata should be of the form "RefreshMetadata ..." (golint)
    • Line 167: warning: comment on exported method MetadataServiceProxy.Version should be of the form "Version ..." (golint)
    • Line 173: warning: comment on exported method MetadataServiceProxy.GetMetadataInfo should be of the form "GetMetadataInfo ..." (golint)
    • dubbo-go/filter/filter_impl/access_log_filter.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 39: warning: comment on exported const FileDateFormat should be of the form "FileDateFormat ..." (golint)
    • Line 41: warning: comment on exported const MessageDateLayout should be of the form "MessageDateLayout ..." (golint)
    • Line 43: warning: comment on exported const LogMaxBuffer should be of the form "LogMaxBuffer ..." (golint)
    • Line 45: warning: comment on exported const LogFileMode should be of the form "LogFileMode ..." (golint)
    • Line 50: warning: comment on exported const Types should be of the form "Types ..." (golint)
    • Line 52: warning: comment on exported const Arguments should be of the form "Arguments ..." (golint)
    • Line 60: warning: comment on exported type AccessLogFilter should be of the form "AccessLogFilter ..." (with optional leading article) (golint)
    • dubbo-go/remoting/getty/listener.go
    • Line 43: warning: don't use underscores in Go names; const WritePkg_Timeout should be WritePkgTimeout (golint)
    • Line 68: warning: comment on exported type RpcClientHandler should be of the form "RpcClientHandler ..." (with optional leading article) (golint)
    • Line 74: warning: comment on exported function NewRpcClientHandler should be of the form "NewRpcClientHandler ..." (golint)
    • Line 176: warning: comment on exported type RpcServerHandler should be of the form "RpcServerHandler ..." (with optional leading article) (golint)
    • Line 186: warning: comment on exported function NewRpcServerHandler should be of the form "NewRpcServerHandler ..." (golint)
    • dubbo-go/filter/filter_impl/generic_service_filter.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 44: warning: comment on exported const GENERIC_SERIALIZATION_DEFAULT should be of the form "GENERIC_SERIALIZATION_DEFAULT ..." (golint)
    • Line 52: warning: comment on exported type GenericServiceFilter should be of the form "GenericServiceFilter ..." (with optional leading article) (golint)
    • Line 117: warning: comment on exported method GenericServiceFilter.OnResponse should be of the form "OnResponse ..." (golint)
    • Line 129: warning: comment on exported function GetGenericServiceFilter should be of the form "GetGenericServiceFilter ..." (golint)
    • dubbo-go/protocol/dubbo/impl/const.go
    • Line 28: warning: exported const DUBBO should have comment (or a comment on this block) or be unexported (golint)
    • Line 155: warning: don't use underscores in Go names; const Response_OK should be ResponseOK (golint)
    • Line 156: warning: don't use underscores in Go names; const Response_CLIENT_TIMEOUT should be ResponseCLIENTTIMEOUT (golint)
    • Line 157: warning: don't use underscores in Go names; const Response_SERVER_TIMEOUT should be ResponseSERVERTIMEOUT (golint)
    • Line 158: warning: don't use underscores in Go names; const Response_BAD_REQUEST should be ResponseBADREQUEST (golint)
    • Line 159: warning: don't use underscores in Go names; const Response_BAD_RESPONSE should be ResponseBADRESPONSE (golint)
    • Line 160: warning: don't use underscores in Go names; const Response_SERVICE_NOT_FOUND should be ResponseSERVICENOTFOUND (golint)
    • Line 161: warning: don't use underscores in Go names; const Response_SERVICE_ERROR should be ResponseSERVICEERROR (golint)
    • Line 162: warning: don't use underscores in Go names; const Response_SERVER_ERROR should be ResponseSERVERERROR (golint)
    • Line 163: warning: don't use underscores in Go names; const Response_CLIENT_ERROR should be ResponseCLIENTERROR (golint)
    • Line 234: warning: exported var NilValue should have comment or be unexported (golint)
    • dubbo-go/config/metric_config.go
    • Line 22: warning: comment on exported type MetricConfig should be of the form "MetricConfig ..." (with optional leading article) (golint)
    • Line 28: warning: comment on exported method MetricConfig.GetHistogramBucket should be of the form "GetHistogramBucket ..." (golint)
    • dubbo-go/common/url.go
    • Line 75: warning: comment on exported type RoleType should be of the form "RoleType ..." (with optional leading article) (golint)
    • Line 285: warning: exported function MatchKey should have comment or be unexported (golint)
    • Line 382: warning: exported function ServiceKey should have comment or be unexported (golint)
    • Line 402: warning: comment on exported method URL.ColonSeparatedKey should be of the form "ColonSeparatedKey ..." (golint)
    • Line 740: warning: exported method URL.CloneExceptParams should have comment or be unexported (golint)
    • Line 756: warning: exported method URL.Compare should have comment or be unexported (golint)
    • Line 769: warning: comment on exported method URL.CloneWithParams should be of the form "CloneWithParams ..." (golint)
    • Line 856: warning: exported type CompareURLEqualFunc should have comment or be unexported (golint)
    • Line 862: warning: exported function SetCompareURLEqualFunc should have comment or be unexported (golint)
    • Line 866: warning: exported function GetCompareURLEqualFunc should have comment or be unexported (golint)
    • dubbo-go/common/proxy/proxy.go
    • Line 39: warning: comment on exported type Proxy should be of the form "Proxy ..." (with optional leading article) (golint)
    • Line 84: warning: comment on exported method Proxy.Implement should be of the form "Implement ..." (golint)
    • dubbo-go/config/consumer_config.go
    • Line 37: warning: exported const MaxWheelTimeSpan should have comment (or a comment on this block) or be unexported (golint)
    • Line 46: warning: don't use underscores in Go names; struct field Connect_Timeout should be ConnectTimeout (golint)
    • Line 52: warning: don't use underscores in Go names; struct field Request_Timeout should be RequestTimeout (golint)
    • Line 73: warning: comment on exported method ConsumerConfig.Prefix should be of the form "Prefix ..." (golint)
    • dubbo-go/protocol/dubbo/impl/codec.go
    • Line 36: warning: exported type ProtocolCodec should have comment or be unexported (golint)
    • Line 44: warning: exported method ProtocolCodec.ReadHeader should have comment or be unexported (golint)
    • Line 106: warning: exported method ProtocolCodec.EncodeHeader should have comment or be unexported (golint)
    • Line 129: warning: exported method ProtocolCodec.Encode should have comment or be unexported (golint)
    • Line 153: warning: exported method ProtocolCodec.Decode should have comment or be unexported (golint)
    • Line 188: warning: exported method ProtocolCodec.SetSerializer should have comment or be unexported (golint)
    • Line 277: warning: exported function NewDubboCodec should have comment or be unexported (golint)
    • dubbo-go/protocol/dubbo/impl/hessian.go
    • Line 40: warning: exported type HessianSerializer should have comment or be unexported (golint)
    • Line 42: warning: exported method HessianSerializer.Marshal should have comment or be unexported (golint)
    • Line 50: warning: exported method HessianSerializer.Unmarshal should have comment or be unexported (golint)
    • Line 514: warning: exported function ToMapStringInterface should have comment or be unexported (golint)
    • dubbo-go/protocol/protocol.go
    • Line 29: warning: comment on exported type Protocol should be of the form "Protocol ..." (with optional leading article) (golint)
    • Line 40: warning: comment on exported type Exporter should be of the form "Exporter ..." (with optional leading article) (golint)
    • dubbo-go/protocol/dubbo/impl/serialize.go
    • Line 1: warning: package comment should be of the form "Package impl ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 23: warning: exported type Serializer should have comment or be unexported (golint)
    • Line 28: warning: exported function LoadSerializer should have comment or be unexported (golint)
    • dubbo-go/protocol/rpc_status.go
    • Line 185: warning: comment on exported function CleanAllStatus should be of the form "CleanAllStatus ..." (golint)
    • Line 244: warning: exported function GetAndRefreshState should have comment or be unexported (golint)
    • dubbo-go/config/ssl_config.go
    • Line 29: warning: exported function GetServerTlsConfigBuilder should have comment or be unexported (golint)
    • Line 33: warning: exported function GetClientTlsConfigBuilder should have comment or be unexported (golint)
    • Line 37: warning: exported function SetServerTlsConfigBuilder should have comment or be unexported (golint)
    • Line 41: warning: exported function SetClientTlsConfigBuilder should have comment or be unexported (golint)
    • dubbo-go/config/uniform_router_config.go
    • Line 26: warning: comment on exported type MetaDataStruct should be of the form "MetaDataStruct ..." (with optional leading article) (golint)
    • Line 31: warning: comment on exported type VirtualServiceConfig should be of the form "VirtualServiceConfig ..." (with optional leading article) (golint)
    • Line 41: warning: comment on exported type UniformRouterConfigSpec should be of the form "UniformRouterConfigSpec ..." (with optional leading article) (golint)
    • Line 47: warning: comment on exported type DubboRoute should be of the form "DubboRoute ..." (with optional leading article) (golint)
    • Line 53: warning: comment on exported type DubboServiceRouterItem should be of the form "DubboServiceRouterItem ..." (with optional leading article) (golint)
    • Line 61: warning: comment on exported type DubboMatchRequest should be of the form "DubboMatchRequest ..." (with optional leading article) (golint)
    • Line 71: warning: comment on exported type DoubleMatch should be of the form "DoubleMatch ..." (with optional leading article) (golint)
    • Line 78: warning: comment on exported type DoubleRangeMatch should be of the form "DoubleRangeMatch ..." (with optional leading article) (golint)
    • Line 84: warning: comment on exported type DubboAttachmentMatch should be of the form "DubboAttachmentMatch ..." (with optional leading article) (golint)
    • Line 90: warning: comment on exported type DubboMethodMatch should be of the form "DubboMethodMatch ..." (with optional leading article) (golint)
    • Line 99: warning: comment on exported type DubboMethodArg should be of the form "DubboMethodArg ..." (with optional leading article) (golint)
    • Line 109: warning: comment on exported type ListStringMatch should be of the form "ListStringMatch ..." (with optional leading article) (golint)
    • Line 114: warning: comment on exported type ListDoubleMatch should be of the form "ListDoubleMatch ..." (with optional leading article) (golint)
    • Line 119: warning: comment on exported type BoolMatch should be of the form "BoolMatch ..." (with optional leading article) (golint)
    • Line 124: warning: comment on exported type StringMatch should be of the form "StringMatch ..." (with optional leading article) (golint)
    • Line 133: warning: comment on exported type DubboDestination should be of the form "DubboDestination ..." (with optional leading article) (golint)
    • Line 139: warning: comment on exported type RouterDest should be of the form "RouterDest ..." (with optional leading article) (golint)
    • Line 148: warning: comment on exported type DestinationRuleConfig should be of the form "DestinationRuleConfig ..." (with optional leading article) (golint)
    • Line 158: warning: comment on exported method DestinationRuleConfig.DeepCopyObject should be of the form "DeepCopyObject ..." (golint)
    • Line 166: warning: comment on exported type DestinationRuleSpec should be of the form "DestinationRuleSpec ..." (with optional leading article) (golint)
    • Line 172: warning: comment on exported type DestinationRuleSubSet should be of the form "DestinationRuleSubSet ..." (with optional leading article) (golint)
    • Line 178: warning: comment on exported method VirtualServiceConfig.DeepCopyObject should be of the form "DeepCopyObject ..." (golint)
    • Line 186: warning: comment on exported type DestinationRuleSpecList should be of the form "DestinationRuleSpecList ..." (with optional leading article) (golint)
    • Line 193: warning: comment on exported type VirtualServiceConfigList should be of the form "VirtualServiceConfigList ..." (with optional leading article) (golint)
    • Line 200: warning: comment on exported method VirtualServiceConfigList.DeepCopyObject should be of the form "DeepCopyObject ..." (golint)
    • Line 213: warning: comment on exported type DestinationRuleConfigList should be of the form "DestinationRuleConfigList ..." (with optional leading article) (golint)
    • Line 220: warning: comment on exported method DestinationRuleConfigList.DeepCopyObject should be of the form "DeepCopyObject ..." (golint)
    • dubbo-go/filter/filter_impl/auth/sign_util.go
    • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 56: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • dubbo-go/filter/filter_impl/sentinel_filter.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 55: warning: exported type DubboLoggerWrapper should have comment or be unexported (golint)
    • Line 59: warning: exported method DubboLoggerWrapper.Debug should have comment or be unexported (golint)
    • Line 63: warning: exported method DubboLoggerWrapper.DebugEnabled should have comment or be unexported (golint)
    • Line 67: warning: exported method DubboLoggerWrapper.Info should have comment or be unexported (golint)
    • Line 71: warning: exported method DubboLoggerWrapper.InfoEnabled should have comment or be unexported (golint)
    • Line 75: warning: exported method DubboLoggerWrapper.Warn should have comment or be unexported (golint)
    • Line 79: warning: exported method DubboLoggerWrapper.WarnEnabled should have comment or be unexported (golint)
    • Line 87: warning: exported method DubboLoggerWrapper.ErrorEnabled should have comment or be unexported (golint)
    • Line 91: warning: exported function GetSentinelConsumerFilter should have comment or be unexported (golint)
    • Line 95: warning: exported function GetSentinelProviderFilter should have comment or be unexported (golint)
    • Line 112: warning: exported type SentinelProviderFilter should have comment or be unexported (golint)
    • Line 114: warning: exported method SentinelProviderFilter.Invoke should have comment or be unexported (golint)
    • Line 141: warning: exported method SentinelProviderFilter.OnResponse should have comment or be unexported (golint)
    • Line 146: warning: exported type SentinelConsumerFilter should have comment or be unexported (golint)
    • Line 148: warning: exported method SentinelConsumerFilter.Invoke should have comment or be unexported (golint)
    • Line 174: warning: exported method SentinelConsumerFilter.OnResponse should have comment or be unexported (golint)
    • Line 184: warning: exported type DubboFallback should have comment or be unexported (golint)
    • Line 186: warning: exported function SetDubboConsumerFallback should have comment or be unexported (golint)
    • Line 190: warning: exported function SetDubboProviderFallback should have comment or be unexported (golint)
    • Line 204: warning: exported const SentinelProviderFilterName should have comment (or a comment on this block) or be unexported (golint)
    • dubbo-go/registry/event/service_instance_event.go
    • Line 45: warning: comment on exported type ServiceInstancePreRegisteredEvent should be of the form "ServiceInstancePreRegisteredEvent ..." (with optional leading article) (golint)
    • Line 51: warning: comment on exported type ServiceInstancePreUnregisteredEvent should be of the form "ServiceInstancePreUnregisteredEvent ..." (with optional leading article) (golint)
    • Line 57: warning: comment on exported type ServiceInstanceRegisteredEvent should be of the form "ServiceInstanceRegisteredEvent ..." (with optional leading article) (golint)
    • Line 63: warning: comment on exported type ServiceInstanceUnregisteredEvent should be of the form "ServiceInstanceUnregisteredEvent ..." (with optional leading article) (golint)
    • dubbo-go/protocol/rest/rest_protocol.go
    • Line 33: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 35: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 37: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 42: warning: exported const REST should have comment or be unexported (golint)
    • Line 49: warning: comment on exported type RestProtocol should be of the form "RestProtocol ..." (with optional leading article) (golint)
    • dubbo-go/remoting/zookeeper/listener.go
    • Line 44: warning: comment on exported type ZkEventListener should be of the form "ZkEventListener ..." (with optional leading article) (golint)
    • Line 62: warning: comment on exported method ZkEventListener.SetClient should be of the form "SetClient ..." (golint)
    • dubbo-go/protocol/rest/config/rest_config.go
    • Line 29: warning: comment on exported type RestConsumerConfig should be of the form "RestConsumerConfig ..." (with optional leading article) (golint)
    • Line 49: warning: comment on exported type RestProviderConfig should be of the form "RestProviderConfig ..." (with optional leading article) (golint)
    • Line 69: warning: comment on exported type RestServiceConfig should be of the form "RestServiceConfig ..." (with optional leading article) (golint)
    • Line 95: warning: comment on exported type RestMethodConfig should be of the form "RestMethodConfig ..." (with optional leading article) (golint)
    • Line 125: warning: comment on exported function GetRestConsumerServiceConfig should be of the form "GetRestConsumerServiceConfig ..." (golint)
    • Line 130: warning: comment on exported function GetRestProviderServiceConfig should be of the form "GetRestProviderServiceConfig ..." (golint)
    • Line 135: warning: comment on exported function SetRestConsumerServiceConfigMap should be of the form "SetRestConsumerServiceConfigMap ..." (golint)
    • Line 140: warning: comment on exported function SetRestProviderServiceConfigMap should be of the form "SetRestProviderServiceConfigMap ..." (golint)
    • Line 145: warning: comment on exported function GetRestConsumerServiceConfigMap should be of the form "GetRestConsumerServiceConfigMap ..." (golint)
    • Line 150: warning: comment on exported function GetRestProviderServiceConfigMap should be of the form "GetRestProviderServiceConfigMap ..." (golint)
    • dubbo-go/filter/filter_impl/seata_filter.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 34: warning: exported const SEATA should have comment (or a comment on this block) or be unexported (golint)
    • Line 45: warning: comment on exported method SeataFilter.Invoke should be of the form "Invoke ..." (golint)
    • dubbo-go/common/constant/default.go
    • Line 21: warning: exported const DUBBO should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: comment on exported const OVERRIDE_PROTOCOL should be of the form "OVERRIDE_PROTOCOL ..." (golint)
    • Line 30: warning: exported const DEFAULT_WEIGHT should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported const DEFAULT_LOADBALANCE should have comment (or a comment on this block) or be unexported (golint)
    • Line 52: warning: exported const DEFAULT_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 62: warning: exported const ANY_VALUE should have comment (or a comment on this block) or be unexported (golint)
    • Line 69: warning: exported const CONFIGURATORS_CATEGORY should have comment (or a comment on this block) or be unexported (golint)
    • Line 79: warning: exported const COMMA_SPLIT_PATTERN should have comment (or a comment on this block) or be unexported (golint)
    • Line 83: warning: exported const SIMPLE_METADATA_SERVICE_NAME should have comment (or a comment on this block) or be unexported (golint)
    • Line 88: warning: exported const SERVICE_DISCOVERY_DEFAULT_GROUP should have comment (or a comment on this block) or be unexported (golint)
    • Line 92: warning: exported const DEFAULT_PROVIDER_CONF_FILE_PATH should have comment (or a comment on this block) or be unexported (golint)
    • dubbo-go/filter/filter_impl/generic_filter.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 40: warning: comment on exported const GENERIC should be of the form "GENERIC ..." (golint)
    • Line 51: warning: comment on exported type GenericFilter should be of the form "GenericFilter ..." (with optional leading article) (golint)
    • dubbo-go/protocol/dubbo/impl/response.go
    • Line 20: warning: exported type ResponsePayload should have comment or be unexported (golint)
    • Line 26: warning: comment on exported function NewResponsePayload should be of the form "NewResponsePayload ..." (golint)
    • Line 38: warning: exported function EnsureResponsePayload should have comment or be unexported (golint)
    • dubbo-go/registry/event.go
    • Line 55: warning: comment on exported method ServiceEvent.Update should be of the form "Update ..." (golint)
    • Line 61: warning: comment on exported method ServiceEvent.Updated should be of the form "Updated ..." (golint)
    • Line 67: warning: comment on exported method ServiceEvent.Key should be of the form "Key ..." (golint)
    • dubbo-go/remoting/etcdv3/listener.go
    • Line 37: warning: comment on exported type EventListener should be of the form "EventListener ..." (with optional leading article) (golint)
    • Line 53: warning: comment on exported method EventListener.ListenServiceNodeEvent should be of the form "ListenServiceNodeEvent ..." (golint)
    • Line 228: warning: comment on exported method EventListener.Close should be of the form "Close ..." (golint)
    • dubbo-go/protocol/dubbo3/internal/server.go
    • Line 26: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 28: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 31: warning: comment on exported type Server should be of the form "Server ..." (with optional leading article) (golint)
    • Line 42: warning: exported method Server.Reference should have comment or be unexported (golint)
    • dubbo-go/remoting/exchange_server.go
    • Line 1: warning: package comment should be of the form "Package remoting ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 23: warning: comment on exported type Server should be of the form "Server ..." (with optional leading article) (golint)
    • Line 32: warning: comment on exported type ExchangeServer should be of the form "ExchangeServer ..." (with optional leading article) (golint)
    • Line 38: warning: comment on exported function NewExchangeServer should be of the form "NewExchangeServer ..." (golint)
    • Line 47: warning: comment on exported method ExchangeServer.Start should be of the form "Start ..." (golint)
    • Line 52: warning: comment on exported method ExchangeServer.Stop should be of the form "Stop ..." (golint)
    • dubbo-go/remoting/kubernetes/watch.go
    • Line 32: warning: exported var ErrWatcherSetAlreadyStopped should have comment or be unexported (golint)
    • Line 43: warning: exported const Create should have comment (or a comment on this block) or be unexported (golint)
    • Line 61: warning: comment on exported type WatcherEvent should be of the form "WatcherEvent ..." (with optional leading article) (golint)
    • Line 72: warning: comment on exported type WatcherSet should be of the form "WatcherSet ..." (with optional leading article) (golint)
    • Line 87: warning: comment on exported type Watcher should be of the form "Watcher ..." (with optional leading article) (golint)
    • dubbo-go/protocol/dubbo/impl/package.go
    • Line 31: warning: exported type PackageType should have comment or be unexported (golint)
    • Line 39: warning: don't use underscores in Go names; const PackageRequest_TwoWay should be PackageRequestTwoWay (golint)
    • Line 40: warning: don't use underscores in Go names; const PackageResponse_Exception should be PackageResponseException (golint)
    • Line 41: warning: don't use underscores in Go names; const PackageType_BitSize should be PackageTypeBitSize (golint)
    • Line 44: warning: exported type DubboHeader should have comment or be unexported (golint)
    • Line 62: warning: exported type DubboPackage should have comment or be unexported (golint)
    • Line 74: warning: exported method DubboPackage.ReadHeader should have comment or be unexported (golint)
    • Line 78: warning: exported method DubboPackage.Marshal should have comment or be unexported (golint)
    • Line 89: warning: exported method DubboPackage.Unmarshal should have comment or be unexported (golint)
    • Line 96: warning: exported method DubboPackage.IsHeartBeat should have comment or be unexported (golint)
    • Line 100: warning: exported method DubboPackage.IsRequest should have comment or be unexported (golint)
    • Line 104: warning: exported method DubboPackage.IsResponse should have comment or be unexported (golint)
    • Line 108: warning: exported method DubboPackage.IsResponseWithException should have comment or be unexported (golint)
    • Line 113: warning: exported method DubboPackage.GetBodyLen should have comment or be unexported (golint)
    • Line 117: warning: exported method DubboPackage.GetLen should have comment or be unexported (golint)
    • Line 121: warning: exported method DubboPackage.GetBody should have comment or be unexported (golint)
    • Line 125: warning: exported method DubboPackage.SetBody should have comment or be unexported (golint)
    • Line 129: warning: exported method DubboPackage.SetHeader should have comment or be unexported (golint)
    • Line 133: warning: exported method DubboPackage.SetService should have comment or be unexported (golint)
    • Line 137: warning: exported method DubboPackage.SetID should have comment or be unexported (golint)
    • Line 141: warning: exported method DubboPackage.GetHeader should have comment or be unexported (golint)
    • Line 145: warning: exported method DubboPackage.GetService should have comment or be unexported (golint)
    • Line 149: warning: exported method DubboPackage.SetResponseStatus should have comment or be unexported (golint)
    • Line 153: warning: exported method DubboPackage.SetSerializer should have comment or be unexported (golint)
    • Line 157: warning: exported function NewDubboPackage should have comment or be unexported (golint)
    • dubbo-go/protocol/rest/client/rest_client.go
    • Line 25: warning: comment on exported type RestOptions should be of the form "RestOptions ..." (with optional leading article) (golint)
    • Line 31: warning: comment on exported type RestClientRequest should be of the form "RestClientRequest ..." (with optional leading article) (golint)
    • dubbo-go/protocol/dubbo/hessian2/hessian_dubbo.go
    • Line 37: warning: don't use underscores in Go names; const PackageRequest_TwoWay should be PackageRequestTwoWay (golint)
    • Line 38: warning: don't use underscores in Go names; const PackageResponse_Exception should be PackageResponseException (golint)
    • Line 39: warning: don't use underscores in Go names; const PackageType_BitSize should be PackageTypeBitSize (golint)
    • Line 78: warning: comment on exported function NewHessianCodecCustom should be of the form "NewHessianCodecCustom ..." (golint)
    • Line 218: warning: comment on exported method HessianCodec.ReadAttachments should be of the form "ReadAttachments ..." (golint)
    • dubbo-go/registry/event/service_discovery_event.go
    • Line 49: warning: comment on exported type ServiceDiscoveryDestroyingEvent should be of the form "ServiceDiscoveryDestroyingEvent ..." (with optional leading article) (golint)
    • Line 55: warning: comment on exported type ServiceDiscoveryExceptionEvent should be of the form "ServiceDiscoveryExceptionEvent ..." (with optional leading article) (golint)
    • Line 62: warning: comment on exported type ServiceDiscoveryInitializedEvent should be of the form "ServiceDiscoveryInitializedEvent ..." (with optional leading article) (golint)
    • Line 68: warning: comment on exported type ServiceDiscoveryInitializingEvent should be of the form "ServiceDiscoveryInitializingEvent ..." (with optional leading article) (golint)
    • Line 74: warning: comment on exported type ServiceDiscoveryDestroyedEvent should be of the form "ServiceDiscoveryDestroyedEvent ..." (with optional leading article) (golint)
    • dubbo-go/config/config_api.go
    • Line 71: warning: comment on exported type RegistryConfigOpt should be of the form "RegistryConfigOpt ..." (with optional leading article) (golint)
    • Line 171: warning: comment on exported type ConsumerConfigOpt should be of the form "ConsumerConfigOpt ..." (with optional leading article) (golint)
    • Line 255: warning: comment on exported type ReferenceConfigOpt should be of the form "ReferenceConfigOpt ..." (with optional leading article) (golint)
    • Line 320: warning: comment on exported type ProviderConfigOpt should be of the form "ProviderConfigOpt ..." (with optional leading article) (golint)
    • Line 394: warning: comment on exported type ServiceConfigOpt should be of the form "ServiceConfigOpt ..." (with optional leading article) (golint)
    • Line 476: warning: comment on exported type ApplicationConfigOpt should be of the form "ApplicationConfigOpt ..." (with optional leading article) (golint)
    • dubbo-go/protocol/dubbo/impl/request.go
    • Line 20: warning: exported type RequestPayload should have comment or be unexported (golint)
    • Line 25: warning: exported function NewRequestPayload should have comment or be unexported (golint)
    • Line 35: warning: exported function EnsureRequestPayload should have comment or be unexported (golint)

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • dubbo-go/protocol/jsonrpc/json.go
    • Line 224: warning: cyclomatic complexity 23 of function (*serverRequest).UnmarshalJSON() is high (> 15) (gocyclo)
    • Line 117: warning: cyclomatic complexity 18 of function (*jsonClientCodec).Write() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!