Report for github.com/apache/incubator-yunikorn-k8shim
A+ Excellent! Found 77 issues across 146 files
gofmt98%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
incubator-yunikorn-k8shim/pkg/common/events/events.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
incubator-yunikorn-k8shim/pkg/cache/task.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo98%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
incubator-yunikorn-k8shim/pkg/callback/scheduler_callback.go
- Line 43: warning: cyclomatic complexity 20 of function (*AsyncRMCallback).RecvUpdateResponse() is high (> 15) (gocyclo)
-
-
incubator-yunikorn-k8shim/pkg/cache/context_recovery.go
- Line 72: warning: cyclomatic complexity 22 of function (*Context).recover() is high (> 15) (gocyclo)
golint47%
Golint is a linter for Go source code.
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/yunikorn/yk_utils.go
- Line 29: warning: exported type ResourceUsage should have comment or be unexported (golint)
- Line 34: warning: exported method ResourceUsage.ParseResourceUsageString should have comment or be unexported (golint)
- Line 45: warning: exported method ResourceUsage.GetMemory should have comment or be unexported (golint)
- Line 49: warning: exported method ResourceUsage.GetVCPU should have comment or be unexported (golint)
- Line 53: warning: exported function GetYKUrl should have comment or be unexported (golint)
- Line 60: warning: exported function GetYKHost should have comment or be unexported (golint)
- Line 67: warning: exported function GetYKScheme should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/utils/gang_utils.go
- Line 34: warning: exported function FindAppTaskGroup should have comment or be unexported (golint)
- Line 56: warning: comment on exported function GeneratePlaceholderName should be of the form "GeneratePlaceholderName ..." (golint)
- Line 68: warning: exported function GetPlaceholderResourceRequest should have comment or be unexported (golint)
- Line 76: warning: exported function GetPlaceholderFlagFromPodSpec should have comment or be unexported (golint)
- Line 91: warning: exported function GetTaskGroupFromPodSpec should have comment or be unexported (golint)
- Line 98: warning: exported function GetTaskGroupsFromAnnotation should have comment or be unexported (golint)
- Line 126: warning: exported function GetPlaceholderTimeoutParam should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/namespaceinformer_mock.go
- Line 27: warning: exported type MockNamespaceInformer should have comment or be unexported (golint)
- Line 31: warning: exported function NewMockNamespaceInformer should have comment or be unexported (golint)
- Line 37: warning: exported method MockNamespaceInformer.Informer should have comment or be unexported (golint)
- Line 41: warning: exported method MockNamespaceInformer.Lister should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/external/scheduler_cache.go
- Line 38: warning: comment on exported type SchedulerCache should be of the form "SchedulerCache ..." (with optional leading article) (golint)
- Line 53: warning: exported function NewSchedulerCache should have comment or be unexported (golint)
- Line 64: warning: exported method SchedulerCache.GetNodesInfoMap should have comment or be unexported (golint)
- Line 79: warning: exported method SchedulerCache.GetNode should have comment or be unexported (golint)
- Line 89: warning: exported method SchedulerCache.AddNode should have comment or be unexported (golint)
- Line 108: warning: exported method SchedulerCache.UpdateNode should have comment or be unexported (golint)
- Line 123: warning: exported method SchedulerCache.RemoveNode should have comment or be unexported (golint)
- Line 146: warning: exported method SchedulerCache.ArePodVolumesAllBound should have comment or be unexported (golint)
- Line 152: warning: comment on exported method SchedulerCache.AddPod should be of the form "AddPod ..." (golint)
- Line 193: warning: exported method SchedulerCache.UpdatePod should have comment or be unexported (golint)
- Line 241: warning: exported method SchedulerCache.RemovePod should have comment or be unexported (golint)
- Line 258: warning: exported method SchedulerCache.GetPod should have comment or be unexported (golint)
- Line 267: warning: exported method SchedulerCache.AssumePod should have comment or be unexported (golint)
- Line 286: warning: exported method SchedulerCache.ForgetPod should have comment or be unexported (golint)
- Line 316: warning: comment on exported method SchedulerCache.List should be of the form "List ..." (golint)
- Line 322: warning: comment on exported method SchedulerCache.FilteredList should be of the form "FilteredList ..." (golint)
- Line 344: warning: comment on exported method SchedulerCache.GetNodeInfo should be of the form "GetNodeInfo ..." (golint)
- Line 355: warning: comment on exported method SchedulerCache.GetStorageClassInfo should be of the form "GetStorageClassInfo ..." (golint)
- Line 360: warning: comment on exported method SchedulerCache.GetPersistentVolumeClaimInfo should be of the form "GetPersistentVolumeClaimInfo ..." (golint)
- Line 365: warning: comment on exported method SchedulerCache.GetPersistentVolumeInfo should be of the form "GetPersistentVolumeInfo ..." (golint)
-
-
incubator-yunikorn-k8shim/pkg/client/interfaces.go
- Line 27: warning: exported type KubeClient should have comment or be unexported (golint)
- Line 49: warning: exported function NewKubeClient should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/plugin/admissioncontrollers/webhook/admission_controller.go
- Line 65: warning: exported type ValidateConfResponse should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/application_events.go
- Line 32: warning: exported type ApplicationEvent should have comment or be unexported (golint)
- Line 38: warning: exported function NewSimpleApplicationEvent should have comment or be unexported (golint)
- Line 45: warning: exported method SimpleApplicationEvent.GetEvent should have comment or be unexported (golint)
- Line 49: warning: exported method SimpleApplicationEvent.GetArgs should have comment or be unexported (golint)
- Line 53: warning: exported method SimpleApplicationEvent.GetApplicationID should have comment or be unexported (golint)
- Line 57: warning: exported function NewApplicationEvent should have comment or be unexported (golint)
- Line 65: warning: exported method ApplicationEvent.GetEvent should have comment or be unexported (golint)
- Line 69: warning: exported method ApplicationEvent.GetArgs should have comment or be unexported (golint)
- Line 75: warning: exported method ApplicationEvent.GetApplicationID should have comment or be unexported (golint)
- Line 79: warning: comment on exported type ApplicationStatusChangeEvent should be of the form "ApplicationStatusChangeEvent ..." (with optional leading article) (golint)
- Line 88: warning: exported function NewApplicationStatusChangeEvent should have comment or be unexported (golint)
- Line 96: warning: exported method ApplicationStatusChangeEvent.GetEvent should have comment or be unexported (golint)
- Line 100: warning: exported method ApplicationStatusChangeEvent.GetArgs should have comment or be unexported (golint)
- Line 104: warning: exported method ApplicationStatusChangeEvent.GetApplicationID should have comment or be unexported (golint)
- Line 108: warning: exported method ApplicationStatusChangeEvent.GetState should have comment or be unexported (golint)
- Line 112: warning: comment on exported type SubmitApplicationEvent should be of the form "SubmitApplicationEvent ..." (with optional leading article) (golint)
- Line 120: warning: exported function NewSubmitApplicationEvent should have comment or be unexported (golint)
- Line 127: warning: exported method SubmitApplicationEvent.GetEvent should have comment or be unexported (golint)
- Line 131: warning: exported method SubmitApplicationEvent.GetArgs should have comment or be unexported (golint)
- Line 135: warning: exported method SubmitApplicationEvent.GetApplicationID should have comment or be unexported (golint)
- Line 139: warning: comment on exported type RunApplicationEvent should be of the form "RunApplicationEvent ..." (with optional leading article) (golint)
- Line 147: warning: exported function NewRunApplicationEvent should have comment or be unexported (golint)
- Line 154: warning: exported method RunApplicationEvent.GetEvent should have comment or be unexported (golint)
- Line 158: warning: exported method RunApplicationEvent.GetArgs should have comment or be unexported (golint)
- Line 162: warning: exported method RunApplicationEvent.GetApplicationID should have comment or be unexported (golint)
- Line 166: warning: comment on exported type FailApplicationEvent should be of the form "FailApplicationEvent ..." (with optional leading article) (golint)
- Line 175: warning: exported function NewFailApplicationEvent should have comment or be unexported (golint)
- Line 183: warning: exported method FailApplicationEvent.GetEvent should have comment or be unexported (golint)
- Line 187: warning: exported method FailApplicationEvent.GetArgs should have comment or be unexported (golint)
- Line 193: warning: exported method FailApplicationEvent.GetApplicationID should have comment or be unexported (golint)
- Line 197: warning: comment on exported type UpdateApplicationReservationEvent should be of the form "UpdateApplicationReservationEvent ..." (with optional leading article) (golint)
- Line 205: warning: exported function NewUpdateApplicationReservationEvent should have comment or be unexported (golint)
- Line 212: warning: exported method UpdateApplicationReservationEvent.GetEvent should have comment or be unexported (golint)
- Line 216: warning: exported method UpdateApplicationReservationEvent.GetArgs should have comment or be unexported (golint)
- Line 220: warning: exported method UpdateApplicationReservationEvent.GetApplicationID should have comment or be unexported (golint)
- Line 224: warning: comment on exported type ReleaseAppAllocationEvent should be of the form "ReleaseAppAllocationEvent ..." (with optional leading article) (golint)
- Line 234: warning: exported function NewReleaseAppAllocationEvent should have comment or be unexported (golint)
- Line 243: warning: exported method ReleaseAppAllocationEvent.GetApplicationID should have comment or be unexported (golint)
- Line 247: warning: exported method ReleaseAppAllocationEvent.GetArgs should have comment or be unexported (golint)
- Line 254: warning: exported method ReleaseAppAllocationEvent.GetEvent should have comment or be unexported (golint)
- Line 258: warning: exported type ReleaseAppAllocationAskEvent should have comment or be unexported (golint)
- Line 265: warning: exported function NewReleaseAppAllocationAskEvent should have comment or be unexported (golint)
- Line 274: warning: exported method ReleaseAppAllocationAskEvent.GetApplicationID should have comment or be unexported (golint)
- Line 278: warning: exported method ReleaseAppAllocationAskEvent.GetArgs should have comment or be unexported (golint)
- Line 285: warning: exported method ReleaseAppAllocationAskEvent.GetEvent should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/configmap_lister_mock.go
- Line 30: warning: exported type ConfigMapListerMock should have comment or be unexported (golint)
- Line 34: warning: exported function NewConfigMapListerMock should have comment or be unexported (golint)
- Line 47: warning: exported method ConfigMapListerMock.List should have comment or be unexported (golint)
- Line 51: warning: exported method ConfigMapListerMock.ConfigMaps should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/external/types.go
- Line 46: warning: exported function GetPluginArgs should have comment or be unexported (golint)
- Line 50: warning: comment on exported type PluginFactoryArgsProvider should be of the form "PluginFactoryArgsProvider ..." (with optional leading article) (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/general/general.go
- Line 50: warning: exported function NewManager should have comment or be unexported (golint)
- Line 57: warning: comment on exported method Manager.Name should be of the form "Name ..." (golint)
- Line 62: warning: comment on exported method Manager.ServiceInit should be of the form "ServiceInit ..." (golint)
- Line 75: warning: comment on exported method Manager.Start should be of the form "Start ..." (golint)
- Line 82: warning: comment on exported method Manager.Stop should be of the form "Stop ..." (golint)
- Line 298: warning: exported method Manager.ListApplications should have comment or be unexported (golint)
- Line 325: warning: exported method Manager.GetExistingAllocation should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/common/test_pod.go
- Line 31: warning: exported type SleepPodConfig should have comment or be unexported (golint)
- Line 40: warning: comment on exported function InitSleepPod should be of the form "InitSleepPod ..." (golint)
- Line 79: warning: exported type TestPodConfig should have comment or be unexported (golint)
- Line 98: warning: exported function InitTestPod should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/utils/utils.go
- Line 40: warning: exported function Convert2Pod should have comment or be unexported (golint)
- Line 48: warning: exported function NeedRecovery should have comment or be unexported (golint)
- Line 60: warning: exported function IsPodRunning should have comment or be unexported (golint)
- Line 64: warning: exported function IsPodTerminated should have comment or be unexported (golint)
- Line 68: warning: comment on exported function IsAssignedPod should be of the form "IsAssignedPod ..." (golint)
- Line 73: warning: exported function GeneralPodFilter should have comment or be unexported (golint)
- Line 77: warning: exported function GetQueueNameFromPod should have comment or be unexported (golint)
- Line 85: warning: exported function GetApplicationIDFromPod should have comment or be unexported (golint)
- Line 110: warning: comment on exported function PodUnderCondition should be of the form "PodUnderCondition ..." (golint)
- Line 117: warning: exported function GetNamespaceQuotaFromAnnotation should have comment or be unexported (golint)
- Line 130: warning: exported type K8sResource should have comment or be unexported (golint)
- Line 135: warning: exported function NewK8sResourceList should have comment or be unexported (golint)
- Line 143: warning: exported function WaitForCondition should have comment or be unexported (golint)
- Line 158: warning: exported function PodForTest should have comment or be unexported (golint)
- Line 184: warning: exported function NodeForTest should have comment or be unexported (golint)
- Line 205: warning: comment on exported function MergeMaps should be of the form "MergeMaps ..." (golint)
- Line 222: warning: comment on exported function GetUserFromPod should be of the form "GetUserFromPod ..." (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/amprotocol_mock.go
- Line 1: warning: package comment should be of the form "Package cache ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 28: warning: comment on exported type MockedAMProtocol should be of the form "MockedAMProtocol ..." (with optional leading article) (golint)
- Line 33: warning: exported function NewMockedAMProtocol should have comment or be unexported (golint)
- Line 38: warning: exported method MockedAMProtocol.GetApplication should have comment or be unexported (golint)
- Line 45: warning: exported method MockedAMProtocol.AddApplication should have comment or be unexported (golint)
- Line 63: warning: exported method MockedAMProtocol.RemoveApplication should have comment or be unexported (golint)
- Line 71: warning: exported method MockedAMProtocol.AddTask should have comment or be unexported (golint)
- Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 85: warning: exported method MockedAMProtocol.RemoveTask should have comment or be unexported (golint)
- Line 88: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 93: warning: exported method MockedAMProtocol.NotifyApplicationComplete should have comment or be unexported (golint)
- Line 101: warning: exported method MockedAMProtocol.NotifyApplicationFail should have comment or be unexported (golint)
- Line 109: warning: exported method MockedAMProtocol.NotifyTaskComplete should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/nodes.go
- Line 40: warning: exported const AddOccupiedResource should have comment (or a comment on this block) or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go
- Line 51: warning: exported function NewPlaceholderManager should have comment or be unexported (golint)
- Line 130: warning: exported method PlaceholderManager.Start should have comment or be unexported (golint)
- Line 155: warning: exported method PlaceholderManager.Stop should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/events/event_helper.go
- Line 25: warning: exported function GetEventArgsAsStrings should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/sparkoperator/spark.go
- Line 42: warning: exported function NewManager should have comment or be unexported (golint)
- Line 79: warning: exported method Manager.Name should have comment or be unexported (golint)
- Line 83: warning: exported method Manager.Start should have comment or be unexported (golint)
- Line 91: warning: exported method Manager.Stop should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/nodelister_mock.go
- Line 29: warning: exported type NodeListerMock should have comment or be unexported (golint)
- Line 33: warning: exported function NewNodeListerMock should have comment or be unexported (golint)
- Line 39: warning: exported method NodeListerMock.AddNode should have comment or be unexported (golint)
- Line 43: warning: exported method NodeListerMock.List should have comment or be unexported (golint)
- Line 47: warning: exported method NodeListerMock.Get should have comment or be unexported (golint)
- Line 56: warning: exported method NodeListerMock.ListWithPredicate should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/client/apifactory_mock.go
- Line 34: warning: exported type MockedAPIProvider should have comment or be unexported (golint)
- Line 38: warning: exported function NewMockedAPIProvider should have comment or be unexported (golint)
- Line 74: warning: exported method MockedAPIProvider.MockSchedulerApiUpdateFn should have comment or be unexported (golint)
- Line 80: warning: exported method MockedAPIProvider.GetSchedulerApiUpdateCount should have comment or be unexported (golint)
- Line 87: warning: exported method MockedAPIProvider.GetSchedulerApiRegisterCount should have comment or be unexported (golint)
- Line 94: warning: exported method MockedAPIProvider.MockBindFn should have comment or be unexported (golint)
- Line 100: warning: exported method MockedAPIProvider.MockDeleteFn should have comment or be unexported (golint)
- Line 106: warning: exported method MockedAPIProvider.MockCreateFn should have comment or be unexported (golint)
- Line 112: warning: exported method MockedAPIProvider.MockUpdateStatusFn should have comment or be unexported (golint)
- Line 118: warning: exported method MockedAPIProvider.MockGetFn should have comment or be unexported (golint)
- Line 124: warning: exported method MockedAPIProvider.SetNodeLister should have comment or be unexported (golint)
- Line 131: warning: exported method MockedAPIProvider.SetPodLister should have comment or be unexported (golint)
- Line 138: warning: exported method MockedAPIProvider.GetAPIs should have comment or be unexported (golint)
- Line 142: warning: exported method MockedAPIProvider.IsTestingMode should have comment or be unexported (golint)
- Line 146: warning: exported method MockedAPIProvider.AddEventHandler should have comment or be unexported (golint)
- Line 150: warning: exported method MockedAPIProvider.Start should have comment or be unexported (golint)
- Line 154: warning: exported method MockedAPIProvider.Stop should have comment or be unexported (golint)
- Line 158: warning: exported method MockedAPIProvider.WaitForSync should have comment or be unexported (golint)
- Line 165: warning: exported method MockedPersistentVolumeInformer.Informer should have comment or be unexported (golint)
- Line 169: warning: exported method MockedPersistentVolumeInformer.Lister should have comment or be unexported (golint)
- Line 176: warning: exported method MockedPersistentVolumeClaimInformer.Informer should have comment or be unexported (golint)
- Line 180: warning: exported method MockedPersistentVolumeClaimInformer.Lister should have comment or be unexported (golint)
- Line 187: warning: exported method MockedStorageClassInformer.Informer should have comment or be unexported (golint)
- Line 191: warning: exported method MockedStorageClassInformer.Lister should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/log/logger.go
- Line 35: warning: exported function Logger should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/common/test_queues_configs.go
- Line 28: warning: comment on exported method PartitionsWrapper.ToYAML should be of the form "ToYAML ..." (golint)
- Line 38: warning: exported function CreateBasicConfigMap should have comment or be unexported (golint)
- Line 72: warning: comment on exported method PartitionsWrapper.SetSchedulingPolicy should be of the form "SetSchedulingPolicy ..." (golint)
- Line 88: warning: exported method PartitionsWrapper.AddQueue should have comment or be unexported (golint)
- Line 105: warning: comment on exported type PartitionsWrapper should be of the form "PartitionsWrapper ..." (with optional leading article) (golint)
- Line 110: warning: exported type PartitionConfigType should have comment or be unexported (golint)
- Line 120: warning: exported type QueueConfigType should have comment or be unexported (golint)
- Line 133: warning: exported type PlacementRuleConfigType should have comment or be unexported (golint)
- Line 143: warning: exported type LimitsConfigType should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/placeholder.go
- Line 42: warning: exported type Placeholder should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/apis/yunikorn.apache.org/register.go
- Line 22: warning: exported const GroupName should have comment (or a comment on this block) or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/events/states.go
- Line 25: warning: exported type AllStates should have comment or be unexported (golint)
- Line 32: warning: exported type SchedulerStates should have comment or be unexported (golint)
- Line 42: warning: exported type ApplicationStates should have comment or be unexported (golint)
- Line 56: warning: exported type NodeStates should have comment or be unexported (golint)
- Line 65: warning: exported type TaskStates should have comment or be unexported (golint)
- Line 80: warning: exported function States should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/shim/scheduler_events.go
- Line 23: warning: exported type ShimSchedulerEvent should have comment or be unexported (golint)
- Line 27: warning: exported method ShimSchedulerEvent.GetEvent should have comment or be unexported (golint)
- Line 31: warning: exported method ShimSchedulerEvent.GetArgs should have comment or be unexported (golint)
- Line 35: warning: comment on exported type RegisterSchedulerEvent should be of the form "RegisterSchedulerEvent ..." (with optional leading article) (golint)
- Line 48: warning: exported method RegisterSchedulerEvent.GetEvent should have comment or be unexported (golint)
- Line 52: warning: exported method RegisterSchedulerEvent.GetArgs should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/configmap_informer_mock.go
- Line 26: warning: exported type ConfigMapInformerMock should have comment or be unexported (golint)
- Line 30: warning: exported function NewMockedConfigMapInformer should have comment or be unexported (golint)
- Line 36: warning: exported method ConfigMapInformerMock.Informer should have comment or be unexported (golint)
- Line 40: warning: exported method ConfigMapInformerMock.Lister should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/nodeinformer_mock.go
- Line 26: warning: exported type MockedNodeInformer should have comment or be unexported (golint)
- Line 30: warning: exported function NewMockedNodeInformer should have comment or be unexported (golint)
- Line 36: warning: exported method MockedNodeInformer.Informer should have comment or be unexported (golint)
- Line 40: warning: exported method MockedNodeInformer.Lister should have comment or be unexported (golint)
- Line 44: warning: exported method MockedNodeInformer.SetLister should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/recoverable_apps_mock.go
- Line 29: warning: exported type MockedRecoverableAppManager should have comment or be unexported (golint)
- Line 32: warning: exported function NewMockedRecoverableAppManager should have comment or be unexported (golint)
- Line 36: warning: exported method MockedRecoverableAppManager.ListApplications should have comment or be unexported (golint)
- Line 40: warning: exported method MockedRecoverableAppManager.GetExistingAllocation should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/callback/scheduler_callback.go
- Line 33: warning: comment on exported type AsyncRMCallback should be of the form "AsyncRMCallback ..." (with optional leading article) (golint)
- Line 39: warning: exported function NewAsyncRMCallback should have comment or be unexported (golint)
- Line 43: warning: exported method AsyncRMCallback.RecvUpdateResponse should have comment or be unexported (golint)
- Line 165: warning: comment on exported method AsyncRMCallback.Predicates should be of the form "Predicates ..." (golint)
- Line 170: warning: comment on exported method AsyncRMCallback.ReSyncSchedulerCache should be of the form "ReSyncSchedulerCache ..." (golint)
- Line 186: warning: comment on exported method AsyncRMCallback.SendEvent should be of the form "SendEvent ..." (golint)
- Line 194: warning: comment on exported method AsyncRMCallback.Update should be of the form "Update ..." (golint)
- Line 199: warning: exported method AsyncRMCallback.UpdateConfiguration should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/resource.go
- Line 32: warning: comment on exported type ResourceBuilder should be of the form "ResourceBuilder ..." (with optional leading article) (golint)
- Line 37: warning: exported function NewResourceBuilder should have comment or be unexported (golint)
- Line 43: warning: exported method ResourceBuilder.AddResource should have comment or be unexported (golint)
- Line 48: warning: exported method ResourceBuilder.Build should have comment or be unexported (golint)
- Line 52: warning: comment on exported function GetPodResource should be of the form "GetPodResource ..." (golint)
- Line 78: warning: exported function GetNodeResource should have comment or be unexported (golint)
- Line 87: warning: comment on exported function ParseResource should be of the form "ParseResource ..." (golint)
- Line 120: warning: exported function GetTGResource should have comment or be unexported (golint)
- Line 152: warning: exported function Equals should have comment or be unexported (golint)
- Line 180: warning: exported function Add should have comment or be unexported (golint)
- Line 202: warning: exported function Sub should have comment or be unexported (golint)
- Line 231: warning: exported function IsZero should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/configmanager/constants.go
- Line 26: warning: exported const TestResultsPath should have comment (or a comment on this block) or be unexported (golint)
- Line 35: warning: comment on exported const YKSvcName should be of the form "YKSvcName ..." (golint)
- Line 38: warning: comment on exported const YKAdmCtrlName should be of the form "YKAdmCtrlName ..." (golint)
- Line 41: warning: comment on exported const QueuesPath should be of the form "QueuesPath ..." (golint)
- Line 46: warning: comment on exported const DefaultYuniKornHost should be of the form "DefaultYuniKornHost ..." (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/app_informer_mock.go
- Line 29: warning: exported type MockedAppInformer should have comment or be unexported (golint)
- Line 33: warning: exported function NewAppInformerMock should have comment or be unexported (golint)
- Line 40: warning: exported method MockedAppInformer.Informer should have comment or be unexported (golint)
- Line 44: warning: exported method MockedAppInformer.Lister should have comment or be unexported (golint)
- Line 48: warning: exported type MockedAppLister should have comment or be unexported (golint)
- Line 51: warning: exported method MockedAppLister.List should have comment or be unexported (golint)
- Line 55: warning: exported method MockedAppLister.Applications should have comment or be unexported (golint)
- Line 59: warning: exported method MockedAppLister.Get should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/events/events.go
- Line 21: warning: exported const EnterState should have comment or be unexported (golint)
- Line 23: warning: comment on exported type SchedulingEvent should be of the form "SchedulingEvent ..." (with optional leading article) (golint)
- Line 30: warning: comment on exported type ApplicationEventType should be of the form "ApplicationEventType ..." (with optional leading article) (golint)
- Line 36: warning: exported const SubmitApplication should have comment (or a comment on this block) or be unexported (golint)
- Line 52: warning: exported type ApplicationEvent should have comment or be unexported (golint)
- Line 66: warning: comment on exported type ApplicationStatusEvent should be of the form "ApplicationStatusEvent ..." (with optional leading article) (golint)
- Line 73: warning: comment on exported type TaskEventType should be of the form "TaskEventType ..." (with optional leading article) (golint)
- Line 79: warning: exported const InitTask should have comment (or a comment on this block) or be unexported (golint)
- Line 90: warning: exported type TaskEvent should have comment or be unexported (golint)
- Line 107: warning: comment on exported type SchedulerEventType should be of the form "SchedulerEventType ..." (with optional leading article) (golint)
- Line 113: warning: exported const RegisterScheduler should have comment (or a comment on this block) or be unexported (golint)
- Line 121: warning: exported type SchedulerEvent should have comment or be unexported (golint)
- Line 130: warning: comment on exported type SchedulerNodeEventType should be of the form "SchedulerNodeEventType ..." (with optional leading article) (golint)
- Line 136: warning: exported const RecoverNode should have comment (or a comment on this block) or be unexported (golint)
- Line 144: warning: exported type SchedulerNodeEvent should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/events/recorder_mock.go
- Line 26: warning: exported type MockedRecorder should have comment or be unexported (golint)
- Line 30: warning: exported function NewMockedRecorder should have comment or be unexported (golint)
- Line 36: warning: exported method MockedRecorder.Event should have comment or be unexported (golint)
- Line 40: warning: exported method MockedRecorder.Eventf should have comment or be unexported (golint)
- Line 44: warning: exported method MockedRecorder.AnnotatedEventf should have comment or be unexported (golint)
- Line 48: warning: exported method MockedRecorder.PastEventf should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/client/clients.go
- Line 37: warning: comment on exported type Clients should be of the form "Clients ..." (with optional leading article) (golint)
- Line 66: warning: exported method Clients.WaitForSync should have comment or be unexported (golint)
- Line 80: warning: exported method Clients.Run should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/yunikorn/states.go
- Line 25: warning: exported type AllStates should have comment or be unexported (golint)
- Line 30: warning: exported type ApplicationStates should have comment or be unexported (golint)
- Line 44: warning: exported type NodeStates should have comment or be unexported (golint)
- Line 53: warning: exported function States should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/task.go
- Line 40: warning: exported type Task should have comment or be unexported (golint)
- Line 58: warning: exported function NewTask should have comment or be unexported (golint)
- Line 63: warning: exported function NewTaskPlaceholder should have comment or be unexported (golint)
- Line 68: warning: exported function NewFromTaskMeta should have comment or be unexported (golint)
- Line 175: warning: exported method Task.GetTaskPod should have comment or be unexported (golint)
- Line 181: warning: exported method Task.GetTaskID should have comment or be unexported (golint)
- Line 187: warning: exported method Task.IsPlaceholder should have comment or be unexported (golint)
- Line 193: warning: exported method Task.GetTaskState should have comment or be unexported (golint)
- Line 222: warning: exported method Task.DeleteTaskPod should have comment or be unexported (golint)
- Line 226: warning: exported method Task.UpdateTaskPodStatus should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/apis/yunikorn.apache.org/v1alpha1/register.go
- Line 29: warning: exported var SchemeGroupVersion should have comment or be unexported (golint)
- Line 31: warning: exported function Kind should have comment or be unexported (golint)
- Line 35: warning: exported function Resource should have comment or be unexported (golint)
- Line 40: warning: exported var SchemeBuilder should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/conf/schedulerconf.go
- Line 53: warning: exported type SchedulerConf should have comment or be unexported (golint)
- Line 75: warning: exported function GetSchedulerConf should have comment or be unexported (golint)
- Line 80: warning: exported method SchedulerConf.SetTestMode should have comment or be unexported (golint)
- Line 86: warning: exported method SchedulerConf.GetSchedulingInterval should have comment or be unexported (golint)
- Line 92: warning: exported method SchedulerConf.GetKubeConfigPath should have comment or be unexported (golint)
- Line 98: warning: exported method SchedulerConf.IsOperatorPluginEnabled should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/client/kubeclient_mock.go
- Line 45: warning: exported function NewKubeClientMock should have comment or be unexported (golint)
- Line 77: warning: exported method KubeClientMock.MockBindFn should have comment or be unexported (golint)
- Line 81: warning: exported method KubeClientMock.MockDeleteFn should have comment or be unexported (golint)
- Line 85: warning: exported method KubeClientMock.MockCreateFn should have comment or be unexported (golint)
- Line 89: warning: exported method KubeClientMock.Bind should have comment or be unexported (golint)
- Line 93: warning: exported method KubeClientMock.Create should have comment or be unexported (golint)
- Line 98: warning: exported method KubeClientMock.UpdateStatus should have comment or be unexported (golint)
- Line 103: warning: exported method KubeClientMock.Get should have comment or be unexported (golint)
- Line 112: warning: exported method KubeClientMock.Delete should have comment or be unexported (golint)
- Line 117: warning: exported method KubeClientMock.GetClientSet should have comment or be unexported (golint)
- Line 121: warning: exported method KubeClientMock.GetConfigs should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/k8s/k8s_utils.go
- Line 44: warning: exported type KubeCtl should have comment or be unexported (golint)
- Line 83: warning: exported method KubeCtl.SetClient should have comment or be unexported (golint)
- Line 96: warning: exported method KubeCtl.GetClient should have comment or be unexported (golint)
- Line 100: warning: exported method KubeCtl.GetKubeConfig should have comment or be unexported (golint)
- Line 106: warning: exported method KubeCtl.GetPods should have comment or be unexported (golint)
- Line 110: warning: exported method KubeCtl.GetPod should have comment or be unexported (golint)
- Line 114: warning: exported method KubeCtl.UpdatePodWithAnnotation should have comment or be unexported (golint)
- Line 124: warning: exported method KubeCtl.DeletePodAnnotation should have comment or be unexported (golint)
- Line 131: warning: exported method KubeCtl.GetPodNamesFromNS should have comment or be unexported (golint)
- Line 143: warning: exported method KubeCtl.GetService should have comment or be unexported (golint)
- Line 147: warning: comment on exported method KubeCtl.CreateNamespace should be of the form "CreateNamespace ..." (golint)
- Line 161: warning: exported method KubeCtl.DeleteNamespace should have comment or be unexported (golint)
- Line 165: warning: exported method KubeCtl.TearDownNamespace should have comment or be unexported (golint)
- Line 182: warning: exported function GetConfigMapObj should have comment or be unexported (golint)
- Line 190: warning: exported method KubeCtl.CreateConfigMap should have comment or be unexported (golint)
- Line 194: warning: exported method KubeCtl.GetConfigMap should have comment or be unexported (golint)
- Line 198: warning: exported method KubeCtl.UpdateConfigMap should have comment or be unexported (golint)
- Line 202: warning: exported method KubeCtl.DeleteConfigMap should have comment or be unexported (golint)
- Line 206: warning: exported function GetPodObj should have comment or be unexported (golint)
- Line 214: warning: exported method KubeCtl.CreatePod should have comment or be unexported (golint)
- Line 218: warning: exported method KubeCtl.DeletePod should have comment or be unexported (golint)
- Line 263: warning: exported method KubeCtl.WaitForPodTerminated should have comment or be unexported (golint)
- Line 267: warning: comment on exported method KubeCtl.WaitForPodRunning should be of the form "WaitForPodRunning ..." (golint)
- Line 273: warning: exported method KubeCtl.WaitForPodPending should have comment or be unexported (golint)
- Line 277: warning: exported method KubeCtl.WaitForPodSucceeded should have comment or be unexported (golint)
- Line 281: warning: exported method KubeCtl.WaitForPodFailed should have comment or be unexported (golint)
- Line 285: warning: comment on exported method KubeCtl.ListPods should be of the form "ListPods ..." (golint)
- Line 296: warning: comment on exported method KubeCtl.WaitForPodBySelectorRunning should be of the form "WaitForPodBySelectorRunning ..." (golint)
- Line 315: warning: exported method KubeCtl.CreateSecret should have comment or be unexported (golint)
- Line 319: warning: exported function GetSecretObj should have comment or be unexported (golint)
- Line 327: warning: exported method KubeCtl.CreateServiceAccount should have comment or be unexported (golint)
- Line 333: warning: exported method KubeCtl.DeleteServiceAccount should have comment or be unexported (golint)
- Line 337: warning: exported method KubeCtl.CreateClusterRoleBinding should have comment or be unexported (golint)
- Line 356: warning: exported method KubeCtl.DeleteClusterRoleBindings should have comment or be unexported (golint)
- Line 360: warning: exported method KubeCtl.GetConfigMaps should have comment or be unexported (golint)
- Line 364: warning: exported method KubeCtl.UpdateConfigMaps should have comment or be unexported (golint)
- Line 368: warning: exported method KubeCtl.DeleteConfigMaps should have comment or be unexported (golint)
- Line 372: warning: exported method KubeCtl.CreateConfigMaps should have comment or be unexported (golint)
- Line 376: warning: exported method KubeCtl.GetEvents should have comment or be unexported (golint)
- Line 413: warning: exported method KubeCtl.WaitForPodScheduled should have comment or be unexported (golint)
- Line 438: warning: exported method KubeCtl.UpdateYunikornSchedulerPodAnnotation should have comment or be unexported (golint)
- Line 456: warning: exported method KubeCtl.RemoveYunikornSchedulerPodAnnotation should have comment or be unexported (golint)
- Line 474: warning: exported function ApplyYamlWithKubectl should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/utils/tg_map.go
- Line 25: warning: exported type TaskGroupInstanceCountMap should have comment or be unexported (golint)
- Line 30: warning: exported function NewTaskGroupInstanceCountMap should have comment or be unexported (golint)
- Line 36: warning: exported method TaskGroupInstanceCountMap.Add should have comment or be unexported (golint)
- Line 40: warning: exported method TaskGroupInstanceCountMap.AddOne should have comment or be unexported (golint)
- Line 44: warning: exported method TaskGroupInstanceCountMap.DeleteOne should have comment or be unexported (golint)
- Line 58: warning: exported method TaskGroupInstanceCountMap.Size should have comment or be unexported (golint)
- Line 64: warning: exported method TaskGroupInstanceCountMap.GetTaskGroupInstanceCount should have comment or be unexported (golint)
- Line 70: warning: exported method TaskGroupInstanceCountMap.Equals should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/schedulerapi_mock.go
- Line 29: warning: exported type SchedulerAPIMock should have comment or be unexported (golint)
- Line 38: warning: exported function NewSchedulerAPIMock should have comment or be unexported (golint)
- Line 53: warning: exported method SchedulerAPIMock.RegisterFunction should have comment or be unexported (golint)
- Line 59: warning: exported method SchedulerAPIMock.UpdateFunction should have comment or be unexported (golint)
- Line 66: warning: exported method SchedulerAPIMock.RegisterResourceManager should have comment or be unexported (golint)
- Line 74: warning: exported method SchedulerAPIMock.Update should have comment or be unexported (golint)
- Line 81: warning: exported method SchedulerAPIMock.ReloadConfiguration should have comment or be unexported (golint)
- Line 87: warning: exported method SchedulerAPIMock.GetRegisterCount should have comment or be unexported (golint)
- Line 91: warning: exported method SchedulerAPIMock.GetUpdateCount should have comment or be unexported (golint)
- Line 95: warning: exported method SchedulerAPIMock.ResetAllCounters should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/podinformer_mock.go
- Line 26: warning: exported type MockedPodInformer should have comment or be unexported (golint)
- Line 30: warning: exported function NewMockedPodInformer should have comment or be unexported (golint)
- Line 36: warning: exported method MockedPodInformer.Informer should have comment or be unexported (golint)
- Line 40: warning: exported method MockedPodInformer.Lister should have comment or be unexported (golint)
- Line 44: warning: exported method MockedPodInformer.SetLister should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/appmgmt_recovery.go
- Line 33: warning: exported method AppManagementService.WaitForRecovery should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/client/apifactory.go
- Line 39: warning: exported type Type should have comment or be unexported (golint)
- Line 42: warning: exported const PodInformerHandlers should have comment (or a comment on this block) or be unexported (golint)
- Line 51: warning: exported type APIProvider should have comment or be unexported (golint)
- Line 60: warning: comment on exported type ResourceEventHandlers should be of the form "ResourceEventHandlers ..." (with optional leading article) (golint)
- Line 70: warning: comment on exported type APIFactory should be of the form "APIFactory ..." (with optional leading article) (golint)
- Line 79: warning: exported function NewAPIFactory should have comment or be unexported (golint)
- Line 134: warning: exported method APIFactory.GetAPIs should have comment or be unexported (golint)
- Line 138: warning: exported method APIFactory.IsTestingMode should have comment or be unexported (golint)
- Line 142: warning: exported method APIFactory.AddEventHandler should have comment or be unexported (golint)
- Line 194: warning: exported method APIFactory.WaitForSync should have comment or be unexported (golint)
- Line 202: warning: exported method APIFactory.Start should have comment or be unexported (golint)
- Line 213: warning: exported method APIFactory.Stop should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/k8s/events.go
- Line 39: warning: exported function ScheduleSuccessEvent should have comment or be unexported (golint)
- Line 48: warning: exported function ScheduleFailureEvent should have comment or be unexported (golint)
- Line 59: warning: comment on exported function ObserveEventAfterAction should be of the form "ObserveEventAfterAction ..." (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/node.go
- Line 27: warning: comment on exported type Node should be of the form "Node ..." (with optional leading article) (golint)
- Line 35: warning: exported function NewNode should have comment or be unexported (golint)
- Line 39: warning: exported function CreateFrom should have comment or be unexported (golint)
- Line 47: warning: exported function CreateFromNodeSpec should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/plugin/predicates/predictor.go
- Line 79: warning: exported type Predictor should have comment or be unexported (golint)
- Line 90: warning: exported function NewPredictor should have comment or be unexported (golint)
- Line 243: warning: exported method Predictor.GetPredicateMeta should have comment or be unexported (golint)
- Line 248: warning: exported method Predictor.Enabled should have comment or be unexported (golint)
- Line 252: warning: exported method Predictor.Predicates should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/plugin/admissioncontrollers/webhook/webhook.go
- Line 38: warning: exported const HTTPPort should have comment (or a comment on this block) or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/interfaces/appprotocol.go
- Line 23: warning: exported type ManagedApp should have comment or be unexported (golint)
- Line 33: warning: exported type ManagedTask should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/context_recovery.go
- Line 40: warning: exported method Context.WaitForRecovery should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/task_events.go
- Line 23: warning: comment on exported type SimpleTaskEvent should be of the form "SimpleTaskEvent ..." (with optional leading article) (golint)
- Line 32: warning: exported function NewSimpleTaskEvent should have comment or be unexported (golint)
- Line 40: warning: exported method SimpleTaskEvent.GetEvent should have comment or be unexported (golint)
- Line 44: warning: exported method SimpleTaskEvent.GetArgs should have comment or be unexported (golint)
- Line 48: warning: exported method SimpleTaskEvent.GetTaskID should have comment or be unexported (golint)
- Line 52: warning: exported method SimpleTaskEvent.GetApplicationID should have comment or be unexported (golint)
- Line 56: warning: comment on exported type SubmitTaskEvent should be of the form "SubmitTaskEvent ..." (with optional leading article) (golint)
- Line 65: warning: exported function NewSubmitTaskEvent should have comment or be unexported (golint)
- Line 73: warning: exported method SubmitTaskEvent.GetEvent should have comment or be unexported (golint)
- Line 77: warning: exported method SubmitTaskEvent.GetArgs should have comment or be unexported (golint)
- Line 81: warning: exported method SubmitTaskEvent.GetTaskID should have comment or be unexported (golint)
- Line 85: warning: exported method SubmitTaskEvent.GetApplicationID should have comment or be unexported (golint)
- Line 89: warning: comment on exported type AllocatedTaskEvent should be of the form "AllocatedTaskEvent ..." (with optional leading article) (golint)
- Line 100: warning: exported function NewAllocateTaskEvent should have comment or be unexported (golint)
- Line 110: warning: exported method AllocatedTaskEvent.GetEvent should have comment or be unexported (golint)
- Line 114: warning: exported method AllocatedTaskEvent.GetArgs should have comment or be unexported (golint)
- Line 121: warning: exported method AllocatedTaskEvent.GetTaskID should have comment or be unexported (golint)
- Line 125: warning: exported method AllocatedTaskEvent.GetApplicationID should have comment or be unexported (golint)
- Line 129: warning: comment on exported type BindTaskEvent should be of the form "BindTaskEvent ..." (with optional leading article) (golint)
- Line 138: warning: exported function NewBindTaskEvent should have comment or be unexported (golint)
- Line 146: warning: exported method BindTaskEvent.GetEvent should have comment or be unexported (golint)
- Line 150: warning: exported method BindTaskEvent.GetArgs should have comment or be unexported (golint)
- Line 154: warning: exported method BindTaskEvent.GetTaskID should have comment or be unexported (golint)
- Line 158: warning: exported method BindTaskEvent.GetApplicationID should have comment or be unexported (golint)
- Line 162: warning: comment on exported type FailTaskEvent should be of the form "FailTaskEvent ..." (with optional leading article) (golint)
- Line 172: warning: exported function NewFailTaskEvent should have comment or be unexported (golint)
- Line 181: warning: exported method FailTaskEvent.GetEvent should have comment or be unexported (golint)
- Line 185: warning: exported method FailTaskEvent.GetArgs should have comment or be unexported (golint)
- Line 191: warning: exported method FailTaskEvent.GetTaskID should have comment or be unexported (golint)
- Line 195: warning: exported method FailTaskEvent.GetApplicationID should have comment or be unexported (golint)
- Line 199: warning: comment on exported type RejectTaskEvent should be of the form "RejectTaskEvent ..." (with optional leading article) (golint)
- Line 209: warning: exported function NewRejectTaskEvent should have comment or be unexported (golint)
- Line 218: warning: exported method RejectTaskEvent.GetEvent should have comment or be unexported (golint)
- Line 222: warning: exported method RejectTaskEvent.GetArgs should have comment or be unexported (golint)
- Line 228: warning: exported method RejectTaskEvent.GetTaskID should have comment or be unexported (golint)
- Line 232: warning: exported method RejectTaskEvent.GetApplicationID should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/context.go
- Line 46: warning: comment on exported type Context should be of the form "Context ..." (with optional leading article) (golint)
- Line 56: warning: comment on exported function NewContext should be of the form "NewContext ..." (golint)
- Line 79: warning: exported method Context.AddSchedulingEventHandlers should have comment or be unexported (golint)
- Line 315: warning: comment on exported method Context.IsPodFitNode should be of the form "IsPodFitNode ..." (golint)
- Line 355: warning: comment on exported method Context.AssumePod should be of the form "AssumePod ..." (golint)
- Line 389: warning: comment on exported method Context.ForgetPod should be of the form "ForgetPod ..." (golint)
- Line 404: warning: exported method Context.UpdateApplication should have comment or be unexported (golint)
- Line 410: warning: comment on exported method Context.NotifyApplicationComplete should be of the form "NotifyApplicationComplete ..." (golint)
- Line 423: warning: exported method Context.NotifyApplicationFail should have comment or be unexported (golint)
- Line 433: warning: exported method Context.NotifyTaskComplete should have comment or be unexported (golint)
- Line 489: warning: exported method Context.AddApplication should have comment or be unexported (golint)
- Line 523: warning: exported method Context.GetApplication should have comment or be unexported (golint)
- Line 532: warning: exported method Context.RemoveApplication should have comment or be unexported (golint)
- Line 556: warning: exported method Context.RemoveApplicationInternal should have comment or be unexported (golint)
- Line 566: warning: comment on exported method Context.AddTask should be of the form "AddTask ..." (golint)
- Line 597: warning: exported method Context.RemoveTask should have comment or be unexported (golint)
- Line 619: warning: exported method Context.SelectApplications should have comment or be unexported (golint)
- Line 634: warning: exported method Context.PublishEvents should have comment or be unexported (golint)
- Line 705: warning: comment on exported method Context.HandleContainerStateUpdate should be of the form "HandleContainerStateUpdate ..." (golint)
- Line 746: warning: exported method Context.ApplicationEventHandler should have comment or be unexported (golint)
- Line 769: warning: exported method Context.TaskEventHandler should have comment or be unexported (golint)
- Line 791: warning: exported method Context.SchedulerNodeEventHandler should have comment or be unexported (golint)
- Line 811: warning: comment on exported method Context.SaveConfigmap should be of the form "SaveConfigmap ..." (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/interfaces/recoverable.go
- Line 27: warning: comment on exported type Recoverable should be of the form "Recoverable ..." (with optional leading article) (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/yunikorn/rest_api_utils.go
- Line 37: warning: exported type RClient should have comment or be unexported (golint)
- Line 86: warning: exported method RClient.GetPartitions should have comment or be unexported (golint)
- Line 96: warning: exported method RClient.GetQueues should have comment or be unexported (golint)
- Line 106: warning: exported method RClient.GetSpecificQueueInfo should have comment or be unexported (golint)
- Line 126: warning: exported method RClient.GetApps should have comment or be unexported (golint)
- Line 136: warning: exported method RClient.GetAppInfo should have comment or be unexported (golint)
- Line 151: warning: exported method RClient.GetAppsFromSpecificQueue should have comment or be unexported (golint)
- Line 184: warning: exported method RClient.WaitForAppStateTransition should have comment or be unexported (golint)
- Line 188: warning: exported method RClient.AreAllExecPodsAllotted should have comment or be unexported (golint)
- Line 227: warning: exported function WaitForSchedPolicy should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/interfaces/amprotocol.go
- Line 28: warning: comment on exported type ApplicationManagementProtocol should be of the form "ApplicationManagementProtocol ..." (with optional leading article) (golint)
- Line 67: warning: exported type AddApplicationRequest should have comment or be unexported (golint)
- Line 71: warning: exported type AddTaskRequest should have comment or be unexported (golint)
- Line 76: warning: exported type ApplicationMetadata should have comment or be unexported (golint)
- Line 86: warning: exported type TaskMetadata should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/controller/application/app_controller.go
- Line 39: warning: exported type AppManager should have comment or be unexported (golint)
- Line 47: warning: exported function NewAppManager should have comment or be unexported (golint)
- Line 54: warning: comment on exported method AppManager.Name should be of the form "Name ..." (golint)
- Line 59: warning: comment on exported method AppManager.ServiceInit should be of the form "ServiceInit ..." (golint)
- Line 64: warning: comment on exported method AppManager.Start should be of the form "Start ..." (golint)
- Line 74: warning: comment on exported method AppManager.Stop should be of the form "Stop ..." (golint)
- Line 79: warning: comment on exported method AppManager.HandleApplicationStateUpdate should be of the form "HandleApplicationStateUpdate ..." (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/common/utils.go
- Line 38: warning: exported function GetAbsPath should have comment or be unexported (golint)
- Line 83: warning: exported function GetFileContents should have comment or be unexported (golint)
- Line 88: warning: exported function GetUUID should have comment or be unexported (golint)
- Line 92: warning: exported function RandSeq should have comment or be unexported (golint)
- Line 102: warning: exported function SliceExists should have comment or be unexported (golint)
- Line 117: warning: comment on exported function CompareQueueMap should be of the form "CompareQueueMap ..." (golint)
- Line 177: warning: comment on exported function GetSubQueues should be of the form "GetSubQueues ..." (golint)
-
-
incubator-yunikorn-k8shim/pkg/shim/scheduler.go
- Line 42: warning: comment on exported type KubernetesShim should be of the form "KubernetesShim ..." (with optional leading article) (golint)
- Line 120: warning: exported method KubernetesShim.SchedulerEventHandler should have comment or be unexported (golint)
- Line 229: warning: exported method KubernetesShim.GetSchedulerState should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/node_events.go
- Line 23: warning: exported type CachedSchedulerNodeEvent should have comment or be unexported (golint)
- Line 29: warning: exported method CachedSchedulerNodeEvent.GetEvent should have comment or be unexported (golint)
- Line 33: warning: exported method CachedSchedulerNodeEvent.GetArgs should have comment or be unexported (golint)
- Line 37: warning: exported method CachedSchedulerNodeEvent.GetNodeID should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/podlister_mock.go
- Line 29: warning: exported type PodListerMock should have comment or be unexported (golint)
- Line 33: warning: exported function NewPodListerMock should have comment or be unexported (golint)
- Line 39: warning: exported method PodListerMock.AddPod should have comment or be unexported (golint)
- Line 43: warning: exported method PodListerMock.List should have comment or be unexported (golint)
- Line 53: warning: exported method PodListerMock.Get should have comment or be unexported (golint)
- Line 62: warning: exported method PodListerMock.Pods should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/common/deserializer.go
- Line 27: warning: exported function Yaml2Obj should have comment or be unexported (golint)
- Line 37: warning: exported function Y2Map should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/test/namespacelister_mock.go
- Line 29: warning: exported type MockNamespaceLister should have comment or be unexported (golint)
- Line 33: warning: exported function NewMockNamespaceLister should have comment or be unexported (golint)
- Line 39: warning: exported method MockNamespaceLister.List should have comment or be unexported (golint)
- Line 43: warning: exported method MockNamespaceLister.Add should have comment or be unexported (golint)
- Line 47: warning: exported method MockNamespaceLister.Get should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/apis/yunikorn.apache.org/v1alpha1/type.go
- Line 30: warning: exported type Application should have comment or be unexported (golint)
- Line 40: warning: exported type ApplicationSpec should have comment or be unexported (golint)
- Line 46: warning: exported type SchedulingPolicy should have comment or be unexported (golint)
- Line 51: warning: exported type SchedulingPolicyType should have comment or be unexported (golint)
- Line 54: warning: exported const TryOnce should have comment (or a comment on this block) or be unexported (golint)
- Line 60: warning: exported type TaskGroup should have comment or be unexported (golint)
- Line 72: warning: exported type ApplicationStateType should have comment or be unexported (golint)
- Line 75: warning: exported const NewApplicationState should have comment (or a comment on this block) or be unexported (golint)
- Line 85: warning: exported type ApplicationStatus should have comment or be unexported (golint)
- Line 94: warning: exported type ApplicationList should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/events/recorder.go
- Line 38: warning: exported function GetRecorder should have comment or be unexported (golint)
- Line 58: warning: exported function SetRecorderForTest should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/simulation/gang/webserver/webservice.go
- Line 33: warning: exported type WebService should have comment or be unexported (golint)
- Line 54: warning: exported method WebService.StartWebApp should have comment or be unexported (golint)
- Line 64: warning: exported function NewWebApp should have comment or be unexported (golint)
- Line 69: warning: exported method WebService.StopWebApp should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/constants/constants.go
- Line 21: warning: comment on exported const DefaultNodeAttributeHostNameKey should be of the form "DefaultNodeAttributeHostNameKey ..." (golint)
- Line 23: warning: exported const DefaultNodeAttributeRackNameKey should have comment or be unexported (golint)
- Line 24: warning: exported const DefaultRackName should have comment or be unexported (golint)
- Line 26: warning: comment on exported const LabelApp should be of the form "LabelApp ..." (golint)
- Line 28: warning: exported const LabelApplicationID should have comment or be unexported (golint)
- Line 29: warning: exported const AnnotationApplicationID should have comment or be unexported (golint)
- Line 30: warning: exported const LabelQueueName should have comment or be unexported (golint)
- Line 31: warning: exported const ApplicationDefaultQueue should have comment or be unexported (golint)
- Line 32: warning: exported const DefaultPartition should have comment or be unexported (golint)
- Line 33: warning: exported const AppTagNamespace should have comment or be unexported (golint)
- Line 34: warning: exported const AppTagNamespaceResourceQuota should have comment or be unexported (golint)
- Line 35: warning: exported const AppTagNamespaceParentQueue should have comment or be unexported (golint)
- Line 36: warning: exported const DefaultAppNamespace should have comment or be unexported (golint)
- Line 37: warning: exported const DefaultUserLabel should have comment or be unexported (golint)
- Line 38: warning: exported const DefaultUser should have comment or be unexported (golint)
- Line 40: warning: comment on exported const Memory should be of the form "Memory ..." (golint)
- Line 42: warning: exported const CPU should have comment or be unexported (golint)
- Line 44: warning: comment on exported const SparkLabelAppID should be of the form "SparkLabelAppID ..." (golint)
- Line 46: warning: exported const SparkLabelRole should have comment or be unexported (golint)
- Line 47: warning: exported const SparkLabelRoleDriver should have comment or be unexported (golint)
- Line 49: warning: comment on exported const DefaultConfigMapName should be of the form "DefaultConfigMapName ..." (golint)
- Line 51: warning: exported const SchedulerName should have comment or be unexported (golint)
- Line 53: warning: comment on exported const AppManagerHandlerName should be of the form "AppManagerHandlerName ..." (golint)
- Line 56: warning: comment on exported const PlaceholderContainerImage should be of the form "PlaceholderContainerImage ..." (golint)
- Line 58: warning: exported const PlaceholderContainerName should have comment or be unexported (golint)
- Line 59: warning: exported const PlaceholderPodRestartPolicy should have comment or be unexported (golint)
- Line 60: warning: exported const LabelPlaceholderFlag should have comment or be unexported (golint)
- Line 61: warning: exported const AnnotationPlaceholderFlag should have comment or be unexported (golint)
- Line 62: warning: exported const AnnotationTaskGroupName should have comment or be unexported (golint)
- Line 63: warning: exported const AnnotationTaskGroups should have comment or be unexported (golint)
- Line 64: warning: exported const AnnotationSchedulingPolicyParam should have comment or be unexported (golint)
- Line 65: warning: exported const SchedulingPolicyTimeoutParam should have comment or be unexported (golint)
- Line 66: warning: exported const SchedulingPolicyParamDelimiter should have comment or be unexported (golint)
- Line 68: warning: exported const ApplicationInsufficientResourcesFailure should have comment or be unexported (golint)
- Line 69: warning: exported const ApplicationRejectedFailure should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/appmgmt.go
- Line 42: warning: exported function NewAMService should have comment or be unexported (golint)
- Line 67: warning: exported method AppManagementService.GetAllManagers should have comment or be unexported (golint)
- Line 71: warning: exported method AppManagementService.GetManagerByName should have comment or be unexported (golint)
- Line 93: warning: exported method AppManagementService.Start should have comment or be unexported (golint)
- Line 119: warning: exported method AppManagementService.Stop should have comment or be unexported (golint)
- Line 126: warning: exported method AppManagementService.ApplicationStateUpdateEventHandler should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/dispatcher/dispatcher.go
- Line 37: warning: exported type EventType should have comment or be unexported (golint)
- Line 40: warning: exported const EventTypeApp should have comment (or a comment on this block) or be unexported (golint)
- Line 48: warning: exported var AsyncDispatchLimit should have comment or be unexported (golint)
- Line 54: warning: comment on exported type Dispatcher should be of the form "Dispatcher ..." (with optional leading article) (golint)
- Line 86: warning: exported function RegisterEventHandler should have comment or be unexported (golint)
- Line 108: warning: comment on exported function Dispatch should be of the form "Dispatch ..." (golint)
- Line 182: warning: exported function Start should have comment or be unexported (golint)
- Line 213: warning: comment on exported function Stop should be of the form "Stop ..." (golint)
-
-
incubator-yunikorn-k8shim/pkg/common/si_helper.go
- Line 46: warning: exported function CreateUpdateRequestForTask should have comment or be unexported (golint)
- Line 67: warning: exported function CreateReleaseAskRequestForTask should have comment or be unexported (golint)
- Line 88: warning: exported function GetTerminationTypeFromString should have comment or be unexported (golint)
- Line 95: warning: exported function CreateReleaseAllocationRequestForTask should have comment or be unexported (golint)
- Line 117: warning: exported function CreateUpdateRequestForNewNode should have comment or be unexported (golint)
- Line 139: warning: exported function CreateUpdateRequestForUpdatedNode should have comment or be unexported (golint)
- Line 158: warning: exported function CreateUpdateRequestForDeleteNode should have comment or be unexported (golint)
- Line 176: warning: exported function CreateUpdateRequestForRemoveApplication should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/client/kubeclient.go
- Line 33: warning: exported type SchedulerKubeClient should have comment or be unexported (golint)
- Line 72: warning: exported method SchedulerKubeClient.GetClientSet should have comment or be unexported (golint)
- Line 76: warning: exported method SchedulerKubeClient.GetConfigs should have comment or be unexported (golint)
- Line 80: warning: exported method SchedulerKubeClient.Bind should have comment or be unexported (golint)
- Line 103: warning: exported method SchedulerKubeClient.Create should have comment or be unexported (golint)
- Line 107: warning: exported method SchedulerKubeClient.Delete should have comment or be unexported (golint)
- Line 122: warning: exported method SchedulerKubeClient.Get should have comment or be unexported (golint)
- Line 134: warning: exported method SchedulerKubeClient.UpdateStatus should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/test/e2e/framework/helpers/yunikorn/application_utils.go
- Line 33: warning: exported function GetApplicationObj should have comment or be unexported (golint)
- Line 45: warning: exported function CreateApplication should have comment or be unexported (golint)
- Line 53: warning: exported function UpdateApplication should have comment or be unexported (golint)
- Line 61: warning: exported function GetApplication should have comment or be unexported (golint)
- Line 69: warning: exported function DeleteApplication should have comment or be unexported (golint)
- Line 77: warning: exported function NewApplicationClient should have comment or be unexported (golint)
- Line 86: warning: exported function NewClient should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/application.go
- Line 45: warning: exported type Application should have comment or be unexported (golint)
- Line 68: warning: exported function NewApplication should have comment or be unexported (golint)
- Line 177: warning: exported method Application.GetTask should have comment or be unexported (golint)
- Line 187: warning: exported method Application.GetApplicationID should have comment or be unexported (golint)
- Line 193: warning: exported method Application.GetQueue should have comment or be unexported (golint)
- Line 199: warning: exported method Application.GetUser should have comment or be unexported (golint)
- Line 268: warning: exported method Application.GetApplicationState should have comment or be unexported (golint)
- Line 272: warning: exported method Application.GetPendingTasks should have comment or be unexported (golint)
- Line 278: warning: exported method Application.GetNewTasks should have comment or be unexported (golint)
- Line 284: warning: exported method Application.GetAllocatedTasks should have comment or be unexported (golint)
- Line 310: warning: exported method Application.GetTags should have comment or be unexported (golint)
- Line 332: warning: exported method Application.TriggerAppRecovery should have comment or be unexported (golint)
- Line 643: warning: exported method Application.SetPlaceholderTimeout should have comment or be unexported (golint)
-
-
incubator-yunikorn-k8shim/pkg/cache/node.go
- Line 37: warning: comment on exported type SchedulerNode should be of the form "SchedulerNode ..." (with optional leading article) (golint)
-
-
incubator-yunikorn-k8shim/pkg/appmgmt/interfaces/appmgr.go
- Line 21: warning: comment on exported type AppManager should be of the form "AppManager ..." (with optional leading article) (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell99%
Misspell Finds commonly misspelled English words
-
-
incubator-yunikorn-k8shim/pkg/common/utils/gang_utils_test.go
- Line 299: warning: "unkown" is a misspelling of "unknown" (misspell)
- Line 300: warning: "unkown" is a misspelling of "unknown" (misspell)
- Line 301: warning: "unkown" is a misspelling of "unknown" (misspell)
- Line 302: warning: "unkown" is a misspelling of "unknown" (misspell)
- Line 303: warning: "unkown" is a misspelling of "unknown" (misspell)