Report for github.com/appscode/grpc-go-addons
(v0.3.0)
A+ Excellent! Found 16 issues across 19 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint21%
Golint is a linter for Go source code.
-
-
cors/gateway.go
- Line 29: warning: comment on exported type Handler should be of the form "Handler ..." (with optional leading article) (golint)
- Line 37: warning: exported function NewHandler should have comment or be unexported (golint)
- Line 41: warning: exported method Handler.RegisterHandler should have comment or be unexported (golint)
-
-
testing/mutex_readerwriter.go
- Line 17: warning: don't use an underscore in package name (golint)
-
-
testing/pingservice.go
- Line 8: warning: don't use an underscore in package name (golint)
- Line 22: warning: comment on exported const DefaultResponseValue should be of the form "DefaultResponseValue ..." (golint)
- Line 28: warning: exported type TestPingService should have comment or be unexported (golint)
- Line 32: warning: exported method TestPingService.PingEmpty should have comment or be unexported (golint)
- Line 36: warning: exported method TestPingService.Ping should have comment or be unexported (golint)
- Line 41: warning: exported method TestPingService.PingError should have comment or be unexported (golint)
- Line 46: warning: exported method TestPingService.PingList should have comment or be unexported (golint)
- Line 57: warning: exported method TestPingService.PingStream should have comment or be unexported (golint)
-
-
endpoints/grpc.go
- Line 31: warning: exported type GRPCRegistry should have comment or be unexported (golint)
- Line 33: warning: exported method GRPCRegistry.Register should have comment or be unexported (golint)
- Line 43: warning: exported method GRPCRegistry.ApplyTo should have comment or be unexported (golint)
-
-
server/options/recommended.go
- Line 27: warning: exported type RecommendedOptions should have comment or be unexported (golint)
- Line 32: warning: exported function NewRecommendedOptions should have comment or be unexported (golint)
- Line 39: warning: exported method RecommendedOptions.AddGoFlags should have comment or be unexported (golint)
- Line 44: warning: exported method RecommendedOptions.AddFlags should have comment or be unexported (golint)
- Line 49: warning: exported method RecommendedOptions.ApplyTo should have comment or be unexported (golint)
- Line 59: warning: exported method RecommendedOptions.Validate should have comment or be unexported (golint)
-
-
testing/interceptor_suite.go
- Line 4: warning: don't use an underscore in package name (golint)
- Line 45: warning: exported method InterceptorTestSuite.SetupSuite should have comment or be unexported (golint)
- Line 71: warning: exported method InterceptorTestSuite.NewClient should have comment or be unexported (golint)
- Line 86: warning: exported method InterceptorTestSuite.ServerAddr should have comment or be unexported (golint)
- Line 90: warning: exported method InterceptorTestSuite.SimpleCtx should have comment or be unexported (golint)
- Line 95: warning: exported method InterceptorTestSuite.DeadlineCtx should have comment or be unexported (golint)
- Line 100: warning: exported method InterceptorTestSuite.TearDownSuite should have comment or be unexported (golint)
-
-
endpoints/gateway.go
- Line 30: warning: exported type RegisterProxyHandlerFunc should have comment or be unexported (golint)
- Line 36: warning: exported type ProxyRegistry should have comment or be unexported (golint)
- Line 38: warning: exported method ProxyRegistry.Register should have comment or be unexported (golint)
- Line 47: warning: exported method ProxyRegistry.ApplyTo should have comment or be unexported (golint)
-
-
schema_validator/doc.go
- Line 4: warning: package comment should be of the form "Package grpc_schema_validator ..." (golint)
- Line 45: warning: don't use an underscore in package name (golint)
-
-
server/options/cors.go
- Line 27: warning: exported type CorsOptions should have comment or be unexported (golint)
- Line 33: warning: exported function NewCORSOptions should have comment or be unexported (golint)
- Line 40: warning: exported method CorsOptions.AddGoFlags should have comment or be unexported (golint)
- Line 46: warning: exported method CorsOptions.AddFlags should have comment or be unexported (golint)
- Line 52: warning: exported method CorsOptions.ApplyTo should have comment or be unexported (golint)
- Line 60: warning: exported method CorsOptions.Validate should have comment or be unexported (golint)
-
-
cors/registry.go
- Line 21: warning: comment on exported type PatternRegistry should be of the form "PatternRegistry ..." (with optional leading article) (golint)
- Line 26: warning: exported method PatternRegistry.Register should have comment or be unexported (golint)
-
-
server/server.go
- Line 37: warning: exported type Server should have comment or be unexported (golint)
- Line 41: warning: exported method Server.Run should have comment or be unexported (golint)
- Line 97: warning: exported method Server.NewGatewayMux should have comment or be unexported (golint)
- Line 118: warning: exported method Server.ServeHTTPS should have comment or be unexported (golint)
-
-
schema_validator/validator.go
- Line 4: warning: don't use an underscore in package name (golint)
-
-
server/options/serving.go
- Line 27: warning: exported type SecureServingOptions should have comment or be unexported (golint)
- Line 36: warning: exported function NewSecureServingOptions should have comment or be unexported (golint)
- Line 43: warning: exported method SecureServingOptions.AddGoFlags should have comment or be unexported (golint)
- Line 53: warning: exported method SecureServingOptions.AddFlags should have comment or be unexported (golint)
- Line 59: warning: exported method SecureServingOptions.ApplyTo should have comment or be unexported (golint)
- Line 70: warning: exported method SecureServingOptions.Validate should have comment or be unexported (golint)
-
-
cors/options.go
- Line 40: warning: exported type Option should have comment or be unexported (golint)
- Line 42: warning: exported function OriginHost should have comment or be unexported (golint)
- Line 48: warning: exported function AllowSubdomain should have comment or be unexported (golint)
-
-
server/config.go
- Line 27: warning: exported type Config should have comment or be unexported (golint)
- Line 46: warning: exported function NewConfig should have comment or be unexported (golint)
- Line 50: warning: exported method Config.UseTLS should have comment or be unexported (golint)
- Line 54: warning: exported method Config.SetGRPCRegistry should have comment or be unexported (golint)
- Line 58: warning: exported method Config.SetProxyRegistry should have comment or be unexported (golint)
- Line 62: warning: exported method Config.SetCORSRegistry should have comment or be unexported (golint)
- Line 66: warning: exported method Config.GRPCServerOption should have comment or be unexported (golint)
- Line 70: warning: exported method Config.GatewayMuxOption should have comment or be unexported (golint)
- Line 74: warning: exported method Config.New should have comment or be unexported (golint)
- Line 74: warning: receiver name c should be consistent with previous receiver name s for Config (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell84%
Misspell Finds commonly misspelled English words
-
-
schema_validator/doc.go
- Line 10: warning: "existance" is a misspelling of "existence" (misspell)
- Line 38: warning: "existance" is a misspelling of "existence" (misspell)
-
-
schema_validator/validator_test.go
- Line 62: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 80: warning: "receving" is a misspelling of "receiving" (misspell)
- Line 83: warning: "receving" is a misspelling of "receiving" (misspell)
- Line 87: warning: "receving" is a misspelling of "receiving" (misspell)
-
-
server/server.go
- Line 57: warning: "againts" is a misspelling of "against" (misspell)