Preparing report...

Report for github.com/appscode/voyager

A+    Excellent!    Found 67 issues across 151 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • voyager/pkg/ingress/internal.go
    • Line 89: warning: cyclomatic complexity 19 of function (*internalController).Reconcile() is high (> 15) (gocyclo)
    • Line 325: warning: cyclomatic complexity 16 of function (*internalController).ensurePods() is high (> 15) (gocyclo)
    • voyager/pkg/ingress/loadbalancer.go
    • Line 94: warning: cyclomatic complexity 19 of function (*loadBalancerController).Reconcile() is high (> 15) (gocyclo)
    • Line 275: warning: cyclomatic complexity 17 of function (*loadBalancerController).ensureService() is high (> 15) (gocyclo)
    • Line 379: warning: cyclomatic complexity 16 of function (*loadBalancerController).ensurePods() is high (> 15) (gocyclo)
    • voyager/pkg/ingress/nodeport.go
    • Line 125: warning: cyclomatic complexity 21 of function (*nodePortController).Reconcile() is high (> 15) (gocyclo)
    • Line 444: warning: cyclomatic complexity 16 of function (*nodePortController).ensurePods() is high (> 15) (gocyclo)
    • voyager/pkg/ingress/hostport.go
    • Line 124: warning: cyclomatic complexity 20 of function (*hostPortController).Reconcile() is high (> 15) (gocyclo)
    • Line 407: warning: cyclomatic complexity 16 of function (*hostPortController).ensurePods() is high (> 15) (gocyclo)
    • voyager/pkg/ingress/parser.go
    • Line 307: warning: cyclomatic complexity 104 of function (*controller).generateConfig() is high (> 15) (gocyclo)
    • Line 104: warning: cyclomatic complexity 24 of function (*controller).getEndpoints() is high (> 15) (gocyclo)

golint56%

Golint is a linter for Go source code.

    • voyager/crds/lib.go
    • Line 39: warning: exported function CustomResourceDefinition should have comment or be unexported (golint)
    • Line 59: warning: exported function MustCustomResourceDefinition should have comment or be unexported (golint)
    • voyager/pkg/operator/gc.go
    • Line 29: warning: exported method Operator.PurgeOffshootsWithDeprecatedLabels should have comment or be unexported (golint)
    • Line 130: warning: exported method Operator.PurgeOffshootsDaemonSet should have comment or be unexported (golint)
    • voyager/apis/voyager/v1beta1/monitor.go
    • Line 26: warning: exported const StatsPortName should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported method Ingress.StatsAccessor should have comment or be unexported (golint)
    • voyager/pkg/server/server.go
    • Line 53: warning: exported var Scheme should have comment or be unexported (golint)
    • Line 75: warning: exported type VoyagerConfig should have comment or be unexported (golint)
    • Line 86: warning: exported method VoyagerServer.Run should have comment or be unexported (golint)
    • Line 96: warning: exported type CompletedConfig should have comment or be unexported (golint)
    • voyager/pkg/cmds/run.go
    • Line 21: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 31: warning: exported function NewCmdRun should have comment or be unexported (golint)
    • voyager/pkg/operator/operator.go
    • Line 45: warning: exported type Operator should have comment or be unexported (golint)
    • Line 130: warning: exported method Operator.RunInformers should have comment or be unexported (golint)
    • Line 181: warning: exported method Operator.Run should have comment or be unexported (golint)
    • Line 181: warning: receiver name w should be consistent with previous receiver name op for Operator (golint)
    • voyager/pkg/haproxy/controller/controller.go
    • Line 45: warning: exported type Options should have comment or be unexported (golint)
    • Line 58: warning: exported method Options.UsesEngress should have comment or be unexported (golint)
    • Line 62: warning: exported type Controller should have comment or be unexported (golint)
    • Line 86: warning: exported function New should have comment or be unexported (golint)
    • Line 104: warning: exported method Controller.Setup should have comment or be unexported (golint)
    • Line 242: warning: exported method Controller.Run should have comment or be unexported (golint)
    • voyager/apis/voyager/v1beta1/ingress.go
    • Line 26: warning: exported const ResourceKindIngress should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: comment on exported type Ingress should be of the form "Ingress ..." (with optional leading article) (golint)
    • Line 290: warning: exported type TCPIngressRuleValue should have comment or be unexported (golint)
    • Line 393: warning: exported type HTTPIngressBackend should have comment or be unexported (golint)
    • Line 407: warning: exported type IngressRef should have comment or be unexported (golint)
    • Line 413: warning: exported type FrontendRule should have comment or be unexported (golint)
    • Line 422: warning: exported type AuthOption should have comment or be unexported (golint)
    • Line 428: warning: exported type OAuth should have comment or be unexported (golint)
    • Line 436: warning: exported type BasicAuth should have comment or be unexported (golint)
    • Line 441: warning: exported type TLSAuthVerifyOption should have comment or be unexported (golint)
    • Line 444: warning: exported const TLSAuthVerifyOptional should have comment (or a comment on this block) or be unexported (golint)
    • Line 448: warning: exported type TLSAuth should have comment or be unexported (golint)
    • voyager/pkg/operator/config.go
    • Line 40: warning: exported type OperatorConfig should have comment or be unexported (golint)
    • Line 53: warning: exported function NewOperatorConfig should have comment or be unexported (golint)
    • Line 59: warning: exported method OperatorConfig.New should have comment or be unexported (golint)
    • voyager/pkg/operator/statefulset.go
    • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/pkg/ingress/controller.go
    • Line 28: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 46: warning: exported type Controller should have comment or be unexported (golint)
    • Line 77: warning: exported function NewController should have comment or be unexported (golint)
    • voyager/pkg/haproxy/api/helper_test.go
    • Line 62: warning: don't use underscores in Go names; var host_i should be hostI (golint)
    • Line 63: warning: don't use underscores in Go names; var host_rank_i should be hostRankI (golint)
    • Line 65: warning: don't use underscores in Go names; var host_j should be hostJ (golint)
    • Line 66: warning: don't use underscores in Go names; var host_rank_j should be hostRankJ (golint)
    • Line 83: warning: don't use underscores in Go names; var path_i should be pathI (golint)
    • Line 84: warning: don't use underscores in Go names; var path_comp_i should be pathCompI (golint)
    • Line 86: warning: don't use underscores in Go names; var path_j should be pathJ (golint)
    • Line 87: warning: don't use underscores in Go names; var path_comp_j should be pathCompJ (golint)
    • voyager/apis/voyager/v1beta1/diff.go
    • Line 39: warning: comment on exported method Ingress.ShouldHandleIngress should be of the form "ShouldHandleIngress ..." (golint)
    • Line 51: warning: exported method Ingress.HasChanged should have comment or be unexported (golint)
    • Line 84: warning: exported method Ingress.UseTLSForRule should have comment or be unexported (golint)
    • Line 92: warning: exported method Ingress.FindTLSSecret should have comment or be unexported (golint)
    • Line 106: warning: exported method Ingress.IsPortChanged should have comment or be unexported (golint)
    • Line 118: warning: exported method Ingress.IsLoadBalancerSourceRangeChanged should have comment or be unexported (golint)
    • Line 148: warning: exported method Ingress.IsStatsChanged should have comment or be unexported (golint)
    • Line 155: warning: exported method Ingress.IsStatsSecretChanged should have comment or be unexported (golint)
    • Line 159: warning: exported method Ingress.IsKeepSourceChanged should have comment or be unexported (golint)
    • Line 171: warning: exported method Ingress.BackendServices should have comment or be unexported (golint)
    • Line 205: warning: exported method Ingress.HasBackendService should have comment or be unexported (golint)
    • Line 236: warning: exported method Ingress.UsesAuthSecret should have comment or be unexported (golint)
    • Line 247: warning: comment on exported method IngressRule.GetHost should be of the form "GetHost ..." (golint)
    • Line 258: warning: exported method IngressRule.ParseALPNOptions should have comment or be unexported (golint)
    • Line 272: warning: exported method IngressBackend.ParseALPNOptions should have comment or be unexported (golint)
    • Line 279: warning: comment on exported method Ingress.ProtoWithALPN should be of the form "ProtoWithALPN ..." (golint)
    • Line 310: warning: comment on exported method Ingress.UseHTX should be of the form "UseHTX ..." (golint)
    • voyager/pkg/haproxy/api/helper.go
    • Line 32: warning: exported const URLPrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported method TemplateData.Canonicalize should have comment or be unexported (golint)
    • Line 71: warning: don't use underscores in Go names; var host_i should be hostI (golint)
    • Line 72: warning: don't use underscores in Go names; var host_rank_i should be hostRankI (golint)
    • Line 74: warning: don't use underscores in Go names; var host_j should be hostJ (golint)
    • Line 75: warning: don't use underscores in Go names; var host_rank_j should be hostRankJ (golint)
    • Line 98: warning: don't use underscores in Go names; var path_i should be pathI (golint)
    • Line 99: warning: don't use underscores in Go names; var path_comp_i should be pathCompI (golint)
    • Line 101: warning: don't use underscores in Go names; var path_j should be pathJ (golint)
    • Line 102: warning: don't use underscores in Go names; var path_comp_j should be pathCompJ (golint)
    • Line 122: warning: don't use underscores in Go names; var host_i should be hostI (golint)
    • Line 123: warning: don't use underscores in Go names; var host_rank_i should be hostRankI (golint)
    • Line 125: warning: don't use underscores in Go names; var host_j should be hostJ (golint)
    • Line 126: warning: don't use underscores in Go names; var host_rank_j should be hostRankJ (golint)
    • Line 227: warning: exported method TemplateData.IsValid should have comment or be unexported (golint)
    • Line 238: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 247: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 258: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 266: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 292: warning: exported function TimeOutConfigs should have comment or be unexported (golint)
    • Line 303: warning: exported function OptionConfigs should have comment or be unexported (golint)
    • Line 314: warning: exported function TLSHeaders should have comment or be unexported (golint)
    • voyager/pkg/cmds/server/options.go
    • Line 41: warning: exported type OperatorOptions should have comment or be unexported (golint)
    • Line 64: warning: exported method OperatorOptions.HAProxyImage should have comment or be unexported (golint)
    • Line 68: warning: exported method OperatorOptions.ExporterImage should have comment or be unexported (golint)
    • Line 72: warning: exported method OperatorOptions.WatchNamespace should have comment or be unexported (golint)
    • Line 79: warning: exported function NewOperatorOptions should have comment or be unexported (golint)
    • Line 103: warning: exported method OperatorOptions.AddGoFlags should have comment or be unexported (golint)
    • Line 129: warning: exported method OperatorOptions.AddFlags should have comment or be unexported (golint)
    • Line 135: warning: exported method OperatorOptions.ApplyTo should have comment or be unexported (golint)
    • Line 189: warning: exported method OperatorOptions.Validate should have comment or be unexported (golint)
    • voyager/pkg/operator/daemonsets.go
    • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/pkg/operator/servicemonitors.go
    • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 88: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/apis/voyager/v1beta1/register.go
    • Line 27: warning: exported var SchemeGroupVersion should have comment or be unexported (golint)
    • Line 30: warning: comment on exported var SchemeBuilder should be of the form "SchemeBuilder ..." (golint)
    • Line 34: warning: exported var AddToScheme should have comment or be unexported (golint)
    • voyager/test/framework/util.go
    • Line 30: warning: exported method Framework.ServerSANs should have comment or be unexported (golint)
    • Line 38: warning: exported var ClientOrgs should have comment or be unexported (golint)
    • voyager/pkg/haproxy/api/types.go
    • Line 28: warning: exported type TemplateData should have comment or be unexported (golint)
    • Line 40: warning: exported method TemplateData.UsesTLSAuth should have comment or be unexported (golint)
    • Line 54: warning: exported type TimeoutConfig should have comment or be unexported (golint)
    • Line 59: warning: exported type OptionConfig should have comment or be unexported (golint)
    • Line 64: warning: exported type ErrorFile should have comment or be unexported (golint)
    • Line 70: warning: exported type SharedInfo should have comment or be unexported (golint)
    • Line 87: warning: exported type CORSConfig should have comment or be unexported (golint)
    • Line 95: warning: exported type StatsInfo should have comment or be unexported (golint)
    • Line 101: warning: exported type HTTPService should have comment or be unexported (golint)
    • Line 118: warning: exported method HTTPService.RedirectSSL should have comment or be unexported (golint)
    • Line 129: warning: exported method HTTPService.RemoveBackendAuth should have comment or be unexported (golint)
    • Line 146: warning: exported type HTTPHost should have comment or be unexported (golint)
    • Line 152: warning: exported type HTTPPath should have comment or be unexported (golint)
    • Line 159: warning: exported type TCPService should have comment or be unexported (golint)
    • Line 177: warning: exported type TCPHost should have comment or be unexported (golint)
    • Line 182: warning: exported type Backend should have comment or be unexported (golint)
    • Line 204: warning: exported type ExternalAuth should have comment or be unexported (golint)
    • Line 223: warning: exported type Endpoint should have comment or be unexported (golint)
    • Line 240: warning: exported type UserList should have comment or be unexported (golint)
    • Line 249: warning: exported type BasicAuth should have comment or be unexported (golint)
    • Line 258: warning: exported type AuthUser should have comment or be unexported (golint)
    • Line 264: warning: exported type Limit should have comment or be unexported (golint)
    • Line 270: warning: exported type TLSHeader should have comment or be unexported (golint)
    • Line 275: warning: exported type TLSAuth should have comment or be unexported (golint)
    • voyager/pkg/ingress/loadbalancer.go
    • Line 33: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 65: warning: exported function NewLoadBalancerController should have comment or be unexported (golint)
    • voyager/pkg/admission/plugin/admission.go
    • Line 32: warning: exported type CRDValidator should have comment or be unexported (golint)
    • Line 38: warning: exported method CRDValidator.Resource should have comment or be unexported (golint)
    • Line 47: warning: exported method CRDValidator.Admit should have comment or be unexported (golint)
    • Line 96: warning: exported method CRDValidator.Initialize should have comment or be unexported (golint)
    • voyager/pkg/operator/secret.go
    • Line 23: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 76: warning: exported method Operator.IngressServiceUsesAuthSecret should have comment or be unexported (golint)
    • voyager/apis/voyager/v1beta1/constants.go
    • Line 20: warning: exported const ProviderMinikube should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported const MatchAll should have comment (or a comment on this block) or be unexported (golint)
    • voyager/pkg/ingress/nodeport.go
    • Line 32: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 65: warning: exported function NewNodePortController should have comment or be unexported (golint)
    • voyager/pkg/eventer/recorder.go
    • Line 35: warning: comment on exported const EventReasonIngressConfigMapReconcileFailed should be of the form "EventReasonIngressConfigMapReconcileFailed ..." (golint)
    • Line 37: warning: exported const EventReasonIngressConfigMapReconcileSuccessful should have comment (or a comment on this block) or be unexported (golint)
    • Line 58: warning: exported function NewEventRecorder should have comment or be unexported (golint)
    • Line 72: warning: exported function CreateEvent should have comment or be unexported (golint)
    • Line 96: warning: exported function CreateEventWithLog should have comment or be unexported (golint)
    • voyager/apis/voyager/v1beta1/dns_resolver.go
    • Line 28: warning: comment on exported const UseDNSResolver should be of the form "UseDNSResolver ..." (golint)
    • Line 42: warning: exported const DNSResolverNameservers should have comment (or a comment on this block) or be unexported (golint)
    • Line 50: warning: exported var DNSResolverHoldKeys should have comment or be unexported (golint)
    • Line 54: warning: exported type DNSResolver should have comment or be unexported (golint)
    • Line 63: warning: exported function DNSResolverForService should have comment or be unexported (golint)
    • voyager/test/test-server/server.go
    • Line 39: warning: exported const LOADMAX should have comment or be unexported (golint)
    • Line 41: warning: exported type Response should have comment or be unexported (golint)
    • Line 53: warning: exported type HTTPHandler should have comment or be unexported (golint)
    • Line 80: warning: exported type HTTPSHandler should have comment or be unexported (golint)
    • Line 110: warning: exported type TCPServer should have comment or be unexported (golint)
    • Line 115: warning: exported type TCPHandler should have comment or be unexported (golint)
    • Line 123: warning: exported method TCPHandler.ServeTCP should have comment or be unexported (golint)
    • Line 133: warning: exported type ProxyAwareHandler should have comment or be unexported (golint)
    • Line 141: warning: exported method ProxyAwareHandler.ServeTCP should have comment or be unexported (golint)
    • voyager/test/framework/framework.go
    • Line 27: warning: should not use dot imports (golint)
    • Line 38: warning: exported const MaxRetry should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported type Framework should have comment or be unexported (golint)
    • Line 56: warning: exported type Invocation should have comment or be unexported (golint)
    • Line 75: warning: exported function New should have comment or be unexported (golint)
    • Line 93: warning: exported method Framework.Invoke should have comment or be unexported (golint)
    • Line 105: warning: exported method Framework.MinikubeIP should have comment or be unexported (golint)
    • voyager/pkg/cmds/root.go
    • Line 31: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 37: warning: exported function NewCmdVoyager should have comment or be unexported (golint)
    • voyager/pkg/operator/namespaces.go
    • Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/pkg/operator/services.go
    • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/test/framework/namespaces.go
    • Line 27: warning: exported method Framework.Namespace should have comment or be unexported (golint)
    • Line 31: warning: exported method Framework.EnsureNamespace should have comment or be unexported (golint)
    • Line 46: warning: exported method Framework.DeleteNamespace should have comment or be unexported (golint)
    • voyager/client/clientset/versioned/typed/voyager/v1beta1/util/ingress.go
    • Line 36: warning: exported function CreateOrPatchIngress should have comment or be unexported (golint)
    • Line 57: warning: exported function PatchIngress should have comment or be unexported (golint)
    • Line 61: warning: exported function PatchIngressObject should have comment or be unexported (golint)
    • Line 84: warning: exported function TryUpdateIngress should have comment or be unexported (golint)
    • Line 105: warning: exported function UpdateIngressStatus should have comment or be unexported (golint)
    • voyager/pkg/haproxy/template/template.go
    • Line 30: warning: comment on exported function ACLName should be of the form "ACLName ..." (golint)
    • Line 46: warning: exported function HeaderName should have comment or be unexported (golint)
    • Line 58: warning: exported function HostACLs should have comment or be unexported (golint)
    • Line 96: warning: exported function SNIMatcher should have comment or be unexported (golint)
    • Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 110: warning: exported function BackendHash should have comment or be unexported (golint)
    • Line 135: warning: exported function LoadTemplates should have comment or be unexported (golint)
    • voyager/pkg/cmds/server/start.go
    • Line 37: warning: exported type VoyagerOptions should have comment or be unexported (golint)
    • Line 45: warning: exported function NewVoyagerOptions should have comment or be unexported (golint)
    • Line 62: warning: exported method VoyagerOptions.AddFlags should have comment or be unexported (golint)
    • Line 67: warning: exported method VoyagerOptions.Validate should have comment or be unexported (golint)
    • Line 71: warning: exported method VoyagerOptions.Complete should have comment or be unexported (golint)
    • Line 75: warning: exported method VoyagerOptions.Config should have comment or be unexported (golint)
    • Line 100: warning: exported method VoyagerOptions.Run should have comment or be unexported (golint)
    • voyager/test/test-server/client/http.go
    • Line 46: warning: exported type Response should have comment or be unexported (golint)
    • Line 67: warning: exported function NewTestHTTPClient should have comment or be unexported (golint)
    • Line 75: warning: exported function NewTestHTTPClientWithTimeout should have comment or be unexported (golint)
    • voyager/pkg/ingress/parser.go
    • Line 17: warning: package comment should be of the form "Package ingress ..." (golint)
    • Line 36: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 262: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 804: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/pkg/operator/deployments.go
    • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/apis/voyager/v1beta1/validator.go
    • Line 38: warning: comment on exported type Paths should be of the form "Paths ..." (with optional leading article) (golint)
    • Line 58: warning: exported method Ingress.Migrate should have comment or be unexported (golint)
    • Line 71: warning: exported method Ingress.IsValid should have comment or be unexported (golint)
    • Line 153: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 186: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 250: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 257: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 293: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 366: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 391: warning: exported method Ingress.SupportsLBType should have comment or be unexported (golint)
    • Line 426: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • voyager/test/framework/ingress_util.go
    • Line 30: warning: should not use dot imports (golint)
    • Line 378: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1298: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1317: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • voyager/pkg/ingress/internal.go
    • Line 30: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 60: warning: exported function NewInternalController should have comment or be unexported (golint)
    • voyager/pkg/operator/configmaps.go
    • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • voyager/apis/voyager/v1beta1/annotations.go
    • Line 35: warning: exported const EngressKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: comment on exported const StatsOn should be of the form "StatsOn ..." (golint)
    • Line 59: warning: comment on exported const LoadBalancerIP should be of the form "LoadBalancerIP ..." (golint)
    • Line 67: warning: comment on exported const ServiceAnnotations should be of the form "ServiceAnnotations ..." (golint)
    • Line 79: warning: comment on exported const KeepSourceIP should be of the form "KeepSourceIP ..." (golint)
    • Line 101: warning: comment on exported const HealthCheckNodeport should be of the form "HealthCheckNodeport ..." (golint)
    • Line 104: warning: comment on exported const AcceptProxy should be of the form "AcceptProxy ..." (golint)
    • Line 107: warning: comment on exported const SendProxy should be of the form "SendProxy ..." (golint)
    • Line 111: warning: comment on exported const OriginAPISchema should be of the form "OriginAPISchema ..." (golint)
    • Line 115: warning: comment on exported const DefaultsTimeOut should be of the form "DefaultsTimeOut ..." (golint)
    • Line 130: warning: comment on exported const HardStopAfter should be of the form "HardStopAfter ..." (golint)
    • Line 135: warning: comment on exported const DefaultsOption should be of the form "DefaultsOption ..." (golint)
    • Line 149: warning: comment on exported const BackendTLSOptions should be of the form "BackendTLSOptions ..." (golint)
    • Line 175: warning: comment on exported const IngressAffinity should be of the form "IngressAffinity ..." (golint)
    • Line 182: warning: comment on exported const IngressAffinitySessionCookieName should be of the form "IngressAffinitySessionCookieName ..." (golint)
    • Line 184: warning: comment on exported const IngressAffinitySessionCookieHash should be of the form "IngressAffinitySessionCookieHash ..." (golint)
    • Line 187: warning: comment on exported const AuthType should be of the form "AuthType ..." (golint)
    • Line 199: warning: comment on exported const AuthRealm should be of the form "AuthRealm ..." (golint)
    • Line 202: warning: comment on exported const AuthSecret should be of the form "AuthSecret ..." (golint)
    • Line 205: warning: comment on exported const AuthTLSSecret should be of the form "AuthTLSSecret ..." (golint)
    • Line 208: warning: comment on exported const AuthTLSErrorPage should be of the form "AuthTLSErrorPage ..." (golint)
    • Line 211: warning: comment on exported const AuthTLSVerifyClient should be of the form "AuthTLSVerifyClient ..." (golint)
    • Line 214: warning: comment on exported const CORSEnabled should be of the form "CORSEnabled ..." (golint)
    • Line 225: warning: comment on exported const ProxyBodySize should be of the form "ProxyBodySize ..." (golint)
    • Line 231: warning: comment on exported const SSLPassthrough should be of the form "SSLPassthrough ..." (golint)
    • Line 235: warning: comment on exported const HSTSMaxAge should be of the form "HSTSMaxAge ..." (golint)
    • Line 239: warning: comment on exported const HSTSIncludeSubDomains should be of the form "HSTSIncludeSubDomains ..." (golint)
    • Line 245: warning: comment on exported const UseNodePort should be of the form "UseNodePort ..." (golint)
    • Line 250: warning: comment on exported const ErrorFiles should be of the form "ErrorFiles ..." (golint)
    • Line 253: warning: comment on exported const LimitRPS should be of the form "LimitRPS ..." (golint)
    • Line 259: warning: comment on exported const LimitRPM should be of the form "LimitRPM ..." (golint)
    • Line 262: warning: comment on exported const LimitConnection should be of the form "LimitConnection ..." (golint)
    • Line 266: warning: comment on exported const CheckHealth should be of the form "CheckHealth ..." (golint)
    • Line 271: warning: comment on exported const RewriteTarget should be of the form "RewriteTarget ..." (golint)
    • Line 274: warning: comment on exported const WorkloadKind should be of the form "WorkloadKind ..." (golint)
    • Line 277: warning: comment on exported const NodeSelector should be of the form "NodeSelector ..." (golint)
    • Line 281: warning: comment on exported const AgentPort should be of the form "AgentPort ..." (golint)
    • Line 344: warning: exported const ACMEUserEmail should have comment (or a comment on this block) or be unexported (golint)
    • Line 350: warning: exported type ProxyProtocolVersion should have comment or be unexported (golint)
    • Line 359: warning: exported function ProxyProtocolCommand should have comment or be unexported (golint)
    • Line 370: warning: exported method Ingress.OffshootName should have comment or be unexported (golint)
    • Line 374: warning: exported method Ingress.OffshootSelector should have comment or be unexported (golint)
    • Line 387: warning: exported method Ingress.OffshootLabels should have comment or be unexported (golint)
    • Line 397: warning: exported method Ingress.StatsLabels should have comment or be unexported (golint)
    • Line 403: warning: exported method Ingress.APISchema should have comment or be unexported (golint)
    • Line 410: warning: exported method Ingress.Sticky should have comment or be unexported (golint)
    • Line 417: warning: exported method Ingress.StickySessionCookieName should have comment or be unexported (golint)
    • Line 425: warning: exported method Ingress.StickySessionCookieHashType should have comment or be unexported (golint)
    • Line 431: warning: comment on exported const CORSDefaultAllowedMethods should be of the form "CORSDefaultAllowedMethods ..." (golint)
    • Line 433: warning: exported const CORSDefaultAllowedHeaders should have comment (or a comment on this block) or be unexported (golint)
    • Line 436: warning: exported method Ingress.EnableCORS should have comment or be unexported (golint)
    • Line 441: warning: exported method Ingress.AllowedCORSOrigin should have comment or be unexported (golint)
    • Line 448: warning: exported method Ingress.AllowedCORSMethods should have comment or be unexported (golint)
    • Line 455: warning: exported method Ingress.AllowedCORSHeaders should have comment or be unexported (golint)
    • Line 462: warning: exported method Ingress.AllowCORSCred should have comment or be unexported (golint)
    • Line 469: warning: exported method Ingress.UseNodePort should have comment or be unexported (golint)
    • Line 477: warning: exported method Ingress.EnableHSTS should have comment or be unexported (golint)
    • Line 484: warning: exported method Ingress.HSTSMaxAge should have comment or be unexported (golint)
    • Line 495: warning: exported method Ingress.HSTSPreload should have comment or be unexported (golint)
    • Line 500: warning: exported method Ingress.HSTSIncludeSubDomains should have comment or be unexported (golint)
    • Line 505: warning: exported method Ingress.WhitelistSourceRange should have comment or be unexported (golint)
    • Line 510: warning: exported method Ingress.MaxConnections should have comment or be unexported (golint)
    • Line 515: warning: exported method Ingress.SSLRedirect should have comment or be unexported (golint)
    • Line 522: warning: exported method Ingress.ForceSSLRedirect should have comment or be unexported (golint)
    • Line 527: warning: exported method Ingress.ProxyBodySize should have comment or be unexported (golint)
    • Line 532: warning: exported method Ingress.SSLPassthrough should have comment or be unexported (golint)
    • Line 537: warning: exported method Ingress.Stats should have comment or be unexported (golint)
    • Line 542: warning: exported method Ingress.StatsSecretName should have comment or be unexported (golint)
    • Line 547: warning: exported method Ingress.StatsPort should have comment or be unexported (golint)
    • Line 554: warning: exported method Ingress.StatsServiceName should have comment or be unexported (golint)
    • Line 561: warning: exported method Ingress.LBType should have comment or be unexported (golint)
    • Line 568: warning: exported method Ingress.Replicas should have comment or be unexported (golint)
    • Line 575: warning: exported method Ingress.LoadBalancerIP should have comment or be unexported (golint)
    • Line 582: warning: exported method Ingress.ServiceAnnotations should have comment or be unexported (golint)
    • Line 603: warning: exported method Ingress.PodsAnnotations should have comment or be unexported (golint)
    • Line 617: warning: exported method Ingress.KeepSourceIP should have comment or be unexported (golint)
    • Line 622: warning: exported method Ingress.HealthCheckNodeport should have comment or be unexported (golint)
    • Line 627: warning: exported method Ingress.AcceptProxy should have comment or be unexported (golint)
    • Line 632: warning: exported method Ingress.WorkloadKind should have comment or be unexported (golint)
    • Line 706: warning: exported method Ingress.Timeouts should have comment or be unexported (golint)
    • Line 723: warning: exported method Ingress.HAProxyOptions should have comment or be unexported (golint)
    • Line 748: warning: exported method Ingress.BasicAuthEnabled should have comment or be unexported (golint)
    • Line 759: warning: exported method Ingress.RewriteTarget should have comment or be unexported (golint)
    • Line 764: warning: exported method Ingress.AuthRealm should have comment or be unexported (golint)
    • Line 769: warning: exported method Ingress.AuthSecretName should have comment or be unexported (golint)
    • Line 774: warning: exported method Ingress.AuthTLSSecret should have comment or be unexported (golint)
    • Line 779: warning: exported method Ingress.AuthTLSVerifyClient should have comment or be unexported (golint)
    • Line 786: warning: exported method Ingress.AuthTLSErrorPage should have comment or be unexported (golint)
    • Line 791: warning: exported method Ingress.ErrorFilesConfigMapName should have comment or be unexported (golint)
    • Line 796: warning: exported method Ingress.LimitRPS should have comment or be unexported (golint)
    • Line 801: warning: exported method Ingress.LimitRPM should have comment or be unexported (golint)
    • Line 806: warning: exported method Ingress.LimitConnections should have comment or be unexported (golint)
    • Line 811: warning: exported method Ingress.HardStopAfter should have comment or be unexported (golint)
    • voyager/pkg/ingress/hostport.go
    • Line 31: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 64: warning: exported function NewHostPortController should have comment or be unexported (golint)

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!