Report for github.com/athos/trenchman
A Great! Found 10 issues across 13 files
gofmt84%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
trenchman/trenchman/nrepl/nrepl.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
trenchman/cmd/trench/main.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo84%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
trenchman/trenchman/prepl/exception.go
- Line 36: warning: cyclomatic complexity 26 of function exTriage() is high (> 15) (gocyclo)
- Line 162: warning: cyclomatic complexity 20 of function exString() is high (> 15) (gocyclo)
-
-
trenchman/cmd/trench/main.go
- Line 109: warning: cyclomatic complexity 19 of function main() is high (> 15) (gocyclo)
golint23%
Golint is a linter for Go source code.
-
-
trenchman/trenchman/prepl/exception.go
- Line 12: warning: exported type Exception should have comment or be unexported (golint)
- Line 18: warning: exported type ViaEntry should have comment or be unexported (golint)
- Line 24: warning: exported type TriageData should have comment or be unexported (golint)
-
-
trenchman/trenchman/nrepl/client.go
- Line 15: warning: exported type Client should have comment or be unexported (golint)
- Line 27: warning: exported type Opts should have comment or be unexported (golint)
- Line 35: warning: exported function NewClient should have comment or be unexported (golint)
- Line 58: warning: exported method Client.Close should have comment or be unexported (golint)
- Line 66: warning: exported method Client.CurrentNS should have comment or be unexported (golint)
- Line 70: warning: exported method Client.SupportsOp should have comment or be unexported (golint)
- Line 97: warning: exported method Client.HandleResp should have comment or be unexported (golint)
- Line 128: warning: exported method Client.HandleErr should have comment or be unexported (golint)
- Line 175: warning: exported method Client.Eval should have comment or be unexported (golint)
- Line 186: warning: exported method Client.Load should have comment or be unexported (golint)
- Line 209: warning: exported method Client.Stdin should have comment or be unexported (golint)
- Line 226: warning: exported method Client.Interrupt should have comment or be unexported (golint)
-
-
trenchman/trenchman/nrepl/nrepl.go
- Line 13: warning: exported type Request should have comment or be unexported (golint)
- Line 14: warning: exported type Response should have comment or be unexported (golint)
- Line 16: warning: exported type Handler should have comment or be unexported (golint)
- Line 17: warning: exported type ErrHandler should have comment or be unexported (golint)
- Line 19: warning: exported type Conn should have comment or be unexported (golint)
- Line 25: warning: exported type SessionInfo should have comment or be unexported (golint)
- Line 31: warning: exported function Connect should have comment or be unexported (golint)
- Line 43: warning: exported method Conn.Send should have comment or be unexported (golint)
- Line 47: warning: exported method Conn.Recv should have comment or be unexported (golint)
- Line 86: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
- Line 96: warning: exported method Conn.Close should have comment or be unexported (golint)
-
-
trenchman/cmd/trench/main.go
- Line 21: warning: exported const COLOR_NONE should have comment (or a comment on this block) or be unexported (golint)
-
-
trenchman/trenchman/bencode/decode.go
- Line 9: warning: exported type Datum should have comment or be unexported (golint)
- Line 11: warning: exported type Decoder should have comment or be unexported (golint)
- Line 15: warning: exported function NewDecoder should have comment or be unexported (golint)
- Line 36: warning: exported method Decoder.Decode should have comment or be unexported (golint)
- Line 151: warning: exported function Decode should have comment or be unexported (golint)
-
-
trenchman/trenchman/bencode/encode.go
- Line 10: warning: exported type Encoder should have comment or be unexported (golint)
- Line 14: warning: exported function NewEncoder should have comment or be unexported (golint)
- Line 66: warning: exported method Encoder.Encode should have comment or be unexported (golint)
- Line 73: warning: exported function Encode should have comment or be unexported (golint)
-
-
trenchman/trenchman/repl/printer.go
- Line 10: warning: exported type Printer should have comment or be unexported (golint)
- Line 17: warning: exported type MonochromePrinter should have comment or be unexported (golint)
- Line 19: warning: exported function NewMonochromePrinter should have comment or be unexported (golint)
- Line 23: warning: exported method MonochromePrinter.With should have comment or be unexported (golint)
- Line 27: warning: exported method MonochromePrinter.Fprint should have comment or be unexported (golint)
- Line 31: warning: exported method MonochromePrinter.Fprintln should have comment or be unexported (golint)
- Line 35: warning: exported method MonochromePrinter.Fprintf should have comment or be unexported (golint)
- Line 39: warning: exported type ColorPrinter should have comment or be unexported (golint)
- Line 43: warning: exported function NewColorPrinter should have comment or be unexported (golint)
- Line 47: warning: exported method ColorPrinter.With should have comment or be unexported (golint)
- Line 51: warning: exported function NewPrinter should have comment or be unexported (golint)
- Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
trenchman/trenchman/repl/repl.go
- Line 16: warning: exported type Repl should have comment or be unexported (golint)
- Line 26: warning: exported type Opts should have comment or be unexported (golint)
- Line 34: warning: exported function NewRepl should have comment or be unexported (golint)
- Line 48: warning: exported method Repl.Close should have comment or be unexported (golint)
- Line 55: warning: exported method Repl.SupportsOp should have comment or be unexported (golint)
- Line 59: warning: exported method Repl.Out should have comment or be unexported (golint)
- Line 63: warning: exported method Repl.Err should have comment or be unexported (golint)
- Line 98: warning: exported method Repl.Eval should have comment or be unexported (golint)
- Line 102: warning: exported method Repl.Load should have comment or be unexported (golint)
- Line 120: warning: exported method Repl.Start should have comment or be unexported (golint)
- Line 142: warning: exported method Repl.StartWatchingInterruption should have comment or be unexported (golint)
-
-
trenchman/trenchman/prepl/prepl.go
- Line 14: warning: exported type Response should have comment or be unexported (golint)
- Line 23: warning: exported type Client should have comment or be unexported (golint)
- Line 34: warning: exported type Opts should have comment or be unexported (golint)
- Line 41: warning: exported function NewClient should have comment or be unexported (golint)
- Line 64: warning: exported method Client.Close should have comment or be unexported (golint)
- Line 69: warning: exported method Client.Send should have comment or be unexported (golint)
- Line 76: warning: exported method Client.Recv should have comment or be unexported (golint)
- Line 84: warning: exported method Client.HandleResp should have comment or be unexported (golint)
- Line 115: warning: exported method Client.HandleErr should have comment or be unexported (golint)
- Line 119: warning: exported method Client.CurrentNS should have comment or be unexported (golint)
- Line 126: warning: exported method Client.SupportsOp should have comment or be unexported (golint)
- Line 135: warning: exported method Client.Eval should have comment or be unexported (golint)
- Line 146: warning: exported method Client.Load should have comment or be unexported (golint)
- Line 150: warning: exported method Client.Stdin should have comment or be unexported (golint)
- Line 156: warning: exported method Client.Interrupt should have comment or be unexported (golint)
-
-
trenchman/trenchman/client/client.go
- Line 6: warning: exported type Request should have comment or be unexported (golint)
- Line 7: warning: exported type Response should have comment or be unexported (golint)
- Line 9: warning: exported type Conn should have comment or be unexported (golint)
- Line 15: warning: exported type Handler should have comment or be unexported (golint)
- Line 22: warning: exported type RuntimeError should have comment or be unexported (golint)
- Line 26: warning: exported type Client should have comment or be unexported (golint)
- Line 36: warning: exported type OutputHandler should have comment or be unexported (golint)
- Line 42: warning: exported function NewRuntimeError should have comment or be unexported (golint)
- Line 50: warning: exported function StartLoop should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!