Preparing report...

Report for github.com/aws/aws-controllers-k8s

(v0.0.2)

A+    Excellent!    Found 68 issues across 414 files

Tweet

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint92%

Golint is a linter for Go source code.

    • aws-controllers-k8s/pkg/compare/reporter.go
    • Line 9: warning: exported type DiffItem should have comment or be unexported (golint)
    • Line 17: warning: exported type Reporter should have comment or be unexported (golint)
    • Line 22: warning: exported method Reporter.PushStep should have comment or be unexported (golint)
    • Line 26: warning: exported method Reporter.PopStep should have comment or be unexported (golint)
    • Line 30: warning: exported method Reporter.Report should have comment or be unexported (golint)
    • aws-controllers-k8s/pkg/errors/error.go
    • Line 24: warning: error var NotImplemented should have name of the form ErrFoo (golint)
    • Line 26: warning: error var NotFound should have name of the form ErrFoo (golint)
    • Line 29: warning: error var NilResourceManagerFactory should have name of the form ErrFoo (golint)
    • Line 36: warning: error var AdoptedResourceNotFound should have name of the form ErrFoo (golint)
    • Line 40: warning: error var TemporaryOutOfSync should have name of the form ErrFoo (golint)
    • Line 43: warning: error var Terminal should have name of the form ErrFoo (golint)
    • aws-controllers-k8s/pkg/requeue/requeue.go
    • Line 21: warning: exported const DefaultRequeueAfterDuration should have comment (or a comment on this block) or be unexported (golint)
    • Line 47: warning: comment on exported type RequeueNeeded should be of the form "RequeueNeeded ..." (with optional leading article) (golint)
    • Line 69: warning: comment on exported type RequeueNeededAfter should be of the form "RequeueNeededAfter ..." (with optional leading article) (golint)
    • Line 87: warning: exported method RequeueNeededAfter.Duration should have comment or be unexported (golint)
    • aws-controllers-k8s/pkg/model/op.go
    • Line 23: warning: exported type OpType should have comment or be unexported (golint)
    • Line 26: warning: exported const OpTypeUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 42: warning: exported type OperationMap should have comment or be unexported (golint)
    • Line 104: warning: exported function OpTypeFromString should have comment or be unexported (golint)
    • aws-controllers-k8s/services/apigatewayv2/pkg/resource/api/custom_http_api.go
    • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 58: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 92: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • aws-controllers-k8s/services/apigatewayv2/apis/v1alpha1/zz_generated.deepcopy.go
    • Line 1790: warning: cyclomatic complexity 24 of function (*Integration_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2994: warning: cyclomatic complexity 23 of function (*Stage_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 429: warning: cyclomatic complexity 23 of function (*API_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 1624: warning: cyclomatic complexity 22 of function (*IntegrationSpec).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2674: warning: cyclomatic complexity 22 of function (*Route_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2532: warning: cyclomatic complexity 19 of function (*RouteSpec).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 252: warning: cyclomatic complexity 19 of function (*APISpec).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2845: warning: cyclomatic complexity 18 of function (*StageSpec).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 3324: warning: cyclomatic complexity 16 of function (*VPCLink_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • aws-controllers-k8s/services/dynamodb/pkg/resource/table/sdk.go
    • Line 45: warning: cyclomatic complexity 88 of function (*resourceManager).sdkFind() is high (> 15) (gocyclo)
    • Line 548: warning: cyclomatic complexity 50 of function (*resourceManager).newCreateRequestPayload() is high (> 15) (gocyclo)
    • Line 385: warning: cyclomatic complexity 45 of function (*resourceManager).sdkCreate() is high (> 15) (gocyclo)
    • Line 732: warning: cyclomatic complexity 45 of function (*resourceManager).sdkUpdate() is high (> 15) (gocyclo)
    • Line 898: warning: cyclomatic complexity 17 of function (*resourceManager).newUpdateRequestPayload() is high (> 15) (gocyclo)
    • aws-controllers-k8s/services/elasticache/pkg/resource/replication_group/custom_update_api.go
    • Line 734: warning: cyclomatic complexity 46 of function (*resourceManager).provideUpdatedResource() is high (> 15) (gocyclo)
    • Line 31: warning: cyclomatic complexity 23 of function (*resourceManager).CustomModifyReplicationGroup() is high (> 15) (gocyclo)
    • Line 484: warning: cyclomatic complexity 22 of function (*resourceManager).newUpdateShardConfigurationRequestPayload() is high (> 15) (gocyclo)
    • Line 346: warning: cyclomatic complexity 16 of function (*resourceManager).newIncreaseReplicaCountRequestPayload() is high (> 15) (gocyclo)
    • Line 415: warning: cyclomatic complexity 16 of function (*resourceManager).newDecreaseReplicaCountRequestPayload() is high (> 15) (gocyclo)
    • aws-controllers-k8s/services/elasticache/apis/v1alpha1/zz_generated.deepcopy.go
    • Line 1827: warning: cyclomatic complexity 47 of function (*ReplicationGroupSpec).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2044: warning: cyclomatic complexity 34 of function (*ReplicationGroupStatus).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2195: warning: cyclomatic complexity 32 of function (*ReplicationGroup_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2870: warning: cyclomatic complexity 30 of function (*Snapshot_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2724: warning: cyclomatic complexity 29 of function (*SnapshotStatus).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 73: warning: cyclomatic complexity 23 of function (*CacheCluster).DeepCopyInto() is high (> 15) (gocyclo)
    • aws-controllers-k8s/services/elasticache/pkg/resource/replication_group/sdk.go
    • Line 45: warning: cyclomatic complexity 70 of function (*resourceManager).sdkFind() is high (> 15) (gocyclo)
    • Line 721: warning: cyclomatic complexity 59 of function (*resourceManager).sdkUpdate() is high (> 15) (gocyclo)
    • Line 318: warning: cyclomatic complexity 57 of function (*resourceManager).sdkCreate() is high (> 15) (gocyclo)
    • Line 535: warning: cyclomatic complexity 51 of function (*resourceManager).newCreateRequestPayload() is high (> 15) (gocyclo)
    • Line 946: warning: cyclomatic complexity 17 of function (*resourceManager).newUpdateRequestPayload() is high (> 15) (gocyclo)
    • aws-controllers-k8s/services/sagemaker/apis/v1alpha1/zz_generated.deepcopy.go
    • Line 3646: warning: cyclomatic complexity 50 of function (*TrainingJob_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2667: warning: cyclomatic complexity 29 of function (*ProcessingJob_SDK).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 3425: warning: cyclomatic complexity 27 of function (*TrainingJobSpec).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 2482: warning: cyclomatic complexity 18 of function (*ProcessingJobSpec).DeepCopyInto() is high (> 15) (gocyclo)
    • Line 1235: warning: cyclomatic complexity 16 of function (*HyperParameterTrainingJobDefinition).DeepCopyInto() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!