Preparing report...

Report for github.com/awsctrl/manager

A+    Excellent!    Found 67 issues across 246 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint88%

Golint is a linter for Go source code.

    • manager/apis/route53/v1alpha1/recordsetgroup_types.go
    • Line 42: warning: don't use underscores in Go names; type RecordSetGroup_AliasTarget should be RecordSetGroupAliasTarget (golint)
    • Line 54: warning: don't use underscores in Go names; type RecordSetGroup_GeoLocation should be RecordSetGroupGeoLocation (golint)
    • Line 66: warning: don't use underscores in Go names; type RecordSetGroup_RecordSet should be RecordSetGroupRecordSet (golint)
    • manager/apis/s3/v1alpha1/accesspoint_types.go
    • Line 54: warning: don't use underscores in Go names; type AccessPoint_PublicAccessBlockConfiguration should be AccessPointPublicAccessBlockConfiguration (golint)
    • Line 69: warning: don't use underscores in Go names; type AccessPoint_VpcConfiguration should be AccessPointVpcConfiguration (golint)
    • manager/apis/apigateway/v1alpha1/method_types.go
    • Line 69: warning: don't use underscores in Go names; type Method_Integration should be MethodIntegration (golint)
    • Line 114: warning: don't use underscores in Go names; type Method_IntegrationResponse should be MethodIntegrationResponse (golint)
    • Line 132: warning: don't use underscores in Go names; type Method_MethodResponse should be MethodMethodResponse (golint)
    • manager/apis/route53/v1alpha1/healthcheck_types.go
    • Line 36: warning: don't use underscores in Go names; type HealthCheck_AlarmIdentifier should be HealthCheckAlarmIdentifier (golint)
    • Line 45: warning: don't use underscores in Go names; type HealthCheck_HealthCheckConfig should be HealthCheckHealthCheckConfig (golint)
    • Line 96: warning: don't use underscores in Go names; type HealthCheck_HealthCheckTag should be HealthCheckHealthCheckTag (golint)
    • manager/apis/apigateway/v1alpha1/usageplan_types.go
    • Line 45: warning: don't use underscores in Go names; type UsagePlan_ApiStage should be UsagePlanAPIStage (golint)
    • Line 57: warning: don't use underscores in Go names; type UsagePlan_QuotaSettings should be UsagePlanQuotaSettings (golint)
    • Line 69: warning: don't use underscores in Go names; type UsagePlan_ThrottleSettings should be UsagePlanThrottleSettings (golint)
    • manager/apis/apigateway/v1alpha1/stage_types.go
    • Line 69: warning: don't use underscores in Go names; type Stage_AccessLogSetting should be StageAccessLogSetting (golint)
    • Line 78: warning: don't use underscores in Go names; type Stage_CanarySetting should be StageCanarySetting (golint)
    • Line 93: warning: don't use underscores in Go names; type Stage_MethodSetting should be StageMethodSetting (golint)
    • manager/apis/lambda/v1alpha1/function_types.go
    • Line 75: warning: don't use underscores in Go names; type Function_Code should be FunctionCode (golint)
    • Line 90: warning: don't use underscores in Go names; type Function_DeadLetterConfig should be FunctionDeadLetterConfig (golint)
    • Line 96: warning: don't use underscores in Go names; type Function_Environment should be FunctionEnvironment (golint)
    • Line 102: warning: don't use underscores in Go names; type Function_TracingConfig should be FunctionTracingConfig (golint)
    • Line 108: warning: don't use underscores in Go names; type Function_VpcConfig should be FunctionVpcConfig (golint)
    • manager/apis/apigateway/v1alpha1/deployment_types.go
    • Line 45: warning: don't use underscores in Go names; type Deployment_AccessLogSetting should be DeploymentAccessLogSetting (golint)
    • Line 54: warning: don't use underscores in Go names; type Deployment_CanarySetting should be DeploymentCanarySetting (golint)
    • Line 66: warning: don't use underscores in Go names; type Deployment_DeploymentCanarySettings should be DeploymentDeploymentCanarySettings (golint)
    • Line 78: warning: don't use underscores in Go names; type Deployment_MethodSetting should be DeploymentMethodSetting (golint)
    • Line 111: warning: don't use underscores in Go names; type Deployment_StageDescription should be DeploymentStageDescription (golint)
    • manager/apis/route53/v1alpha1/hostedzone_types.go
    • Line 45: warning: don't use underscores in Go names; type HostedZone_HostedZoneConfig should be HostedZoneHostedZoneConfig (golint)
    • Line 51: warning: don't use underscores in Go names; type HostedZone_HostedZoneTag should be HostedZoneHostedZoneTag (golint)
    • Line 60: warning: don't use underscores in Go names; type HostedZone_QueryLoggingConfig should be HostedZoneQueryLoggingConfig (golint)
    • Line 66: warning: don't use underscores in Go names; type HostedZone_VPC should be HostedZoneVPC (golint)
    • manager/apis/s3/v1alpha1/bucket_types.go
    • Line 81: warning: don't use underscores in Go names; type Bucket_AbortIncompleteMultipartUpload should be BucketAbortIncompleteMultipartUpload (golint)
    • Line 87: warning: don't use underscores in Go names; type Bucket_AccelerateConfiguration should be BucketAccelerateConfiguration (golint)
    • Line 93: warning: don't use underscores in Go names; type Bucket_AccessControlTranslation should be BucketAccessControlTranslation (golint)
    • Line 99: warning: don't use underscores in Go names; type Bucket_AnalyticsConfiguration should be BucketAnalyticsConfiguration (golint)
    • Line 114: warning: don't use underscores in Go names; type Bucket_BucketEncryption should be BucketBucketEncryption (golint)
    • Line 120: warning: don't use underscores in Go names; type Bucket_CorsConfiguration should be BucketCorsConfiguration (golint)
    • Line 126: warning: don't use underscores in Go names; type Bucket_CorsRule should be BucketCorsRule (golint)
    • Line 147: warning: don't use underscores in Go names; type Bucket_DataExport should be BucketDataExport (golint)
    • Line 156: warning: don't use underscores in Go names; type Bucket_DefaultRetention should be BucketDefaultRetention (golint)
    • Line 168: warning: don't use underscores in Go names; type Bucket_Destination should be BucketDestination (golint)
    • Line 183: warning: don't use underscores in Go names; type Bucket_EncryptionConfiguration should be BucketEncryptionConfiguration (golint)
    • Line 189: warning: don't use underscores in Go names; type Bucket_FilterRule should be BucketFilterRule (golint)
    • Line 198: warning: don't use underscores in Go names; type Bucket_InventoryConfiguration should be BucketInventoryConfiguration (golint)
    • Line 222: warning: don't use underscores in Go names; type Bucket_LambdaConfiguration should be BucketLambdaConfiguration (golint)
    • Line 234: warning: don't use underscores in Go names; type Bucket_LifecycleConfiguration should be BucketLifecycleConfiguration (golint)
    • Line 240: warning: don't use underscores in Go names; type Bucket_LoggingConfiguration should be BucketLoggingConfiguration (golint)
    • Line 249: warning: don't use underscores in Go names; type Bucket_MetricsConfiguration should be BucketMetricsConfiguration (golint)
    • Line 261: warning: don't use underscores in Go names; type Bucket_NoncurrentVersionTransition should be BucketNoncurrentVersionTransition (golint)
    • Line 270: warning: don't use underscores in Go names; type Bucket_NotificationConfiguration should be BucketNotificationConfiguration (golint)
    • Line 282: warning: don't use underscores in Go names; type Bucket_NotificationFilter should be BucketNotificationFilter (golint)
    • Line 288: warning: don't use underscores in Go names; type Bucket_ObjectLockConfiguration should be BucketObjectLockConfiguration (golint)
    • Line 297: warning: don't use underscores in Go names; type Bucket_ObjectLockRule should be BucketObjectLockRule (golint)
    • Line 303: warning: don't use underscores in Go names; type Bucket_PublicAccessBlockConfiguration should be BucketPublicAccessBlockConfiguration (golint)
    • Line 318: warning: don't use underscores in Go names; type Bucket_QueueConfiguration should be BucketQueueConfiguration (golint)
    • Line 330: warning: don't use underscores in Go names; type Bucket_RedirectAllRequestsTo should be BucketRedirectAllRequestsTo (golint)
    • Line 339: warning: don't use underscores in Go names; type Bucket_RedirectRule should be BucketRedirectRule (golint)
    • Line 357: warning: don't use underscores in Go names; type Bucket_ReplicationConfiguration should be BucketReplicationConfiguration (golint)
    • Line 366: warning: don't use underscores in Go names; type Bucket_ReplicationDestination should be BucketReplicationDestination (golint)
    • Line 384: warning: don't use underscores in Go names; type Bucket_ReplicationRule should be BucketReplicationRule (golint)
    • Line 402: warning: don't use underscores in Go names; type Bucket_RoutingRule should be BucketRoutingRule (golint)
    • Line 411: warning: don't use underscores in Go names; type Bucket_RoutingRuleCondition should be BucketRoutingRuleCondition (golint)
    • Line 420: warning: don't use underscores in Go names; type Bucket_Rule should be BucketRule (golint)
    • Line 459: warning: don't use underscores in Go names; type Bucket_S3KeyFilter should be BucketS3KeyFilter (golint)
    • Line 465: warning: don't use underscores in Go names; type Bucket_ServerSideEncryptionByDefault should be BucketServerSideEncryptionByDefault (golint)
    • Line 474: warning: don't use underscores in Go names; type Bucket_ServerSideEncryptionRule should be BucketServerSideEncryptionRule (golint)
    • Line 480: warning: don't use underscores in Go names; type Bucket_SourceSelectionCriteria should be BucketSourceSelectionCriteria (golint)
    • Line 486: warning: don't use underscores in Go names; type Bucket_SseKmsEncryptedObjects should be BucketSseKmsEncryptedObjects (golint)
    • Line 492: warning: don't use underscores in Go names; type Bucket_StorageClassAnalysis should be BucketStorageClassAnalysis (golint)
    • Line 498: warning: don't use underscores in Go names; type Bucket_TagFilter should be BucketTagFilter (golint)
    • Line 507: warning: don't use underscores in Go names; type Bucket_TopicConfiguration should be BucketTopicConfiguration (golint)
    • Line 519: warning: don't use underscores in Go names; type Bucket_Transition should be BucketTransition (golint)
    • Line 531: warning: don't use underscores in Go names; type Bucket_VersioningConfiguration should be BucketVersioningConfiguration (golint)
    • Line 537: warning: don't use underscores in Go names; type Bucket_WebsiteConfiguration should be BucketWebsiteConfiguration (golint)
    • manager/apis/lambda/v1alpha1/alias_types.go
    • Line 48: warning: don't use underscores in Go names; type Alias_AliasRoutingConfiguration should be AliasAliasRoutingConfiguration (golint)
    • Line 54: warning: don't use underscores in Go names; type Alias_ProvisionedConcurrencyConfiguration should be AliasProvisionedConcurrencyConfiguration (golint)
    • Line 60: warning: don't use underscores in Go names; type Alias_VersionWeight should be AliasVersionWeight (golint)
    • manager/apis/lambda/v1alpha1/eventinvokeconfig_types.go
    • Line 45: warning: don't use underscores in Go names; type EventInvokeConfig_DestinationConfig should be EventInvokeConfigDestinationConfig (golint)
    • Line 54: warning: don't use underscores in Go names; type EventInvokeConfig_OnFailure should be EventInvokeConfigOnFailure (golint)
    • Line 60: warning: don't use underscores in Go names; type EventInvokeConfig_OnSuccess should be EventInvokeConfigOnSuccess (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign99%

IneffAssign detects ineffectual assignments in Go code.


misspell93%

Misspell Finds commonly misspelled English words