Go Report Card

Preparing report...

Report for github.com/awslabs/amazon-ecr-credential-helper

A+    Excellent!    Found 11 issues across 21 files

Tweet
Last refresh:

Refresh now

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint47%

Golint is a linter for Go source code.

    • amazon-ecr-credential-helper/ecr-login/api/client.go
    • Line 42: warning: exported type Service should have comment or be unexported (golint)
    • Line 45: warning: exported const ServiceECR should have comment (or a comment on this block) or be unexported (golint)
    • Line 105: warning: exported type ECRAPI should have comment or be unexported (golint)
    • Line 109: warning: exported type ECRPublicAPI should have comment or be unexported (golint)
    • amazon-ecr-credential-helper/ecr-login/ecr.go
    • Line 26: warning: error var notImplemented should have name of the form errFoo (golint)
    • Line 28: warning: exported type ECRHelper should have comment or be unexported (golint)
    • Line 35: warning: exported method ECRHelper.Add should have comment or be unexported (golint)
    • Line 40: warning: exported method ECRHelper.Delete should have comment or be unexported (golint)
    • Line 45: warning: exported method ECRHelper.Get should have comment or be unexported (golint)
    • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 74: warning: exported method ECRHelper.List should have comment or be unexported (golint)
    • Line 74: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • amazon-ecr-credential-helper/ecr-login/cache/mocks/cache_mocks.go
    • Line 14: warning: don't use an underscore in package name (golint)
    • Line 20: warning: exported type MockCredentialsCache should have comment or be unexported (golint)
    • Line 30: warning: exported method MockCredentialsCache.Get should have comment or be unexported (golint)
    • Line 34: warning: exported method MockCredentialsCache.GetPublic should have comment or be unexported (golint)
    • Line 38: warning: exported method MockCredentialsCache.Set should have comment or be unexported (golint)
    • Line 42: warning: exported method MockCredentialsCache.List should have comment or be unexported (golint)
    • Line 46: warning: exported method MockCredentialsCache.Clear should have comment or be unexported (golint)
    • amazon-ecr-credential-helper/ecr-login/mocks/ecr_mocks.go
    • Line 14: warning: don't use an underscore in package name (golint)
    • Line 22: warning: exported type MockClientFactory should have comment or be unexported (golint)
    • Line 30: warning: exported method MockClientFactory.NewClient should have comment or be unexported (golint)
    • Line 34: warning: exported method MockClientFactory.NewClientWithOptions should have comment or be unexported (golint)
    • Line 38: warning: exported method MockClientFactory.NewClientFromRegion should have comment or be unexported (golint)
    • Line 42: warning: exported method MockClientFactory.NewClientWithFipsEndpoint should have comment or be unexported (golint)
    • Line 46: warning: exported method MockClientFactory.NewClientWithDefaults should have comment or be unexported (golint)
    • Line 54: warning: exported type MockClient should have comment or be unexported (golint)
    • Line 62: warning: exported method MockClient.GetCredentials should have comment or be unexported (golint)
    • Line 66: warning: exported method MockClient.GetCredentialsByRegistryID should have comment or be unexported (golint)
    • Line 70: warning: exported method MockClient.ListCredentials should have comment or be unexported (golint)
    • amazon-ecr-credential-helper/ecr-login/cache/credentials.go
    • Line 20: warning: exported type CredentialsCache should have comment or be unexported (golint)
    • Line 28: warning: exported type Service should have comment or be unexported (golint)
    • Line 31: warning: exported const ServiceECR should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported type AuthEntry should have comment or be unexported (golint)
    • amazon-ecr-credential-helper/ecr-login/api/mocks/api_mocks.go
    • Line 17: warning: don't use an underscore in package name (golint)
    • Line 24: warning: exported type MockECRAPI should have comment or be unexported (golint)
    • Line 28: warning: exported method MockECRAPI.GetAuthorizationToken should have comment or be unexported (golint)
    • Line 32: warning: exported type MockECRPublicAPI should have comment or be unexported (golint)
    • Line 36: warning: exported method MockECRPublicAPI.GetAuthorizationToken should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!