Report for github.com/b-b3rn4rd/gocfn
A+ Excellent! Found 7 issues across 17 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint58%
Golint is a linter for Go source code.
-
-
gocfn/pkg/writer/writer.go
- Line 9: warning: exported type FormatFunc should have comment or be unexported (golint)
- Line 11: warning: exported type StringWriter should have comment or be unexported (golint)
- Line 16: warning: exported function New should have comment or be unexported (golint)
- Line 27: warning: exported function PlainFormatter should have comment or be unexported (golint)
- Line 31: warning: exported function JSONFormatter should have comment or be unexported (golint)
-
-
gocfn/pkg/uploader/uploader.go
- Line 26: warning: exported type Uploaderiface should have comment or be unexported (golint)
- Line 34: warning: exported type Uploader should have comment or be unexported (golint)
- Line 45: warning: exported type CustomReader should have comment or be unexported (golint)
- Line 55: warning: exported method CustomReader.ReadAt should have comment or be unexported (golint)
- Line 67: warning: exported method CustomReader.Seek should have comment or be unexported (golint)
- Line 71: warning: exported function New should have comment or be unexported (golint)
- Line 85: warning: exported method Uploader.FileChecksum should have comment or be unexported (golint)
- Line 103: warning: exported method Uploader.URLTos3Path should have comment or be unexported (golint)
- Line 113: warning: exported method Uploader.UploadWithDedup should have comment or be unexported (golint)
- Line 186: warning: exported method Uploader.MakeURL should have comment or be unexported (golint)
- Line 204: warning: exported method Uploader.FileExists should have comment or be unexported (golint)
-
-
gocfn/pkg/deployer/deployer.go
- Line 40: warning: exported type Deployeriface should have comment or be unexported (golint)
- Line 48: warning: exported type StackRecord should have comment or be unexported (golint)
- Line 53: warning: exported type ChangeSetRecord should have comment or be unexported (golint)
- Line 60: warning: exported type Deployer should have comment or be unexported (golint)
- Line 66: warning: exported function New should have comment or be unexported (golint)
- Line 214: warning: comment on exported method Deployer.DescribeStackUnsafe should be of the form "DescribeStackUnsafe ..." (golint)
- Line 223: warning: exported method Deployer.WaitForChangeSet should have comment or be unexported (golint)
- Line 252: warning: exported method Deployer.WaitForExecute should have comment or be unexported (golint)
- Line 304: warning: exported method Deployer.ExecuteChangeset should have comment or be unexported (golint)
- Line 320: warning: exported method Deployer.CreateChangeSet should have comment or be unexported (golint)
-
-
gocfn/pkg/packager/packager.go
- Line 36: warning: exported type Packageriface should have comment or be unexported (golint)
- Line 157: warning: exported method Packager.Marshall should have comment or be unexported (golint)
- Line 182: warning: exported method Packager.Open should have comment or be unexported (golint)
-
-
gocfn/pkg/cfn/cfn.go
- Line 17: warning: exported type Params should have comment or be unexported (golint)
- Line 21: warning: exported type Cfn should have comment or be unexported (golint)
- Line 28: warning: exported function Deployer should have comment or be unexported (golint)
- Line 34: warning: exported function Packager should have comment or be unexported (golint)
- Line 40: warning: exported function Streamer should have comment or be unexported (golint)
- Line 46: warning: exported function Logger should have comment or be unexported (golint)
- Line 52: warning: exported function New should have comment or be unexported (golint)
- Line 72: warning: exported function NewWithOptions should have comment or be unexported (golint)
- Line 82: warning: exported method Cfn.Deploy should have comment or be unexported (golint)
- Line 135: warning: exported method Cfn.Package should have comment or be unexported (golint)
-
-
gocfn/pkg/cli/cli.go
- Line 14: warning: exported type CFNParametersValue should have comment or be unexported (golint)
- Line 15: warning: exported type CFNTagsValue should have comment or be unexported (golint)
- Line 42: warning: exported method CFNParametersValue.Set should have comment or be unexported (golint)
- Line 62: warning: exported function CFNParameters should have comment or be unexported (golint)
- Line 68: warning: exported method CFNTagsValue.Set should have comment or be unexported (golint)
- Line 88: warning: exported function CFNTags should have comment or be unexported (golint)
-
-
gocfn/pkg/streamer/streamer.go
- Line 14: warning: exported type StackEvents should have comment or be unexported (golint)
- Line 16: warning: exported type Streamer should have comment or be unexported (golint)
- Line 21: warning: exported type StackEventsRecord should have comment or be unexported (golint)
- Line 26: warning: exported type Streameriface should have comment or be unexported (golint)
- Line 31: warning: exported function New should have comment or be unexported (golint)
- Line 38: warning: exported method Streamer.StartStreaming should have comment or be unexported (golint)
- Line 83: warning: exported method Streamer.DescribeStackEvents should have comment or be unexported (golint)
ineffassign94%
IneffAssign detects ineffectual assignments in Go code.
-
-
gocfn/pkg/uploader/uploader.go
- Line 155: warning: ineffectual assignment to err (ineffassign)