Report for github.com/bbva/qed
A+ Excellent! Found 102 issues across 241 files
gofmt93%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
qed/api/apihttp/apihttp_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/client/client_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/rocksdb/ticker_type.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/hyper/rebuild_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/hyper/tree_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/storage/bplus/bplus_store_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/rocksdb/cow.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/hyper/position.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/history/tree_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/gossip/messages.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/rocksdb/backup.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/balloon.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/storage/rocks/rocksdb_store_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/hyper/insert_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/hyper/search_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
qed/balloon/history/position.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo97%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
qed/log/stdlog.go
- Line 14: warning: cyclomatic complexity 17 of function (*stdLogAdapter).Write() is high (> 15) (gocyclo)
-
-
qed/balloon/hyper/insert_bulk.go
- Line 23: warning: cyclomatic complexity 22 of function pruneToInsertBulk() is high (> 15) (gocyclo)
-
-
qed/balloon/hyper/insert.go
- Line 64: warning: cyclomatic complexity 21 of function pruneToInsert() is high (> 15) (gocyclo)
-
-
qed/client/topology.go
- Line 94: warning: cyclomatic complexity 29 of function (*topology).NextReadEndpoint() is high (> 15) (gocyclo)
-
-
qed/client/retrier.go
- Line 107: warning: cyclomatic complexity 17 of function (*BackoffRequestRetrier).DoReq() is high (> 15) (gocyclo)
-
-
qed/consensus/cluster.go
- Line 132: warning: cyclomatic complexity 20 of function NewRaftNodeWithLogger() is high (> 15) (gocyclo)
golint67%
Golint is a linter for Go source code.
-
-
qed/cmd/agent_publisher.go
- Line 33: warning: exported var QedPublisherInstancesCount should have comment or be unexported (golint)
-
-
qed/testutils/rand/bytes.go
- Line 23: warning: exported function Bytes should have comment or be unexported (golint)
-
-
qed/balloon/hyper/loader.go
- Line 39: warning: exported function NewDefaultBatchLoader should have comment or be unexported (golint)
- Line 48: warning: exported function NewDefaultBatchLoaderWithLogger should have comment or be unexported (golint)
-
-
qed/balloon/hyper/tree.go
- Line 32: warning: exported type HyperTree should have comment or be unexported (golint)
- Line 47: warning: exported function NewHyperTree should have comment or be unexported (golint)
- Line 51: warning: exported function NewHyperTreeWithLogger should have comment or be unexported (golint)
-
-
qed/rocksdb/cow.go
- Line 60: warning: exported type Registry should have comment or be unexported (golint)
- Line 65: warning: exported function NewRegistry should have comment or be unexported (golint)
- Line 71: warning: exported method Registry.Register should have comment or be unexported (golint)
- Line 77: warning: exported method Registry.Lookup should have comment or be unexported (golint)
- Line 83: warning: exported method Registry.Unregister should have comment or be unexported (golint)
-
-
qed/gossip/agent.go
- Line 205: warning: comment on exported method Agent.Start should be of the form "Start ..." (golint)
- Line 264: warning: comment on exported method Agent.RegisterProcessor should be of the form "RegisterProcessor ..." (golint)
- Line 273: warning: comment on exported method Agent.DeregisterProcessor should be of the form "DeregisterProcessor ..." (golint)
- Line 281: warning: comment on exported method Agent.RegisterMetrics should be of the form "RegisterMetrics ..." (golint)
- Line 323: warning: comment on exported method Agent.Send should be of the form "Send ..." (golint)
- Line 420: warning: comment on exported method Agent.Shutdown should be of the form "Shutdown ..." (golint)
- Line 463: warning: comment on exported method Agent.Memberlist should be of the form "Memberlist ..." (golint)
- Line 469: warning: comment on exported method Agent.Broadcasts should be of the form "Broadcasts ..." (golint)
- Line 475: warning: comment on exported method Agent.GetAddrPort should be of the form "GetAddrPort ..." (golint)
- Line 481: warning: comment on exported method Agent.State should be of the form "State ..." (golint)
-
-
qed/gossip/cache.go
- Line 19: warning: comment on exported type Cache should be of the form "Cache ..." (with optional leading article) (golint)
-
-
qed/gossip/store.go
- Line 20: warning: exported type SnapshotStore should have comment or be unexported (golint)
- Line 38: warning: comment on exported type RestSnapshotStoreConfig should be of the form "RestSnapshotStoreConfig ..." (with optional leading article) (golint)
- Line 46: warning: exported function NewRestSnapshotStoreFromConfig should have comment or be unexported (golint)
- Line 50: warning: exported function DefaultRestSnapshotStoreConfig should have comment or be unexported (golint)
- Line 58: warning: comment on exported function NewRestSnapshotStore should be of the form "NewRestSnapshotStore ..." (golint)
- Line 80: warning: comment on exported method RestSnapshotStore.PutBatch should be of the form "PutBatch ..." (golint)
- Line 107: warning: exported method RestSnapshotStore.PutSnapshot should have comment or be unexported (golint)
- Line 111: warning: exported method RestSnapshotStore.GetRange should have comment or be unexported (golint)
- Line 115: warning: exported method RestSnapshotStore.GetSnapshot should have comment or be unexported (golint)
- Line 142: warning: exported method RestSnapshotStore.DeleteRange should have comment or be unexported (golint)
- Line 146: warning: exported method RestSnapshotStore.Count should have comment or be unexported (golint)
- Line 173: warning: exported type BPlusTreeStore should have comment or be unexported (golint)
- Line 177: warning: exported type StoreItem should have comment or be unexported (golint)
- Line 181: warning: exported method StoreItem.Less should have comment or be unexported (golint)
- Line 185: warning: exported method BPlusTreeStore.Count should have comment or be unexported (golint)
- Line 189: warning: exported method BPlusTreeStore.PutSnapshot should have comment or be unexported (golint)
- Line 198: warning: exported method BPlusTreeStore.GetRange should have comment or be unexported (golint)
- Line 217: warning: exported method BPlusTreeStore.DeleteRange should have comment or be unexported (golint)
-
-
qed/client/client_test.go
- Line 1159: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
qed/storage/bplus/bplus_store.go
- Line 29: warning: exported type BPlusTreeStore should have comment or be unexported (golint)
- Line 33: warning: exported function NewBPlusTreeStore should have comment or be unexported (golint)
- Line 37: warning: exported method BPlusTreeStore.Mutate should have comment or be unexported (golint)
- Line 45: warning: exported method BPlusTreeStore.GetRange should have comment or be unexported (golint)
- Line 60: warning: exported method BPlusTreeStore.Get should have comment or be unexported (golint)
- Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 73: warning: exported method BPlusTreeStore.GetLast should have comment or be unexported (golint)
- Line 87: warning: exported method BPlusTreeStore.GetAll should have comment or be unexported (golint)
- Line 91: warning: exported method BPlusTreeStore.Close should have comment or be unexported (golint)
- Line 96: warning: exported method BPlusTreeStore.Dump should have comment or be unexported (golint)
- Line 100: warning: exported method BPlusTreeStore.Load should have comment or be unexported (golint)
- Line 104: warning: exported method BPlusTreeStore.Snapshot should have comment or be unexported (golint)
- Line 108: warning: exported method BPlusTreeStore.Backup should have comment or be unexported (golint)
- Line 112: warning: exported method BPlusTreeStore.GetBackupsInfo should have comment or be unexported (golint)
- Line 116: warning: exported method BPlusTreeStore.DeleteBackup should have comment or be unexported (golint)
- Line 120: warning: exported method BPlusTreeStore.RestoreFromBackup should have comment or be unexported (golint)
- Line 124: warning: exported method BPlusTreeStore.RegisterMetrics should have comment or be unexported (golint)
- Line 128: warning: exported type KVItem should have comment or be unexported (golint)
- Line 132: warning: exported method KVItem.Less should have comment or be unexported (golint)
- Line 136: warning: exported type BPlusKVPairReader should have comment or be unexported (golint)
- Line 142: warning: exported function NewBPlusKVPairReader should have comment or be unexported (golint)
- Line 168: warning: exported method BPlusKVPairReader.Close should have comment or be unexported (golint)
-
-
qed/testutils/storage/storage.go
- Line 28: warning: exported function OpenBPlusTreeStore should have comment or be unexported (golint)
- Line 35: warning: exported function OpenRocksDBStore should have comment or be unexported (golint)
-
-
qed/testutils/spec/spec_test.go
- Line 75: warning: don't use underscores in Go names; var tv_power_button should be tvPowerButton (golint)
-
-
qed/consensus/backup.go
- Line 25: warning: comment on exported method RaftNode.CreateBackup should be of the form "CreateBackup ..." (golint)
- Line 48: warning: comment on exported method RaftNode.ListBackups should be of the form "ListBackups ..." (golint)
-
-
qed/gossip/messages.go
- Line 29: warning: exported const MAXMESSAGEID should have comment (or a comment on this block) or be unexported (golint)
- Line 32: warning: exported type MessageType should have comment or be unexported (golint)
- Line 35: warning: exported const BatchMessageType should have comment (or a comment on this block) or be unexported (golint)
- Line 38: warning: comment on exported type Message should be of the form "Message ..." (with optional leading article) (golint)
- Line 57: warning: exported method Message.Encode should have comment or be unexported (golint)
- Line 63: warning: exported method Message.Decode should have comment or be unexported (golint)
-
-
qed/protocol/events.go
- Line 37: warning: comment on exported type EventsBulk should be of the form "EventsBulk ..." (with optional leading article) (golint)
- Line 65: warning: exported method Snapshot.Encode should have comment or be unexported (golint)
- Line 69: warning: exported method Snapshot.Decode should have comment or be unexported (golint)
- Line 81: warning: exported method SignedSnapshot.Encode should have comment or be unexported (golint)
- Line 85: warning: exported method SignedSnapshot.Decode should have comment or be unexported (golint)
- Line 97: warning: exported method BatchSnapshots.Encode should have comment or be unexported (golint)
- Line 101: warning: exported method BatchSnapshots.Decode should have comment or be unexported (golint)
- Line 131: warning: comment on exported function ToMembershipResult should be of the form "ToMembershipResult ..." (golint)
- Line 152: warning: comment on exported function ToBalloonProof should be of the form "ToBalloonProof ..." (golint)
-
-
qed/crypto/tlsutil/tls.go
- Line 1: warning: package comment should be of the form "Package tlsutil ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 81: warning: exported method TLSConfigurator.AppendCAToPool should have comment or be unexported (golint)
-
-
qed/rocksdb/filter_policy.go
- Line 22: warning: exported type FilterPolicy should have comment or be unexported (golint)
-
-
qed/gossip/bus.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 36: warning: comment on exported type Producer should be of the form "Producer ..." (with optional leading article) (golint)
- Line 42: warning: exported type Subscribers should have comment or be unexported (golint)
- Line 44: warning: comment on exported type MessageBus should be of the form "MessageBus ..." (with optional leading article) (golint)
- Line 101: warning: comment on exported type MessageQueue should be of the form "MessageQueue ..." (with optional leading article) (golint)
- Line 118: warning: comment on exported method MessageQueue.Producer should be of the form "Producer ..." (golint)
- Line 129: warning: comment on exported method MessageQueue.Consumer should be of the form "Consumer ..." (golint)
- Line 139: warning: comment on exported method MessageQueue.Cancel should be of the form "Cancel ..." (golint)
-
-
qed/gossip/topology.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 22: warning: comment on exported type Topology should be of the form "Topology ..." (with optional leading article) (golint)
- Line 29: warning: comment on exported function NewTopology should be of the form "NewTopology ..." (golint)
- Line 37: warning: comment on exported method Topology.Update should be of the form "Update ..." (golint)
- Line 52: warning: comment on exported method Topology.Delete should be of the form "Delete ..." (golint)
- Line 62: warning: comment on exported method Topology.Get should be of the form "Get ..." (golint)
- Line 69: warning: comment on exported method Topology.Each should be of the form "Each ..." (golint)
-
-
qed/cmd/agent_monitor.go
- Line 37: warning: exported var QedMonitorInstancesCount should have comment or be unexported (golint)
-
-
qed/client/retrier.go
- Line 54: warning: exported method NoRequestRetrier.DoReq should have comment or be unexported (golint)
- Line 107: warning: exported method BackoffRequestRetrier.DoReq should have comment or be unexported (golint)
-
-
qed/crypto/sign/sign.go
- Line 37: warning: exported type Ed25519Signer should have comment or be unexported (golint)
- Line 87: warning: exported method Ed25519Signer.Sign should have comment or be unexported (golint)
- Line 91: warning: exported method Ed25519Signer.Verify should have comment or be unexported (golint)
-
-
qed/rocksdb/options_read.go
- Line 22: warning: exported type ReadOptions should have comment or be unexported (golint)
-
-
qed/testutils/workload/config.go
- Line 25: warning: exported const WorkloadHelp should have comment or be unexported (golint)
- Line 93: warning: exported type Config should have comment or be unexported (golint)
- Line 111: warning: exported function DefaultConfig should have comment or be unexported (golint)
-
-
qed/consensus/snapshot.go
- Line 126: warning: exported method RaftNode.FetchSnapshot should have comment or be unexported (golint)
-
-
qed/gossip/taskmanager.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 44: warning: comment on exported type TaskFactory should be of the form "TaskFactory ..." (with optional leading article) (golint)
- Line 70: warning: comment on exported type SimpleTasksManagerConfig should be of the form "SimpleTasksManagerConfig ..." (with optional leading article) (golint)
- Line 77: warning: comment on exported function DefaultSimpleTasksManagerConfig should be of the form "DefaultSimpleTasksManagerConfig ..." (golint)
- Line 85: warning: exported function NewSimpleTasksManagerFromConfig should have comment or be unexported (golint)
- Line 89: warning: comment on exported type SimpleTasksManager should be of the form "SimpleTasksManager ..." (with optional leading article) (golint)
- Line 193: warning: exported function NewPrinterFactory should have comment or be unexported (golint)
- Line 201: warning: exported method PrinterFactory.Metrics should have comment or be unexported (golint)
- Line 205: warning: exported method PrinterFactory.New should have comment or be unexported (golint)
-
-
qed/cmd/bug.go
- Line 152: warning: exported type BugConfig should have comment or be unexported (golint)
-
-
qed/cmd/generate.go
- Line 28: warning: exported type GenerateConfig should have comment or be unexported (golint)
- Line 36: warning: exported function GenerateDefaultConfig should have comment or be unexported (golint)
-
-
qed/gossip/peer.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 30: warning: exported const AgentStatusAlive should have comment (or a comment on this block) or be unexported (golint)
- Line 52: warning: comment on exported type Peer should be of the form "Peer ..." (with optional leading article) (golint)
- Line 61: warning: comment on exported method Peer.Node should be of the form "Node ..." (golint)
- Line 71: warning: comment on exported function NewPeer should be of the form "NewPeer ..." (golint)
- Line 85: warning: comment on exported function ParsePeer should be of the form "ParsePeer ..." (golint)
- Line 100: warning: comment on exported type PeerList should be of the form "PeerList ..." (with optional leading article) (golint)
- Line 107: warning: exported function NewPeerList should have comment or be unexported (golint)
- Line 113: warning: comment on exported type Filter should be of the form "Filter ..." (with optional leading article) (golint)
- Line 117: warning: comment on exported method PeerList.Filter should be of the form "Filter ..." (golint)
- Line 131: warning: comment on exported method PeerList.Append should be of the form "Append ..." (golint)
- Line 139: warning: comment on exported method PeerList.Take should be of the form "Take ..." (golint)
- Line 151: warning: comment on exported method PeerList.Exclude should be of the form "Exclude ..." (golint)
- Line 167: warning: comment on exported method PeerList.Shuffle should be of the form "Shuffle ..." (golint)
- Line 175: warning: comment on exported method PeerList.Update should be of the form "Update ..." (golint)
- Line 186: warning: comment on exported method PeerList.Delete should be of the form "Delete ..." (golint)
- Line 198: warning: exported method PeerList.Size should have comment or be unexported (golint)
-
-
qed/testutils/tls/certs.go
- Line 36: warning: exported function CreateKeyPair should have comment or be unexported (golint)
- Line 44: warning: exported function CreateKeyPairPEM should have comment or be unexported (golint)
- Line 60: warning: exported function CreateKeyPairFiles should have comment or be unexported (golint)
- Line 117: warning: exported function SavePEMToFile should have comment or be unexported (golint)
- Line 137: warning: exported function CreateCACertificate should have comment or be unexported (golint)
- Line 184: warning: exported function CreateCertificate should have comment or be unexported (golint)
- Line 255: warning: exported function CreateCsr should have comment or be unexported (golint)
- Line 284: warning: exported function SignCsr should have comment or be unexported (golint)
-
-
qed/balloon/test_util.go
- Line 25: warning: exported function NewFakeQueryProof should have comment or be unexported (golint)
- Line 32: warning: exported function NewFakeMembershipProof should have comment or be unexported (golint)
-
-
qed/storage/store.go
- Line 36: warning: comment on exported const HyperCacheTable should be of the form "HyperCacheTable ..." (golint)
- Line 87: warning: exported var ErrKeyNotFound should have comment or be unexported (golint)
- Line 90: warning: exported type Store should have comment or be unexported (golint)
- Line 99: warning: exported type ManagedStore should have comment or be unexported (golint)
- Line 116: warning: exported type Mutation should have comment or be unexported (golint)
- Line 121: warning: exported function NewMutation should have comment or be unexported (golint)
- Line 129: warning: exported type KVPair should have comment or be unexported (golint)
- Line 133: warning: exported function NewKVPair should have comment or be unexported (golint)
- Line 137: warning: exported type KVPairReader should have comment or be unexported (golint)
- Line 142: warning: exported type KVRange should have comment or be unexported (golint)
- Line 144: warning: exported function NewKVRange should have comment or be unexported (golint)
- Line 148: warning: exported type BackupInfo should have comment or be unexported (golint)
-
-
qed/gossip/delegate.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
-
-
qed/client/error.go
- Line 28: warning: comment on exported var ErrPrimaryDead should be of the form "ErrPrimaryDead ..." (golint)
-
-
qed/balloon/metrics.go
- Line 25: warning: exported var AddTotal should have comment or be unexported (golint)
-
-
qed/metrics/metrics.go
- Line 37: warning: exported type Registerer should have comment or be unexported (golint)
- Line 41: warning: comment on exported type Server should be of the form "Server ..." (with optional leading article) (golint)
- Line 50: warning: comment on exported function NewServer should be of the form "NewServer ..." (golint)
- Line 63: warning: comment on exported method Server.Start should be of the form "Start ..." (golint)
-
-
qed/util/process.go
- Line 10: warning: exported function AwaitTermSignal should have comment or be unexported (golint)
-
-
qed/cmd/restore.go
- Line 31: warning: exported type RestoreConfig should have comment or be unexported (golint)
-
-
qed/balloon/hyper/metrics.go
- Line 27: warning: exported var AddTotal should have comment or be unexported (golint)
-
-
qed/testutils/metrics/metrics.go
- Line 30: warning: exported function StartMetricsServer should have comment or be unexported (golint)
- Line 62: warning: exported function CustomRegister should have comment or be unexported (golint)
-
-
qed/consensus/info.go
- Line 29: warning: exported method RaftNode.FetchNodeInfo should have comment or be unexported (golint)
-
-
qed/gossip/errors.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 20: warning: error var ChTimedOut should have name of the form ErrFoo (golint)
- Line 20: warning: exported var ChTimedOut should have comment or be unexported (golint)
- Line 21: warning: error var NoSubscribersFound should have name of the form ErrFoo (golint)
- Line 21: warning: exported var NoSubscribersFound should have comment or be unexported (golint)
-
-
qed/cmd/backup.go
- Line 28: warning: exported type BackupConfig should have comment or be unexported (golint)
-
-
qed/balloon/history/tree.go
- Line 29: warning: exported type HistoryTree should have comment or be unexported (golint)
- Line 38: warning: exported function NewHistoryTree should have comment or be unexported (golint)
- Line 42: warning: exported function NewHistoryTreeWithLogger should have comment or be unexported (golint)
-
-
qed/storage/rocks/rocksdb_store.go
- Line 1: warning: package comment should be of the form "Package rocks ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 33: warning: exported type RocksDBStore should have comment or be unexported (golint)
- Line 63: warning: exported type Options should have comment or be unexported (golint)
- Line 71: warning: exported function DefaultOptions should have comment or be unexported (golint)
- Line 80: warning: exported function NewRocksDBStore should have comment or be unexported (golint)
- Line 87: warning: exported function NewRocksDBStoreWithOpts should have comment or be unexported (golint)
- Line 340: warning: exported method RocksDBStore.Mutate should have comment or be unexported (golint)
- Line 352: warning: exported method RocksDBStore.Get should have comment or be unexported (golint)
- Line 366: warning: exported method RocksDBStore.GetRange should have comment or be unexported (golint)
- Line 388: warning: exported method RocksDBStore.GetLast should have comment or be unexported (golint)
- Line 409: warning: exported method RocksDBStore.GetAll should have comment or be unexported (golint)
- Line 413: warning: exported method RocksDBStore.Close should have comment or be unexported (golint)
- Line 468: warning: comment on exported method RocksDBStore.RestoreFromLatestBackup should be of the form "RestoreFromLatestBackup ..." (golint)
- Line 479: warning: comment on exported method RocksDBStore.RestoreFromBackup should be of the form "RestoreFromBackup ..." (golint)
- Line 631: warning: exported method RocksDBStore.RegisterMetrics should have comment or be unexported (golint)
- Line 649: warning: exported type RocksDBKVPairReader should have comment or be unexported (golint)
- Line 653: warning: exported function NewRocksDBKVPairReader should have comment or be unexported (golint)
- Line 677: warning: exported method RocksDBKVPairReader.Close should have comment or be unexported (golint)
-
-
qed/server/sender.go
- Line 34: warning: exported var QedSenderInstancesCount should have comment or be unexported (golint)
- Line 48: warning: exported type Sender should have comment or be unexported (golint)
- Line 59: warning: exported function NewSender should have comment or be unexported (golint)
- Line 63: warning: exported function NewSenderWithLogger should have comment or be unexported (golint)
- Line 86: warning: exported method Sender.RegisterMetrics should have comment or be unexported (golint)
- Line 154: warning: exported method Sender.Stop should have comment or be unexported (golint)
-
-
qed/rocksdb/cf_handle.go
- Line 47: warning: exported type ColumnFamilyHandles should have comment or be unexported (golint)
-
-
qed/gossip/meta.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 25: warning: comment on exported type Meta should be of the form "Meta ..." (with optional leading article) (golint)
- Line 30: warning: exported method Meta.Encode should have comment or be unexported (golint)
- Line 39: warning: exported method Meta.Decode should have comment or be unexported (golint)
-
-
qed/gossip/notifier.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 30: warning: comment on exported type Notifier should be of the form "Notifier ..." (with optional leading article) (golint)
- Line 40: warning: comment on exported type SimpleNotifierConfig should be of the form "SimpleNotifierConfig ..." (with optional leading article) (golint)
- Line 49: warning: comment on exported function DefaultSimpleNotifierConfig should be of the form "DefaultSimpleNotifierConfig ..." (golint)
- Line 58: warning: comment on exported function NewSimpleNotifierFromConfig should be of the form "NewSimpleNotifierFromConfig ..." (golint)
- Line 63: warning: comment on exported type SimpleNotifier should be of the form "SimpleNotifier ..." (with optional leading article) (golint)
- Line 76: warning: comment on exported function NewSimpleNotifier should be of the form "NewSimpleNotifier ..." (golint)
- Line 121: warning: comment on exported method SimpleNotifier.Start should be of the form "Start ..." (golint)
- Line 151: warning: comment on exported method SimpleNotifier.Stop should be of the form "Stop ..." (golint)
-
-
qed/balloon/history/metrics.go
- Line 25: warning: exported var AddTotal should have comment or be unexported (golint)
-
-
qed/balloon/hyper/proof.go
- Line 25: warning: exported type AuditPath should have comment or be unexported (golint)
- Line 27: warning: exported method AuditPath.Get should have comment or be unexported (golint)
- Line 32: warning: exported function NewAuditPath should have comment or be unexported (golint)
- Line 36: warning: exported type QueryProof should have comment or be unexported (golint)
- Line 42: warning: exported function NewQueryProof should have comment or be unexported (golint)
-
-
qed/server/config.go
- Line 26: warning: exported type Config should have comment or be unexported (golint)
- Line 103: warning: exported function DefaultConfig should have comment or be unexported (golint)
-
-
qed/consensus/fsm.go
- Line 1: warning: package comment should be of the form "Package consensus ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 37: warning: exported type VersionMetadata should have comment or be unexported (golint)
-
-
qed/protocol/info.go
- Line 19: warning: exported type Scheme should have comment or be unexported (golint)
- Line 22: warning: exported const Http should have comment (or a comment on this block) or be unexported (golint)
-
-
qed/api/mgmthttp/mgmthttp.go
- Line 29: warning: exported type MgmtApi should have comment or be unexported (golint)
- Line 46: warning: exported function ManageBackup should have comment or be unexported (golint)
-
-
qed/api/apihttp/metrics.go
- Line 35: warning: exported var HealthCheckRequest should have comment or be unexported (golint)
- Line 101: warning: exported function RegisterMetrics should have comment or be unexported (golint)
-
-
qed/testutils/spec/spec.go
- Line 28: warning: exported type TestF should have comment or be unexported (golint)
- Line 30: warning: exported type LetF should have comment or be unexported (golint)
- Line 31: warning: exported type ReportF should have comment or be unexported (golint)
- Line 33: warning: exported function New should have comment or be unexported (golint)
- Line 58: warning: exported function Equal should have comment or be unexported (golint)
- Line 65: warning: exported function True should have comment or be unexported (golint)
- Line 72: warning: exported function False should have comment or be unexported (golint)
- Line 79: warning: exported function NoError should have comment or be unexported (golint)
- Line 86: warning: exported function Error should have comment or be unexported (golint)
- Line 108: warning: exported function NotNil should have comment or be unexported (golint)
- Line 115: warning: exported function Retry should have comment or be unexported (golint)
- Line 134: warning: exported function RetryOnFalse should have comment or be unexported (golint)
-
-
qed/testutils/notifierstore/api.go
- Line 42: warning: exported var QedStoreInstancesCount should have comment or be unexported (golint)
- Line 191: warning: exported type Service should have comment or be unexported (golint)
- Line 204: warning: exported function NewService should have comment or be unexported (golint)
- Line 213: warning: exported function NewServiceWithLogger should have comment or be unexported (golint)
- Line 222: warning: exported method Service.Start should have comment or be unexported (golint)
- Line 275: warning: exported method Service.Shutdown should have comment or be unexported (golint)
-
-
qed/util/bytes.go
- Line 23: warning: exported function Uint64AsBytes should have comment or be unexported (golint)
- Line 29: warning: exported function Uint64AsPaddedBytes should have comment or be unexported (golint)
- Line 33: warning: exported function Uint16AsBytes should have comment or be unexported (golint)
- Line 39: warning: exported function Uint16AsPaddedBytes should have comment or be unexported (golint)
- Line 43: warning: exported function AddPaddingToBytes should have comment or be unexported (golint)
- Line 52: warning: exported function BytesAsUint64 should have comment or be unexported (golint)
- Line 56: warning: exported function BytesAsUint16 should have comment or be unexported (golint)
-
-
qed/cmd/agent_auditor.go
- Line 35: warning: exported var QedAuditorInstancesCount should have comment or be unexported (golint)
- Line 192: warning: receiver name i should be consistent with previous receiver name m for membershipFactory (golint)
-
-
qed/client/client.go
- Line 578: warning: comment on exported method HTTPClient.MembershipDigest should be of the form "MembershipDigest ..." (golint)
-
-
qed/client/options.go
- Line 71: warning: exported function SetHttpClient should have comment or be unexported (golint)
- Line 78: warning: exported function SetURLs should have comment or be unexported (golint)
- Line 88: warning: exported function SetSnapshotStoreURL should have comment or be unexported (golint)
- Line 98: warning: exported function SetAttemptToReviveEndpoints should have comment or be unexported (golint)
- Line 105: warning: exported function SetRequestRetrier should have comment or be unexported (golint)
- Line 115: warning: exported function SetAPIKey should have comment or be unexported (golint)
- Line 122: warning: exported function SetReadPreference should have comment or be unexported (golint)
- Line 129: warning: exported function SetMaxRetries should have comment or be unexported (golint)
- Line 136: warning: exported function SetTopologyDiscovery should have comment or be unexported (golint)
- Line 143: warning: exported function SetHealthChecks should have comment or be unexported (golint)
- Line 150: warning: exported function SetHealthCheckTimeout should have comment or be unexported (golint)
- Line 157: warning: exported function SetHealthCheckInterval should have comment or be unexported (golint)
- Line 164: warning: exported function SetHasherFunction should have comment or be unexported (golint)
- Line 174: warning: exported function SetLogger should have comment or be unexported (golint)
-
-
qed/client/test_util.go
- Line 24: warning: exported type RoundTripFunc should have comment or be unexported (golint)
- Line 26: warning: exported method RoundTripFunc.RoundTrip should have comment or be unexported (golint)
-
-
qed/balloon/hyper/tree_test.go
- Line 146: warning: should omit 2nd value from range; this loop is equivalent to `for j := range ...` (golint)
-
-
qed/testutils/workload/workload.go
- Line 51: warning: exported type Workload should have comment or be unexported (golint)
- Line 61: warning: exported type Plan should have comment or be unexported (golint)
- Line 72: warning: exported type Attack should have comment or be unexported (golint)
- Line 83: warning: exported type Task should have comment or be unexported (golint)
- Line 90: warning: exported function NewWorkload should have comment or be unexported (golint)
- Line 97: warning: exported method Workload.Start should have comment or be unexported (golint)
- Line 108: warning: exported method Workload.RunOnce should have comment or be unexported (golint)
- Line 112: warning: exported method Workload.MergeConf should have comment or be unexported (golint)
- Line 118: warning: exported method Workload.Serve should have comment or be unexported (golint)
- Line 193: warning: exported method Workload.Stop should have comment or be unexported (golint)
- Line 254: warning: exported method Attack.Run should have comment or be unexported (golint)
-
-
qed/consensus/cluster.go
- Line 82: warning: exported function DefaultClusteringOptions should have comment or be unexported (golint)
- Line 99: warning: exported type RaftNode should have comment or be unexported (golint)
- Line 128: warning: exported function NewRaftNode should have comment or be unexported (golint)
- Line 132: warning: exported function NewRaftNodeWithLogger should have comment or be unexported (golint)
- Line 347: warning: exported method RaftNode.IsLeader should have comment or be unexported (golint)
-
-
qed/gossip/config.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 25: warning: comment on exported const DefaultBindPort should be of the form "DefaultBindPort ..." (golint)
-
-
qed/balloon/cache/test_util.go
- Line 28: warning: exported type FakeCache should have comment or be unexported (golint)
- Line 33: warning: exported function NewFakeCache should have comment or be unexported (golint)
- Line 40: warning: exported method FakeCache.Get should have comment or be unexported (golint)
- Line 50: warning: exported method FakeCache.Put should have comment or be unexported (golint)
- Line 56: warning: exported method FakeCache.Fill should have comment or be unexported (golint)
- Line 60: warning: exported method FakeCache.Size should have comment or be unexported (golint)
- Line 64: warning: exported method FakeCache.Equal should have comment or be unexported (golint)
- Line 77: warning: exported type FakeKVPairReader should have comment or be unexported (golint)
- Line 82: warning: exported function NewFakeKVPairReader should have comment or be unexported (golint)
- Line 97: warning: exported method FakeKVPairReader.Close should have comment or be unexported (golint)
-
-
qed/api/apihttp/apihttp.go
- Line 35: warning: exported type ClientApi should have comment or be unexported (golint)
- Line 501: warning: exported function InfoShardsHandler should have comment or be unexported (golint)
-
-
qed/server/server.go
- Line 290: warning: exported method Server.RegisterMetrics should have comment or be unexported (golint)
-
-
qed/gossip/options.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 27: warning: exported type AgentOptionF should have comment or be unexported (golint)
- Line 56: warning: exported function SetNodeName should have comment or be unexported (golint)
- Line 63: warning: exported function SetRole should have comment or be unexported (golint)
- Line 70: warning: exported function SetBindAddr should have comment or be unexported (golint)
- Line 77: warning: exported function SetAdvertiseAddr should have comment or be unexported (golint)
- Line 84: warning: exported function SetLeaveOnTerm should have comment or be unexported (golint)
- Line 91: warning: exported function SetStartJoin should have comment or be unexported (golint)
- Line 98: warning: exported function SetEnableCompression should have comment or be unexported (golint)
- Line 105: warning: exported function SetBroadcastTimeout should have comment or be unexported (golint)
- Line 112: warning: exported function SetLeavePropagateDelay should have comment or be unexported (golint)
- Line 119: warning: exported function SetTimeoutQueues should have comment or be unexported (golint)
- Line 126: warning: exported function SetProcessInterval should have comment or be unexported (golint)
- Line 132: warning: exported function SetMetricsServer should have comment or be unexported (golint)
- Line 141: warning: exported function SetTasksManager should have comment or be unexported (golint)
- Line 148: warning: exported function SetQEDClient should have comment or be unexported (golint)
- Line 155: warning: exported function SetSnapshotStore should have comment or be unexported (golint)
- Line 162: warning: exported function SetNotifier should have comment or be unexported (golint)
- Line 169: warning: exported function SetLogger should have comment or be unexported (golint)
- Line 179: warning: comment on exported function SetCache should be of the form "SetCache ..." (golint)
- Line 188: warning: exported function SetProcessors should have comment or be unexported (golint)
-
-
qed/cmd/root.go
- Line 32: warning: exported var Root should have comment or be unexported (golint)
- Line 40: warning: exported var Ctx should have comment or be unexported (golint)
-
-
qed/crypto/hashing/hash.go
- Line 28: warning: exported type Digest should have comment or be unexported (golint)
- Line 30: warning: exported type Hasher should have comment or be unexported (golint)
- Line 40: warning: exported function NewXorHasher should have comment or be unexported (golint)
- Line 64: warning: receiver name s should be consistent with previous receiver name x for XorHasher (golint)
- Line 66: warning: exported type KeyHasher should have comment or be unexported (golint)
- Line 108: warning: exported function NewPearsonHasher should have comment or be unexported (golint)
- Line 119: warning: receiver name p should be consistent with previous receiver name h for PearsonHasher (golint)
- Line 158: warning: receiver name p should be consistent with previous receiver name h for PearsonHasher (golint)
- Line 183: warning: exported function NewFakeXorHasher should have comment or be unexported (golint)
- Line 187: warning: exported function NewFakeSha256Hasher should have comment or be unexported (golint)
- Line 191: warning: exported function NewFakePearsonHasher should have comment or be unexported (golint)
-
-
qed/balloon/history/proof.go
- Line 29: warning: exported type AuditPath should have comment or be unexported (golint)
- Line 31: warning: exported method AuditPath.Get should have comment or be unexported (golint)
- Line 38: warning: exported method AuditPath.Serialize should have comment or be unexported (golint)
- Line 46: warning: exported function ParseAuditPath should have comment or be unexported (golint)
- Line 60: warning: exported type MembershipProof should have comment or be unexported (golint)
- Line 66: warning: exported function NewMembershipProof should have comment or be unexported (golint)
- Line 85: warning: exported type IncrementalProof should have comment or be unexported (golint)
- Line 91: warning: exported function NewIncrementalProof should have comment or be unexported (golint)
- Line 100: warning: exported method IncrementalProof.Verify should have comment or be unexported (golint)
-
-
qed/balloon/cache/cache.go
- Line 25: warning: exported type Cache should have comment or be unexported (golint)
- Line 29: warning: exported type ModifiableCache should have comment or be unexported (golint)
-
-
qed/balloon/balloon.go
- Line 37: warning: exported var BalloonVersionKey should have comment or be unexported (golint)
- Line 53: warning: exported function NewBalloon should have comment or be unexported (golint)
- Line 57: warning: comment on exported function NewBalloonWithLogger should be of the form "NewBalloonWithLogger ..." (golint)
- Line 92: warning: exported type Verifiable should have comment or be unexported (golint)
- Line 161: warning: comment on exported function NewIncrementalProof should be of the form "NewIncrementalProof ..." (golint)
- Line 282: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
- Line 294: warning: comment on exported method Balloon.QueryDigestMembershipConsistency should be of the form "QueryDigestMembershipConsistency ..." (golint)
- Line 344: warning: comment on exported method Balloon.QueryMembershipConsistency should be of the form "QueryMembershipConsistency ..." (golint)
-
-
qed/balloon/hyper/batch.go
- Line 27: warning: exported const DefaultBatchHeight should have comment (or a comment on this block) or be unexported (golint)
-
-
qed/rocksdb/histogram.go
- Line 24: warning: exported type HistogramData should have comment or be unexported (golint)
-
-
qed/gossip/processor.go
- Line 1: warning: package comment should be of the form "Package gossip ..." (golint)
- Line 1: warning: package comment should not have leading space (golint)
- Line 29: warning: comment on exported type Processor should be of the form "Processor ..." (with optional leading article) (golint)
- Line 41: warning: comment on exported type BatchProcessor should be of the form "BatchProcessor ..." (with optional leading article) (golint)
- Line 56: warning: exported function NewBatchProcessor should have comment or be unexported (golint)
- Line 68: warning: should not use basic type string as key in context.WithValue (golint)
- Line 80: warning: exported method BatchProcessor.Stop should have comment or be unexported (golint)
- Line 84: warning: exported method BatchProcessor.Metrics should have comment or be unexported (golint)
- Line 112: warning: exported method BatchProcessor.Subscribe should have comment or be unexported (golint)
- Line 141: warning: should not use basic type string as key in context.WithValue (golint)
ineffassign99%
IneffAssign detects ineffectual assignments in Go code.
-
-
qed/rocksdb/backup_test.go
- Line 500: warning: ineffectual assignment to err (ineffassign)
- Line 515: warning: ineffectual assignment to err (ineffassign)
- Line 534: warning: ineffectual assignment to err (ineffassign)
misspell93%
Misspell Finds commonly misspelled English words
-
-
qed/cmd/generate_certs.go
- Line 49: warning: "sertificates" is a misspelling of "certificates" (misspell)
-
-
qed/cmd/parameters.go
- Line 159: warning: "begining" is a misspelling of "beginning" (misspell)
-
-
qed/gossip/taskmanager.go
- Line 187: warning: "intented" is a misspelling of "intended" (misspell)
-
-
qed/protocol/events.go
- Line 201: warning: "suposed" is a misspelling of "supposed" (misspell)
-
-
qed/testutils/notifierstore/api.go
- Line 282: warning: "ocurred" is a misspelling of "occurred" (misspell)
-
-
qed/balloon/balloon.go
- Line 40: warning: "necesary" is a misspelling of "necessary" (misspell)
-
-
qed/log/logger.go
- Line 169: warning: "supressed" is a misspelling of "suppressed" (misspell)
-
-
qed/gossip/processor.go
- Line 146: warning: "becasue" is a misspelling of "because" (misspell)
-
-
qed/client/retrier.go
- Line 71: warning: "reponse" is a misspelling of "response" (misspell)
- Line 141: warning: "reponse" is a misspelling of "response" (misspell)
-
-
qed/cmd/agent.go
- Line 37: warning: "throught" is a misspelling of "thought" (misspell)
-
-
qed/gossip/messages_test.go
- Line 35: warning: "succesfully" is a misspelling of "successfully" (misspell)
-
-
qed/gossip/peer.go
- Line 117: warning: "containg" is a misspelling of "containing" (misspell)
-
-
qed/consensus/raft_log.go
- Line 93: warning: "diferent" is a misspelling of "different" (misspell)
-
-
qed/gossip/agent.go
- Line 36: warning: "necesary" is a misspelling of "necessary" (misspell)
-
-
qed/gossip/bus.go
- Line 78: warning: "correspondant" is a misspelling of "correspondent" (misspell)
-
-
qed/balloon/cache/lru.go
- Line 27: warning: "asociated" is a misspelling of "associated" (misspell)