Report for github.com/bitleak/go-redis-pool
A+ Excellent! Found 6 issues across 16 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint62%
Golint is a linter for Go source code.
-
-
go-redis-pool/pool.go
- Line 32: warning: exported type ConnFactory should have comment or be unexported (golint)
- Line 146: warning: exported type Pool should have comment or be unexported (golint)
- Line 150: warning: exported function NewHA should have comment or be unexported (golint)
- Line 160: warning: exported function NewShard should have comment or be unexported (golint)
- Line 170: warning: exported method Pool.Close should have comment or be unexported (golint)
- Line 174: warning: exported method Pool.WithMaster should have comment or be unexported (golint)
- Line 178: warning: exported method Pool.Pipeline should have comment or be unexported (golint)
- Line 186: warning: exported method Pool.Pipelined should have comment or be unexported (golint)
- Line 194: warning: exported method Pool.TxPipeline should have comment or be unexported (golint)
- Line 202: warning: exported method Pool.TxPipelined should have comment or be unexported (golint)
- Line 210: warning: exported method Pool.Ping should have comment or be unexported (golint)
- Line 219: warning: exported method Pool.Get should have comment or be unexported (golint)
- Line 227: warning: exported method Pool.Set should have comment or be unexported (golint)
- Line 235: warning: exported method Pool.SetNX should have comment or be unexported (golint)
- Line 243: warning: exported method Pool.SetXX should have comment or be unexported (golint)
- Line 251: warning: exported method Pool.SetRange should have comment or be unexported (golint)
- Line 259: warning: exported method Pool.StrLen should have comment or be unexported (golint)
- Line 267: warning: exported method Pool.Echo should have comment or be unexported (golint)
- Line 275: warning: exported method Pool.Del should have comment or be unexported (golint)
- Line 289: warning: exported method Pool.Unlink should have comment or be unexported (golint)
- Line 303: warning: exported method Pool.Touch should have comment or be unexported (golint)
- Line 317: warning: exported method Pool.MGet should have comment or be unexported (golint)
- Line 448: warning: exported method Pool.Dump should have comment or be unexported (golint)
- Line 456: warning: exported method Pool.Exists should have comment or be unexported (golint)
- Line 473: warning: exported method Pool.Expire should have comment or be unexported (golint)
- Line 481: warning: exported method Pool.ExpireAt should have comment or be unexported (golint)
- Line 489: warning: exported method Pool.TTL should have comment or be unexported (golint)
- Line 497: warning: exported method Pool.ObjectRefCount should have comment or be unexported (golint)
- Line 505: warning: exported method Pool.ObjectEncoding should have comment or be unexported (golint)
- Line 513: warning: exported method Pool.ObjectIdleTime should have comment or be unexported (golint)
- Line 521: warning: exported method Pool.Rename should have comment or be unexported (golint)
- Line 534: warning: exported method Pool.RenameNX should have comment or be unexported (golint)
- Line 549: warning: exported method Pool.Sort should have comment or be unexported (golint)
- Line 557: warning: exported method Pool.SortStore should have comment or be unexported (golint)
- Line 573: warning: exported method Pool.SortInterfaces should have comment or be unexported (golint)
- Line 581: warning: exported method Pool.Eval should have comment or be unexported (golint)
- Line 589: warning: exported method Pool.EvalSha should have comment or be unexported (golint)
- Line 597: warning: exported method Pool.ScriptExists should have comment or be unexported (golint)
- Line 605: warning: exported method Pool.ScriptFlush should have comment or be unexported (golint)
- Line 613: warning: exported method Pool.ScriptKill should have comment or be unexported (golint)
- Line 621: warning: exported method Pool.ScriptLoad should have comment or be unexported (golint)
- Line 629: warning: exported method Pool.DebugObject should have comment or be unexported (golint)
- Line 637: warning: exported method Pool.MemoryUsage should have comment or be unexported (golint)
- Line 645: warning: exported method Pool.Publish should have comment or be unexported (golint)
- Line 653: warning: exported method Pool.PubSubChannels should have comment or be unexported (golint)
- Line 664: warning: exported method Pool.PubSubNumSub should have comment or be unexported (golint)
- Line 675: warning: exported method Pool.PubSubNumPat should have comment or be unexported (golint)
- Line 686: warning: exported method Pool.Type should have comment or be unexported (golint)
- Line 694: warning: exported method Pool.Scan should have comment or be unexported (golint)
- Line 705: warning: exported method Pool.SScan should have comment or be unexported (golint)
- Line 713: warning: exported method Pool.HScan should have comment or be unexported (golint)
- Line 721: warning: exported method Pool.ZScan should have comment or be unexported (golint)
- Line 729: warning: exported method Pool.Append should have comment or be unexported (golint)
- Line 737: warning: exported method Pool.GetRange should have comment or be unexported (golint)
- Line 745: warning: exported method Pool.GetSet should have comment or be unexported (golint)
- Line 753: warning: exported method Pool.BitCount should have comment or be unexported (golint)
- Line 761: warning: exported method Pool.BitPos should have comment or be unexported (golint)
- Line 769: warning: exported method Pool.BitField should have comment or be unexported (golint)
- Line 777: warning: exported method Pool.GetBit should have comment or be unexported (golint)
- Line 785: warning: exported method Pool.SetBit should have comment or be unexported (golint)
- Line 793: warning: exported method Pool.BitOp should have comment or be unexported (golint)
- Line 816: warning: exported method Pool.BitOpAnd should have comment or be unexported (golint)
- Line 820: warning: exported method Pool.BitOpOr should have comment or be unexported (golint)
- Line 824: warning: exported method Pool.BitOpXor should have comment or be unexported (golint)
- Line 828: warning: exported method Pool.BitOpNot should have comment or be unexported (golint)
- Line 841: warning: exported method Pool.Decr should have comment or be unexported (golint)
- Line 845: warning: exported method Pool.Incr should have comment or be unexported (golint)
- Line 849: warning: exported method Pool.IncrBy should have comment or be unexported (golint)
- Line 853: warning: exported method Pool.DecrBy should have comment or be unexported (golint)
- Line 861: warning: exported method Pool.IncrByFloat should have comment or be unexported (golint)
- Line 869: warning: exported method Pool.HSet should have comment or be unexported (golint)
- Line 877: warning: exported method Pool.HDel should have comment or be unexported (golint)
- Line 885: warning: exported method Pool.HExists should have comment or be unexported (golint)
- Line 893: warning: exported method Pool.HGet should have comment or be unexported (golint)
- Line 901: warning: exported method Pool.HGetAll should have comment or be unexported (golint)
- Line 909: warning: exported method Pool.HIncrBy should have comment or be unexported (golint)
- Line 917: warning: exported method Pool.HIncrByFloat should have comment or be unexported (golint)
- Line 925: warning: exported method Pool.HKeys should have comment or be unexported (golint)
- Line 933: warning: exported method Pool.HLen should have comment or be unexported (golint)
- Line 941: warning: exported method Pool.HMGet should have comment or be unexported (golint)
- Line 949: warning: exported method Pool.HMSet should have comment or be unexported (golint)
- Line 957: warning: exported method Pool.HSetNX should have comment or be unexported (golint)
- Line 965: warning: exported method Pool.HVals should have comment or be unexported (golint)
- Line 973: warning: exported method Pool.BLPop should have comment or be unexported (golint)
- Line 986: warning: exported method Pool.BRPop should have comment or be unexported (golint)
- Line 999: warning: exported method Pool.BRPopLPush should have comment or be unexported (golint)
- Line 1012: warning: exported method Pool.LIndex should have comment or be unexported (golint)
- Line 1020: warning: exported method Pool.LInsert should have comment or be unexported (golint)
- Line 1028: warning: exported method Pool.LInsertBefore should have comment or be unexported (golint)
- Line 1032: warning: exported method Pool.LInsertAfter should have comment or be unexported (golint)
- Line 1036: warning: exported method Pool.LLen should have comment or be unexported (golint)
- Line 1044: warning: exported method Pool.LPop should have comment or be unexported (golint)
- Line 1052: warning: exported method Pool.LPush should have comment or be unexported (golint)
- Line 1060: warning: exported method Pool.LPushX should have comment or be unexported (golint)
- Line 1068: warning: exported method Pool.LRange should have comment or be unexported (golint)
- Line 1076: warning: exported method Pool.LRem should have comment or be unexported (golint)
- Line 1084: warning: exported method Pool.LSet should have comment or be unexported (golint)
- Line 1092: warning: exported method Pool.LTrim should have comment or be unexported (golint)
- Line 1100: warning: exported method Pool.RPop should have comment or be unexported (golint)
- Line 1108: warning: exported method Pool.RPopLPush should have comment or be unexported (golint)
- Line 1121: warning: exported method Pool.RPush should have comment or be unexported (golint)
- Line 1129: warning: exported method Pool.RPushX should have comment or be unexported (golint)
- Line 1137: warning: exported method Pool.SAdd should have comment or be unexported (golint)
- Line 1145: warning: exported method Pool.SCard should have comment or be unexported (golint)
- Line 1153: warning: exported method Pool.SDiff should have comment or be unexported (golint)
- Line 1172: warning: exported method Pool.SDiffStore should have comment or be unexported (golint)
- Line 1186: warning: exported method Pool.SInter should have comment or be unexported (golint)
- Line 1205: warning: exported method Pool.SInterStore should have comment or be unexported (golint)
- Line 1218: warning: exported method Pool.SIsMember should have comment or be unexported (golint)
- Line 1226: warning: exported method Pool.SMembers should have comment or be unexported (golint)
- Line 1234: warning: exported method Pool.SMembersMap should have comment or be unexported (golint)
- Line 1242: warning: exported method Pool.SMove should have comment or be unexported (golint)
- Line 1255: warning: exported method Pool.SPop should have comment or be unexported (golint)
- Line 1263: warning: exported method Pool.SPopN should have comment or be unexported (golint)
- Line 1271: warning: exported method Pool.SRandMember should have comment or be unexported (golint)
- Line 1279: warning: exported method Pool.SRandMemberN should have comment or be unexported (golint)
- Line 1287: warning: exported method Pool.SRem should have comment or be unexported (golint)
- Line 1295: warning: exported method Pool.SUnion should have comment or be unexported (golint)
- Line 1314: warning: exported method Pool.SUnionStore should have comment or be unexported (golint)
- Line 1327: warning: exported method Pool.ZAdd should have comment or be unexported (golint)
- Line 1335: warning: exported method Pool.ZAddNX should have comment or be unexported (golint)
- Line 1343: warning: exported method Pool.ZAddXX should have comment or be unexported (golint)
- Line 1351: warning: exported method Pool.ZAddCh should have comment or be unexported (golint)
- Line 1359: warning: exported method Pool.ZAddNXCh should have comment or be unexported (golint)
- Line 1367: warning: exported method Pool.ZAddXXCh should have comment or be unexported (golint)
- Line 1375: warning: exported method Pool.ZIncr should have comment or be unexported (golint)
- Line 1383: warning: exported method Pool.ZIncrNX should have comment or be unexported (golint)
- Line 1391: warning: exported method Pool.ZIncrXX should have comment or be unexported (golint)
- Line 1399: warning: exported method Pool.ZCard should have comment or be unexported (golint)
- Line 1407: warning: exported method Pool.ZCount should have comment or be unexported (golint)
- Line 1415: warning: exported method Pool.ZLexCount should have comment or be unexported (golint)
- Line 1423: warning: exported method Pool.ZIncrBy should have comment or be unexported (golint)
- Line 1431: warning: exported method Pool.ZPopMax should have comment or be unexported (golint)
- Line 1439: warning: exported method Pool.ZPopMin should have comment or be unexported (golint)
- Line 1447: warning: exported method Pool.ZRange should have comment or be unexported (golint)
- Line 1455: warning: exported method Pool.ZRangeWithScores should have comment or be unexported (golint)
- Line 1463: warning: exported method Pool.ZRangeByScore should have comment or be unexported (golint)
- Line 1471: warning: exported method Pool.ZRangeByLex should have comment or be unexported (golint)
- Line 1479: warning: exported method Pool.ZRangeByScoreWithScores should have comment or be unexported (golint)
- Line 1487: warning: exported method Pool.ZRank should have comment or be unexported (golint)
- Line 1495: warning: exported method Pool.ZRem should have comment or be unexported (golint)
- Line 1503: warning: exported method Pool.ZRemRangeByRank should have comment or be unexported (golint)
- Line 1511: warning: exported method Pool.ZRemRangeByScore should have comment or be unexported (golint)
- Line 1519: warning: exported method Pool.ZRemRangeByLex should have comment or be unexported (golint)
- Line 1527: warning: exported method Pool.ZRevRange should have comment or be unexported (golint)
- Line 1535: warning: exported method Pool.ZRevRangeWithScores should have comment or be unexported (golint)
- Line 1543: warning: exported method Pool.ZRevRangeByScore should have comment or be unexported (golint)
- Line 1551: warning: exported method Pool.ZRevRangeByLex should have comment or be unexported (golint)
- Line 1559: warning: exported method Pool.ZRevRangeByScoreWithScores should have comment or be unexported (golint)
- Line 1567: warning: exported method Pool.ZRevRank should have comment or be unexported (golint)
- Line 1575: warning: exported method Pool.ZScore should have comment or be unexported (golint)
- Line 1583: warning: exported method Pool.ZUnionStore should have comment or be unexported (golint)
- Line 1597: warning: exported method Pool.ZInterStore should have comment or be unexported (golint)
- Line 1611: warning: exported method Pool.GeoAdd should have comment or be unexported (golint)
- Line 1619: warning: exported method Pool.GeoPos should have comment or be unexported (golint)
- Line 1627: warning: exported method Pool.GeoRadius should have comment or be unexported (golint)
- Line 1635: warning: exported method Pool.GeoRadiusStore should have comment or be unexported (golint)
- Line 1651: warning: exported method Pool.GeoRadiusByMember should have comment or be unexported (golint)
- Line 1659: warning: exported method Pool.GeoRadiusByMemberStore should have comment or be unexported (golint)
- Line 1675: warning: exported method Pool.GeoDist should have comment or be unexported (golint)
- Line 1683: warning: exported method Pool.GeoHash should have comment or be unexported (golint)
- Line 1691: warning: exported method Pool.PFAdd should have comment or be unexported (golint)
- Line 1699: warning: exported method Pool.PFCount should have comment or be unexported (golint)
- Line 1710: warning: exported method Pool.PFMerge should have comment or be unexported (golint)
-
-
go-redis-pool/shard_conn_factory.go
- Line 24: warning: exported type ShardConfig should have comment or be unexported (golint)
- Line 30: warning: exported type ShardConnFactory should have comment or be unexported (golint)
- Line 36: warning: exported function NewShardConnFactory should have comment or be unexported (golint)
-
-
go-redis-pool/hashkit/fnv.go
- Line 5: warning: exported function Fnv1a64 should have comment or be unexported (golint)
-
-
go-redis-pool/hashkit/hashkit.go
- Line 3: warning: exported type Server should have comment or be unexported (golint)
- Line 9: warning: exported type HashKit should have comment or be unexported (golint)
-
-
go-redis-pool/hashkit/ketama.go
- Line 8: warning: exported const KetamaPointsPerServer should have comment or be unexported (golint)
- Line 15: warning: exported type Continuum should have comment or be unexported (golint)
- Line 26: warning: exported function NewKetama should have comment or be unexported (golint)
- Line 40: warning: exported method Continuum.Dispatch should have comment or be unexported (golint)
- Line 48: warning: exported method Continuum.Rebuild should have comment or be unexported (golint)
-
-
go-redis-pool/ha_conn_factory.go
- Line 23: warning: exported type HAConfig should have comment or be unexported (golint)
- Line 71: warning: exported function NewHAConnFactory should have comment or be unexported (golint)
- Line 238: warning: receiver name p should be consistent with previous receiver name pool for clientPool (golint)
- Line 285: warning: receiver name p should be consistent with previous receiver name pool for clientPool (golint)
- Line 297: warning: receiver name p should be consistent with previous receiver name pool for clientPool (golint)
- Line 328: warning: receiver name p should be consistent with previous receiver name pool for clientPool (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!