Go Report Card

Preparing report...

Report for github.com/bmc-toolbox/bmclib

A+    Excellent!    Found 30 issues across 129 files

Tweet
Last refresh:

Refresh now

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • bmclib/providers/dell/idrac8/idrac8.go
    • Line 734: warning: cyclomatic complexity 34 of function (*IDrac8).ServerSnapshot() is high (> 15) (gocyclo)
    • Line 212: warning: cyclomatic complexity 19 of function (*IDrac8).Nics() is high (> 15) (gocyclo)
    • Line 553: warning: cyclomatic complexity 17 of function (*IDrac8).Disks() is high (> 15) (gocyclo)

golint82%

Golint is a linter for Go source code.

    • bmclib/providers/asrockrack/asrockrack.go
    • Line 100: warning: comment on exported method ASRockRack.GetBIOSVersion should be of the form "GetBIOSVersion ..." (golint)
    • Line 111: warning: comment on exported method ASRockRack.GetBMCVersion should be of the form "GetBMCVersion ..." (golint)
    • Line 122: warning: comment on exported method ASRockRack.FirmwareUpdateBMC should be of the form "FirmwareUpdateBMC ..." (golint)
    • Line 209: warning: exported method ASRockRack.FirmwareUpdateBIOS should have comment or be unexported (golint)
    • bmclib/providers/dell/idrac8/idrac8.go
    • Line 889: warning: comment on exported method IDrac8.GetBIOSVersion should be of the form "GetBIOSVersion ..." (golint)
    • Line 894: warning: comment on exported method IDrac8.GetBMCVersion should be of the form "GetBMCVersion ..." (golint)
    • Line 899: warning: comment on exported method IDrac8.FirmwareUpdateBMC should be of the form "FirmwareUpdateBMC ..." (golint)
    • bmclib/providers/dell/idrac9/idrac.go
    • Line 46: warning: exported method Conn.Name should have comment or be unexported (golint)
    • Line 50: warning: exported method Conn.Open should have comment or be unexported (golint)
    • Line 64: warning: exported method Conn.Close should have comment or be unexported (golint)
    • Line 112: warning: exported method Conn.UserCreate should have comment or be unexported (golint)
    • Line 159: warning: exported method Conn.UserUpdate should have comment or be unexported (golint)
    • Line 201: warning: exported method Conn.UserDelete should have comment or be unexported (golint)
    • Line 234: warning: exported method Conn.UserRead should have comment or be unexported (golint)
    • bmclib/providers/supermicro/supermicrox/supermicrox.go
    • Line 725: warning: comment on exported method SupermicroX.GetBIOSVersion should be of the form "GetBIOSVersion ..." (golint)
    • Line 730: warning: comment on exported method SupermicroX.GetBMCVersion should be of the form "GetBMCVersion ..." (golint)
    • Line 735: warning: comment on exported method SupermicroX.FirmwareUpdateBMC should be of the form "FirmwareUpdateBMC ..." (golint)
    • bmclib/errors/errors.go
    • Line 55: warning: exported type ErrUnsupportedHardware should have comment or be unexported (golint)
    • Line 63: warning: exported function NewErrUnsupportedHardware should have comment or be unexported (golint)
    • bmclib/bmc/firmware.go
    • Line 187: warning: comment on exported function UpdateBIOSFirmwareFromInterfaces should be of the form "UpdateBIOSFirmwareFromInterfaces ..." (golint)
    • bmclib/providers/redfish/redfish.go
    • Line 64: warning: exported method Conn.Name should have comment or be unexported (golint)
    • Line 179: warning: receiver name r should be consistent with previous receiver name c for Conn (golint)
    • Line 197: warning: receiver name r should be consistent with previous receiver name c for Conn (golint)
    • bmclib/providers/dell/idrac9/idrac9.go
    • Line 932: warning: comment on exported method IDrac9.GetBIOSVersion should be of the form "GetBIOSVersion ..." (golint)
    • Line 937: warning: comment on exported method IDrac9.GetBMCVersion should be of the form "GetBMCVersion ..." (golint)
    • Line 942: warning: comment on exported method IDrac9.FirmwareUpdateBMC should be of the form "FirmwareUpdateBMC ..." (golint)
    • bmclib/providers/dummy/dummy.go
    • Line 31: warning: exported type Conn should have comment or be unexported (golint)
    • Line 36: warning: exported method Conn.Name should have comment or be unexported (golint)
    • Line 40: warning: exported method Conn.Open should have comment or be unexported (golint)
    • bmclib/providers/goipmi/goipmi.go
    • Line 30: warning: exported type Conn should have comment or be unexported (golint)
    • Line 40: warning: exported method Conn.Name should have comment or be unexported (golint)
    • Line 44: warning: exported method Conn.Open should have comment or be unexported (golint)
    • Line 68: warning: exported method Conn.Close should have comment or be unexported (golint)
    • Line 99: warning: exported method Conn.PowerSet should have comment or be unexported (golint)
    • bmclib/providers/dummy/ibmc/ibmc.go
    • Line 191: warning: comment on exported method Ibmc.GetBIOSVersion should be of the form "GetBIOSVersion ..." (golint)
    • Line 196: warning: comment on exported method Ibmc.GetBMCVersion should be of the form "GetBMCVersion ..." (golint)
    • Line 201: warning: comment on exported method Ibmc.FirmwareUpdateBMC should be of the form "FirmwareUpdateBMC ..." (golint)
    • bmclib/providers/hp/ilo/ilo.go
    • Line 670: warning: comment on exported method Ilo.IsBlade should be of the form "IsBlade ..." (golint)
    • Line 863: warning: comment on exported method Ilo.GetBIOSVersion should be of the form "GetBIOSVersion ..." (golint)
    • Line 868: warning: comment on exported method Ilo.GetBMCVersion should be of the form "GetBMCVersion ..." (golint)
    • Line 873: warning: comment on exported method Ilo.FirmwareUpdateBMC should be of the form "FirmwareUpdateBMC ..." (golint)
    • bmclib/providers/supermicro/supermicrox11/supermicrox.go
    • Line 728: warning: comment on exported method SupermicroX.GetBIOSVersion should be of the form "GetBIOSVersion ..." (golint)
    • Line 733: warning: comment on exported method SupermicroX.GetBMCVersion should be of the form "GetBMCVersion ..." (golint)
    • Line 738: warning: comment on exported method SupermicroX.FirmwareUpdateBMC should be of the form "FirmwareUpdateBMC ..." (golint)
    • bmclib/providers/hp/hp.go
    • Line 9: warning: exported type Hp should have comment or be unexported (golint)
    • Line 14: warning: exported const ChassisInfoOldURL should have comment (or a comment on this block) or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell99%

Misspell Finds commonly misspelled English words