Report for github.com/brainicorn/skelp
A+ Excellent! Found 17 issues across 43 files
gofmt97%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
skelp/skelplate/schema_accessor.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo93%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
skelp/skelplate/descriptor.go
- Line 130: warning: cyclomatic complexity 19 of function (*SkelplateDescriptor).UnmarshalJSON() is high (> 15) (gocyclo)
-
-
skelp/prompter/keyed.go
- Line 59: warning: cyclomatic complexity 17 of function (*KeyedInput).Ask() is high (> 15) (gocyclo)
-
-
skelp/prompter/selected.go
- Line 92: warning: cyclomatic complexity 16 of function (*SelectedInput).Ask() is high (> 15) (gocyclo)
golint65%
Golint is a linter for Go source code.
-
-
skelp/prompter/keyed.go
- Line 11: warning: exported type KeyedInput should have comment or be unexported (golint)
- Line 18: warning: exported var KeyedInputTemplate should have comment or be unexported (golint)
- Line 33: warning: exported type KeyedTemplateData should have comment or be unexported (golint)
- Line 59: warning: exported method KeyedInput.Ask should have comment or be unexported (golint)
-
-
skelp/prompter/validators.go
- Line 15: warning: exported type Validator should have comment or be unexported (golint)
- Line 17: warning: exported function StringNotBlank should have comment or be unexported (golint)
- Line 24: warning: exported function YesOrNo should have comment or be unexported (golint)
- Line 31: warning: exported function IsANumber should have comment or be unexported (golint)
- Line 41: warning: exported function GreaterThanZero should have comment or be unexported (golint)
- Line 55: warning: exported type MinMaxString should have comment or be unexported (golint)
- Line 60: warning: exported method MinMaxString.CheckMin should have comment or be unexported (golint)
- Line 72: warning: exported method MinMaxString.CheckMax should have comment or be unexported (golint)
- Line 84: warning: exported type MinMaxNumber should have comment or be unexported (golint)
- Line 89: warning: exported method MinMaxNumber.CheckMin should have comment or be unexported (golint)
- Line 107: warning: exported method MinMaxNumber.CheckMax should have comment or be unexported (golint)
-
-
skelp/cmd/skelp.go
- Line 21: warning: exported function NewSkelpCommand should have comment or be unexported (golint)
- Line 64: warning: comment on exported function Execute should be of the form "Execute ..." (golint)
-
-
skelp/skelplate/descriptor.go
- Line 15: warning: exported type SkelplateDescriptor should have comment or be unexported (golint)
- Line 66: warning: exported method SimpleVar.Name should have comment or be unexported (golint)
- Line 70: warning: exported method SimpleVar.Default should have comment or be unexported (golint)
-
-
skelp/generator/alias.go
- Line 14: warning: exported const ErrAliasNotFound should have comment (or a comment on this block) or be unexported (golint)
- Line 21: warning: exported method SkelpGenerator.IDForAlias should have comment or be unexported (golint)
- Line 41: warning: exported method SkelpGenerator.AddAlias should have comment or be unexported (golint)
- Line 71: warning: exported method SkelpGenerator.RemoveAlias should have comment or be unexported (golint)
- Line 88: warning: exported method SkelpGenerator.AliasMap should have comment or be unexported (golint)
-
-
skelp/generator/skelp.go
- Line 21: warning: exported type SkelpOptions should have comment or be unexported (golint)
- Line 31: warning: exported function DefaultOptions should have comment or be unexported (golint)
- Line 42: warning: exported type SkelpGenerator should have comment or be unexported (golint)
- Line 51: warning: exported function New should have comment or be unexported (golint)
- Line 83: warning: exported method SkelpGenerator.InitSkelpHome should have comment or be unexported (golint)
-
-
skelp/prompter/prompt.go
- Line 9: warning: exported type Prompter should have comment or be unexported (golint)
- Line 15: warning: exported type Prompt should have comment or be unexported (golint)
- Line 24: warning: exported method Prompt.Validate should have comment or be unexported (golint)
- Line 38: warning: exported type InputTemplateData should have comment or be unexported (golint)
-
-
skelp/skelputil/util.go
- Line 15: warning: exported function FunctionMap should have comment or be unexported (golint)
- Line 21: warning: exported function TemplateOptions should have comment or be unexported (golint)
- Line 25: warning: comment on exported function PathExists should be of the form "PathExists ..." (golint)
- Line 36: warning: exported function DirIsEmpty should have comment or be unexported (golint)
- Line 50: warning: exported function MkdirAll should have comment or be unexported (golint)
- Line 61: warning: exported function GetFileMode should have comment or be unexported (golint)
- Line 83: warning: exported function IsBlank should have comment or be unexported (golint)
-
-
skelp/prompter/answers.go
- Line 7: warning: exported function AsBool should have comment or be unexported (golint)
-
-
skelp/provider/provider.go
- Line 11: warning: exported type BasicAuthProvider should have comment or be unexported (golint)
- Line 13: warning: exported function DefaultOverwriteProvider should have comment or be unexported (golint)
- Line 17: warning: exported function AlwaysOverwriteProvider should have comment or be unexported (golint)
- Line 21: warning: exported type DefaultBasicAuthProvider should have comment or be unexported (golint)
- Line 25: warning: exported method DefaultBasicAuthProvider.ProvideAuth should have comment or be unexported (golint)
-
-
skelp/prompter/selected.go
- Line 13: warning: exported type SelectedInput should have comment or be unexported (golint)
- Line 22: warning: exported var SelectedInputTemplate should have comment or be unexported (golint)
- Line 38: warning: exported type SelectedTemplateData should have comment or be unexported (golint)
- Line 45: warning: comment on exported method SelectedInput.OnChange should be of the form "OnChange ..." (golint)
- Line 92: warning: exported method SelectedInput.Ask should have comment or be unexported (golint)
-
-
skelp/skelplate/dataprovider.go
- Line 20: warning: exported const ErrSkelpFileNotFound should have comment (or a comment on this block) or be unexported (golint)
- Line 23: warning: exported type SkelplateDataProvider should have comment or be unexported (golint)
- Line 30: warning: exported function NewDataProvider should have comment or be unexported (golint)
- Line 38: warning: exported method SkelplateDataProvider.DataProviderFunc should have comment or be unexported (golint)
-
-
skelp/generator/generator.go
- Line 17: warning: exported const ErrBlankTemplateID should have comment (or a comment on this block) or be unexported (golint)
- Line 23: warning: exported method SkelpGenerator.Generate should have comment or be unexported (golint)
-
-
skelp/generator/util.go
- Line 15: warning: exported const TIDTypeRepo should have comment (or a comment on this block) or be unexported (golint)
- Line 27: warning: exported function TypeForTemplateID should have comment or be unexported (golint)
- Line 39: warning: exported function AuthMethodForURL should have comment or be unexported (golint)
- Line 55: warning: exported function FilepathFromURL should have comment or be unexported (golint)
- Line 84: warning: exported function IsRepoURL should have comment or be unexported (golint)
- Line 88: warning: exported function IsSSH should have comment or be unexported (golint)
- Line 92: warning: exported function IsFilePath should have comment or be unexported (golint)
- Line 96: warning: exported function IsAlias should have comment or be unexported (golint)
-
-
skelp/executor/executor.go
- Line 16: warning: exported const ErrNoTemplatesFound should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported type WalkingExecutor should have comment or be unexported (golint)
- Line 25: warning: exported function New should have comment or be unexported (golint)
- Line 32: warning: exported method WalkingExecutor.Execute should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell95%
Misspell Finds commonly misspelled English words
-
-
skelp/executor/executor_test.go
- Line 34: warning: "ouput" is a misspelling of "output" (misspell)
- Line 43: warning: "ouput" is a misspelling of "output" (misspell)
-
-
skelp/prompter/validators.go
- Line 12: warning: "alse" is a misspelling of "else" (misspell)