Preparing report...

Report for github.com/buildpacks/pack

A+    Excellent!    Found 157 issues across 328 files

Tweet

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • pack/pkg/archive/archive.go
    • Line 168: warning: cyclomatic complexity 19 of function WriteDirToTar() is high (> 15) (gocyclo)
    • Line 253: warning: cyclomatic complexity 16 of function WriteZipToTar() is high (> 15) (gocyclo)
    • pack/build.go
    • Line 194: warning: cyclomatic complexity 26 of function (*Client).Build() is high (> 15) (gocyclo)
    • Line 632: warning: cyclomatic complexity 26 of function (*Client).processBuildpacks() is high (> 15) (gocyclo)

golint54%

Golint is a linter for Go source code.

    • pack/internal/build/phase_config_provider.go
    • Line 21: warning: exported type PhaseConfigProviderOperation should have comment or be unexported (golint)
    • Line 23: warning: exported type PhaseConfigProvider should have comment or be unexported (golint)
    • Line 33: warning: exported function NewPhaseConfigProvider should have comment or be unexported (golint)
    • Line 79: warning: exported method PhaseConfigProvider.ContainerConfig should have comment or be unexported (golint)
    • Line 83: warning: exported method PhaseConfigProvider.ContainerOps should have comment or be unexported (golint)
    • Line 87: warning: exported method PhaseConfigProvider.HostConfig should have comment or be unexported (golint)
    • Line 91: warning: exported method PhaseConfigProvider.Name should have comment or be unexported (golint)
    • Line 95: warning: exported method PhaseConfigProvider.ErrorWriter should have comment or be unexported (golint)
    • Line 99: warning: exported method PhaseConfigProvider.InfoWriter should have comment or be unexported (golint)
    • Line 103: warning: exported function NullOp should have comment or be unexported (golint)
    • Line 107: warning: exported function WithArgs should have comment or be unexported (golint)
    • Line 120: warning: exported function WithBinds should have comment or be unexported (golint)
    • Line 126: warning: exported function WithDaemonAccess should have comment or be unexported (golint)
    • Line 155: warning: exported function WithEnv should have comment or be unexported (golint)
    • Line 161: warning: exported function WithImage should have comment or be unexported (golint)
    • Line 177: warning: exported function WithLifecycleProxy should have comment or be unexported (golint)
    • Line 193: warning: exported function WithNetwork should have comment or be unexported (golint)
    • Line 199: warning: exported function WithRegistryAccess should have comment or be unexported (golint)
    • Line 205: warning: exported function WithRoot should have comment or be unexported (golint)
    • Line 215: warning: exported function WithContainerOperations should have comment or be unexported (golint)
    • pack/internal/builder/fakes/fake_label_manager_factory.go
    • Line 5: warning: exported type FakeLabelManagerFactory should have comment or be unexported (golint)
    • Line 11: warning: exported function NewFakeLabelManagerFactory should have comment or be unexported (golint)
    • Line 17: warning: exported method FakeLabelManagerFactory.BuilderLabelManager should have comment or be unexported (golint)
    • pack/internal/builder/writer/structured_format.go
    • Line 16: warning: exported type InspectOutput should have comment or be unexported (golint)
    • Line 22: warning: exported type RunImage should have comment or be unexported (golint)
    • Line 27: warning: exported type Lifecycle should have comment or be unexported (golint)
    • Line 33: warning: exported type Stack should have comment or be unexported (golint)
    • Line 38: warning: exported type BuilderInfo should have comment or be unexported (golint)
    • Line 48: warning: exported type StructuredFormat should have comment or be unexported (golint)
    • Line 52: warning: exported method StructuredFormat.Print should have comment or be unexported (golint)
    • pack/internal/fakes/fake_image_fetcher.go
    • Line 14: warning: exported type FetchArgs should have comment or be unexported (golint)
    • Line 19: warning: exported type FakeImageFetcher should have comment or be unexported (golint)
    • Line 25: warning: exported function NewFakeImageFetcher should have comment or be unexported (golint)
    • Line 33: warning: exported method FakeImageFetcher.Fetch should have comment or be unexported (golint)
    • pack/internal/builder/descriptor.go
    • Line 34: warning: exported type APISet should have comment or be unexported (golint)
    • Line 52: warning: exported method APISet.Earliest should have comment or be unexported (golint)
    • Line 56: warning: exported method APISet.Latest should have comment or be unexported (golint)
    • Line 60: warning: exported method APISet.AsStrings should have comment or be unexported (golint)
    • pack/internal/build/fakes/fake_phase.go
    • Line 5: warning: exported type FakePhase should have comment or be unexported (golint)
    • Line 10: warning: exported method FakePhase.Cleanup should have comment or be unexported (golint)
    • Line 16: warning: exported method FakePhase.Run should have comment or be unexported (golint)
    • pack/internal/image/fetcher.go
    • Line 26: warning: exported type Fetcher should have comment or be unexported (golint)
    • Line 31: warning: exported function NewFetcher should have comment or be unexported (golint)
    • Line 38: warning: exported var ErrNotFound should have comment or be unexported (golint)
    • Line 40: warning: exported method Fetcher.Fetch should have comment or be unexported (golint)
    • pack/internal/builder/label_manager.go
    • Line 12: warning: exported type LabelManager should have comment or be unexported (golint)
    • Line 16: warning: exported function NewLabelManager should have comment or be unexported (golint)
    • Line 20: warning: exported method LabelManager.Metadata should have comment or be unexported (golint)
    • Line 26: warning: exported method LabelManager.StackID should have comment or be unexported (golint)
    • Line 30: warning: exported method LabelManager.Mixins should have comment or be unexported (golint)
    • Line 36: warning: exported method LabelManager.Order should have comment or be unexported (golint)
    • Line 42: warning: exported method LabelManager.BuildpackLayers should have comment or be unexported (golint)
    • pack/testhelpers/testhelpers.go
    • Line 42: warning: exported function RandString should have comment or be unexported (golint)
    • Line 50: warning: comment on exported function AssertEq should be of the form "AssertEq ..." (golint)
    • Line 58: warning: exported function AssertFunctionName should have comment or be unexported (golint)
    • Line 70: warning: comment on exported function AssertNotEq should be of the form "AssertNotEq ..." (golint)
    • Line 78: warning: exported function AssertTrue should have comment or be unexported (golint)
    • Line 83: warning: exported function AssertFalse should have comment or be unexported (golint)
    • Line 88: warning: exported function AssertUnique should have comment or be unexported (golint)
    • Line 99: warning: comment on exported function AssertSameInstance should be of the form "AssertSameInstance ..." (golint)
    • Line 107: warning: exported function AssertError should have comment or be unexported (golint)
    • Line 117: warning: exported function AssertContains should have comment or be unexported (golint)
    • Line 129: warning: exported function AssertContainsAllInOrder should have comment or be unexported (golint)
    • Line 166: warning: exported function AssertNotContainsMatch should have comment or be unexported (golint)
    • Line 173: warning: exported function AssertNotContains should have comment or be unexported (golint)
    • Line 180: warning: exported function AssertSliceContains should have comment or be unexported (golint)
    • Line 188: warning: exported function AssertSliceContainsInOrder should have comment or be unexported (golint)
    • Line 213: warning: exported function AssertSliceNotContains should have comment or be unexported (golint)
    • Line 221: warning: exported function AssertSliceContainsMatch should have comment or be unexported (golint)
    • Line 244: warning: exported function AssertSliceContainsOnly should have comment or be unexported (golint)
    • Line 255: warning: exported function AssertMatch should have comment or be unexported (golint)
    • Line 278: warning: exported function AssertNotNil should have comment or be unexported (golint)
    • Line 285: warning: exported function AssertTarball should have comment or be unexported (golint)
    • Line 318: warning: exported function Eventually should have comment or be unexported (golint)
    • Line 338: warning: exported function CreateImage should have comment or be unexported (golint)
    • Line 357: warning: exported function CreateImageFromDir should have comment or be unexported (golint)
    • Line 404: warning: exported function CreateImageOnRemote should have comment or be unexported (golint)
    • Line 412: warning: exported function DockerRmi should have comment or be unexported (golint)
    • Line 428: warning: exported function PushImage should have comment or be unexported (golint)
    • Line 443: warning: exported function HTTPGetE should have comment or be unexported (golint)
    • Line 470: warning: exported function ImageID should have comment or be unexported (golint)
    • Line 477: warning: exported function Digest should have comment or be unexported (golint)
    • Line 491: warning: exported function TopLayerDiffID should have comment or be unexported (golint)
    • Line 501: warning: exported function Run should have comment or be unexported (golint)
    • Line 508: warning: exported function RunE should have comment or be unexported (golint)
    • Line 517: warning: exported function PullImageWithAuth should have comment or be unexported (golint)
    • Line 528: warning: exported function CopyFile should have comment or be unexported (golint)
    • Line 535: warning: exported function CopyFileE should have comment or be unexported (golint)
    • Line 562: warning: exported function RecursiveCopy should have comment or be unexported (golint)
    • Line 569: warning: exported function RecursiveCopyE should have comment or be unexported (golint)
    • Line 603: warning: exported function RequireDocker should have comment or be unexported (golint)
    • Line 608: warning: exported function SkipIf should have comment or be unexported (golint)
    • Line 615: warning: exported function SkipUnless should have comment or be unexported (golint)
    • Line 622: warning: exported function RunContainer should have comment or be unexported (golint)
    • Line 655: warning: exported function CreateTGZ should have comment or be unexported (golint)
    • Line 670: warning: exported function CreateTAR should have comment or be unexported (golint)
    • Line 691: warning: exported function RecursiveCopyNow should have comment or be unexported (golint)
    • Line 725: warning: exported function AssertTarFileContents should have comment or be unexported (golint)
    • Line 757: warning: exported function AssertTarHasFile should have comment or be unexported (golint)
    • Line 789: warning: exported function AssertBuildpacksHaveDescriptors should have comment or be unexported (golint)
    • Line 803: warning: exported function AssertGitHeadEq should have comment or be unexported (golint)
    • Line 819: warning: exported function MockWriterAndOutput should have comment or be unexported (golint)
    • pack/internal/build/fakes/fake_phase_factory.go
    • Line 5: warning: exported type FakePhaseFactory should have comment or be unexported (golint)
    • Line 11: warning: exported function NewFakePhaseFactory should have comment or be unexported (golint)
    • Line 23: warning: exported function WhichReturnsForNew should have comment or be unexported (golint)
    • Line 29: warning: exported method FakePhaseFactory.New should have comment or be unexported (golint)
    • pack/internal/builder/fakes/fake_label_manager.go
    • Line 8: warning: exported type FakeLabelManager should have comment or be unexported (golint)
    • Line 22: warning: exported method FakeLabelManager.Metadata should have comment or be unexported (golint)
    • Line 26: warning: exported method FakeLabelManager.StackID should have comment or be unexported (golint)
    • Line 30: warning: exported method FakeLabelManager.Mixins should have comment or be unexported (golint)
    • Line 34: warning: exported method FakeLabelManager.Order should have comment or be unexported (golint)
    • Line 38: warning: exported method FakeLabelManager.BuildpackLayers should have comment or be unexported (golint)
    • pack/internal/dist/buildpack.go
    • Line 16: warning: exported const AssumedBuildpackAPIVersion should have comment or be unexported (golint)
    • Line 17: warning: exported const BuildpacksDir should have comment or be unexported (golint)
    • Line 19: warning: exported type Blob should have comment or be unexported (golint)
    • Line 33: warning: comment on exported type Buildpack should be of the form "Buildpack ..." (with optional leading article) (golint)
    • Line 42: warning: exported type BuildpackInfo should have comment or be unexported (golint)
    • Line 52: warning: exported type License should have comment or be unexported (golint)
    • Line 57: warning: exported method BuildpackInfo.FullName should have comment or be unexported (golint)
    • Line 72: warning: exported type Stack should have comment or be unexported (golint)
    • pack/internal/inspectimage/bom_display.go
    • Line 10: warning: exported type BOMDisplay should have comment or be unexported (golint)
    • Line 17: warning: exported type BOMEntryDisplay should have comment or be unexported (golint)
    • Line 24: warning: exported function NewBOMDisplay should have comment or be unexported (golint)
    • pack/internal/cache/volume_cache.go
    • Line 15: warning: exported type VolumeCache should have comment or be unexported (golint)
    • Line 20: warning: exported function NewVolumeCache should have comment or be unexported (golint)
    • Line 30: warning: exported method VolumeCache.Name should have comment or be unexported (golint)
    • Line 34: warning: exported method VolumeCache.Clear should have comment or be unexported (golint)
    • Line 42: warning: exported method VolumeCache.Type should have comment or be unexported (golint)
    • pack/internal/commands/commands.go
    • Line 19: warning: comment on exported type PackClient should be of the form "PackClient ..." (with optional leading article) (golint)
    • Line 34: warning: exported function AddHelpFlag should have comment or be unexported (golint)
    • Line 38: warning: exported function CreateCancellableContext should have comment or be unexported (golint)
    • pack/testhelpers/tar_assertions.go
    • Line 21: warning: exported type TarEntryAssertion should have comment or be unexported (golint)
    • Line 23: warning: exported function AssertOnTarEntry should have comment or be unexported (golint)
    • Line 38: warning: exported function AssertOnNestedTar should have comment or be unexported (golint)
    • Line 89: warning: exported function ContentContains should have comment or be unexported (golint)
    • Line 96: warning: exported function ContentEquals should have comment or be unexported (golint)
    • Line 103: warning: exported function SymlinksTo should have comment or be unexported (golint)
    • Line 116: warning: exported function HasOwnerAndGroup should have comment or be unexported (golint)
    • Line 128: warning: exported function IsJSON should have comment or be unexported (golint)
    • Line 136: warning: exported function IsGzipped should have comment or be unexported (golint)
    • Line 146: warning: exported function HasFileMode should have comment or be unexported (golint)
    • Line 155: warning: exported function HasModTime should have comment or be unexported (golint)
    • Line 164: warning: exported function DoesNotHaveModTime should have comment or be unexported (golint)
    • Line 173: warning: exported function IsDirectory should have comment or be unexported (golint)
    • pack/internal/blob/blob.go
    • Line 15: warning: exported type Blob should have comment or be unexported (golint)
    • Line 23: warning: exported function NewBlob should have comment or be unexported (golint)
    • pack/internal/paths/paths.go
    • Line 14: warning: exported function IsURI should have comment or be unexported (golint)
    • Line 18: warning: exported function IsDir should have comment or be unexported (golint)
    • Line 52: warning: comment on exported function URIToFilePath should be of the form "URIToFilePath ..." (golint)
    • Line 81: warning: exported function FilterReservedNames should have comment or be unexported (golint)
    • pack/internal/commands/suggest_builders.go
    • Line 15: warning: exported type SuggestedBuilder should have comment or be unexported (golint)
    • Line 54: warning: comment on exported function SuggestBuilders should be of the form "SuggestBuilders ..." (golint)
    • Line 83: warning: exported function WriteSuggestedBuilder should have comment or be unexported (golint)
    • pack/internal/dist/layers.go
    • Line 14: warning: exported function BuildpackToLayerTar should have comment or be unexported (golint)
    • Line 36: warning: exported function LayerDiffID should have comment or be unexported (golint)
    • pack/testmocks/mock_image.go
    • Line 8: warning: exported type MockImage should have comment or be unexported (golint)
    • Line 21: warning: exported function NewImage should have comment or be unexported (golint)
    • Line 27: warning: exported method MockImage.Entrypoint should have comment or be unexported (golint)
    • pack/internal/build/lifecycle_execution.go
    • Line 26: warning: exported type LifecycleExecution should have comment or be unexported (golint)
    • Line 37: warning: exported function NewLifecycleExecution should have comment or be unexported (golint)
    • Line 85: warning: exported method LifecycleExecution.Builder should have comment or be unexported (golint)
    • Line 89: warning: exported method LifecycleExecution.AppPath should have comment or be unexported (golint)
    • Line 93: warning: exported method LifecycleExecution.AppDir should have comment or be unexported (golint)
    • Line 97: warning: exported method LifecycleExecution.AppVolume should have comment or be unexported (golint)
    • Line 101: warning: exported method LifecycleExecution.LayersVolume should have comment or be unexported (golint)
    • Line 105: warning: exported method LifecycleExecution.PlatformAPI should have comment or be unexported (golint)
    • Line 109: warning: exported method LifecycleExecution.Run should have comment or be unexported (golint)
    • Line 163: warning: exported method LifecycleExecution.Cleanup should have comment or be unexported (golint)
    • Line 174: warning: exported method LifecycleExecution.Create should have comment or be unexported (golint)
    • Line 227: warning: exported method LifecycleExecution.Detect should have comment or be unexported (golint)
    • Line 250: warning: exported method LifecycleExecution.Restore should have comment or be unexported (golint)
    • Line 282: warning: exported method LifecycleExecution.Analyze should have comment or be unexported (golint)
    • Line 362: warning: exported method LifecycleExecution.Build should have comment or be unexported (golint)
    • Line 449: warning: exported method LifecycleExecution.Export should have comment or be unexported (golint)
    • pack/internal/builder/inspect.go
    • Line 16: warning: exported type Info should have comment or be unexported (golint)
    • Line 29: warning: exported type Inspectable should have comment or be unexported (golint)
    • Line 33: warning: exported type InspectableFetcher should have comment or be unexported (golint)
    • Line 37: warning: exported type LabelManagerFactory should have comment or be unexported (golint)
    • Line 41: warning: exported type LabelInspector should have comment or be unexported (golint)
    • Line 49: warning: exported type DetectionCalculator should have comment or be unexported (golint)
    • Line 53: warning: exported type Inspector should have comment or be unexported (golint)
    • Line 59: warning: exported function NewInspector should have comment or be unexported (golint)
    • Line 67: warning: exported method Inspector.Inspect should have comment or be unexported (golint)
    • pack/internal/cache/image_cache.go
    • Line 11: warning: exported type ImageCache should have comment or be unexported (golint)
    • Line 16: warning: exported function NewImageCache should have comment or be unexported (golint)
    • Line 23: warning: exported method ImageCache.Name should have comment or be unexported (golint)
    • Line 27: warning: exported method ImageCache.Clear should have comment or be unexported (golint)
    • Line 37: warning: exported method ImageCache.Type should have comment or be unexported (golint)
    • pack/internal/layer/writer_factory.go
    • Line 13: warning: exported type WriterFactory should have comment or be unexported (golint)
    • Line 17: warning: exported function NewWriterFactory should have comment or be unexported (golint)
    • Line 25: warning: exported method WriterFactory.NewWriter should have comment or be unexported (golint)
    • pack/logging/logging.go
    • Line 11: warning: exported type Level should have comment or be unexported (golint)
    • Line 14: warning: exported const DebugLevel should have comment (or a comment on this block) or be unexported (golint)
    • pack/package_buildpack.go
    • Line 20: warning: comment on exported const FormatImage should be of the form "FormatImage ..." (golint)
    • Line 23: warning: comment on exported const FormatFile should be of the form "FormatFile ..." (golint)
    • pack/builder/detection_order.go
    • Line 7: warning: exported type DetectionOrderEntry should have comment or be unexported (golint)
    • Line 13: warning: exported type DetectionOrder should have comment or be unexported (golint)
    • Line 16: warning: exported const OrderDetectionMaxDepth should have comment (or a comment on this block) or be unexported (golint)
    • pack/internal/commands/builder_inspect.go
    • Line 13: warning: exported type BuilderInspector should have comment or be unexported (golint)
    • Line 17: warning: exported type BuilderInspectFlags should have comment or be unexported (golint)
    • Line 22: warning: exported function BuilderInspect should have comment or be unexported (golint)
    • pack/internal/buildpack/locator_type.go
    • Line 17: warning: exported type LocatorType should have comment or be unexported (golint)
    • Line 20: warning: exported const InvalidLocator should have comment (or a comment on this block) or be unexported (golint)
    • Line 84: warning: exported function HasDockerLocator should have comment or be unexported (golint)
    • pack/testhelpers/tar_verifier.go
    • Line 10: warning: exported type TarVerifier should have comment or be unexported (golint)
    • Line 17: warning: exported function NewTarVerifier should have comment or be unexported (golint)
    • Line 26: warning: exported method TarVerifier.NextDirectory should have comment or be unexported (golint)
    • Line 53: warning: exported method TarVerifier.NoMoreFilesExist should have comment or be unexported (golint)
    • Line 63: warning: exported method TarVerifier.NextFile should have comment or be unexported (golint)
    • Line 98: warning: exported method TarVerifier.NextSymLink should have comment or be unexported (golint)
    • pack/internal/buildpackage/builder.go
    • Line 25: warning: exported type ImageFactory should have comment or be unexported (golint)
    • Line 29: warning: exported type WorkableImage should have comment or be unexported (golint)
    • Line 64: warning: exported type PackageBuilder should have comment or be unexported (golint)
    • Line 70: warning: exported function NewBuilder should have comment or be unexported (golint)
    • Line 76: warning: exported method PackageBuilder.SetBuildpack should have comment or be unexported (golint)
    • Line 80: warning: exported method PackageBuilder.AddDependency should have comment or be unexported (golint)
    • Line 152: warning: exported method PackageBuilder.SaveAsFile should have comment or be unexported (golint)
    • Line 232: warning: exported method PackageBuilder.SaveAsImage should have comment or be unexported (golint)
    • pack/internal/build/phase.go
    • Line 15: warning: exported type Phase should have comment or be unexported (golint)
    • Line 29: warning: exported method Phase.Run should have comment or be unexported (golint)
    • Line 51: warning: exported method Phase.Cleanup should have comment or be unexported (golint)
    • pack/internal/build/fakes/fake_builder.go
    • Line 13: warning: exported type FakeBuilder should have comment or be unexported (golint)
    • Line 21: warning: exported function NewFakeBuilder should have comment or be unexported (golint)
    • Line 49: warning: exported function WithDeprecatedPlatformAPIs should have comment or be unexported (golint)
    • Line 55: warning: exported function WithSupportedPlatformAPIs should have comment or be unexported (golint)
    • Line 61: warning: exported function WithImage should have comment or be unexported (golint)
    • Line 67: warning: exported function WithUID should have comment or be unexported (golint)
    • Line 73: warning: exported function WithGID should have comment or be unexported (golint)
    • Line 79: warning: exported method FakeBuilder.Name should have comment or be unexported (golint)
    • Line 83: warning: exported method FakeBuilder.Image should have comment or be unexported (golint)
    • Line 87: warning: exported method FakeBuilder.UID should have comment or be unexported (golint)
    • Line 91: warning: exported method FakeBuilder.GID should have comment or be unexported (golint)
    • Line 95: warning: exported method FakeBuilder.LifecycleDescriptor should have comment or be unexported (golint)
    • Line 99: warning: exported method FakeBuilder.Stack should have comment or be unexported (golint)
    • Line 103: warning: exported function WithBuilder should have comment or be unexported (golint)
    • pack/internal/config/config.go
    • Line 13: warning: exported type Config should have comment or be unexported (golint)
    • Line 26: warning: exported type Registry should have comment or be unexported (golint)
    • Line 32: warning: exported type RunImage should have comment or be unexported (golint)
    • Line 37: warning: exported type TrustedBuilder should have comment or be unexported (golint)
    • Line 41: warning: exported const OfficialRegistryName should have comment or be unexported (golint)
    • Line 43: warning: exported function DefaultRegistry should have comment or be unexported (golint)
    • Line 51: warning: exported function DefaultConfigPath should have comment or be unexported (golint)
    • Line 59: warning: exported function PackHome should have comment or be unexported (golint)
    • Line 71: warning: exported function Read should have comment or be unexported (golint)
    • Line 81: warning: exported function Write should have comment or be unexported (golint)
    • Line 94: warning: exported function MkdirAll should have comment or be unexported (golint)
    • Line 98: warning: exported function SetRunImageMirrors should have comment or be unexported (golint)
    • Line 109: warning: exported function GetRegistries should have comment or be unexported (golint)
    • Line 113: warning: exported function GetRegistry should have comment or be unexported (golint)
    • Line 130: warning: exported const DefaultLifecycleImageRepo should have comment or be unexported (golint)
    • pack/internal/fakes/fake_buildpack.go
    • Line 31: warning: exported type FakeBuildpackOption should have comment or be unexported (golint)
    • Line 33: warning: exported function WithExtraBuildpackContents should have comment or be unexported (golint)
    • Line 39: warning: exported function WithOpenError should have comment or be unexported (golint)
    • pack/errors.go
    • Line 8: warning: exported function NewExperimentError should have comment or be unexported (golint)
    • Line 19: warning: exported function NewSoftError should have comment or be unexported (golint)
    • pack/testhelpers/registry.go
    • Line 31: warning: exported type TestRegistryConfig should have comment or be unexported (golint)
    • Line 41: warning: exported function RegistryHost should have comment or be unexported (golint)
    • Line 45: warning: exported function CreateRegistryFixture should have comment or be unexported (golint)
    • Line 79: warning: exported function RunRegistry should have comment or be unexported (golint)
    • Line 123: warning: exported method TestRegistryConfig.AuthConfig should have comment or be unexported (golint)
    • Line 131: warning: exported method TestRegistryConfig.Login should have comment or be unexported (golint)
    • Line 207: warning: exported function DockerHostname should have comment or be unexported (golint)
    • Line 275: warning: exported method TestRegistryConfig.RmRegistry should have comment or be unexported (golint)
    • Line 285: warning: exported method TestRegistryConfig.StopRegistry should have comment or be unexported (golint)
    • Line 294: warning: exported method TestRegistryConfig.RepoName should have comment or be unexported (golint)
    • Line 298: warning: exported method TestRegistryConfig.RegistryAuth should have comment or be unexported (golint)
    • Line 302: warning: exported method TestRegistryConfig.RegistryCatalog should have comment or be unexported (golint)
    • pack/client.go
    • Line 104: warning: comment on exported function WithCacheDir should be of the form "WithCacheDir ..." (golint)
    • pack/internal/dist/image.go
    • Line 11: warning: exported type Labeled should have comment or be unexported (golint)
    • Line 15: warning: exported type Labelable should have comment or be unexported (golint)
    • Line 19: warning: exported function SetLabel should have comment or be unexported (golint)
    • Line 30: warning: exported function GetLabel should have comment or be unexported (golint)
    • pack/internal/registry/registry_cache.go
    • Line 26: warning: exported const DefaultRegistryURL should have comment or be unexported (golint)
    • Line 27: warning: exported const DefaultRegistryName should have comment or be unexported (golint)
    • Line 37: warning: exported const GithubIssueTitleTemplate should have comment or be unexported (golint)
    • Line 38: warning: exported const GithubIssueBodyTemplate should have comment or be unexported (golint)
    • Line 43: warning: exported const GitCommitTemplate should have comment or be unexported (golint)
    • pack/internal/inspectimage/info_display.go
    • Line 13: warning: exported type GeneralInfo should have comment or be unexported (golint)
    • Line 18: warning: exported type RunImageMirrorDisplay should have comment or be unexported (golint)
    • Line 23: warning: exported type StackDisplay should have comment or be unexported (golint)
    • Line 28: warning: exported type ProcessDisplay should have comment or be unexported (golint)
    • Line 36: warning: exported type BaseDisplay should have comment or be unexported (golint)
    • Line 41: warning: exported type InfoDisplay should have comment or be unexported (golint)
    • Line 49: warning: exported type InspectOutput should have comment or be unexported (golint)
    • Line 55: warning: exported function NewInfoDisplay should have comment or be unexported (golint)
    • pack/internal/image/factory.go
    • Line 11: warning: exported type DefaultImageFactory should have comment or be unexported (golint)
    • Line 16: warning: exported function NewFactory should have comment or be unexported (golint)
    • Line 23: warning: exported method DefaultImageFactory.NewImage should have comment or be unexported (golint)
    • pack/internal/builder/writer/factory.go
    • Line 13: warning: exported type Factory should have comment or be unexported (golint)
    • Line 15: warning: exported type BuilderWriter should have comment or be unexported (golint)
    • Line 25: warning: exported type SharedBuilderInfo should have comment or be unexported (golint)
    • Line 31: warning: exported type BuilderWriterFactory should have comment or be unexported (golint)
    • Line 35: warning: exported function NewFactory should have comment or be unexported (golint)
    • Line 39: warning: exported method Factory.Writer should have comment or be unexported (golint)
    • pack/internal/style/style.go
    • Line 11: warning: exported var Symbol should have comment or be unexported (golint)
    • Line 18: warning: exported var Map should have comment or be unexported (golint)
    • Line 39: warning: exported var SymbolF should have comment or be unexported (golint)
    • Line 46: warning: exported var Key should have comment or be unexported (golint)
    • Line 48: warning: exported var Tip should have comment or be unexported (golint)
    • Line 50: warning: exported var Warn should have comment or be unexported (golint)
    • Line 52: warning: exported var Error should have comment or be unexported (golint)
    • Line 54: warning: exported var Step should have comment or be unexported (golint)
    • Line 58: warning: exported var Prefix should have comment or be unexported (golint)
    • Line 59: warning: exported var Waiting should have comment or be unexported (golint)
    • Line 60: warning: exported var Working should have comment or be unexported (golint)
    • Line 61: warning: exported var Complete should have comment or be unexported (golint)
    • Line 62: warning: exported var ProgressBar should have comment or be unexported (golint)
    • pack/internal/dist/dist.go
    • Line 7: warning: exported const BuildpackLayersLabel should have comment or be unexported (golint)
    • Line 9: warning: exported type BuildpackURI should have comment or be unexported (golint)
    • Line 13: warning: exported type ImageRef should have comment or be unexported (golint)
    • Line 17: warning: exported type ImageOrURI should have comment or be unexported (golint)
    • Line 22: warning: exported method ImageOrURI.DisplayString should have comment or be unexported (golint)
    • Line 30: warning: exported type Platform should have comment or be unexported (golint)
    • Line 34: warning: exported type Order should have comment or be unexported (golint)
    • Line 36: warning: exported type OrderEntry should have comment or be unexported (golint)
    • Line 40: warning: exported type BuildpackRef should have comment or be unexported (golint)
    • Line 45: warning: exported type BuildpackLayers should have comment or be unexported (golint)
    • Line 47: warning: exported type BuildpackLayerInfo should have comment or be unexported (golint)
    • Line 56: warning: exported method BuildpackLayers.Get should have comment or be unexported (golint)
    • Line 71: warning: exported function AddBuildpackToLayersMD should have comment or be unexported (golint)
    • pack/testhelpers/assert_file.go
    • Line 7: warning: exported method AssertionManager.FileExists should have comment or be unexported (golint)
    • Line 19: warning: exported method AssertionManager.FileIsNotEmpty should have comment or be unexported (golint)
    • pack/internal/dist/buildpack_descriptor.go
    • Line 14: warning: exported type BuildpackDescriptor should have comment or be unexported (golint)
    • Line 21: warning: exported method BuildpackDescriptor.EscapedID should have comment or be unexported (golint)
    • Line 25: warning: exported method BuildpackDescriptor.EnsureStackSupport should have comment or be unexported (golint)
    • pack/pkg/archive/tar_builder.go
    • Line 14: warning: exported type TarBuilder should have comment or be unexported (golint)
    • Line 26: warning: exported method TarBuilder.AddFile should have comment or be unexported (golint)
    • Line 36: warning: exported method TarBuilder.AddDir should have comment or be unexported (golint)
    • Line 45: warning: exported method TarBuilder.Reader should have comment or be unexported (golint)
    • Line 58: warning: exported method TarBuilder.WriteToPath should have comment or be unexported (golint)
    • Line 69: warning: exported method TarBuilder.WriteTo should have comment or be unexported (golint)
    • pack/internal/builder/detection_order_calculator.go
    • Line 8: warning: exported type DetectionOrderCalculator should have comment or be unexported (golint)
    • Line 10: warning: exported function NewDetectionOrderCalculator should have comment or be unexported (golint)
    • Line 26: warning: exported method DetectionOrderCalculator.Order should have comment or be unexported (golint)
    • pack/internal/builder/metadata.go
    • Line 6: warning: exported const OrderLabel should have comment (or a comment on this block) or be unexported (golint)
    • Line 9: warning: exported type Metadata should have comment or be unexported (golint)
    • Line 17: warning: exported type CreatorMetadata should have comment or be unexported (golint)
    • Line 22: warning: exported type LifecycleMetadata should have comment or be unexported (golint)
    • Line 29: warning: exported type StackMetadata should have comment or be unexported (golint)
    • Line 33: warning: exported type RunImageMetadata should have comment or be unexported (golint)
    • pack/inspect_buildpack.go
    • Line 18: warning: exported type BuildpackInfo should have comment or be unexported (golint)
    • Line 26: warning: exported type InspectBuildpackOptions should have comment or be unexported (golint)
    • Line 32: warning: exported type ImgWrapper should have comment or be unexported (golint)
    • Line 36: warning: exported method ImgWrapper.Label should have comment or be unexported (golint)
    • Line 40: warning: exported method Client.InspectBuildpack should have comment or be unexported (golint)
    • pack/cmd/cmd.go
    • Line 26: warning: comment on exported function NewPackCommand should be of the form "NewPackCommand ..." (golint)
    • pack/internal/stack/mixins.go
    • Line 12: warning: exported const MixinsLabel should have comment or be unexported (golint)
    • Line 14: warning: exported function ValidateMixins should have comment or be unexported (golint)
    • Line 37: warning: exported function FindStageMixins should have comment or be unexported (golint)
    • pack/internal/inspectimage/writer/factory.go
    • Line 14: warning: exported type Factory should have comment or be unexported (golint)
    • Line 16: warning: exported type InspectImageWriter should have comment or be unexported (golint)
    • Line 25: warning: exported function NewFactory should have comment or be unexported (golint)
    • Line 29: warning: exported method Factory.Writer should have comment or be unexported (golint)
    • pack/internal/build/lifecycle_executor.go
    • Line 27: warning: exported type Builder should have comment or be unexported (golint)
    • Line 36: warning: exported type LifecycleExecutor should have comment or be unexported (golint)
    • Line 41: warning: exported type Cache should have comment or be unexported (golint)
    • Line 51: warning: exported type LifecycleOptions should have comment or be unexported (golint)
    • Line 74: warning: exported function NewLifecycleExecutor should have comment or be unexported (golint)
    • Line 78: warning: exported method LifecycleExecutor.Execute should have comment or be unexported (golint)
    • pack/inspect_builder.go
    • Line 59: warning: exported type BuilderInspectionConfig should have comment or be unexported (golint)
    • Line 63: warning: exported type BuilderInspectionModifier should have comment or be unexported (golint)
    • Line 65: warning: exported function WithDetectionOrderDepth should have comment or be unexported (golint)
    • pack/registry/type.go
    • Line 4: warning: exported const TypeGit should have comment (or a comment on this block) or be unexported (golint)
    • Line 8: warning: exported var Types should have comment or be unexported (golint)
    • pack/internal/builder/image_fetcher_wrapper.go
    • Line 11: warning: exported type ImageFetcher should have comment or be unexported (golint)
    • Line 18: warning: exported type ImageFetcherWrapper should have comment or be unexported (golint)
    • Line 22: warning: exported function NewImageFetcherWrapper should have comment or be unexported (golint)
    • Line 28: warning: exported method ImageFetcherWrapper.Fetch should have comment or be unexported (golint)
    • pack/internal/build/phase_factory.go
    • Line 5: warning: exported type RunnerCleaner should have comment or be unexported (golint)
    • Line 10: warning: exported type PhaseFactory should have comment or be unexported (golint)
    • Line 14: warning: exported type DefaultPhaseFactory should have comment or be unexported (golint)
    • Line 18: warning: exported type PhaseFactoryCreator should have comment or be unexported (golint)
    • Line 20: warning: exported function NewDefaultPhaseFactory should have comment or be unexported (golint)
    • Line 24: warning: exported method DefaultPhaseFactory.New should have comment or be unexported (golint)
    • pack/internal/build/fakes/cache.go
    • Line 9: warning: exported type FakeCache should have comment or be unexported (golint)
    • Line 19: warning: exported function NewFakeCache should have comment or be unexported (golint)
    • Line 23: warning: exported method FakeCache.Type should have comment or be unexported (golint)
    • Line 28: warning: exported method FakeCache.Clear should have comment or be unexported (golint)
    • Line 32: warning: exported method FakeCache.Name should have comment or be unexported (golint)
    • pack/internal/cache/consts.go
    • Line 4: warning: exported const Image should have comment (or a comment on this block) or be unexported (golint)
    • Line 8: warning: exported type Type should have comment or be unexported (golint)
    • pack/internal/builder/label_manager_provider.go
    • Line 3: warning: exported type LabelManagerProvider should have comment or be unexported (golint)
    • Line 5: warning: exported function NewLabelManagerProvider should have comment or be unexported (golint)
    • Line 9: warning: exported method LabelManagerProvider.BuilderLabelManager should have comment or be unexported (golint)
    • pack/testhelpers/assertions.go
    • Line 19: warning: exported type AssertionManager should have comment or be unexported (golint)
    • Line 23: warning: exported function NewAssertionManager should have comment or be unexported (golint)
    • Line 29: warning: exported method AssertionManager.TrimmedEq should have comment or be unexported (golint)
    • Line 48: warning: exported method AssertionManager.AssertTrimmedContains should have comment or be unexported (golint)
    • Line 67: warning: exported method AssertionManager.Equal should have comment or be unexported (golint)
    • Line 75: warning: exported method AssertionManager.NotEqual should have comment or be unexported (golint)
    • Line 83: warning: exported method AssertionManager.Nil should have comment or be unexported (golint)
    • Line 91: warning: exported method AssertionManager.Succeeds should have comment or be unexported (golint)
    • Line 97: warning: exported method AssertionManager.Fails should have comment or be unexported (golint)
    • Line 103: warning: exported method AssertionManager.NilWithMessage should have comment or be unexported (golint)
    • Line 111: warning: exported method AssertionManager.TrueWithMessage should have comment or be unexported (golint)
    • Line 119: warning: exported method AssertionManager.NotNil should have comment or be unexported (golint)
    • Line 127: warning: exported method AssertionManager.Contains should have comment or be unexported (golint)
    • Line 140: warning: exported method AssertionManager.EqualJSON should have comment or be unexported (golint)
    • Line 145: warning: exported method AssertionManager.ContainsJSON should have comment or be unexported (golint)
    • Line 199: warning: exported method AssertionManager.EqualYAML should have comment or be unexported (golint)
    • Line 204: warning: exported method AssertionManager.ContainsYAML should have comment or be unexported (golint)
    • Line 246: warning: exported method AssertionManager.EqualTOML should have comment or be unexported (golint)
    • Line 251: warning: exported method AssertionManager.ContainsTOML should have comment or be unexported (golint)
    • Line 302: warning: exported method AssertionManager.ContainsF should have comment or be unexported (golint)
    • Line 318: warning: exported method AssertionManager.ContainsAll should have comment or be unexported (golint)
    • Line 326: warning: exported method AssertionManager.Matches should have comment or be unexported (golint)
    • Line 334: warning: exported method AssertionManager.NoMatches should have comment or be unexported (golint)
    • Line 342: warning: exported method AssertionManager.MatchesAll should have comment or be unexported (golint)
    • Line 350: warning: exported method AssertionManager.NotContains should have comment or be unexported (golint)
    • Line 377: warning: exported method AssertionManager.ErrorContains should have comment or be unexported (golint)
    • Line 387: warning: exported method AssertionManager.ErrorWithMessage should have comment or be unexported (golint)
    • Line 394: warning: exported method AssertionManager.ErrorWithMessageF should have comment or be unexported (golint)
    • pack/internal/builder/writer/human_readable.go
    • Line 65: warning: exported type HumanReadable should have comment or be unexported (golint)
    • Line 67: warning: exported function NewHumanReadable should have comment or be unexported (golint)
    • Line 71: warning: exported method HumanReadable.Print should have comment or be unexported (golint)
    • pack/project/project.go
    • Line 13: warning: exported type Buildpack should have comment or be unexported (golint)
    • Line 19: warning: exported type EnvVar should have comment or be unexported (golint)
    • Line 24: warning: exported type Build should have comment or be unexported (golint)
    • Line 32: warning: exported type Project should have comment or be unexported (golint)
    • Line 37: warning: exported type Descriptor should have comment or be unexported (golint)
    • Line 43: warning: exported function ReadProjectDescriptor should have comment or be unexported (golint)
    • pack/pkg/archive/archive.go
    • Line 19: warning: exported var NormalizedDateTime should have comment or be unexported (golint)
    • Line 25: warning: exported type TarWriter should have comment or be unexported (golint)
    • Line 31: warning: exported type TarWriterFactory should have comment or be unexported (golint)
    • Line 37: warning: exported function DefaultTarWriterFactory should have comment or be unexported (golint)
    • Line 45: warning: exported function ReadDirAsTar should have comment or be unexported (golint)
    • Line 51: warning: exported function ReadZipAsTar should have comment or be unexported (golint)
    • Line 57: warning: exported function GenerateTar should have comment or be unexported (golint)
    • Line 61: warning: comment on exported function GenerateTarWithWriter should be of the form "GenerateTarWithWriter ..." (golint)
    • Line 121: warning: exported function CreateSingleFileTarReader should have comment or be unexported (golint)
    • Line 127: warning: exported function CreateSingleFileTar should have comment or be unexported (golint)
    • pack/internal/registry/github.go
    • Line 16: warning: exported type GithubIssue should have comment or be unexported (golint)
    • Line 21: warning: exported function CreateGithubIssue should have comment or be unexported (golint)
    • Line 50: warning: exported function CreateBrowserCmd should have comment or be unexported (golint)
    • Line 68: warning: exported function GetIssueURL should have comment or be unexported (golint)
    • pack/new_buildpack.go
    • Line 34: warning: exported type NewBuildpackOptions should have comment or be unexported (golint)
    • Line 51: warning: exported method Client.NewBuildpack should have comment or be unexported (golint)
    • pack/logging/prefix_writer.go
    • Line 20: warning: exported type PrefixWriterOption should have comment or be unexported (golint)
    • Line 22: warning: exported function WithReaderFactory should have comment or be unexported (golint)
    • Line 99: warning: comment on exported function ScanLinesKeepNewLine should be of the form "ScanLinesKeepNewLine ..." (golint)
    • pack/internal/commands/inspect_image.go
    • Line 14: warning: comment on exported type InspectImageWriterFactory should be of the form "InspectImageWriterFactory ..." (with optional leading article) (golint)
    • Line 19: warning: exported type InspectImageFlags should have comment or be unexported (golint)
    • Line 24: warning: exported function InspectImage should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!