Preparing report...

Report for github.com/carousell/Orion

A+    Excellent!    Found 28 issues across 97 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint76%

Golint is a linter for Go source code.

    • Orion/example/stringsvc2/service/service.go
    • Line 12: warning: exported function NewSvc should have comment or be unexported (golint)
    • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 43: warning: exported function DebugInterceptor should have comment or be unexported (golint)
    • Orion/utils/errors/notifier/notifier.go
    • Line 42: warning: exported type Tags should have comment or be unexported (golint)
    • Line 68: warning: exported function InitSentry should have comment or be unexported (golint)
    • Line 147: warning: exported function Notify should have comment or be unexported (golint)
    • Line 151: warning: exported function NotifyWithLevel should have comment or be unexported (golint)
    • Line 155: warning: exported function NotifyWithLevelAndSkip should have comment or be unexported (golint)
    • Line 266: warning: exported function NotifyWithExclude should have comment or be unexported (golint)
    • Line 291: warning: exported function NotifyOnPanic should have comment or be unexported (golint)
    • Line 335: warning: exported function Close should have comment or be unexported (golint)
    • Line 341: warning: exported function SetEnvironemnt should have comment or be unexported (golint)
    • Line 395: warning: exported function SetServerRoot should have comment or be unexported (golint)
    • Line 399: warning: exported function SetHostname should have comment or be unexported (golint)
    • Orion/utils/migrator/migratorcmdbase.go
    • Line 15: warning: comment on exported type MigrationClientFunc should be of the form "MigrationClientFunc ..." (with optional leading article) (golint)
    • Line 168: warning: exported function Execute should have comment or be unexported (golint)
    • Orion/utils/hystrixprometheus/hystrixprometheus.go
    • Line 9: warning: exported type PrometheusCollector should have comment or be unexported (golint)
    • Line 26: warning: exported function NewPrometheusCollector should have comment or be unexported (golint)
    • Line 152: warning: exported method PrometheusCollector.Collector should have comment or be unexported (golint)
    • Orion/utils/utils.go
    • Line 47: warning: should not use basic type string as key in context.WithValue (golint)
    • Line 51: warning: context.Context should be the first parameter of a function (golint)
    • Orion/utils/spanutils/spanutils.go
    • Line 193: warning: context.Context should be the first parameter of a function (golint)
    • Line 209: warning: context.Context should be the first parameter of a function (golint)
    • Line 209: warning: exported function GRPCTracingSpan should have comment or be unexported (golint)
    • Orion/orion/handlers/http/types.go
    • Line 38: warning: exported const ContentTypeJSON should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported const NRTxNameTypeMethod should have comment (or a comment on this block) or be unexported (golint)
    • Orion/utils/errors/errors.go
    • Line 165: warning: comment on exported function WrapWithStatus should be of the form "WrapWithStatus ..." (golint)
    • Line 175: warning: comment on exported function WrapWithSkipAndStatus should be of the form "WrapWithSkipAndStatus ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign98%

IneffAssign detects ineffectual assignments in Go code.


misspell97%

Misspell Finds commonly misspelled English words