Preparing report...

Report for github.com/cavaliergopher/rpm

A+    Excellent!    Found 7 issues across 16 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo81%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • rpm/header.go
    • Line 42: warning: cyclomatic complexity 35 of function readHeader() is high (> 15) (gocyclo)

golint68%

Golint is a linter for Go source code.

    • rpm/tag.go
    • Line 4: warning: exported const TagTypeNull should have comment (or a comment on this block) or be unexported (golint)
    • rpm/fileinfo.go
    • Line 71: warning: exported method FileInfo.Flags should have comment or be unexported (golint)
    • rpm/header.go
    • Line 9: warning: don't use underscores in Go names; const r_MaxHeaderSize should be rMaxHeaderSize (golint)
    • rpm/package.go
    • Line 85: warning: exported method Package.GPGSignature should have comment or be unexported (golint)
    • Line 92: warning: exported method Package.Name should have comment or be unexported (golint)
    • Line 96: warning: exported method Package.Version should have comment or be unexported (golint)
    • Line 100: warning: exported method Package.Release should have comment or be unexported (golint)
    • Line 104: warning: exported method Package.Epoch should have comment or be unexported (golint)
    • Line 108: warning: exported method Package.Requires should have comment or be unexported (golint)
    • Line 112: warning: exported method Package.Provides should have comment or be unexported (golint)
    • Line 116: warning: exported method Package.Conflicts should have comment or be unexported (golint)
    • Line 120: warning: exported method Package.Obsoletes should have comment or be unexported (golint)
    • Line 124: warning: exported method Package.Suggests should have comment or be unexported (golint)
    • Line 128: warning: exported method Package.Enhances should have comment or be unexported (golint)
    • Line 132: warning: exported method Package.Recommends should have comment or be unexported (golint)
    • Line 136: warning: exported method Package.Supplements should have comment or be unexported (golint)
    • Line 219: warning: exported method Package.Summary should have comment or be unexported (golint)
    • Line 223: warning: exported method Package.Description should have comment or be unexported (golint)
    • Line 227: warning: exported method Package.BuildTime should have comment or be unexported (golint)
    • Line 231: warning: exported method Package.BuildHost should have comment or be unexported (golint)
    • Line 235: warning: exported method Package.InstallTime should have comment or be unexported (golint)
    • Line 254: warning: exported method Package.Distribution should have comment or be unexported (golint)
    • Line 258: warning: exported method Package.Vendor should have comment or be unexported (golint)
    • Line 262: warning: exported method Package.GIFImage should have comment or be unexported (golint)
    • Line 266: warning: exported method Package.XPMImage should have comment or be unexported (golint)
    • Line 270: warning: exported method Package.License should have comment or be unexported (golint)
    • Line 274: warning: exported method Package.Packager should have comment or be unexported (golint)
    • Line 278: warning: exported method Package.Groups should have comment or be unexported (golint)
    • Line 282: warning: exported method Package.ChangeLog should have comment or be unexported (golint)
    • Line 286: warning: exported method Package.Source should have comment or be unexported (golint)
    • Line 290: warning: exported method Package.Patch should have comment or be unexported (golint)
    • Line 294: warning: exported method Package.URL should have comment or be unexported (golint)
    • Line 298: warning: exported method Package.OperatingSystem should have comment or be unexported (golint)
    • Line 302: warning: exported method Package.Architecture should have comment or be unexported (golint)
    • Line 306: warning: exported method Package.PreInstallScript should have comment or be unexported (golint)
    • Line 310: warning: exported method Package.PostInstallScript should have comment or be unexported (golint)
    • Line 314: warning: exported method Package.PreUninstallScript should have comment or be unexported (golint)
    • Line 318: warning: exported method Package.PostUninstallScript should have comment or be unexported (golint)
    • Line 322: warning: exported method Package.OldFilenames should have comment or be unexported (golint)
    • Line 326: warning: exported method Package.Icon should have comment or be unexported (golint)
    • Line 330: warning: exported method Package.SourceRPM should have comment or be unexported (golint)
    • Line 334: warning: exported method Package.RPMVersion should have comment or be unexported (golint)
    • Line 338: warning: exported method Package.Platform should have comment or be unexported (golint)
    • rpm/signature.go
    • Line 190: warning: comment on exported function OpenKeyRing should be of the form "OpenKeyRing ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!